Re: [Qemu-devel] [PATCH for-2.6?] nbd: Don't mishandle unaligned client requests

2016-04-22 Thread Kevin Wolf
Am 21.04.2016 um 18:28 hat Peter Maydell geschrieben: > On 21 April 2016 at 15:42, Eric Blake wrote: > > The NBD protocol does not (yet) force any alignment constraints > > on clients. Even though qemu NBD clients always send requests > > that are aligned to 512 bytes, we must be prepared for non

Re: [Qemu-devel] [Qemu-arm] [PATCH] bcm2835_property: use cached values when querying framebuffer

2016-04-22 Thread Peter Crosthwaite
On Thu, Apr 21, 2016 at 9:06 AM, Stephen Warren wrote: > On 04/21/2016 08:07 AM, Sylvain Garrigues wrote: >> >> Le 21 avr. 2016 à 15:42, Peter Maydell a écrit >> : >>> >>> >>> There may be something we can do here to make FreeBSD's life >>> easier, but we definitely can't do it on the eve of a re

Re: [Qemu-devel] [PATCH for-2.6?] nbd: Don't mishandle unaligned client requests

2016-04-22 Thread Fam Zheng
On Thu, 04/21 08:42, Eric Blake wrote: > The NBD protocol does not (yet) force any alignment constraints > on clients. Even though qemu NBD clients always send requests > that are aligned to 512 bytes, we must be prepared for non-qemu > clients that don't care about alignment (even if it means the

Re: [Qemu-devel] [Qemu-arm] [PATCH] bcm2835_property: use cached values when querying framebuffer

2016-04-22 Thread Gerd Hoffmann
Hi, > > Ideally as was mentioned earlier this would be done by simply executing the > > existing bootloader under emulation, rather than building all that code into > > qemu. However, in the Pi case, the bootloader runs on the VideoCore (a > > separate non-ARM CPU), so isn't (and likely won't be

Re: [Qemu-devel] [PATCH 02/11] pc-bios/s390-ccw: Use correct strip when cross-compiling

2016-04-22 Thread Cornelia Huck
On Thu, 21 Apr 2016 20:36:49 +0300 Sergey Fedorov wrote: > On 18/04/16 18:47, Sergey Fedorov wrote: > > On 18/04/16 18:34, Cornelia Huck wrote: > >> On Mon, 18 Apr 2016 16:51:16 +0200 > >> Cornelia Huck wrote: > >> > >>> On Thu, 7 Apr 2016 18:53:44 +0300 > >>> Sergey Fedorov wrote: > >>> > >>>

Re: [Qemu-devel] [PATCH v14 18/19] qapi: Simplify semantics of visit_next_list()

2016-04-22 Thread Markus Armbruster
Markus Armbruster writes: [...] >> diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c >> index 797973a..77dd1a7 100644 >> --- a/qapi/string-input-visitor.c >> +++ b/qapi/string-input-visitor.c >> @@ -25,8 +25,6 @@ struct StringInputVisitor >> { >> Visitor visitor; >> >>

Re: [Qemu-devel] [PATCH for-2.6?] nbd: Don't mishandle unaligned client requests

2016-04-22 Thread Peter Maydell
On 22 April 2016 at 08:03, Kevin Wolf wrote: > Am 21.04.2016 um 18:28 hat Peter Maydell geschrieben: >> On 21 April 2016 at 15:42, Eric Blake wrote: >> > The NBD protocol does not (yet) force any alignment constraints >> > on clients. Even though qemu NBD clients always send requests >> > that a

Re: [Qemu-devel] [PATCH V2 RFC] fixup! virtio: convert to use DMA api

2016-04-22 Thread Stefan Hajnoczi
On Thu, Apr 21, 2016 at 06:11:40PM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 21, 2016 at 03:56:53PM +0100, Stefan Hajnoczi wrote: > > On Thu, Apr 21, 2016 at 04:43:45PM +0300, Michael S. Tsirkin wrote: > > > This adds a flag to enable/disable bypassing the IOMMU by > > > virtio devices. > > >

Re: [Qemu-devel] [PATCH v3 01/11] compiler.h: add QEMU_ALIGNED() to enforce struct alignment

2016-04-22 Thread Alex Bennée
Emilio G. Cota writes: > Reviewed-by: Richard Henderson > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > include/qemu/compiler.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h > index 8f1cc7b..1978ddc 100644 > --

Re: [Qemu-devel] [PATCH v3 04/11] include/processor.h: define cpu_relax()

2016-04-22 Thread Alex Bennée
Emilio G. Cota writes: > Taken from the linux kernel. > > Reviewed-by: Richard Henderson > Signed-off-by: Emilio G. Cota License header notwithstanding: Reviewed-by: Alex Bennée > --- > include/qemu/processor.h | 28 > 1 file changed, 28 insertions(+) > crea

Re: [Qemu-devel] [PATCH v3 01/11] compiler.h: add QEMU_ALIGNED() to enforce struct alignment

2016-04-22 Thread Peter Maydell
On 20 April 2016 at 00:07, Emilio G. Cota wrote: > Reviewed-by: Richard Henderson > Signed-off-by: Emilio G. Cota > --- > include/qemu/compiler.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h > index 8f1cc7b..1978ddc 100644 > --- a/

Re: [Qemu-devel] [PATCH for-2.6 2/3] mirror: Skip BH for mirror_exit if in main loop

2016-04-22 Thread Fam Zheng
On Fri, 04/22 14:35, Fam Zheng wrote: > As a bandage, this patch undoes the change of 5a7e7a0bad17 in > non-dataplane case, and calls mirror_replace directly in mirror_run. mirror_exit minus mirror_replace was kept in the BH because it's not safe to call in coroutine. After discussing with kwolf o

Re: [Qemu-devel] [PATCH kernel 1/2] mm: add the related functions to build the free page bitmap

2016-04-22 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Tue, Apr 19, 2016 at 03:02:09PM +, Li, Liang Z wrote: > > > On Tue, 2016-04-19 at 22:34 +0800, Liang Li wrote: > > > > The free page bitmap will be sent to QEMU through virtio interface and > > > > used for live migration optimization. > > > >

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-22 Thread Sergey Fedorov
On 22/04/16 00:54, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 21/04/16 19:16, Sergey Fedorov wrote: >>> On 21/04/16 18:55, Alex Bennée wrote: Sergey Fedorov writes: > On 18/04/16 20:51, Sergey Fedorov wrote: >> On 18/04/16 20:17, Alex Bennée wrote: >>> Sergey Fedoro

Re: [Qemu-devel] Performance regression using KVM/ARM

2016-04-22 Thread Christoffer Dall
On Thu, Apr 21, 2016 at 09:50:05PM +0200, Alexander Graf wrote: > > > On 21.04.16 18:23, Christoffer Dall wrote: > > Hi, > > > > Commit 9fac18f (oslib: allocate PROT_NONE pages on top of RAM, > > 2015-09-10) had the unfortunate side effect that memory slots registered > > with KVM no longer cont

Re: [Qemu-devel] Performance regression using KVM/ARM

2016-04-22 Thread Christoffer Dall
Hi Laszlo, On Thu, Apr 21, 2016 at 11:58:07PM +0200, Laszlo Ersek wrote: > On 04/21/16 18:23, Christoffer Dall wrote: > > Hi, > > > > Commit 9fac18f (oslib: allocate PROT_NONE pages on top of RAM, > > 2015-09-10) had the unfortunate side effect that memory slots registered > > with KVM no longer

Re: [Qemu-devel] Bug (Regression?) in hw/usb/hcd-uhci.c causes failure of ICH9 host controller and attached Xbox 360 Wireless Receiver

2016-04-22 Thread Gerd Hoffmann
Hi, > Starting the guest VM with the UHCI debug patch and the device unplugged > results in these two lines just after it starts: > > uhci_handle_td: invalid pid token 0x0, raising HCPERR > uhci_handle_td: invalid pid token 0x0, raising HCPERR > > and then the same line repeated 18 times once

Re: [Qemu-devel] Bug (Regression?) in hw/usb/hcd-uhci.c causes failure of ICH9 host controller and attached Xbox 360 Wireless Receiver

2016-04-22 Thread Gerd Hoffmann
Hi, > I should add that for some unknown reason, my host machine sometimes > changes the host bus enumeration that has the USB 2.0 hub hanging off > it, that has the pass-through devices attached to it. Probably because linux probes the pci devices in parallel, so whoever finished first gets

Re: [Qemu-devel] Performance regression using KVM/ARM

2016-04-22 Thread Alexander Graf
On 04/22/2016 12:01 PM, Christoffer Dall wrote: On Thu, Apr 21, 2016 at 09:50:05PM +0200, Alexander Graf wrote: On 21.04.16 18:23, Christoffer Dall wrote: Hi, Commit 9fac18f (oslib: allocate PROT_NONE pages on top of RAM, 2015-09-10) had the unfortunate side effect that memory slots registere

Re: [Qemu-devel] [PATCH COLO-Frame v16 13/35] COLO: Load VMState into qsb before restore it

2016-04-22 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > We should not destroy the state of SVM (Secondary VM) until we receive the > whole > state from the PVM (Primary VM), in case the primary fails in the middle of > sending > the state, so, here we cache the device state in Secondary before

Re: [Qemu-devel] Performance regression using KVM/ARM

2016-04-22 Thread Christoffer Dall
On Fri, Apr 22, 2016 at 12:06:52PM +0200, Alexander Graf wrote: > On 04/22/2016 12:01 PM, Christoffer Dall wrote: > >On Thu, Apr 21, 2016 at 09:50:05PM +0200, Alexander Graf wrote: > >> > >>On 21.04.16 18:23, Christoffer Dall wrote: > >>>Hi, > >>> > >>>Commit 9fac18f (oslib: allocate PROT_NONE page

Re: [Qemu-devel] Performance regression using KVM/ARM

2016-04-22 Thread Peter Maydell
On 22 April 2016 at 11:15, Christoffer Dall wrote: > Peter just pointed me to a change I remember doing for ARM, so perhaps > this fix is the right one? > > > diff --git a/util/oslib-posix.c b/util/oslib-posix.c > index d25f671..a36e734 100644 > --- a/util/oslib-posix.c > +++ b/util/oslib-posix.c

Re: [Qemu-devel] [PATCH for-2.6?] nbd: Don't mishandle unaligned client requests

2016-04-22 Thread Kevin Wolf
Am 22.04.2016 um 11:29 hat Peter Maydell geschrieben: > On 22 April 2016 at 08:03, Kevin Wolf wrote: > > Am 21.04.2016 um 18:28 hat Peter Maydell geschrieben: > >> On 21 April 2016 at 15:42, Eric Blake wrote: > >> > The NBD protocol does not (yet) force any alignment constraints > >> > on clients

[Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts

2016-04-22 Thread Daniel P. Berrange
The iSCSI block driver has ability to lookup various options, in particular authentication info, specified by the separate -iscsi argument. It currently uses the iSCSI IQN as the ID value for this lookup, however, this does not work for common iSCSI IQNs as they contain characters such as ':' which

[Qemu-devel] [PATCH for-2.6] Fix association of -drive & -iscsi args

2016-04-22 Thread Daniel P. Berrange
The iSCSI block driver is a bit strange in that it requires a separate -iscsi arg to pass various values, instead of accepting them directly with the -drive argument. Pino is working on fixing that for 2.7: https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg02011.html The problem with the

Re: [Qemu-devel] Performance regression using KVM/ARM

2016-04-22 Thread Christoffer Dall
On Fri, Apr 22, 2016 at 11:17:47AM +0100, Peter Maydell wrote: > On 22 April 2016 at 11:15, Christoffer Dall > wrote: > > Peter just pointed me to a change I remember doing for ARM, so perhaps > > this fix is the right one? > > > > > > diff --git a/util/oslib-posix.c b/util/oslib-posix.c > > inde

Re: [Qemu-devel] Bug (Regression?) in hw/usb/hcd-uhci.c causes failure of ICH9 host controller and attached Xbox 360 Wireless Receiver

2016-04-22 Thread joe
On 2016-04-22 11:04, Gerd Hoffmann wrote: Hi, Starting the guest VM with the UHCI debug patch and the device unplugged results in these two lines just after it starts: uhci_handle_td: invalid pid token 0x0, raising HCPERR uhci_handle_td: invalid pid token 0x0, raising HCPERR and then the sam

[Qemu-devel] [PATCH] util: align memory allocations to 2M on AArch64

2016-04-22 Thread Christoffer Dall
For KVM to use Transparent Huge Pages (THP) we have to ensure that the alignment of the userspace address of the KVM memory slot and the IPA that the guest sees for a memory region have the same offset from the 2M huge page size boundary. One way to achieve this is to always align the IPA region a

Re: [Qemu-devel] [PATCH COLO-Frame v16 for-2.7 00/35] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-04-22 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > This is the 16th version of COLO (Still only support periodic checkpoint). OK, so the main migration code in here looks OK now (still need one block R-b's and the net R-b's from Jason) - which of the other COLO patch series does this depend

[Qemu-devel] [PATCH 2.6 candidate] usb/uhci: move pid check

2016-04-22 Thread Gerd Hoffmann
commit "5f77e06 usb: add pid check at the first of uhci_handle_td()" moved the pid verification to the start of the uhci_handle_td function, to simplify the error handling (we don't have to free stuff which we didn't allocate in the first place ...). Problem is now the check fires too often, it ra

Re: [Qemu-devel] I/O errors reported to guest for raw-image-file backed /dev/vda - but host sees no I/O errors

2016-04-22 Thread Lutz Vieweg
On 04/21/2016 05:54 PM, Lutz Vieweg wrote: And indeed, the errors occured exactly at the time a backup procedure was preparing a read-only snapshot with "btrfs subvolume snapshot -r" - so until I can upgrade to a mainline kernel including the fix, I'll pause the qemu process while the "btrfs subv

[Qemu-devel] [PATCH v2 for-2.6 0/5] block: Fix assertion failure at mirror exit

2016-04-22 Thread Fam Zheng
v2: Go along the is_external appraoch. [Kevin] I tested this series survives the "snapshot + commit" loop reproducer with both bonnie++ and RHEL installation in the guest. This supersedes the "virtio: Register host notifier handler as external" patch from yesterday. The bug was initially reporte

[Qemu-devel] [PATCH v2 for-2.6 4/5] aio-posix: Skip external nodes in aio_dispatch

2016-04-22 Thread Fam Zheng
aio_poll doesn't poll the external nodes so this should never be true, but aio_ctx_dispatch may get notified by the events from GSource. To make bdrv_drained_begin effective in main loop, we should check the is_external flag here too. This could result in a few busy polls because the fd is left un

[Qemu-devel] [PATCH v2 for-2.6 1/5] iohandler: Introduce iohandler_get_aio_context

2016-04-22 Thread Fam Zheng
Signed-off-by: Fam Zheng --- include/qemu/main-loop.h | 1 + iohandler.c | 6 ++ stubs/Makefile.objs | 1 + stubs/iohandler.c| 8 4 files changed, 16 insertions(+) create mode 100644 stubs/iohandler.c diff --git a/include/qemu/main-loop.h b/include/qemu/ma

[Qemu-devel] [PATCH v2 for-2.6 2/5] event-notifier: Add "is_external" parameter

2016-04-22 Thread Fam Zheng
All callers pass "false" keeping the old semantics. The windows implementation doesn't distinguish the flag yet. On posix, it is passed down to the underlying aio context. Signed-off-by: Fam Zheng --- hw/usb/ccid-card-emulated.c | 2 +- hw/virtio/virtio.c| 8 include/qem

[Qemu-devel] [PATCH v2 for-2.6 3/5] virtio: Mark host notifiers as external

2016-04-22 Thread Fam Zheng
The effect of this change is the block layer drained section can work, for example when mirror job is being completed. Signed-off-by: Fam Zheng --- hw/virtio/virtio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index fffa09f..30

Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts

2016-04-22 Thread Kevin Wolf
Am 22.04.2016 um 12:24 hat Daniel P. Berrange geschrieben: > The iSCSI block driver has ability to lookup various options, in > particular authentication info, specified by the separate -iscsi > argument. It currently uses the iSCSI IQN as the ID value for this > lookup, however, this does not work

[Qemu-devel] [PATCH v2 for-2.6 5/5] mirror: Workaround for unexpected iohandler events during completion

2016-04-22 Thread Fam Zheng
Commit 5a7e7a0ba moved mirror_exit to a BH handler but didn't add any protection against new requests that could sneak in just before the BH is dispatched. For example (assuming a code base at that commit): main_loop_wait # 1 os_host_main_loop_wait g_main_context_disp

[Qemu-devel] [PATCH v2] util: align memory allocations to 2M on AArch64

2016-04-22 Thread Christoffer Dall
For KVM to use Transparent Huge Pages (THP) we have to ensure that the alignment of the userspace address of the KVM memory slot and the IPA that the guest sees for a memory region have the same offset from the 2M huge page size boundary. One way to achieve this is to always align the IPA region a

Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts

2016-04-22 Thread Peter Lieven
Am 22.04.2016 um 12:59 schrieb Kevin Wolf: > Am 22.04.2016 um 12:24 hat Daniel P. Berrange geschrieben: >> The iSCSI block driver has ability to lookup various options, in >> particular authentication info, specified by the separate -iscsi >> argument. It currently uses the iSCSI IQN as the ID valu

Re: [Qemu-devel] [PATCH v2 1/3] xenfb: use the correct condition to avoid excessive looping

2016-04-22 Thread Anthony PERARD
On Tue, Apr 12, 2016 at 10:12:28AM -0700, Stefano Stabellini wrote: > On Tue, 12 Apr 2016, Wei Liu wrote: > > In commit ac0487e1 ("xenfb.c: avoid expensive loops when prod <= > > out_cons"), ">=" was used. In fact, a full ring is a legit state. > > Correct the test to use ">". > > > > Reported-by:

Re: [Qemu-devel] Performance regression using KVM/ARM

2016-04-22 Thread Andrew Jones
On Fri, Apr 22, 2016 at 12:26:52PM +0200, Christoffer Dall wrote: > On Fri, Apr 22, 2016 at 11:17:47AM +0100, Peter Maydell wrote: > > On 22 April 2016 at 11:15, Christoffer Dall > > wrote: > > > Peter just pointed me to a change I remember doing for ARM, so perhaps > > > this fix is the right on

Re: [Qemu-devel] [PATCH v2 1/3] xenfb: use the correct condition to avoid excessive looping

2016-04-22 Thread Wei Liu
On Fri, Apr 22, 2016 at 12:16:09PM +0100, Anthony PERARD wrote: > On Tue, Apr 12, 2016 at 10:12:28AM -0700, Stefano Stabellini wrote: > > On Tue, 12 Apr 2016, Wei Liu wrote: > > > In commit ac0487e1 ("xenfb.c: avoid expensive loops when prod <= > > > out_cons"), ">=" was used. In fact, a full ring

Re: [Qemu-devel] [PATCH for-2.6?] nbd: Don't mishandle unaligned client requests

2016-04-22 Thread Peter Maydell
On 22 April 2016 at 11:19, Kevin Wolf wrote: > Am 22.04.2016 um 11:29 hat Peter Maydell geschrieben: >> On 22 April 2016 at 08:03, Kevin Wolf wrote: >> > Peter, do you want a pull request (which I would have to do because >> > Paolo is away) or are you going to apply the patch directly? >> >> If

Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer

2016-04-22 Thread Andrew Baumann
> From: Qemu-devel [mailto:qemu-devel- > bounces+andrew.baumann=microsoft@nongnu.org] On Behalf Of Sylvain > Garrigues > Sent: Thursday, 21 April 2016 12:42 > > As the framebuffer settings are copied into the result message before it is > reconfigured, inconsistent behavior can happen when, fo

Re: [Qemu-devel] Performance regression using KVM/ARM

2016-04-22 Thread Alexander Graf
On 04/22/2016 01:16 PM, Andrew Jones wrote: On Fri, Apr 22, 2016 at 12:26:52PM +0200, Christoffer Dall wrote: On Fri, Apr 22, 2016 at 11:17:47AM +0100, Peter Maydell wrote: On 22 April 2016 at 11:15, Christoffer Dall wrote: Peter just pointed me to a change I remember doing for ARM, so perhap

Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer

2016-04-22 Thread Sylvain Garrigues
Le 22 avr. 2016 à 13:22, Andrew Baumann a écrit : >> +stl_le_phys(&s->dma_as, value + 16, tmp_xres * tmp_yres * >> + (tmp_bpp >> 3)); > > Personal style nit: I prefer * 8 rather than >> 3, because it's more > immediately obvious what you're computing, a trivial optimisation for the

Re: [Qemu-devel] [PATCH 01/13] migration: create Migration Incoming State at init time

2016-04-22 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/migration.c | 38 +- > migration/savevm.c| 3 ++- > 2 files changed, 19 insertions(+), 22 deletions(-) > > diff --git a/mi

Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer

2016-04-22 Thread Andrew Baumann
> From: Sylvain Garrigues [mailto:sylv...@sylvaingarrigues.com] > Sent: Friday, 22 April 2016 13:27 > > Le 22 avr. 2016 à 13:22, Andrew Baumann > a écrit : > >> +stl_le_phys(&s->dma_as, value + 16, tmp_xres * tmp_yres > >> + * (tmp_bpp >> 3)); > > > > Personal style nit: I prefer * 8

Re: [Qemu-devel] [PATCH 03/11] tci: Make direct jump patching thread-safe

2016-04-22 Thread Sergey Fedorov
On 20/04/16 16:14, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 20/04/16 12:42, Alex Bennée wrote: >>> Sergey Fedorov writes: diff --git a/tcg/tci/tcg-target.inc.c b/tcg/tci/tcg-target.inc.c index 4afe4d7a8d59..7e6180e62898 100644 --- a/tcg/tci/tcg-target.inc.c +++ b/tc

Re: [Qemu-devel] [PATCH v14 18/19] qapi: Simplify semantics of visit_next_list()

2016-04-22 Thread Markus Armbruster
Markus Armbruster writes: > Markus Armbruster writes: > > [...] >>> diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c >>> index 797973a..77dd1a7 100644 >>> --- a/qapi/string-input-visitor.c >>> +++ b/qapi/string-input-visitor.c >>> @@ -25,8 +25,6 @@ struct StringInputVisitor

[Qemu-devel] [PATCH] tests/string-input-visitor: Add negative integer tests

2016-04-22 Thread Markus Armbruster
Add two negative tests, one for int and one for int16List. The latter exposes a bug: nonsensical input results in an empty list instead of an error. Signed-off-by: Markus Armbruster --- tests/test-string-input-visitor.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tests/

Re: [Qemu-devel] [PATCH 05/13] migration: Create x-multifd-threads parameter

2016-04-22 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Indicates the number of threads that we would create. By default we > create 2 threads. Is a migration with the multifd capability set and x_multifd_threads=1 the same as a normal migration, or I'm thinking it's still different in that it has a separ

Re: [Qemu-devel] [PATCH v2 for-2.6 4/5] aio-posix: Skip external nodes in aio_dispatch

2016-04-22 Thread Kevin Wolf
Am 22.04.2016 um 12:56 hat Fam Zheng geschrieben: > aio_poll doesn't poll the external nodes so this should never be true, > but aio_ctx_dispatch may get notified by the events from GSource. To > make bdrv_drained_begin effective in main loop, we should check the > is_external flag here too. > > T

[Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer

2016-04-22 Thread Sylvain Garrigues
As the framebuffer settings are copied into the result message before it is reconfigured, inconsistent behavior can happen when, for instance, you set with a single message the width, height, and depth, and ask at the same time to allocate the buffer and get the pitch and the size. In this case, t

Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts

2016-04-22 Thread Daniel P. Berrange
On Fri, Apr 22, 2016 at 01:13:42PM +0200, Peter Lieven wrote: > Am 22.04.2016 um 12:59 schrieb Kevin Wolf: > > Am 22.04.2016 um 12:24 hat Daniel P. Berrange geschrieben: > >> The iSCSI block driver has ability to lookup various options, in > >> particular authentication info, specified by the separ

Re: [Qemu-devel] [PATCH v2 for-2.6 4/5] aio-posix: Skip external nodes in aio_dispatch

2016-04-22 Thread Fam Zheng
On Fri, 04/22 13:38, Kevin Wolf wrote: > Am 22.04.2016 um 12:56 hat Fam Zheng geschrieben: > > aio_poll doesn't poll the external nodes so this should never be true, > > but aio_ctx_dispatch may get notified by the events from GSource. To > > make bdrv_drained_begin effective in main loop, we shoul

Re: [Qemu-devel] [Qemu-arm] [PATCH] bcm2835_property: use cached values when querying framebuffer

2016-04-22 Thread Andrew Baumann
Hi all, > From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Friday, 22 April 2016 09:18 > > On Thu, Apr 21, 2016 at 9:06 AM, Stephen Warren > wrote: > > On 04/21/2016 08:07 AM, Sylvain Garrigues wrote: > >> > >> Le 21 avr. 2016 à 15:42, Peter Maydell a > >> écrit > >> : > >>>

Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts

2016-04-22 Thread Markus Armbruster
Kevin Wolf writes: > Am 22.04.2016 um 12:24 hat Daniel P. Berrange geschrieben: >> The iSCSI block driver has ability to lookup various options, in >> particular authentication info, specified by the separate -iscsi >> argument. It currently uses the iSCSI IQN as the ID value for this >> lookup,

Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts

2016-04-22 Thread Kevin Wolf
Am 22.04.2016 um 13:43 hat Daniel P. Berrange geschrieben: > On Fri, Apr 22, 2016 at 01:13:42PM +0200, Peter Lieven wrote: > > Am 22.04.2016 um 12:59 schrieb Kevin Wolf: > > > Am 22.04.2016 um 12:24 hat Daniel P. Berrange geschrieben: > > >> The iSCSI block driver has ability to lookup various opti

Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts

2016-04-22 Thread Daniel P. Berrange
On Fri, Apr 22, 2016 at 01:53:47PM +0200, Kevin Wolf wrote: > Am 22.04.2016 um 13:43 hat Daniel P. Berrange geschrieben: > > On Fri, Apr 22, 2016 at 01:13:42PM +0200, Peter Lieven wrote: > > > Am 22.04.2016 um 12:59 schrieb Kevin Wolf: > > > > Am 22.04.2016 um 12:24 hat Daniel P. Berrange geschrieb

Re: [Qemu-devel] [Qemu-arm] [PATCH] bcm2835_property: use cached values when querying framebuffer

2016-04-22 Thread Andrew Baumann
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, 22 April 2016 09:46 > > Alternatively we can just go for a later boot loader stage, i.e. put a u-boot > build > for rpi2 to pc-bios/ (we already have one for ppc there) and run that by > default. > > Our sdcard emulation seems to h

Re: [Qemu-devel] [PATCH v2] util: align memory allocations to 2M on AArch64

2016-04-22 Thread Peter Maydell
On 22 April 2016 at 12:12, Christoffer Dall wrote: > For KVM to use Transparent Huge Pages (THP) we have to ensure that the > alignment of the userspace address of the KVM memory slot and the IPA > that the guest sees for a memory region have the same offset from the 2M > huge page size boundary.

Re: [Qemu-devel] [PATCH 13/13] migration: [HACK]Transfer pages over new channels

2016-04-22 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We switch for sending the page number to send real pages. > > [HACK] > How we calculate the bandwidth is beyond repair, there is a hack there > that would work for x86 and archs thta have 4kb pages. > > If you are having a nice day just go to migrati

Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts

2016-04-22 Thread Peter Maydell
On 22 April 2016 at 12:55, Daniel P. Berrange wrote: > On Fri, Apr 22, 2016 at 01:53:47PM +0200, Kevin Wolf wrote: >> -iscsi is a weird thing anyway. We should do things the usual way, with >> a proper BlockdevOptionsIscsi QAPI structure. Introducing a new API in >> 2.6 when we know we'll deprecat

Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer

2016-04-22 Thread Sylvain Garrigues
Le 22 avr. 2016 à 13:30, Andrew Baumann a écrit : > But I won't be merging this patch (hopefully Peter can do that?), so it's > probably best if you make the tweak and resend with my Reviewed-by. Made the tweak and resent the patch with your reviewed-by. Have a good day.

Re: [Qemu-devel] [PATCH v4.1] Add optionrom compatible with fw_cfg DMA version

2016-04-22 Thread Richard W.M. Jones
On Tue, Apr 05, 2016 at 09:29:28AM +0200, Gerd Hoffmann wrote: > On Mo, 2016-04-04 at 16:21 +0100, Richard W.M. Jones wrote: > > On Mon, Apr 04, 2016 at 04:02:04PM +0100, Stefan Hajnoczi wrote: > > > (1) initrd loading is broken, kernel complains it finds only gibberish: > > > > > > [0.934

Re: [Qemu-devel] [PATCH v5 1/5] ARM: Virt: Add /distance-map node for NUMA

2016-04-22 Thread Andrew Jones
On Thu, Apr 21, 2016 at 02:23:50PM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > This /distance-map node is used to describe the accessing distance > between NUMA nodes. > > Signed-off-by: Shannon Zhao > --- > hw/arm/virt.c | 30 ++ > 1 file changed, 30 insert

Re: [Qemu-devel] [RFC 00/13] Multiple fd migration support

2016-04-22 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Hi > > This patch series is "an" initial implementation of multiple fd migration. > This is to get something out for others to comment, it is not finished at all. I've had a quick skim: a) I think mst is right about the risk of getting stale pages

Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts

2016-04-22 Thread Daniel P. Berrange
On Fri, Apr 22, 2016 at 01:10:40PM +0100, Peter Maydell wrote: > On 22 April 2016 at 12:55, Daniel P. Berrange wrote: > > On Fri, Apr 22, 2016 at 01:53:47PM +0200, Kevin Wolf wrote: > >> -iscsi is a weird thing anyway. We should do things the usual way, with > >> a proper BlockdevOptionsIscsi QAPI

Re: [Qemu-devel] [PATCH v5 2/5] ARM: Virt: Set numa-node-id for CPUs

2016-04-22 Thread Andrew Jones
On Thu, Apr 21, 2016 at 02:23:51PM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > Add a numa-node-id property to specify NUMA information for CPUs. > > Signed-off-by: Shannon Zhao > --- > hw/arm/virt.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/hw/arm/virt.c b/hw/arm

Re: [Qemu-devel] [PATCH v5 3/5] ARM: Add numa-node-id for /memory node

2016-04-22 Thread Andrew Jones
On Thu, Apr 21, 2016 at 02:23:52PM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > When specifying NUMA for ARM machine, generate /memory node according to > NUMA topology. > > Signed-off-by: Shannon Zhao > --- > hw/arm/boot.c | 31 ++- > 1 file changed, 30 inse

Re: [Qemu-devel] [PATCH 03/11] tci: Make direct jump patching thread-safe

2016-04-22 Thread Alex Bennée
Sergey Fedorov writes: > On 20/04/16 16:14, Alex Bennée wrote: >> Sergey Fedorov writes: >> >>> On 20/04/16 12:42, Alex Bennée wrote: Sergey Fedorov writes: > diff --git a/tcg/tci/tcg-target.inc.c b/tcg/tci/tcg-target.inc.c > index 4afe4d7a8d59..7e6180e62898 100644 > --- a/tcg

Re: [Qemu-devel] [PATCH v3 07/11] tb hash: hash phys_pc, pc, and flags with xxhash

2016-04-22 Thread Alex Bennée
Emilio G. Cota writes: > For some workloads such as arm bootup, tb_phys_hash is performance-critical. > The is due to the high frequency of accesses to the hash table, originated > by (frequent) TLB flushes that wipe out the cpu-private tb_jmp_cache's. > More info: > https://lists.nongnu.org/a

Re: [Qemu-devel] [PATCH v3 06/11] exec: add tb_hash_func5, derived from xxhash

2016-04-22 Thread Alex Bennée
Emilio G. Cota writes: > This will be used by upcoming changes for hashing the tb hash. > > Add this into a separate file to include the copyright notice from > xxhash. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > include/exec/tb-hash-xx.h | 94 > +

[Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg DMA version

2016-04-22 Thread Richard W.M. Jones
From: Marc Marí This optionrom is based on linuxboot.S. Signed-off-by: Marc Marí Signed-off-by: Richard W.M. Jones --- .gitignore| 4 + hw/i386/pc.c | 9 +- hw/nvram/fw_cfg.c | 2 +- include/hw/nvram/fw_cfg.h | 1 +

[Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg DMA version

2016-04-22 Thread Richard W.M. Jones
v4 -> v5: * Fix the initrd loading problem by fixing the get_e801_addr function so it really reads the values from the BIOS. Previously the function always returned 16MB, and so it only happened to work for initrd sizes < ~15MB, and broke for anything larger. Now the function is fixed, I tes

Re: [Qemu-devel] [PATCH v5 5/5] hw/arm/virt-acpi-build: Generate SRAT table

2016-04-22 Thread Andrew Jones
On Thu, Apr 21, 2016 at 02:23:54PM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > To support NUMA, it needs to generate SRAT ACPI table. > > Signed-off-by: Shannon Zhao > --- > hw/arm/virt-acpi-build.c | 58 > > 1 file changed, 58 insertio

Re: [Qemu-devel] [PATCH v5 4/5] include/hw/acpi/acpi-defs: Add GICC Affinity Structure

2016-04-22 Thread Andrew Jones
On Thu, Apr 21, 2016 at 02:23:53PM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > --- > hw/i386/acpi-build.c| 2 +- > include/hw/acpi/acpi-defs.h | 15 ++- > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/acpi-

Re: [Qemu-devel] [PATCH 1/3] target-arm: kvm64: set guest PMUv3 feature bit if supported

2016-04-22 Thread Andrew Jones
On Fri, Mar 25, 2016 at 05:46:19PM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > Check if kvm supports guest PMUv3. If so, set the corresponding feature > bit for vcpu. > > Signed-off-by: Shannon Zhao > --- > linux-headers/asm-arm64/kvm.h | 6 ++ > linux-headers/linux/kvm.h | 2 +

Re: [Qemu-devel] [PATCH v2 for-2.6 3/5] virtio: Mark host notifiers as external

2016-04-22 Thread Michael S. Tsirkin
On Fri, Apr 22, 2016 at 06:56:02PM +0800, Fam Zheng wrote: > The effect of this change is the block layer drained section can work, > for example when mirror job is being completed. > > Signed-off-by: Fam Zheng Reviewed-by: Michael S. Tsirkin > --- > hw/virtio/virtio.c | 4 ++-- > 1 file cha

Re: [Qemu-devel] [PATCH v2 for-2.6 2/5] event-notifier: Add "is_external" parameter

2016-04-22 Thread Michael S. Tsirkin
On Fri, Apr 22, 2016 at 06:56:01PM +0800, Fam Zheng wrote: > All callers pass "false" keeping the old semantics. The windows > implementation doesn't distinguish the flag yet. On posix, it is passed > down to the underlying aio context. > > Signed-off-by: Fam Zheng Reviewed-by: Michael S. Tsirki

Re: [Qemu-devel] [PATCH v2 for-2.6 1/5] iohandler: Introduce iohandler_get_aio_context

2016-04-22 Thread Michael S. Tsirkin
On Fri, Apr 22, 2016 at 06:56:00PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng Reviewed-by: Michael S. Tsirkin > --- > include/qemu/main-loop.h | 1 + > iohandler.c | 6 ++ > stubs/Makefile.objs | 1 + > stubs/iohandler.c| 8 > 4 files changed, 16

Re: [Qemu-devel] [PATCH v2 for-2.6 0/5] block: Fix assertion failure at mirror exit

2016-04-22 Thread Michael S. Tsirkin
On Fri, Apr 22, 2016 at 06:55:59PM +0800, Fam Zheng wrote: > v2: Go along the is_external appraoch. [Kevin] > > I tested this series survives the "snapshot + commit" loop reproducer with > both > bonnie++ and RHEL installation in the guest. > > This supersedes the "virtio: Register host notifier

[Qemu-devel] [PATCH v3 for-2.6 3/5] virtio: Mark host notifiers as external

2016-04-22 Thread Fam Zheng
The effect of this change is the block layer drained section can work, for example when mirror job is being completed. Signed-off-by: Fam Zheng --- hw/virtio/virtio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index fffa09f..30

[Qemu-devel] [PATCH v3 for-2.6 5/5] mirror: Workaround for unexpected iohandler events during completion

2016-04-22 Thread Fam Zheng
Commit 5a7e7a0ba moved mirror_exit to a BH handler but didn't add any protection against new requests that could sneak in just before the BH is dispatched. For example (assuming a code base at that commit): main_loop_wait # 1 os_host_main_loop_wait g_main_context_disp

[Qemu-devel] [PATCH v3 for-2.6 2/5] event-notifier: Add "is_external" parameter

2016-04-22 Thread Fam Zheng
All callers pass "false" keeping the old semantics. The windows implementation doesn't distinguish the flag yet. On posix, it is passed down to the underlying aio context. Signed-off-by: Fam Zheng --- hw/usb/ccid-card-emulated.c | 2 +- hw/virtio/virtio.c| 8 include/qem

[Qemu-devel] [PATCH v3 for-2.6 4/5] aio-posix: Skip external nodes in aio_dispatch

2016-04-22 Thread Fam Zheng
aio_poll doesn't poll the external nodes so this should never be true, but aio_ctx_dispatch may get notified by the events from GSource. To make bdrv_drained_begin effective in main loop, we should check the is_external flag here too. Also do the check in aio_pending so aio_dispatch is not called

Re: [Qemu-devel] [PATCH v2 for-2.6 0/5] block: Fix assertion failure at mirror exit

2016-04-22 Thread Fam Zheng
On Fri, 04/22 16:49, Michael S. Tsirkin wrote: > On Fri, Apr 22, 2016 at 06:55:59PM +0800, Fam Zheng wrote: > > v2: Go along the is_external appraoch. [Kevin] > > > > I tested this series survives the "snapshot + commit" loop reproducer with > > both > > bonnie++ and RHEL installation in the gues

Re: [Qemu-devel] [PATCH v2 for-2.6 0/5] block: Fix assertion failure at mirror exit

2016-04-22 Thread Kevin Wolf
Am 22.04.2016 um 15:49 hat Michael S. Tsirkin geschrieben: > On Fri, Apr 22, 2016 at 06:55:59PM +0800, Fam Zheng wrote: > > v2: Go along the is_external appraoch. [Kevin] > > > > I tested this series survives the "snapshot + commit" loop reproducer with > > both > > bonnie++ and RHEL installation

Re: [Qemu-devel] [PATCH v3 for-2.6 0/5] block: Fix assertion failure at mirror exit

2016-04-22 Thread Michael S. Tsirkin
On Fri, Apr 22, 2016 at 09:53:51PM +0800, Fam Zheng wrote: > v3: 04: Add check in aio_pending. [Kevin] > > I tested this series survives the "snapshot + commit" loop reproducer with > both > bonnie++ and RHEL installation in the guest. > > This supersedes the "virtio: Register host notifier hand

Re: [Qemu-devel] [PATCH kernel 1/2] mm: add the related functions to build the free page bitmap

2016-04-22 Thread Michael S. Tsirkin
On Fri, Apr 22, 2016 at 10:48:38AM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Tue, Apr 19, 2016 at 03:02:09PM +, Li, Liang Z wrote: > > > > On Tue, 2016-04-19 at 22:34 +0800, Liang Li wrote: > > > > > The free page bitmap will be sent to QEMU thr

[Qemu-devel] [PATCH v3 for-2.6 0/5] block: Fix assertion failure at mirror exit

2016-04-22 Thread Fam Zheng
v3: 04: Add check in aio_pending. [Kevin] I tested this series survives the "snapshot + commit" loop reproducer with both bonnie++ and RHEL installation in the guest. This supersedes the "virtio: Register host notifier handler as external" patch from yesterday. The bug was initially reported by

[Qemu-devel] [PATCH v3 for-2.6 1/5] iohandler: Introduce iohandler_get_aio_context

2016-04-22 Thread Fam Zheng
Signed-off-by: Fam Zheng --- include/qemu/main-loop.h | 1 + iohandler.c | 6 ++ stubs/Makefile.objs | 1 + stubs/iohandler.c| 8 4 files changed, 16 insertions(+) create mode 100644 stubs/iohandler.c diff --git a/include/qemu/main-loop.h b/include/qemu/ma

Re: [Qemu-devel] [PATCH v3 08/11] qht: QEMU's fast, resizable and scalable Hash Table

2016-04-22 Thread Alex Bennée
Emilio G. Cota writes: > This is a hash table with optional auto-resizing and MRU promotion for > reads and writes. Its implementation goal is to stay fast while > scaling for read-mostly workloads. > > A hash table with these features will be necessary for the scalability > of the ongoing MTTCG

Re: [Qemu-devel] [PATCH v3 for-2.6 0/5] block: Fix assertion failure at mirror exit

2016-04-22 Thread Kevin Wolf
Am 22.04.2016 um 15:53 hat Fam Zheng geschrieben: > v3: 04: Add check in aio_pending. [Kevin] > > I tested this series survives the "snapshot + commit" loop reproducer with > both > bonnie++ and RHEL installation in the guest. > > This supersedes the "virtio: Register host notifier handler as ex

Re: [Qemu-devel] [PATCH v3 for-2.6 0/5] block: Fix assertion failure at mirror exit

2016-04-22 Thread Jeff Cody
On Fri, Apr 22, 2016 at 09:53:51PM +0800, Fam Zheng wrote: > v3: 04: Add check in aio_pending. [Kevin] > > I tested this series survives the "snapshot + commit" loop reproducer with > both > bonnie++ and RHEL installation in the guest. > > This supersedes the "virtio: Register host notifier hand

Re: [Qemu-devel] [PATCH COLO-Frame v16 21/35] qmp event: Add COLO_EXIT event to notify users while exited from COLO

2016-04-22 Thread Eric Blake
On 04/08/2016 12:26 AM, zhanghailiang wrote: > If some errors happen during VM's COLO FT stage, it's important to notify the > users > of this event. Together with 'x_colo_lost_heartbeat', users can intervene in > COLO's > failover work immediately. > If users don't want to get involved in COLO's

Re: [Qemu-devel] [PATCH 2/3] hw/arm/virt: Add PMU node for virt machine

2016-04-22 Thread Andrew Jones
On Fri, Mar 25, 2016 at 05:46:20PM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > Add a virtual PMU device for virt machine while use PPI 7 for PMU > overflow interrupt number. > > Signed-off-by: Shannon Zhao > --- > hw/arm/virt.c | 31 +++ > include/hw

Re: [Qemu-devel] [PATCH v3 09/11] qht: add test program

2016-04-22 Thread Alex Bennée
Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > tests/.gitignore | 1 + > tests/Makefile | 6 ++- > tests/test-qht.c | 139 > +++ > 3 files changed, 145 insertions(+), 1 deletion(-) > create

  1   2   3   >