On 8 February 2016 at 17:02, Paolo Bonzini wrote:
> The following changes since commit e4a096b1cd4350eeca5dcdc391ab333d2083d7fd:
>
> ui/cocoa.m: Include qemu/osdep.h (2016-02-08 13:14:40 +)
>
> are available in the git repository at:
>
> git://github.com/bonzini/qemu.git tags/for-upstream
On 8 February 2016 at 23:25, Richard Henderson wrote:
> On 02/09/2016 07:24 AM, Richard Henderson wrote:
>> IMO this is a clang bug.
>
>
> I'm glad they agree: https://llvm.org/bugs/show_bug.cgi?id=16154
>
> What clang version are you using, Peter?
This showed up with both:
Ubuntu clang version
On 9 February 2016 at 07:43, Deepak kumar Raju
wrote:
> Can you please help me with the cortex-a7 CPU definitions/configuration that
> I need to add in QEMU. Thanks,
I'm afraid I don't have time to do this myself. I suggested
below how you can go about doing this yourself if you need it:
>> You
On Mon, Feb 08, 2016 at 01:23:28PM -0700, Eric Blake wrote:
> On 02/08/2016 09:28 AM, Daniel P. Berrange wrote:
>
> >> My vote: do the same as we do for qcow2 or any other format. Make the
> >> size requested by the user as the size visible to the guest, and a
> >> fully-allocated image will take
There is a possibility to hit assert qcow2_get_specific_info that
s->qcow_version is undefined. This happens when VM in starting from
suspended state, i.e. it processes incoming migration, and in the same
time 'info block' is called.
The problem is that in the qcow2_invalidate_cache closes and the
There is a possibility to hit assert qcow2_get_specific_info that
s->qcow_version is undefined. This happens when VM in starting from
suspended state, i.e. it processes incoming migration, and in the same
time 'info block' is called.
The problem is that in the qcow2_invalidate_cache closes and the
Am 09.02.2016 um 06:55 hat Pavel Dovgalyuk geschrieben:
> This patch introduces a set of functions that implement recording
> and replaying of block devices' operations. These functions form a thin
> layer between blk_aio_ functions and replay subsystem.
> All asynchronous block requests are added
Am 08.02.2016 um 15:14 hat Alberto Garcia geschrieben:
> When x-blockdev-del is performed on a BlockBackend that has inserted
> media it will only succeed if the BDS doesn't have any additional
> references.
>
> The only problem with this is that if the BDS was created separately
> using blockdev-
Some of this patch set is two years old, though I never got
around to posting it. I've (lightly) tested it under qemu
with a 5kc cpu, with a debian n64 runtime. I've not been
able to test any of the r6 changes, except for compilation.
So to some extent this is an RFC. Hopefully someone has an
R
Bulk patch adding 64-bit opcodes into tcg_out_op. Note that
mips64 is as yet neither complete nor enabled.
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 372 --
tcg/mips/tcg-target.h | 43 ++
2 files changed, 403 insertions(+),
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c
index 43210c5..8f90360 100644
--- a/tcg/mips/tcg-target.c
+++ b/tcg/mips/tcg-target.c
@@ -733,7 +733,7 @@ st
At the same time, use extract in the tlb_load for mips32r2.
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 239 ++
1 file changed, 163 insertions(+), 76 deletions(-)
diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c
index e9
Since the mips manual tables are in octal, reorg all of the opcodes
into that format for clarity. Note that the 64-bit opcodes are as
yet unused.
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 191 +++---
1 file changed, 117 insertions(+
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 57 ---
1 file changed, 27 insertions(+), 30 deletions(-)
diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c
index 8f90360..89083fb 100644
--- a/tcg/mips/tcg-target.c
+++ b/tcg/mi
The DAHI and DATI instructions can eliminate two insns
off the pre-r6 path.
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 63 +++
1 file changed, 63 insertions(+)
diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c
index 97f9
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 21 +++--
tcg/mips/tcg-target.h | 19 +++
2 files changed, 30 insertions(+), 10 deletions(-)
diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c
index 242db14..b5982de 100644
--- a/tcg/mips/tcg-ta
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 34 +-
1 file changed, 25 insertions(+), 9 deletions(-)
diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c
index e56dbc6..43210c5 100644
--- a/tcg/mips/tcg-target.c
+++ b/tcg/mips/tcg-target.c
@@
The DAUI, DAHI, and DATI insns can be used to eliminate
one extra instruction in these cases.
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 40
1 file changed, 40 insertions(+)
diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c
ind
Using compact branches, when possible, avoids a delay slot nop.
Signed-off-by: Richard Henderson
---
include/elf.h | 4 +
tcg/mips/tcg-target.c | 216 +++---
2 files changed, 172 insertions(+), 48 deletions(-)
diff --git a/include/elf.h b/in
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 59 ++-
1 file changed, 49 insertions(+), 10 deletions(-)
diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c
index bda31c2..e0972ba 100644
--- a/tcg/mips/tcg-target.c
+++ b/tcg/mi
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 44
1 file changed, 44 insertions(+)
diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c
index 89083fb..e986437 100644
--- a/tcg/mips/tcg-target.c
+++ b/tcg/mips/tcg-target.c
@@ -2302
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 30 ++
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c
index 06e15d4..1b876af 100644
--- a/tcg/mips/tcg-target.c
+++ b/tcg/mips/tcg-target.c
@@ -3
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c
index b5982de..b8c5d90 100644
--- a/tcg/mips/tcg-target.c
+++ b/tcg/mips/tcg-target.c
@@ -1656,6 +1656,7 @@ static inline void tcg_out_op(TC
On Tue 09 Feb 2016 11:32:20 AM CET, Kevin Wolf wrote:
>> When x-blockdev-del is performed on a BlockBackend that has inserted
>> media it will only succeed if the BDS doesn't have any additional
>> references.
>>
>> The only problem with this is that if the BDS was created separately
>> using blo
e following changes since commit e4a096b1cd4350eeca5dcdc391ab333d2083d7fd:
>
> ui/cocoa.m: Include qemu/osdep.h (2016-02-08 13:14:40 +)
>
> are available in the git repository at:
>
> git://github.com/rth7680/qemu.git tags/pull-tcg-20160209
>
> for you to fetch changes u
Without the mips32r2 / mips64r2 instructions to perform swapping,
32 and 64-bit bswap is quite large. Move them to a subroutine in
the prologue block to minimize code bloat.
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 389 ++
tcg/
On Tue, 2 Feb 2016 13:16:38 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Feb 02, 2016 at 10:59:53AM +0100, Igor Mammedov wrote:
> > On Sun, 31 Jan 2016 18:22:13 +0200
> > "Michael S. Tsirkin" wrote:
> >
> > > On Fri, Jan 29, 2016 at 12:13:59PM +0100, Igor Mammedov wrote:
> > > > On Thu, 28 J
Peter Maydell writes:
> This patchset runs clean-includes on all the .c files in
> tests/, except those in tests/tcg, which I think are all
> intended as standalone test programs for the guest.
>
> The first patch handles i440fx-test.c manually since otherwise
> compilation would fail due to the
The "max" value is being compared with >=, but addr + width points to
the first byte that will _not_ be copied. Subtract one like it is
already done above for the height.
Cc: Gerd Hoffmann
Signed-off-by: Paolo Bonzini
---
hw/display/cirrus_vga.c | 4 ++--
1 file changed, 2 insertions(+), 2 del
Two wrongs make a right, but they should be fixed anyway.
Cc: Daniel P. Berrange
Signed-off-by: Paolo Bonzini
---
io/channel-socket.c | 2 +-
qemu-char.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/io/channel-socket.c b/io/channel-socket.c
index 22d2fd6..bf66a
Only the echo field is used in the temporary VirtualConsole, so the
damage was limited. But still, if echo was incorrectly set to true,
the result would be some puzzling output in VTE monitor and serial
consoles.
Fixes: fba958c692e47a373d15c1fd3d72b255bf76adbd
Cc: Gerd Hoffmann
Tested-by: Mark C
+-- On Fri, 5 Feb 2016, P J P wrote --+
| From: Prasad J Pandit
|
| When processing remote NDIS control message packets, the USB Net
| device emulator uses a fixed length(4096) data buffer. The incoming
| informationBufferOffset & Length combination could cross that range.
| Check control message
On Tue, Feb 09, 2016 at 11:59:15AM +0100, Paolo Bonzini wrote:
> Two wrongs make a right, but they should be fixed anyway.
>
> Cc: Daniel P. Berrange
> Signed-off-by: Paolo Bonzini
> ---
> io/channel-socket.c | 2 +-
> qemu-char.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(
On 09/02/2016 10:21, Peter Maydell wrote:
> On 8 February 2016 at 17:02, Paolo Bonzini wrote:
>> The following changes since commit e4a096b1cd4350eeca5dcdc391ab333d2083d7fd:
>>
>> ui/cocoa.m: Include qemu/osdep.h (2016-02-08 13:14:40 +)
>>
>> are available in the git repository at:
>>
>>
On 02/08/2016 09:43 PM, Alex Bennée wrote:
Stefan Hajnoczi writes:
From: Paolo Bonzini
This is cleaner, and improves error reporting with -daemonize.
Signed-off-by: Paolo Bonzini
Signed-off-by: Denis V. Lunev
Acked-by: Christian Borntraeger
Message-id: 1452174932-28657-4-git-send-email-.
On Mon, Feb 08, 2016 at 02:12:14PM +0100, Didier Pallard wrote:
> On 02/04/2016 03:10 PM, Michael S. Tsirkin wrote:
> >On Thu, Dec 03, 2015 at 10:53:17AM +0100, Didier Pallard wrote:
> >>unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all
> >>is used to send a message and r
From: Eric Blake
Commit 6c2f9a15 ensured that we would not return NULL when the
caller used an output visitor but had nothing to visit. But
in doing so, it added a FIXME about a reference count leak
that could abort qemu in the (unlikely) case of SIZE_MAX such
visits (more plausible on 32-bit).
This reverts commit 662da3854e3f490223373b40afdcfcc339d14aa5.
We require Python 2.6 now (commit fec2103).
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Acked-by: Stefan Hajnoczi
Message-Id: <1450425164-24969-4-git-send-email-arm...@redhat.com>
---
scripts/tracetool.py | 4 ++--
1 f
PEP 8 calls for it, because it's forward compatible with Python 3.
Supported since Python 2.6, which we require (commit fec2103).
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Acked-by: Stefan Hajnoczi
Message-Id: <1450425164-24969-3-git-send-email-arm...@redhat.com>
---
scripts/qmp
From: Eric Blake
Guarantee that visit_end_struct() is called if
visit_start_struct() succeeded. This matches the behavior of
most other uses of visitors, and is a step towards the possibility
of a future patch that adds and enforces some tighter semantics to
the visitor interface (namely, cleanu
From: Eric Blake
Commit 5cdc8831 reworked gen_params() to be simpler, but forgot
to clean up a now-unused errp named argument.
No change to generated code.
Reported-by: Markus Armbruster
Signed-off-by: Eric Blake
Message-Id: <1454075341-13658-6-git-send-email-ebl...@redhat.com>
Signed-off-by:
The following changes since commit e4a096b1cd4350eeca5dcdc391ab333d2083d7fd:
ui/cocoa.m: Include qemu/osdep.h (2016-02-08 13:14:40 +)
are available in the git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2016-02-09
for you to fetch changes up to 423aeaf219890e8a7311dbe
From: Eric Blake
The intent of having the visitor type_size() callback differ
from type_uint64() is to allow special handling for sizes; the
visitor core gracefully falls back to type_uint64() if there is
no need for the distinction. Since the dealloc visitor does
nothing for any of the int visi
PEP 8 calls for it, because it's forward compatible with Python 3.
Supported since Python 2.6, which we require (commit fec2103).
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Acked-by: Stefan Hajnoczi
Message-Id: <1450425164-24969-5-git-send-email-arm...@redhat.com>
---
tests/image
PEP 8 calls for it, because it's forward compatible with Python 3.
Supported since Python 2.6, which we require (commit fec2103).
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Acked-by: Stefan Hajnoczi
Message-Id: <1450425164-24969-2-git-send-email-arm...@redhat.com>
---
scripts/qap
From: Eric Blake
The qapi visitor contract allows us to visit a virtual structure,
where we don't have any corresponding qapi struct. Most such uses
pass NULL for @obj; but these two callers were passing a dummy
pointer, which then gets allocated to heap memory but then
immediately freed without
From: Eric Blake
The only way that qmp_input_pop() will set errp is if a dictionary
was the most recent thing pushed. Since we don't have any
push(struct)/pop(list) or push(list)/pop(struct) mismatches (such
a mismatch is a programming bug), we therefore cannot set errp
inside qmp_input_end_list
From: Eric Blake
Rework the control flow of balloon_stats_get_all() to make it
easier for a later patch to split visit_end_struct(). Also
switch to the uint64 visitor to match the data type.
Signed-off-by: Eric Blake
Message-Id: <1454075341-13658-10-git-send-email-ebl...@redhat.com>
Signed-off
From: Eric Blake
We've already documented that our JSON parsing is locale dependent;
but we should also document that our JSON output has the same
problem. Additionally, JSON requires finite values (you have to
upgrade to JSON5 to get support for Inf or NaN), and our output
truncates floating po
From: Eric Blake
Our qapi visitor contract supports multiple integer visitors,
but left the type_uint64 visitor as optional (falling back on
type_int64); which in turn can lead to awkward behavior with
numbers larger than INT64_MAX (the user has to be aware of
twos complement, and deal with negat
From: Eric Blake
Cache the visitor in a local variable instead of repeatedly
calling the accessor.
Signed-off-by: Eric Blake
Reviewed-by: Marc-André Lureau
Message-Id: <1454075341-13658-8-git-send-email-ebl...@redhat.com>
Signed-off-by: Markus Armbruster
---
hmp.c | 12 +++-
vl.c |
From: Eric Blake
Commit 0b9d8542 added StackEntry.is_list_head, but forgot to
delete the now-unused QapiDeallocVisitor.is_list_head.
Signed-off-by: Eric Blake
Reviewed-by: Marc-André Lureau
Message-Id: <1454075341-13658-4-git-send-email-ebl...@redhat.com>
Signed-off-by: Markus Armbruster
---
From: Eric Blake
Inside the generated code between visit_start_struct() and
visit_end_struct(), we were blindly setting the error into
the caller's errp parameter. But a future patch to split
visit_end_struct() will require that we take action based
on whether an error has occurred, which requir
From: Eric Blake
Commit 4e27e819 introduced optional visitor callbacks for all
sorts of int types, but no visitor has supplied any of the
callbacks for sizes less than 64 bits. In other words, the
generic implementation based on using type_[u]int64() followed
by bounds-checking works just fine.
From: Lluís Vilanova
Forgotten in commit 1dde0f4 (trace.json) and commit fafa4d5
(rocker.json).
Signed-off-by: Lluís Vilanova
Message-Id: <145461055662.15201.2702170180078718114.stgit@localhost>
Reviewed-by: Eric Blake
[Commit message tweaked]
Signed-off-by: Markus Armbruster
---
Makefile |
From: Eric Blake
C compilers are allowed to represent enums as a smaller type
than int, if all enum values fit in the smaller type. There
are even compiler flags that force the use of this smaller
representation, although using them changes the ABI of a
binary. Therefore, our generated code for
From: Eric Blake
The generated code can call visit_end_union() without having called
visit_start_union(). Example:
if (!*obj) {
goto out_obj;
}
visit_type_CpuInfoBase_fields(v, (CpuInfoBase **)obj, &err);
if (err) {
goto out_obj; // if we
From: Eric Blake
The macro DO_UPCAST() is incorrectly named: it converts from a
parent class to a derived class (which is a downcast). Better,
and more consistent with some of the other qapi visitors, is
to use the container_of() macro through a to_FOO() helper. Names
like 'to_ov()' may be a bi
This will be used by the synchronous I/O helpers, to choose between
aio_poll or QemuEvent.
Signed-off-by: Paolo Bonzini
---
include/block/aio.h | 7 +++
iothread.c | 9 +
2 files changed, 16 insertions(+)
diff --git a/include/block/aio.h b/include/block/aio.h
index e086e3b.
From: Eric Blake
The qapi builtin type 'int' is basically shorthand for the type
'int64'. In fact, since no visitor was providing the optional
type_int64() callback, visit_type_int64() was just always falling
back to type_int(), cementing the equivalence between the types.
However, some visitor
Move the implemntation of aio_poll to aio_poll_internal, and introduce
a wrapper for public use. For now it just asserts that aio_poll is
being used correctly---either from the thread that manages the context,
or with the QEMU global mutex held.
The next patch, however, will completely separate t
Signed-off-by: Paolo Bonzini
---
aio-posix.c | 54 --
1 file changed, 32 insertions(+), 22 deletions(-)
diff --git a/aio-posix.c b/aio-posix.c
index 450da51..cbdc6e4 100644
--- a/aio-posix.c
+++ b/aio-posix.c
@@ -16,7 +16,7 @@
#include "qemu/o
This will be used for AioHandlers too. There is going to be little
or no contention, so it is better to reuse the same lock.
Signed-off-by: Paolo Bonzini
---
async.c | 16
include/block/aio.h | 2 +-
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/as
aio_poll is not thread safe; it can report progress incorrectly when
called from the main thread. The bug remains latent as long as
all of it is called within aio_context_acquire/aio_context_release,
but this will change soon.
The details of the bug are pretty simple, but fixing it in an
efficien
From: Eric Blake
JSON uses "name":value, but many of our visitor interfaces were
called with visit_type_FOO(v, &value, name, errp). This can be
a bit confusing to have to mentally swap the parameter order to
match JSON order. It's particularly bad for visit_start_struct(),
where the 'name' para
This will make it possible to walk the list of bottom halves without
holding the AioContext lock---and in turn to call bottom half
handlers without holding the lock.
Signed-off-by: Paolo Bonzini
---
async.c | 31 ++-
include/block/aio.h | 12 +---
Preparing for the following patch, use QLIST_FOREACH_SAFE and
modify the placement of walking_handlers increment/decrement.
Signed-off-by: Paolo Bonzini
---
aio-posix.c | 27 +--
aio-win32.c | 26 --
2 files changed, 25 insertions(+), 28 deletions(
Alistair Francis writes:
> From: Peter Crosthwaite
>
> QOMify registers as a child of TYPE_DEVICE. This allows registers to
> define GPIOs.
>
> Define an init helper that will do QOM initialisation as well as setup
> the r/w fast paths.
I don't know if there has been bit-rot since posting but
Signed-off-by: Paolo Bonzini
---
aio-win32.c | 81 +
1 file changed, 49 insertions(+), 32 deletions(-)
diff --git a/aio-win32.c b/aio-win32.c
index f1a8780..862f48c 100644
--- a/aio-win32.c
+++ b/aio-win32.c
@@ -43,6 +43,7 @@ void aio_s
The AioContext data structures are now protected by list_lock and/or
they are walked with FOREACH_RCU primitives. There is no need anymore
to acquire the AioContext for the entire duration of aio_dispatch.
Instead, just acquire it before and after invoking the callbacks.
The next step is then to p
This is the first step towards having fine-grained critical sections in
dataplane threads, which resolves lock ordering problems between
address_space_* functions (which need the BQL when doing MMIO, even
after we complete RCU-based dispatch) and the AioContext.
Because AioContext does not use con
It is simpler and a bit faster, and QEMU does not need the contention
callbacks (and thus the fairness) anymore.
Signed-off-by: Paolo Bonzini
---
async.c | 8 ++---
include/block/aio.h | 3 +-
include/qemu/rfifolock.h | 54
tests/.gitignore
A QemuLockCnt comprises a counter and a mutex, with primitives
to increment and decrement the counter, and to take and release the
mutex. It can be used to do lock-free visits to a data structure
whenever mutexes would be too heavy-weight and the critical section
is too long for RCU.
This could b
Alex Bennée writes:
> Lluís Vilanova writes:
>> The tracing infrastructure later needs to differentiate between regular
>> pointers and pointers to vCPUs.
>>
>> Also changes all targets to use the new 'TCGv_cpu' type instead of the
>> generic 'TCGv_ptr'. As of now, the change is merely cosmetic
This is complex, but I think it is reasonably documented in the source.
Signed-off-by: Paolo Bonzini
---
docs/lockcnt.txt | 9 +-
include/qemu/futex.h | 36 ++
include/qemu/thread.h| 3 +
trace-events | 10 ++
util/lockcnt.c | 282 +
Signed-off-by: Paolo Bonzini
---
docs/multiple-iothreads.txt | 5 ++---
include/block/aio.h | 32
2 files changed, 18 insertions(+), 19 deletions(-)
diff --git a/docs/multiple-iothreads.txt b/docs/multiple-iothreads.txt
index c5d38e9..8ec3777 100644
---
On Thu, Feb 04, 2016 at 04:10:38PM +0200, Michael S. Tsirkin wrote:
> On Thu, Dec 03, 2015 at 10:53:17AM +0100, Didier Pallard wrote:
> > unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all
> > is used to send a message and retries as long as EAGAIN errno is set,
> > but wr
Alex Bennée writes:
> Lluís Vilanova writes:
>> The tracing infrastructure later needs to differentiate between regular
>> pointers and pointers to vCPUs.
>>
>> Also changes all targets to use the new 'TCGv_cpu' type instead of the
>> generic 'TCGv_ptr'. As of now, the change is merely cosmetic
The main AIO context is used in many places that are not aware
of AioContexts at all. bdrv_drain will soon do a release/acquire
itself, which for the main AIO context would break because code
calls bdrv_drain on it without acquiring anything.
Very soon, bdrv will be ready for removal of aio_conte
This will be useful to define and use properties when the object is
instanciated.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index e1ad19b8db6e..131713
Currently, the code initializing the sdr table relies on an ending
record with a recid of 0x. This patch changes the loop to use the
sdr size as a breaking condition.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(
This patch adds a couple of variables to manipulate the raw sdr
entries. The const attribute is also removed on init_sdrs. This will
ease the introduction of a sdr loader using a file.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 15 ++-
1 file changed, 10 insertions(
This patch provides a simple FRU support for the BMC simulator. FRUs
are loaded from a file which name is specified in the object
properties, each entry having a fixed size, also specified in the
properties. If the file is unknown or not accessible for some reason,
a unique entry of 1024 bytes is c
The first patches are cleanups and prepare ground for an extension of
the BMC simulator providing a SDR loader using a file. A simple FRU
support comes next.
The last patches introduce APIs to populate a guest device tree with
the available sensors and to generate events, which is needed by
platfo
This patch exposes a new IPMI routine to query a sdr entry from the
sdr table maintained by the IPMI BMC simulator. The API is very
similar to the internal sdr_find_entry() routine and should be used
the same way to query one or all sdrs.
A typical use would be to loop on the sdrs to build nodes o
The IPMI BMC simulator populates the sdr/sensor tables with a minimal
set of entries (Watchdog). But some qemu platforms might want to use
extra entries for their custom needs.
This patch modifies slighty the initializing routine to take into
account a larger set read from a file. The name of the
From: Stephen Warren
Add an entry to MAINTAINERS that matches every patch, and requests the
user send patches to qemu-devel@nongnu.org.
It's not 100% obvious to project newcomers that all patches should be sent
there; checkpatch doesn't say so, and since it mentions other lists to CC,
the wordin
This patch does not change anything. It only moves the code section
initializing the sdrs in its own routine and prepares ground for the
subsequent patches.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 49 -
1 file changed, 28 inser
From: Stefan Hajnoczi
Although accesses to ram_list.dirty_memory[] use atomics so multiple
threads can safely dirty the bitmap, the data structure is not fully
thread-safe yet.
This patch handles the RAM hotplug case where ram_list.dirty_memory[] is
grown. ram_list.dirty_memory[] is change from
From: Peter Maydell
Improve the part of the memory region documentation which describes
the various different kinds of memory region:
* add the missing types ROM, IOMMU and reservation
* mention the functions used to initialize each type, as a hint
for finding the API docs and examples of us
Two wrongs make a right, but they should be fixed anyway.
Cc: Daniel P. Berrange
Signed-off-by: Paolo Bonzini
Message-Id: <1455015557-15106-1-git-send-email-pbonz...@redhat.com>
---
io/channel-socket.c | 2 +-
qemu-char.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --
It will be used to fill the message buffer with custom events expected
by some systems. Typically, an Open PowerNV platform guest is notified
with an OEM SEL message before a shutdown or a reboot.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 24
include/h
This adds the SAS1068 device, a SAS disk controller used in VMware that
is oldish but widely supported and has decent performance. Unlike
megasas, it presents itself as a SAS controller and not as a RAID
controller. The device corresponds to the mptsas kernel driver in
Linux.
A few small things
The following changes since commit e4a096b1cd4350eeca5dcdc391ab333d2083d7fd:
ui/cocoa.m: Include qemu/osdep.h (2016-02-08 13:14:40 +)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you to fetch changes up to 91eb5e5293fda2127ae33594715b47
(pde & 0x1fe000) is a 32-bit integer; when shifting it
into bits 39-32 the result is zero. Fix it by making the
mask (and thus the result of the AND) a 64-bit integer.
Reported by Coverity.
Signed-off-by: Paolo Bonzini
---
target-i386/helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 delet
On Tue, Feb 09, 2016 at 11:48:13AM +, Daniel P. Berrange wrote:
> On Thu, Feb 04, 2016 at 04:10:38PM +0200, Michael S. Tsirkin wrote:
> > On Thu, Dec 03, 2015 at 10:53:17AM +0100, Didier Pallard wrote:
> > > unix_send_msgfds is used by vhost-user control socket.
> > > qemu_chr_fe_write_all
> >
On Tue, Feb 09, 2016 at 11:46:08AM +0100, Igor Mammedov wrote:
> > So the linker interface solves this rather neatly:
> > bios allocates memory, bios passes memory map to guest.
> > Served us well for several years without need for extensions,
> > and it does solve the VM GEN ID problem, even thoug
Denis V. Lunev writes:
> On 02/08/2016 09:43 PM, Alex Bennée wrote:
>> Stefan Hajnoczi writes:
>>
>>> From: Paolo Bonzini
>>>
>>> This is cleaner, and improves error reporting with -daemonize.
>>>
>>> Signed-off-by: Paolo Bonzini
>>> Signed-off-by: Denis V. Lunev
>>> Acked-by: Christian Born
From: Eric Blake
Commit 86f4b687 broke compilation on MIPS and SPARC, which have a
preprocessor pollution of '#define mips 1' and '#define sparc 1',
respectively. Treat it the same way as we do for the pollution with
'unix', so that QMP remains backwards compatible and only the C code
needs to u
From: Eric Blake
No need to repeat 'struct Visitor' when we already have it in
typedefs.h. Omitting the redundant 'struct' also makes a later
patch easier to search for all object property callbacks that
are associated with a Visitor.
Signed-off-by: Eric Blake
Reviewed-by: Marc-André Lureau
M
1 - 100 of 399 matches
Mail list logo
