Denis V. Lunev <d...@openvz.org> writes:
> On 02/08/2016 09:43 PM, Alex Bennée wrote:
>> Stefan Hajnoczi <stefa...@redhat.com> writes:
>>
>>> From: Paolo Bonzini <pbonz...@redhat.com>
>>>
>>> This is cleaner, and improves error reporting with -daemonize.
>>>
>>> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
>>> Signed-off-by: Denis V. Lunev <d...@openvz.org>
>>> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com>
>>> Message-id: 1452174932-28657-4-git-send-email-...@openvz.org
>>> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
>>> ---
>>> qemu-io.c | 2 +-
>>> trace/control.c | 17 ++++++++++++-----
>>> trace/control.h | 13 ++++++++++++-
>>> trace/simple.c | 6 ++----
>>> trace/simple.h | 4 ++--
>>> vl.c | 13 +++++++++----
>>> 6 files changed, 38 insertions(+), 17 deletions(-)
>>>
>>> diff --git a/qemu-io.c b/qemu-io.c
>>> index 1c11d57..83c48f4 100644
>>> --- a/qemu-io.c
>>> +++ b/qemu-io.c
>>> @@ -435,7 +435,7 @@ int main(int argc, char **argv)
>>> }
>>> break;
>>> case 'T':
>>> - if (!trace_init_backends(optarg)) {
>>> + if (!trace_init_backends()) {
>>> exit(1); /* error message will have been printed */
>>> }
>>> break;
>>> diff --git a/trace/control.c b/trace/control.c
>>> index 931d64c..f5a497a 100644
>>> --- a/trace/control.c
>>> +++ b/trace/control.c
>>> @@ -145,17 +145,24 @@ void trace_init_events(const char *fname)
>>> loc_pop(&loc);
>>> }
>>>
>>> -bool trace_init_backends(const char *file)
>>> +void trace_init_file(const char *file)
>>> {
>>> #ifdef CONFIG_TRACE_SIMPLE
>>> - if (!st_init(file)) {
>>> - fprintf(stderr, "failed to initialize simple tracing backend.\n");
>>> - return false;
>>> - }
>>> + st_set_trace_file(file);
>> This breaks "make check" as st_set_trace_file will attempt to flush the
>> file:
> this does not hang for me even with CONFIG_TRACE_SIMPLE enabled.
> Could you share your ./configure options?
./configure --target-list=x86_64-softmmu --enable-trace-backends=simple
Also see:
https://travis-ci.org/stsquad/qemu/jobs/107280320
--
Alex Bennée
