Re: [Qemu-devel] [PATCH v9] spec: add qcow2 bitmaps extension specification

2016-02-03 Thread Fam Zheng
On Tue, 02/02 09:35, Vladimir Sementsov-Ogievskiy wrote: > The new feature for qcow2: storing bitmaps. > > This patch adds new header extension to qcow2 - Bitmaps Extension. It > provides an ability to store virtual disk related bitmaps in a qcow2 > image. For now there is only one type of such bi

[Qemu-devel] RE: [iGVT-g] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-02-03 Thread Tian, Kevin
> From: Zhiyuan Lv > Sent: Tuesday, February 02, 2016 3:35 PM > > Hi Gerd/Alex, > > On Mon, Feb 01, 2016 at 02:44:55PM -0700, Alex Williamson wrote: > > On Mon, 2016-02-01 at 14:10 +0100, Gerd Hoffmann wrote: > > >   Hi, > > > > > > > > Unfortunately it's not the only one. Another example is, dev

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-03 Thread Fam Zheng
On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > These series which aims to add external backup api. This is needed to allow > backup software use our dirty bitmaps. > > Vmware and Parallels Cloud Server have this feature. What is the advantage of this appraoch over "drive-

Re: [Qemu-devel] [PATCH v9 01/16] block: Release named dirty bitmaps in bdrv_close()

2016-02-03 Thread Fam Zheng
On Fri, 01/29 16:36, Max Reitz wrote: > bdrv_delete() is not very happy about deleting BlockDriverStates with > dirty bitmaps still attached to them. In the past, we got around that > very easily by relying on bdrv_close_all() bypassing bdrv_delete(), and > bdrv_close() simply ignoring that conditi

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-03 Thread Gerd Hoffmann
Hi, > Actually I have a long puzzle in this area. Definitely libvirt will use UUID > to > mark a VM. And obviously UUID is not recorded within KVM. Then how does > libvirt talk to KVM based on UUID? It could be a good reference to this > design. libvirt keeps track which qemu instance belongs

Re: [Qemu-devel] [PATCH v9 05/16] virtio-scsi: Catch BDS-BB removal/insertion

2016-02-03 Thread Fam Zheng
On Fri, 01/29 16:36, Max Reitz wrote: > Make use of the BDS-BB removal and insertion notifiers to remove or set > up, respectively, virtio-scsi's op blockers. > > Signed-off-by: Max Reitz Reviewed-by: Fam Zheng

Re: [Qemu-devel] RE: [iGVT-g] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-02-03 Thread Neo Jia
On Wed, Feb 03, 2016 at 08:04:16AM +, Tian, Kevin wrote: > > From: Zhiyuan Lv > > Sent: Tuesday, February 02, 2016 3:35 PM > > > > Hi Gerd/Alex, > > > > On Mon, Feb 01, 2016 at 02:44:55PM -0700, Alex Williamson wrote: > > > On Mon, 2016-02-01 at 14:10 +0100, Gerd Hoffmann wrote: > > > >   Hi,

[Qemu-devel] [PATCH v2] scripts/kvm/kvm_stat: Fix tracefs access checking

2016-02-03 Thread Janosch Frank
On kernels build without CONFIG_TRACING kvm_stat will bail out even when traces are not used. This is not very helpful, especially if the user can't install a new kernel. Instead, we should warn the user and fall back to debugfs statistics. These changes check if trace statistics were selected wit

Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-02-03 Thread Gerd Hoffmann
Hi, > I think the "dma_enabled" property is not exposed to the user. It is: "-global fw_cfg.dma_enabled=off" works (as in: doesn't throw an error). Has no effect through as it gets overridden later on. > The default value of "dma_enabled" in both fw_cfg_io_properties and > fw_cfg_mem_properti

Re: [Qemu-devel] [RFC PATCH v2 7/7] vfio/pci: Find and expose Intel IGD OpRegion

2016-02-03 Thread Gerd Hoffmann
On Di, 2016-02-02 at 13:09 -0700, Alex Williamson wrote: > This is provided via a device specific region, look for it on Intel > VGA class devices. Our default mechanism to expose this to the BIOS > is via fw_cfg where it's expected that the BIOS will copy the data > into a reserved RAM area and u

Re: [Qemu-devel] [PATCH v14 7/8] Implement new driver for block replication

2016-02-03 Thread Stefan Hajnoczi
On Wed, Feb 03, 2016 at 09:29:15AM +0800, Wen Congyang wrote: > On 02/02/2016 10:34 PM, Stefan Hajnoczi wrote: > > On Mon, Feb 01, 2016 at 09:13:36AM +0800, Wen Congyang wrote: > >> On 01/29/2016 11:46 PM, Stefan Hajnoczi wrote: > >>> On Fri, Jan 29, 2016 at 11:13:42AM +0800, Changlong Xie wrote: >

Re: [Qemu-devel] [PATCH 05/16] iothread: release AioContext around aio_poll

2016-02-03 Thread Stefan Hajnoczi
On Tue, Feb 02, 2016 at 04:01:55PM +0100, Paolo Bonzini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > > > On 02/02/2016 15:52, Stefan Hajnoczi wrote: > >>> @@ -110,6 +111,8 @@ static void *test_acquire_thread(void > >>> *opaque) qemu_mutex_lock(&data->start_lock); > >>> qemu_mu

Re: [Qemu-devel] [PATCH] Fix inconsistency between comment and variable name

2016-02-03 Thread Markus Armbruster
Michael Tokarev writes: > 03.02.2016 06:19, Cao jin wrote: >> Signed-off-by: Cao jin >> --- >> include/hw/qdev-core.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h >> index abcdee8..42fa5db 100644 >> --- a/include/hw

[Qemu-devel] [PATCH 2/2] m68k: Build the opcode table only once to avoid multithreading issues

2016-02-03 Thread John Paul Adrian Glaubitz
Signed-off-by: John Paul Adrian Glaubitz --- target-m68k/translate.c | 4 1 file changed, 4 insertions(+) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 535d7f9..f508d1e 100644 --- a/target-m68k/translate.c +++ b/target-m68k/translate.c @@ -2828,6 +2828,10 @@ register_

[Qemu-devel] [PATCH 1/2] m68k: Fix opcode mask for fbcc instruction

2016-02-03 Thread John Paul Adrian Glaubitz
Signed-off-by: John Paul Adrian Glaubitz --- target-m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 342c040..535d7f9 100644 --- a/target-m68k/translate.c +++ b/target-m68k/translate.c @@ -2940,7 +2940,7 @

[Qemu-devel] m68k: More bug fixes for translation code

2016-02-03 Thread John Paul Adrian Glaubitz
Hi Laurent! As promised, here are the fixes for the two recently discovered bugs in the m68k translation code. The first patch fixes the opcode mask for the fbcc instruction which is currently incorrect as it masks the 6th bit as constant (0xffc0). However, according to the ColdFire reference man

Re: [Qemu-devel] [PATCH 1/2] m68k: Fix opcode mask for fbcc instruction

2016-02-03 Thread Laurent Vivier
Le 03/02/2016 10:37, John Paul Adrian Glaubitz a écrit : > Signed-off-by: John Paul Adrian Glaubitz > --- > target-m68k/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-m68k/translate.c b/target-m68k/translate.c > index 342c040..535d7f9 100644 > --- a

Re: [Qemu-devel] [PATCH 2/2] m68k: Build the opcode table only once to avoid multithreading issues

2016-02-03 Thread Laurent Vivier
Le 03/02/2016 10:37, John Paul Adrian Glaubitz a écrit : > Signed-off-by: John Paul Adrian Glaubitz > --- > target-m68k/translate.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/target-m68k/translate.c b/target-m68k/translate.c > index 535d7f9..f508d1e 100644 > --- a/target-m68k

Re: [Qemu-devel] [PATCH 1/2] m68k: Fix opcode mask for fbcc instruction

2016-02-03 Thread John Paul Adrian Glaubitz
Strange. There should be a cover letter coming along as well which explains my changes. Did you get it? On 02/03/2016 10:37 AM, John Paul Adrian Glaubitz wrote: > Signed-off-by: John Paul Adrian Glaubitz > --- > target-m68k/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Qemu-devel] [PATCH 1/2] m68k: Fix opcode mask for fbcc instruction

2016-02-03 Thread Laurent Vivier
Le 03/02/2016 10:40, John Paul Adrian Glaubitz a écrit : > Strange. There should be a cover letter coming along as well which > explains my changes. Did you get it? We have the cover letter, but it is never sent to the sender :) Laurent > > On 02/03/2016 10:37 AM, John Paul Adrian Glaubitz wro

Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-02-03 Thread Stefan Hajnoczi
On Tue, Feb 02, 2016 at 01:58:14PM +0100, Marc Marí wrote: > El Tue, 02 Feb 2016 12:06:27 +0100 > Gerd Hoffmann escribió: > > Hi, > > > > > %.img: %.o > > > - $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -Ttext 0 -e > > > _start -s -o $@ $<," Building $(TARGET_DIR)$@") > > > + $(call quiet-com

Re: [Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort

2016-02-03 Thread Markus Armbruster
David Gibson writes: > On Tue, Feb 02, 2016 at 10:47:35PM +0100, Thomas Huth wrote: >> On 02.02.2016 19:53, Markus Armbruster wrote: >> > Lluís Vilanova writes: >> ... >> >> >> diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h >> >> index 7ab2355..6c2f142 100644 >> >> --- a

[Qemu-devel] [PULL 1/1] hmp: fix sendkey out of bounds write (CVE-2015-8619)

2016-02-03 Thread Markus Armbruster
From: Wolfgang Bumiller When processing 'sendkey' command, hmp_sendkey routine null terminates the 'keyname_buf' array. This results in an OOB write issue, if 'keyname_len' was to fall outside of 'keyname_buf' array. Since the keyname's length is known the keyname_buf can be removed altogether b

[Qemu-devel] [PULL 0/1] Monitor patches for 2016-02-03

2016-02-03 Thread Markus Armbruster
The following changes since commit c65db7705b7926f4a084b93778e4bd5dd3990aad: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-for-peter-2016-02-02' into staging (2016-02-02 18:04:04 +) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-moni

Re: [Qemu-devel] [PATCH 05/16] iothread: release AioContext around aio_poll

2016-02-03 Thread Paolo Bonzini
On 03/02/2016 10:34, Stefan Hajnoczi wrote: > +g_usleep(50); > Sleep? >>> >>> What about it? :) > Sleep in a loop is inefficient but at least correct. > > A sleep outside a loop is a race condition. If the machine is > heavily loaded, whatever you are waiting for may not ha

Re: [Qemu-devel] [PATCH v1 14/22] migration: convert savevm to use QIOChannel for writing to files

2016-02-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > Convert the exec savevm code to use QIOChannel and QEMUFileChannel, > instead of the stdio APIs. > > Signed-off-by: Daniel P. Berrange Reviewed-by: Dr. David Alan Gilbert > --- > migration/savevm.c | 8 +--- > tests/Makefile |

Re: [Qemu-devel] [PATCH v14 7/8] Implement new driver for block replication

2016-02-03 Thread Wen Congyang
On 02/03/2016 05:32 PM, Stefan Hajnoczi wrote: > On Wed, Feb 03, 2016 at 09:29:15AM +0800, Wen Congyang wrote: >> On 02/02/2016 10:34 PM, Stefan Hajnoczi wrote: >>> On Mon, Feb 01, 2016 at 09:13:36AM +0800, Wen Congyang wrote: On 01/29/2016 11:46 PM, Stefan Hajnoczi wrote: > On Fri, Jan 29

Re: [Qemu-devel] [PATCH] block: add missing call to bdrv_drain_recurse

2016-02-03 Thread Paolo Bonzini
On 11/01/2016 09:32, Paolo Bonzini wrote: > > > On 25/12/2015 02:55, Fam Zheng wrote: >> On Wed, 12/23 11:48, Paolo Bonzini wrote: >>> This is also needed in bdrv_drain_all, not just in bdrv_drain. >>> >>> Signed-off-by: Paolo Bonzini >>> --- >>> block/io.c | 1 + >>> 1 file changed, 1 insert

Re: [Qemu-devel] [PATCH v1 15/22] migration: delete QEMUFile buffer implementation

2016-02-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > The qemu_bufopen() method is no longer used, so the memory > buffer based QEMUFile backend can be deleted entirely. > > Signed-off-by: Daniel P. Berrange Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/qemu-file.h | 6 --- > m

Re: [Qemu-devel] [PATCH v1 16/22] migration: delete QEMUSizedBuffer struct

2016-02-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > Now that we don't have have a buffer based QemuFile > implementation, the QEMUSizedBuffer code is also > unused and can be deleted. A simpler buffer class > also exists in util/buffer.c which other code can > used as needed. > > Signed-off-by: Da

Re: [Qemu-devel] [PATCH v1 17/22] migration: delete QEMUFile sockets implementation

2016-02-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > Now that the tcp, unix and fd migration backends have converted > to use the QIOChannel based QEMUFile, there is no user remaining > for the sockets based QEMUFile impl and it can be deleted. > > Signed-off-by: Daniel P. Berrange Reviewed-by: D

Re: [Qemu-devel] [PATCH 2/2] m68k: Build the opcode table only once to avoid multithreading issues

2016-02-03 Thread Laurent Vivier
Le 03/02/2016 10:39, Laurent Vivier a écrit : > > > Le 03/02/2016 10:37, John Paul Adrian Glaubitz a écrit : >> Signed-off-by: John Paul Adrian Glaubitz >> --- >> target-m68k/translate.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/target-m68k/translate.c b/target-m68k/tran

Re: [Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort

2016-02-03 Thread Thomas Huth
On 03.02.2016 10:48, Markus Armbruster wrote: > David Gibson writes: > >> On Tue, Feb 02, 2016 at 10:47:35PM +0100, Thomas Huth wrote: >>> On 02.02.2016 19:53, Markus Armbruster wrote: Lluís Vilanova writes: >>> ... >>> > diff --git a/include/qemu/error-report.h b/include/qemu/error-rep

Re: [Qemu-devel] [PATCH v1 18/22] migration: delete QEMUFile stdio implementation

2016-02-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > Now that the exec migration backend and savevm have converted > to use the QIOChannel based QEMUFile, there is no user remaining > for the stdio based QEMUFile impl and it can be deleted. > > Signed-off-by: Daniel P. Berrange Reviewed-by: Dr. D

Re: [Qemu-devel] [PATCHv3 2/4] Split serial-isa into its own config option

2016-02-03 Thread Markus Armbruster
David Gibson writes: > At present, the core device model code for 8250-like serial ports > (serial.c) and the code for serial ports attached to ISA-style legacy IO > (serial-isa.c) are both controlled by the CONFIG_SERIAL variable. > > There are lots and lots of embedded platforms that have 8250-

Re: [Qemu-devel] [PATCH v1 10/22] migration: convert tcp socket protocol to use QIOChannel

2016-02-03 Thread Daniel P. Berrange
On Tue, Feb 02, 2016 at 06:19:03PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > Convert the tcp socket migration protocol driver to use > > QIOChannel and QEMUFileChannel, instead of plain sockets > > APIs. > > > > While this now looks pretty similar

Re: [Qemu-devel] [PATCH v1 11/22] migration: convert fd socket protocol to use QIOChannel

2016-02-03 Thread Daniel P. Berrange
On Tue, Feb 02, 2016 at 06:46:01PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > Convert the fd socket migration protocol driver to use > > QIOChannel and QEMUFileChannel, instead of plain sockets > > APIs. It can be unconditionally built because the >

Re: [Qemu-devel] [PATCH 2/2] m68k: Build the opcode table only once to avoid multithreading issues

2016-02-03 Thread John Paul Adrian Glaubitz
On 02/03/2016 10:57 AM, Laurent Vivier wrote: > In fact, the line should be: > > +if (opcode_table[0] != NULL) > +return; > > thanks to scripts/checkpatch.pl. Want me to re-send it? -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Un

Re: [Qemu-devel] [PATCHv3 3/4] Allow ISA bus to be configured out

2016-02-03 Thread Markus Armbruster
David Gibson writes: > Currently, the code to handle the legacy ISA bus is always included in > qemu. However there are lots of platforms that don't include ISA legacy > devies, and quite a few that have never used ISA legacy devices at all. > > This patch allows the ISA bus code to be disabled

Re: [Qemu-devel] [PATCH v5 02/10] qemu-img: add support for --object command line arg

2016-02-03 Thread Daniel P. Berrange
On Tue, Feb 02, 2016 at 05:24:32PM -0700, Eric Blake wrote: > On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: > > Allow creation of user creatable object types with qemu-img > > via a new --object command line arg. This will be used to supply > > passwords and/or encryption keys to the various bl

Re: [Qemu-devel] [PATCH 2/2] m68k: Build the opcode table only once to avoid multithreading issues

2016-02-03 Thread Laurent Vivier
Le 03/02/2016 11:06, John Paul Adrian Glaubitz a écrit : > On 02/03/2016 10:57 AM, Laurent Vivier wrote: >> In fact, the line should be: >> >> +if (opcode_table[0] != NULL) >> +return; >> >> thanks to scripts/checkpatch.pl. > > Want me to re-send it? > I don't know if the one who w

[Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues

2016-02-03 Thread John Paul Adrian Glaubitz
Signed-off-by: John Paul Adrian Glaubitz --- target-m68k/translate.c | 4 1 file changed, 4 insertions(+) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 535d7f9..a989961 100644 --- a/target-m68k/translate.c +++ b/target-m68k/translate.c @@ -2828,6 +2828,10 @@ register_

[Qemu-devel] Updated patch for the opcode table

2016-02-03 Thread John Paul Adrian Glaubitz
Hi Laurent! Here's the second patch again, this time checked with ./scripts/checkpatch.pl. Thanks for the heads-up! Adrian

Re: [Qemu-devel] [PATCH 2/2] m68k: Build the opcode table only once to avoid multithreading issues

2016-02-03 Thread John Paul Adrian Glaubitz
On 02/03/2016 11:13 AM, Laurent Vivier wrote: > I don't know if the one who will commit this to the tree will want to > update this. Just sent an updated one, just in case :). > BTW, Peter, perhaps it's the time to add me as m68k maintainer ? > (so I will manage that :) ) Yes, please. I'm all fo

Re: [Qemu-devel] [PATCH v1 11/22] migration: convert fd socket protocol to use QIOChannel

2016-02-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, Feb 02, 2016 at 06:46:01PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > Convert the fd socket migration protocol driver to use > > > QIOChannel and QEMUFileChannel, instead of plain socke

Re: [Qemu-devel] [PATCH v1 10/22] migration: convert tcp socket protocol to use QIOChannel

2016-02-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, Feb 02, 2016 at 06:19:03PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > Convert the tcp socket migration protocol driver to use > > > QIOChannel and QEMUFileChannel, instead of plain sock

Re: [Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort

2016-02-03 Thread Markus Armbruster
Thomas Huth writes: > On 03.02.2016 10:48, Markus Armbruster wrote: >> David Gibson writes: >> >>> On Tue, Feb 02, 2016 at 10:47:35PM +0100, Thomas Huth wrote: On 02.02.2016 19:53, Markus Armbruster wrote: > Lluís Vilanova writes: ... >> diff --git a/include/qemu/error-r

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-03 Thread Kevin Wolf
Am 02.02.2016 um 20:29 hat Eric Blake geschrieben: > On 02/02/2016 10:28 AM, Programmingkid wrote: > > >> Whats the rationale here ? Using pre-allocated fixed > >> length arrays is pretty bad practice in general, but > >> especially so for filenames > > > > With an automatic variable there is no

Re: [Qemu-devel] [PATCH v1 11/22] migration: convert fd socket protocol to use QIOChannel

2016-02-03 Thread Daniel P. Berrange
On Wed, Feb 03, 2016 at 10:29:50AM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Tue, Feb 02, 2016 at 06:46:01PM +, Dr. David Alan Gilbert wrote: > > > > void fd_start_incoming_migration(const char *infd, Error **errp) > > > > { > > > > -i

Re: [Qemu-devel] [Qemu-block] [PATCH] block: add missing call to bdrv_drain_recurse

2016-02-03 Thread Kevin Wolf
Am 23.12.2015 um 11:48 hat Paolo Bonzini geschrieben: > This is also needed in bdrv_drain_all, not just in bdrv_drain. > > Signed-off-by: Paolo Bonzini Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 2/6] i.MX: simplify CCM to only handle clock required by timers.

2016-02-03 Thread Peter Maydell
On 2 February 2016 at 22:22, Jean-Christophe DUBOIS wrote: > Peter Maydell wrote: >> These are just renaming NOCLK to CLK_NONE and fixing formatting? >> Again, please don't put that in the same patch as substantive >> code changes. > > > I just wanted to make things more coherent at the naming co

Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse

2016-02-03 Thread Peter Maydell
On 3 February 2016 at 07:15, Michael Tokarev wrote: > 28.01.2016 21:22, Wei Huang wrote: >> When QEMU is hook'ed up with libvirt/virsh, the first ACPI reboot >> request will succeed; but the following shutdown/reboot requests >> fail to trigger VMs to react. Notice that in mach-virt machine >> mod

Re: [Qemu-devel] [PATCH] Fix inconsistency between comment and variable name

2016-02-03 Thread Cao jin
On 02/03/2016 05:35 PM, Markus Armbruster wrote: Michael Tokarev writes: 03.02.2016 06:19, Cao jin wrote: Signed-off-by: Cao jin --- include/hw/qdev-core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index abcdee8..

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-03 Thread Vladimir Sementsov-Ogievskiy
On 03.02.2016 11:14, Fam Zheng wrote: On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: Hi all. These series which aims to add external backup api. This is needed to allow backup software use our dirty bitmaps. Vmware and Parallels Cloud Server have this feature. What is the advantage

Re: [Qemu-devel] [PATCH v4] blockjob: Fix hang in block_job_finish_sync

2016-02-03 Thread Stefan Hajnoczi
On Tue, Feb 02, 2016 at 10:12:24AM +0800, Fam Zheng wrote: > With a mirror job running on a virtio-blk dataplane disk, sending "q" to > HMP will cause a dead loop in block_job_finish_sync. > > This is because the aio_poll() only processes the AIO context of bs > which has no more work to do, while

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-03 Thread Fam Zheng
On Wed, 02/03 13:57, Vladimir Sementsov-Ogievskiy wrote: > On 03.02.2016 11:14, Fam Zheng wrote: > >On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: > >>Hi all. > >> > >>These series which aims to add external backup api. This is needed to allow > >>backup software use our dirty bitmaps. >

Re: [Qemu-devel] [PATCH v16 00/14] vfio-pci: pass the aer error to guest

2016-02-03 Thread Chen Fan
On 01/17/2016 02:34 AM, Michael S. Tsirkin wrote: On Tue, Jan 12, 2016 at 10:43:01AM +0800, Cao jin wrote: From: Chen Fan For now, for vfio pci passthough devices when qemu receives an error from host aer report, currentlly just terminate the guest, but usually user want to know what error oc

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU

2016-02-03 Thread Gerd Hoffmann
Hi, > +static void intel_igd_opregion_setup(struct pci_device *dev, void *arg) > +{ > +struct romfile_s *file = romfile_find("etc/igd-opregion"); Is it possible to have multiple igd devices in a single machine? So, should we include the pci address in the file name? Guess not needed, it's

Re: [Qemu-devel] [PULL 00/17] Net patches

2016-02-03 Thread Samuel Thibault
Jason Wang, on Wed 03 Feb 2016 12:52:24 +0800, wrote: > > Hi. I'm afraid this failed to build on w32: > > > > declaration specifiers or ‘...’ before ‘sa_family_t’ > > - switch to use unsigned short > - or typedef sa_family_t as unsigned short for windows Doing the second runs the risk of windows

[Qemu-devel] [PULL 0/6] virtio-gpu: bugfixes and spice support preparation

2016-02-03 Thread Gerd Hoffmann
(2016-02-02 18:04:04 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-vga-20160203-1 for you to fetch changes up to 321c9adba5a64a1a9de2dd7db5433b62a5433439: virtio-gpu: block any rendering until client (ui) is done (2016-02-03 10:4

[Qemu-devel] [PULL 1/6] zap qemu_egl_has_ext in include/ui/egl-helpers.h

2016-02-03 Thread Gerd Hoffmann
Drop leftover prototype which sneaked in by mistake Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- include/ui/egl-helpers.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/ui/egl-helpers.h b/include/ui/egl-helpers.h index 5ad5dc3..8c84398 100644 --- a/include/ui/egl-

[Qemu-devel] [PULL 4/6] virtio-gpu: maintain command queue

2016-02-03 Thread Gerd Hoffmann
We'll go take out the commands we receive out of the virt queue and put them into a linked list, to decouple virtio queue handling from actual command processing. Also move cmd processing to new virtio_gpu_handle_ctrl func, so we can easily kick it from different places. Signed-off-by: Gerd Hoffm

[Qemu-devel] [PULL 3/6] virtio-gpu: fix memory leak in error path

2016-02-03 Thread Gerd Hoffmann
Found by Coverity Scan, buf not freed on error. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- hw/display/virtio-gpu-3d.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c index 59581a4..e13122d 100644

[Qemu-devel] [PULL 6/6] virtio-gpu: block any rendering until client (ui) is done

2016-02-03 Thread Gerd Hoffmann
Wire up gl_block callback, so ui code can request to stop virtio-gpu rendering. Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu-3d.c | 5 + hw/display/virtio-gpu.c| 11 +++ hw/display/virtio-vga.c| 10 ++ include/hw/virtio/virtio-gpu.h | 1 + 4 fi

[Qemu-devel] [PULL 2/6] console: block rendering until client is done

2016-02-03 Thread Gerd Hoffmann
Allow gl user interfaces to block display device gl rendering. The ui code might want to do that in case it takes a little longer to bring things to screen, for example because we'll hand over a dma-buf to another process (spice will do that). Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André

[Qemu-devel] [PULL 5/6] virtio-gpu: add support to enable/disable command processing

2016-02-03 Thread Gerd Hoffmann
So we can stop rendering for a while in case we have to. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- hw/display/virtio-gpu-3d.c | 3 ++- hw/display/virtio-gpu.c| 5 - include/hw/virtio/virtio-gpu.h | 2 ++ 3 files changed, 8 insertions(+), 2 deletions(-) dif

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-03 Thread Vladimir Sementsov-Ogievskiy
On 03.02.2016 14:02, Fam Zheng wrote: On Wed, 02/03 13:57, Vladimir Sementsov-Ogievskiy wrote: On 03.02.2016 11:14, Fam Zheng wrote: On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: Hi all. These series which aims to add external backup api. This is needed to allow backup software use

Re: [Qemu-devel] [PATCH v1 09/22] migration: convert unix socket protocol to use QIOChannel

2016-02-03 Thread Daniel P. Berrange
On Tue, Feb 02, 2016 at 06:02:13PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > Convert the unix socket migration protocol driver to use > > QIOChannel and QEMUFileChannel, instead of plain sockets > > APIs. It can be unconditionally built, since the

Re: [Qemu-devel] [PATCH v14 7/8] Implement new driver for block replication

2016-02-03 Thread Hailiang Zhang
On 2016/2/3 17:55, Wen Congyang wrote: On 02/03/2016 05:32 PM, Stefan Hajnoczi wrote: On Wed, Feb 03, 2016 at 09:29:15AM +0800, Wen Congyang wrote: On 02/02/2016 10:34 PM, Stefan Hajnoczi wrote: On Mon, Feb 01, 2016 at 09:13:36AM +0800, Wen Congyang wrote: On 01/29/2016 11:46 PM, Stefan Hajno

Re: [Qemu-devel] [PATCH v1 13/22] migration: convert RDMA to use QIOChannel interface

2016-02-03 Thread Daniel P. Berrange
On Tue, Feb 02, 2016 at 08:01:36PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > This converts the RDMA code to provide a subclass of > > QIOChannel that uses RDMA for the data transport. > > > > The RDMA code would be much better off it it could > >

Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-02-03 Thread Laszlo Ersek
On 02/03/16 09:44, Gerd Hoffmann wrote: > Hi, > >> I think the "dma_enabled" property is not exposed to the user. > > It is: "-global fw_cfg.dma_enabled=off" works (as in: doesn't throw an > error). Has no effect through as it gets overridden later on. > >> The default value of "dma_enabled"

[Qemu-devel] [PATCH] hw/pxb: add pxb devices to the bridge category

2016-02-03 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum --- hw/pci-bridge/pci_expander_bridge.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expander_bridge.c index 62fd29d..d23b8da 100644 --- a/hw/pci-bridge/pci_expander_bridge.c +++ b/hw/pci-bridge/pci_

Re: [Qemu-devel] [PATCH 2/3] pcdimm: add 'type' field to PCDIMMDeviceInfo

2016-02-03 Thread Vladimir Sementsov-Ogievskiy
On 03.02.2016 01:12, Eric Blake wrote: On 01/27/2016 11:51 PM, Vladimir Sementsov-Ogievskiy wrote: The field is needed to distinguish pc-dimm and nvdimm. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Xiao Guangrong CC: "Michael S. Tsirkin"

Re: [Qemu-devel] [PATCH 3/3] balloon: don't use NVDIMM for ballooning

2016-02-03 Thread Vladimir Sementsov-Ogievskiy
On 02.02.2016 18:30, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: NVDIMM for now is planned to use as a backing store for DAX filesystem in the guest and thus this memory is excluded from guest memory management and LRUs. In this case libvirt running QEMU along with configure

Re: [Qemu-devel] [PATCH] Fix inconsistency between comment and variable name

2016-02-03 Thread Cao jin
On 02/03/2016 05:35 PM, Markus Armbruster wrote: Michael Tokarev writes: 03.02.2016 06:19, Cao jin wrote: Signed-off-by: Cao jin --- include/hw/qdev-core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index abcdee8..

Re: [Qemu-devel] [PATCH v2 00/10] virtio/vring: optimization patches

2016-02-03 Thread Gonglei (Arei)
Hi, > Subject: [Qemu-devel] [PATCH v2 00/10] virtio/vring: optimization patches > > This includes two optimization of virtio: > > - "slimming down" VirtQueueElements by not including room for > 1024 buffers. This makes malloc much faster. > > - optimizations to limit the number of address_sp

Re: [Qemu-devel] [PULL 0/1] Monitor patches for 2016-02-03

2016-02-03 Thread Peter Maydell
On 3 February 2016 at 09:51, Markus Armbruster wrote: > The following changes since commit c65db7705b7926f4a084b93778e4bd5dd3990aad: > > Merge remote-tracking branch > 'remotes/maxreitz/tags/pull-block-for-peter-2016-02-02' into staging > (2016-02-02 18:04:04 +) > > are available in the gi

Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Don't report presence of EL2 if it doesn't exist

2016-02-03 Thread Sergey Fedorov
On 02.02.2016 21:20, Peter Maydell wrote: > We already modify the processor feature bits to not report EL3 > support to the guest if EL3 isn't enabled for the CPU we're emulating. > Add similar support for not reporting EL2 unless it is enabled. > This is necessary because real world guest code run

[Qemu-devel] [PATCH v2] target-mips: implement R6 multi-threading

2016-02-03 Thread Leon Alrae
From: Yongbok Kim MIPS Release 6 provides multi-threading features which replace pre-R6 MT Module. CP0.Config3.MT is always 0 in R6, instead there is new CP0.Config5.VP (Virtual Processor) bit which indicates presence of multi-threading support which includes CP0.GlobalNumber register and DVP/EVP

Re: [Qemu-devel] [PATCH 07/10] virtio: combine the read of a descriptor

2016-02-03 Thread Gonglei (Arei)
Hi, > Subject: [Qemu-devel] [PATCH 07/10] virtio: combine the read of a descriptor > > Compared to vring, virtio has a performance penalty of 10%. Fix it > by combining all the reads for a descriptor in a single address_space_read > call. This also simplifies the code nicely. > > Reviewed-by:

Re: [Qemu-devel] [PATCH] rng-random: implement request queue

2016-02-03 Thread Amit Shah
Hi Ladi, Adding Pankaj to CC, he too looked at this recently. On (Fri) 22 Jan 2016 [13:19:58], Ladi Prosek wrote: > If the guest adds a buffer to the virtio queue while another buffer > is still pending and hasn't been filled and returned by the rng > device, rng-random internally discards the pe

Re: [Qemu-devel] [PATCH v2 00/10] virtio/vring: optimization patches

2016-02-03 Thread Gonglei (Arei)
> -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Paolo Bonzini > Sent: Sunday, January 31, 2016 6:29 PM > To: qemu-devel@nongnu.org > Cc: cornelia.h...@de.ibm.com; m...@redhat.

Re: [Qemu-devel] [PATCH qemu] migration/vmstate: document VMStateFlags

2016-02-03 Thread Amit Shah
On (Thu) 21 Jan 2016 [21:39:27], Sascha Silbe wrote: > The VMState API is rather sparsely documented. Start by describing the > meaning of all VMStateFlags. > > Signed-off-by: Sascha Silbe Thanks, this is much needed. I'm just returning from a long trip, will go through this in a bit.

Re: [Qemu-devel] [PATCH V2 1/2] ARM: PL061: Clear PL061 device state after reset

2016-02-03 Thread Shannon Zhao
Hi Wei, This still has a problem as I said before. If we execute "virsh reboot xxx" during VM booting(i.e. before the PL061 driver loaded), then after VM booting, the VM will not have any reaction to the "virsh reboot xxx". On 2016/2/2 4:49, Wei Huang wrote: > Current QEMU doesn't clear PL061 st

Re: [Qemu-devel] [PULL 0/6] virtio-gpu: bugfixes and spice support preparation

2016-02-03 Thread Peter Maydell
t; Merge remote-tracking branch > 'remotes/maxreitz/tags/pull-block-for-peter-2016-02-02' into staging > (2016-02-02 18:04:04 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-vga-20160203-1 > > for you to fetch changes up to

Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-02-03 Thread Gerd Hoffmann
Hi, > >> I agree that DMA capability should be filtered with machine type. > >> However, that distinction should not be made using the current > >> "dma_enabled" properties (i.e., of "fw_cfg_io_properties" and > >> "fw_cfg_mem_properties". Instead, it should be made in the > >> board-specific ca

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-03 Thread Kirti Wankhede
On 2/3/2016 11:26 AM, Tian, Kevin wrote: [...] * @vgpu_create:Called to allocate basic resouces in graphics * driver for a particular vgpu. * @dev: physical pci device structure on which vgpu *should b

Re: [Qemu-devel] [PATCH v1 13/22] migration: convert RDMA to use QIOChannel interface

2016-02-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, Feb 02, 2016 at 08:01:36PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > This converts the RDMA code to provide a subclass of > > > QIOChannel that uses RDMA for the data transport. > > >

Re: [Qemu-devel] [PATCH v1 13/22] migration: convert RDMA to use QIOChannel interface

2016-02-03 Thread Daniel P. Berrange
On Wed, Feb 03, 2016 at 01:23:04PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Tue, Feb 02, 2016 at 08:01:36PM +, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > This converts the RDMA code to prov

[Qemu-devel] Memory on stellaris board

2016-02-03 Thread Aurelio Remonda
Hello, i was trying to understand how does the sram and flash size works on lm3s6965evb, i found a hardcoded 0x00ff007f as dc0 value and how flash_size and sram_size are calculated based on that hexadecimal. I mean this: flash_size = (((board->dc0 & 0x) + 1) << 1) * 1024; sram_size = ((board->

Re: [Qemu-devel] [PATCH v1 03/22] migration: ensure qemu_fflush() always writes full data amount

2016-02-03 Thread Daniel P. Berrange
On Thu, Jan 28, 2016 at 05:53:46PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > The QEMUFile writev_buffer / put_buffer functions are expected > > to write out the full set of requested data, blocking until > > complete. The qemu_fflush() caller does

Re: [Qemu-devel] Memory on stellaris board

2016-02-03 Thread Peter Maydell
On 3 February 2016 at 13:00, Aurelio Remonda wrote: > Hello, i was trying to understand how does the sram and flash size > works on lm3s6965evb, i found a hardcoded 0x00ff007f as dc0 value and > how flash_size and sram_size are calculated based on that hexadecimal. > I mean this: > > flash_size =

Re: [Qemu-devel] [PATCH v1 07/22] migration: introduce a new QEMUFile impl based on QIOChannel

2016-02-03 Thread Daniel P. Berrange
On Tue, Feb 02, 2016 at 05:06:24PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > Introduce a new QEMUFile implementation that is based on > > the QIOChannel objects. This impl is different from existing > > impls in that there is no file descriptor tha

[Qemu-devel] [PATCH 7/7] target-arm: Enable EL3 for Cortex-A53 and Cortex-A57

2016-02-03 Thread Peter Maydell
Enable EL3 support for our Cortex-A53 and Cortex-A57 CPU models. We have enough implemented now to be able to run real world code at least to some extent (I can boot ARM Trusted Firmware to the point where it pulls in OP-TEE and then falls over because it doesn't have a UEFI image it can chain to).

[Qemu-devel] [PATCH 2/7] target-arm: Implement MDCR_EL3 and SDCR

2016-02-03 Thread Peter Maydell
Implement the MDCR_EL3 register (which is SDCR for AArch32). For the moment we implement it as reads-as-written. Signed-off-by: Peter Maydell --- target-arm/cpu.h| 1 + target-arm/helper.c | 24 2 files changed, 25 insertions(+) diff --git a/target-arm/cpu.h b/targ

[Qemu-devel] [PATCH 5/7] target-arm: Add isread parameter to CPAccessFns

2016-02-03 Thread Peter Maydell
System registers might have access requirements which need to be described via a CPAccessFn and which differ for reads and writes. For this to be possible we need to pass the access function a parameter to tell it whether the access being checked is a read or a write. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH 07/10] virtio: combine the read of a descriptor

2016-02-03 Thread Paolo Bonzini
On 03/02/2016 13:34, Gonglei (Arei) wrote: > Hi, > >> Subject: [Qemu-devel] [PATCH 07/10] virtio: combine the read of a descriptor >> >> Compared to vring, virtio has a performance penalty of 10%. Fix it >> by combining all the reads for a descriptor in a single address_space_read >> call. Thi

Re: [Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort

2016-02-03 Thread Lluís Vilanova
Markus Armbruster writes: > Thomas Huth writes: >> On 03.02.2016 10:48, Markus Armbruster wrote: >>> David Gibson writes: >>> On Tue, Feb 02, 2016 at 10:47:35PM +0100, Thomas Huth wrote: > On 02.02.2016 19:53, Markus Armbruster wrote: >> Lluís Vilanova writes: > ... > >>>

Re: [Qemu-devel] Memory on stellaris board

2016-02-03 Thread Aurelio Remonda
On Wed, Feb 3, 2016 at 10:34 AM, Peter Maydell wrote: > On 3 February 2016 at 13:00, Aurelio Remonda > wrote: >> Hello, i was trying to understand how does the sram and flash size >> works on lm3s6965evb, i found a hardcoded 0x00ff007f as dc0 value and >> how flash_size and sram_size are calculat

Re: [Qemu-devel] [PATCH v9] spec: add qcow2 bitmaps extension specification

2016-02-03 Thread Vladimir Sementsov-Ogievskiy
On 03.02.2016 11:04, Fam Zheng wrote: On Tue, 02/02 09:35, Vladimir Sementsov-Ogievskiy wrote: The new feature for qcow2: storing bitmaps. This patch adds new header extension to qcow2 - Bitmaps Extension. It provides an ability to store virtual disk related bitmaps in a qcow2 image. For now th

  1   2   3   4   >