On 02/03/2016 05:35 PM, Markus Armbruster wrote:
Michael Tokarev <m...@tls.msk.ru> writes:
03.02.2016 06:19, Cao jin wrote:
Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com>
---
include/hw/qdev-core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index abcdee8..42fa5db 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -221,7 +221,7 @@ typedef struct BusChild {
/**
* BusState:
- * @hotplug_device: link to a hotplug device associated with bus.
+ * @hotplug_handler: link to a hotplug device associated with bus.
Hmm. Now while the field name in comment and in the structure
do match, the comment is still wrong, since it is a linke to
a handler, not a device… :)
Do you mean to suggest the line should be changed to
* @hotplug_device: link to a hotplug handler associated with bus.
?
If I understand it right, hotplug_handler is a link property of
BusState, see qbus_initfn(). Tt actually points to a device, see
qbus_set_hotplug_handler(), and the actually hotplug handler is reside
in this device, see how qdev_get_hotplug_handler() is used.
So, base on the talking above, the original comment could be understood
by me:)
--
Yours Sincerely,
Cao jin
