Re: [Qemu-devel] performance in io virtulization

2015-12-22 Thread Stefan Hajnoczi
On Mon, Dec 21, 2015 at 12:40:00PM +0800, 浩樊啊 wrote: > i use qemu 2.2 and zhe vm kernel is 3.18i use fio do experiments in host and > vm: > 4k randwrite/read ioengine=libaio > host: vm: > randread about 200M/S randread about 190M/S

Re: [Qemu-devel] [PATCH v3 0/3] sdhci patches to enable Raspberry Pi

2015-12-22 Thread Stefan Hajnoczi
On Mon, Dec 21, 2015 at 02:47:46PM -0800, Andrew Baumann wrote: > This is a series of three tweaks needed to enable the generic sdhci > controller to emulate Raspberry Pi (bcm2835/2836), and boot Linux and > Windows. > > There was some discussion of these changes in the following thread: > https:/

[Qemu-devel] [Bug 1528239] Re: Unable to debug PIE binaries with QEMU gdb stub.

2015-12-22 Thread Maxim Ostapenko
GDB server itself actually supports PIE binaries. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1528239 Title: Unable to debug PIE binaries with QEMU gdb stub. Status in QEMU: New Bug descripti

Re: [Qemu-devel] [PATCH] iov: avoid memcpy for "simple" iov_from_buf/iov_to_buf

2015-12-22 Thread Stefan Hajnoczi
On Fri, Dec 18, 2015 at 01:08:43PM +0800, Stefan Hajnoczi wrote: > On Wed, Dec 16, 2015 at 11:57:33AM +0100, Paolo Bonzini wrote: > > memcpy can take a large amount of time for small reads and writes. > > For virtio it is a common case that the first iovec can satisfy the > > whole read or write.

[Qemu-devel] [PULL 00/10] Block patches

2015-12-22 Thread Stefan Hajnoczi
The following changes since commit c688084506cf2cf2eba4ba9df4e91abb6e3dab83: Merge remote-tracking branch 'remotes/berrange/tags/pull-qcrypto-secrets-base-2015-12-18-1' into staging (2015-12-18 17:04:15 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/

[Qemu-devel] [PULL 01/10] virtio-blk: trivial code optimization

2015-12-22 Thread Stefan Hajnoczi
From: Gonglei 1. avoid possible superflous checking 2. make code more robustness ["make code more robustness" refers to avoiding integer underflows/overflows. --Stefan] Signed-off-by: Gonglei Message-id: 1447207166-12612-1-git-send-email-arei.gong...@huawei.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 02/10] block: add BlockLimits.max_iov field

2015-12-22 Thread Stefan Hajnoczi
The maximum number of struct iovec elements depends on the BlockDriverState. The raw-posix and iSCSI protocols have a maximum of IOV_MAX but others could have different values. Cc: Peter Lieven Suggested-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/io.c| 7 +++

[Qemu-devel] [PULL 03/10] block-backend: add blk_get_max_iov()

2015-12-22 Thread Stefan Hajnoczi
Add a function to query BlockLimits.max_iov. Signed-off-by: Stefan Hajnoczi --- block/block-backend.c | 5 + include/sysemu/block-backend.h | 1 + 2 files changed, 6 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index 36ccc9e..f41d326 100644 --- a/block/b

[Qemu-devel] [PULL 06/10] parallels: add format spec

2015-12-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy This specifies Parallels image format as implemented in Parallels Cloud Server 6.10 Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Message-id: 1448626806-17591-1-git-send-email-...@openvz.org CC: Eric Blake CC: John Snow CC: Stefa

[Qemu-devel] [PULL 04/10] block: replace IOV_MAX with BlockLimits.max_iov

2015-12-22 Thread Stefan Hajnoczi
Request merging must not result in a huge request that exceeds the maximum number of iovec elements. Use BlockLimits.max_iov instead of hardcoding IOV_MAX. Signed-off-by: Stefan Hajnoczi --- block/io.c| 3 ++- hw/block/virtio-blk.c | 2 +- 2 files changed, 3 insertions(+), 2 deletio

[Qemu-devel] [PULL 05/10] block/mirror: replace IOV_MAX with blk_get_max_iov()

2015-12-22 Thread Stefan Hajnoczi
Use blk_get_max_iov() instead of hardcoding IOV_MAX, which may not apply to all BlockDrivers. Signed-off-by: Stefan Hajnoczi --- block/mirror.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index fc34a9c..f201f2b 100644 --- a/block/mirr

[Qemu-devel] [PULL 07/10] scripts/gdb: Fix a python exception in mtree.py

2015-12-22 Thread Stefan Hajnoczi
From: Yang Wei The following exception is threw: Python Exception name 'long' is not defined: Error occurred in Python command: name 'long' is not defined Python 2.4+, int()/long() have been unified, so replace long with int. Signed-off-by: Yang Wei Message-id: 1449316340-4030-1-git-send-emai

[Qemu-devel] [PULL 08/10] sd: sdhci: Delete over-zealous power check

2015-12-22 Thread Stefan Hajnoczi
From: Peter Crosthwaite This check was conditionalising SD card operation on the card being powered by the SDHCI host controller. It is however possible (particularly in embedded systems) for the power control of the SD card to be managed outside of SDHCI. This can be as trivial as hard-wiring th

[Qemu-devel] [PULL 09/10] sdhci: don't raise a command index error for an unexpected response

2015-12-22 Thread Stefan Hajnoczi
From: Andrew Baumann This deletes a block of code that raised a command index error if a command returned response data, but the guest did not set the appropriate bits in the response register to handle such a response. I cannot find any documentation that suggests the controller should behave in

[Qemu-devel] [PULL 10/10] sdhci: add optional quirk property to disable card insertion/removal interrupts

2015-12-22 Thread Stefan Hajnoczi
From: Andrew Baumann This is needed for a quirk of the Raspberry Pi (bcm2835/6) MMC controller, where the card insert bit is documented as unimplemented (always reads zero, doesn't generate interrupts) but is in fact observed on hardware as set at power on, but is cleared (and remains clear) on s

Re: [Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure

2015-12-22 Thread P J P
+-- On Tue, 22 Dec 2015, Miao Yan wrote --+ | > If '1' indicates the error, the 'default:' case in the same switch needs to be | > updated too. | | '1' indicates an error on device activation. Not sure about the 'unknown | command' case. Ideally it should be same, inconsistent return codes wo

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-22 Thread Cao jin
On 12/22/2015 03:34 PM, Marcel Apfelbaum wrote: On 12/22/2015 05:58 AM, Cao jin wrote: On 12/21/2015 11:49 PM, Paolo Bonzini wrote: On 20/12/2015 12:38, Cao jin wrote: +object_unref(OBJECT(ds)); +object_unref(OBJECT(bds)); +object_unref(OBJECT(bus)); I think these should b

Re: [Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure

2015-12-22 Thread Miao Yan
2015-12-22 17:06 GMT+08:00 P J P : > +-- On Tue, 22 Dec 2015, Miao Yan wrote --+ > | > If '1' indicates the error, the 'default:' case in the same switch needs > to be > | > updated too. > | > | '1' indicates an error on device activation. Not sure about the 'unknown > | command' case. > > Ideal

Re: [Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure

2015-12-22 Thread Dmitry Fleytman
> On 22 Dec 2015, at 11:26 AM, Miao Yan wrote: > > 2015-12-22 17:06 GMT+08:00 P J P : >> +-- On Tue, 22 Dec 2015, Miao Yan wrote --+ >> | > If '1' indicates the error, the 'default:' case in the same switch needs >> to be >> | > updated too. >> | >> | '1' indicates an error on device activation

Re: [Qemu-devel] [PATCH v2 58/74] pc: acpi: piix4: move PCI0._PRT() into SSDT

2015-12-22 Thread Michael S. Tsirkin
On Mon, Dec 21, 2015 at 01:55:16PM +0100, Igor Mammedov wrote: > On Sat, 19 Dec 2015 21:23:22 +0200 > "Michael S. Tsirkin" wrote: > > > On Thu, Dec 10, 2015 at 05:17:07PM +0100, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > > v2: > > > - adapt build_prt() for using for P

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-22 Thread Marcel Apfelbaum
On 12/22/2015 11:16 AM, Cao jin wrote: On 12/22/2015 03:34 PM, Marcel Apfelbaum wrote: On 12/22/2015 05:58 AM, Cao jin wrote: On 12/21/2015 11:49 PM, Paolo Bonzini wrote: On 20/12/2015 12:38, Cao jin wrote: +object_unref(OBJECT(ds)); +object_unref(OBJECT(bds)); +object_unre

Re: [Qemu-devel] [PATCH 54/74] pc: acpi: move remaining GPE handlers into SSDT

2015-12-22 Thread Michael S. Tsirkin
On Mon, Dec 21, 2015 at 04:35:23PM +0100, Igor Mammedov wrote: > On Sat, 19 Dec 2015 22:34:55 +0200 > "Michael S. Tsirkin" wrote: > > > On Thu, Dec 10, 2015 at 12:41:48AM +0100, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > > hw/i386/acpi-build.c | 26 ++

[Qemu-devel] [PATCH 1/1] doc: document chardev option 'append'

2015-12-22 Thread Denis V. Lunev
commit 31e38a22a0c5a25646f966f001e1f5513d5a186d Author: Olga Krishtal Date: Fri Dec 4 09:42:04 2015 +0300 qemu-char: append opt to stop truncation of serial file has added the option to the runtime but does not added it to -help output. This blocks libvirt from using it. S

[Qemu-devel] [PATCH v2 1/1] doc: document chardev option 'append'

2015-12-22 Thread Denis V. Lunev
commit 31e38a22a0c5a25646f966f001e1f5513d5a186d Author: Olga Krishtal Date: Fri Dec 4 09:42:04 2015 +0300 qemu-char: append opt to stop truncation of serial file has added the option to the runtime but does not added it to -help output. This blocks libvirt from using it. S

[Qemu-devel] [PATCH] block/qapi: Clear err for further error

2015-12-22 Thread Fam Zheng
Since a5002d5 (block/qapi: allow best-effort query) we don't return at this error, however err must be cleared before passing to bdrv_query_snapshot_info_list below, as required by error API. Signed-off-by: Fam Zheng --- block/qapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qapi

Re: [Qemu-devel] [PATCH v2 1/1] doc: document chardev option 'append'

2015-12-22 Thread Daniel P. Berrange
On Tue, Dec 22, 2015 at 12:49:09PM +0300, Denis V. Lunev wrote: > commit 31e38a22a0c5a25646f966f001e1f5513d5a186d > Author: Olga Krishtal > Date: Fri Dec 4 09:42:04 2015 +0300 > > qemu-char: append opt to stop truncation of serial file > > has added the option to the runtim

Re: [Qemu-devel] [PATCH v2 1/1] doc: document chardev option 'append'

2015-12-22 Thread Denis V. Lunev
On 12/22/2015 01:26 PM, Daniel P. Berrange wrote: On Tue, Dec 22, 2015 at 12:49:09PM +0300, Denis V. Lunev wrote: commit 31e38a22a0c5a25646f966f001e1f5513d5a186d Author: Olga Krishtal Date: Fri Dec 4 09:42:04 2015 +0300 qemu-char: append opt to stop truncation of seri

[Qemu-devel] [PATCH v2] iov: avoid memcpy for "simple" iov_from_buf/iov_to_buf

2015-12-22 Thread Paolo Bonzini
memcpy can take a large amount of time for small reads and writes. For virtio it is a common case that the first iovec can satisfy the whole read or write. In that case, and if bytes is a constant to avoid excessive growth of code, inline the first iteration into the caller. Signed-off-by: Paolo

[Qemu-devel] [PATCH 6/7] qemu-nbd: allow specifying image as a set of options args

2015-12-22 Thread Daniel P. Berrange
Currently qemu-nbd allows an image filename to be passed on the command line, but does not have a way to set any options except the format eg qemu-nbd https://127.0.0.1/images/centos7.iso qemu-nbd /home/berrange/demo.qcow2 This adds a --source arg (that is mutually exclusive with a position

[Qemu-devel] [PATCH 1/7] qom: add user_creatable_add & user_creatable_del methods

2015-12-22 Thread Daniel P. Berrange
The QMP monitor code has two helper methods object_add and qmp_object_del that are called from several places in the code (QMP, HMP and main emulator startup). We soon need to use this code from qemu-img, qemu-io and qemu-nbd too, but don't want those to depend on the monitor. To avoid this, move

[Qemu-devel] [PATCH 0/7] Make qemu-img/qemu-nbd/qemu-io CLI more flexible

2015-12-22 Thread Daniel P. Berrange
This series of patches expands the syntax of the qemu-img, qemu-nbd and qemu-io commands to make them more flexible. First all three gain a --object parameter, which allows instantiation of user creatable object types. The immediate use case is to allow for creation of the 'secret' object type to

[Qemu-devel] [PATCH 5/7] qemu-io: allow specifying image as a set of options args

2015-12-22 Thread Daniel P. Berrange
Currently qemu-io allows an image filename to be passed on the command line, but does not have a way to set any options except the format eg qemu-io https://127.0.0.1/images/centos7.iso qemu-io /home/berrange/demo.qcow2 This adds a --source arg (that is mutually exclusive with a positional file

[Qemu-devel] [PATCH 3/7] qemu-nbd: add support for --object command line arg

2015-12-22 Thread Daniel P. Berrange
Allow creation of user creatable object types with qemu-nbd via a --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # echo -n letmein > mypasswd.txt # qemu-nbd --object secret,

[Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args

2015-12-22 Thread Daniel P. Berrange
Currently qemu-img allows an image filename to be passed on the command line, but does not have a way to set any options except the format eg qemu-img info https://127.0.0.1/images/centos7.iso This adds a --source arg (that is mutually exclusive with a positional filename arg and -f arg) that

[Qemu-devel] [PATCH 4/7] qemu-io: add support for --object command line arg

2015-12-22 Thread Daniel P. Berrange
Allow creation of user creatable object types with qemu-io via a --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # echo -n letmein > mypasswd.txt # qemu-io --object secret,id

[Qemu-devel] [PATCH 2/7] qemu-img: add support for --object command line arg

2015-12-22 Thread Daniel P. Berrange
Allow creation of user creatable object types with qemu-img via a --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # echo -n letmein > mypasswd.txt # qemu-img info --object se

Re: [Qemu-devel] [PATCH v2] xen-pvdevice: convert to realize()

2015-12-22 Thread Stefano Stabellini
On Tue, 22 Dec 2015, Cao jin wrote: > Signed-off-by: Cao jin Acked-by: Stefano Stabellini > hw/i386/xen/xen_pvdevice.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/hw/i386/xen/xen_pvdevice.c b/hw/i386/xen/xen_pvdevice.c > index c218947..9abcf25 100644

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-22 Thread Cao jin
On 12/22/2015 05:35 PM, Marcel Apfelbaum wrote: On 12/22/2015 11:16 AM, Cao jin wrote: On 12/22/2015 03:34 PM, Marcel Apfelbaum wrote: On 12/22/2015 05:58 AM, Cao jin wrote: On 12/21/2015 11:49 PM, Paolo Bonzini wrote: On 20/12/2015 12:38, Cao jin wrote: +object_unref(OBJECT(ds)

[Qemu-devel] [RFC PATCH v2 02/10] Jhash: add linux kernel jhashtable in qemu

2015-12-22 Thread Zhang Chen
From: zhangchen Jhash used by colo-proxy to save and lookup net connection info Signed-off-by: zhangchen Signed-off-by: zhanghailiang --- include/qemu/jhash.h | 61 1 file changed, 61 insertions(+) create mode 100644 include/qemu/jhash.h

[Qemu-devel] [RFC PATCH v2 06/10] net/colo-proxy: add socket used by forward func

2015-12-22 Thread Zhang Chen
From: zhangchen Colo need to forward packets we start socket server in secondary and primary connect to secondary in startup the packet recv by primary forward to secondary the packet send by secondary forward to primary Signed-off-by: zhangchen Signed-off-by: zhanghailiang --- net/colo-proxy

[Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2015-12-22 Thread Zhang Chen
From: zhangchen Hi,all This patch add an colo-proxy object, COLO-Proxy is a part of COLO, based on qemu netfilter and it's a plugin for qemu netfilter. the function keep Secondary VM connect normal to Primary VM and compare packets sent by PVM to sent by SVM.if the packet difference,notify COLO

[Qemu-devel] [RFC PATCH v2 01/10] Init colo-proxy object based on netfilter

2015-12-22 Thread Zhang Chen
From: zhangchen add colo-proxy to vl.c and qemu-options.hx add trace-colo-proxy relation Signed-off-by: zhangchen Signed-off-by: zhanghailiang --- qemu-options.hx | 6 ++ trace-events| 8 vl.c| 3 ++- 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/

[Qemu-devel] [RFC PATCH v2 03/10] Colo-proxy: add colo-proxy framework

2015-12-22 Thread Zhang Chen
From: zhangchen Colo-proxy is a plugin of qemu netfilter like filter-buffer and dump Signed-off-by: zhangchen Signed-off-by: zhanghailiang --- net/Makefile.objs | 1 + net/colo-proxy.c | 240 ++ net/colo-proxy.h | 24 ++ 3 files cha

[Qemu-devel] [RFC PATCH v2 07/10] net/colo-proxy: Add packet enqueue & handle func

2015-12-22 Thread Zhang Chen
From: zhangchen Add common packet handle function and enqueue packet distinguished connection,then we can lookup one connection packet to compare Signed-off-by: zhangchen Signed-off-by: zhanghailiang --- net/colo-proxy.c | 148 ++- 1 file ch

[Qemu-devel] [PATCH] docs/pci_expander_bridge: fix typo

2015-12-22 Thread Cao jin
Signed-off-by: Cao jin --- docs/pci_expander_bridge.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/pci_expander_bridge.txt b/docs/pci_expander_bridge.txt index d7913fb..e7c8fe9 100644 --- a/docs/pci_expander_bridge.txt +++ b/docs/pci_expander_bridge.txt @@ -23,

[Qemu-devel] [RFC PATCH v2 04/10] Colo-proxy: add data structure and jhash func

2015-12-22 Thread Zhang Chen
From: zhangchen add data structure and hash func will be uesed Signed-off-by: zhangchen Signed-off-by: zhanghailiang --- net/colo-proxy.c | 66 1 file changed, 66 insertions(+) diff --git a/net/colo-proxy.c b/net/colo-proxy.c index 2e3

[Qemu-devel] [RFC PATCH v2 08/10] net/colo-proxy: Handle packet and connection

2015-12-22 Thread Zhang Chen
From: zhangchen In here we will handle ip packet and connection Signed-off-by: zhangchen Signed-off-by: zhanghailiang --- net/colo-proxy.c | 130 +++ 1 file changed, 130 insertions(+) diff --git a/net/colo-proxy.c b/net/colo-proxy.c index 5

[Qemu-devel] [RFC PATCH v2 10/10] net/colo-proxy: Colo-proxy do checkpoint and clear

2015-12-22 Thread Zhang Chen
From: zhangchen Do checkpoint and flush Signed-off-by: zhangchen Signed-off-by: zhanghailiang --- net/colo-proxy.c | 88 1 file changed, 88 insertions(+) diff --git a/net/colo-proxy.c b/net/colo-proxy.c index abb289f..79b1b1b 100644 --

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-22 Thread Cao jin
Hi, Marcel On 12/22/2015 05:35 PM, Marcel Apfelbaum wrote: On 12/22/2015 11:16 AM, Cao jin wrote: [...] Sure, just add something like: fprintf(stderr, "ds parent: %p, bus parent... ", ds->parent ...) Compile and run QEMU with a pxb device: -device pxb,bus=80,... And look for w

[Qemu-devel] [RFC PATCH v2 05/10] net/colo-proxy: Add colo interface to use proxy

2015-12-22 Thread Zhang Chen
From: zhangchen Add interface used by migration/colo.c so colo framework can work with proxy Signed-off-by: zhangchen Signed-off-by: zhanghailiang --- net/colo-proxy.c | 93 1 file changed, 93 insertions(+) diff --git a/net/colo-proxy.

[Qemu-devel] [RFC PATCH v2 09/10] net/colo-proxy: Compare pri pkt to sec pkt

2015-12-22 Thread Zhang Chen
From: zhangchen We will compare packet sent by primary guest to secondary guest,if same,send primary packet. else we will notify colo to do checkpoint to make secondary guset running same as primary Signed-off-by: zhangchen Signed-off-by: zhanghailiang --- net/colo-proxy.c | 64 ++

[Qemu-devel] [PATCH v3] PXB: convert to realize()

2015-12-22 Thread Cao jin
Signed-off-by: Cao jin --- v3 changelog: 1. As per Paolo`s review, also Marcel`s test suggestion, just unparent bus object while unref the ds & bds object hw/pci-bridge/pci_expander_bridge.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git

[Qemu-devel] [PATCH v3] PXB: convert to realize()

2015-12-22 Thread Cao jin
Signed-off-by: Cao jin --- v3 changelog: 1. As per Paolo`s review, also Marcel`s test suggestion, just unparent bus object while unref the ds & bds object hw/pci-bridge/pci_expander_bridge.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git

[Qemu-devel] [PATCH] net: rocker: fix an incorrect array bounds check

2015-12-22 Thread P J P
Hello Scott, Jiri A stack overflow issue was reported by Mr Qinghao Tang, CC'd here. It occurs while processing transmit(tx) descriptors in tx_consume() routine. If a descriptor was to have more than allowed(ROCKER_TX_FRAGS_MAX=16) packet fragments, the processing loop suffers an off-by-one

Re: [Qemu-devel] [PATCH COLO-Frame v12 11/38] COLO: Add a new RunState RUN_STATE_COLO

2015-12-22 Thread Hailiang Zhang
On 2015/12/19 17:27, Markus Armbruster wrote: zhanghailiang writes: Guest will enter this state when paused to save/restore VM state under colo checkpoint. Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Gonglei Reviewed-by: Dr.

Re: [Qemu-devel] [PATCH] net: rocker: fix an incorrect array bounds check

2015-12-22 Thread Jiri Pirko
Tue, Dec 22, 2015 at 02:07:01PM CET, ppan...@redhat.com wrote: > Hello Scott, Jiri > >A stack overflow issue was reported by Mr Qinghao Tang, CC'd here. It occurs >while processing transmit(tx) descriptors in tx_consume() routine. If a >descriptor was to have more than allowed(ROCKER_TX_FRAGS_MAX=

Re: [Qemu-devel] [PATCH COLO-Frame v12 19/38] COLO: Add checkpoint-delay parameter for migrate-set-parameters

2015-12-22 Thread Hailiang Zhang
On 2015/12/19 17:33, Markus Armbruster wrote: zhanghailiang writes: Add checkpoint-delay parameter for migrate-set-parameters, so that we can control the checkpoint frequency when COLO is in periodic mode. Cc: Luiz Capitulino Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: zhanghailian

Re: [Qemu-devel] [Xen-devel] [PATCH v3 13/13] xen-hvm: Mark inappropriate error handling FIXME

2015-12-22 Thread Stefano Stabellini
On Thu, 17 Dec 2015, Markus Armbruster wrote: > Cc: Stefano Stabellini > Cc: xen-de...@lists.xensource.com > Signed-off-by: Markus Armbruster > --- > xen-hvm.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/xen-hvm.c b/xen-hvm.c > index 3d78a0c..2a93390 100644 > --- a/xen-hvm.c

Re: [Qemu-devel] [PATCH COLO-Frame v12 21/38] COLO failover: Introduce a new command to trigger a failover

2015-12-22 Thread Hailiang Zhang
On 2015/12/19 17:38, Markus Armbruster wrote: zhanghailiang writes: We leave users to choose whatever heartbeat solution they want, if the heartbeat is lost, or other errors they detect, they can use experimental command 'x_colo_lost_heartbeat' to tell COLO to do failover, COLO will do operati

Re: [Qemu-devel] [PATCH v2 58/74] pc: acpi: piix4: move PCI0._PRT() into SSDT

2015-12-22 Thread Igor Mammedov
On Tue, 22 Dec 2015 11:34:46 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 21, 2015 at 01:55:16PM +0100, Igor Mammedov wrote: > > On Sat, 19 Dec 2015 21:23:22 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Dec 10, 2015 at 05:17:07PM +0100, Igor Mammedov wrote: > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH v3] PXB: convert to realize()

2015-12-22 Thread Marcel Apfelbaum
On 12/22/2015 02:50 PM, Cao jin wrote: Signed-off-by: Cao jin --- v3 changelog: 1. As per Paolo`s review, also Marcel`s test suggestion, just unparent bus object while unref the ds & bds object hw/pci-bridge/pci_expander_bridge.c | 33 +++-- 1 file changed, 19

Re: [Qemu-devel] [PATCH] docs/pci_expander_bridge: fix typo

2015-12-22 Thread Marcel Apfelbaum
Cc: qemu-triv...@nongnu.org Anyway, Reviewed-by: Marcel Apfelbaum Thanks, Marcel On 12/22/2015 02:00 PM, Cao jin wrote: Signed-off-by: Cao jin --- docs/pci_expander_bridge.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/pci_expander_bridge.txt b/docs/pc

Re: [Qemu-devel] [PULL 0/1] NUMA queue, 2015-12-18

2015-12-22 Thread Peter Maydell
On 18 December 2015 at 17:54, Eduardo Habkost wrote: > The following changes since commit c688084506cf2cf2eba4ba9df4e91abb6e3dab83: > > Merge remote-tracking branch > 'remotes/berrange/tags/pull-qcrypto-secrets-base-2015-12-18-1' into staging > (2015-12-18 17:04:15 +) > > are available in

[Qemu-devel] Request for Help (Generate Trace for Individual Instructions)

2015-12-22 Thread Junaid Aslam
Dear Sir I am a student in Netherlands TU/e and intend to explore QEMU for a project. I need help in understanding how i can trace an individual instruction which is translated by TCG. For this moment in am more interested in Guest load store and Function call instructions. Can you please help me

Re: [Qemu-devel] [PATCH 1/8] bcm2835_sbm: add BCM2835 mailboxes

2015-12-22 Thread Grégory ESTRADE
Indeed, this header is generated from the Broadcom's Linux drivers headers, with a Perl script. On Tue, Dec 22, 2015 at 12:33 AM, Peter Crosthwaite < crosthwaitepe...@gmail.com> wrote: > On Mon, Dec 21, 2015 at 3:15 PM, Andrew Baumann > wrote: > > Hi Peter, > > > > Thanks for the review! > > > >

Re: [Qemu-devel] [PATCH 1/8] bcm2835_sbm: add BCM2835 mailboxes

2015-12-22 Thread Grégory ESTRADE
Hi, The "sbm" is a typo. It was meant to be "smb": Semaphore MailBoxes... Sorry about that. Regards, Gregory On Tue, Dec 22, 2015 at 12:15 AM, Andrew Baumann < andrew.baum...@microsoft.com> wrote: > Hi Peter, > > Thanks for the review! > > > From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail

Re: [Qemu-devel] [PATCH 1/1] doc: document chardev option 'append'

2015-12-22 Thread Dmitry Mishin
On 22/12/15 12:43, "Denis V. Lunev" wrote: >commit 31e38a22a0c5a25646f966f001e1f5513d5a186d >Author: Olga Krishtal >Date: Fri Dec 4 09:42:04 2015 +0300 > >qemu-char: append opt to stop truncation of serial file > >has added the option to the runtime but does not added it

Re: [Qemu-devel] [PATCH] block/qapi: Clear err for further error

2015-12-22 Thread John Snow
On 12/22/2015 05:11 AM, Fam Zheng wrote: > Since a5002d5 (block/qapi: allow best-effort query) we don't return at > this error, however err must be cleared before passing to > bdrv_query_snapshot_info_list below, as required by error API. > > Signed-off-by: Fam Zheng > --- > block/qapi.c | 1 +

Re: [Qemu-devel] [PATCH 54/74] pc: acpi: move remaining GPE handlers into SSDT

2015-12-22 Thread Igor Mammedov
On Tue, 22 Dec 2015 11:37:40 +0200 "Michael S. Tsirkin" wrote: [...] > > > > +for (i = 4; i <= 0xF; i++) { > > > > +char *name = g_strdup_printf("_L0%X", i); > > > > +method = aml_method(name, 0, AML_NOTSERIALIZED); > > > > +aml_append(scope, method); >

Re: [Qemu-devel] [PULL v1 4/9] io: add QIOChannelSocket class

2015-12-22 Thread Peter Maydell
On 17 December 2015 at 13:45, Daniel P. Berrange wrote: > Implement a QIOChannel subclass that supports sockets I/O. > The implementation is able to manage a single socket file > descriptor, whether a TCP/UNIX listener, TCP/UNIX connection, > or a UDP datagram. It provides APIs which can listen an

Re: [Qemu-devel] [PATCH] net: rocker: fix an incorrect array bounds check

2015-12-22 Thread P J P
+-- On Tue, 22 Dec 2015, Jiri Pirko wrote --+ | >From f3461d8098a0572786f5a2d7a492863090c73134 Mon Sep 17 00:00:00 2001 | >From: Prasad J Pandit | >Date: Tue, 22 Dec 2015 18:21:00 +0530 | >Subject: [PATCH] net: rocker: fix an incorrect array bounds check | > | >While processing transmit(tx) descri

Re: [Qemu-devel] [PATCH] net: rocker: fix an incorrect array bounds check

2015-12-22 Thread Paolo Bonzini
On 22/12/2015 14:07, P J P wrote: > Hello Scott, Jiri > > A stack overflow issue was reported by Mr Qinghao Tang, CC'd here. It > occurs while processing transmit(tx) descriptors in tx_consume() > routine. If a descriptor was to have more than > allowed(ROCKER_TX_FRAGS_MAX=16) packet fragments

Re: [Qemu-devel] [PATCH 54/74] pc: acpi: move remaining GPE handlers into SSDT

2015-12-22 Thread Michael S. Tsirkin
On Tue, Dec 22, 2015 at 03:38:24PM +0100, Igor Mammedov wrote: > On Tue, 22 Dec 2015 11:37:40 +0200 > "Michael S. Tsirkin" wrote: > > [...] > > > > > +for (i = 4; i <= 0xF; i++) { > > > > > +char *name = g_strdup_printf("_L0%X", i); > > > > > +method = aml_method(n

Re: [Qemu-devel] [PULL 00/10] Block patches

2015-12-22 Thread Peter Maydell
On 22 December 2015 at 08:54, Stefan Hajnoczi wrote: > The following changes since commit c688084506cf2cf2eba4ba9df4e91abb6e3dab83: > > Merge remote-tracking branch > 'remotes/berrange/tags/pull-qcrypto-secrets-base-2015-12-18-1' into staging > (2015-12-18 17:04:15 +) > > are available in

Re: [Qemu-devel] [PULL v1 4/9] io: add QIOChannelSocket class

2015-12-22 Thread Daniel P. Berrange
On Tue, Dec 22, 2015 at 02:44:00PM +, Peter Maydell wrote: > On 17 December 2015 at 13:45, Daniel P. Berrange wrote: > > Implement a QIOChannel subclass that supports sockets I/O. > > The implementation is able to manage a single socket file > > descriptor, whether a TCP/UNIX listener, TCP/UNI

Re: [Qemu-devel] [PATCH v2 58/74] pc: acpi: piix4: move PCI0._PRT() into SSDT

2015-12-22 Thread Michael S. Tsirkin
On Tue, Dec 22, 2015 at 03:12:01PM +0100, Igor Mammedov wrote: > On Tue, 22 Dec 2015 11:34:46 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Dec 21, 2015 at 01:55:16PM +0100, Igor Mammedov wrote: > > > On Sat, 19 Dec 2015 21:23:22 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Thu,

Re: [Qemu-devel] [PATCH 54/74] pc: acpi: move remaining GPE handlers into SSDT

2015-12-22 Thread Igor Mammedov
On Tue, 22 Dec 2015 16:47:18 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 22, 2015 at 03:38:24PM +0100, Igor Mammedov wrote: > > On Tue, 22 Dec 2015 11:37:40 +0200 > > "Michael S. Tsirkin" wrote: > > > > [...] > > > > > > +for (i = 4; i <= 0xF; i++) { > > > > > > +char *n

Re: [Qemu-devel] [PATCH v3 1/2] i386: expose floppy-related objects in SSDT

2015-12-22 Thread Michael S. Tsirkin
On Fri, Dec 18, 2015 at 10:32:29PM +0300, Roman Kagan wrote: > On x86-based systems Linux determines the presence and the type of > floppy drives via a query of a CMOS field. So does SeaBIOS when > populating the return data for int 0x13 function 0x08. > > Windows doesn't; instead, it requests th

Re: [Qemu-devel] [PATCH v2 26/74] pc: acpi: memhp: move MHPD._STA method into SSDT

2015-12-22 Thread Michael S. Tsirkin
On Mon, Dec 21, 2015 at 06:31:40PM +0100, Igor Mammedov wrote: > On Sun, 20 Dec 2015 15:41:22 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Dec 16, 2015 at 03:47:35PM +0100, Igor Mammedov wrote: > [...] > > > +method = aml_method("_STA", 0, AML_NOTSERIALIZED); > > > +ifctx = a

Re: [Qemu-devel] [PATCH v3 1/2] i386: expose floppy-related objects in SSDT

2015-12-22 Thread Roman Kagan
On Tue, Dec 22, 2015 at 05:07:16PM +0200, Michael S. Tsirkin wrote: > On Fri, Dec 18, 2015 at 10:32:29PM +0300, Roman Kagan wrote: > > On x86-based systems Linux determines the presence and the type of > > floppy drives via a query of a CMOS field. So does SeaBIOS when > > populating the return da

Re: [Qemu-devel] [PATCH 24/74] acpi: extend aml_interrupt() to support multiple irqs

2015-12-22 Thread Michael S. Tsirkin
On Thu, Dec 10, 2015 at 12:41:18AM +0100, Igor Mammedov wrote: > ASL Interrupt() macro translates to Extended Interrupt Descriptor > which supports variable number of IRQs. It will be used for > conversion of ASL code for pc/q35 machines that use it for > returning several IRQs in _PSR object. > >

Re: [Qemu-devel] [PATCH 01/74] tests: acpi: print ASL diff in verbose mode

2015-12-22 Thread Michael S. Tsirkin
On Thu, Dec 10, 2015 at 12:40:55AM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > tests/bios-tables-test.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 6d37332..50678b5 100644 > --- a/tests/bios-ta

Re: [Qemu-devel] [PATCH 24/74] acpi: extend aml_interrupt() to support multiple irqs

2015-12-22 Thread Igor Mammedov
On Tue, 22 Dec 2015 17:17:33 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 10, 2015 at 12:41:18AM +0100, Igor Mammedov wrote: > > ASL Interrupt() macro translates to Extended Interrupt Descriptor > > which supports variable number of IRQs. It will be used for > > conversion of ASL code for pc/q

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-22 Thread Kevin O'Connor
On Tue, Dec 22, 2015 at 03:15:26AM +, Xulei (Stone) wrote: > Hi, Kevin, > Can you tell how to reset/reboot this VM, if it goes to the handle_hwpic1() > on its booting procedure? I mean, usually, SeaBIOS would not go to > handle_hwpic routine. But in my test case, SeaBIOS calls handle_hwpic whe

Re: [Qemu-devel] [PATCH v2 26/74] pc: acpi: memhp: move MHPD._STA method into SSDT

2015-12-22 Thread Igor Mammedov
On Tue, 22 Dec 2015 17:11:46 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 21, 2015 at 06:31:40PM +0100, Igor Mammedov wrote: > > On Sun, 20 Dec 2015 15:41:22 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Dec 16, 2015 at 03:47:35PM +0100, Igor Mammedov wrote: > > [...] > > > > +

[Qemu-devel] [PATCH] io: bind to loopback IP addrs in test suite

2015-12-22 Thread Daniel P. Berrange
The test suite currently binds to 0.0.0.0 or ::, which covers all interfaces of the machine. It is bad practice for test suite to open publically accessible ports on a machine, so switch to use loopback addrs 127.0.0.1 or ::1. Reported-by: Peter Maydell Signed-off-by: Daniel P. Berrange --- tes

Re: [Qemu-devel] [PATCH 3/6] crypto: move QCryptoHashAlgorithm enum definition into QAPI

2015-12-22 Thread Daniel P. Berrange
On Mon, Dec 21, 2015 at 09:27:15AM -0700, Eric Blake wrote: > On 12/21/2015 09:06 AM, Daniel P. Berrange wrote: > > The QCryptoHashAlgorithm enum is defined in the crypto/hash.h > > header. In the future some QAPI types will want to reference > > the hash enums, so move the enum definition into QAP

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-22 Thread Kevin O'Connor
On Tue, Dec 22, 2015 at 02:14:12AM +, Gonglei (Arei) wrote: > > From: Kevin O'Connor [mailto:ke...@koconnor.net] > > Sent: Tuesday, December 22, 2015 2:47 AM > > To: Gonglei (Arei) > > Cc: Xulei (Stone); Paolo Bonzini; qemu-devel; seab...@seabios.org; > > Huangweidong (C); k...@vger.kernel.org;

Re: [Qemu-devel] [PATCH 5/6] crypto: ensure qapi/crypto.json is listed in qapi-modules

2015-12-22 Thread Daniel P. Berrange
On Mon, Dec 21, 2015 at 09:32:42AM -0700, Eric Blake wrote: > On 12/21/2015 09:06 AM, Daniel P. Berrange wrote: > > The rebuild of qapi-types.c/h is not correctly triggered > > when qapi/crypto.json is changed because it was missing > > from the list of files in the qapi-modules variable. > > > >

Re: [Qemu-devel] [PATCH v2 1/1] doc: document chardev option 'append'

2015-12-22 Thread Eric Blake
On 12/22/2015 02:49 AM, Denis V. Lunev wrote: > commit 31e38a22a0c5a25646f966f001e1f5513d5a186d > Author: Olga Krishtal > Date: Fri Dec 4 09:42:04 2015 +0300 > > qemu-char: append opt to stop truncation of serial file > > has added the option to the runtime but does not add

Re: [Qemu-devel] [PATCH 01/74] tests: acpi: print ASL diff in verbose mode

2015-12-22 Thread Igor Mammedov
On Tue, 22 Dec 2015 17:28:42 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 10, 2015 at 12:40:55AM +0100, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > tests/bios-tables-test.c | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/tests/bios-tables-test.c b

Re: [Qemu-devel] [PATCH v3 1/2] i386: expose floppy-related objects in SSDT

2015-12-22 Thread Igor Mammedov
On Fri, 18 Dec 2015 22:32:29 +0300 Roman Kagan wrote: > On x86-based systems Linux determines the presence and the type of > floppy drives via a query of a CMOS field. So does SeaBIOS when > populating the return data for int 0x13 function 0x08. > > Windows doesn't; instead, it requests this in

Re: [Qemu-devel] [PATCH 24/74] acpi: extend aml_interrupt() to support multiple irqs

2015-12-22 Thread Michael S. Tsirkin
On Tue, Dec 22, 2015 at 04:37:11PM +0100, Igor Mammedov wrote: > On Tue, 22 Dec 2015 17:17:33 +0200 > "Michael S. Tsirkin" wrote: > > > On Thu, Dec 10, 2015 at 12:41:18AM +0100, Igor Mammedov wrote: > > > ASL Interrupt() macro translates to Extended Interrupt Descriptor > > > which supports varia

Re: [Qemu-devel] [PATCH 1/7] qom: add user_creatable_add & user_creatable_del methods

2015-12-22 Thread Eric Blake
On 12/22/2015 04:06 AM, Daniel P. Berrange wrote: > The QMP monitor code has two helper methods object_add > and qmp_object_del that are called from several places > in the code (QMP, HMP and main emulator startup). > > We soon need to use this code from qemu-img, qemu-io > and qemu-nbd too, but d

Re: [Qemu-devel] [PATCH 01/74] tests: acpi: print ASL diff in verbose mode

2015-12-22 Thread Michael S. Tsirkin
On Tue, Dec 22, 2015 at 04:54:06PM +0100, Igor Mammedov wrote: > On Tue, 22 Dec 2015 17:28:42 +0200 > "Michael S. Tsirkin" wrote: > > > On Thu, Dec 10, 2015 at 12:40:55AM +0100, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > > tests/bios-tables-test.c | 7 +++ > > > 1

Re: [Qemu-devel] [PATCH 24/74] acpi: extend aml_interrupt() to support multiple irqs

2015-12-22 Thread Igor Mammedov
On Tue, 22 Dec 2015 17:58:41 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 22, 2015 at 04:37:11PM +0100, Igor Mammedov wrote: > > On Tue, 22 Dec 2015 17:17:33 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Dec 10, 2015 at 12:41:18AM +0100, Igor Mammedov wrote: > > > > ASL Interrupt()

Re: [Qemu-devel] [Qemu-block] Jobs 2.0 QAPI [RFC]

2015-12-22 Thread Alberto Garcia
On Mon 21 Dec 2015 08:40:26 PM CET, John Snow wrote: > However, better flexibility also plays a part. Say we have two devices: > > [drive0]: [X] --> [Y] --> [Z] > [drive1]: [A] --> [B] > > In theory, we should be able to commit Z into Y into X while we > simultaneously perform a backup from X to A

[Qemu-devel] [PULL 0/4] xen-2015-12-22

2015-12-22 Thread Stefano Stabellini
The following changes since commit c3626ca7df027dabf0568284360a23faf18f0884: Update version for v2.5.0-rc3 release (2015-12-07 17:47:40 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-2015-12-22 for you to fetch changes up to fc3e

Re: [Qemu-devel] [Qemu-block] Jobs 2.0 QAPI [RFC]

2015-12-22 Thread John Snow
On 12/22/2015 11:19 AM, Alberto Garcia wrote: > On Mon 21 Dec 2015 08:40:26 PM CET, John Snow wrote: >> However, better flexibility also plays a part. Say we have two devices: >> >> [drive0]: [X] --> [Y] --> [Z] >> [drive1]: [A] --> [B] >> >> In theory, we should be able to commit Z into Y into

[Qemu-devel] [PULL 1/4] xen/MSI-X: latch MSI-X table writes

2015-12-22 Thread Stefano Stabellini
From: Jan Beulich The remaining log message in pci_msix_write() is wrong, as there guest behavior may only appear to be wrong: For one, the old logic didn't take the mask-all bit into account. And then this shouldn't depend on host device state (i.e. the host may have masked the entry without the

  1   2   3   >