On Mon, Dec 21, 2015 at 09:32:42AM -0700, Eric Blake wrote: > On 12/21/2015 09:06 AM, Daniel P. Berrange wrote: > > The rebuild of qapi-types.c/h is not correctly triggered > > when qapi/crypto.json is changed because it was missing > > from the list of files in the qapi-modules variable. > > > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > Makefile | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > > > > diff --git a/Makefile b/Makefile > > index af3e5f1..82b2fc8 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -271,7 +271,8 @@ $(SRC_PATH)/qga/qapi-schema.json > > $(SRC_PATH)/scripts/qapi-commands.py $(qapi-py) > > > > qapi-modules = $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi/common.json \ > > $(SRC_PATH)/qapi/block.json > > $(SRC_PATH)/qapi/block-core.json \ > > - $(SRC_PATH)/qapi/event.json $(SRC_PATH)/qapi/introspect.json > > + $(SRC_PATH)/qapi/event.json > > $(SRC_PATH)/qapi/introspect.json \ > > + $(SRC_PATH)/qapi/crypto.json > > Wonder if a wildcard for qapi/*.json would be any smarter.
I'm not sure if there's an official position, but it seems we mostly avoid using wildcards in the QEMU Makefiles, so I figured to stick with current practice. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
