Re: [Qemu-devel] [PATCH v10 23/30] qapi: Check for qapi collisions of flat union branches

2015-11-10 Thread Markus Armbruster
Eric Blake writes: > On 11/09/2015 05:56 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Right now, our ad hoc parser ensures that we cannot have a >>> flat union that introduces any qapi member names that would >>> conflict with the non-variant qapi members already present >>> from t

Re: [Qemu-devel] [POC]colo-proxy in qemu

2015-11-10 Thread zhanghailiang
On 2015/11/10 15:35, Jason Wang wrote: On 11/10/2015 01:26 PM, Tkid wrote: Hi,all We are planning to reimplement colo proxy in userspace (Here is in qemu) to cache and compare net packets.This module is one of the important components of COLO project and now it is still in early stage, so any

Re: [Qemu-devel] [PATCH v6 4/4] hmp: add monitor command to add/remove a child

2015-11-10 Thread Wen Congyang
On 11/09/2015 10:54 PM, Alberto Garcia wrote: > On Fri 16 Oct 2015 10:57:46 AM CEST, Wen Congyang wrote: > >> +.name = "blockdev_change", >> +.args_type = "op:s,parent:B,child:B?,node:?", >> +.params = "operation parent [child] [node]", > [...] >> +/* >> +

[Qemu-devel] [PATCH v3 0/2] mirror: Improve zero write and discard

2015-11-10 Thread Fam Zheng
The first patch adds a lock between bdrv_set_dirty{,_bitmap} and non-atomic (coroutine) readers, The second patch makes use of it and fixes mirror thin writing. Fam Zheng (2): block: Introduce coroutine lock to dirty bitmap mirror: Improve zero-write and discard with fragmented image block.

[Qemu-devel] [PATCH v3 1/2] block: Introduce coroutine lock to dirty bitmap

2015-11-10 Thread Fam Zheng
Typically, what a dirty bit consumer does is 1) get the next dirty sectors; 2) do something with the sectors; 3) clear the dirty bits; 4) goto 1). This works as long as 2) is simple and atomic in the coroutine sense. Anything sophisticated requires either moving 3) before 2) or using locks, becaus

[Qemu-devel] [PATCH v3 2/2] mirror: Improve zero-write and discard with fragmented image

2015-11-10 Thread Fam Zheng
The "pnum < nb_sectors" condition in deciding whether to actually copy data is unnecessarily strict, and the qiov initialization is unnecessarily too, for both bdrv_aio_write_zeroes and bdrv_aio_discard branches. Reorganize mirror_iteration flow so that we: 1) Find the contiguous zero/discard

Re: [Qemu-devel] [PATCH for-2.5] hw/timer/hpet.c: Avoid signed integer overflow which results in bugs on OSX

2015-11-10 Thread Laszlo Ersek
On 11/09/15 23:25, Laszlo Ersek wrote: > On 11/09/15 15:56, Peter Maydell wrote: >> Signed integer overflow in C is undefined behaviour, and the compiler >> is at liberty to assume it can never happen and optimize accordingly. >> In particular, the subtractions in hpet_time_after() and hpet_time_af

Re: [Qemu-devel] [v2 RESEND 2/2] configure: add options to config avx2

2015-11-10 Thread Juan Quintela
Liang Li wrote: > Add the '--enable-avx2' & '--disable-avx2' option so as to config > the AVX2 instruction optimization. > > By default, avx2 optimization is enabled, if '--disable-avx2' is not > set, configure will detect if the compiler can support AVX2 option, > if yes, AVX2 optimization is eab

Re: [Qemu-devel] [PATCH] mirror: Improve zero-write and discard with fragmented image

2015-11-10 Thread Paolo Bonzini
On 10/11/2015 07:14, Fam Zheng wrote: > On Mon, 11/09 17:29, Kevin Wolf wrote: >> Am 09.11.2015 um 17:18 hat Paolo Bonzini geschrieben: >>> >>> >>> On 09/11/2015 17:04, Kevin Wolf wrote: Am 06.11.2015 um 11:22 hat Fam Zheng geschrieben: > The "pnum < nb_sectors" condition in deciding whe

Re: [Qemu-devel] [PATCH 0/7] int128: reparing broken 128 bit memory calculations

2015-11-10 Thread Pierre Morel
On 11/09/2015 01:20 PM, Paolo Bonzini wrote: On 09/11/2015 13:01, Pierre Morel wrote: This leads to have UINT64_MAX represented with {1, 0} instead of {0, UINT64_MAX} while {1, 0} is 2^64. This again leads to have unnecessary and obfuscating transformations with int128_2_64() to test for UINT

[Qemu-devel] [PATCH 0/3] block/gluster: add support for multiple gluster servers

2015-11-10 Thread Prasanna Kumar Kalever
This release is rebased on qemu master branch. In this series of patches 1/3 and 2/3 are unchanged. Prasanna Kumar Kalever (3): block/gluster: rename [server, volname, image] -> [host, volume, path] block/gluster: code cleanup block/gluster: add support for multiple gluster servers block/g

[Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname, image] -> [host, volume, path]

2015-11-10 Thread Prasanna Kumar Kalever
this patch is very much be meaningful after next patch which adds multiple gluster servers support. After that, an example is, in 'servers' tuple values we use 'server' variable for key 'host' in the code, it will be quite messy to have colliding names for variables, so to maintain better readabi

[Qemu-devel] [PATCH v2 2/3] block/gluster: code cleanup

2015-11-10 Thread Prasanna Kumar Kalever
unified coding styles of multiline function arguments and other error functions moved random declarations of structures and other list variables Signed-off-by: Prasanna Kumar Kalever --- block/gluster.c | 113 ++-- 1 file changed, 60 insertions

[Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers

2015-11-10 Thread Prasanna Kumar Kalever
This patch adds a way to specify multiple volfile servers to the gluster block backend of QEMU with tcp|rdma transport types and their port numbers. Problem: Currently VM Image on gluster volume is specified like this: file=gluster[+tcp]://host[:port]/testvol/a.img Assuming we have three hosts

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-10 Thread Juan Quintela
"Li, Liang Z" wrote: >> Rather than trying to cater to multiple assembly instruction implementations >> ourselves, have you tried taking the ideas in this earlier thread? >> https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg05298.html >> >> Ideally, libc's memcmp() will already be using th

Re: [Qemu-devel] [PATCH v10 24/30] qapi: Factor out QAPISchemaObjectType.check_clash()

2015-11-10 Thread Markus Armbruster
Eric Blake writes: > On 11/09/2015 07:49 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Consolidate two common sequences of clash detection into a >>> new QAPISchemaObjectType.check_clash() helper method. >>> >>> No change to generated code. >>> >>> Signed-off-by: Eric Blake >>> > >

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-10 Thread Markus Armbruster
Wen Congyang writes: > On 11/09/2015 10:42 PM, Alberto Garcia wrote: >> Sorry again for the late review, here are my comments: >> >> On Fri 16 Oct 2015 10:57:45 AM CEST, Wen Congyang wrote: >>> +void qmp_x_blockdev_change(ChangeOperation op, const char *parent, >>> + bo

Re: [Qemu-devel] [PATCH for-2.5] hw/timer/hpet.c: Avoid signed integer overflow which results in bugs on OSX

2015-11-10 Thread Paolo Bonzini
On 10/11/2015 09:57, Laszlo Ersek wrote: > On 11/09/15 23:25, Laszlo Ersek wrote: >> On 11/09/15 15:56, Peter Maydell wrote: >>> Signed integer overflow in C is undefined behaviour, and the compiler >>> is at liberty to assume it can never happen and optimize accordingly. >>> In particular, the s

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-10 Thread Paolo Bonzini
On 10/11/2015 10:13, Juan Quintela wrote: >> > I rewrite the buffer_find_nonzero_offset() with the 'bool memeqzero4_paolo >> > length' >> > then write a test program to check a large amount of zero pages, and >> > use the 'time' to >> > recode the time takes by different optimization. Test resul

Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

2015-11-10 Thread Peter Maydell
On 9 November 2015 at 18:52, Markus Armbruster wrote: > Peter Maydell writes: >> Thanks, I had missed this useful improvement to the API. >> How does it work in cases like this where we don't have >> an Error* to fill in? > > You do what error_report_err() would do had you had an Error *err to >

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-10 Thread Li, Liang Z
> > Eric, thanks for you information. I didn't notice that discussion before. > > > > > > I rewrite the buffer_find_nonzero_offset() with the 'bool memeqzero4_paolo > length' > > then write a test program to check a large amount of zero pages, and > > use the 'time' to recode the time takes by diff

Re: [Qemu-devel] [POC]colo-proxy in qemu

2015-11-10 Thread Tkid
On 11/10/2015 03:35 PM, Jason Wang wrote: On 11/10/2015 01:26 PM, Tkid wrote: Hi,all We are planning to reimplement colo proxy in userspace (Here is in qemu) to cache and compare net packets.This module is one of the important components of COLO project and now it is still in early stage, so

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-10 Thread Paolo Bonzini
On 10/11/2015 10:26, Li, Liang Z wrote: > I don't know Paolo's opinion about how to deal with the SSE2 > Intrinsics, he is the author. From my personal view, now that we have > found a better way, why to use such low level SSE2/AVX2 Intrinsics. I totally agree. :) Paolo

Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

2015-11-10 Thread Markus Armbruster
Peter Maydell writes: > On 9 November 2015 at 18:52, Markus Armbruster wrote: >> Peter Maydell writes: >>> Thanks, I had missed this useful improvement to the API. >>> How does it work in cases like this where we don't have >>> an Error* to fill in? >> >> You do what error_report_err() would do

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-10 Thread Li, Liang Z
> On 10/11/2015 10:26, Li, Liang Z wrote: > > I don't know Paolo's opinion about how to deal with the SSE2 > > Intrinsics, he is the author. From my personal view, now that we have > > found a better way, why to use such low level SSE2/AVX2 Intrinsics. > > I totally agree. :) > > Paolo Hi Paolo,

Re: [Qemu-devel] [POC]colo-proxy in qemu

2015-11-10 Thread Dr. David Alan Gilbert
* Jason Wang (jasow...@redhat.com) wrote: > > > On 11/10/2015 01:26 PM, Tkid wrote: > > Hi,all > > > > We are planning to reimplement colo proxy in userspace (Here is in > > qemu) to > > cache and compare net packets.This module is one of the important > > components > > of COLO project and now i

Re: [Qemu-devel] [PATCH for 2.5 v6 0/10] dataplane snapshot fixes

2015-11-10 Thread Stefan Hajnoczi
On Mon, Nov 09, 2015 at 08:57:26PM +0300, Denis V. Lunev wrote: > On 11/09/2015 08:37 PM, Stefan Hajnoczi wrote: > >On Sat, Nov 07, 2015 at 06:54:50PM +0300, Denis V. Lunev wrote: > >>with test > >> while /bin/true ; do > >> virsh snapshot-create rhel7 > >> sleep 10 > >>

[Qemu-devel] [PATCH v3 1/2] net: netmap: Fix compilation issue

2015-11-10 Thread Vincenzo Maffione
Reorganization of struct NetClientOptions (commit e4ba22b) caused a compilation failure of the netmap backend. This patch fixes the issue by properly accessing the union field. Signed-off-by: Vincenzo Maffione --- net/netmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/n

[Qemu-devel] [PATCH v3 0/2] Fix compilation of netmap backend

2015-11-10 Thread Vincenzo Maffione
This patch series adds some fixes to the netmap net backend. It contains two changes: (1) Fix compilation issue of netmap.c introduced by the reorganization of struct NetClientOptions (2) Address the FIXME comment that was asking to use error_setg() variants in place of erro

Re: [Qemu-devel] [PATCH 0/2] checkpatch: Fixing two cases of false positives in checkpatch.pl

2015-11-10 Thread Leonid Bloch
ping http://patchwork.ozlabs.org/patch/537763 http://patchwork.ozlabs.org/patch/537762 On Thu, Oct 29, 2015 at 11:48 AM, Leonid Bloch wrote: > This series addresses two cases where errors were printed if whitespaces > appeared in front of a square bracket in places where there should be no > pro

[Qemu-devel] [PATCH v3 2/2] net: netmap: use error_setg() helpers in place of error_report()

2015-11-10 Thread Vincenzo Maffione
This update was required to align error reporting of netmap backend initialization to the modifications introduced by commit a30ecde. Signed-off-by: Vincenzo Maffione --- net/netmap.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/net/netmap.c b/net/

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-10 Thread Paolo Bonzini
On 10/11/2015 10:41, Li, Liang Z wrote: >> On 10/11/2015 10:26, Li, Liang Z wrote: >>> I don't know Paolo's opinion about how to deal with the SSE2 >>> Intrinsics, he is the author. From my personal view, now that we >>> have found a better way, why to use such low level SSE2/AVX2 >>> Intrinsics

Re: [Qemu-devel] [PATCH for-2.5] hw/timer/hpet.c: Avoid signed integer overflow which results in bugs on OSX

2015-11-10 Thread Laszlo Ersek
On 11/10/15 10:26, Paolo Bonzini wrote: > > > On 10/11/2015 09:57, Laszlo Ersek wrote: >> On 11/09/15 23:25, Laszlo Ersek wrote: >>> On 11/09/15 15:56, Peter Maydell wrote: Signed integer overflow in C is undefined behaviour, and the compiler is at liberty to assume it can never happen

Re: [Qemu-devel] [PATCH v3] virtio-blk: trivial code optimization

2015-11-10 Thread Paolo Bonzini
On 10/11/2015 07:35, Gonglei wrote: >> > nb_sectors - int >> > max_xfer_len - int >> > req->qiov.size - size_t >> > BDRV_SECTOR_SIZE - unsigned long long >> > >> > Therefore this expression is an int > unsigned long long comparison. >> > > Sorry, I'm confused. > max_xfer_len is int, > "req->qio

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-10 Thread Thomas Huth
On 10/11/15 05:22, Sukadev Bhattiprolu wrote: [...] > | > +static int file_read_buf(char *file_name, char *buf, int len) > | > +{ > | > +int rc; > | > +FILE *fp; > | > + > | > +fp = fopen(file_name, "r"); > | > +if (!fp) { > | > +error_report("%s: Error opening %s\n", __func

Re: [Qemu-devel] [PATCH v3] virtio-blk: trivial code optimization

2015-11-10 Thread Stefan Hajnoczi
On Tue, Nov 10, 2015 at 02:35:19PM +0800, Gonglei wrote: > On 2015/11/9 21:57, Stefan Hajnoczi wrote: > > On Mon, Nov 09, 2015 at 05:03:30PM +0800, arei.gong...@huawei.com wrote: > >> From: Gonglei > >> > >> 1. avoid possible superflous checking > >> 2. make code more robustness > >> > >> Signed-o

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-10 Thread Li, Liang Z
> On 10/11/2015 10:41, Li, Liang Z wrote: > >> On 10/11/2015 10:26, Li, Liang Z wrote: > >>> I don't know Paolo's opinion about how to deal with the SSE2 > >>> Intrinsics, he is the author. From my personal view, now that we > >>> have found a better way, why to use such low level SSE2/AVX2 > >>> I

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-10 Thread Paolo Bonzini
On 10/11/2015 10:56, Li, Liang Z wrote: > > I agree that your patch can be dropped, but go ahead and submit your > > improvements! > > You mean I do this work? > If you are busy, I can do this. It's not that I'm busy, it's that it's your idea. It doesn't matter if I (and Peter Lieven too, act

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-10 Thread Li, Liang Z
> On 10/11/2015 10:56, Li, Liang Z wrote: > > > I agree that your patch can be dropped, but go ahead and submit your > > > improvements! > > > > You mean I do this work? > > If you are busy, I can do this. > > It's not that I'm busy, it's that it's your idea. It doesn't matter if I > (and Peter

Re: [Qemu-devel] [PATCH for-2.5] hw/timer/hpet.c: Avoid signed integer overflow which results in bugs on OSX

2015-11-10 Thread Peter Maydell
On 9 November 2015 at 20:17, Michael S. Tsirkin wrote: > On Mon, Nov 09, 2015 at 02:56:31PM +, Peter Maydell wrote: >> Signed integer overflow in C is undefined behaviour, and the compiler >> is at liberty to assume it can never happen and optimize accordingly. >> In particular, the subtractio

Re: [Qemu-devel] [PATCH] mirror: Improve zero-write and discard with fragmented image

2015-11-10 Thread Kevin Wolf
Am 10.11.2015 um 10:01 hat Paolo Bonzini geschrieben: > > > On 10/11/2015 07:14, Fam Zheng wrote: > > On Mon, 11/09 17:29, Kevin Wolf wrote: > >> Am 09.11.2015 um 17:18 hat Paolo Bonzini geschrieben: > >>> > >>> > >>> On 09/11/2015 17:04, Kevin Wolf wrote: > Am 06.11.2015 um 11:22 hat Fam Zh

Re: [Qemu-devel] [PATCH v6 04/15] iotests: Move _filter_nbd into common.filter

2015-11-10 Thread Kevin Wolf
Am 09.11.2015 um 19:17 hat Max Reitz geschrieben: > On 09.11.2015 17:04, Kevin Wolf wrote: > > Am 04.11.2015 um 19:57 hat Max Reitz geschrieben: > >> _filter_nbd can be useful for other NBD tests, too, therefore it should > >> reside in common.filter, and it should support URLs of the "nbd://" > >>

Re: [Qemu-devel] [PATCH] mirror: Improve zero-write and discard with fragmented image

2015-11-10 Thread Paolo Bonzini
On 10/11/2015 11:12, Kevin Wolf wrote: > > For full mirroring, this strategy will probably make the first > > incremental iteration more expensive. > > You mean because we issue smaller, interleaved write and write_zeroes > requests now instead of only large writes? That's probably right, but > g

Re: [Qemu-devel] [PULL 29/57] migrate_start_postcopy: Command to trigger transition to postcopy

2015-11-10 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > [adding Markus for a qapi question] > > On 11/09/2015 10:28 AM, Juan Quintela wrote: > > From: "Dr. David Alan Gilbert" > > > > Once postcopy is enabled (with migrate_set_capability), the migration > > will still start on precopy mode. To cause a transi

Re: [Qemu-devel] [PULL v2 00/12] QAPI patches

2015-11-10 Thread Peter Maydell
On 10 November 2015 at 07:16, Markus Armbruster wrote: > v2: > * PATCH 07: fix a comment typo [Eric] > * PATCH 12: tweak commit message [Eric] > > The following changes since commit 9d5c1dc117d1ad881bbc76f6990ee1f9e9f8ef7f: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-reque

Re: [Qemu-devel] [PULL 00/57] Migration pull

2015-11-10 Thread Peter Maydell
On 9 November 2015 at 22:36, Eric Blake wrote: > The only POSIX-ly correct portable way to print ssize_t is via casts > (yes, quite ugly), as in: > > printf("%zu", (size_t)(ssize_t_value)); I'm running a test build using this approach. > I wish %zd were portably useful for printing ssize_t, but

Re: [Qemu-devel] [POC]colo-proxy in qemu

2015-11-10 Thread Dr. David Alan Gilbert
* Tkid (zhangchen.f...@cn.fujitsu.com) wrote: > Hi,all > > We are planning to reimplement colo proxy in userspace (Here is in qemu) to > cache and compare net packets.This module is one of the important components > of COLO project and now it is still in early stage, so any comments and > feedback

Re: [Qemu-devel] assert during internal snapshot

2015-11-10 Thread Stefan Hajnoczi
On Mon, Nov 09, 2015 at 03:29:13AM +, Li, Liang Z wrote: > > -Original Message- > > From: Denis V. Lunev [mailto:d...@openvz.org] > > Sent: Saturday, November 07, 2015 11:20 PM > > To: Li, Liang Z; Paolo Bonzini; Juan Quintela; Amit Shah > > Cc: QEMU > > Subject: assert during internal

Re: [Qemu-devel] [PATCH v5 3/8] e1000: Introduced an array to control the access to the MAC registers

2015-11-10 Thread Leonid Bloch
On Tue, Nov 10, 2015 at 7:37 AM, Jason Wang wrote: > > > On 11/09/2015 10:59 PM, Leonid Bloch wrote: >> The array of uint8_t's which is introduced here, contains useful metadata >> about the MAC registers: if a register should be always accessible, or if >> it is accessible, but partly implemented

Re: [Qemu-devel] [PATCH v5 0/8] e1000: Various fixes and registers' implementation

2015-11-10 Thread Leonid Bloch
On Tue, Nov 10, 2015 at 8:21 AM, Jason Wang wrote: > > > On 11/09/2015 10:59 PM, Leonid Bloch wrote: >> This series fixes issues with packet/octet counting in e1000's Statistic >> registers, fixes a bug in the packet address filtering procedure, and >> implements many MAC registers that were absen

[Qemu-devel] [PATCH V5] hw/virtio: Add PCIe capability to virtio devices

2015-11-10 Thread Marcel Apfelbaum
The virtio devices are converted to PCI-Express if they are plugged into a PCI-Express bus and the 'modern' protocol is enabled. Devices plugged directly into the Root Complex as Integrated Endpoints remain PCI. Signed-off-by: Marcel Apfelbaum --- v4 -> v5: - Addressed Michael S. Tsirkin's comm

Re: [Qemu-devel] assert during internal snapshot

2015-11-10 Thread Denis V. Lunev
On 11/10/2015 02:00 PM, Stefan Hajnoczi wrote: On Mon, Nov 09, 2015 at 03:29:13AM +, Li, Liang Z wrote: -Original Message- From: Denis V. Lunev [mailto:d...@openvz.org] Sent: Saturday, November 07, 2015 11:20 PM To: Li, Liang Z; Paolo Bonzini; Juan Quintela; Amit Shah Cc: QEMU Subjec

Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

2015-11-10 Thread Peter Maydell
On 10 November 2015 at 09:39, Markus Armbruster wrote: > Peter Maydell writes: >> ...so in conclusion Andrew's patch is correct as it stands >> and I should just apply it? :-) > > Yes. It got my R-by :) OK, applied to target-arm.next. Thanks for walking me through this. -- PMM

Re: [Qemu-devel] [PATCH v10 00/30] qapi member collision (post-introspection cleanups, subset C')

2015-11-10 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 11/09/2015 02:59 AM, Markus Armbruster wrote: >>> Eric Blake writes: >>> On 11/06/2015 09:03 AM, Markus Armbruster wrote: > Eric Blake writes: >>> [...] >> Hopefully, we are converging on something that will be ready >> f

Re: [Qemu-devel] [PATCH for-2.5] hw/timer/hpet.c: Avoid signed integer overflow which results in bugs on OSX

2015-11-10 Thread Michael S. Tsirkin
On Tue, Nov 10, 2015 at 10:04:40AM +, Peter Maydell wrote: > On 9 November 2015 at 20:17, Michael S. Tsirkin wrote: > > On Mon, Nov 09, 2015 at 02:56:31PM +, Peter Maydell wrote: > >> Signed integer overflow in C is undefined behaviour, and the compiler > >> is at liberty to assume it can

Re: [Qemu-devel] [PATCH 0/7] int128: reparing broken 128 bit memory calculations

2015-11-10 Thread Pierre Morel
On 11/10/2015 10:08 AM, Pierre Morel wrote: On 11/09/2015 01:20 PM, Paolo Bonzini wrote: On 09/11/2015 13:01, Pierre Morel wrote: This leads to have UINT64_MAX represented with {1, 0} instead of {0, UINT64_MAX} while {1, 0} is 2^64. This again leads to have unnecessary and obfuscating tran

Re: [Qemu-devel] [PATCH v2] target-arm: Clean up DISAS_UPDATE usage in AArch32 translation code

2015-11-10 Thread Peter Maydell
On 9 November 2015 at 19:37, Sergey Fedorov wrote: > Though I don't clearly understand how singlestepping is done here, I just do > what Peter suggested in his commnets for v1 and send this patch for review. > I'm > going to get into this while the patch is in review process... So the way the 32

Re: [Qemu-devel] [PULL 00/57] Migration pull

2015-11-10 Thread Peter Maydell
On 10 November 2015 at 10:53, Peter Maydell wrote: > On 9 November 2015 at 22:36, Eric Blake wrote: >> The only POSIX-ly correct portable way to print ssize_t is via casts >> (yes, quite ugly), as in: >> >> printf("%zu", (size_t)(ssize_t_value)); > > I'm running a test build using this approach.

Re: [Qemu-devel] [PULL 00/57] Migration pull

2015-11-10 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 10 November 2015 at 10:53, Peter Maydell wrote: > > On 9 November 2015 at 22:36, Eric Blake wrote: > >> The only POSIX-ly correct portable way to print ssize_t is via casts > >> (yes, quite ugly), as in: > >> > >> printf("%zu", (size_t)(ssize

Re: [Qemu-devel] [PATCH 0/4] s390: Allow hotplug of s390 CPUs

2015-11-10 Thread Bharata B Rao
On Mon, Nov 09, 2015 at 09:04:27PM +0100, Christian Borntraeger wrote: > > > Bharata did implement device_add for pseries, I thought. Yes. For pseries, my patchset did CPU hotplug via device_add and device_del commands. And that's what I am planning to stick to going forward. > > Seems that the

Re: [Qemu-devel] [PULL 00/57] Migration pull

2015-11-10 Thread Peter Maydell
On 10 November 2015 at 12:22, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On 10 November 2015 at 10:53, Peter Maydell wrote: >> > On 9 November 2015 at 22:36, Eric Blake wrote: >> >> The only POSIX-ly correct portable way to print ssize_t is via casts >>

Re: [Qemu-devel] [PATCH v9 11/15] qmp: Introduce blockdev-change-medium

2015-11-10 Thread Kevin Wolf
Am 06.11.2015 um 16:27 hat Max Reitz geschrieben: > Introduce a new QMP command 'blockdev-change-medium' which is intended > to replace the 'change' command for block devices. The existing function > qmp_change_blockdev() is accordingly renamed to > qmp_blockdev_change_medium(). > > Signed-off-by:

Re: [Qemu-devel] [PATCH QEMU-XEN v5 9/9] xen: make it possible to build without the Xen PV domain builder

2015-11-10 Thread Stefano Stabellini
On Mon, 9 Nov 2015, Ian Campbell wrote: > Until the previous patch this relied on xc_fd(), which was only > implemented for Xen 4.0 and earlier. > > Given this wasn't working since Xen 4.0 I have marked this as disabled > by default. > > Removing this support drops the use of a bunch of symbols f

Re: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes

2015-11-10 Thread Denis V. Lunev
On 11/10/2015 12:05 AM, Eric Blake wrote: On 11/06/2015 02:13 PM, Denis V. Lunev wrote: That is a case of using libvirt to trigger internal snapshots... The HMP monitor is legacy and also not used by modern libvirt. ...and libvirt is forced to use HMP for internal snapshots, since we _still_

Re: [Qemu-devel] [PATCH v2] hw/misc: Add support for ADC controller in Xilinx Zynq 7000

2015-11-10 Thread Peter Maydell
On 2 November 2015 at 06:33, Peter Crosthwaite wrote: > I've made a v3 of this, some comments on changes below. The v3 seems to have never hit the list? thanks -- PMM

Re: [Qemu-devel] [PATCH v5 0/8] e1000: Various fixes and registers' implementation

2015-11-10 Thread Jason Wang
On 11/10/2015 07:39 PM, Leonid Bloch wrote: > On Tue, Nov 10, 2015 at 8:21 AM, Jason Wang wrote: >> >> On 11/09/2015 10:59 PM, Leonid Bloch wrote: >>> This series fixes issues with packet/octet counting in e1000's Statistic >>> registers, fixes a bug in the packet address filtering procedure, an

Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

2015-11-10 Thread Andrew Jones
On Tue, Nov 10, 2015 at 11:55:55AM +, Peter Maydell wrote: > On 10 November 2015 at 09:39, Markus Armbruster wrote: > > Peter Maydell writes: > >> ...so in conclusion Andrew's patch is correct as it stands > >> and I should just apply it? :-) > > > > Yes. It got my R-by :) > > OK, applied t

Re: [Qemu-devel] [PATCH v2 2/5] target-i386/kvm: Hyper-V SynIC MSR's support

2015-11-10 Thread Paolo Bonzini
On 10/11/2015 13:52, Andrey Smetanin wrote: > This patch does Hyper-V Synthetic interrupt > controller(Hyper-V SynIC) MSR's support and > migration. Hyper-V SynIC is enabled by cpu's > 'hv-synic' option. > > This patch does not allow cpu creation if > 'hv-synic' option specified but kernel > doe

Re: [Qemu-devel] [PATCH v10 24/30] qapi: Factor out QAPISchemaObjectType.check_clash()

2015-11-10 Thread Eric Blake
On 11/10/2015 02:15 AM, Markus Armbruster wrote: >> On the other hand, we've been arguing that check() should populate >> everything after construction prior to anything else being run; and not >> running Variant.type.check() during Variants.check() of flat unions >> feels like we may have a hole

Re: [Qemu-devel] [PATCH v5 0/8] e1000: Various fixes and registers' implementation

2015-11-10 Thread Leonid Bloch
On Tue, Nov 10, 2015 at 3:01 PM, Jason Wang wrote: > > > On 11/10/2015 07:39 PM, Leonid Bloch wrote: >> On Tue, Nov 10, 2015 at 8:21 AM, Jason Wang wrote: >>> >>> On 11/09/2015 10:59 PM, Leonid Bloch wrote: This series fixes issues with packet/octet counting in e1000's Statistic registe

[Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

2015-11-10 Thread Andrey Smetanin
A new vcpu exit is introduced to notify the userspace of the changes in Hyper-V SynIC configuration triggered by guest writing to the corresponding MSRs. Changes v4: * exit into userspace only if guest writes into SynIC MSR's Changes v3: * added KVM_EXIT_HYPERV types and structs notes into docs

[Qemu-devel] [PATCH v2 3/5] kvm: Hyper-V SynIC irq routing support

2015-11-10 Thread Andrey Smetanin
Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Richard Henderson CC: Eduardo Habkost CC: "Andreas Färber" CC: Marcelo Tosatti CC: Roman Kagan CC: Denis V. Lunev CC: k...@vger.kernel.org --- include/sysemu/kvm.h | 1 + kvm-all

[Qemu-devel] [PATCH v2 0/5] QEMU: Hyper-V SynIC support

2015-11-10 Thread Andrey Smetanin
Hyper-V SynIC (synthetic interrupt controller) support: * msr's support * irq routing setup * irq injection * irq ack's callbacks * event/message pages changes tracking at Hyper-V exit * Hyper-V test device to test SynIC by kvm-unit-tests Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan S

[Qemu-devel] [PATCH v4 0/5] KVM: Hyper-V synthetic interrupt controller

2015-11-10 Thread Andrey Smetanin
This patchset implements the KVM part of the synthetic interrupt controller (SynIC) which is a building block of the Hyper-V paravirtualized device bus (vmbus). SynIC is a lapic extension, which is controlled via MSRs and maintains for each vCPU - 16 synthetic interrupt "lines" (SINT's); each can

[Qemu-devel] [PATCH v4 1/5] kvm/irqchip: kvm_arch_irq_routing_update renaming split

2015-11-10 Thread Andrey Smetanin
Actually kvm_arch_irq_routing_update() should be kvm_arch_post_irq_routing_update() as it's called at the end of irq routing update. This renaming frees kvm_arch_irq_routing_update function name. kvm_arch_irq_routing_update() weak function which will be used to update mappings for arch-specific ir

[Qemu-devel] [PATCH v2 1/5] headers: Linux kernel Hyper-V SynIC defines

2015-11-10 Thread Andrey Smetanin
This patch brings in the necessary changes from the corresponding kernel patchset. It's included only for completeness; ideally these changes should arrive via the standard kernel header pull. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Paolo Bonzi

[Qemu-devel] [PATCH v2 4/5] target-i386/hyperv: Hyper-V SynIC SINT routing and vcpu exit

2015-11-10 Thread Andrey Smetanin
Hyper-V SynIC(synthetic interrupt controller) helpers for Hyper-V SynIC irq routing setup, irq injection, irq ack notifications event/message pages changes tracking for future use. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Richa

Re: [Qemu-devel] [PATCH v10 23/30] qapi: Check for qapi collisions of flat union branches

2015-11-10 Thread Eric Blake
On 11/10/2015 01:30 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 11/09/2015 05:56 AM, Markus Armbruster wrote: >>> Eric Blake writes: >>> Right now, our ad hoc parser ensures that we cannot have a flat union that introduces any qapi member names that would conflict wi

[Qemu-devel] [PATCH v4 2/5] kvm/x86: split ioapic-handled and EOI exit bitmaps

2015-11-10 Thread Andrey Smetanin
The function to determine if the vector is handled by ioapic used to rely on the fact that only ioapic-handled vectors were set up to cause vmexits when virtual apic was in use. We're going to break this assumption when introducing Hyper-V synthetic interrupts: they may need to cause vmexits too.

[Qemu-devel] [PATCH v2 5/5] hw/misc: Hyper-V test device 'hyperv-testdev'

2015-11-10 Thread Andrey Smetanin
'hyperv-testdev' will be used by kvm-unit-tests to setup Hyper-V SynIC SINT's routing and to inject Hyper-V SynIC SINT's. Hyper-V test device is ISA type device that creates 0x3000 IO memory region and catches write access into it. Every write operation data decoded into ctl code and parameters fo

[Qemu-devel] [PATCH v4 3/5] kvm/x86: per-vcpu apicv deactivation support

2015-11-10 Thread Andrey Smetanin
The decision on whether to use hardware APIC virtualization used to be taken globally, based on the availability of the feature in the CPU and the value of a module parameter. However, under certain circumstances we want to control it on per-vcpu basis. In particular, when the userspace activates

[Qemu-devel] [PATCH v2 2/5] target-i386/kvm: Hyper-V SynIC MSR's support

2015-11-10 Thread Andrey Smetanin
This patch does Hyper-V Synthetic interrupt controller(Hyper-V SynIC) MSR's support and migration. Hyper-V SynIC is enabled by cpu's 'hv-synic' option. This patch does not allow cpu creation if 'hv-synic' option specified but kernel doesn't support Hyper-V SynIC. Changes v2: * activate Hyper-V Sy

[Qemu-devel] [PATCH v4 4/5] kvm/x86: Hyper-V synthetic interrupt controller

2015-11-10 Thread Andrey Smetanin
SynIC (synthetic interrupt controller) is a lapic extension, which is controlled via MSRs and maintains for each vCPU - 16 synthetic interrupt "lines" (SINT's); each can be configured to trigger a specific interrupt vector optionally with auto-EOI semantics - a message page in the guest mem

[Qemu-devel] [PULL 02/15] trace: add make dependencies on tracetool source

2015-11-10 Thread Stefan Hajnoczi
Patches that change tracetool can break the build if old build output files are lying around. This happens because the Makefile does not specify dependencies on tracetool. The build will use old object files that do not match the current source code. Signed-off-by: Stefan Hajnoczi Message-id: 1

[Qemu-devel] [PULL 00/15] Tracing patches

2015-11-10 Thread Stefan Hajnoczi
The following changes since commit a8b4f9585a0bf5186fca793ce2c5d754cd8ec49a: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-11-10' into staging (2015-11-10 09:39:24 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request

[Qemu-devel] [PULL 01/15] trace: fix make foo-timestamp rules

2015-11-10 Thread Stefan Hajnoczi
The Makefile uses intermediate timestamp files to avoid rebuilding if tracetool output is unchanged. Timestamps are implemented incorrectly. This was fixed for rules.mak in commit 4b25966ab976f3a7fd9008193b2defcc82f8f04d ("rules.mak: cleanup config generation rules") but never fixed in trace/Make

[Qemu-devel] [PULL 04/15] trace: track enabled events in a separate array

2015-11-10 Thread Stefan Hajnoczi
From: Paolo Bonzini This is more cache friendly on the fast path, where we already have the event id available. Signed-off-by: Paolo Bonzini Message-id: 1446012388-9586-3-git-send-email-pbonz...@redhat.com Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/format/events_c.py | 2 +- trace/

[Qemu-devel] [PULL 07/15] trace: split trace_init_file out of trace_init_backends

2015-11-10 Thread Stefan Hajnoczi
From: Paolo Bonzini This is cleaner, and improves error reporting with -daemonize. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger Message-id: 1446151457-21157-4-git-send-email-...@openvz.org Signed-off-by: Stefan Hajnoczi --- qemu-io.c | 2

[Qemu-devel] [PULL 03/15] trace: count number of enabled events

2015-11-10 Thread Stefan Hajnoczi
From: Paolo Bonzini This lets trace_event_get_state_dynamic quickly return false. Right now there is hardly any benefit because there are also many assertions and indirections, but the next patch will streamline all of this. Signed-off-by: Paolo Bonzini Message-id: 1446012388-9586-2-git-send-e

[Qemu-devel] [PULL 10/15] trace: add "-trace help"

2015-11-10 Thread Stefan Hajnoczi
From: Paolo Bonzini Print a list of trace points Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger Message-id: 1446151457-21157-7-git-send-email-...@openvz.org Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 2 ++ trace/control.c | 21 +

[Qemu-devel] [PULL 11/15] log: do not unnecessarily include qom/cpu.h

2015-11-10 Thread Stefan Hajnoczi
From: Paolo Bonzini Split the bits that require it to exec/log.h. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger Message-id: 1446151457-21157-8-git-send-email-...@openvz.org Signed-off-by: Stefan Hajnoczi --- bsd-user/main.c | 1 +

[Qemu-devel] [PULL 06/15] trace: split trace_init_events out of trace_init_backends

2015-11-10 Thread Stefan Hajnoczi
From: Paolo Bonzini This is cleaner and has two advantages. First, it improves error reporting with -daemonize. Second, multiple "-trace events" options now cumulate. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger Message-id: 1446151457-21157-3-gi

[Qemu-devel] [PULL 09/15] trace: add "-trace enable=..."

2015-11-10 Thread Stefan Hajnoczi
From: Paolo Bonzini Allow enabling events without going through a file, for example: qemu-system-x86_64 -trace bdrv_aio_writev -trace bdrv_aio_readv or with globbing too: qemu-system-x86_64 -trace 'bdrv_aio_*' if an appropriate backend is enabled (simple, stderr, ftrace). Signed-off-by

Re: [Qemu-devel] [PATCH v11 00/14] block: incremental backup transactions using BlockJobTxn

2015-11-10 Thread Stefan Hajnoczi
On Thu, Nov 05, 2015 at 06:13:06PM -0500, John Snow wrote: > Welcome to the Incremental Backup Transactions Newsletter! > > What's new? > > I replaced the per-action "transactional-cancel" parameter with > a per-transaction paremeter named "completion-mode" which is implemented > as an enum in ca

[Qemu-devel] [PULL 05/15] trace: fix documentation

2015-11-10 Thread Stefan Hajnoczi
From: Paolo Bonzini Mention the ftrace backend too. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger Message-id: 1446151457-21157-2-git-send-email-...@openvz.org Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 10 +- 1 file changed, 5 i

[Qemu-devel] [PULL 12/15] log: move qemu-log.c into util/ directory

2015-11-10 Thread Stefan Hajnoczi
From: "Denis V. Lunev" log will become common facility with tracepoints support in next step. Signed-off-by: Denis V. Lunev Reviewed-by: Paolo Bonzini Signed-off-by: Paolo Bonzini Message-id: 1446151457-21157-9-git-send-email-...@openvz.org Signed-off-by: Stefan Hajnoczi --- Makefile.objs

Re: [Qemu-devel] [PULL 00/15] Tracing patches

2015-11-10 Thread Peter Maydell
On 10 November 2015 at 13:31, Stefan Hajnoczi wrote: > The following changes since commit a8b4f9585a0bf5186fca793ce2c5d754cd8ec49a: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-11-10' > into staging (2015-11-10 09:39:24 +) > > are available in the git repository at:

[Qemu-devel] [PULL 14/15] trace: switch default backend to "log"

2015-11-10 Thread Stefan Hajnoczi
From: Paolo Bonzini This enables integration with other QEMU logging facilities. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger Message-id: 1446151457-21157-11-git-send-email-...@openvz.org Signed-off-by: Stefan Hajnoczi --- configure | 2 +- 1 fi

[Qemu-devel] [PULL 08/15] trace: no need to call trace_backend_init in different branches now

2015-11-10 Thread Stefan Hajnoczi
From: "Denis V. Lunev" original idea to split calling locations was to spawn tracing thread in the final child process according to commit 8a745f2a9296ad2cf6bda33534ed298f2625a4ad Author: Michael Mueller Date: Mon Sep 23 16:36:54 2013 +0200 os_daemonize is now on top of both locat

[Qemu-devel] [PULL 13/15] trace: convert stderr backend to log

2015-11-10 Thread Stefan Hajnoczi
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger Message-id: 1446151457-21157-10-git-send-email-...@openvz.org Signed-off-by: Stefan Hajnoczi --- configure | 4 ++-- include/qemu/log.h |

  1   2   3   4   5   6   >