Re: [Qemu-devel] [PATCH v7 22/42] migrate_start_postcopy: Command to trigger transition to postcopy

2015-09-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> "Dr. David Alan Gilbert (git)" wrote: > >> > From: "Dr. David Alan Gilbert" > >> > > >> > Once postcopy is enabled (with migrate_set_capability), the migration > >

Re: [Qemu-devel] [PATCH v5 05/46] qapi: Test use of 'number' within alternates

2015-09-24 Thread Markus Armbruster
Eric Blake writes: > Add some testsuite exposure for use of a 'number' as part of > an alternate. The current state of the tree has a few bugs > exposed by this: our input parser depends on the ordering of > how the qapi schema declared the alternate, and the parser > does not accept integers fo

Re: [Qemu-devel] [PATCH v5 06/46] qapi: Improve 'include' error message

2015-09-24 Thread Markus Armbruster
Eric Blake writes: > Use of '"...%s" % include' to print non-strings can lead to > ugly messages, such as this (if the .json change is applied > without the qapi.py change): > Expected a file name (string), got: OrderedDict() > > Better is to just omit the actual non-string value in the > messag

Re: [Qemu-devel] [PATCH v1 06/16] coroutine: move into libqemuutil.a library

2015-09-24 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 02:07:27PM +0200, Paolo Bonzini wrote: > > > On 18/09/2015 15:19, Daniel P. Berrange wrote: > > The coroutine files are currently referenced by the block-obj-y > > variable. The coroutine functionality though is already used by > > more than just the block code. eg migrati

Re: [Qemu-devel] [PATCH v1 07/16] io: add abstract QIOChannel classes

2015-09-24 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 02:28:25PM +0200, Paolo Bonzini wrote: > > > On 22/09/2015 14:24, Daniel P. Berrange wrote: > > On Tue, Sep 22, 2015 at 02:19:27PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 18/09/2015 15:19, Daniel P. Berrange wrote: > >>> +QIO_CHANNEL_FEATURE_FD_PASS = (1 << 0),

Re: [Qemu-devel] [FIX PATCH] pc-dimm: Fail pc-dimm realization for invalid nodes in non-NUMA configuration

2015-09-24 Thread Eduardo Habkost
On Thu, Sep 24, 2015 at 11:53:30AM +0530, Bharata B Rao wrote: > On Wed, Aug 26, 2015 at 01:24:08PM -0300, Eduardo Habkost wrote: > > Applied to the numa tree, with the following changes in the commit > > message: > > > > Subject was changed to: > > pc-dimm: Fail realization for invalid nodes in

Re: [Qemu-devel] [PATCH 1/1] target-i386: get/put MSR_TSC_AUX across reset and migration

2015-09-24 Thread Eduardo Habkost
On Wed, Sep 23, 2015 at 09:47:43AM +0200, Paolo Bonzini wrote: > > > On 23/09/2015 08:27, Amit Shah wrote: > > There's one report of migration breaking due to missing MSR_TSC_AUX > > save/restore. Fix this by adding a new subsection that saves the state > > of this MSR. > > > > https://bugzilla

Re: [Qemu-devel] [PATCH v1 00/16] Introduce I/O channels framework

2015-09-24 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 02:23:20PM +0200, Paolo Bonzini wrote: > > > On 18/09/2015 15:18, Daniel P. Berrange wrote: > > David Gilbert had some feedback on my previous RFC series which > > I have incorporated into this new posting. I did forget his > > comments about using #defines instead of magi

Re: [Qemu-devel] [PATCH v5 07/46] qapi: Don't pass pre-existing error to later call

2015-09-24 Thread Markus Armbruster
Eric Blake writes: > Due to the existing semantics of the error_set() family, > generated sequences in the qapi visitors such as: > > visit_start_implicit_struct(m, (void **)obj, sizeof(FOO), &err); > if (!err) { > visit_type_FOO_fields(m, obj, errp); > visit_e

Re: [Qemu-devel] [PATCH 1/1] target-i386: get/put MSR_TSC_AUX across reset and migration

2015-09-24 Thread Eduardo Habkost
On Wed, Sep 23, 2015 at 11:57:33AM +0530, Amit Shah wrote: > There's one report of migration breaking due to missing MSR_TSC_AUX > save/restore. Fix this by adding a new subsection that saves the state > of this MSR. > > https://bugzilla.redhat.com/show_bug.cgi?id=1261797 > > Reported-by: Xiaoqi

[Qemu-devel] [PATCH] vfio/pci: Remove use of g_malloc0_n() from quirks

2015-09-24 Thread Alex Williamson
For compatibility with glib 2.22. Reported-by: Wen Congyang Signed-off-by: Alex Williamson --- hw/vfio/pci-quirks.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index 2bdaef1..c675d1b 100644 --- a/hw/vfio/pci-

Re: [Qemu-devel] [PATCH v2 6/7] qdev: Protect device-list-properties against broken devices

2015-09-24 Thread Eduardo Habkost
On Wed, Sep 23, 2015 at 04:09:48PM +0200, Markus Armbruster wrote: > Several devices don't survive object_unref(object_new(T)): they crash > or hang during cleanup, or they leave dangling pointers behind. > > This breaks at least device-list-properties, because > qmp_device_list_properties() needs

Re: [Qemu-devel] [PATCH v2 7/7] Revert "qdev: Use qdev_get_device_class() for -device , help"

2015-09-24 Thread Eduardo Habkost
On Wed, Sep 23, 2015 at 04:09:49PM +0200, Markus Armbruster wrote: > This reverts commit 31bed5509dfcbdfc293154ce81086a4dbd7a80b6. > > The reverted commit changed qdev_device_help() to reject abstract > devices and devices that have cannot_instantiate_with_device_add_yet > set, to fix crash bugs l

Re: [Qemu-devel] [PATCH 02/14] MAINTAINERS: there is no PPC64 TCG backend anymore

2015-09-24 Thread Michael Tokarev
24.09.2015 15:21, Markus Armbruster wrote: > Paolo Bonzini writes: > >> PPC32 and PPC64 were unified. >> >> Signed-off-by: Paolo Bonzini >> --- >> MAINTAINERS | 5 - >> 1 file changed, 5 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 71c652b..7c81848 100644 >> --- a/MAIN

Re: [Qemu-devel] [PATCH v5 04/46] qapi: Add tests for empty unions

2015-09-24 Thread Eric Blake
On 09/24/2015 08:16 AM, Markus Armbruster wrote: > Eric Blake writes: > >> The documentation claims that alternates are useful for >> allowing two types, although nothing enforces this. Meanwhile, >> it is silent on whether empty unions are allowed. In practice, >> the generated code will compi

Re: [Qemu-devel] [PATCH v5 05/46] qapi: Test use of 'number' within alternates

2015-09-24 Thread Eric Blake
On 09/24/2015 08:36 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Add some testsuite exposure for use of a 'number' as part of >> an alternate. The current state of the tree has a few bugs >> exposed by this: our input parser depends on the ordering of >> how the qapi schema declared th

Re: [Qemu-devel] [PATCH 1/7] vfio: Remove unneeded union from VFIOContainer

2015-09-24 Thread Alex Williamson
On Thu, 2015-09-24 at 14:33 +1000, David Gibson wrote: > Currently the VFIOContainer iommu_data field contains a union with > different information for different host iommu types. However: >* It only actually contains information for the x86-like "Type1" iommu >* Because we have a common l

Re: [Qemu-devel] [PULL 0/7] target-arm queue

2015-09-24 Thread Peter Maydell
> into staging (2015-09-23 21:39:46 +0100) > > are available in the git repository at: > > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20150924 > > for you to fetch changes up to 85b4d5dae12580ecdd446c0f71afa04a95641c91: > > M

Re: [Qemu-devel] [PATCH v5 06/46] qapi: Improve 'include' error message

2015-09-24 Thread Eric Blake
On 09/24/2015 08:39 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Use of '"...%s" % include' to print non-strings can lead to >> ugly messages, such as this (if the .json change is applied >> without the qapi.py change): >> Expected a file name (string), got: OrderedDict() >> >> Better

Re: [Qemu-devel] [PATCH 5/7] memory: Allow replay of IOMMU mapping notifications

2015-09-24 Thread Laurent Vivier
On 24/09/2015 06:33, David Gibson wrote: > When we have guest visible IOMMUs, we allow notifiers to be registered > which will be informed of all changes to IOMMU mappings. This is used by > vfio to keep the host IOMMU mappings in sync with guest IOMMU mappings. > > However, unlike with a memor

Re: [Qemu-devel] [PATCH 1/7] vfio: Remove unneeded union from VFIOContainer

2015-09-24 Thread Thomas Huth
On 24/09/15 06:33, David Gibson wrote: > Currently the VFIOContainer iommu_data field contains a union with > different information for different host iommu types. However: >* It only actually contains information for the x86-like "Type1" iommu >* Because we have a common listener the Type

[Qemu-devel] [PATCH 0/3] MAINTAINERS docs: flatten docs/qmp/, specify include and test files

2015-09-24 Thread Markus Armbruster
Markus Armbruster (3): docs: Move files from docs/qmp/ to docs/ MAINTAINERS: Specify QObject include and test files MAINTAINERS: Specify QAPI include and test files MAINTAINERS| 15 ++- docs/{qmp => }/qmp-events.txt | 0 docs/{qmp/README => qmp-intr

[Qemu-devel] [PATCH 2/3] MAINTAINERS: Specify QObject include and test files

2015-09-24 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 385febe..68db1b8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1016,6 +1016,14 @@ QObject M: Luiz Capitulino S: Maintained F: qobject/ +F: include/qapi

[Qemu-devel] [PATCH 3/3] MAINTAINERS: Specify QAPI include and test files

2015-09-24 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 68db1b8..1ae207c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -999,7 +999,12 @@ M: Michael Roth S: Supported F: qapi/ X: qapi/*.json +F: include/qapi/ +X:

[Qemu-devel] [PATCH 1/3] docs: Move files from docs/qmp/ to docs/

2015-09-24 Thread Markus Armbruster
Giving QMP its own subdirectory in docs/ is hardly worthwhile when we have just four files, and one of them isn't even in the subdirectory. Move the files from docs/qmp/ to docs/, renaming docs/qmp/README to docs/qmp-intro. Update MAINTAINERS. The new pattern also captures the fourth file docs/wr

Re: [Qemu-devel] [PATCH v5 1/2] vl: Allow to define optional parameter with -arg[=params]

2015-09-24 Thread Laurent Vivier
ping ? On 14/09/2015 20:01, Laurent Vivier wrote: > The goal is to be able to use '-help' alone, or with > a sub-section, i.e. '-help=network,usb'. > > Signed-off-by: Laurent Vivier > --- > vl.c | 31 --- > 1 file changed, 20 insertions(+), 11 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v5 2/2] Use help sub-sections to create sub-help options

2015-09-24 Thread Laurent Vivier
ping ? On 14/09/2015 20:01, Laurent Vivier wrote: > As '-help' output is 400 lines long it is not easy > to find information, but generally we know from > which area we want the information. > > As sections already exist in the help description, > add some options to only display the wanted secti

Re: [Qemu-devel] [PATCH v5 07/46] qapi: Don't pass pre-existing error to later call

2015-09-24 Thread Eric Blake
On 09/24/2015 08:58 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Due to the existing semantics of the error_set() family, >> generated sequences in the qapi visitors such as: >> >> visit_start_implicit_struct(m, (void **)obj, sizeof(FOO), &err); >> if (!err) { >>

Re: [Qemu-devel] qemu-system-arm system support for big endian BE8

2015-09-24 Thread Peter Crosthwaite
On Thu, Sep 24, 2015 at 3:48 AM, sridhar kulkarni wrote: > The issue is mostly related to my application under test. When the > application calls a function the PC is getting set up to a wrong address, > and then qemu crashes by displaying "floating point exception(core dumped)" > message. > I am

Re: [Qemu-devel] [PATCH] rocker: Use g_new() & friends where that makes obvious sense

2015-09-24 Thread Markus Armbruster
Michael, could you take this one through trivial? Assuming Scott and Jiri don't mind, and with s/patchas/patch as/ in the commit message. Markus Armbruster writes: > g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, > for two reasons. One, it catches multiplication overflow

Re: [Qemu-devel] [PATCH 1/3] virtio: introduce virtqueue_unmap_sg()

2015-09-24 Thread Andrew James
On 09/18/2015 02:01 AM, Jason Wang wrote: > Factor out sg unmapping logic. This will be reused by the patch that > can discard descriptor. > > Cc: Michael S. Tsirkin > Signed-off-by: Jason Wang > --- > hw/virtio/virtio.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) >

Re: [Qemu-devel] [PATCH] linux-user: Use g_new() & friends where that makes obvious sense

2015-09-24 Thread Markus Armbruster
Stefan Weil writes: > Am 24.09.2015 um 09:06 schrieb Markus Armbruster: >> Ping? >> >> Markus Armbruster writes: >> >>> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also >>> safer, for two reasons. One, it catches multiplication >>> overflowing size_t. Two, it returns T * rathe

Re: [Qemu-devel] [PATCH 02/14] MAINTAINERS: there is no PPC64 TCG backend anymore

2015-09-24 Thread Markus Armbruster
Michael Tokarev writes: > 24.09.2015 15:21, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> PPC32 and PPC64 were unified. >>> >>> Signed-off-by: Paolo Bonzini >>> --- >>> MAINTAINERS | 5 - >>> 1 file changed, 5 deletions(-) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> inde

Re: [Qemu-devel] [PATCH v3 0/9] remove useless muldiv64()

2015-09-24 Thread Laurent Vivier
Hi, all the patches of the series have been reviewed, except: [PATCH v4 1/9] i6300esb: remove muldiv64(), which is a rebased version. [PATCH v3 5/9] openrisc: remove muldiv64() Any volunteers ? Laurent On 27/08/2015 21:32, Laurent Vivier wrote: > Originally, timers were t

[Qemu-devel] [PATCH v5 02/21] configure: probe for memfd

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau Check if memfd_create() is part of system libc. Signed-off-by: Marc-André Lureau --- configure | 19 +++ 1 file changed, 19 insertions(+) diff --git a/configure b/configure index 52f5b79..a7cdfa4 100755 --- a/configure +++ b/configure @@ -3455,6 +3455,2

[Qemu-devel] [PATCH v5 01/21] vhost-user: unit test for new messages

2015-09-24 Thread marcandre . lureau
From: "Michael S. Tsirkin" Data is empty for now, but do make sure master sets the new feature bit flag. Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-test.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c inde

[Qemu-devel] [PATCH v5 04/21] util: add memfd helpers

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau Add qemu_memfd_alloc/free() helpers. The function helps to allocate and seal a memfd, and implements an open/unlink/mmap fallback for system that do not support memfd. Signed-off-by: Marc-André Lureau --- include/qemu/memfd.h | 4 +++ util/memfd.c | 74 +++

[Qemu-devel] [PATCH v5 09/21] vhost-user: add a migration blocker

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau If VHOST_USER_PROTOCOL_F_LOG_SHMFD is not announced, block vhost-user migration. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-user.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 6420efd.

[Qemu-devel] [PATCH v5 00/21] vhost-user: add migration support

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau Hi, The following series implement shareable log for vhost-user to support memory tracking during live migration. On qemu-side, the solution is fairly straightfoward since vhost already supports the dirty log, only vhost-user couldn't access the log memory until then. Th

[Qemu-devel] [PATCH v5 05/21] vhost: alloc shareable log

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau If the backend is of type VHOST_BACKEND_TYPE_USER, allocate shareable memory. Next patch will only allocate when the backend has the required feature. vhost_log_get() now uses 2 globals "vhost_log" and "vhost_log_shm", that way there is a common non-shareable log and a co

[Qemu-devel] [PATCH v5 11/21] vhost: only use shared log if in use by backend

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau Do not allocate a shared log if the backend doesn't support it. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-user.c| 9 + hw/virtio/vhost.c | 15 ++- include/hw/virtio/vhost-backend.h | 4 3 files changed, 2

[Qemu-devel] [PATCH v5 07/21] vhost: add vhost_set_log_base op

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau Split VHOST_SET_LOG_BASE call in a seperate function callback, so that type safety works and more arguments can be added in the next patches. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-backend.c | 8 hw/virtio/vhost-user.c| 17 +++

[Qemu-devel] [PATCH v5 06/21] vhost: document log resizing

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/virtio/vhost.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index bf88618..7bc3862 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -364,6 +364,8 @@ static inline void vhost_d

[Qemu-devel] [PATCH v5 03/21] util: add linux-only memfd fallback

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau Implement memfd_create() fallback if not available in system libc. memfd_create() is still not included in glibc today, atlhough it's been available since Linux 3.17 in Oct 2014. memfd has numerous advantages over traditional shm/mmap for ipc memory sharing with fd handle

[Qemu-devel] [PATCH v5 10/21] vhost: use a function for each call

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau Replace the generic vhost_call() by specific functions for each function call to help with type safety and changing arguments. While doing this, I found that "unsigned long long" and "uint64_t" were used interchangeably and causing compilation warnings, using uint64_t ins

[Qemu-devel] [PATCH v5 08/21] vhost-user: send log shm fd along with log_base

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau Send the shm for the dirty pages logging if the backend supports VHOST_USER_PROTOCOL_F_LOG_SHMFD. Wait for a reply to make sure the old log is no longer used. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-backend.c | 3 ++- hw/virtio/vhost-user.c

[Qemu-devel] [PATCH v5 14/21] vhost user: add support of live migration

2015-09-24 Thread marcandre . lureau
From: Thibaut Collet Some vhost user backends are able to support live migration. To provide this service the following features must be added: 1. Add the VIRTIO_NET_F_GUEST_ANNOUNCE capability to vhost-net when netdev backend is vhost-user. 2. Provide a nop receive callback to vhost-user.

[Qemu-devel] [PATCH v5 19/21] vhost-user-test: learn to tweak various qemu arguments

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau Add a new macro to make the qemu command line with other values of memory size, and specific chardev id. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/vhost-user-test

[Qemu-devel] [PATCH v5 12/21] vhost-user: document migration log

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- docs/specs/vhost-user.txt | 48 +-- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt index 4eadad1..e0292a0 100644 --- a/d

[Qemu-devel] [PATCH v5 17/21] vhost-user-test: remove useless static check

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 88714ff..6662ca9 100644 --- a/tests/vhost-user-test.c +++ b/tests/vhost-user-test.c @@ -262,7 +262,6 @@

[Qemu-devel] [PATCH v5 16/21] vhost-user-test: move wait_for_fds() out

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau This function is a precondition for most vhost-user tests. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 77b7b68

[Qemu-devel] [PATCH v5 21/21] vhost-user-test: check ownership during migration

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau Check that backend source and destination do not have simultaneous ownership during migration. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/tests/vhost-user-test.

[Qemu-devel] [PATCH v5 13/21] net: add trace_vhost_user_event

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau Replace error_report() and use tracing instead. It's not an error to get a connection or a disconnection, so silence this and trace it instead. Signed-off-by: Marc-André Lureau --- net/vhost-user.c | 4 ++-- trace-events | 3 +++ 2 files changed, 5 insertions(+), 2

[Qemu-devel] [PATCH v5 18/21] vhost-user-test: wrap server in TestServer struct

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau In the coming patches, a test will use several servers simultaneously. Wrap the server in a struct, out of the global scope. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 146 ++-- 1 file changed, 92 insertion

Re: [Qemu-devel] [PATCH v5 05/46] qapi: Test use of 'number' within alternates

2015-09-24 Thread Markus Armbruster
Eric Blake writes: > On 09/24/2015 08:36 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Add some testsuite exposure for use of a 'number' as part of >>> an alternate. The current state of the tree has a few bugs >>> exposed by this: our input parser depends on the ordering of >>> ho

[Qemu-devel] [PATCH v5 15/21] vhost user: add rarp sending after live migration for legacy guest

2015-09-24 Thread marcandre . lureau
From: Thibaut Collet A new vhost user message is added to allow QEMU to ask to vhost user backend to broadcast a fake RARP after live migration for guest without GUEST_ANNOUNCE capability. This new message is sent only if the backend supports the new VHOST_USER_PROTOCOL_F_RARP protocol feature.

Re: [Qemu-devel] [PATCH 0/3] MAINTAINERS docs: flatten docs/qmp/, specify include and test files

2015-09-24 Thread Eric Blake
On 09/24/2015 10:11 AM, Markus Armbruster wrote: > Markus Armbruster (3): > docs: Move files from docs/qmp/ to docs/ > MAINTAINERS: Specify QObject include and test files > MAINTAINERS: Specify QAPI include and test files Reviewed-by: Eric Blake > > MAINTAINERS| 1

Re: [Qemu-devel] [PATCH v2 6/7] qdev: Protect device-list-properties against broken devices

2015-09-24 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Sep 23, 2015 at 04:09:48PM +0200, Markus Armbruster wrote: >> Several devices don't survive object_unref(object_new(T)): they crash >> or hang during cleanup, or they leave dangling pointers behind. >> >> This breaks at least device-list-properties, because >> q

[Qemu-devel] [PATCH v5 20/21] vhost-user-test: add live-migration test

2015-09-24 Thread marcandre . lureau
From: Marc-André Lureau This test checks that the log fd is given to the migration source, and mark dirty pages during migration. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 171 +++- 1 file changed, 168 insertions(+), 3 deletions(

Re: [Qemu-devel] [RfC PATCH 00/10] vnc buffer handling

2015-09-24 Thread Daniel P. Berrange
On Thu, Sep 24, 2015 at 10:41:58AM +0200, Gerd Hoffmann wrote: > Hi, > > Here is a patch series to improve the vnc buffer handling. It picks up > the qio_buffer patches from Daniel, adds move calls (move data from one > buffer to another) and tracing, makes vnc use the new features. Net > effe

Re: [Qemu-devel] [PATCH v5 12/21] vhost-user: document migration log

2015-09-24 Thread Eric Blake
On 09/24/2015 10:22 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > docs/specs/vhost-user.txt | 48 > +-- > 1 file changed, 46 insertions(+), 2 deletions(-) > @@ -140,8 +142,7 @@ Multiple

Re: [Qemu-devel] [PATCH v5 12/21] vhost-user: document migration log

2015-09-24 Thread Marc-André Lureau
Hi - Original Message - > On 09/24/2015 10:22 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > --- > > docs/specs/vhost-user.txt | 48 > > +-- > > 1 file changed, 46 insertions(

Re: [Qemu-devel] [PATCH v5 12/21] vhost-user: document migration log

2015-09-24 Thread Eric Blake
On 09/24/2015 10:41 AM, Marc-André Lureau wrote: >>> -only when the protocol feature VHOST_USER_PROTOCOL_F_MQ (bit 0) is set: >>> -#define VHOST_USER_PROTOCOL_F_MQ0 >>> +only when the protocol feature VHOST_USER_PROTOCOL_F_MQ (bit 0) is set. >> >> Should this hunk be in an earlier patch, > >

Re: [Qemu-devel] [PATCH v2 00/11] add virgl rendering support

2015-09-24 Thread Marc-André Lureau
Hi Gerd On Thu, Sep 24, 2015 at 11:04 AM, Gerd Hoffmann wrote: > Hi, > > This patch series adds infrastructure for opengl rendering > (context management, define scanout textures), adds support > for this to sdl2 and gtk user interfaces and adds virgl/3d > mode to virtio-gpu by hooking up the v

Re: [Qemu-devel] Loading image/elf to cpu that has different not system memory address space

2015-09-24 Thread mar.krzeminski
W dniu 24.09.2015 o 05:07, Peter Crosthwaite pisze: On Wed, Sep 23, 2015 at 8:06 PM, Peter Crosthwaite wrote: On Wed, Sep 23, 2015 at 10:31 AM, mar.krzeminski wrote: W dniu 23.09.2015 o 17:46, Peter Maydell pisze: On 23 September 2015 at 08:17, Marcin Krzemiński wrote: Hello, I am tryi

Re: [Qemu-devel] [PATCH 0/3] MAINTAINERS docs: flatten docs/qmp/, specify include and test files

2015-09-24 Thread Luiz Capitulino
On Thu, 24 Sep 2015 18:11:54 +0200 Markus Armbruster wrote: > Markus Armbruster (3): > docs: Move files from docs/qmp/ to docs/ > MAINTAINERS: Specify QObject include and test files > MAINTAINERS: Specify QAPI include and test files > > MAINTAINERS| 15

Re: [Qemu-devel] [PATCH v5 15/21] vhost user: add rarp sending after live migration for legacy guest

2015-09-24 Thread Thibaut Collet
On Thu, Sep 24, 2015 at 6:22 PM, wrote: > From: Thibaut Collet > > A new vhost user message is added to allow QEMU to ask to vhost user backend > to > broadcast a fake RARP after live migration for guest without GUEST_ANNOUNCE > capability. > > This new message is sent only if the backend suppo

Re: [Qemu-devel] [PATCH 4/7] vfio: Record host IOMMU's available IO page sizes

2015-09-24 Thread Alex Williamson
On Thu, 2015-09-24 at 14:33 +1000, David Gibson wrote: > Depending on the host IOMMU type we determine and record the available page > sizes for IOMMU translation. We'll need this for other validation in > future patches. > > Signed-off-by: David Gibson > Reviewed-by: Thomas Huth > Reviewed-by:

Re: [Qemu-devel] [PATCH 3/7] vfio: Check guest IOVA ranges against host IOMMU capabilities

2015-09-24 Thread Alex Williamson
On Thu, 2015-09-24 at 14:33 +1000, David Gibson wrote: > The current vfio core code assumes that the host IOMMU is capable of > mapping any IOVA the guest wants to use to where we need. However, real > IOMMUs generally only support translating a certain range of IOVAs (the > "DMA window") not a fu

Re: [Qemu-devel] [PATCH 5/7] memory: Allow replay of IOMMU mapping notifications

2015-09-24 Thread Alex Williamson
On Thu, 2015-09-24 at 14:33 +1000, David Gibson wrote: > When we have guest visible IOMMUs, we allow notifiers to be registered > which will be informed of all changes to IOMMU mappings. This is used by > vfio to keep the host IOMMU mappings in sync with guest IOMMU mappings. > > However, unlike

Re: [Qemu-devel] [PATCH 2/2] hw/vfio/platform: do not set resamplefd for edge-sensitive IRQS

2015-09-24 Thread Eric Auger
On 09/23/2015 09:28 PM, Alex Williamson wrote: > On Wed, 2015-09-23 at 00:00 +0100, Eric Auger wrote: >> In irqfd mode, current code attempts to set a resamplefd whatever >> the type of the IRQ. For an edge-sensitive IRQ this attempt fails >> and as a consequence the whole irqfd setup fails and we

[Qemu-devel] [PATCH] MAINTAINERS: Small IDE/FDC touchup

2015-09-24 Thread John Snow
libqos/ahci and tests/fdc-test are under my purview also, include them in the appropriate stanzas. Signed-off-by: John Snow --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cf02890..7d97bd8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -634,6

Re: [Qemu-devel] [PATCH RFC V4 4/4] Add virt-v3 machine that uses GIC-500

2015-09-24 Thread Christopher Covington
Hi, On 09/17/2015 01:38 PM, Shlomo Pongratz wrote: > From: Pavel Fedin > > I would like to offer this, slightly improved implementation. The key thing > is a new > kernel_irqchip_type member in Machine class. Currently it it used only by > virt machine for > its internal purposes, however in f

Re: [Qemu-devel] [PULL] remove libcacard

2015-09-24 Thread Peter Maydell
On 23 September 2015 at 14:38, wrote: > From: Marc-André Lureau > > The following changes since commit 684bb5770ec5d72a66620f64fc5d9672bf8d3509: > > Merge remote-tracking branch 'remotes/dgibson/tags/spapr-next-20150923' > into staging (2015-09-23 16:52:54 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH 00/16] block: Get rid of bdrv_swap()

2015-09-24 Thread Alberto Garcia
On Thu 17 Sep 2015 03:48:04 PM CEST, Kevin Wolf wrote: > bdrv_swap() has always been an ugly hack that we would rather have > avoided. When it was introduced, we simply didn't have the > infrastructure to update pointers instead of transplanting the > contents of BDS object, so we grudgingly adde

Re: [Qemu-devel] [PATCH v4] docs: describe the QEMU build system structure / design

2015-09-24 Thread Laszlo Ersek
On 09/24/15 15:41, Daniel P. Berrange wrote: > Developers who are new to QEMU, or have a background familiarity > with GNU autotools, can have trouble getting their head around the > home-grown QEMU build system. This document attempts to explain > the structure / design of the configure script and

Re: [Qemu-devel] [PULL 00/22] virtio,pc features, fixes

2015-09-24 Thread Peter Maydell
On 24 September 2015 at 06:20, Michael S. Tsirkin wrote: > The following changes since commit fefa4b128de06cec6d513f00ee61e8208aed4a87: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20150923.0' > into staging (2015-09-23 21:39:46 +0100) > > are available in the git reposit

Re: [Qemu-devel] Loading image/elf to cpu that has different not system memory address space

2015-09-24 Thread Peter Crosthwaite
On Thu, Sep 24, 2015 at 10:14 AM, mar.krzeminski wrote: > > > W dniu 24.09.2015 o 05:07, Peter Crosthwaite pisze: > > On Wed, Sep 23, 2015 at 8:06 PM, Peter Crosthwaite > wrote: > > On Wed, Sep 23, 2015 at 10:31 AM, mar.krzeminski > wrote: > > W dniu 23.09.2015 o 17:46, Peter Maydell pisze: > >

[Qemu-devel] [Bug 1350435] Re: tcg.c:1693: tcg fatal error

2015-09-24 Thread Michael Tokarev
Well. This is definitely wrong. It is a valid bug, but it needs quite serious work to fix, which requires major refactoring of the tcg code. Upstream is working on it, see http://wiki.qemu.org/Features/tcg- multithread ** Changed in: qemu Status: Invalid => Confirmed -- You received thi

Re: [Qemu-devel] [PATCH] rocker: Use g_new() & friends where that makes obvious sense

2015-09-24 Thread Jiri Pirko
Thu, Sep 24, 2015 at 06:18:43PM CEST, arm...@redhat.com wrote: >Michael, could you take this one through trivial? Assuming Scott and >Jiri don't mind, and with s/patchas/patch as/ in the commit message. I don't mind :)

[Qemu-devel] [Bug 1498144] Re: Failure booting hurd with qemu-system-i386 on ARM

2015-09-24 Thread PeteVine
I've just tried again with the latest commits - hurd boots, hooray! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1498144 Title: Failure booting hurd with qemu-system-i386 on ARM Status in QEMU:

Re: [Qemu-devel] [PULL 00/22] virtio,pc features, fixes

2015-09-24 Thread Michael S. Tsirkin
On Thu, Sep 24, 2015 at 11:36:35AM -0700, Peter Maydell wrote: > On 24 September 2015 at 06:20, Michael S. Tsirkin wrote: > > The following changes since commit fefa4b128de06cec6d513f00ee61e8208aed4a87: > > > > Merge remote-tracking branch > > 'remotes/awilliam/tags/vfio-update-20150923.0' into

[Qemu-devel] [PATCH v3 3/7] libqtest: New hmp() & friends

2015-09-24 Thread Markus Armbruster
New convenience function hmp() to facilitate use of human-monitor-command in tests. Use it to simplify its existing uses. To blend into existing libqtest code, also add qtest_hmpv() and qtest_hmp(). That, and the egregiously verbose GTK-Doc comment format make this patch look bigger than it is.

[Qemu-devel] [PATCH v3 2/7] libqtest: Clean up unused QTestState member sigact_old

2015-09-24 Thread Markus Armbruster
Unused since commit d766825. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/libqtest.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index e5188e0..8dede56 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -46,7 +46,6 @@ struct

[Qemu-devel] [PATCH v3 5/7] qmp: Fix device-list-properties not to crash for abstract device

2015-09-24 Thread Markus Armbruster
Broken in commit f4eb32b "qmp: show QOM properties in device-list-properties", v2.1. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qmp.c | 6 ++ tests/device-introspect-test.c | 15 --- 2 files changed, 10 inser

[Qemu-devel] [PATCH v3 4/7] device-introspect-test: New, covering device introspection

2015-09-24 Thread Markus Armbruster
The test doesn't check that the output makes any sense, only that QEMU survives. Useful since we've had an astounding number of crash bugs around there. In fact, we have a bunch of them right now: several devices crash or hang, and all CPUs leave a dangling pointer behind. The test skips testing

[Qemu-devel] [PATCH v3 0/7] Fix device introspection regressions

2015-09-24 Thread Markus Armbruster
QMP command device-list-properties regressed in 2.1: it can crash or leave dangling pointers behind. -device FOO,help regressed in 2.2: it no longer works for non-pluggable devices. I tried to fix that some time ago[*], but my fix failed review. This is my second, more comprehensive try. PATCH

Re: [Qemu-devel] [PULL 20/22] virtio: introduce virtqueue_unmap_sg()

2015-09-24 Thread Michael S. Tsirkin
On Thu, Sep 24, 2015 at 04:21:02PM +0300, Michael S. Tsirkin wrote: > From: Jason Wang > > Factor out sg unmapping logic. This will be reused by the patch that > can discard descriptor. > > Cc: Michael S. Tsirkin > Signed-off-by: Jason Wang > Reviewed-by: Michael S. Tsirkin > Signed-off-by: M

[Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices

2015-09-24 Thread Markus Armbruster
Several devices don't survive object_unref(object_new(T)): they crash or hang during cleanup, or they leave dangling pointers behind. This breaks at least device-list-properties, because qmp_device_list_properties() needs to create a device to find its properties. Broken in commit f4eb32b "qmp: s

[Qemu-devel] [PATCH v3 1/7] tests: Fix how qom-test is run

2015-09-24 Thread Markus Armbruster
We want to run qom-test for every architecture, without having to manually add it to every architecture's list of tests. Commit 3687d53 accomplished this by adding it to every architecture's list automatically. However, some architectures inherit their tests from others, like this: check-qte

Re: [Qemu-devel] Loading image/elf to cpu that has different not system memory address space

2015-09-24 Thread mar.krzeminski
W dniu 24.09.2015 o 20:38, Peter Crosthwaite pisze: On Thu, Sep 24, 2015 at 10:14 AM, mar.krzeminski wrote: W dniu 24.09.2015 o 05:07, Peter Crosthwaite pisze: On Wed, Sep 23, 2015 at 8:06 PM, Peter Crosthwaite wrote: On Wed, Sep 23, 2015 at 10:31 AM, mar.krzeminski wrote: W dniu 23.09.

[Qemu-devel] [PATCH v3 7/7] Revert "qdev: Use qdev_get_device_class() for -device , help"

2015-09-24 Thread Markus Armbruster
This reverts commit 31bed5509dfcbdfc293154ce81086a4dbd7a80b6. The reverted commit changed qdev_device_help() to reject abstract devices and devices that have cannot_instantiate_with_device_add_yet set, to fix crash bugs like -device x86_64-cpu,help. Rejecting abstract devices makes sense: they're

[Qemu-devel] [Bug 1350435] Re: tcg.c:1693: tcg fatal error

2015-09-24 Thread Serge Hallyn
Ah, thanks for setting me straight. ** Changed in: qemu (Ubuntu) Status: Invalid => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1350435 Title: tcg.c:1693: tcg fatal error Stat

Re: [Qemu-devel] [PATCH RFC V4 4/4] Add virt-v3 machine that uses GIC-500

2015-09-24 Thread Christopher Covington
On 09/24/2015 02:03 PM, Christopher Covington wrote: > Hi, > > On 09/17/2015 01:38 PM, Shlomo Pongratz wrote: >> From: Pavel Fedin >> >> I would like to offer this, slightly improved implementation. The key thing >> is a new >> kernel_irqchip_type member in Machine class. Currently it it used on

Re: [Qemu-devel] [PATCH v2 REPOST] oslib-win32: only provide localtime_r/gmtime_r if missing

2015-09-24 Thread Stefan Weil
Am 23.09.2015 um 10:33 schrieb Daniel P. Berrange: > On Tue, Sep 22, 2015 at 07:49:40PM +0200, Stefan Weil wrote: >> Hi, >> >> I suggest cleaning some comments, mostly using the "official" >> spellings for MinGW and Mingw-w64. [...] >> Otherwise this patch looks good. >> >> If you agree, I'd clea

Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices

2015-09-24 Thread Eduardo Habkost
On Thu, Sep 24, 2015 at 08:57:21PM +0200, Markus Armbruster wrote: [...] > diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c > index ff249af..7692090 100644 > --- a/hw/arm/allwinner-a10.c > +++ b/hw/arm/allwinner-a10.c > @@ -103,6 +103,8 @@ static void aw_a10_class_init(ObjectClass *oc,

Re: [Qemu-devel] [PATCH v3 13/25] target-sparc: Split out gen_branch_n

2015-09-24 Thread Aurelien Jarno
On 2015-09-22 13:24, Richard Henderson wrote: > Unify three copies of this code from different > branch types. Fix the case when npc == DYNAMIC_PC, > i.e. a branch within a delay slot. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > target-sparc/translate.c | 55 > ++

Re: [Qemu-devel] [PATCH v3 14/25] target-sparc: Remove gen_opc_jump_pc

2015-09-24 Thread Aurelien Jarno
On 2015-09-22 13:24, Richard Henderson wrote: > Since jump_pc[1] is always npc + 4, we can infer after incrementing > that jump_pc[1] == pc + 4. Because of that, we can encode the branch > destination into a single word, and store that in npc. > > Reviewed-by: Peter Maydell > Signed-off-by: Rich

Re: [Qemu-devel] [PATCH v3 12/25] target-sparc: Tidy gen_branch_a interface

2015-09-24 Thread Aurelien Jarno
On 2015-09-22 13:24, Richard Henderson wrote: > We always pass pc2 == dc->npc and r_cond == cpu_cond, > and always set is_br afterward. Infer all of that. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > target-sparc/translate.c | 21 ++--- > 1 file cha

Re: [Qemu-devel] [PATCH v3 15/25] target-sparc: Add npc state to insn_start

2015-09-24 Thread Aurelien Jarno
On 2015-09-22 13:24, Richard Henderson wrote: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > target-sparc/cpu.h | 1 + > target-sparc/translate.c | 7 ++- > 2 files changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Aurelien Jarno -- Aurelien Jarno

<    1   2   3   4   >