On Tue, Sep 22, 2015 at 02:23:20PM +0200, Paolo Bonzini wrote: > > > On 18/09/2015 15:18, Daniel P. Berrange wrote: > > David Gilbert had some feedback on my previous RFC series which > > I have incorporated into this new posting. I did forget his > > comments about using #defines instead of magic constants in > > the websock patch, so that's still on my todo list. > > > > Finally I've listed myself as maintainer for the new io/ and > > include/io/ directory prefixes. > > I only made a few very small remarks. The API is reasonable and you've > proved its utility by using it in the rest of your project.
Thanks, I'd still love one or more people to do a detailed review of the I/O channel implementations before I think about sending a PULL request, since there's a fair amount of code in there.... > I remember I had some remarks about the rest of the conversion and > especially the integration with coroutines, but it's not part of this > series. I'm curious now as to which bit you might be refering to here :-) IIRC the only place I had any interaction with coroutines was the migration code QEMUFile implementation, where I need to yield when reads block. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
