On Mon, Sep 21, 2015 at 01:50:23PM +0200, Igor Mammedov wrote:
[...]
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index caa4edc..7671905 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -301,9 +301,17 @@ static void pc_init1(MachineState *machine,
> }
> }
>
> +stati
On Sat, Sep 19, 2015 at 10:13:21AM +0200, Andreas Färber wrote:
> Am 04.09.2015 um 20:37 schrieb Eduardo Habkost:
> > Convert all machines to use DEFINE_MACHINE instead of QEMUMachine
> > automatically using a script.
[...]
> > Changes v1 -> v2:
> > * Fix trailing spaces and newlines
> > * Don't to
On 09/19/15 12:54, Marina Kovalevna wrote:
> Hello boyos,
>
> I got myself an Rpi2 recently and have been reading up on qemu.
>
> Does this mean there's a problem booting x86 images on Arm or just the
> ones from that particular source?
>
The outlandishness of this use case (-> buy an underpowe
On Mon, Sep 21, 2015 at 08:09:48AM +0200, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > On Fri, Sep 18, 2015 at 02:00:38PM +0200, Markus Armbruster wrote:
> >> Several devices don't survive object_unref(object_new(T)): they crash
> >> or hang during cleanup, or they leave dangling poin
On Mon, Sep 21, 2015 at 08:14:56AM +0200, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > On Fri, Sep 18, 2015 at 08:42:54PM +0200, Thomas Huth wrote:
> >> On 18/09/15 14:00, Markus Armbruster wrote:
> >> > Several devices don't survive object_unref(object_new(T)): they crash
> >> > or h
On 21 September 2015 at 08:12, Laszlo Ersek wrote:
> Where does the division by zero come from then? Well grub fetches and
> stashes the TSC, then programs the PIT to sleep for some time, then
> re-fetches the TSC, and uses the TSC difference as denominator when
> calculating the "TSC rate". (It h
On Mon, Sep 21, 2015 at 10:30:50AM +0200, David Hildenbrand wrote:
> > Am 18.09.2015 um 14:00 schrieb Markus Armbruster:
> > > Several devices don't survive object_unref(object_new(T)): they crash
> > > or hang during cleanup, or they leave dangling pointers behind.
> > >
> > > This breaks at leas
On 09/21/2015 05:24 AM, Prasanna Kumar Kalever wrote:
> This patch adds a way to specify multiple backup volfile servers to the
> gluster
> block backend of QEMU with tcp|rdma transport types and their port numbers.
>
>
> This patch gives a mechanism to provide all the server addresses which ar
Hi,
is this a duplicate of 1493049? (Should they be merged?)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1497479
Title:
memory corruption with migrate/savevm in TCG mode
Status in QEMU:
New
On 09/21/2015 12:00 AM, Thomas Huth wrote:
>>> This being said, I am not sure about the use case where a user has a hwrng
>>> capable platform and wants to run guests without any hwrng support at all is
>>> an appropriate default behavior... I guess we will find more users that want
>>> in-kernel
On 21/09/15 08:14, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
>> On Fri, Sep 18, 2015 at 08:42:54PM +0200, Thomas Huth wrote:
>>> On 18/09/15 14:00, Markus Armbruster wrote:
Several devices don't survive object_unref(object_new(T)): they crash
or hang during cleanup, or they l
On Sat, Sep 19, 2015 at 04:43:29PM +0200, Andreas Färber wrote:
> The script used for converting from QEMUMachine had used one
> DEFINE_MACHINE() per machine registered. In cases where multiple
> machines are registered from one source file, avoid the excessive
> generation of module init functions
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On 21 September 2015 at 08:12, Laszlo Ersek wrote:
> > Where does the division by zero come from then? Well grub fetches and
> > stashes the TSC, then programs the PIT to sleep for some time, then
> > re-fetches the TSC, and uses the TSC differen
Am 21.09.2015 um 17:49 schrieb Eduardo Habkost:
> On Sat, Sep 19, 2015 at 04:43:29PM +0200, Andreas Färber wrote:
>> The script used for converting from QEMUMachine had used one
>> DEFINE_MACHINE() per machine registered. In cases where multiple
>> machines are registered from one source file, avoi
On 09/21/2015 01:57 AM, Kevin Wolf wrote:
>>> +- "wr_highest_offset": The offset after the greatest byte written to
>>> the
>>> + BlockDriverState since it has been opened
>>> (json-int)
>>
>> ...someday, I'd really like to have this stat show as non-zero even when
On Sat, Sep 19, 2015 at 05:36:37PM +0200, Andreas Färber wrote:
> Hello,
>
> Based on my pending qom-next pull, this series continues Eduardo's machine
> cleanups.
> Having eliminated QEMUMachine and qemu_machine_register(), this series
> eliminates
> machine_init() and MODULE_INIT_MACHINE.
>
>
It is going to be in QEMU 2.5 and qemu-xen 4.7.
On Mon, 21 Sep 2015, Chen, Tiejun wrote:
> Stefano,
>
> I have two questions,
>
> #1. Which qemu version is this igd stuff going into? 2.6?
> #2. Is this igd stuff going into qemu-xen inside xen? Any plan to go into xen
> 4.6?
>
> Thanks
> Tiejun
Hi,
This one is for QEMU master, 1493049 is for Ubuntu packages.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1497479
Title:
memory corruption with migrate/savevm in TCG mode
Status in QEMU:
N
> -Original Message-
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com]
> Sent: Monday, September 21, 2015 8:01 PM
> To: Sai Pavan Boddu
> Cc: qemu-devel@nongnu.org Developers; Stefan Hajnoczi; Peter Maydell;
> Alistair Francis; Edgar Iglesias; Sai Pavan Boddu
> Subject: Re: [P
The previous commit
commit 9a2fd4347c40321f5cbb4ab4220e759fcbf87d03
Author: Daniel P. Berrange
Date: Mon Apr 13 14:01:39 2015 +0100
crypto: add sanity checking of TLS x509 credentials
defined new variables $TEST_LIBS and $TEST_CFLAGS and
used them in tests/Makefile to augment $LIBS
On Mon, Sep 21, 2015 at 09:48:15AM +0100, Daniel P. Berrange wrote:
> On Sat, Sep 19, 2015 at 09:47:01PM -0700, Peter Crosthwaite wrote:
> > > diff --git a/configure b/configure
> > > index d7c24cd..bdd302c 100755
> > > --- a/configure
> > > +++ b/configure
> > > @@ -416,6 +416,9 @@ if test "$debu
Thomas Huth writes:
> On 21/09/15 08:14, Markus Armbruster wrote:
>> Eduardo Habkost writes:
>>
>>> On Fri, Sep 18, 2015 at 08:42:54PM +0200, Thomas Huth wrote:
On 18/09/15 14:00, Markus Armbruster wrote:
> Several devices don't survive object_unref(object_new(T)): they crash
> or
On 2015-09-17 21:55, Richard Henderson wrote:
> With an eye toward making it mandatory.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> ---
> target-alpha/translate.c | 2 +-
> target-arm/translate-a64.c| 2 +-
> target-arm/translate.c| 2 +-
> target-cris/t
On 2015-09-17 21:55, Richard Henderson wrote:
> While we're at it, emit the opcode adjacent to where we currently
> record data for search_pc. This puts gen_io_start et al on the
> "correct" side of the marker.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> ---
> target-al
On 2015-09-17 21:55, Richard Henderson wrote:
> This does tidy the icount test common to all targets.
>
> Signed-off-by: Richard Henderson
> ---
> target-alpha/translate.c | 4 ++--
> target-arm/translate-a64.c| 6 +++---
> target-arm/translate.c| 7 ---
> target-cris/transl
When DT node names for PCI devices are generated by SLOF,
they are generated according to the type of the device
(for instance, ethernet for virtio-net-pci device).
Node name for hotplugged devices is generated by QEMU.
This patch adds the mechanic to QEMU to create the node
name according to the
On 09/21/15 17:50, Dr. David Alan Gilbert wrote:
> * Peter Maydell (peter.mayd...@linaro.org) wrote:
>> On 21 September 2015 at 08:12, Laszlo Ersek wrote:
>>> Where does the division by zero come from then? Well grub fetches and
>>> stashes the TSC, then programs the PIT to sleep for some time, th
Generally combining them is still better - but if it helps you to
keep things straight then no problem, sorry for the noise - thanks.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1497479
Title:
me
On 21/09/15 18:39, Markus Armbruster wrote:
> Thomas Huth writes:
>
>> On 21/09/15 08:14, Markus Armbruster wrote:
>>> Eduardo Habkost writes:
>>>
On Fri, Sep 18, 2015 at 08:42:54PM +0200, Thomas Huth wrote:
> On 18/09/15 14:00, Markus Armbruster wrote:
>> Several devices don't surv
On Mon, Sep 21, 2015 at 05:52:47PM +0200, Andreas Färber wrote:
> Am 21.09.2015 um 17:49 schrieb Eduardo Habkost:
> > On Sat, Sep 19, 2015 at 04:43:29PM +0200, Andreas Färber wrote:
> >> The script used for converting from QEMUMachine had used one
> >> DEFINE_MACHINE() per machine registered. In ca
Am 21.09.2015 um 03:19 schrieb Mike Ladouceur:
> Okay, i followed the steps from the reply to my email I noticed on the
> website, but never made its way to my inbox. Now, I'm stuck with the
> following errors:
>
> /home/mike/qemu/include/glib-compat.h: At top level:
> /home/mike/qemu/include/glib
Signed-off-by: Max Filippov
---
target-xtensa/helper.c| 8
target-xtensa/op_helper.c | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/target-xtensa/helper.c b/target-xtensa/helper.c
index 76be50d..2c3447b 100644
--- a/target-xtensa/helper.c
+++ b/target-xtensa
What a funny coincidence, just before getting all of that bug email
(telepathy?), I decided to also try a debian hurd image, but it
immediately aborts:
qemu-system-i386: qemu-coroutine-lock.c:91: qemu_co_queue_restart_all:
Assertion `qemu_in_coroutine()' failed.
Aborted
Is this known and/or des
On Mon, Sep 21, 2015 at 02:24:51PM -0300, Eduardo Habkost wrote:
> On Mon, Sep 21, 2015 at 05:52:47PM +0200, Andreas Färber wrote:
> > Am 21.09.2015 um 17:49 schrieb Eduardo Habkost:
> > > On Sat, Sep 19, 2015 at 04:43:29PM +0200, Andreas Färber wrote:
> > >> The script used for converting from QEM
Please use different subjects that uniquely identify what each patch
does, don't simply re-use the subject for the cover patch on each.
On Wed, 2015-09-16 at 10:02 +0800, Cao jin wrote:
> In case user regret when hot-add multi-function, we should roll back,
> device_del the function added but st
PeteVine: That sounds like a separate bug ; probably best to get a
separate report for it with a backtrace.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/893208
Title:
qemu on ARM hosts can't boot
On Mon, Sep 21, 2015 at 07:22:51PM +0200, Thomas Huth wrote:
> On 21/09/15 18:39, Markus Armbruster wrote:
> > Thomas Huth writes:
> >> On 21/09/15 08:14, Markus Armbruster wrote:
> >>> Eduardo Habkost writes:
> On Fri, Sep 18, 2015 at 08:42:54PM +0200, Thomas Huth wrote:
> > On 18/09/15
On 09/21/2015 11:25 AM, Marcel Apfelbaum wrote:
On 09/21/2015 08:01 AM, Star Chang wrote:
Hi Marcel:
Many thanks for you to contribute wiki page in how to configuring vhost-user
type with openvsitch/qemu in VM environment.
We bring 2 VMs up with vhost-user type. We can see eth0 interfaces cre
On 20 September 2015 at 13:53, Alexander Graf wrote:
> Hi Peter,
>
> This is my current patch queue for ppc. Please pull.
>
> Alex
>
> CC: Aurelien Jarno
> CC: David Gibson
>
> The following changes since commit 18640989a9f5e4d2e84b566c52ff1fccfa0dbf4a:
>
> Merge remote-tracking branch 'remot
Dear all,
I am trying to add some trace points to the qemu source code and see them
in trace compass. The question is: I don't know where to add my trace
point. I add some tracepoints to vhost-net.c sometimes there is some traces
and sometime there is not at all when I use wget command.
Further inf
Dear all,
I am trying to add some trace points to the qemu source code and see them
in trace compass. The question is: I don't know where to add my trace
point. I add some tracepoint to vhost-net.c sometimes there is some traces
and sometime there is not at all when I use wget command.
Further info
Dear all,
I am trying to add some trace points to the qemu source code and see them
in trace compass. The question is: I don't know where to add my trace
point. I add some tracepoints to vhost-net.c sometimes there is some traces
and sometime there is not at all when I use wget command.
Further inf
On 19 September 2015 at 08:01, Programmingkid wrote:
>
> On Sep 19, 2015, at 10:58 AM, Peter Maydell wrote:
>> By the way, I don't mean that I'm completely opposed to the
>> idea of dropping the open-dialog. I'd just like to hear
>> some input from other people who care about OSX QEMU
>> rather th
On Sep 21, 2015, at 3:01 PM, Peter Maydell wrote:
> On 19 September 2015 at 08:01, Programmingkid
> wrote:
>>
>> On Sep 19, 2015, at 10:58 AM, Peter Maydell wrote:
>>> By the way, I don't mean that I'm completely opposed to the
>>> idea of dropping the open-dialog. I'd just like to hear
>>> so
Public bug reported:
Trying to boot debian-hurd-20150320.img ends with:
qemu-system-i386: qemu-coroutine-lock.c:91: qemu_co_queue_restart_all:
Assertion `qemu_in_coroutine()' failed.
Program received signal SIGABRT, Aborted.
__libc_do_syscall ()
at ../ports/sysdeps/unix/sysv/linux/arm/libc-d
On 09/17/2015 07:03 AM, Daniel P. Berrange wrote:
> The README file is usually the first thing consulted when a user
> or developer obtains a copy of the QEMU source. The current QEMU
> README is lacking immediately useful information and so not very
> friendly for first time encounters. It eithe
On 09/17/2015 12:43 PM, Markus Armbruster wrote:
> "Daniel P. Berrange" writes:
>
>> On Thu, Sep 17, 2015 at 01:20:43PM +0100, Peter Maydell wrote:
>>> On 17 September 2015 at 13:05, Daniel P. Berrange
>>> wrote:
On Thu, Sep 17, 2015 at 12:32:56PM +0100, Peter Maydell wrote:
> On 17
On Mon, Sep 21, 2015 at 10:02:02AM -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > On Sat, Sep 19, 2015 at 12:11:58PM +0200, marcandre.lur...@redhat.com wrote:
> > > From: Marc-André Lureau
> > >
> > > If the backend is of type VHOST_BACKEND_TYPE_USER, allocate
> > > sh
On Mon, Sep 21, 2015 at 10:05:22AM -0400, Marc-André Lureau wrote:
>
>
> - Original Message -
> > On Sat, Sep 19, 2015 at 12:12:02PM +0200, marcandre.lur...@redhat.com wrote:
> > > From: Marc-André Lureau
> > >
> > > Send the shm for the dirty pages logging if the backend supports
> > >
** Description changed:
Trying to boot debian-hurd-20150320.img ends with:
qemu-system-i386: qemu-coroutine-lock.c:91: qemu_co_queue_restart_all:
Assertion `qemu_in_coroutine()' failed.
Program received signal SIGABRT, Aborted.
__libc_do_syscall ()
- at ../ports/sysdeps/unix/sy
On Mon, Sep 21, 2015 at 06:13:57AM -0700, Peter Maydell wrote:
> On 20 September 2015 at 22:34, Jonathan Neuschäfer
> wrote:
> > On Fri, Sep 04, 2015 at 01:48:39PM +0100, Peter Maydell wrote:
> >> On 3 September 2015 at 06:27, Jonathan Neuschäfer
> >> wrote:
> >> > Currently, __target_cmsg_nxthd
Change the maintainer for Allwinner A10 to myself as Li Guang's mail
address bounces. While at it, extend the file pattern for the entry to
include allwinner_emac.[ch].
Signed-off-by: Beniamino Galvani
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAIN
On Mon, Sep 21, 2015 at 12:45:21PM -0700, Riku Voipio wrote:
> On Mon, Sep 21, 2015 at 06:13:57AM -0700, Peter Maydell wrote:
> > On 20 September 2015 at 22:34, Jonathan Neuschäfer
[...]
> > > What's the status of this patch?
>
> > It's waiting for Riku to wake up and put it into a linux-user
> >
On Mon, Sep 21, 2015 at 12:52 PM, Beniamino Galvani wrote:
> Change the maintainer for Allwinner A10 to myself as Li Guang's mail
> address bounces. While at it, extend the file pattern for the entry to
> include allwinner_emac.[ch].
>
> Signed-off-by: Beniamino Galvani
Reviewed-by: Peter Crosth
Fixes https://bugs.launchpad.net/qemu/+bug/1497711
(!ncq || (ncq && lba48)) is the same as
(!ncq || lba48).
The intention is simply: "If a command is NCQ,
it must also be LBA48."
Signed-off-by: John Snow
---
tests/libqos/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 09/21/2015 08:25 AM, Peter Lieven wrote:
> This series aims at avoiding a hanging main-loop if a vserver has a
> CDROM image mounted from a NFS share and that NFS share goes down.
> Typical situation is that users mount an CDROM ISO to install something
> and then forget to eject that CDROM af
Paolo Bonzini writes:
> On 24/08/2015 02:23, Emilio G. Cota wrote:
>> +void HELPER(aie_st_pre)(CPUArchState *env, target_ulong vaddr)
>> +{
>> +if (unlikely(env->aie_lock_enabled)) {
>> +if (env->aie_locked) {
>> +return;
>> +}
>
> Now that I've reviewed your code
l32.net/qemu.git tags/pull-tcg-mips-20150921
>
> for you to fetch changes up to 81dfaf1a8f7f95259801da9732472f879023ef77:
>
> tcg/mips: pass oi to tcg_out_tlb_load (2015-09-19 11:53:15 +0200)
>
>
> TCG MIPS que
> Am 21.09.2015 um 22:58 schrieb John Snow :
>
>
>
>> On 09/21/2015 08:25 AM, Peter Lieven wrote:
>> This series aims at avoiding a hanging main-loop if a vserver has a
>> CDROM image mounted from a NFS share and that NFS share goes down.
>> Typical situation is that users mount an CDROM ISO t
ble in the git repository at:
>
> git://github.com/dgibson/qemu.git spapr-next-20150921
>
> for you to fetch changes up to 5576a6644cb302ac5b715205e7b4f157f116b9de:
>
> ppc/spapr: Fix buffer overflow in spapr_populate
Hi
On Mon, Sep 21, 2015 at 9:29 PM, Michael S. Tsirkin wrote:
>> Can this be considered a future enhancement?
>
> What's the big issue? Just count the devices that need a shared one, if
> that count is 0 reallocate with shared == false.
But then it should also VHOST_SET_LOG_BASE all the other d
From: Chen Gang
v2sh* are implemented with helper fucntions, according to the v1sh*
implementations.
v4sh* are implmeneted in normal code.
Signed-off-by: Chen Gang
---
target-tilegx/helper.h | 3 +++
target-tilegx/simd_helper.c | 31 +++
target-tilegx/transla
Use of '"...%s" % include' to print non-strings can lead to
ugly messages, such as this (if the .json change is applied
without the qapi.py change):
Expected a file name (string), got: OrderedDict()
Better is to just omit the actual non-string value in the
message.
Signed-off-by: Eric Blake
---
Recent changes to qapi have provided quite a bit of churn in
the makefile, because we are inconsistent on what order test
names appear in, and on whether to re-wrap the list of tests or
just add arbitrary line lengths. Writing the list in a sorted
fashion, one test per line, will make future patch
Silence pep8, and make pylint a bit happier. Just style cleanups;
no semantic changes.
Signed-off-by: Eric Blake
---
scripts/qapi.py | 165
1 file changed, 107 insertions(+), 58 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
It should be fairly obvious that qapi base classes need to
form an acyclic graph, since QMP cannot specify the same
key more than once, while base classes are included as flat
members alongside other members added by the child. But prior
to Markus' introspection commits (such as commit 75ebcd7f),
Expose some weaknesses in the generator: we don't always forbid
the generation of structs that contain multiple members that map
to the same C name. This has already been marked FIXME in
qapi.py, but having more tests will make sure future patches
produce desired behavior.
Some of these tests wil
Previously, working with alternates required two enums, and
some indirection: for type Foo, we created Foo_qtypes[] which
maps each qtype to a member of FooKind_lookup[], then use
FooKind_lookup[] like we do for other union types.
This has a subtle bug: since the values of FooKind_lookup
start at
The documentation claims that alternates are useful for
allowing two types, although nothing enforces this. Meanwhile,
it is silent on whether empty unions are allowed. In practice,
the generated code will compile, in part because we have a
'void *data' branch; but attempting to visit such a type
Detect attempts to declare two object members that would result
in the same C member name, by keying the 'seen' dictionary off
of the C name rather than the qapi name. As this is the first
error raised within the QapiSchema check() methods, we also have
to pass 'info' around through the call stack
Due to the existing semantics of the error_set() family,
generated sequences in the qapi visitors such as:
visit_start_implicit_struct(m, (void **)obj, sizeof(FOO), &err);
if (!err) {
visit_type_FOO_fields(m, obj, errp);
visit_end_implicit_struct(m, &err);
No longer RFC, but depends on Markus' pull-qapi-2015-09-21 tag
(https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg05257.html)
which had not been merged as of this email.
Also available at this location (although I may rebase it):
git fetch git://repo.or.cz/qemu/ericb.git qapi
http://repo.or
With the previous commit, we have two different locations for
detecting member name clashes - one at parse time, and another
at schema check() time. Consolidate the checks into a single
place, which is also in line with our TODO to eventually defer
all of the parse time semantic checking into the
Our generated list visitors have the same problem as has been
mentioned elsewhere (see commit 2f52e20): they allocate data
even on failure. An upcoming patch will correct things to
provide saner guarantees, but first we need to expose the
behavior in the testsuite to ensure we aren't introducing an
None of the visitor callbacks would set an error when testing
if an optional field was present; make this part of the interface
contract by eliminating the errp argument. Then, for less code,
reflect the determined boolean value back to the caller instead
of making the caller read the boolean afte
Add some testsuite exposure for use of a 'number' as part of
an alternate. The current state of the tree has a few bugs
exposed by this: our input parser depends on the ordering of
how the qapi schema declared the alternate, and the parser
does not accept integers for a 'number' in an alternate ev
Rather than open-code the check for a valid base type, we
should reuse the common functionality. This allows for
consistent error messages, and also makes it easier for a
later patch to turn on support for inline anonymous base
structures.
Test flat-union-inline is updated to test only one feature
Sorting the values of an enum makes it easier to look up whether
a particular value is present by binary rather than linear search
(probably most visible with QKeyCode, which has grown over
several releases). Additionally, QMP clients need not know which
C value is associated with an enum name, so
Consolidate the code between visit, command marshalling, and
event generation that iterates over the members of a struct.
It reduces code duplication in the generator, with no change to
generated marshal code, slightly more verbose visit code:
| visit_optional(v, &(*obj)->has_device, "device",
Commit cee2dedb noticed that if you have a partial flat union
(such as if an input parse failed due to a missing
discriminator), calling the dealloc visitor could result in
trying to dereference the NULL pointer. But the fix it proposed
requires the use of a 'data' member in the union, which may or
We had some pointless differences in the generated code for visit,
command marshalling, and events; unifying them makes it easier for
future patches to consolidate to common helper functions.
- Consistently name the error variable 'err'
- Consistently use the labels 'out' and 'out_obj'
- If allocat
Returning a partial object on error is an invitation for a careless
caller to leak memory. As no one outside the testsuite was actually
relying on these semantics, it is cleaner to just document and
guarantee that ALL visit_type_FOO() functions do not alter *obj
when an error is encountered during
A future patch will enable error reporting from the various
check() methods. But to report an error on an implicit type,
we'll need to associate a location with the type (the same
location as the top-level entity that is causing the creation
of the implicit type), and once we do that, keying off o
Clean up the only remaining external use of the tag_name field of
QAPISchemaObjectTypeVariants, by explicitly listing the generated
'type' tag for simple unions in the testsuite. Since alternate
types no longer use the tag_member field, we can now mark the
tag_name field as private by adding a lea
The code for visiting the base class of a child struct created
visit_type_Base_fields(); the code for visiting the base class
of a flat union created visit_type_Union_fields(). If the same
type is shared between a struct and a union, the two functions
differed only by whether they visited the discr
A future patch will enable error detection in the various
QapiSchema check() methods. But since all errors have to
have an associated 'info' location, we need a location to
be associated with all implicit types. Easiest is to reuse
the location of the enclosing entity that includes the
dictionary
Future commits will migrate semantic checking away from parsing
and over to the various QAPISchema*.check() methods. But to
report an error message about an incorrect semantic use of a
member of an object type, we need to know which type, command,
or event owns the member. Rather than making all
For the sake of humans reading introspection output, it is nice
to have the name of implicit array types be recognizable as
arrays of the underlying type. However, while this patch allows
humans to skip from a command with return type "[123]" straight
to the definition of type "123" without having
Empty unions serve no purpose, and while we compile with gcc
which permits them, strict C99 forbids them. We could inject
a dummy member (and in fact, we do for empty structs), but while
empty structs make sense in qapi, empty unions don't add any
expressiveness to the QMP language. So prohibit t
Rather than storing a base class as a pointer to a box, just
store the fields of that base class in the same order, so that
a child struct can be safely cast to its parent. This gives
less malloc overhead, less pointer dereferencing, and even less
generated code.
Without boxing, the corner case o
The previous commit documented an inconsistency in how we are
using the stack of qmp-output-visitor. Normally, pushing a
single top-level object puts the object on the stack twice:
once as the root, and once as the current container being
appended to; but popping that struct only pops once. Howev
qapi code generators currently create a 'void *data' member as
part of the anonymous union embedded in the C struct corresponding
to a qapi union. However, directly assigning to this member of
the union feels a bit fishy, when we can directly use the rest
of the struct instead.
Signed-off-by: Eri
Turn on the ability to pass command and event arguments in
a single boxed parameter. This patch merely tests the use
of the feature on structs. With this patch, we still reject
union types, and crash on { 'command':'foo', 'data': {
anonymous...}, 'box':true }; that will be addressed in the
next p
The QMP input visitor allows integral values to be assigned by
promotion to a QTYPE_QFLOAT. However, when parsing an alternate,
we did not take this into account, such that an alternate that
accepts 'number' but not 'int' would reject integral values.
With this patch, we now have the following de
Commit cbc95538 removed unused start_handle() and end_handle(),
but forgot got remove their declarations.
Commit 4e27e819 introduced optional visitor callbacks for all
sorts of int types, but except for type_uint64 and type_size,
none of them have ever been supplied (the generic implementation
bas
Commit 6c2f9a15 ensured that we would not return NULL when the
caller used an output visitor but had nothing to visit. But
in doing so, it added a FIXME about a reference count leak
that could abort qemu in the (unlikely) case of SIZE_MAX such
visits (more plausible on 32-bit).
This fixes things b
From: Kővágó, Zoltán
They are required for flat unions (you still have to allocate the
structs).
Signed-off-by: Kővágó, Zoltán
Message-Id:
<88451f26df139c09b56b1525f3c5afeea43dd3db.1441627175.git.dirty.ice...@gmail.com>
Signed-off-by: Eric Blake
---
qapi/opts-visitor.c | 15 +++
When dealing with simple qapi unions, the code was generating a
discriminator field of 'kind' even though the discriminator is
sent as 'type' over QMP. Renaming things to match gets us one
step closer to reusing common generator code for both simple and
flat unions, without having to special case
The visitor interface for mapping between QObject and qapi
has formerly been documented only by reading source code,
making it difficult to propose changes to either
scripts/qapi*.py or to clients without knowing whether those
changes would be safe. This tries to add documentation,
including menti
From: Kővágó, Zoltán
Except qapi-schema.json, this patch was generated by:
find . -name .git -prune -o -type f \! -name '*~' -print0 | \
xargs -0 sed -i \
-e 's/NetClientOptionsKind/NetClientDriver/g' \
-e 's/NET_CLIENT_OPTIONS_KIND_/NET_CLIENT_DRIVER_/g' \
-e 's/netdev->opts/netde
101 - 200 of 258 matches
Mail list logo
