Am 21.09.2015 um 17:49 schrieb Eduardo Habkost: > On Sat, Sep 19, 2015 at 04:43:29PM +0200, Andreas Färber wrote: >> The script used for converting from QEMUMachine had used one >> DEFINE_MACHINE() per machine registered. In cases where multiple >> machines are registered from one source file, avoid the excessive >> generation of module init functions by reverting this unrolling. > > Why is that a problem?
It's unnecessary code bloat and it blocks the usual QOM patterns. See the follow-up series for an example where an abstract base type helps, which your macro does not allow. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
