Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] spapr: Add support for hwrng when available

2015-09-10 Thread David Gibson
On Thu, Sep 10, 2015 at 09:33:21AM +0200, Thomas Huth wrote: > On 09/09/15 23:10, Thomas Huth wrote: > > On 08/09/15 07:15, David Gibson wrote: > ... > >> At this point rather than just implementing them as discrete machine > >> options, I suspect it will be more maintainable to split out the > >>

Re: [Qemu-devel] [PATCH 1/4] virtio: ring sizes vs. reset

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 12:22:54PM +0200, Cornelia Huck wrote: > On Thu, 10 Sep 2015 12:02:44 +0300 > "Michael S. Tsirkin" wrote: > > > On Fri, Sep 04, 2015 at 10:54:26AM +0200, Cornelia Huck wrote: > > > We allow guests to change the size of the virtqueue rings by supplying > > > a number of buf

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 11:29:18AM +0100, Stefano Stabellini wrote: > CC Michael > > On Thu, 10 Sep 2015, Stefano Stabellini wrote: > > On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > > > xen-host-pci-device.c is only compiled if CONFIG_XEN_PCI_PASSTHROUGH > > > > was set by configure. That won't be

Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation

2015-09-10 Thread Paolo Bonzini
On 10/09/2015 12:37, Dennis Luehring wrote: >> >> Can you also show the perf top of the tcg-search-2 branch run? > > perf top from tcg-search-2 branch > > http://pastebin.com/AtASpQvk Still has gen_intermediate_code_pc in it. Paolo

Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation

2015-09-10 Thread Dennis Luehring
Am 10.09.2015 um 12:37 schrieb Dennis Luehring: Am 10.09.2015 um 11:54 schrieb Artyom Tarasenko: > On Thu, Sep 10, 2015 at 11:32 AM, Dennis Luehring wrote: >> >Am 10.09.2015 um 09:00 schrieb Artyom Tarasenko: >>> > >>> >strangly your branch doesn't changed anything for pure SPARC64 in m

Re: [Qemu-devel] [PATCH 1/2] pc: memhotplug: fix incorrectly set reserved-memory-end

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 11:59:07AM +0200, Igor Mammedov wrote: > On Wed, 9 Sep 2015 17:03:56 -0300 > Eduardo Habkost wrote: > > > On Mon, Sep 07, 2015 at 01:55:31PM +0200, Igor Mammedov wrote: > > > reserved-memory-end tells firmware address from which > > > it could start treating memory as PCI

Re: [Qemu-devel] [RFC 09/38] rcu: fix comment with s/rcu_gp_lock/rcu_registry_lock/

2015-09-10 Thread Alex Bennée
Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota > --- > include/qemu/rcu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/qemu/rcu.h b/include/qemu/rcu.h > index 7df1e86..f6d1d56 100644 > --- a/include/qemu/rcu.h > +++ b/include/qemu/rcu.h > @@ -71,7 +7

Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation

2015-09-10 Thread Artyom Tarasenko
On Thu, Sep 10, 2015 at 1:02 PM, Dennis Luehring wrote: > Am 10.09.2015 um 12:37 schrieb Dennis Luehring: >> >> Am 10.09.2015 um 11:54 schrieb Artyom Tarasenko: >> > On Thu, Sep 10, 2015 at 11:32 AM, Dennis Luehring >> > wrote: >> >> >Am 10.09.2015 um 09:00 schrieb Artyom Tarasenko: >> >>> >>

[Qemu-devel] [PATCH V3 0/2] Move sdhci.h to include/hw/sd

2015-09-10 Thread Sai Pavan Boddu
Move sdhci.h splitting it into common and public. Create a new area for sd in include/hw/. Correct paths of sd.h in #include Sai Pavan Boddu (2): hw/sd : move sd.h to include/hw/sd/ sdhci: Split sdhci.h for public and internal device usage hw/sd/milkymist-memcard.c | 2 +- hw/sd/oma

[Qemu-devel] [PATCH V3 2/2] sdhci: Split sdhci.h for public and internal device usage

2015-09-10 Thread Sai Pavan Boddu
Split sdhci.h into sdhci-common.h and sdhci.h separating common register declarations and object declarations. And move sdhci.h to include/hw/sd/. Signed-off-by: Sai Pavan Boddu --- Changes for V2: Create new area in includes for sd. And move sdhci.h to same. Changes for V3: Split the hea

[Qemu-devel] [PATCH V3 1/2] hw/sd : move sd.h to include/hw/sd/

2015-09-10 Thread Sai Pavan Boddu
Create new folder in includes for sd headers. Signed-off-by: Sai Pavan Boddu --- Changes for V3: None. --- hw/sd/milkymist-memcard.c | 2 +- hw/sd/omap_mmc.c | 2 +- hw/sd/pl181.c | 2 +- hw/sd/pxa2xx_mmci.c | 2 +- hw/sd/sd.c| 2 +- hw/sd/sdhci.h

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > On Thu, Sep 10, 2015 at 11:29:18AM +0100, Stefano Stabellini wrote: > > CC Michael > > > > On Thu, 10 Sep 2015, Stefano Stabellini wrote: > > > On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > > > > xen-host-pci-device.c is only compiled if CONFIG_XEN_P

[Qemu-devel] [PATCH] virtio: right size for virtio_queue_get_avail_size

2015-09-10 Thread Pierre Morel
Being working on dataplane I notice something strange: virtio_queue_get_avail_size() used a 64bit size index for the calculation of the available ring size. It is quite strange but it did work with the old calculation of the avail ring, at most with performance penalty, and I wonder where I misse

Re: [Qemu-devel] [PATCH 4/5] disk_deadlines: add control of requests time expiration

2015-09-10 Thread Kevin Wolf
Am 10.09.2015 um 12:27 hat Stefan Hajnoczi geschrieben: > On Tue, Sep 08, 2015 at 04:48:24PM +0200, Kevin Wolf wrote: > > Am 08.09.2015 um 16:23 hat Denis V. Lunev geschrieben: > > > On 09/08/2015 04:05 PM, Kevin Wolf wrote: > > > >Am 08.09.2015 um 13:27 hat Denis V. Lunev geschrieben: > > > >>inte

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Alexander Graf
On 10.09.15 12:04, Laszlo Ersek wrote: > On 09/10/15 08:19, Alexander Graf wrote: >> >> >>> Am 10.09.2015 um 07:32 schrieb Jordan Justen : > >>> Laszlo's email raised the GPL question, but I was not sure what the >>> EDK II community would accept with regards to GPL. Thus ... I asked. I >>> gues

Re: [Qemu-devel] [PATCH 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-09-10 Thread Kevin Wolf
Am 10.09.2015 um 07:42 hat Deepak Shetty geschrieben: > [snip] > > On Wed, Sep 9, 2015 at 10:37 PM, Raghavendra Talur wrote: > > > > From QEMU's perspective, it would be better to use separate fields > > (that have type information) than to encode everything in an opaque >

[Qemu-devel] [PATCH v2] virtio: ring sizes vs. reset

2015-09-10 Thread Cornelia Huck
We allow guests to change the size of the virtqueue rings by supplying a number of buffers that is different from the number of buffers the device was initialized with. Current code has some problems, however, since reset does not reset the ringsizes to the default values (as this is not saved anyw

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Wed, Sep 09, 2015 at 05:41:59PM -0700, Jordan Justen wrote: > > On 2015-09-09 16:05:20, Andrew Fish wrote: > > > > > > > On Sep 9, 2015, at 3:24 PM, Jordan Justen > > > > wrot> > > FWIW, I don't mind if the consensus is that GplDriverPkg mus

Re: [Qemu-devel] [RFC 10/38] translate-all: remove obsolete comment about l1_map

2015-09-10 Thread Alex Bennée
Emilio G. Cota writes: > l1_map is based on physical addresses in full-system mode, as pointed > out in an earlier comment. Said comment also mentions that virtual > addresses are only used in l1_map in user-only mode. > > Signed-off-by: Emilio G. Cota > --- > translate-all.c | 3 +-- > 1 file

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 12:26:21PM +0100, Stefano Stabellini wrote: > On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > > On Thu, Sep 10, 2015 at 11:29:18AM +0100, Stefano Stabellini wrote: > > > CC Michael > > > > > > On Thu, 10 Sep 2015, Stefano Stabellini wrote: > > > > On Thu, 10 Sep 2015, Chen

Re: [Qemu-devel] [PATCH] vmdk: Fix next_cluster_sector for compressed write

2015-09-10 Thread Kevin Wolf
Am 10.09.2015 um 10:58 hat Fam Zheng geschrieben: > On Thu, 09/10 11:48, Radoslav Gerganov wrote: > > On 10.09.2015 11:15, Fam Zheng wrote: > > > On Thu, 09/10 10:53, Radoslav Gerganov wrote: > > >> When the VMDK is streamOptimized (or compressed), the > > >> next_cluster_sector must not be increme

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > On Thu, Sep 10, 2015 at 12:26:21PM +0100, Stefano Stabellini wrote: > > On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > > > On Thu, Sep 10, 2015 at 11:29:18AM +0100, Stefano Stabellini wrote: > > > > CC Michael > > > > > > > > On Thu, 10 Sep 2015,

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] spapr: Add support for hwrng when available

2015-09-10 Thread Thomas Huth
On 10/09/15 12:40, David Gibson wrote: > On Thu, Sep 10, 2015 at 09:33:21AM +0200, Thomas Huth wrote: >> On 09/09/15 23:10, Thomas Huth wrote: >>> On 08/09/15 07:15, David Gibson wrote: >> ... At this point rather than just implementing them as discrete machine options, I suspect it will

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] spapr: Add support for hwrng when available

2015-09-10 Thread Greg Kurz
On Wed, 9 Sep 2015 10:54:20 +1000 Sam Bobroff wrote: > On Tue, Sep 08, 2015 at 07:38:12AM +0200, Thomas Huth wrote: > > On 08/09/15 07:03, Sam Bobroff wrote: > > > On Tue, Sep 01, 2015 at 12:53:26PM +0200, Thomas Huth wrote: > > >> On 01/09/15 02:38, David Gibson wrote: > > >>> On Mon, Aug 31, 20

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 01:00:35PM +0100, Stefano Stabellini wrote: > On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > > On Thu, Sep 10, 2015 at 12:26:21PM +0100, Stefano Stabellini wrote: > > > On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > > > > On Thu, Sep 10, 2015 at 11:29:18AM +0100, Stefano

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] spapr: Add support for hwrng when available

2015-09-10 Thread Alexander Graf
> Am 10.09.2015 um 14:03 schrieb Thomas Huth : > >> On 10/09/15 12:40, David Gibson wrote: >>> On Thu, Sep 10, 2015 at 09:33:21AM +0200, Thomas Huth wrote: On 09/09/15 23:10, Thomas Huth wrote: On 08/09/15 07:15, David Gibson wrote: >>> ... > At this point rather than just implemen

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Andrew Fish
> On Sep 10, 2015, at 4:40 AM, Alexander Graf wrote: > > > > On 10.09.15 12:04, Laszlo Ersek wrote: >> On 09/10/15 08:19, Alexander Graf wrote: >>> >>> Am 10.09.2015 um 07:32 schrieb Jordan Justen : >> Laszlo's email raised the GPL question, but I was not sure what the EDK II

Re: [Qemu-devel] [PATCH 19/23] userfaultfd: activate syscall

2015-09-10 Thread Bharata B Rao
(cc trimmed since this looks like an issue that is contained within QEMU) On Tue, Sep 08, 2015 at 03:13:56PM +0100, Dr. David Alan Gilbert wrote: > * Bharata B Rao (bhar...@linux.vnet.ibm.com) wrote: > > On Tue, Sep 08, 2015 at 01:46:52PM +0100, Dr. David Alan Gilbert wrote: > > > * Bharata B Rao

Re: [Qemu-devel] [PATCH] linux-user/main.c: Always set QEMU_LD_PREFIX when interp_prefix is changed

2015-09-10 Thread Peter Maydell
On 10 September 2015 at 10:32, Chen Gang wrote: > From: peter.mayd...@linaro.org >> Date: Thu, 10 Sep 2015 10:02:27 +0100 >> >> On 10 September 2015 at 06:43, wrote: >>> From: Chen Gang >>> >>> If qemu sets interp_prfix via command line '-L' instead of environments >>> variable QEMU_LD_PREFIX, i

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Sharma Bhupesh
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jordan Justen > Sent: Thursday, September 10, 2015 11:03 AM > On 2015-09-09 20:26:54, Andrew Fish wrote: > > > On Sep 9, 2015, at 5:41 PM, Jordan Justen > wrote: > > > On 2015-09-09 16:05:20, Andrew Fish wrote: > > >> So yo

[Qemu-devel] [PATCH 0/2] PCI-e device multi-function hot-add support

2015-09-10 Thread Cao jin
Support PCI-e device hot-add multi-function via device_add, just ensure add the function 0 is added last. While allow user to roll back in the middle via device_del, in case user regret. Cao jin (2): PCI-e device multi-function hot-add support PCI-e device multi-function hot-add support hw/p

[Qemu-devel] [PATCH 2/2] PCI-e device multi-function hot-add support

2015-09-10 Thread Cao jin
In case user regret when hot-add multi-function, we should roll back, device_del the function added but still not worked. Signed-off-by: Cao jin --- hw/pci/pcie.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index

[Qemu-devel] [PATCH 1/2] PCI-e device multi-function hot-add support

2015-09-10 Thread Cao jin
Enable PCI-e device multifunction hot, just ensure the function 0 added last, then driver will got the notification to scan all the function in the slot. Signed-off-by: Cao jin --- hw/pci/pcie.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/pci/pc

Re: [Qemu-devel] [PULL 0/7] virtio,pc,acpi fixes, cleanups

2015-09-10 Thread Peter Maydell
On 10 September 2015 at 10:17, Michael S. Tsirkin wrote: > The following changes since commit fc04a730b7e60f4a62d6260d4eb9c537d1d3643f: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20150908' into staging (2015-09-08 > 18:02:36 +0100) > > are available in the git re

Re: [Qemu-devel] [RFC v4 1/9] exec.c: Add new exclusive bitmap to ram_list

2015-09-10 Thread alvise rigo
Hi Paolo, A brief update on this. I have a first implementation of the idea you proposed, though it's not working really well. The failing rate of SCs for some reason is very high. Instead of trying to fix it, I came up with this alternative design: we still use 8 bits per page and we group the sm

Re: [Qemu-devel] [PATCH 2/9] sdl2: quick & dirty flicker workaround

2015-09-10 Thread Marc-André Lureau
On Wed, Sep 9, 2015 at 1:20 PM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/sdl2-2d.c | 13 + > 1 file changed, 13 insertions(+) > Reviewed-by: Marc-André Lureau > diff --git a/ui/sdl2-2d.c b/ui/sdl2-2d.c > index d0b340f..191ee3b 100644 > --- a/ui/sdl2-2d.c > ++

Re: [Qemu-devel] [PATCH 3/9] ui/console: add opengl context and scanout support interfaces.

2015-09-10 Thread Marc-André Lureau
On Wed, Sep 9, 2015 at 1:20 PM, Gerd Hoffmann wrote: > Add callbacks for opengl context management and scanout texture > configuration to DisplayChangeListenerOps. > > Signed-off-by: Gerd Hoffmann > --- > include/ui/console.h | 36 > ui/console.c | 67 >

Re: [Qemu-devel] [RFC 11/38] qemu-thread: handle spurious futex_wait wakeups

2015-09-10 Thread Alex Bennée
Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota > --- > util/qemu-thread-posix.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c > index 04dae0f..3760e27 100644 > --- a/util/qemu-thread-posix.c > ++

Re: [Qemu-devel] [PATCH 1/9] shaders: initialize vertexes once

2015-09-10 Thread Gerd Hoffmann
> > +glBindBuffer (GL_ARRAY_BUFFER, 0); > > +glBindVertexArray (0); > > +glDeleteBuffers (1, &buffer); > > + > > extra space before ( Fixed. > Is the unbinding necessary? Unbinding? Do you mam the DeleteBuffers? cheers, Gerd

Re: [Qemu-devel] [PATCH 4/9] virtio-gpu: update headers for virgl/3d

2015-09-10 Thread Marc-André Lureau
On Wed, Sep 9, 2015 at 1:20 PM, Gerd Hoffmann wrote: > Sync with linux kernel headers with virgl/3d patches applied. > > Signed-off-by: Gerd Hoffmann > --- > include/standard-headers/linux/virtio_gpu.h | 112 > +++- > 1 file changed, 111 insertions(+), 1 deletion(-) > >

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Alexander Graf
> Am 10.09.2015 um 14:17 schrieb Andrew Fish : > > >> On Sep 10, 2015, at 4:40 AM, Alexander Graf wrote: >> >> >> >>> On 10.09.15 12:04, Laszlo Ersek wrote: On 09/10/15 08:19, Alexander Graf wrote: > Am 10.09.2015 um 07:32 schrieb Jordan Justen : >>> > Laszlo's ema

[Qemu-devel] [PULL 6/7] error: Revamp interface documentation

2015-09-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- include/qapi/error.h | 177 --- 1 file changed, 127 insertions(+), 50 deletions(-) diff --git a/include/qapi/error.h b/include/qapi/error.h index 8c3a7dd..358a9d3 100644 --- a/include/qa

[Qemu-devel] [PULL 5/7] error: error_set_errno() is unused, drop

2015-09-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- include/qapi/error.h | 7 ++- util/error.c | 5 ++--- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/include/qapi/error.h b/include/qapi/error.h index 692e013..8c3a7dd 100644 --- a/include/qapi/error.h +++ b

[Qemu-devel] [PATCH v3 0/4] Add 'blockdev-snapshot' command

2015-09-10 Thread Alberto Garcia
Hi, here's version 3 of the patchset that adds the 'blockdev-snapshot' QMP command. This one has a couple of important fixes plus some of the corrections suggested by Eric. The most controversial change, I believe, is the addition of the 'ignore-backing' field to BlockdevOptionsGenericCOWFormat.

[Qemu-devel] [PATCH v3 1/4] block: rename BlockdevSnapshot to BlockdevSnapshotSync

2015-09-10 Thread Alberto Garcia
We will introduce the 'blockdev-snapshot' command that will require its own struct for the parameters, so we need to rename this one in order to avoid name clashes. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- blockdev.c | 2 +- qapi-schema.json | 2 +- qapi/block-cor

[Qemu-devel] [PULL 4/7] qga/vss-win32: Document the DLL requires non-null errp

2015-09-10 Thread Markus Armbruster
requester.cpp uses this pattern to receive an error and pass it on to the caller (err_is_set() macro peeled off for clarity): ... code that may set errset->errp ... if (errset->errp && *errset->errp) { ... handle error ... } This breaks when errset->errp is null. As far as I

[Qemu-devel] [PULL 0/7] error: On abort, report where the error was created

2015-09-10 Thread Markus Armbruster
The following changes since commit fc04a730b7e60f4a62d6260d4eb9c537d1d3643f: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150908' into staging (2015-09-08 18:02:36 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-error-2015-0

Re: [Qemu-devel] [PATCH 1/9] shaders: initialize vertexes once

2015-09-10 Thread Marc-André Lureau
Hi On Wed, Sep 9, 2015 at 1:20 PM, Gerd Hoffmann wrote: > Create a buffer for the vertex data and place vertexes > there at initialization time. Then just use the buffer > for each texture blit. > > Signed-off-by: Gerd Hoffmann > --- > include/ui/shader.h | 4 +++- > ui/console-gl.c | 7

[Qemu-devel] [PULL 2/7] error: Make error_setg() a function

2015-09-10 Thread Markus Armbruster
Saves a tiny amount of code at every call site. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- include/qapi/error.h | 4 ++-- util/error.c | 9 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/include/qapi/error.h b/include/qapi/error.h index f44c4

[Qemu-devel] [PATCH v3 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-10 Thread Alberto Garcia
One of the limitations of the 'blockdev-snapshot-sync' command is that it does not allow passing BlockdevOptions to the newly created snapshots, so they are always opened using the default values. Extending the command to allow passing options is not a practical solution because there is overlap b

[Qemu-devel] [PULL 3/7] qga: Clean up unnecessarily dirty casts

2015-09-10 Thread Markus Armbruster
qga_vss_fsfreeze() casts error_set_win32() from void (*)(Error **, int, ErrorClass, const char *, ...) to void (*)(void **, int, int, const char *, ...) The result is later called. Since the two types are not compatible, the call is undefined behavior. It works in practice anyway. Ho

[Qemu-devel] [PULL 7/7] error: On abort, report where the error was created

2015-09-10 Thread Markus Armbruster
This is particularly useful when we abort in error_propagate(), because there the stack backtrace doesn't lead to where the error was created. Looks like this: Unexpected error in parse_block_error_action() at .../qemu/blockdev.c:322: qemu-system-x86_64: -drive if=none,werror=foo: 'foo' i

[Qemu-devel] [PULL 1/7] error: De-duplicate code creating Error objects

2015-09-10 Thread Markus Armbruster
Duplicated when commit 680d16d added error_set_errno(), and again when commit 20840d4 added error_set_win32(). Make the original copy in error_set() reusable by factoring out error_setv(), then rewrite error_set_errno() and error_set_win32() on top of it. Signed-off-by: Markus Armbruster Reviewe

Re: [Qemu-devel] [PATCH 1/9] shaders: initialize vertexes once

2015-09-10 Thread Marc-André Lureau
Hi On Thu, Sep 10, 2015 at 3:22 PM, Gerd Hoffmann wrote: >> > +glBindBuffer (GL_ARRAY_BUFFER, 0); >> > +glBindVertexArray (0); >> > +glDeleteBuffers (1, &buffer); >> > + >> >> extra space before ( > > Fixed. > >> Is the unbinding necessary? > > Unbinding? Do you mam the DeleteBuffers

[Qemu-devel] [PATCH v3 2/4] block: Add 'ignore-backing' field to BlockdevOptionsGenericCOWFormat

2015-09-10 Thread Alberto Garcia
If set to true, the image will be opened with the BDRV_O_NO_BACKING flag. This is useful for creating snapshots using images opened with blockdev-add, since they are not supposed to have a backing image before the operation. Signed-off-by: Alberto Garcia --- block.c | 5 + qapi/

[Qemu-devel] [PATCH v3 4/4] block: add tests for the 'blockdev-snapshot' command

2015-09-10 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- tests/qemu-iotests/085 | 97 +++--- tests/qemu-iotests/085.out | 34 +++- 2 files changed, 123 insertions(+), 8 deletions(-) diff --git a/tests/qemu-iotests/085 b/tests/qemu-iotests/085 index 56cd6f8..2b0f8

Re: [Qemu-devel] [RFC 13/38] cputlb: add physical address to CPUTLBEntry

2015-09-10 Thread Alex Bennée
Emilio G. Cota writes: > Having the physical address in the TLB entry will allow us > to portably obtain the physical address of a memory access, > which will prove useful when implementing a scalable emulation > of atomic instructions. > > Signed-off-by: Emilio G. Cota > --- > cputlb.c

Re: [Qemu-devel] [PATCH 18/20] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-10 Thread Peter Maydell
On 2 September 2015 at 06:52, Richard Henderson wrote: > We can now restore state without retranslation. > > Signed-off-by: Richard Henderson > --- > include/exec/exec-all.h | 1 + > tcg/tcg.c | 11 - > tcg/tcg.h | 3 +- > translate-all.c | 129 > +++

Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation

2015-09-10 Thread Peter Maydell
On 8 September 2015 at 19:56, Peter Maydell wrote: > Looks sensible to me. For patches 1 2 4..16 20 > Reviewed-by: Peter Maydell > > Patches 3, 17, 19 I've sent "minor nit, otherwise r-by" followups to. > > Patch 18 is of course the meat of this series. It doesn't look > obviously wrong but I wan

[Qemu-devel] [PATCH RFC 0/3] add mitigation against buffer overflows

2015-09-10 Thread Michael S. Tsirkin
Multiple places in QEMU map guest memory, then access it directly. Unfortunately since we are using C, there's always a chance that we'll miss a bounds check when we do this. This has a potential to corrupt QEMU memory. As a mitigation strategy against such exploits, allocate a page in HVA space o

[Qemu-devel] [PATCH RFC 3/3] exec: allocate PROT_NONE pages on top of RAM

2015-09-10 Thread Michael S. Tsirkin
This inserts a read and write protected page between RAM and QEMU memory, for file-backend RAM. This makes it harder to exploit QEMU bugs resulting from buffer overflows in devices using variants of cpu_physical_memory_map, dma_memory_map etc. Signed-off-by: Michael S. Tsirkin --- This patch is

[Qemu-devel] [PATCH RFC 1/3] oslib: rework anonimous RAM allocation

2015-09-10 Thread Michael S. Tsirkin
At the moment we first allocate RAM, sometimes more than necessary for alignment reasons. We then free the extra RAM. Rework this to avoid the temporary allocation: reserve the range by mapping it with PROT_NONE, then use just the necessary range with MAP_FIXED. Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCH RFC 2/3] oslib: allocate PROT_NONE pages on top of RAM

2015-09-10 Thread Michael S. Tsirkin
This inserts a read and write protected page between RAM and QEMU memory. This makes it harder to exploit QEMU bugs resulting from buffer overflows in devices using variants of cpu_physical_memory_map, dma_memory_map etc. Signed-off-by: Michael S. Tsirkin --- util/oslib-posix.c | 8 1 f

Re: [Qemu-devel] [RFC 15/38] radix-tree: add generic lockless radix tree module

2015-09-10 Thread Alex Bennée
Emilio G. Cota writes: > This will be used by atomic instruction emulation code. If we are adding utility functions into the code base like this (which I can see being useful) we should at least add some documentation with example calling conventions to docs/ Have you any performance numbers c

Re: [Qemu-devel] [PATCH v4 2/4] iotests: Add dependency info to groups list

2015-09-10 Thread John Snow
On 09/10/2015 05:11 AM, Fam Zheng wrote: > On Wed, 09/09 12:35, John Snow wrote: >> Ping -- Fam? > > Well, it's not a particularly interesting patch to review, but since you > caught > me ... > Sorry, you did an earlier version :) --js

Re: [Qemu-devel] [PATCH] Add a few argument filters to the seccomp sandbox

2015-09-10 Thread Daniel P. Berrange
(Adding Paul Moore to CC since he's done a lot of work on syscall whitelisting in QEMU) On Wed, Sep 09, 2015 at 09:55:33PM -0400, namn...@safe-mail.net wrote: > This patch here adds argument filtering for three syscalls: > madvise(), shmget(), and shmctl(). > > The madvise() flags may need a few

Re: [Qemu-devel] qemu-devel digest question

2015-09-10 Thread Steve Ellcey
On Thu, 2015-09-10 at 08:39 +0200, Markus Armbruster wrote: > >> I am on various GCC, gdb, and binutils lists and I would say that most > >> of them send out 4 to 10 digests a day. qemu-devel seems to send out > >> a hundred or so. Any chance of becoming more digest-y? > > How many messages do

Re: [Qemu-devel] [PATCH 1/9] shaders: initialize vertexes once

2015-09-10 Thread Gerd Hoffmann
On Do, 2015-09-10 at 15:42 +0200, Marc-André Lureau wrote: > Hi > > On Thu, Sep 10, 2015 at 3:22 PM, Gerd Hoffmann wrote: > >> > +glBindBuffer (GL_ARRAY_BUFFER, 0); > >> > +glBindVertexArray (0); > >> > +glDeleteBuffers (1, &buffer); > >> > + > >> > >> extra space before ( > > > > Fix

Re: [Qemu-devel] [ipxe-devel] EFI_PXE_BASE_CODE_PROTOCOL

2015-09-10 Thread Michael Brown
On 07/09/15 15:58, Gerd Hoffmann wrote: This is generated by a script which does also copy the kernels to the tftproot, there are more simliar entries for more RHEL versions but this should be enough to get the idea ... First entry actually works. Second does not, but I'm hoping some day it doe

Re: [Qemu-devel] [PATCH] linux-user/main.c: Always set QEMU_LD_PREFIX when interp_prefix is changed

2015-09-10 Thread Chen Gang
On 9/10/15 20:35, Peter Maydell wrote: > On 10 September 2015 at 10:32, Chen Gang wrote: >> >> For me, when users type a command line under Linux shell, they always >> assume all related executions will know about their commands, they need >> not set the environments again (at least, in one proces

[Qemu-devel] [Bug 1494350] [NEW] QEMU: causes vCPU steal time overflow on live migration

2015-09-10 Thread c sights
Public bug reported: I'm pasting in text from Debian Bug 785557 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=785557 b/c I couldn't find this issue reported. It is present in QEMU 2.3, but I haven't tested later versions. Perhaps someone else will find this bug and confirm for later versions

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Kevin Davis
> > > On Sep 10, 2015, at 4:40 AM, Alexander Graf wrote: > > > > > > > > On 10.09.15 12:04, Laszlo Ersek wrote: > >> On 09/10/15 08:19, Alexander Graf wrote: > >>> > >>> > Am 10.09.2015 um 07:32 schrieb Jordan Justen > : > >> > Laszlo's email raised the GPL question, but I was not sure

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Paolo Bonzini
On 10/09/2015 16:24, Kevin Davis wrote: > Further leading me to guess that any actual use of those > implementations could lead to you actually needing to hire a real > attorney and not one that you find on YouTube. The good thing is that attorneys have already figured it out. IBM figured out a

[Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only

2015-09-10 Thread Alberto Garcia
The QEMU code is not internationalized and assumes that it runs under the C locale, but if we use the GTK+ UI we'll end up importing the locale settings from the environment. This can break things, such as the JSON generator and iotest 120 in locales that use a decimal comma. We do however have tr

Re: [Qemu-devel] [ipxe-devel] EFI_PXE_BASE_CODE_PROTOCOL

2015-09-10 Thread Gerd Hoffmann
Hi, > > The file is simply placed as "grub.cfg" in tftproot, next to grubx64.efi > > Thanks. From my experiments, it seems that GRUB is using the hardcoded > path /efi/boot/grub.cfg to locate the configuration file, regardless of > where grub.efi was loaded from. Hmm, probably depends on ho

Re: [Qemu-devel] [PATCH] linux-user/main.c: Always set QEMU_LD_PREFIX when interp_prefix is changed

2015-09-10 Thread Peter Maydell
On 10 September 2015 at 16:15, Chen Gang wrote: > Yes, we have to use binfmt_misc to let execve() run correctly. After > let execve() run correctly, I am analyzing another issue when let qemu > run wine (it is a pending issue, I guess, it is related with mmu). > > At present, I often change the in

Re: [Qemu-devel] [PATCH v14 00/33] TileGX basic instructions

2015-09-10 Thread Chen Gang
Hello all: It looks tilegx still outside of qemu master tree. I guess, I have to still use my own implementation to continue analyzing gcc testsuite (or I am not quite sure whether I can finish analyzing within this month). Welcome any ideas, suggestions and completions. Thanks. On 8/30/15 12:

Re: [Qemu-devel] [RFC 18/38] tcg: add fences

2015-09-10 Thread Alex Bennée
Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota > --- > tcg/tcg-op.c | 5 + > tcg/tcg-op.h | 18 ++ > tcg/tcg-opc.h | 5 + > 3 files changed, 28 insertions(+) > > diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c > index 45098c3..6d5b1df 100644 > --- a/tcg/tcg-op.c >

Re: [Qemu-devel] [ipxe-devel] EFI_PXE_BASE_CODE_PROTOCOL

2015-09-10 Thread Michael Brown
On 10/09/15 16:20, Gerd Hoffmann wrote: Thanks. From my experiments, it seems that GRUB is using the hardcoded path /efi/boot/grub.cfg to locate the configuration file, regardless of where grub.efi was loaded from. Hmm, probably depends on how you are building it. There are also tools like gr

Re: [Qemu-devel] [PATCH 1/2] PCI-e device multi-function hot-add support

2015-09-10 Thread Alex Williamson
On Thu, 2015-09-10 at 20:12 +0800, Cao jin wrote: > Enable PCI-e device multifunction hot, just ensure the function 0 > added last, then driver will got the notification to scan all the > function in the slot. > > Signed-off-by: Cao jin > --- > hw/pci/pcie.c | 22 +- > 1 file

Re: [Qemu-devel] [PATCH 2/2] PCI-e device multi-function hot-add support

2015-09-10 Thread Alex Williamson
On Thu, 2015-09-10 at 20:12 +0800, Cao jin wrote: > In case user regret when hot-add multi-function, we should roll back, > device_del the function added but still not worked. > > Signed-off-by: Cao jin > --- > hw/pci/pcie.c | 28 +++- > 1 file changed, 23 insertions(+),

[Qemu-devel] [PATCH 3/4] hmp-commands.hx: fix end of table info

2015-09-10 Thread Denis V. Lunev
From: Pavel Butsykin The table info(information about the system state) closes earlier and some of its elements are outside(trace-events, rocker, etc). This can be confusing and lead to additional bugs. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Peter Ma

[Qemu-devel] [PATCH 4/4] monitor: added generation of documentation for hmp-commands-info.hx

2015-09-10 Thread Denis V. Lunev
From: Pavel Butsykin It will be easier if you need to add info-commands to edit only hmp-commands-info.hx, before this had to edit monitor.c and hmp-commands.hx. >From the build point of view all documentation is saved into qemu-monitor-info.texi which from now on is used for all user documentat

[Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c

2015-09-10 Thread Denis V. Lunev
From: Pavel Butsykin Move target-specific code out of /monitor.c to /target-*/monitor.c, this will avoid code cluttering and using random ifdeffery. The solution is quite simple, but solves the issue of the separation of target-specific code from monitor. Signed-off-by: Pavel Butsykin Signed-o

[Qemu-devel] [PATCH v4 0/4] Move target- and device specific code from monitor

2015-09-10 Thread Denis V. Lunev
The monivation of this set is simple. Recently we have proposed patch to monitor.c with specific x86 APIC HMP commands. The patchset was denied with the main motivation "No more arch specific code in monitor.c" This patchset is the first step to move arch specific code from monitor.c targets. So,

[Qemu-devel] [PATCH 1/4] hmp-commands-info: move info_cmds content out of monitor.c

2015-09-10 Thread Denis V. Lunev
From: Pavel Butsykin For moving target- and device-specific code from monitor.c, to beginning we move info_cmds content to hmp-commands-info.hx Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Peter Maydell --- Makefile.target | 5 +- hmp-commands-in

Re: [Qemu-devel] [PATCH] linux-user/main.c: Always set QEMU_LD_PREFIX when interp_prefix is changed

2015-09-10 Thread Chen Gang
On 9/10/15 23:24, Peter Maydell wrote: > On 10 September 2015 at 16:15, Chen Gang wrote: >> Yes, we have to use binfmt_misc to let execve() run correctly. After >> let execve() run correctly, I am analyzing another issue when let qemu >> run wine (it is a pending issue, I guess, it is related with

Re: [Qemu-devel] [RFC 19/38] tcg: add tcg_gen_smp_rmb()

2015-09-10 Thread Alex Bennée
Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota > --- > tcg/tcg-op.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h > index 52482c0..3ec9f13 100644 > --- a/tcg/tcg-op.h > +++ b/tcg/tcg-op.h > @@ -716,6 +716,16 @@ static inline void tcg_g

Re: [Qemu-devel] [PULL 0/7] error: On abort, report where the error was created

2015-09-10 Thread Peter Maydell
On 10 September 2015 at 14:32, Markus Armbruster wrote: > The following changes since commit fc04a730b7e60f4a62d6260d4eb9c537d1d3643f: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20150908' into staging (2015-09-08 > 18:02:36 +0100) > > are available in the git rep

Re: [Qemu-devel] [PATCH] qemu-thread: add a fast path to the Win32 QemuEvent

2015-09-10 Thread Paolo Bonzini
On 12/08/2015 15:38, Paolo Bonzini wrote: > QemuEvents are used heavily by call_rcu. We do not want them to be slow, > but the current implementation does a kernel call on every invocation > of qemu_event_* and won't cut it. > > So, wrap a Win32 manual-reset event with a fast userspace path. The

Re: [Qemu-devel] [PATCH v4 0/4] Move target- and device specific code from monitor

2015-09-10 Thread Peter Crosthwaite
On Thu, Sep 10, 2015 at 8:38 AM, Denis V. Lunev wrote: > The monivation of this set is simple. Recently we have proposed patch > to monitor.c with specific x86 APIC HMP commands. The patchset was denied > with the main motivation "No more arch specific code in monitor.c" > This patchset is the fir

[Qemu-devel] [PATCH v4] hmp: Allow for error message hints on HMP

2015-09-10 Thread Eric Blake
Commits 7216ae3d and d2828429 disabled some error message hints, all because a change to use modern error reporting meant that the hint would be output prior to the actual error. Fix this by making hints a first-class member of Error. For example, we are now back to the pleasant: $ qemu-system-

Re: [Qemu-devel] [RFC v4 1/9] exec.c: Add new exclusive bitmap to ram_list

2015-09-10 Thread Alex Bennée
alvise rigo writes: > Hi Paolo, > > A brief update on this. I have a first implementation of the idea you > proposed, though it's not working really well. The failing rate of SCs > for some reason is very high. Due to high memory contention on the EXCL page? > Instead of trying to fix it, I ca

Re: [Qemu-devel] [PULL 7/7] error: On abort, report where the error was created

2015-09-10 Thread Eric Blake
On 09/10/2015 07:32 AM, Markus Armbruster wrote: > This is particularly useful when we abort in error_propagate(), > because there the stack backtrace doesn't lead to where the error was > created. Looks like this: > > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > Acked-by: La

Re: [Qemu-devel] [PATCH v4 0/4] Move target- and device specific code from monitor

2015-09-10 Thread Paolo Bonzini
On 10/09/2015 18:18, Peter Crosthwaite wrote: >> > Signed-off-by: Pavel Butsykin >> > Signed-off-by: Denis V. Lunev >> > CC: Paolo Bonzini >> > CC: Peter Maydell >> > > I need this! > > This is a piece of the puzzle for multi arch. I'll add it to my review > queue, but can I take a CC on thi

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add Mount image file menu item

2015-09-10 Thread Programmingkid
On Sep 10, 2015, at 3:21 AM, Markus Armbruster wrote: > Programmingkid writes: > >> Does this look about right? >> >>QDict *qdict; >>Error *errp; >>QObject **ret_data; >>static int counter; >>char *idString, *fileName; >> >> // The file variable is objective-c, left t

Re: [Qemu-devel] [RFC v4 1/9] exec.c: Add new exclusive bitmap to ram_list

2015-09-10 Thread Paolo Bonzini
On 10/09/2015 15:04, alvise rigo wrote: > Hi Paolo, > > A brief update on this. I have a first implementation of the idea you > proposed, though it's not working really well. The failing rate of SCs > for some reason is very high. > Instead of trying to fix it, I came up with this alternative de

Re: [Qemu-devel] [PATCH v4 0/4] Move target- and device specific code from monitor

2015-09-10 Thread Denis V. Lunev
On 09/10/2015 07:18 PM, Peter Crosthwaite wrote: On Thu, Sep 10, 2015 at 8:38 AM, Denis V. Lunev wrote: The monivation of this set is simple. Recently we have proposed patch to monitor.c with specific x86 APIC HMP commands. The patchset was denied with the main motivation "No more arch specific

[Qemu-devel] [PATCH 2/1] error: Copy location information in error_copy()

2015-09-10 Thread Eric Blake
Commit 1e9b65bb forgot to propagate source information to copied errors. Signed-off-by: Eric Blake --- I noticed this while rebasing my patch (as in 'why did I not get a merge conflict where I expected one?'); of course we could apply this one first, but swapping the patch order implies even mor

Re: [Qemu-devel] [PULL 7/7] error: On abort, report where the error was created

2015-09-10 Thread Eric Blake
On 09/10/2015 10:21 AM, Eric Blake wrote: > Already in mainline, but I'm wondering... > > >> +++ b/util/error.c >> @@ -18,12 +18,23 @@ struct Error >> { >> char *msg; >> ErrorClass err_class; >> +const char *src, *func; >> +int line; >> }; >> > > Should we also be modifyin

<    1   2   3   4   5   >