Re: [Qemu-devel] [PATCH v2 15/23] target-i386: use memory API to implement SMRAM

2015-06-04 Thread Peter Crosthwaite
On Wed, Jun 3, 2015 at 10:08 AM, Paolo Bonzini wrote: > Remove cpu_smm_register and cpu_smm_update. Instead, each CPU > address space gets an extra region which is an alias of > /machine/smram. This extra region is enabled or disabled > as the CPU enters/exits SMM. > Why is the connectivity fro

[Qemu-devel] Ping: [PATCH] qobject: object_property_add() performance improvement

2015-06-04 Thread Pavel Fedin
Hello Luiz! Have you missed this ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia > -Original Message- > From: qemu-devel-bounces+p.fedin=samsung@nongnu.org [mailto:qemu-devel- > bounces+p.fedin=samsung@nongnu.org] On Behalf Of Pavel Fedin >

Re: [Qemu-devel] [RFC PATCH] qapi for audio backends

2015-06-04 Thread Gerd Hoffmann
Hi, > +## > +# @AudiodevAlsaPerDirectionOptions > +# > +# Options of the alsa backend that are used for both playback and recording. > +# > +# @dev: #optional the name of the alsa device to use. > +# > +# @period_size_usec: #optional the period size in microseconds. Must not be > +#

Re: [Qemu-devel] [PULL v2 0/8] SH4 patches for upstream

2015-06-04 Thread Aurelien Jarno
On 2015-06-02 21:25, Aurelien Jarno wrote: > The following changes since commit f5790c3bc81702c98c7ddadedb274758cff8cbe7: > > Revert "target-alpha: Add vector implementation for CMPBGE" (2015-05-22 > 12:30:13 +0100) > > are available in the git repository at: > > git://git.aurel32.net/qemu.

[Qemu-devel] [PATCH] usb: Use usb_bus_find(-1) instead of usb_enabled() in usb_device_add/usb_device_del

2015-06-04 Thread Lin Ma
Without usb=on machine option, usb_device_add/usb_device_del don't work, Even if there are virtual usb controllers presented. This patch fixes it. Signed-off-by: Lin Ma --- vl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 1d4c089..26fab83 100644 ---

[Qemu-devel] Ping: [PATCH] Extract some reusable vGIC code

2015-06-04 Thread Pavel Fedin
Hello! More than week ago i've done this patch but it seems to be lost. It is a part of my vGICv3 project and i decided to post it separately because vGICv3 code itself waits for Shlomo's patches. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia > -Orig

Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals

2015-06-04 Thread Paolo Bonzini
On 04/06/2015 03:10, Peter Crosthwaite wrote: > Ping! > > Was there an outcome? Andreas will handle the patches, but he's on vacation now. Paolo > On Fri, May 29, 2015 at 11:34 AM, Eduardo Habkost wrote: >> On Tue, May 26, 2015 at 01:49:56PM +0200, Paolo Bonzini wrote: >>> On 26/05/2015 10:3

Re: [Qemu-devel] [PATCH v2 13/23] target-i386: create a separate AddressSpace for each CPU

2015-06-04 Thread Paolo Bonzini
On 03/06/2015 19:58, Peter Crosthwaite wrote: > On Wed, Jun 3, 2015 at 10:08 AM, Paolo Bonzini wrote: >> Different CPUs can be in SMM or not at the same time, thus they >> will see different things where the chipset places SMRAM. >> >> Signed-off-by: Paolo Bonzini >> --- >> target-i386/cpu-qom

Re: [Qemu-devel] Ping: [PATCH] Extract some reusable vGIC code

2015-06-04 Thread Peter Maydell
On 4 June 2015 at 08:56, Pavel Fedin wrote: > Hello! More than week ago i've done this patch but it seems to be lost. It > is a part of > my vGICv3 project and i decided to post it separately because vGICv3 code > itself waits for > Shlomo's patches. Apologies for the delay; GICv3 related patc

Re: [Qemu-devel] [PATCH v2 12/23] vl: run "late" notifiers immediately

2015-06-04 Thread Paolo Bonzini
On 04/06/2015 08:39, Peter Crosthwaite wrote: > On Wed, Jun 3, 2015 at 10:08 AM, Paolo Bonzini wrote: >> If a machine_init_done notifier is added late, as part of a hot-plugged >> device, run it immediately. > > Blank line? Yes, thanks. Paolo >> Signed-off-by: Paolo Bonzini > > Reviewed-by

Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors

2015-06-04 Thread Paolo Bonzini
On 04/06/2015 08:19, Peter Crosthwaite wrote: > On Wed, Jun 3, 2015 at 10:08 AM, Paolo Bonzini wrote: >> This is a required step to implement read_with_attrs and write_with_attrs. >> >> Signed-off-by: Paolo Bonzini >> --- >> hw/block/pflash_cfi01.c | 96 >> ++--

Re: [Qemu-devel] [PATCH v2 15/23] target-i386: use memory API to implement SMRAM

2015-06-04 Thread Paolo Bonzini
On 04/06/2015 09:19, Peter Crosthwaite wrote: > > Remove cpu_smm_register and cpu_smm_update. Instead, each CPU > > address space gets an extra region which is an alias of > > /machine/smram. This extra region is enabled or disabled > > as the CPU enters/exits SMM. > > Why is the connectivity f

Re: [Qemu-devel] Ping: [PATCH] qobject: object_property_add() performance improvement

2015-06-04 Thread Peter Crosthwaite
On Thu, Jun 4, 2015 at 12:35 AM, Pavel Fedin wrote: > Hello Luiz! Have you missed this ? > > Kind regards, > Pavel Fedin > Expert Engineer > Samsung Electronics Research center Russia > > >> -Original Message- >> From: qemu-devel-bounces+p.fedin=samsung@nongnu.org [mailto:qemu-devel-

Re: [Qemu-devel] [PATCH v3 0/3] Bitmap based CPU enumeration

2015-06-04 Thread Paolo Bonzini
On 04/06/2015 07:44, Peter Crosthwaite wrote: > On Wed, Jun 3, 2015 at 8:08 PM, Bharata B Rao > wrote: >> On Thu, May 28, 2015 at 09:59:38PM -0700, Peter Crosthwaite wrote: >>> On Thu, May 28, 2015 at 7:27 PM, Bharata B Rao >>> wrote: All the comments have been addressed and the series has b

Re: [Qemu-devel] [PATCH v3 0/3] Bitmap based CPU enumeration

2015-06-04 Thread Peter Crosthwaite
On Thu, Jun 4, 2015 at 1:09 AM, Paolo Bonzini wrote: > On 04/06/2015 07:44, Peter Crosthwaite wrote: >> On Wed, Jun 3, 2015 at 8:08 PM, Bharata B Rao >> wrote: >>> On Thu, May 28, 2015 at 09:59:38PM -0700, Peter Crosthwaite wrote: On Thu, May 28, 2015 at 7:27 PM, Bharata B Rao wrote: >

Re: [Qemu-devel] [PATCH v3 0/3] Bitmap based CPU enumeration

2015-06-04 Thread Paolo Bonzini
On 04/06/2015 10:39, Peter Crosthwaite wrote: >> > I wouldn't mind separating the "CPU" parts of exec.c and moving them >> > under Andreas and Eduardo's mantainership. In fact, Peter, in your >> > patch to move stuff from cpu-exec.c to cpus.c, perhaps you can use >> > qom/cpu.c instead? Then qo

Re: [Qemu-devel] virtio branch rebased

2015-06-04 Thread Gerd Hoffmann
Hi, > > Current state is here: > > https://www.kraxel.org/cgit/qemu/log/?h=rebase/virtio-wip Branch updated. > comments: > > virtio-pci: add flags to enable/disable legacy/modern > please change so by default modern is off, legacy is on (can be > a patch on top too). There are

Re: [Qemu-devel] virtio branch rebased

2015-06-04 Thread Michael S. Tsirkin
On Thu, Jun 04, 2015 at 11:05:00AM +0200, Gerd Hoffmann wrote: > Hi, > > > > Current state is here: > > > https://www.kraxel.org/cgit/qemu/log/?h=rebase/virtio-wip > > Branch updated. > > > comments: > > > > virtio-pci: add flags to enable/disable legacy/modern > > please change so by d

Re: [Qemu-devel] [PULL 00/21] Monitor patches

2015-06-04 Thread Peter Maydell
On 2 June 2015 at 09:23, Markus Armbruster wrote: > These change the monitor core, shared by HMP (maintained by Luiz) and > QMP (maintained by myself). Luiz reviewed and asked me to take them > through my tree. > > This is v3 with the (reviewed!) one-line amend to PATCH 14 squashed > in, and triv

[Qemu-devel] [PATCH V5] vhost: logs sharing

2015-06-04 Thread Jason Wang
Currently we allocate one vhost log per vhost device. This is sub optimal when: - Guest has several device with vhost as backend - Guest has multiqueue devices In the above cases, we can avoid the memory allocation by sharing a single vhost log among all the vhost devices. This is done through:

Re: [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop

2015-06-04 Thread Jason Wang
On 06/03/2015 09:40 PM, Stefan Hajnoczi wrote: > On Wed, Jun 3, 2015 at 10:42 AM, Jason Wang wrote: >> >> On 06/03/2015 03:56 PM, Thibaut Collet wrote: >>> Hi, >>> >>> thanks for your point, I did not notice the problem of the lost of ARP >>> announce by discarding the message. >>> So I must rew

Re: [Qemu-devel] [RFC] edk2 support for a new QEMU device - PXB (PCI Expander Device)

2015-06-04 Thread Marcel Apfelbaum
On 06/04/2015 02:11 AM, Laszlo Ersek wrote: On 06/03/15 22:34, Marcel Apfelbaum wrote: On 06/03/2015 01:20 PM, Laszlo Ersek wrote: Maybe we can experiment some more; for example we could start by you explaining to me how exactly to probe for a root bus's presence (you mentioned device 0, but

Re: [Qemu-devel] Ping: [PATCH] Extract some reusable vGIC code

2015-06-04 Thread Pavel Fedin
Hi! > I think if I were you I would just include this patch in the same series > as the code it's intended to support. The code it's intended to support waits for GICv3 itself, that's why it's delayed. And this part has no dependencies and could be applied to master. IMHO partial progress is

Re: [Qemu-devel] Ping: [PATCH] Extract some reusable vGIC code

2015-06-04 Thread Peter Maydell
On 4 June 2015 at 10:44, Pavel Fedin wrote: > Hi! > >> I think if I were you I would just include this patch in the same series >> as the code it's intended to support. > > The code it's intended to support waits for GICv3 itself, that's > why it's delayed. And this part has no dependencies and

Re: [Qemu-devel] [Qemu-block] [PATCH v8 03/10] qcow2: Use error_report() in qcow2_amend_options()

2015-06-04 Thread Alberto Garcia
On Wed 03 Jun 2015 10:13:32 PM CEST, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > Reviewed-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] Ping: [PATCH] qobject: object_property_add() performance improvement

2015-06-04 Thread Pavel Fedin
Hello! > >> + void *v = g_malloc0(sizeof(uint32_t)); > >> + > > Can you allocate name_no_array here along with the count in a small > struct to save on some allocs and memcpys? How can i? Here i allocate persistent storage space for the property, which is kept along. And name_no_array

Re: [Qemu-devel] [Qemu-block] [PATCH v8 04/10] qcow2: Use abort() instead of assert(false)

2015-06-04 Thread Alberto Garcia
On Wed 03 Jun 2015 10:13:33 PM CEST, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > Reviewed-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH] configure: append --extra-ldflags to LDFLAGS

2015-06-04 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] Grammar: 'as to'->'as for'

2015-06-04 Thread Michael Tokarev
Applied to -trivial, what a huge patch, thanks! :) /mjt

Re: [Qemu-devel] [PATCH v1 1/1] xilinx_axidma.c: Fix up the stream_running() function

2015-06-04 Thread Michael Tokarev
03.06.2015 10:00, Alistair Francis wrote: > On Wed, May 27, 2015 at 5:37 PM, Alistair Francis > wrote: >> Previously the stream_running() function didn't check >> if the DMA was halted. This caused hangs in recent versions >> of MicroBlaze u-boot. Correct stream_running() to check >> DMASR_HALTED

[Qemu-devel] [PATCH 00/33] virtio 1.0 patch series rebased

2015-06-04 Thread Gerd Hoffmann
Hi, Here comes the virtio 1.0 patch series, rebased to latest master. Patches 1-23 are based on the old branch by cornelia & mst. Patches 24-30 are virtio-pci bits on top of that. Patches 31-33 add virtio-pci support for the virtio-input devices. Light testing only so far, posting early neverth

[Qemu-devel] [PATCH 05/33] virtio: disallow late feature changes for virtio-1

2015-06-04 Thread Gerd Hoffmann
From: Cornelia Huck For virtio-1 devices, the driver must not attempt to set feature bits after it set FEATURES_OK in the device status. Simply reject it in that case. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio.c | 18 +

[Qemu-devel] [PATCH 01/33] virtio: 64bit features fixups.

2015-06-04 Thread Gerd Hoffmann
Commit "019a3ed virtio: make features 64bit wide" missed a few changes, as I've noticed while trying to rebase the virtio-1 branch to latest master. This patch adds them. Signed-off-by: Gerd Hoffmann --- hw/net/virtio-net.c| 2 +- hw/virtio/virtio.c | 2 +- include/hw/virtio/v

[Qemu-devel] [PATCH 03/33] virtio: allow virtio-1 queue layout

2015-06-04 Thread Gerd Hoffmann
From: Cornelia Huck For virtio-1 devices, we allow a more complex queue layout that doesn't require descriptor table and rings on a physically-contigous memory area: add virtio_queue_set_rings() to allow transports to set this up. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Si

[Qemu-devel] [PATCH 08/33] virtio-net: support longer header

2015-06-04 Thread Gerd Hoffmann
From: Cornelia Huck virtio-1 devices always use num_buffers in the header, even if mergeable rx buffers have not been negotiated. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 21 +++-- 1 file changed,

[Qemu-devel] [PATCH 17/33] virtio-pci: add flags to enable/disable legacy/modern

2015-06-04 Thread Gerd Hoffmann
Add VIRTIO_PCI_FLAG_DISABLE_LEGACY and VIRTIO_PCI_FLAG_DISABLE_MODERN for VirtIOPCIProxy->flags. Also add properties for them. They can be used to disable modern (virtio 1.0) or legacy (virtio 0.9) modes. By default only legacy is advertized, modern will be turned on by default once all remainin

[Qemu-devel] [PATCH 09/33] virtio-net: enable virtio 1.0

2015-06-04 Thread Gerd Hoffmann
From: Cornelia Huck virtio-net (non-vhost) now should have everything in place to support virtio 1.0: let's enable the feature bit for it. Note that VIRTIO_F_VERSION_1 is technically a transport feature; once every device is ready for virtio 1.0, we can move setting this feature bit out of the i

[Qemu-devel] [PATCH 07/33] virtio-net: no writeable mac for virtio-1

2015-06-04 Thread Gerd Hoffmann
From: Cornelia Huck Devices operating as virtio 1.0 may not allow writes to the mac address in config space. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/virti

[Qemu-devel] [PATCH 14/33] virtio: generation counter support

2015-06-04 Thread Gerd Hoffmann
From: "Michael S. Tsirkin" Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 2 +- hw/virtio/virtio.c | 1 + include/hw/virtio/virtio.h | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 7bd31d9..c8

[Qemu-devel] [PATCH 22/33] virtio_balloon: header update

2015-06-04 Thread Gerd Hoffmann
From: "Michael S. Tsirkin" add modern header Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio-balloon.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/hw/virtio/virtio-balloon.h b/include/hw/virtio/virtio-balloon.h index 4ab8f54..346a9fd 100644 --- a/include/h

[Qemu-devel] [PATCH 10/33] vhost_net: add version_1 feature

2015-06-04 Thread Gerd Hoffmann
From: "Michael S. Tsirkin" Add VERSION_1 to list of features that we should test at the backend. Signed-off-by: Michael S. Tsirkin --- hw/net/vhost_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index 426b23e..dc48ece 100644 --- a/hw/net/vho

[Qemu-devel] [PATCH 02/33] virtio: endianness checks for virtio 1.0 devices

2015-06-04 Thread Gerd Hoffmann
From: Cornelia Huck Add code that checks for the VERSION_1 feature bit in order to make decisions about the device's endianness. This allows us to support transitional devices. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio

[Qemu-devel] [PATCH 21/33] virtio-pci: correctly set host notifiers for modern bar

2015-06-04 Thread Gerd Hoffmann
From: Jason Wang Currently, during host notifier set. We only add eventfd for legacy bar, this is not correct since: - Non-transitional device does not have legacy bar, so qemu will crash since proxy->bar was not initialized. - Modern device uses modern bar and notify cap to notify the device,

[Qemu-devel] [PATCH 26/33] virtio-pci: add virtio_pci_modern_region_map()

2015-06-04 Thread Gerd Hoffmann
Add function to map modern virtio regions. Add offset to VirtIOPCIRegion. Signed-off-by: Gerd Hoffmann --- hw/virtio/virtio-pci.c | 25 +++-- hw/virtio/virtio-pci.h | 1 + 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virt

[Qemu-devel] [PATCH 20/33] virtio-pci: make modern bar 64bit + prefetchable

2015-06-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 0f3eb34..558cb53 100644 --- a/hw/virtio/virtio-p

[Qemu-devel] [PATCH 15/33] virtio: add modern config accessors

2015-06-04 Thread Gerd Hoffmann
From: "Michael S. Tsirkin" virtio 1.0 defines config space as LE, as opposed to pre-1.0 which was native endian. Add API for transports to execute word/dword accesses in little endian format - will be useful for mmio and pci (byte access is also wrapped, for completeness). For simplicity, we st

[Qemu-devel] [PATCH 16/33] virtio-pci: switch to modern accessors for 1.0

2015-06-04 Thread Gerd Hoffmann
From: "Michael S. Tsirkin" virtio 1.0 config space is in LE format for all devices, use modern wrappers when accessed through the 1.0 BAR. Reported-by: Rusty Russell Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH 18/33] virtio-pci: make QEMU_VIRTIO_PCI_QUEUE_MEM_MULT smaller

2015-06-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 2182b41..c86a61d 100644 --- a/hw/virtio/virtio-pci.c +

[Qemu-devel] [PATCH 11/33] vhost: 64 bit features

2015-06-04 Thread Gerd Hoffmann
From: Cornelia Huck Make sure that all vhost interfaces use 64 bit features, as the virtio core does, and make sure to use ULL everywhere possible to be on the safe side. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/net/vhost_net.c

[Qemu-devel] [PATCH 06/33] virtio: allow to fail setting status

2015-06-04 Thread Gerd Hoffmann
From: Cornelia Huck virtio-1 allow setting of the FEATURES_OK status bit to fail if the negotiated feature bits are inconsistent: let's fail virtio_set_status() in that case and update virtio-ccw to post an error to the guest. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed

[Qemu-devel] [PATCH 19/33] virtio-pci: change & document virtio pci bar layout.

2015-06-04 Thread Gerd Hoffmann
This patch adds variables for the pci bars (to get rid of the magic numbers in the code) and moves the modern virtio bar to region 4 so regions 2+3 are kept free. virtio-vga wants use them. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/v

[Qemu-devel] [PATCH 27/33] virtio-pci: move virtio_pci_add_mem_cap call to virtio_pci_modern_region_map

2015-06-04 Thread Gerd Hoffmann
Also fill offset and length automatically, from VirtIOPCIRegion->offset and region size. Signed-off-by: Gerd Hoffmann --- hw/virtio/virtio-pci.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c inde

[Qemu-devel] [PATCH 28/33] virtio-pci: move cap type to VirtIOPCIRegion

2015-06-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/virtio/virtio-pci.c | 9 + hw/virtio/virtio-pci.h | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 4481294..7cffe8a 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci

[Qemu-devel] [PATCH 23/33] virtio-balloon: switch to virtio_add_feature

2015-06-04 Thread Gerd Hoffmann
From: Cornelia Huck This was missed during the conversion of feature bit manipulation. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/v

[Qemu-devel] [PATCH 29/33] virtio-pci: drop identical virtio_pci_cap

2015-06-04 Thread Gerd Hoffmann
Now the three struct virtio_pci_caps are identical, lets drop two of them ;) Signed-off-by: Gerd Hoffmann --- hw/virtio/virtio-pci.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 7cffe8a..7baeb7e 1006

[Qemu-devel] [PATCH 12/33] linux-headers: add virtio_pci

2015-06-04 Thread Gerd Hoffmann
From: "Michael S. Tsirkin" Easier than duplicating code. Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 2 + linux-headers/linux/virtio_pci.h | 192 +++ 2 files changed, 194 insertions(+) create mode 100644 linux-headers/linux/vi

[Qemu-devel] [PATCH 33/33] virtio-input: emulated devices [pci]

2015-06-04 Thread Gerd Hoffmann
This patch adds virtio-pci support for the emulated virtio-input devices. Using them is as simple as adding "-device virtio-tablet-pci" to your command line. If you want add multiple devices but don't want waste a pci slot for each you can compose a multifunction device this way: qemu -device vi

[Qemu-devel] [PATCH 13/33] virtio-pci: initial virtio 1.0 support

2015-06-04 Thread Gerd Hoffmann
From: "Michael S. Tsirkin" This is somewhat functional. With this, and linux driver from my tree, I was able to use virtio net as virtio 1.0 device for light browsing. At the moment, dataplane and vhost code is still missing. Based on Cornelia's virtio 1.0 patchset: Date: Thu, 11 Dec 2014

[Qemu-devel] [PATCH 30/33] virtio-pci: fill VirtIOPCIRegions early.

2015-06-04 Thread Gerd Hoffmann
Initialize the modern bar and the VirtIOPCIRegion fields early, in realize. Also add a size field to VirtIOPCIRegion and variables for pci bars to VirtIOPCIProxy. This allows virtio-pci subclasses to change things before the device_plugged callback applies them. virtio-vga will use that to arran

[Qemu-devel] [PATCH 32/33] virtio-input: core code & base class [pci]

2015-06-04 Thread Gerd Hoffmann
This patch adds the virtio-pci support bits for virtio-input-device. Signed-off-by: Gerd Hoffmann --- hw/virtio/virtio-pci.c | 36 hw/virtio/virtio-pci.h | 14 ++ 2 files changed, 50 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/v

[Qemu-devel] [PATCH 25/33] virtio-pci: add virtio_pci_modern_regions_init()

2015-06-04 Thread Gerd Hoffmann
Add init function for the modern pci regions, move over the init code. Signed-off-by: Gerd Hoffmann --- hw/virtio/virtio-pci.c | 117 + 1 file changed, 59 insertions(+), 58 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c

[Qemu-devel] [PATCH 31/33] pci: add PCI_CLASS_INPUT_*

2015-06-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/pci/pci_ids.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h index c6de710..49c062b 100644 --- a/include/hw/pci/pci_ids.h +++ b/include/hw/pci/pci_ids.h @@ -47,6 +47,13 @@ #define PCI_CLAS

[Qemu-devel] [PATCH 04/33] dataplane: allow virtio-1 devices

2015-06-04 Thread Gerd Hoffmann
From: Cornelia Huck Handle endianness conversion for virtio-1 virtqueues correctly. Note that dataplane now needs to be built per-target. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/dataplane/vring.c | 47 +

Re: [Qemu-devel] [PULL 00/22] target-arm queue

2015-06-04 Thread Peter Maydell
On 2 June 2015 at 17:33, Peter Maydell wrote: > > There's more stuff in the pipeline for ARM, but 22 patches > is a respectable number, so let's drain the queue. > > -- PMM > > > The following changes since commit 3fc827d591679f3e262b9d1f8b34528eabfca8c0: > > target-arm: Correct check for non-EL

[Qemu-devel] [PATCH 24/33] virtio-pci: add struct VirtIOPCIRegion for virtio-1 regions

2015-06-04 Thread Gerd Hoffmann
For now just place the MemoryRegion there, following patches will add more. Signed-off-by: Gerd Hoffmann --- hw/virtio/virtio-pci.c | 20 +++- hw/virtio/virtio-pci.h | 12 2 files changed, 19 insertions(+), 13 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/vi

Re: [Qemu-devel] [PATCH V5] vhost: logs sharing

2015-06-04 Thread Michael S. Tsirkin
On Thu, Jun 04, 2015 at 05:28:46AM -0400, Jason Wang wrote: > Currently we allocate one vhost log per vhost device. This is sub > optimal when: > > - Guest has several device with vhost as backend > - Guest has multiqueue devices > > In the above cases, we can avoid the memory allocation by shari

Re: [Qemu-devel] [PATCH] Print error when failing to load PCI config data

2015-06-04 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v3 3/8] target-sh4: optimize addc using add2

2015-06-04 Thread Paolo Bonzini
On 04/06/2015 07:03, Richard Henderson wrote: >> +tcg_gen_add2_i32(t1, t2, REG(B11_8), t0, REG(B7_4), t0); >> +tcg_gen_add2_i32(REG(B11_8), cpu_sr_t, t1, t2, cpu_sr_t, >> t0); > > Swap these two adds and you don't need t2. You can consume sr_t > immediately and start pro

Re: [Qemu-devel] [PATCH 17/33] virtio-pci: add flags to enable/disable legacy/modern

2015-06-04 Thread Daniel P. Berrange
On Thu, Jun 04, 2015 at 12:34:26PM +0200, Gerd Hoffmann wrote: > Add VIRTIO_PCI_FLAG_DISABLE_LEGACY and VIRTIO_PCI_FLAG_DISABLE_MODERN > for VirtIOPCIProxy->flags. Also add properties for them. They can be > used to disable modern (virtio 1.0) or legacy (virtio 0.9) modes. > > By default only le

Re: [Qemu-devel] [PATCH v5 3/6] target-arm: kvm - implement software breakpoints

2015-06-04 Thread Peter Maydell
On 29 May 2015 at 16:19, Alex Bennée wrote: > These don't involve messing around with debug registers, just setting > the breakpoint instruction in memory. GDB will not use this mechanism if > it can't access the memory to write the breakpoint. > > All the kernel has to do is ensure the hypervisor

Re: [Qemu-devel] [PATCH v5 2/6] target-arm: kvm64: introduce kvm_arm_init_debug()

2015-06-04 Thread Peter Maydell
On 29 May 2015 at 16:19, Alex Bennée wrote: > As we haven't always had guest debug support we need to probe for it. > Additionally we don't do this in the start-up capability code so we > don't fall over on old kernels. > > Signed-off-by: Alex Bennée > --- Reviewed-by: Peter Maydell thanks --

Re: [Qemu-devel] [PATCH v5 4/6] target-arm: kvm - support for single step

2015-06-04 Thread Peter Maydell
On 29 May 2015 at 16:19, Alex Bennée wrote: > This adds support for single-step. There isn't much to do on the QEMU > side as after we set-up the request for single step via the debug ioctl > it is all handled within the kernel. > > Signed-off-by: Alex Bennée > > --- > v2 > - convert to using H

Re: [Qemu-devel] [PATCH 00/33] virtio 1.0 patch series rebased

2015-06-04 Thread Michael S. Tsirkin
On Thu, Jun 04, 2015 at 12:34:09PM +0200, Gerd Hoffmann wrote: > Hi, > > Here comes the virtio 1.0 patch series, rebased to latest master. > Patches 1-23 are based on the old branch by cornelia & mst. > Patches 24-30 are virtio-pci bits on top of that. > Patches 31-33 add virtio-pci support for

Re: [Qemu-devel] [Qemu-block] [PATCH v8 05/10] qcow2: Split upgrade/downgrade paths for amend

2015-06-04 Thread Alberto Garcia
On Wed 03 Jun 2015 10:13:34 PM CEST, Max Reitz wrote: > If the image version should be upgraded, that is the first we should do; > if it should be downgraded, that is the last we should do. So split the > version change block into an upgrade part at the start and a downgrade > part at the end. > >

Re: [Qemu-devel] [PATCH 17/33] virtio-pci: add flags to enable/disable legacy/modern

2015-06-04 Thread Michael S. Tsirkin
On Thu, Jun 04, 2015 at 11:52:43AM +0100, Daniel P. Berrange wrote: > On Thu, Jun 04, 2015 at 12:34:26PM +0200, Gerd Hoffmann wrote: > > Add VIRTIO_PCI_FLAG_DISABLE_LEGACY and VIRTIO_PCI_FLAG_DISABLE_MODERN > > for VirtIOPCIProxy->flags. Also add properties for them. They can be > > used to disab

[Qemu-devel] [PULL 00/28] pc, acpi, virtio, tpm

2015-06-04 Thread Michael S. Tsirkin
Sending earlier than usual because the suspend states patches block Paolo. The following changes since commit b821cbe274c5a5cacf1a7b28360d869ae1e6e0c3: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-06-01 15:22:46 +0100) are available in the git repository at:

[Qemu-devel] [PULL 03/28] virtio-pci: don't try to mask or unmask vqs without notifiers

2015-06-04 Thread Michael S. Tsirkin
From: Jason Wang We should validate the vq index against nvqs_with_notifiers. Otherwise we may try to mask or unmask vector for vqs without notifiers (e.g control vq). This will lead qemu abort on kvm_irqchip_commit_routes() when trying to boot win8.1 guest. Fixes 851c2a75a6e80c8aa5e713864d98cfb

[Qemu-devel] [PULL 01/28] acpi: add missing ssdt

2015-06-04 Thread Michael S. Tsirkin
commit 5cb18b3d7bff2a83275ee98af2a14eb9e21c93ab TPM2 ACPI table support was missing a file, so build with iasl fails (build without iasl works since it uses the generated hex files). Reported-by: "Daniel P. Berrange" Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-tpm-common.dsl | 36 +

[Qemu-devel] [PULL 09/28] hw/pci: made pci_bus_num a PCIBusClass method

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Refactoring it as a method of PCIBusClass will allow different implementations for subclasses. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Laszlo Ersek --- include/hw/pci/pci_bus.h | 1 + hw/pci/pci.c

[Qemu-devel] [PULL 04/28] TPM: fix build with tpm disabled

2015-06-04 Thread Michael S. Tsirkin
From: Juan Quintela Failure was included on commit Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/sysemu/tpm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/sysemu/tpm.h b/include/sysemu/tpm.h index c143890..c8afa17

[Qemu-devel] [PULL 05/28] virtio: 64bit features fixups.

2015-06-04 Thread Michael S. Tsirkin
From: Gerd Hoffmann Commit "019a3ed virtio: make features 64bit wide" missed a few changes, as I've noticed while trying to rebase the virtio-1 branch to latest master. This patch adds them. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- i

[Qemu-devel] [PULL 02/28] hw/q35: fix floppy controller definition in ich9

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum In DSDT FDC0 declares the IO region as IO(Decode16, 0x03F2, 0x03F2, 0x00, 0x04). Use the same in lpc_ich9 initialization code. Now the floppy drive is detected correctly on Windows. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[Qemu-devel] [PULL 11/28] hw/pci: extend PCI config access to support devices behind PXB

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum PXB buses are assumed to be children of bus 0. Look for them while scanning the buses. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Laszlo Ersek --- hw/pci/pci.c | 34 +- 1

[Qemu-devel] [PULL 08/28] hw/pci: made pci_bus_is_root a PCIBusClass method

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Refactoring it as a method of PCIBusClass will allow different implementations for subclasses. Removed the assumption that the root bus does not have a parent device because is specific only to the default class implementation. Signed-off-by: Marcel Apfelbaum Reviewed-by

[Qemu-devel] [PULL 07/28] acpi: add implementation of aml_while() term

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Commit 68e6b0af7 (acpi: add aml_while() term) added the definition of aml_while without the actual implementation. Implement the term. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Laszlo Ersek --- hw/acpi/

[Qemu-devel] [PULL 06/28] acpi: add acpi_send_gpe_event() to rise sci for hotplug

2015-06-04 Thread Michael S. Tsirkin
From: Zhu Guihua Add a new API named acpi_send_gpe_event() to send hotplug SCI. This API can be used by pci, cpu and memory hotplug. This patch is rebased on master. Signed-off-by: Zhu Guihua Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- i

[Qemu-devel] [PULL 18/28] hw/pci: inform bios if the system has extra pci root buses

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum The bios looks for 'etc/extra-pci-roots' to decide if is going to scan further buses after bus 0 tree. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Laszlo Ersek --- hw/i386/pc.c | 20

[Qemu-devel] [PULL 21/28] hw/pxb: add numa_node parameter

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum The pxb can be attach to and existing numa node by specifying numa_node option that equals the desired numa nodeid. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Laszlo Ersek --- hw/i386/acpi-build.c

[Qemu-devel] [PULL 10/28] hw/i386: query only for q35/pc when looking for pci host bridge

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Because of the PXB hosts we cannot simply query TYPE_PCI_HOST_BRIDGE anymore. On i386 arch we only have two pci hosts, so we can look only for them. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Laszlo Ersek

[Qemu-devel] [PULL 16/28] hw/pci: removed 'rootbus nr is 0' assumption from qmp_pci_query

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Use the newer pci_bus_num to correctly get the root bus number. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Laszlo Ersek --- hw/pci/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

[Qemu-devel] [PULL 12/28] hw/acpi: add support for i440fx 'snooping' root busses

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum If the machine has extra root busses that are snooping to the i440fx host bridge, we need to add them to acpi in order to be properly detected by guests. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Laszlo E

[Qemu-devel] [PULL 14/28] hw/acpi: add _CRS method for extra root busses

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Save the IO/mem/bus numbers ranges assigned to the extra root busses to be removed from the root bus 0 range. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Laszlo Ersek --- hw/i386/acpi-build.c | 139 ++

[Qemu-devel] [PULL 19/28] hw/pxb: add map_irq func

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum The bios does not index the pxb slot number when it computes the IRQ because it resides on bus 0 and not on the current bus. However Qemu routes the irq through bus 0 and adds the pxb slot to the IRQ computation of the PXB device. Synchronize between bios and Qemu by cance

[Qemu-devel] [PULL 24/28] pc-dimm: don't assert if pc-dimm alignment != hotpluggable mem range size

2015-06-04 Thread Michael S. Tsirkin
From: Igor Mammedov Drop superfluous pc-dimm alignment on hot-pluggable mem range size assert, since it causes QEMU crash during hotplug when hotplugging pc-dimm with alignment bigger than an alignment of hot-pluggable mem range size. Instead allow pc_dimm_get_free_addr() find free address and b

[Qemu-devel] [PULL 13/28] hw/apci: add _PRT method for extra PCI root busses

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Laszlo Ersek --- hw/i386/acpi-build.c | 81 1 file changed, 81 insertions(+) diff --git a/hw/i386/acpi-buil

[Qemu-devel] [PULL 15/28] hw/acpi: remove from root bus 0 the crs resources used by other buses.

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum If multiple root buses are used, root bus 0 cannot use all the pci holes ranges. Remove the IO/mem ranges used by the other primary buses. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Laszlo Ersek --- hw/i

[Qemu-devel] [PULL 27/28] hw/acpi: piix4_pm_init(): take fw_cfg object no more

2015-06-04 Thread Michael S. Tsirkin
From: Laszlo Ersek This PIIX4 init function has no more reason to receive a pointer to the FwCfg object. Remove the parameter from the prototype, and update callers. As a result, the pc_init1() function no longer needs to save the return value of pc_memory_init() and xen_load_linux(), which make

[Qemu-devel] [PULL 17/28] hw/pci: introduce PCI Expander Bridge (PXB)

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum PXB is a "light-weight" host bridge whose purpose is to enable the main host bridge to support multiple PCI root buses for pc machines. As oposed to PCI-2-PCI bridge's secondary bus, PXB's bus is a primary bus and can be associated with a NUMA node (different from the main

Re: [Qemu-devel] [PATCH v5 5/6] target-arm: kvm - add support for HW assisted debug

2015-06-04 Thread Peter Maydell
On 29 May 2015 at 16:19, Alex Bennée wrote: > This adds basic support for HW assisted debug. The ioctl interface to > KVM allows us to pass an implementation defined number of break and > watch point registers. When KVM_GUESTDBG_USE_HW_BP is specified these > debug registers will be installed in p

[Qemu-devel] [PULL 23/28] docs: Add PXB documentation

2015-06-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Laszlo Ersek --- docs/pci_expander_bridge.txt | 58 1 file changed, 58 insertions(+) create mode 100644 docs/pci_ex

  1   2   3   4   >