[Qemu-devel] [Bug 1458239] Re: Use qed instead of qcow2 for "-snapshot" functionality

2015-05-24 Thread Michael Tokarev
I'm not sure I follow, why qed is better? qed was an example/testing format in an attempt to make qcow2 faster. It succeeded in its task, and qcow2 has been improved a lot after playing with qed. What's wrong with qcow2 and why it is faster? How about providing some benchmarks? ** Changed in: qe

[Qemu-devel] [Bug 1458239] Re: Use qed instead of qcow2 for "-snapshot" functionality

2015-05-24 Thread Коренберг Марк
Sorry, I did not know tha qed is just experimental format. I thought that qed is successor of qcow2. Can you add some links that qcow is not worse than qed ? I did not make any benchmark, just read some articles -- You received this bug notification because you are a member of qemu- devel-ml, whi

Re: [Qemu-devel] [PATCH qemu] pseries: Update SLOF firmware image to qemu-slof-20150429

2015-05-24 Thread Alexey Kardashevskiy
On 12.05.2015 19:58, Alexey Kardashevskiy wrote: On 05/07/2015 05:10 PM, Alexey Kardashevskiy wrote: The changelog is: > version: update to 20150429 > pci: Use QEMU created PCI device nodes > usb: support 64-bit pci bars > pci: Support 64-bit address translation > pci: program cor

Re: [Qemu-devel] [PATCH v2 0/3] Add support for for GICv2m and MSIs to arm-virt

2015-05-24 Thread Christoffer Dall
On Wed, May 06, 2015 at 05:39:28PM +0100, Peter Maydell wrote: > On 6 May 2015 at 17:33, Peter Maydell wrote: > > On 27 April 2015 at 18:31, Christoffer Dall > > wrote: > >> Now when we have a host generic PCIe controller in the virt board, it > >> would be nice to be able to use MSIs so that we

[Qemu-devel] [PATCH v3 1/4] target-arm: Add GIC phandle to VirtBoardInfo

2015-05-24 Thread Christoffer Dall
Instead of passing the GIC phandle around between functions, add it to the VirtBoardInfo just like we do for the clock_phandle. We are about to add the v2m phandle as well, and it's easier not having to pass around a bunch of phandles, return multiple values from functions, etc. Reviewed-by: Pete

[Qemu-devel] [PATCH v3 0/4] Add support for for GICv2m and MSIs to arm-virt

2015-05-24 Thread Christoffer Dall
Now when we have a host generic PCIe controller in the virt board, it would be nice to be able to use MSIs so that we can eventually enable VHOST with KVM. With these patches you can use MSIs with TCG and with KVM, but you still need some fixes for the mapping of the IRQ index to the GSI number fo

[Qemu-devel] [PATCH v3 4/4] target-arm: Add the GICv2m to the virt board

2015-05-24 Thread Christoffer Dall
Add a GICv2m device to the virt board to enable MSIs on the generic PCI host controller. We allocate 64 SPIs in the IRQ space for now (this can be increased/decreased later) and map the GICv2m right after the GIC in the memory map. Signed-off-by: Christoffer Dall --- Changes since v2: - Factore

[Qemu-devel] [PATCH v3 3/4] target-arm: Extend the gic node properties

2015-05-24 Thread Christoffer Dall
From: Shanker Donthineni In preparation for adding the GICv2m which requires address specifiers and is a subnode of the gic, we extend the gic DT definition to specify the #address-cells and #size-cells properties and add an empty ranges property properties of the DT node, since this is required

[Qemu-devel] [PATCH v3 2/4] arm_gicv2m: Add GICv2m widget to support MSIs

2015-05-24 Thread Christoffer Dall
The ARM GICv2m widget is a little device that handles MSI interrupt writes to a trigger register and ties them to a range of interrupt lines wires to the GIC. It has a few status/id registers and the interrupt wires, and that's about it. A board instantiates the device by setting the base SPI num

Re: [Qemu-devel] [PATCH v5 3/4] spapr_pci: enumerate and add PCI device tree

2015-05-24 Thread Alexey Kardashevskiy
On 05/19/2015 06:26 PM, Nikunj A Dadhania wrote: All the PCI enumeration and device node creation was off-loaded to SLOF. With PCI hotplug support, code needed to be added to add device node. This creates multiple copy of the code one in SLOF and other in hotplug code. To unify this, the patch ad

Re: [Qemu-devel] [PATCH v5 4/4] spapr_pci: populate ibm,loc-code

2015-05-24 Thread Alexey Kardashevskiy
On 05/19/2015 06:26 PM, Nikunj A Dadhania wrote: Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Populate i

Re: [Qemu-devel] [PING-2 PATCH v3 0/3] virtio-mmio: introduce eventfd support

2015-05-24 Thread Pavel Fedin
Hello everybody! This is my second PING on this. I have seen no response to v3. Changes since to v2 are: 1. Properly formatted (i really hope so...) 2. Added reset handling. I decided to leave this as three patches because host and guest notifiers should be both implemented in order to make use

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2015-05-24 Thread Jan Kiszka
On 2015-01-12 09:55, Paolo Bonzini wrote: > On 12/01/2015 09:30, Jan Kiszka wrote: >> I think this would only cure a symptom, but it doesn't explain why we >> now hit cpu_handle_guest_debug which we do not before the patch: > > That means we now exit with EXCP_DEBUG and we didn't before? > > Some

[Qemu-devel] [PATCH] i386: Introduce ARAT CPU feature

2015-05-24 Thread Jan Kiszka
From: Jan Kiszka ARAT signals that the APIC timer does not stop in power saving states. As our APICs are emulated, it's fine to expose this feature to guests, at least when asking for KVM host features or with CPU types that include the flag. The exact model number that introduced the feature is

Re: [Qemu-devel] [PATCH 0/4] gdbstub: improve query packet parsing, add qAttached support

2015-05-24 Thread Jan Kiszka
On 2015-02-12 05:19, Peter Maydell wrote: > On 7 February 2015 at 08:38, Jan Kiszka wrote: >> This addresses the review comments on the previews two patches to add >> qAttached support. No longer trivial, so maybe you can pick it up, >> Peter. >> >> Jan >> >> >> CC: Fabien Chouteau >> CC: Jan Kis

[Qemu-devel] [PATCH v2] device-tree: Make a common-obj

2015-05-24 Thread Peter Crosthwaite
There is no reason for device tree API to be built per-target. common-obj it. There is an extraneous inclusion of config.h that needs to be removed. Cc: Alexander Graf Reviewed-by: Andreas Färber Signed-off-by: Peter Crosthwaite --- Makefile.objs | 2 ++ Makefile.target | 1 - device_tree.c

Re: [Qemu-devel] [PATCH 1/2] monitor: Split mon_get_cpu fn to remove ENV_GET_CPU

2015-05-24 Thread Peter Crosthwaite
On Mon, May 18, 2015 at 9:52 AM, Andreas Färber wrote: > Am 18.05.2015 um 18:44 schrieb Peter Crosthwaite: >> On Mon, May 18, 2015 at 9:13 AM, Richard Henderson wrote: >>> On 05/17/2015 12:51 PM, Peter Crosthwaite wrote: @@ -1208,7 +1203,6 @@ static void monitor_printc(Monitor *mon, int c) >

Re: [Qemu-devel] u-boot on qemu-x86

2015-05-24 Thread Bin Meng
Hi Saket, On Tue, May 5, 2015 at 10:11 PM, Saket Sinha wrote: > Hi, > > I am trying to run u-boot as a coreboot payload on qemu-x86.Currently > facing some difficulty in the process. > > Has anyone tried running u-boot bare-metal or as a coreboot payload on > qemu-x86 before? > Reply this threa

[Qemu-devel] [PATCH v2 0/2] monitor+disas: Remove uses of ENV_GET_CPU

2015-05-24 Thread Peter Crosthwaite
Neither the monitor or disassembly core has a good reason to navigate from an env pointer to a cpu pointer. Disas should not need env awarness at all, that is removed in P2. The monitor is trickier, the env is still needed by some #ifdef switched target specific code but all common code only needs

[Qemu-devel] [PATCH v2 2/2] disas: Remove uses of CPU env

2015-05-24 Thread Peter Crosthwaite
disas does not need to access the CPU env for any reason. Change the APIs to accept CPU pointers instead. Small change pattern needs to be applied to all target translate.c. This brings us closer to making disas.o a common-obj and less architecture specific in general. Cc: Richard Henderson Cc: P

[Qemu-devel] [PATCH v2 1/2] monitor: Split mon_get_cpu fn to remove ENV_GET_CPU

2015-05-24 Thread Peter Crosthwaite
The monitor currently has one helper, mon_get_cpu() which will return an env pointer. The target specific users of this API want an env, but all the target agnostic users really just want the cpu pointer. These users then need to use the target-specifically defined ENV_GET_CPU to navigate back up t

Re: [Qemu-devel] [PATCH v2 3/7] disas: arm-a64: Make printfer and stream variable

2015-05-24 Thread Peter Crosthwaite
On Mon, May 11, 2015 at 8:57 AM, Richard Henderson wrote: > On 05/09/2015 01:11 PM, Peter Crosthwaite wrote: >> class QEMUDisassembler : public Disassembler { >> public: >> -explicit QEMUDisassembler(FILE *stream) : stream_(stream) { } >> +QEMUDisassembler() { >> +printf_ = NULL;

Re: [Qemu-devel] [PATCH v2 4/7] disas: arm: QOMify target specific disas setup

2015-05-24 Thread Peter Crosthwaite
On Mon, May 18, 2015 at 9:31 AM, Peter Maydell wrote: > On 9 May 2015 at 21:11, Peter Crosthwaite wrote: >> Move the target_disas() ARM specifics to the QOM disas_set_info hook >> >> +static int >> +print_insn_thumb1(bfd_vma pc, disassemble_info *info) >> +{ >> + return print_insn_arm(pc | 1, i

Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using

2015-05-24 Thread Chen Gang
For "Hello world" with shared glibc, it needs to implement additional instructions and fix one additional bug (it is about syscall_nr.h: need stat64 and fstatat64). I shall send patch v11 within this month. :-) Thanks. On 5/22/15 09:48, Chen Gang wrote: > On 05/22/2015 07:40 AM, Chris Metcalf

[Qemu-devel] [PATCH v3 0/7] Unify and QOMify (target|monitor)_disas

2015-05-24 Thread Peter Crosthwaite
Depends on series: [PATCH v2 0/2] monitor+disas: Remove uses of ENV_GET_CPU Intended for QOM queue. These two functions are mostly trying to do the same thing, which is disassemble a target instruction (sequence) for printfing. The architecture specific setup is largely duped between the two func

[Qemu-devel] [PATCH v3 2/7] disas: QOMify target specific setup

2015-05-24 Thread Peter Crosthwaite
Add a QOM function hook for target-specific disassembly setup. This allows removal of the #ifdeffery currently implementing target specific disas setup from disas.c. Reviewed-by: Richard Henderson Signed-off-by: Peter Crosthwaite --- disas.c | 22 ++ include/qom/cp

[Qemu-devel] [PATCH v3 3/7] disas: arm-a64: Make printfer and stream variable

2015-05-24 Thread Peter Crosthwaite
In a normal disassembly flow, the printf and stream being used varies from disas job to job. In particular it varies if mixing monitor_disas and target_disas. Make both the printfer function and target stream settable in the QEMUDisassmbler class. Remove the stream_ initialisation from the constru

[Qemu-devel] [PATCH v3 4/7] disas: arm: QOMify target specific disas setup

2015-05-24 Thread Peter Crosthwaite
Move the target_disas() ARM specifics to the QOM disas_set_info hook and delete the ARM specific code in disas.c. This has the extra advantage of the more fully featured target_disas() implementation now applying to monitor_disas(). Currently, target_disas() has multi-endian, thumb and AArch64 su

[Qemu-devel] [PATCH v3 1/7] disas: Add print_insn to disassemble info

2015-05-24 Thread Peter Crosthwaite
Add the print_insn pointer to the disassemble info structure. This is to prepare for QOMification support, where a QOM CPU hook function will be responsible for setting the print_insn function. Add this function to the existing struct to consolidate such that only the one struct needs to be passed

[Qemu-devel] [PATCH v3 5/7] disas: microblaze: QOMify target specific disas setup

2015-05-24 Thread Peter Crosthwaite
Move the target_disas() MB specifics to the QOM disas_set_info hook and delete the MB specific code in disas.c. This also now adds support for monitor disas to Microblaze. E.g. (qemu) xp 0x9000 9000: 0x94208001 And before this patch: (qemu) xp/i 0x9000 0x9000: Asm output

Re: [Qemu-devel] [PATCH 2/2] linux-user: Add HWCAP for SH4

2015-05-24 Thread Aurelien Jarno
On 2015-05-23 15:06, Richard Henderson wrote: > Only exposing FPU and LLSC as the only features > supported by the translator. > > Signed-off-by: Richard Henderson > --- > linux-user/elfload.c | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/linux-user/elf

[Qemu-devel] [PATCH v3 6/7] disas: cris: Fix 0 buffer length case

2015-05-24 Thread Peter Crosthwaite
Cris has the complication of variable length instructions and has a check in place to clamp memory reads in case the disas request doesn't have enough bytes for the instruction being disas'd. This breaks down in the case where disassembling for the monitor where the buffer length is defaulted to 0.

[Qemu-devel] [PATCH v3 7/7] disas: cris: QOMify target specific disas setup

2015-05-24 Thread Peter Crosthwaite
Move the target_disas() cris specifics to the QOM disas_set_info hook and delete the cris specific code in disas.c. This also now adds support for monitor disas to cris. E.g. (qemu) xp 0x40004000 40004000: 0x1e6f25f0 And before this patch: (qemu) xp/i 0x40004000 0x40004000: Asm output no

Re: [Qemu-devel] [PATCH 0/2] sh4 linux-user cpu and hwcap

2015-05-24 Thread Aurelien Jarno
On 2015-05-23 15:06, Richard Henderson wrote: > As reported by Rich the other day. As I don't have a user-land > binary that depends on this, I merely note that it still runs > the linux-user-test sh4 binary. And gdb confirms that the LLSC > bit does get set. How would you like to see this patc

Re: [Qemu-devel] [PATCH 1/2] linux-user: Default sh4 to sh7785

2015-05-24 Thread Aurelien Jarno
On 2015-05-23 15:06, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > linux-user/main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/linux-user/main.c b/linux-user/main.c > index 3f32db0..7e0a439 100644 > --- a/linux-user/main.c > +++ b/linux-user/main.c > @@ -39

Re: [Qemu-devel] [PATCH 0/2] sh4 linux-user cpu and hwcap

2015-05-24 Thread Rich Felker
On Sat, May 23, 2015 at 03:06:52PM -0700, Richard Henderson wrote: > As reported by Rich the other day. As I don't have a user-land > binary that depends on this, I merely note that it still runs > the linux-user-test sh4 binary. And gdb confirms that the LLSC > bit does get set. > > Rich, can

[Qemu-devel] [PATCH v3 3/8] target-sh4: optimize addc using add2

2015-05-24 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- target-sh4/translate.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/target-sh4/translate.c b/target-sh4/translate.c index f9bc24c..a7a8f39 100644 --- a/target-sh4/translate.c +++ b/target-sh4/translate.c @@ -642,17 +642,15 @@

[Qemu-devel] [PATCH v3 4/8] target-sh4: optimize subc using sub2

2015-05-24 Thread Aurelien Jarno
Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target-sh4/translate.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/target-sh4/translate.c b/target-sh4/translate.c index a7a8f39..d5b448e 100644 --- a/target-sh4/translate.c +++ b/target-sh4/

[Qemu-devel] [PATCH v3 1/8] target-sh4: use bit number for SR constants

2015-05-24 Thread Aurelien Jarno
Use the bit number for SR constants instead of using a bit mask. This make possible to also use the constants for shifts. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target-sh4/cpu.c | 3 +- target-sh4/cpu.h | 30 ++-- target-sh4/gdbstub.c |

[Qemu-devel] [PATCH v3 7/8] target-sh4: factorize fmov implementation

2015-05-24 Thread Aurelien Jarno
Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target-sh4/translate.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/target-sh4/translate.c b/target-sh4/translate.c index daea268..882c8d8 100644 --- a/target-sh4/translate.c +++ b/target-

[Qemu-devel] [PATCH v3 5/8] target-sh4: optimize negc using add2 and sub2

2015-05-24 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- target-sh4/translate.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target-sh4/translate.c b/target-sh4/translate.c index d5b448e..250632a 100644 --- a/target-sh4/translate.c +++ b/target-sh4/translate.c @@ -795,12 +795,12 @@ s

[Qemu-devel] [PATCH v3 2/8] target-sh4: Split out T from SR

2015-05-24 Thread Aurelien Jarno
In preparation for more efficient setting of this field. Signed-off-by: Aurelien Jarno --- target-sh4/cpu.h | 14 +++- target-sh4/gdbstub.c | 4 +- target-sh4/helper.c| 2 +- target-sh4/op_helper.c | 32 ++-- target-sh4/translate.c | 212

[Qemu-devel] [PATCH v3 8/8] target-sh4: remove dead code

2015-05-24 Thread Aurelien Jarno
Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target-sh4/translate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target-sh4/translate.c b/target-sh4/translate.c index 882c8d8..38d4a6f 100644 --- a/target-sh4/translate.c +++ b/target-sh4/translate.c @@ -18,7 +18,6 @@ *

[Qemu-devel] [PATCH v3 0/8] target-sh4: optimizations and cleanups

2015-05-24 Thread Aurelien Jarno
This patchset improves the SH4 emulation by using the recently added TCG instructions, namely add2, sub2 and movcond. For that the T, Q and M bits are split out from the SR register. This allow the optimizer and the liveness analysis to do some more optimisations. The last two patches are doing cl

[Qemu-devel] [PATCH v3 6/8] target-sh4: split out Q and M from of SR and optimize div1

2015-05-24 Thread Aurelien Jarno
Splitting Q and M out of SR, it's possible to optimize div1 by using TCG code instead of an helper. Signed-off-by: Aurelien Jarno --- target-sh4/cpu.h | 12 +++-- target-sh4/helper.h| 1 - target-sh4/op_helper.c | 118 - target-sh4/tra

[Qemu-devel] [PATCH 00/10] target-s390x: TCG fixes and improvements

2015-05-24 Thread Aurelien Jarno
This patchset fixes a few issues with the s390x emulation and improves it a bit by a emulating a few more instructions. With this patchset and the ones posted a few days ago, I have been able to build the GNU libc in both a 64-bit guest with 64-bit userland and a 64-bit guest with a 31-bit userlan

[Qemu-devel] [PATCH 10/10] target-s390x: implement LAY and LAEY instructions

2015-05-24 Thread Aurelien Jarno
This complete the general-instructions-extension facility, enable it. Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- target-s390x/cpu.h | 2 +- target-s390x/insn-data.def | 3 +++ target-s390x/translate.c | 35 +++ 3 files

[Qemu-devel] [PATCH 05/10] target-s390x: detect tininess before rounding for FP operations

2015-05-24 Thread Aurelien Jarno
The s390x floating point unit detects tininess before rounding, so set the softfloat fp_status up appropriately. Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- target-s390x/cpu.c | 8 1 file changed, 8 insertions(+) diff --git a/target-s390x/cpu.c b/target

[Qemu-devel] [PATCH 01/10] target-s390x: fix PSW value on dynamical exception from helpers

2015-05-24 Thread Aurelien Jarno
runtime_exception computes the psw.addr value using the actual exception address and the instruction length computed by calling the get_ilen function. However as explained above the get_ilen code, it returns the actual instruction length, and not the ILC. Therefore there is no need to multiply the

[Qemu-devel] [PATCH 07/10] target-s390x: enable fully implemented facilities

2015-05-24 Thread Aurelien Jarno
Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- target-s390x/cpu.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h index 8bda2e0..35bfdec 100644 --- a/target-s390x/cpu.h +++ b/target-s390x/cpu.h @@ -169

[Qemu-devel] [PATCH 02/10] target-s390x: fix MMU index computation

2015-05-24 Thread Aurelien Jarno
The cpu_mmu_index function wrongly looks at PSW P bit to determine the MMU index, while this bit actually only control the use of priviledge instructions. The addressing mode is detected by looking at the PSW ASC bits instead. This used to work more or less correctly up to kernel 3.6 as the kernel

[Qemu-devel] [PATCH 09/10] target-s390x: move a few instructions to the correct facility

2015-05-24 Thread Aurelien Jarno
LY is part of the long-displacement facility. RISBHG and RISBLG are part of the high-word facility. STCMH is part of the z/Architecture. Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- target-s390x/insn-data.def | 8 1 file changed, 4 insertions(+), 4 deleti

[Qemu-devel] [PATCH 04/10] target-s390x: silence NaNs for LOAD LENGTHENED and LOAD ROUNDED

2015-05-24 Thread Aurelien Jarno
LOAD LENGTHENED and LOAD ROUNDED are considered as FP operations and thus need to convert input sNaN into corresponding qNaN. Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- target-s390x/fpu_helper.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE instruction

2015-05-24 Thread Aurelien Jarno
Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- target-s390x/cpu.h | 2 +- target-s390x/helper.h | 1 + target-s390x/insn-data.def | 2 ++ target-s390x/misc_helper.c | 19 +++ target-s390x/translate.c | 7 +++ 5 files changed, 30

[Qemu-devel] [PATCH 06/10] target-s390x: improve facilities list

2015-05-24 Thread Aurelien Jarno
We currently use an hardcoded value for the STFL instruction. Move that to a still hardcoded value but computed from bit values. This is more maintainable and can be reused for the STFLE instruction. Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- target-s390x/cpu.h

[Qemu-devel] [PATCH 03/10] target-s390x: define default NaN values

2015-05-24 Thread Aurelien Jarno
Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- fpu/softfloat-specialize.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h index fa1214a..6dd41d8 100644 --- a/fpu/softfloat-specialize.

Re: [Qemu-devel] [PATCH] configure: Check for libfdt version 1.4.0

2015-05-24 Thread David Gibson
On Mon, May 18, 2015 at 09:43:21AM +0200, Thomas Huth wrote: > Some recent patches require functions from libfdt version 1.4.0, > so we should check for this version during the configure step > already. Unfortunately, there does not seem to be a proper #define > for the version number in the libfdt

Re: [Qemu-devel] [PATCH 2/6] Split header writing out of qemu_savevm_state_begin

2015-05-24 Thread David Gibson
On Thu, May 21, 2015 at 01:24:12PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Split qemu_savevm_state_begin to: > qemu_savevm_state_header That writes the initial file header. > qemu_savevm_state_beginThat sets up devices and does the first >

Re: [Qemu-devel] [PATCH 4/6] Create MigrationIncomingState

2015-05-24 Thread David Gibson
On Thu, May 21, 2015 at 01:24:14PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > There are currently lots of pieces of incoming migration state scattered > around, and postcopy is adding more, and it seems better to try and keep > it together. > > allocate MIS i

Re: [Qemu-devel] [PATCH v3 2/3] cpus: Convert cpu_index into a bitmap

2015-05-24 Thread David Gibson
On Thu, May 21, 2015 at 10:32:07AM +0530, Bharata B Rao wrote: > Currently CPUState.cpu_index is monotonically increasing and a newly > created CPU always gets the next higher index. The next available > index is calculated by counting the existing number of CPUs. This is > fine as long as we only

Re: [Qemu-devel] [PATCH v3 1/3] cpus: Add Error argument to cpu_exec_init()

2015-05-24 Thread David Gibson
On Thu, May 21, 2015 at 10:32:06AM +0530, Bharata B Rao wrote: > Add an Error argument to cpu_exec_init() to let users collect the > error. This is in preparation to change the CPU enumeration logic > in cpu_exec_init(). With the new enumeration logic, cpu_exec_init() > can fail if cpu_index values

Re: [Qemu-devel] [PATCH] spapr: ensure we have at least one XICS server

2015-05-24 Thread David Gibson
On Wed, May 13, 2015 at 12:29:33PM +0200, Greg Kurz wrote: > XICS needs to know the upper value for cpu_index as it is used to compute > the number of servers: > > smp_cpus * kvmppc_smt_threads() / smp_threads > > When passing -smp cpus=1,threads=9 on a POWER8 host, we end up with: > > 1

Re: [Qemu-devel] [PATCH 1/6] Add qemu_get_counted_string to read a string prefixed by a count byte

2015-05-24 Thread David Gibson
On Thu, May 21, 2015 at 01:24:11PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > and use it in loadvm_state and ram_load. > > Where ever it's used, check the return and error if it failed. > > Minor: ram_load was using a 257 byte array for its string, the >

Re: [Qemu-devel] [PATCH qemu] pseries: Update SLOF firmware image to qemu-slof-20150429

2015-05-24 Thread David Gibson
On Sun, May 24, 2015 at 08:16:30PM +1000, Alexey Kardashevskiy wrote: > On 12.05.2015 19:58, Alexey Kardashevskiy wrote: > >On 05/07/2015 05:10 PM, Alexey Kardashevskiy wrote: > >>The changelog is: > >> > version: update to 20150429 > >> > pci: Use QEMU created PCI device nodes > >> > usb: su

Re: [Qemu-devel] [PATCH v6 01/13] block: Add op blocker type "device IO"

2015-05-24 Thread Fam Zheng
On Sat, 05/23 18:51, Max Reitz wrote: > On 22.05.2015 06:54, Fam Zheng wrote: > >On Thu, 05/21 15:32, Fam Zheng wrote: > >>On Thu, 05/21 15:06, Wen Congyang wrote: > >>>On 05/21/2015 02:42 PM, Fam Zheng wrote: > It blocks device IO. > > All bdrv_op_block_all/blk_op_block_all callers ar

Re: [Qemu-devel] [PATCH v6 12/13] block: Block "device IO" during bdrv_drain and bdrv_drain_all

2015-05-24 Thread Fam Zheng
On Sat, 05/23 19:11, Max Reitz wrote: > On 21.05.2015 08:43, Fam Zheng wrote: > >We don't want new requests from guest, so block the operation around the > >nested poll. > > > >It also avoids looping forever when iothread is submitting a lot of requests. > > > >Signed-off-by: Fam Zheng > >--- > >

[Qemu-devel] [PATCH v9 00/24] Generate ACPI v5.1 tables and expose them to guest over fw_cfg on ARM

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao This patch series generate seven ACPI tables for machine virt on ARM. The set of generated tables are: - RSDP - RSDT - MADT - GTDT - FADT - DSDT - MCFG (For PCIe host bridge) These tables are created dynamically using the function of aml-build.c, taking into account the needed

[Qemu-devel] [PATCH v9 04/24] hw/arm/virt-acpi-build: Basic framework for building ACPI tables on ARM

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Introduce a preliminary framework in virt-acpi-build.c with the main ACPI build functions. It exposes the generated ACPI contents to guest over fw_cfg. The required ACPI v5.1 tables for ARM are: - RSDP: Initial table that points to XSDT - RSDT: Points to FADT GTDT MADT tables

[Qemu-devel] [PATCH v9 06/24] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Add aml_interrupt() for describing device interrupt in resource template. These can be used to generating DSDT table for ACPI on ARM. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Igor Mammedov --- hw/acpi/aml-build.c | 27 +++

[Qemu-devel] [PATCH v9 07/24] hw/arm/virt-acpi-build: Generation of DSDT table for virt devices

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao DSDT consists of the usual common table header plus a definition block in AML encoding which describes all devices in the platform. After initializing DSDT with header information the namespace is created which is followed by the device encodings. The devices are described usi

[Qemu-devel] [PATCH v9 08/24] hw/arm/virt-acpi-build: Generate FADT table and update ACPI headers

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao In the case of mach virt, it is used to set the Hardware Reduced bit and enable PSCI SMP booting through HVC. So ignore FACS and FADT points to DSDT. Update the header definitions for FADT taking into account the new additions of ACPI v5.1 in `include/hw/acpi/acpi-defs.h` Sig

[Qemu-devel] [PATCH v9 02/24] hw/arm/virt: Move common definitions to virt.h

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Move some common definitions to virt.h. These will be used by generating ACPI tables. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 21 +-- include/hw/arm/virt.h | 56 +++

[Qemu-devel] [PATCH v9 05/24] hw/acpi/aml-build: Add aml_memory32_fixed() term

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Add aml_memory32_fixed() for describing device mmio region in resource template. These can be used to generating DSDT table for ACPI on ARM. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée Reviewed-by: Igor Mammedov Reviewed-by: Michael S.

[Qemu-devel] [PATCH v9 17/24] hw/acpi/aml-build: Add aml_lnot() term

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée Reviewed-by: Igor Mammedov --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-bui

[Qemu-devel] [PATCH v9 15/24] hw/acpi/aml-build: Add ToUUID macro

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Add ToUUID macro, this is useful for generating PCIe ACPI table. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Igor Mammedov --- hw/acpi/aml-build.c | 53 + include/hw/acpi/aml-build.h | 1 + 2 fil

[Qemu-devel] [PATCH v9 03/24] hw/arm/virt: Record PCIe ranges in MemMapEntry array

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao To generate ACPI table for PCIe controller, we need the base and size of the PCIe ranges. Record these ranges in MemMapEntry array, then we could share and use them for generating ACPI table. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt.c

[Qemu-devel] [PATCH v9 09/24] hw/arm/virt-acpi-build: Generate MADT table

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao MADT describes GIC enabled ARM platforms. The GICC and GICD subtables are used to define the GIC regions. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée --- hw/arm/virt-acpi-build.c | 57 in

[Qemu-devel] [PATCH v9 18/24] hw/acpi/aml-build: Add aml_else() term

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée Reviewed-by: Igor Mammedov --- hw/acpi/aml-build.c | 7 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 8 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-buil

[Qemu-devel] [PATCH v9 01/24] hw/acpi/aml-build: Make enum values to be upper case to match coding style

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Igor Mammedov --- hw/acpi/aml-build.c | 12 hw/i386/acpi-build.c| 58 +++--- include/hw/acpi/aml-build.h | 68 ++

[Qemu-devel] [PATCH v9 13/24] hw/arm/virt-acpi-build: Generate MCFG table

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Generate MCFG table for PCIe controller. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée --- hw/arm/virt-acpi-build.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-b

[Qemu-devel] [PATCH v9 14/24] hw/acpi/aml-build: Make aml_buffer() definition consistent with the spec

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao According to ACPI spec, DefBuffer can take two parameters: BufferSize and ByteList. Make it consistent with the spec. Uninitialized buffer could be requested by passing ByteList as NULL to reserve space. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Ig

[Qemu-devel] [PATCH v9 12/24] hw/arm/virt-acpi-build: Generate RSDP table

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao RSDP points to RSDT which in turn points to other tables. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée --- hw/arm/virt-acpi-build.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/h

[Qemu-devel] [PATCH v9 11/24] hw/arm/virt-acpi-build: Generate RSDT table

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao RSDT points to other tables FADT, MADT, GTDT. This code is shared with x86. Here we still use RSDT as UEFI puts ACPI tables below 4G address space, and UEFI ignore the RSDT or XSDT. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée --- hw/ac

[Qemu-devel] [PATCH v9 20/24] hw/acpi/aml-build: Add aml_dword_io() term

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée Reviewed-by: Igor Mammedov --- hw/acpi/aml-build.c | 18 ++ include/hw/acpi/aml-build.h | 5 + 2 files changed, 23 insertions(+) diff --git a/hw/acpi/aml-build.c

[Qemu-devel] [PATCH v9 22/24] hw/arm/virt-acpi-build: Add PCIe controller in ACPI DSDT table

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Add PCIe controller in ACPI DSDT table, so the guest can detect the PCIe. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 154 +++ 1 file changed, 154 insertions(+) diff --git a/hw/arm/virt-

[Qemu-devel] [PATCH v9 23/24] ACPI: split CONFIG_ACPI into 4 pieces

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao As core.c, piix4.c, ich9.c and pcihp.c are for x86, add CONFIG_ACPI_X86 to make it only for x86. ARM doesn't support cpu and memory hotplug, add CONFIG_ACPI_CPU_HOTPLUG and CONFIG_ACPI_MEMORY_HOTPLUG to exclude them for target-arm. Signed-off-by: Shannon Zhao Signed-off-by: S

[Qemu-devel] [PATCH v9 19/24] hw/acpi/aml-build: Add aml_create_dword_field() term

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée Reviewed-by: Igor Mammedov --- hw/acpi/aml-build.c | 11 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/a

[Qemu-devel] [PATCH v9 21/24] hw/acpi/aml-build: Add Unicode macro

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Igor Mammedov --- hw/acpi/aml-build.c | 17 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 18 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index bd9

[Qemu-devel] [PATCH v9 24/24] hw/arm/virt: Enable dynamic generation of ACPI v5.1 tables

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Initialize VirtGuestInfoState and register a machine_init_done notify to call virt_acpi_build(). Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c

[Qemu-devel] [PATCH v9 10/24] hw/arm/virt-acpi-build: Generate GTDT table

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao ACPI v5.1 defines GTDT for ARM devices as a place to describe timer related information in the system. The Arch Timer interrupts must be provided for GTDT. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée --- hw/arm/virt-acpi-build.c| 29

[Qemu-devel] [PATCH v9 16/24] hw/acpi/aml-build: Add aml_or() term

2015-05-24 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Igor Mammedov --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index ebce504..5

[Qemu-devel] [PATCH RFC v9 1/7] qemu-iotests: qemu machine type support

2015-05-24 Thread Bo Tu
From: Xiao Guang Chen This patch adds qemu machine type support to the io test suite. Based on the qemu default machine type and alias of the default machine type the reference output file can now vary from the default to a machine specific output file if necessary. When using a machine specific

[Qemu-devel] [PATCH RFC v9 0/7] Update tests/qemu-iotests failing cases for the s390 platform

2015-05-24 Thread Bo Tu
v9. 1.Fix issue of line over 80 characters for test 049 2.Add Reviewed-by statements for test 051,130 3.Please apply the series if there are no further objections v8. 1.Modify error message in qemu-option.c when image size is invalid 2.Remove Reviewed-by statements if any functional changes in a n

[Qemu-devel] [PATCH RFC v9 3/7] qemu-iotests: s390x: fix test 041

2015-05-24 Thread Bo Tu
From: Xiao Guang Chen There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Reviewed-by: Max Reitz Reviewed-by: Michael Mueller Signed-off-by: Xiao Guang Chen --- tests/qemu-iotests/041 | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Qemu-devel] [PATCH RFC v9 2/7] qemu-iotests: run qemu with -nodefaults and fix 067, 071, 081 and 087

2015-05-24 Thread Bo Tu
From: Xiao Guang Chen This patch fixes an io test suite issue that was introduced with the commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only a single "stdio" character device'. The option supresses the creation of default devices such as the floopy and cdrom. Output files fo

[Qemu-devel] [PATCH RFC v9 4/7] qemu-iotests: s390x: fix test 055

2015-05-24 Thread Bo Tu
From: Xiao Guang Chen There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Reviewed-by: Max Reitz Reviewed-by: Michael Mueller Signed-off-by: Xiao Guang Chen --- tests/qemu-iotests/055 | 9 + 1 file changed, 9 insertions(+) diff --

[Qemu-devel] [PATCH RFC v9 7/7] qemu-iotests: s390x: fix test 130

2015-05-24 Thread Bo Tu
The default device id of hard disk on the s390 platform is "virtio0" which differs to the "ide0-hd0" for the x86 platform. Setting id in the drive definition, ie:"qemu -drive id=testdisk", will be the same on all platforms. Reviewed-by: Max Reitz Signed-off-by: Bo Tu --- tests/qemu-iotests/130

[Qemu-devel] [PATCH RFC v9 5/7] qemu-iotests: s390x: fix test 049

2015-05-24 Thread Bo Tu
when creating an image qemu-img enable us specifying the size of the image using -o size=xx options. But when we specify an invalid size such as a negtive size then different platform gives different result. parse_option_size() function in util/qemu-option.c will be called to parse the size, a cas

[Qemu-devel] [PATCH RFC v9 6/7] qemu-iotests: s390x: fix test 051

2015-05-24 Thread Bo Tu
The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and "virtio0" set for the s390 platform. A x86 platform specific output file is also needed.

[Qemu-devel] [PATCH] microblaze: s3adsp: Instantiate CPU using QOM

2015-05-24 Thread Peter Crosthwaite
Instantiate and realise the CPU directly, rather than using cpu_mb_init. Microblazes cpu_model argument is a dummy so remove the default cpu_model set logic. Signed-off-by: Peter Crosthwaite --- hw/microblaze/petalogix_s3adsp1800_mmu.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-

  1   2   >