On Mon, May 11, 2015 at 8:57 AM, Richard Henderson <r...@twiddle.net> wrote: > On 05/09/2015 01:11 PM, Peter Crosthwaite wrote: >> class QEMUDisassembler : public Disassembler { >> public: >> - explicit QEMUDisassembler(FILE *stream) : stream_(stream) { } >> + QEMUDisassembler() { >> + printf_ = NULL; >> + stream_ = NULL; >> + } > > As a nit, I would have written this > > QEMUDisassembler(FILE *stream) : stream_(NULL), printf_(NULL) { } >
Changed made in V3. > but the difference is unlikely to matter here. > > Reviewed-by: Richard Henderson <r...@twiddle.net> > Thanks, Regards, Peter > > r~ >