Re: [Qemu-devel] [PATCH 20/31] q35: implement SMRAM.D_LCK

2015-05-12 Thread Gerd Hoffmann
On Mo, 2015-05-11 at 15:49 +0200, Paolo Bonzini wrote: > From: Gerd Hoffmann [ more verbose commit message for squashing in ] Once the SMRAM.D_LCK bit has been set by the guest several bits in SMRAM and ESMRAMC become readonly until the next machine reset. Implement this by updating the wmask a

Re: [Qemu-devel] [PATCH 6/6] Add comma after DEFINE_PROP_END_OF_LIST()

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 03:25, wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c > index 433463e..d2b3f37 100644 > --- a/hw/audio/intel-hda.c > +++ b/hw/audio/intel-hda.c > @@ -31,7 +31,7 @@ > >

Re: [Qemu-devel] [PATCH 23/31] ich9: implement SMI_LOCK

2015-05-12 Thread Gerd Hoffmann
On Mo, 2015-05-11 at 15:49 +0200, Paolo Bonzini wrote: > From: Gerd Hoffmann [ more verbose commit message for squashing in ] Add write mask for the smi enable register, so we can disable write access to certain bits. Open all bits on reset. Disable write access to GBL_SMI_EN when SMI_LOCK (in

Re: [Qemu-devel] [PATCH 6/6] Add comma after DEFINE_PROP_END_OF_LIST()

2015-05-12 Thread Shannon Zhao
On 2015/5/12 14:59, Peter Maydell wrote: > On 12 May 2015 at 03:25, wrote: >> From: Shannon Zhao >> >> Signed-off-by: Shannon Zhao >> Signed-off-by: Shannon Zhao >> --- >> diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c >> index 433463e..d2b3f37 100644 >> --- a/hw/audio/intel-hda.c >>

Re: [Qemu-devel] [PATCH v2] Fixes key mapping so all keys work

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 05:11, Programmingkid wrote: > > On May 10, 2015, at 2:45 PM, Peter Maydell wrote: >> This is two conceptually separate fixes: >> (1) better handle key input to the ADB keyboard >> (2) output the right keycodes on the OSX cocoa UI >> which should be in separate patches. >> >> We

Re: [Qemu-devel] Bug report - Windows XP guest failure

2015-05-12 Thread Michael Tokarev
12.05.2015 04:05, Peter Crosthwaite wrote: > On Thu, May 7, 2015 at 2:34 AM, Michael Tokarev wrote: ... >>> Ok, I can reproduce this, winXP BSODs on boot in tcg mode. >>> Git bisect points to this: >>> >>> commit 23820dbfc79d1c9dce090b4c555994f2bb6a69b3 >>> Author: Peter Crosthwaite >>> Date: M

Re: [Qemu-devel] [RFC PATCH 02/34] tcg+qom: QOMify core CPU defintions

2015-05-12 Thread Peter Crosthwaite
On Mon, May 11, 2015 at 1:18 PM, Richard Henderson wrote: > On 05/11/2015 03:24 AM, Paolo Bonzini wrote: >> >> >> On 11/05/2015 12:18, Andreas Färber wrote: > +int (*cpu_mmu_index)(CPUState *cpu); > +void (*cpu_get_tb_cpu_state)(CPUState *cpu, > +

Re: [Qemu-devel] [RFC PATCH 02/34] tcg+qom: QOMify core CPU defintions

2015-05-12 Thread Peter Crosthwaite
On Mon, May 11, 2015 at 3:39 AM, Paolo Bonzini wrote: > > > On 11/05/2015 12:36, Andreas Färber wrote: >> > Right. My point was that these functions are not polymorphic. Each >> > call to these should know exactly which function to call. >> > >> > cputlb.c, cpu-exec.c and parts of translate-all.

Re: [Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-05-12 Thread Cornelia Huck
On Tue, 12 May 2015 10:25:16 +0800 shannon.z...@linaro.org wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/s390x/s390-virtio-bus.c | 15 --- > 1 file changed, 15 deletions(-) > Acked-by: Cornelia Huck

Re: [Qemu-devel] [RFC PATCH v5 00/14] data-driven device registers

2015-05-12 Thread Peter Crosthwaite
Ping! On Mon, Apr 27, 2015 at 2:57 PM, Peter Crosthwaite wrote: > Hi All. This is a new scheme I've come up with handling device registers in a > data driven way. My motivation for this is to factor out a lot of the access > checking that seems to be replicated in every device. See P1 commit mess

Re: [Qemu-devel] [PULL 00/28] pc, virtio enhancements

2015-05-12 Thread Peter Maydell
On 11 May 2015 at 13:46, Michael S. Tsirkin wrote: > The following changes since commit 0d81cdddaa40a1988b24657aeac19959cfad0fde: > > Merge remote-tracking branch 'remotes/qmp-unstable/tags/for-upstream' into > staging (2015-04-27 17:28:41 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 03:25, wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/s390x/s390-virtio-bus.c | 15 --- > 1 file changed, 15 deletions(-) > > diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c > index 1a72b5

Re: [Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-05-12 Thread Shannon Zhao
On 2015/5/12 15:52, Peter Maydell wrote: > On 12 May 2015 at 03:25, wrote: >> > From: Shannon Zhao >> > >> > Signed-off-by: Shannon Zhao >> > Signed-off-by: Shannon Zhao >> > --- >> > hw/s390x/s390-virtio-bus.c | 15 --- >> > 1 file changed, 15 deletions(-) >> > >> > diff --git

Re: [Qemu-devel] [PULL 00/19] target-arm queue

2015-05-12 Thread Peter Maydell
On 11 May 2015 at 14:40, Peter Maydell wrote: > This is mostly the GIC TZ changes, with a couple of other > minor bugfixes. > > -- PMM > > The following changes since commit b951cda21d6b232f138ccf008e12bce8ddc95465: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > sta

Re: [Qemu-devel] [PULL 00/19] target-arm queue

2015-05-12 Thread Peter Crosthwaite
On Tue, May 12, 2015 at 1:01 AM, Peter Maydell wrote: > On 11 May 2015 at 14:40, Peter Maydell wrote: >> This is mostly the GIC TZ changes, with a couple of other >> minor bugfixes. >> >> -- PMM >> >> The following changes since commit b951cda21d6b232f138ccf008e12bce8ddc95465: >> >> Merge remot

[Qemu-devel] [PATCH v3 0/3] virtio-mmio: introduce eventfd support

2015-05-12 Thread Pavel Fedin
This patch set introduces eventfd support for virio-mmio. It was originally published by Ying-Shiuan Pan but never got it to upstream: https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg00715.html I have updated and successfully tested it with vhost-net. I confirm that this solution signifi

Re: [Qemu-devel] [PULL 3/6] console-gl: add opengl rendering helper functions

2015-05-12 Thread Gerd Hoffmann
On Mo, 2015-05-11 at 22:32 +0200, Alexander Graf wrote: > But I see the same error on openSUSE 12.3 x86_64 now: Ah, cool, I have an iso for that laying around. /me goes install. thanks, Gerd

[Qemu-devel] [PATCH v3 1/3] virtio-mmio: introduce set_host_notifier()

2015-05-12 Thread Pavel Fedin
From: Ying-Shiuan Pan set_host_notifier() is introduced into virtio-mmio now. Most of codes came from virtio-pci. Signed-off-by: Ying-Shiuan Pan Signed-off-by: Pavel Fedin --- hw/virtio/virtio-mmio.c | 73 + 1 file changed, 73 insertions(+) dif

[Qemu-devel] [PATCH v3 2/3] virtio-mmio: introduce set_guest_notifiers

2015-05-12 Thread Pavel Fedin
From: Ying-Shiuan Pan Same as host notifier of virtio-mmio, most of codes came from virtio-pci. The kvm-arm does not yet support irqfd, need to fix the hard-coded part after kvm-arm gets irqfd support. Signed-off-by: Ying-Shiuan Pan Signed-off-by: Pavel Fedin --- hw/virtio/virtio-mmio.c | 61

[Qemu-devel] [PATCH v3 3/3] virtio-mmio: start ioeventfd when status gets DRIVER_OK

2015-05-12 Thread Pavel Fedin
From: Ying-Shiuan Pan Signed-off-by: Ying-Shiuan Pan Signed-off-by: Pavel Fedin --- hw/virtio/virtio-mmio.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index a4c4d89..c12d3fc 100644 --- a

Re: [Qemu-devel] [PULL 00/19] target-arm queue

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 09:10, Peter Crosthwaite wrote: > On Tue, May 12, 2015 at 1:01 AM, Peter Maydell > wrote: >> I could have sworn I'd tested that. Will fix & respin... >> > > Feel like grabbing the new Zynq series (v9) with it? :) Maybe. I was going to except for that last minute issue in v8. N

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Pavel Fedin
Hello! > I just pulled last git and git am-ed your patch on-top of my first 3 patches > and got this error: > /home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c: In function > 'fdt_add_gic_node': > /home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c:366:17: error: > 'KVM_DEV_TYPE_ARM_VGIC_V3' undeclar

Re: [Qemu-devel] [PATCH v1 1/1] S390 pci infrastructure modeling

2015-05-12 Thread Cornelia Huck
On Tue, 21 Apr 2015 13:29:01 +0800 Hong Bo Li wrote: > Sorry, I sent the patch three times by accident. Please take this one > as the formal patch. > > This is a followup to the discussion started by Frank Blaschka: > > Option 1: s390x/pci: Extend pci representation by new zpci device > Option

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Pavel Fedin
And one more small note... I have noticed a typo. --- cut --- [VIRT_ITS_CONTROL] = { 0x0802, 0x1000 }, --- cut --- The size should actually be 0x0001. It worked because we don't use ITS. Please fix it for the next merge attempt. Kind regards, Pavel Fedin Expert Engineer Sams

Re: [Qemu-devel] Bug report - Windows XP guest failure

2015-05-12 Thread Paolo Bonzini
On 12/05/2015 03:05, Peter Crosthwaite wrote: > On Thu, May 7, 2015 at 2:34 AM, Michael Tokarev wrote: >> 07.05.2015 09:47, Michael Tokarev wrote: >>> 07.05.2015 09:12, Michael Tokarev wrote: 07.05.2015 04:11, G 3 wrote: > Did you boot Windows XP to the desktop? I have tested Windows 95

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Daniel P. Berrange
On Fri, May 08, 2015 at 04:09:01PM +0300, Pavel Fedin wrote: > I would like to offer this, slightly improved implementation. The key thing > is a new > kernel_irqchip_type member in Machine class. Currently it it used only by > virt machine for > its internal purposes, however in future it is to

Re: [Qemu-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-05-12 Thread Fabio Fantoni
Il 11/05/2015 17:04, Fabio Fantoni ha scritto: Il 21/04/2015 14:53, Stefano Stabellini ha scritto: On Tue, 21 Apr 2015, Fabio Fantoni wrote: Il 21/04/2015 12:49, Stefano Stabellini ha scritto: On Mon, 20 Apr 2015, Fabio Fantoni wrote: I updated xen and qemu from xen 4.5.0 with its upstream qem

[Qemu-devel] [PATCH 0/3] hw/display: QOMify

2015-05-12 Thread arei.gonglei
From: Gonglei Hi, These three patches just some cleanup work about DO_UPCAST(). Please review, Thanks Cc: Gerd Hoffmann Gonglei (3): vga-pci: QOMify cirrus_vga: QOMify qxl: QOMify hw/display/cirrus_vga.c | 8 ++-- hw/display/qxl.c| 44 ++--

Re: [Qemu-devel] Help with deadlock when using sound

2015-05-12 Thread Paolo Bonzini
On 12/05/2015 00:43, Programmingkid wrote: > > On May 10, 2015, at 10:54 AM, Paolo Bonzini wrote: > >> >> >> On 06/05/2015 18:40, Programmingkid wrote: >>> When I try to use the pcspk sound hardware, QEMU freezes and uses >>> 100% of the cpu time. This is the command I use: >>> >>> qemu-system-i3

[Qemu-devel] [PATCH 2/3] cirrus_vga: QOMify

2015-05-12 Thread arei.gonglei
From: Gonglei QOMify pci-cirrus-vga like isa-cirrus-vga device. Signed-off-by: Gonglei --- hw/display/cirrus_vga.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 8765a7e..5198037 100644 --- a/hw/display/cirrus

[Qemu-devel] [PATCH 3/3] qxl: QOMify

2015-05-12 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/display/qxl.c | 44 ++-- hw/display/qxl.h | 3 +++ 2 files changed, 29 insertions(+), 18 deletions(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 0cd314c..8f40dfb 100644 --- a/hw/display/qxl.c +++ b

[Qemu-devel] [PATCH 1/3] vga-pci: QOMify

2015-05-12 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/display/vga-pci.c | 48 ++-- 1 file changed, 30 insertions(+), 18 deletions(-) diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c index aabfc23..ff5dfb2 100644 --- a/hw/display/vga-pci.c +++ b/hw/disp

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Pavel Fedin
Hello! > If we're going to start adding new machine types for aarch64 with > version numbers, then I think we should we be using a versioning > scheme that matches what we do on x86. ie, define versioned > machine types based on the QEMU release numbers As i wrote in v1 patch message, i am perf

Re: [Qemu-devel] [PATCH 1/1] Add support for PCI Enhanced Allocation "BARs"

2015-05-12 Thread Michael S. Tsirkin
On Mon, May 11, 2015 at 01:08:05PM -0700, Sean O. Stalley wrote: > On Mon, May 11, 2015 at 09:26:08PM +0200, Michael S. Tsirkin wrote: > > On Mon, May 11, 2015 at 11:56:44AM -0700, Sean O. Stalley wrote: > > > PCI Enhanced Allocation is a new method of allocating MMIO & IO > > > resources for PCI d

Re: [Qemu-devel] [PULL 00/10] QMP queue

2015-05-12 Thread Peter Maydell
On 11 May 2015 at 14:17, Luiz Capitulino wrote: > On Mon, 11 May 2015 13:53:47 +0100 > Peter Maydell wrote: > >> On 8 May 2015 at 14:34, Luiz Capitulino wrote: >> > The following changes since commit >> > f8340b360b9bc29d48716ba8aca79df2b9544979: >> > >> > hw/ptimer: Do not artificially limit

Re: [Qemu-devel] [PATCH v2 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-12 Thread Leon Alrae
On 11/05/2015 12:30, Yongbok Kim wrote: > @@ -391,6 +391,37 @@ hwaddr cpu_mips_translate_address(CPUMIPSState *env, > target_ulong address, int r > } > } > > +bool cpu_mips_validate_msa_block_access(CPUMIPSState *env, target_ulong addr, > +int rw, in

Re: [Qemu-devel] [PATCH v2 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-12 Thread Peter Maydell
On 11 May 2015 at 14:15, Yongbok Kim wrote: > The thing is that the fact misaligned accesses of MSA LD/ST should be allowed > in R5 cores > while all other instructions are not allowed. > Therefore it is required which types of instruction is triggering the > misaligned accesses. > > Initially I

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 10:20, Daniel P. Berrange wrote: > On Fri, May 08, 2015 at 04:09:01PM +0300, Pavel Fedin wrote: >> static void machvirt_machine_init(void) >> { >> type_register_static(&machvirt_info); >> +type_register_static(&machvirtv3_info); >> } > > If we're going to start adding

Re: [Qemu-devel] [PATCH v3 0/8] qcow2 L2/refcount cache improvements

2015-05-12 Thread Kevin Wolf
Am 11.05.2015 um 14:54 hat Alberto Garcia geschrieben: > New version of the qcow2 cache patches: > > v3: > - Removed a dead comment in patch #3 > - New document explaining how to configure the cache sizes > > v2: https://lists.nongnu.org/archive/html/qemu-devel/2015-05/msg00833.html > - Don't do

Re: [Qemu-devel] [PATCH qemu] pseries: Update SLOF firmware image to qemu-slof-20150429

2015-05-12 Thread Alexey Kardashevskiy
On 05/07/2015 05:10 PM, Alexey Kardashevskiy wrote: The changelog is: > version: update to 20150429 > pci: Use QEMU created PCI device nodes > usb: support 64-bit pci bars > pci: Support 64-bit address translation > pci: program correct bridge limit registers during probe > scsi

Re: [Qemu-devel] [Qemu-block] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign

2015-05-12 Thread Stefan Hajnoczi
On Mon, May 11, 2015 at 07:47:41PM +0300, Denis V. Lunev wrote: > On 11/05/15 19:07, Denis V. Lunev wrote: > >On 11/05/15 18:08, Stefan Hajnoczi wrote: > >>On Mon, May 04, 2015 at 04:42:22PM +0300, Denis V. Lunev wrote: > >>>The difference is quite reliable and the same 5%. > >>> qemu-io -n -c 'w

Re: [Qemu-devel] [Qemu-block] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign

2015-05-12 Thread Denis V. Lunev
On 12/05/15 13:01, Stefan Hajnoczi wrote: On Mon, May 11, 2015 at 07:47:41PM +0300, Denis V. Lunev wrote: On 11/05/15 19:07, Denis V. Lunev wrote: On 11/05/15 18:08, Stefan Hajnoczi wrote: On Mon, May 04, 2015 at 04:42:22PM +0300, Denis V. Lunev wrote: The difference is quite reliable and the

Re: [Qemu-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-05-12 Thread Fabio Fantoni
Il 12/05/2015 11:23, Fabio Fantoni ha scritto: Il 11/05/2015 17:04, Fabio Fantoni ha scritto: Il 21/04/2015 14:53, Stefano Stabellini ha scritto: On Tue, 21 Apr 2015, Fabio Fantoni wrote: Il 21/04/2015 12:49, Stefano Stabellini ha scritto: On Mon, 20 Apr 2015, Fabio Fantoni wrote: I updated x

Re: [Qemu-devel] [PATCH 2/2] block: align bounce buffers to page

2015-05-12 Thread Kevin Wolf
Am 12.05.2015 um 07:47 hat Denis V. Lunev geschrieben: > The following sequence > int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644); > for (i = 0; i < 10; i++) > write(fd, buf, 4096); > performs 5% better if buf is aligned to 4096 bytes. > > The difference is quite

Re: [Qemu-devel] [PATCH 1/2] block: minimal bounce buffer alignment

2015-05-12 Thread Kevin Wolf
Am 12.05.2015 um 07:47 hat Denis V. Lunev geschrieben: > The patch introduces new concept: minimal memory alignment for bounce > buffers. Original so called "optimal" value is actually minimal required > value for aligment. It should be used for validation that the IOVec > is properly aligned and b

Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu

2015-05-12 Thread Gerd Hoffmann
Hi, > We *could* do it that way, but it wouldn't look pretty. Instead of having > these menu items: > > VGA, Monitor, Serial, Parallel > > We would have these menu items: > > VGA > compat_monitor0 > serial0 > parallel0 > > They look very anti-pretty. Those (except VGA) come from the charde

Re: [Qemu-devel] [PULL 0/9] Net patches

2015-05-12 Thread Peter Maydell
On 11 May 2015 at 16:26, Stefan Hajnoczi wrote: > The following changes since commit b951cda21d6b232f138ccf008e12bce8ddc95465: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2015-05-11 12:01:09 +0100) > > are available in the git repository at: > > git://

Re: [Qemu-devel] [PULL 00/14] Ide patches

2015-05-12 Thread Peter Maydell
On 11 May 2015 at 19:12, John Snow wrote: > The following changes since commit 9ad2c8cd41a086020e21aa6d616b73bd5e2a800b: > > Merge remote-tracking branch > 'remotes/mjt/tags/pull-trivial-patches-2015-05-09' into staging (2015-05-11 > 13:54:00 +0100) > > are available in the git repository at:

Re: [Qemu-devel] [Qemu-block] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign

2015-05-12 Thread Paolo Bonzini
On 12/05/2015 12:19, Denis V. Lunev wrote: > > > hades /vol $ strace -f -e pwrite -e raw=write,pwrite qemu-io -n -c > "write -P 0x11 0 64M" ./1.img > Process 19326 attached > [pid 19326] pwrite(0x6, 0x7fac07fff200, 0x400, 0x5) = 0x400 > < 1 GB Write from userspace FWIW this is

Re: [Qemu-devel] [PATCH 2/2] block: align bounce buffers to page

2015-05-12 Thread Paolo Bonzini
On 12/05/2015 12:27, Kevin Wolf wrote: > I think it would make more sense to keep this specific to the raw-posix > driver. After all, it's only the kernel page cache that we optimise > here. Other backends probably don't take advantage of page alignment. I don't think it makes sense to keep it r

Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 11:56, Chen Gang wrote: > Welcome any other members' ideas, suggestions or completions for it. > > If one of another members also suggests to drop all uint8_t and uint16_t, > I shall drop them (more explanations for dropping them will be better). I agree with Richard on this one

[Qemu-devel] [PULL 00/19] target-arm queue

2015-05-12 Thread Peter Maydell
git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20150512 for you to fetch changes up to 5ae79fe825bedc89db8b6bde9d0ed0bb5d59558c: hw/arm/highbank.c: Wire FIQ between CPU <> GIC (2015-05-12 11:57:19 +0100) -

Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using

2015-05-12 Thread Chen Gang
Welcome any other members' ideas, suggestions or completions for it. If one of another members also suggests to drop all uint8_t and uint16_t, I shall drop them (more explanations for dropping them will be better). Thanks. On 05/12/2015 08:43 AM, gchen gchen wrote: > For me, I still stick to u

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Pavel Fedin
Hello! > We are not. Support for GICv2 vs v3 should be dealt with > by suitable machine properties I don't remember whether i clearly wrote about it... First i added a property, like -machine virt,gicv3=on. But then i decided to stick back to different machine name because libvirt does not ha

Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using

2015-05-12 Thread Chen Gang
On 05/12/2015 07:08 PM, Peter Maydell wrote: > On 12 May 2015 at 11:56, Chen Gang wrote: >> Welcome any other members' ideas, suggestions or completions for it. >> >> If one of another members also suggests to drop all uint8_t and uint16_t, >> I shall drop them (more explanations for dropping them

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Daniel P. Berrange
On Tue, May 12, 2015 at 02:15:46PM +0300, Pavel Fedin wrote: > Hello! > > > We are not. Support for GICv2 vs v3 should be dealt with > > by suitable machine properties > > I don't remember whether i clearly wrote about it... First i added a > property, like -machine virt,gicv3=on. But then i de

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Shlomo Pongratz
> -Original Message- > From: Pavel Fedin [mailto:p.fe...@samsung.com] > Sent: Tuesday, 12 May, 2015 12:06 PM > To: Shlomo Pongratz; qemu-devel@nongnu.org > Subject: RE: [PATCH v2] Add virt-v3 machine that uses GIC-500 > > Hello! > > > I just pulled last git and git am-ed your patch on-to

Re: [Qemu-devel] KVM call for agenda 2015-05-12

2015-05-12 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. No topics, no call. Have a good day. Thanks, Juan. > > > Call details: > > By popular demand, a google calendar public entry with it > > > https://www.google.com/calendar/embed?src=dG9iMXRqcXAzN3Y4ZX

[Qemu-devel] [PATCH v3 0/6] block: Mirror discarded sectors

2015-05-12 Thread Fam Zheng
v3: Add John's rev-by in patches 3~6. Rewrite patch 1: discard may not suffice, use write zeroes in that case. v2: Fix typo and add Eric's rev-by in patch 3. Add patch 1 to discard target in mirror job. (Paolo) Add patch 6 to improve iotests.wait_ready. (John) This fixes the mirror as

[Qemu-devel] [PATCH v3 2/6] block: Fix dirty bitmap in bdrv_co_discard

2015-05-12 Thread Fam Zheng
Unsetting dirty globally with discard is not very correct. The discard may zero out sectors (depending on can_write_zeroes_with_unmap), we should replicate this change to destinition side to make sure that the guest sees the same data. Calling bdrv_reset_dirty also troubles mirror job because the

[Qemu-devel] [PATCH v3 1/6] mirror: Do zero write on target if sectors not allocated

2015-05-12 Thread Fam Zheng
If guest discards a source cluster during mirror, we would want to skip the read-write steps. Source and target may have different "can_write_zeroes_with_unmap" values and different discard granularity. It's important to replicate the exact zeroing on the destination, so bdrv_aio_discard is only s

[Qemu-devel] [PATCH v3 3/6] block: Remove bdrv_reset_dirty

2015-05-12 Thread Fam Zheng
Using this function would always be wrong because a dirty bitmap must have a specific owner that consumes the dirty bits and calls bdrv_reset_dirty_bitmap(). Remove the unused function to avoid future misuse. Reviewed-by: Eric Blake Signed-off-by: Fam Zheng Reviewed-by: John Snow --- block.c

[Qemu-devel] [PATCH v3 5/6] qemu-iotests: Add test case for mirror with unmap

2015-05-12 Thread Fam Zheng
This checks that the discard on mirror source that effectively zeroes data is also reflected by the data of target. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- tests/qemu-iotests/131 | 59 ++ tests/qemu-iotests/131.out | 5 tests/qem

[Qemu-devel] [PATCH v3 4/6] qemu-iotests: Make block job methods common

2015-05-12 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: John Snow --- tests/qemu-iotests/041| 66 ++- tests/qemu-iotests/iotests.py | 28 ++ 2 files changed, 43 insertions(+), 51 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/

[Qemu-devel] [PATCH v3 6/6] iotests: Use event_wait in wait_ready

2015-05-12 Thread Fam Zheng
Only poll the specific type of event we are interested in, to avoid stealing events that should be consumed by someone else. Suggested-by: John Snow Signed-off-by: Fam Zheng Reviewed-by: John Snow --- tests/qemu-iotests/iotests.py | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-)

Re: [Qemu-devel] [PATCH v6 1/3] Revert "block: Fix unaligned zero write"

2015-05-12 Thread Kevin Wolf
Am 12.05.2015 um 08:09 hat Fam Zheng geschrieben: > This reverts commit fc3959e4669a1c2149b91ccb05101cfc7ae1fc05. > > The core write code already handles the case, so remove this > duplication. > > Because commit 61007b316 moved the touched code from block.c to > block/io.c, the change is manuall

Re: [Qemu-devel] [PATCH v6 2/3] block: Fix NULL deference for unaligned write if qiov is NULL

2015-05-12 Thread Kevin Wolf
Am 12.05.2015 um 08:09 hat Fam Zheng geschrieben: > For zero write, callers pass in NULL qiov (qemu-io "write -z" or > scsi-disk "write same"). > > Commit fc3959e466 fixed bdrv_co_write_zeroes which is the common case > for this bug, but it still exists in bdrv_aio_write_zeroes. A simpler > fix wo

Re: [Qemu-devel] [PATCH v6 3/3] qemu-iotests: Test unaligned sub-block zero write

2015-05-12 Thread Kevin Wolf
Am 12.05.2015 um 08:09 hat Fam Zheng geschrieben: > Test zero write in byte range 512~1024 for 4k alignment. > > Signed-off-by: Fam Zheng > Reviewed-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf

[Qemu-devel] [PATCH 00/15] net: Improve error reporting

2015-05-12 Thread Markus Armbruster
Markus Armbruster (15): net: Improve error message for -net hubport a bit net: Permit incremental conversion of init functions to Error net: Improve -net nic error reporting net/dump: Improve -net/host_net_add dump error reporting tap: net_tap_fd_init() can't fail, drop dead error handlin

[Qemu-devel] [PATCH 04/15] net/dump: Improve -net/host_net_add dump error reporting

2015-05-12 Thread Markus Armbruster
When -net dump fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -net dump,id=foo,file=/eperm qemu-system-x86_64: -net dump,id=foo,file=/eperm: -net dump: can't open /eperm qemu-system-x86_64: -net dump,id=foo,file=/eperm: Device 'dump' coul

[Qemu-devel] [PATCH 03/15] net: Improve -net nic error reporting

2015-05-12 Thread Markus Armbruster
When -net nic fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -net nic,netdev=nonexistant qemu-system-x86_64: -net nic,netdev=nonexistant: netdev 'nonexistant' not found qemu-system-x86_64: -net nic,netdev=nonexistant: Device 'nic' could n

[Qemu-devel] [PATCH 05/15] tap: net_tap_fd_init() can't fail, drop dead error handling

2015-05-12 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- net/tap.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/net/tap.c b/net/tap.c index 8f06cb7..adb1022 100644 --- a/net/tap.c +++ b/net/tap.c @@ -536,7 +536,6 @@ int net_init_bridge(const NetClientOptions *opts, const char *

[Qemu-devel] [PATCH 11/15] tap-linux: Convert tap_open() to Error

2015-05-12 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- net/tap-linux.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/net/tap-linux.c b/net/tap-linux.c index be18382..6c3caef 100644 --- a/net/tap-linux.c +++ b/net/tap-linux.c @@ -39,7 +39,6 @@ int tap_open(char *ifname, int

[Qemu-devel] [PATCH 07/15] tap: Convert tap_set_sndbuf() to Error

2015-05-12 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- net/tap-aix.c | 3 +-- net/tap-bsd.c | 3 +-- net/tap-haiku.c | 3 +-- net/tap-linux.c | 6 ++ net/tap-solaris.c | 3 +-- net/tap.c | 4 +++- net/tap_int.h | 2 +- 7 files changed, 10 insertions(+), 14 deletions(-) diff --git a/net

[Qemu-devel] [PATCH 06/15] tap: Improve -netdev/netdev_add/-net/... bridge error reporting

2015-05-12 Thread Markus Armbruster
When -netdev bridge fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -netdev bridge,id=foo failed to launch bridge helper qemu-system-x86_64: -netdev bridge,id=foo: Device 'bridge' could not be initialized The first message goes to stderr.

[Qemu-devel] [PATCH 01/15] net: Improve error message for -net hubport a bit

2015-05-12 Thread Markus Armbruster
Type "hubport" is valid only with -netdev. Unfortunately, that's detected late and the error message doesn't explain why: $ qemu-system-i386 -net hubport,id=foo,hubid=0 qemu-system-i386: -net hubport,id=foo,hubid=0: Device 'hubport' could not be initialized Improve the error message to

[Qemu-devel] [PATCH 10/15] tap: Permit incremental conversion of tap_open() to Error

2015-05-12 Thread Markus Armbruster
Convert the trivial ones immediately: tap-aix and tap-haiku. Signed-off-by: Markus Armbruster --- net/tap-aix.c | 4 ++-- net/tap-bsd.c | 6 -- net/tap-haiku.c | 4 ++-- net/tap-linux.c | 3 ++- net/tap-solaris.c | 3 ++- net/tap.c | 13 + net/tap_int.h

[Qemu-devel] [PATCH 09/15] tap: Convert launch_script() to Error

2015-05-12 Thread Markus Armbruster
Fixes inappropriate use of stderr in monitor command handler. While there, improve the messages some. Signed-off-by: Markus Armbruster --- net/tap.c | 40 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/net/tap.c b/net/tap.c index d1f5644

[Qemu-devel] [PATCH 02/15] net: Permit incremental conversion of init functions to Error

2015-05-12 Thread Markus Armbruster
Error reporting for netdev_add is broken: the net_client_init_fun[] report the actual errors with (at best) error_report(), and their caller net_client_init1() makes up a generic error on top. For command line and HMP, this produces an mildly ugly error cascande. In QMP, the actual errors go to s

[Qemu-devel] [PATCH 13/15] tap-solaris: Convert tap_open() to Error

2015-05-12 Thread Markus Armbruster
Fixes inappropriate use of syslog(). Not fixed: leaks on error paths, suspicious non-fatal errors. FIXMEs added instead. Signed-off-by: Markus Armbruster --- net/tap-solaris.c | 59 --- 1 file changed, 30 insertions(+), 29 deletions(-) diff

[Qemu-devel] [PATCH 12/15] tap-bsd: Convert tap_open() to Error

2015-05-12 Thread Markus Armbruster
Fixes inappropriate use of stderr in monitor command handler. While there, improve some of the messages a bit. Signed-off-by: Markus Armbruster --- net/tap-bsd.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/net/tap-bsd.c b/net/tap-bsd.c

[Qemu-devel] [PATCH 14/15] tap: Finish conversion of tap_open() to Error

2015-05-12 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- net/tap.c | 4 1 file changed, 4 deletions(-) diff --git a/net/tap.c b/net/tap.c index 348b786..f7db9dc 100644 --- a/net/tap.c +++ b/net/tap.c @@ -597,10 +597,6 @@ static int net_tap_init(const NetdevTapOptions *tap, int *vnet_hdr, TFR(fd = tap_ope

[Qemu-devel] [PATCH 15/15] tap: Improve -netdev/netdev_add/-net/... tap error reporting

2015-05-12 Thread Markus Armbruster
When -netdev tap fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -netdev tap,id=foo qemu-system-x86_64: -netdev tap,id=foo: could not configure /dev/net/tun: Operation not permitted qemu-system-x86_64: -netdev tap,id=foo: Device 'tap' coul

[Qemu-devel] [PATCH 1/1] docs: document how to configure the qcow2 L2/refcount caches

2015-05-12 Thread Alberto Garcia
QEMU has options to configure the size of the L2 and refcount caches for the qcow2 format. However, choosing the right sizes for a particular disk image is not a straightforward operation since the ratio between the cache size and the allocated disk space is not obvious and depends on the size of t

[Qemu-devel] [PATCH 08/15] tap: Convert net_init_tap_one() to Error

2015-05-12 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- net/tap.c | 70 ++- 1 file changed, 38 insertions(+), 32 deletions(-) diff --git a/net/tap.c b/net/tap.c index d54222d..d1f5644 100644 --- a/net/tap.c +++ b/net/tap.c @@ -600,11 +600,11 @@ static int

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] block: align bounce buffers to page

2015-05-12 Thread Denis V. Lunev
On 12/05/15 13:27, Kevin Wolf wrote: Am 12.05.2015 um 07:47 hat Denis V. Lunev geschrieben: The following sequence int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644); for (i = 0; i < 10; i++) write(fd, buf, 4096); performs 5% better if buf is aligned to 4096 byt

[Qemu-devel] [PATCH v2 0/1] Document how to configure the qcow2 L2/refcount caches

2015-05-12 Thread Alberto Garcia
Kevin applied all other patches from this series, so this is the only one left. Thanks to Max for all the feedback. v2: - Add copyright notice - Document refcount_bits and its effects v1: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01891.html Regards, Berto Alberto Garcia (1):

Re: [Qemu-devel] [PATCH v6 2/3] block: Fix NULL deference for unaligned write if qiov is NULL

2015-05-12 Thread Stefan Hajnoczi
On Tue, May 12, 2015 at 02:09:31PM +0800, Fam Zheng wrote: > +static int coroutine_fn bdrv_co_do_zero_pwritev(BlockDriverState *bs, > +int64_t offset, > +unsigned int bytes, > +

[Qemu-devel] [PATCH] linux-user: fix support for timerfd_create on arm

2015-05-12 Thread Andreas Schwab
On arm the original timerfd syscall was reused for the new timerfd_create syscall. Signed-off-by: Andreas Schwab --- linux-user/arm/syscall_nr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/arm/syscall_nr.h b/linux-user/arm/syscall_nr.h index 7d7be7c..53552be 10

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-12 Thread Pavel Fedin
Hello! > BTW did you try going beyond 16 cores I had problems with 32 and 64 cores. Just tried it. Works fine, except qemu takes incredibly long time to start up with so many cores. 64 cores took something like 2 minutes. Indeed, looks like freeze, but if you're patient enough, you'll see it

Re: [Qemu-devel] [ARM]: Adding support for Cortex-M4

2015-05-12 Thread aurelio remonda
Im using lm3s6965evb stellaris board, trying to make it "work as an M4", i would like to separate them, adding an dsp feature (i.e ARM_FEATURE_DSP) could work? the problem is if this feature is added it has to be set on all the cpus that use dsp instructions.

Re: [Qemu-devel] [RFC v4] monitor: add memory search commands s, sp

2015-05-12 Thread Luiz Capitulino
On Fri, 24 Apr 2015 14:39:48 +0200 hw.clau...@gmail.com wrote: > From: Claudio Fontana > > usage is similar to the commands x, xp. > > Example with string: looking for "ELF" header in memory: > > (qemu) s/100cb 0x40001000 "ELF" > searching memory area [40001000-400f5240] >

Re: [Qemu-devel] [ARM]: Adding support for Cortex-M4

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 13:46, aurelio remonda wrote: > Im using lm3s6965evb stellaris board, trying to make it "work as an M4", i > would like to separate them, adding an dsp feature (i.e ARM_FEATURE_DSP) > could work? the problem is if this feature is added it has to be set on all > the cpus that use

[Qemu-devel] [PATCH] ui: use libexpoxy

2015-05-12 Thread Gerd Hoffmann
libepoxy does the opengl extension handling for us. It also is helpful for trouble-shooting as it prints nice error messages instead of silently failing or segfaulting in case we do something wrong, like using gl commands not supported by the current context. Signed-off-by: Gerd Hoffmann --- co

Re: [Qemu-devel] [v8 13/14] migration: Add qmp commands to set and query parameters

2015-05-12 Thread Li, Liang Z
> > * Liang Li (liang.z...@intel.com) wrote: > > Add the qmp commands to tune and query the parameters used in live > > migration. > > Hi, > Do you know if there's anyone working on libvirt code to drive this > interface > and turn on your compression code? > Yes, I have confirmed that one

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] block: align bounce buffers to page

2015-05-12 Thread Kevin Wolf
Am 12.05.2015 um 12:36 hat Denis V. Lunev geschrieben: > On 12/05/15 13:27, Kevin Wolf wrote: > >Am 12.05.2015 um 07:47 hat Denis V. Lunev geschrieben: > >>The following sequence > >> int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644); > >> for (i = 0; i < 10; i++) > >>

Re: [Qemu-devel] [PATCH] ui: use libexpoxy

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 14:04, Gerd Hoffmann wrote: > libepoxy does the opengl extension handling for us. > > It also is helpful for trouble-shooting as it prints nice error messages > instead of silently failing or segfaulting in case we do something > wrong, like using gl commands not supported by the

Re: [Qemu-devel] [PULL 00/19] target-arm queue

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 12:03, Peter Maydell wrote: > > v2 of the pull, fixing a silly compile failure on ARM hosts. > > target-arm queue: > * Support TZ and grouping in the GIC > * hw/sd: sd_reset cleanup > * armv7m_nvic: fix bug in sy

Re: [Qemu-devel] [PATCHv3 2/2] stubs: Provide parallel_mm_init stub version

2015-05-12 Thread Paolo Bonzini
On 12/05/2015 08:22, mreza...@redhat.com wrote: > From: Miroslav Rezanina > > mips build fail with link error in case PARALLEL_CONFIG is disabled as > hw/mips/mips_jazz.c calls parallel_mm_init. Due to dependecies to content > of parallel.c we can't simply move it to hw/isa/isa-devices.c. > >

Re: [Qemu-devel] [PATCH RFC 4/7] vhost: set vring endianness for legacy virtio

2015-05-12 Thread Cornelia Huck
On Wed, 06 May 2015 14:08:02 +0200 Greg Kurz wrote: > Legacy virtio is native endian: if the guest and host endianness differ, > we have to tell vhost so it can swap bytes where appropriate. This is > done through a vhost ring ioctl. > > Signed-off-by: Greg Kurz > --- > hw/virtio/vhost.c | 5

  1   2   3   >