On Fri, May 08, 2015 at 04:09:01PM +0300, Pavel Fedin wrote:
> I would like to offer this, slightly improved implementation. The key thing
> is a new
> kernel_irqchip_type member in Machine class. Currently it it used only by
> virt machine for
> its internal purposes, however in future it is to be passed to KVM in
> kvm_irqchip_create(). The variable is defined as int in order to be
> architecture agnostic,
> for potential future users.
>
> Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
> ---
> hw/arm/virt.c | 155
> +++++++++++++++++++++++++++++++++++++++++++---------
> include/hw/boards.h | 1 +
> 2 files changed, 130 insertions(+), 26 deletions(-)
> +#define TYPE_VIRTV3_MACHINE "virt-v3"
[snip]
> +static const TypeInfo machvirtv3_info = {
> + .name = TYPE_VIRTV3_MACHINE,
> + .parent = TYPE_VIRT_MACHINE,
> + .instance_size = sizeof(VirtMachineState),
> + .instance_init = virtv3_instance_init,
> + .class_size = sizeof(VirtMachineClass),
> + .class_init = virtv3_class_init,
> +};
> +
> static void machvirt_machine_init(void)
> {
> type_register_static(&machvirt_info);
> + type_register_static(&machvirtv3_info);
> }
If we're going to start adding new machine types for aarch64 with
version numbers, then I think we should we be using a versioning
scheme that matches what we do on x86. ie, define versioned
machine types based on the QEMU release numbers
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
