Re: [Qemu-devel] [RFC PATCH 00/15] spapr: add support for PHB hotplug

2015-04-30 Thread Paolo Bonzini
On 29/04/2015 21:20, Michael Roth wrote: > These patches are based on latest spapr-hotplug-pci patches, and > can also be obtained from: > > https://github.com/mdroth/qemu/commits/spapr-hotplug-phb > > These patches implement support for hotplug/unplug of PCI host-bridges. > The main use case

Re: [Qemu-devel] PCI on ARM virt machine - status ?

2015-04-30 Thread Eric Auger
On 04/29/2015 02:38 PM, Pavel Fedin wrote: > Hello! > I would like to ask, what is the status of > http://www.spinics.net/lists/kvm-arm/msg14466.html and > http://www.spinics.net/lists/kvm-arm/msg14284.html ? > I do not see this committed, but i would like to say that i have tested > this, and t

Re: [Qemu-devel] [PULL 00/10] first pile of s390x patches for 2.4

2015-04-30 Thread Peter Maydell
150428.0' > into staging (2015-04-28 18:58:15 +0100) > > are available in the git repository at: > > git://github.com/cohuck/qemu tags/s390x-20150430 > > for you to fetch changes up to 2c80e996e427ae31982f3405a762859578a6261d: > > kvm: better a

Re: [Qemu-devel] PCI on ARM virt machine - status ?

2015-04-30 Thread Pavel Fedin
Hello! > thanks for your inputs. I think both series are up-to-date wrt last > comments. So is it going to be included in the next release ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia

Re: [Qemu-devel] [PATCH v4 0/7] aio: Support epoll by introducing qemu_poll abstraction

2015-04-30 Thread Kevin Wolf
Am 29.04.2015 um 05:24 hat Fam Zheng geschrieben: > v4: Rebase to 2.3 and rerun tests. timerfd+epoll shows clear improvement over > current master when the virtio-console device attaches more fds to the > main > loop: > > syscall high # of fd low # of fd > --

[Qemu-devel] [PATCH v3 1/2] qga/commands-posix: Fix bug in guest-fstrim

2015-04-30 Thread Justin Ossevoort
The FITRIM ioctl updates the fstrim_range structure it receives. This way the caller can determine how many bytes were trimmed. The guest-fstrim logic reuses the same fstrim_range for each filesystem, effectively limiting each filesystem to trim at most as much as the previous was able to trim. If

[Qemu-devel] [PATCH v3 2/2] qga/commands-posix: Return per path fstrim result

2015-04-30 Thread Justin Ossevoort
The current guest-fstrim support only returns an error if some mountpoint was unable to be trimmed, skipping any possible additional mountpoints. The result of the TRIM operation itself is also discarded. This change returns a per mountpoint result of the TRIM operation. If an error occurs on some

[Qemu-devel] [PATCH v3 0/2] Fix guest-fstrim behaviour

2015-04-30 Thread Justin Ossevoort
The qemu-ga 'guest-fstrim' command is currently not working properly. There are 2 issues: - The current implementation reuses a struct between ioctl() calls without reinitialising it's fields. This struct however is updated to reflect the result of the trim operation. Therefor only the first

[Qemu-devel] [PATCH 5/7] qom: make enum string tables const-correct

2015-04-30 Thread Daniel P. Berrange
The enum string table parameters in various QOM/QAPI methods are declared 'const char *strings[]'. This results in const warnings if passed a variable that was declared as static const char * const strings[] = { }; Add the extra const annotation to the parameters, since neither the string

[Qemu-devel] [PATCH 2/7] qom: document user creatable object types in help text

2015-04-30 Thread Daniel P. Berrange
The QEMU help for -object is essentially useless, just giving users the generic syntax. Move it down into its own section and introduce a nested table where each user creatable object can be documented. The existing memory-backend-file, rng-random and rng-egd object types are documented. Signed-of

[Qemu-devel] [PATCH 0/7] qom: misc fixes & enhancements to support TLS work

2015-04-30 Thread Daniel P. Berrange
This series contains the 7 generic QOM API fixes and enhancements that I previously posted as part of the large series refactoring and extending the TLS support in QEMU: https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg02038.html I'm sending it separately, since the patches are reasonab

[Qemu-devel] [PATCH 1/7] qom: fix typename of 'policy' enum property in hostmem obj

2015-04-30 Thread Daniel P. Berrange
The 'policy' property was being registered with a typename of 'str', but it is in fact an enum of the 'HostMemPolicy' type. Signed-off-by: Daniel P. Berrange --- backends/hostmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/hostmem.c b/backends/hostmem.c index b

[Qemu-devel] [PATCH 4/7] qom: add object_new_propv / object_new_proplist constructors

2015-04-30 Thread Daniel P. Berrange
It is reasonably common to want to create an object, set a number of properties, register it in the hierarchy and then mark it as complete (if a user creatable type). This requires quite a lot of error prone, verbose, boilerplate code to achieve. The object_new_propv / object_new_proplist construc

[Qemu-devel] [PATCH 7/7] qom: don't pass string table to object_get_enum method

2015-04-30 Thread Daniel P. Berrange
Now that properties can be explicitly registered as an enum type, there is no need to pass the string table to the object_get_enum method. The object property registration already has a pointer to the string table. In changing this method signature, the hostmem backend object has to be converted t

[Qemu-devel] [PATCH 3/7] qom: create objects in two phases

2015-04-30 Thread Daniel P. Berrange
Some types of object must be created before chardevs, other types of object must be created after chardevs. As such there is no option but to create objects in two phases. This takes the decision to create as many object types as possible in the first phase, and only delay those which have a depen

[Qemu-devel] [PATCH 6/7] qom: add a object_property_add_enum helper method

2015-04-30 Thread Daniel P. Berrange
A QOM property can be parsed as enum using the visit_type_enum() helper method, but this forces callers to use the more complex generic object_property_add() method when registering it. It also requires that users of that object have access to the string map when they want to read the property valu

Re: [Qemu-devel] [PATCH v3 1/2] qga/commands-posix: Fix bug in guest-fstrim

2015-04-30 Thread Thomas Huth
On Thu, 30 Apr 2015 16:29:57 +0200 Justin Ossevoort wrote: > The FITRIM ioctl updates the fstrim_range structure it receives. This > way the caller can determine how many bytes were trimmed. The > guest-fstrim logic reuses the same fstrim_range for each filesystem, > effectively limiting each fil

Re: [Qemu-devel] [PATCH 4/7] qom: add object_new_propv / object_new_proplist constructors

2015-04-30 Thread Paolo Bonzini
On 30/04/2015 16:42, Daniel P. Berrange wrote: > + * object_new_propv: > + * @typename: The name of the type of the object to instantiate. > + * @path: the object path to register under > + * @id: The unique ID of the object > + * @errp: pointer to error object > + * @...: list of property names

Re: [Qemu-devel] [PATCH 4/7] qom: add object_new_propv / object_new_proplist constructors

2015-04-30 Thread Daniel P. Berrange
On Thu, Apr 30, 2015 at 04:53:27PM +0200, Paolo Bonzini wrote: > > > On 30/04/2015 16:42, Daniel P. Berrange wrote: > > + * object_new_propv: > > + * @typename: The name of the type of the object to instantiate. > > + * @path: the object path to register under > > + * @id: The unique ID of the o

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-30 Thread Stefan Hajnoczi
On Wed, Apr 29, 2015 at 04:37:49PM +0800, Gonglei wrote: > On 2015/4/29 16:29, Paolo Bonzini wrote: > > > > > > On 27/04/2015 11:37, Stefan Hajnoczi wrote: > But it's only for the failover case. Quorum (or a new > block/colo.c driver or filter) is fine for normal colo > operatio

Re: [Qemu-devel] [PATCH 4/7] qom: add object_new_propv / object_new_proplist constructors

2015-04-30 Thread Paolo Bonzini
On 30/04/2015 16:42, Daniel P. Berrange wrote: > +propname = va_arg(vargs, char *); > +while (propname != NULL) { > +const char *value = va_arg(vargs, char *); > + > +g_assert(value != NULL); > +object_property_parse(obj, value, propname, errp); > +if (*err

Re: [Qemu-devel] [PATCH 4/7] qom: add object_new_propv / object_new_proplist constructors

2015-04-30 Thread Daniel P. Berrange
On Thu, Apr 30, 2015 at 05:00:28PM +0200, Paolo Bonzini wrote: > > > On 30/04/2015 16:42, Daniel P. Berrange wrote: > > +propname = va_arg(vargs, char *); > > +while (propname != NULL) { > > +const char *value = va_arg(vargs, char *); > > + > > +g_assert(value != NULL); >

Re: [Qemu-devel] [PATCH 1/6] qcow2: use one single memory block for the L2/refcount cache tables

2015-04-30 Thread Eric Blake
On 04/30/2015 04:11 AM, Alberto Garcia wrote: > The qcow2 L2/refcount cache contains one separate table for each cache > entry. Doing one allocation per table adds unnecessary overhead and it > also requires us to store the address of each table separately. > > Since the size of the cache is const

Re: [Qemu-devel] [PATCH v4 6/7] vmport: Add VMware all ring hack

2015-04-30 Thread Don Slutz
On 04/30/15 09:54, Paolo Bonzini wrote: > On 30/04/2015 15:32, Don Slutz wrote: >> This is done by adding a new machine property vmware-port-ring3 that >> needs to be enabled to have any effect. It only effects accel=tcg >> mode. It is needed if you want to use VMware tools in accel=tcg >> mode.

Re: [Qemu-devel] [PATCH v4 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-04-30 Thread Don Slutz
On 04/30/15 09:55, Paolo Bonzini wrote: > > > On 30/04/2015 15:32, Don Slutz wrote: >> +#ifdef VMPORT_SHORT >> +info->value->key = g_strdup(ckey); >> +#else >> +info->value->key = g_strdup_printf("guestinfo.%s", ckey); >> +#endif > > What is VMPORT_SHORT for? > Simpler code. Looks lik

Re: [Qemu-devel] [PATCH v4 6/7] vmport: Add VMware all ring hack

2015-04-30 Thread Paolo Bonzini
On 30/04/2015 17:15, Don Slutz wrote: > That is a possibility. It did not look simple to access CPUX86State > where I needed to check HF2_VMPORT_HACK_MASK. Instead of the > save/restore I could add it both places. Why not? This: @@ -2566,6 +2566,12 @@ static inline void check_io(CPUX86State

Re: [Qemu-devel] [PATCH v4 6/7] vmport: Add VMware all ring hack

2015-04-30 Thread Paolo Bonzini
On 30/04/2015 17:15, Don Slutz wrote: >>> This is done by adding a new machine property vmware-port-ring3 that >>> needs to be enabled to have any effect. It only effects accel=tcg >>> mode. It is needed if you want to use VMware tools in accel=tcg >>> mode. >> >> How does it work on KVM or Xe

Re: [Qemu-devel] [RFC PATCH v11 00/23] Deterministic replay core

2015-04-30 Thread Paolo Bonzini
On 27/04/2015 09:32, Pavel Dovgalyuk wrote: > This set of patches is related to the reverse execution and deterministic > replay of qemu execution. This implementation of deterministic replay can > be used for deterministic debugging of guest code through gdb remote > interface. > > These patche

Re: [Qemu-devel] Question about block driver

2015-04-30 Thread Stefan Hajnoczi
On Thu, Apr 30, 2015 at 11:52:01AM +0200, Kevin Wolf wrote: > Am 30.04.2015 um 11:43 hat Wen Congyang geschrieben: > > On 04/30/2015 05:33 PM, Kevin Wolf wrote: > > > [Cc: qemu-block] > > > > > > Am 30.04.2015 um 11:11 hat Wen Congyang geschrieben: > > >> Some drivers use bdrv_open, while the othe

[Qemu-devel] [PATCH v2 3/7] qom: create objects in two phases

2015-04-30 Thread Daniel P. Berrange
Some types of object must be created before chardevs, other types of object must be created after chardevs. As such there is no option but to create objects in two phases. This takes the decision to create as many object types as possible in the first phase, and only delay those which have a depen

[Qemu-devel] [PATCH v2 1/7] qom: fix typename of 'policy' enum property in hostmem obj

2015-04-30 Thread Daniel P. Berrange
The 'policy' property was being registered with a typename of 'str', but it is in fact an enum of the 'HostMemPolicy' type. Signed-off-by: Daniel P. Berrange --- backends/hostmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/hostmem.c b/backends/hostmem.c index b

[Qemu-devel] [PATCH v2 2/7] qom: document user creatable object types in help text

2015-04-30 Thread Daniel P. Berrange
The QEMU help for -object is essentially useless, just giving users the generic syntax. Move it down into its own section and introduce a nested table where each user creatable object can be documented. The existing memory-backend-file, rng-random and rng-egd object types are documented. Signed-of

[Qemu-devel] [PATCH v2 4/7] qom: add object_new_propv / object_new_proplist constructors

2015-04-30 Thread Daniel P. Berrange
It is reasonably common to want to create an object, set a number of properties, register it in the hierarchy and then mark it as complete (if a user creatable type). This requires quite a lot of error prone, verbose, boilerplate code to achieve. The object_new_propv / object_new_proplist construc

[Qemu-devel] [PATCH v2 5/7] qom: make enum string tables const-correct

2015-04-30 Thread Daniel P. Berrange
The enum string table parameters in various QOM/QAPI methods are declared 'const char *strings[]'. This results in const warnings if passed a variable that was declared as static const char * const strings[] = { }; Add the extra const annotation to the parameters, since neither the string

[Qemu-devel] [PATCH v2 0/7] qom: misc fixes & enhancements to support TLS work

2015-04-30 Thread Daniel P. Berrange
This series contains the 7 generic QOM API fixes and enhancements that I previously posted as part of the large series refactoring and extending the TLS support in QEMU: https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg02038.html I'm sending it separately, since the patches are reasonab

[Qemu-devel] [PATCH v2 6/7] qom: add a object_property_add_enum helper method

2015-04-30 Thread Daniel P. Berrange
A QOM property can be parsed as enum using the visit_type_enum() helper method, but this forces callers to use the more complex generic object_property_add() method when registering it. It also requires that users of that object have access to the string map when they want to read the property valu

[Qemu-devel] [PATCH v2 7/7] qom: don't pass string table to object_get_enum method

2015-04-30 Thread Daniel P. Berrange
Now that properties can be explicitly registered as an enum type, there is no need to pass the string table to the object_get_enum method. The object property registration already has a pointer to the string table. In changing this method signature, the hostmem backend object has to be converted t

[Qemu-devel] Fwd: qemu drive mirror assert fault

2015-04-30 Thread Paolo Bonzini
John, Fam, I got this report offlist. This happens if a bit in the hbitmap is cleared and the HBitmap has _not_ yet reached the bit. See this comment in include/qemu/hbitmap.h: * Resetting bits before the current * position of the iterator is also okay. However, concurrent * resetting of bi

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-30 Thread Christian Borntraeger
Am 29.04.2015 um 22:19 schrieb Michael S. Tsirkin: [...] >> >> This commit made it work. >> >> commit 7a11370e5e6c26566904bb7f08281093a3002ff2 >> Author: Michael S. Tsirkin >> Date: Wed Oct 15 10:22:30 2014 +1030 >> >> virtio_blk: enable VQs early >> >> virtio spec requires drivers

Re: [Qemu-devel] Fwd: qemu drive mirror assert fault

2015-04-30 Thread Paolo Bonzini
On 30/04/2015 17:50, Paolo Bonzini wrote: > John, Fam, > > I got this report offlist. This happens if a bit in the hbitmap is > cleared and the HBitmap has _not_ yet reached the bit. See this comment > in include/qemu/hbitmap.h: > > * Resetting bits before the current > * position of the it

[Qemu-devel] I can't find qemu developer e-mail,address.

2015-04-30 Thread IdleTime
Hi I can't find qemu developer e-mail address. I made Chrome version of QEMU. Its name PNaCL QEMU. http://idletime.s601.xrea.com/web/qemu/ Only still "qemu-system-i386" This is sandbox and disable network, but very safety. Source code is written in the above URL. If you can't read japanese, yo

[Qemu-devel] [Bug 1395217] Re: Networking in qemu 2.0.0 and beyond is not compatible with Open Solaris (Illumos) 5.11

2015-04-30 Thread Ralf Münk
Hello to all, I confirm this bug in qemu. 12 different Linux versions/distributions and 1 Windows 7 VM are running fine without any networking issue. Solaris 5.11 Version 11.2 can be installed (text version) and is running but network is broken. DHCPOFFER will not be received by Solaris 5.11

Re: [Qemu-devel] [PATCH v3 2/2] qga/commands-posix: Return per path fstrim result

2015-04-30 Thread Thomas Huth
On Thu, 30 Apr 2015 16:29:58 +0200 Justin Ossevoort wrote: > The current guest-fstrim support only returns an error if some > mountpoint was unable to be trimmed, skipping any possible additional > mountpoints. The result of the TRIM operation itself is also discarded. > > This change returns a

Re: [Qemu-devel] [PATCH 2/2] hw/ppc/spapr: Use error_report() instead of hw_error()

2015-04-30 Thread Thomas Huth
On Thu, 30 Apr 2015 13:32:05 +1000 Alexey Kardashevskiy wrote: > On 04/30/2015 05:01 AM, Thomas Huth wrote: > > hw_error() is designed for printing CPU-related error messages > > (e.g. it also prints a full CPU register dump). For error messages > > that are not directly related to CPU problems,

Re: [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30

2015-04-30 Thread Peter Maydell
On 30 April 2015 at 14:10, Michael Tokarev wrote: > Another attempt, now without the problematic ARRAY_SIZE removal, > but with additional patch removing the unused cpu_get_pc(), and > with additional Reviewed-by. > > Resending only the newly added patch, not whole series. > > Thanks, > > /mjt > >

Re: [Qemu-devel] [REBASE PATCH v5 1/2] machine: add default_ram_size to machine class

2015-04-30 Thread Nikunj A Dadhania
Alexander Graf writes: >> Am 30.04.2015 um 11:40 schrieb Thomas Huth : >> On Thu, 30 Apr 2015 11:18:05 +0200 >> Alexander Graf wrote: On 30.04.15 06:41, Nikunj A Dadhania wrote: Hi Paolo, Paolo Bonzini writes: > On 29/04/2015 11:06, Nikunj A Dadhania wrote: >>>

[Qemu-devel] [PATCH v6 0/2] Introduce default ram size in MachineClass

2015-04-30 Thread Nikunj A Dadhania
Current DEFAULT_RAM_SIZE(128MB) enforced by QEMU would not work for all machines. Introduce a default_ram_size as part of MachineClass. The below patches has following behaviour: 1) If the user does not provide "-m" option, machine's default ram size will be picked. 2) The default behaviour o

[Qemu-devel] [PATCH v6 1/2] machine: add default_ram_size to machine class

2015-04-30 Thread Nikunj A Dadhania
Machines types can have different requirement for default ram size. Introduce a member in the machine class and set the current default_ram_size to 128MB. For QEMUMachine types override the value during the registration of the machine and for MachineClass introduce the generic class init setting t

[Qemu-devel] [PATCH v6 2/2] spapr: override default ram size to 512MB

2015-04-30 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania Reviewed-by: Igor Mammedov Reviewed-by: Thomas Huth Acked-by: David Gibson --- hw/ppc/spapr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 61ddc79..7fbbae6 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1794,6

[Qemu-devel] [PATCH v3 2/9] libqos/ahci: Fix sector set method

2015-04-30 Thread John Snow
|| probably does not mean the same thing as |. Additionally, allow users to submit a prd_size of 0 to indicate that they'd like to continue using the default. Signed-off-by: John Snow --- tests/libqos/ahci.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/libqos/

[Qemu-devel] [PATCH v3 9/9] qtest/ahci: add migrate halted dma test

2015-04-30 Thread John Snow
Test migrating a halted DMA transaction. Resume, then test data integrity. Signed-off-by: John Snow --- tests/ahci-test.c | 75 ++- 1 file changed, 74 insertions(+), 1 deletion(-) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index aa0db9

[Qemu-devel] [PATCH v3 3/9] libqos: Add migration helpers

2015-04-30 Thread John Snow
libqos.c: -set_context for addressing which commands go where -migrate performs the actual migration malloc.c: - Structure of the allocator is adjusted slightly with a second-tier malloc to make swapping around the allocators easy when we "migrate" the lists from the source

[Qemu-devel] [PATCH v3 4/9] ich9/ahci: Enable Migration

2015-04-30 Thread John Snow
Lift the flag preventing the migration of the ICH9/AHCI devices. Signed-off-by: John Snow --- hw/ide/ahci.c | 1 - hw/ide/ich.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 833fd45..8e36dec 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1461,7 +14

[Qemu-devel] [PATCH v3 0/9] ahci: enable migration

2015-04-30 Thread John Snow
The day we all feared is here, and I am proposing we allow the migration of the AHCI device tentatively for the 2.4 development window. There are some more NCQ migration tests are needed, but I felt that it was important to get migration enabled as close to the start of the 2.4 development window

[Qemu-devel] [PATCH v3 1/9] libqos/ahci: Add halted command helpers

2015-04-30 Thread John Snow
Sometimes we want a command to halt the VM instead of complete successfully, so it'd be nice to let the libqos/ahci functions cope with such scenarios. Signed-off-by: John Snow --- tests/libqos/ahci.c | 27 +++ tests/libqos/ahci.h | 3 +++ 2 files changed, 30 insertions(

[Qemu-devel] [PATCH v3 7/9] qtest/ahci: add flush migrate test

2015-04-30 Thread John Snow
Use blkdebug to inject an error on first flush, then attempt to flush on the first guest. When the error halts the VM, migrate to the second VM, and attempt to resume the command. Signed-off-by: John Snow --- tests/ahci-test.c | 52 +++- 1 file cha

Re: [Qemu-devel] [PATCH v4 6/7] vmport: Add VMware all ring hack

2015-04-30 Thread Don Slutz
On 04/30/15 11:23, Paolo Bonzini wrote: > > > On 30/04/2015 17:15, Don Slutz wrote: >> That is a possibility. It did not look simple to access CPUX86State >> where I needed to check HF2_VMPORT_HACK_MASK. Instead of the >> save/restore I could add it both places. > > Why not? This: > > @@ -25

[Qemu-devel] [PATCH v3 5/9] qtest/ahci: Add migration test

2015-04-30 Thread John Snow
Notes: * The migration is performed on QOSState objects. * The migration is performed in such a way that it does not assume consistency between the allocators attached to each. That is to say, you can use each QOSState object completely independently and then at an arbitrary point deci

[Qemu-devel] [PATCH v3 8/9] qtest/ahci: add halted dma test

2015-04-30 Thread John Snow
If we're going to test the migration of halted DMA jobs, we should probably check to make sure we can resume them locally as a first step. Signed-off-by: John Snow --- tests/ahci-test.c | 60 +++ 1 file changed, 60 insertions(+) diff --git a/t

[Qemu-devel] [PATCH v3 6/9] qtest/ahci: add migrate dma test

2015-04-30 Thread John Snow
Write to one guest, migrate, and then read from the other. adjust ahci_io to clear any buffers it creates, so that we can use ahci_io safely on both guests knowing we are using empty buffers and not accidentally re-using data. Signed-off-by: John Snow --- tests/ahci-test.c | 45 +++

[Qemu-devel] [RFC 1/5] arm64: Add PMINTENCLR_EL1

2015-04-30 Thread Christopher Covington
The Linux kernel accesses this register early in its setup. Signed-off-by: Christopher Covington --- target-arm/helper.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index d77c6de..6aeb77c 100644 --- a/target-arm/helper.c +++ b/target-arm/hel

[Qemu-devel] [RFC 2/5] arm64: Add PMOVSCLR_EL0 register

2015-04-30 Thread Christopher Covington
The Linux kernel accesses this register early in its setup. Signed-off-by: Christopher Covington --- target-arm/helper.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 6aeb77c..c9463cb 100644 --- a/target-arm/helper.c +++ b/target-arm/he

[Qemu-devel] [RFC 3/5] arm64: Add PMUSERENR_EL0 register

2015-04-30 Thread Christopher Covington
The Linux kernel accesses this register early in its setup. Signed-off-by: Christopher Covington --- target-arm/helper.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index c9463cb..863cfd0 100644 --- a/target-arm/helper.c +++ b/target-arm/he

[Qemu-devel] [RFC 5/5] arm: Simplify cycle counter

2015-04-30 Thread Christopher Covington
Present a system with an instructions per cycle of exactly one. This makes it less likely a user will mistake the cycle counter values as meaningful and makes calculations involving cycles trivial while preserving the necessary property of the cycle counter register as monotonically increasing. Si

[Qemu-devel] [RFC 4/5] arm64: Unmask PMU bits in debug feature register

2015-04-30 Thread Christopher Covington
The previously missing registers are now present in QEMU. Signed-off-by: Christopher Covington --- target-arm/helper.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 863cfd0..3e6fb0b 100644 --- a/target-arm/helper.c +++ b

[Qemu-devel] [PATCH v5 0/7] Add limited support of VMware's hyper-call rpc

2015-04-30 Thread Don Slutz
Changes v4 to v5: Paolo Bonzini What is VMPORT_SHORT about? Dropped this. Why not use a bool in CPUX86State? Took his sugestion and moved to a bool in X86CPU. Changes v3 to v4: Paolo Bonzini on "vmort_rpc: Add QMP access to vmport_rpc" Does this compile on non-x86 tar

[Qemu-devel] [PATCH v5 1/7] vmport.c: Fix vmport_cmd_ram_size

2015-04-30 Thread Don Slutz
Based on https://sites.google.com/site/chitchatvmback/backdoor and testing on ESXi, this should be in MB not bytes. Signed-off-by: Don Slutz --- hw/misc/vmport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c index 7fcc00d..6b350ce 10064

[Qemu-devel] [PATCH v5 6/7] vmport: Add VMware all ring hack

2015-04-30 Thread Don Slutz
This is done by adding a new machine property vmware-port-ring3 that needs to be enabled to have any effect. It only effects accel=tcg mode. It is needed if you want to use VMware tools in accel=tcg mode. Signed-off-by: Don Slutz (cherry picked from commit 6d99c91fc9ae27b476e89a8cc880b4a46e2375

[Qemu-devel] [PATCH v5 2/7] vmport_rpc: Add the object vmport_rpc

2015-04-30 Thread Don Slutz
This is the 1st part of "Add limited support of VMware's hyper-call rpc". This patch uses existing infrastructure used by vmmouse.c (provided by vmport.c) to handle the VMware backdoor command 30. One of the better on-line references is: https://sites.google.com/site/chitchatvmback/backdoor Mor

[Qemu-devel] [PATCH v5 5/7] vmport_rpc: Add migration

2015-04-30 Thread Don Slutz
Signed-off-by: Don Slutz --- hw/misc/vmport_rpc.c | 250 +++ trace-events | 8 +- 2 files changed, 255 insertions(+), 3 deletions(-) diff --git a/hw/misc/vmport_rpc.c b/hw/misc/vmport_rpc.c index 2403f52..caa82ef 100644 --- a/hw/misc/vmpo

[Qemu-devel] [PATCH v5 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-04-30 Thread Don Slutz
This adds one new inject command: inject-vmport-action And three guest info commands: vmport-guestinfo-set vmport-guestinfo-get query-vmport-guestinfo More details in qmp-commands.hx Signed-off-by: Don Slutz --- hw/misc/vmport_rpc.c | 265 +++

[Qemu-devel] [PATCH v5 3/7] vmport_rpc: Add limited support of VMware's hyper-call rpc

2015-04-30 Thread Don Slutz
The support included is enough to allow VMware tools to install in a guest and provide guestinfo support. guestinfo support is provided by what is known as VMware RPC support. If the guest is running VMware tools, then the "build version" of the tools is also available via the property build-numb

[Qemu-devel] [PATCH v5 7/7] MAINTAINERS: add VMware port

2015-04-30 Thread Don Slutz
Signed-off-by: Don Slutz --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b5ab755..4bbda42 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -755,6 +755,13 @@ S: Maintained F: hw/net/vmxnet* F: hw/scsi/vmw_pvscsi* +VMware port +M: Don Slut

[Qemu-devel] [PATCH 1/1] vl.c: Since the help says that 'disk_image' is a raw hard disk image, pass format=raw

2015-04-30 Thread Don Slutz
~/qemu/out/master/x86_64-softmmu/qemu-system-x86_64 -h | head QEMU emulator version 2.3.50, Copyright (c) 2003-2008 Fabrice Bellard usage: qemu-system-x86_64 [options] [disk_image] 'disk_image' is a raw hard disk image for IDE hard disk 0 Standard options: ... Signed-off-by: Don Slutz --- vl.c

[Qemu-devel] [PATCH 1/1] xen-hvm: Add trace to ioreq

2015-04-30 Thread Don Slutz
Signed-off-by: Don Slutz (cherry picked from commit b72adbe7510d0a30053d32334665ee887bec9e43) --- trace-events | 7 +++ xen-hvm.c| 21 + 2 files changed, 28 insertions(+) diff --git a/trace-events b/trace-events index 30eba92..4666dad 100644 --- a/trace-events +++ b/

Re: [Qemu-devel] [RFC 5/5] arm: Simplify cycle counter

2015-04-30 Thread Peter Maydell
On 30 April 2015 at 19:14, Christopher Covington wrote: > Present a system with an instructions per cycle of exactly one. > This makes it less likely a user will mistake the cycle counter > values as meaningful and makes calculations involving cycles > trivial while preserving the necessary proper

[Qemu-devel] [PULL 0/7] Block patches

2015-04-30 Thread Kevin Wolf
The following changes since commit 06feaacfb4cfef10cc0c93d97df7bfc8a71dbc7e: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2015-04-30 12:04:11 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch

[Qemu-devel] [PULL 3/7] MAINTAINERS: make block I/O path Stefan Hajnoczi's responsibility

2015-04-30 Thread Kevin Wolf
From: Stefan Hajnoczi The block I/O path includes the asynchronous I/O machinery and read/write/flush/discard processing. It somewhat arbitrarily also includes block migration, which I've found myself reviewing patches for over the years. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wol

[Qemu-devel] [PULL 1/7] MAINTAINERS: make virtio-blk Stefan Hajnoczi's responsibility

2015-04-30 Thread Kevin Wolf
From: Stefan Hajnoczi Cc: Kevin Wolf Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- MAINTAINERS | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b5ab755..0c14de1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -704,10 +704,13

[Qemu-devel] [PATCH] i440fx-test: guard ARRAY_SIZE definition with #ifndef

2015-04-30 Thread Emilio G. Cota
ARRAY_SIZE is defined in osdep.h so having an unconditional definition here is fragile. Signed-off-by: Emilio G. Cota --- tests/i440fx-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c index d0bc8de..d610e66 100644 --- a/tests/i440fx-test.c ++

Re: [Qemu-devel] [PATCH 1/1] vl.c: Since the help says that 'disk_image' is a raw hard disk image, pass format=raw

2015-04-30 Thread Eric Blake
On 04/30/2015 01:15 PM, Eric Blake wrote: > [adding qemu-block] > > On 04/30/2015 12:23 PM, Don Slutz wrote: >> ~/qemu/out/master/x86_64-softmmu/qemu-system-x86_64 -h | head >> QEMU emulator version 2.3.50, Copyright (c) 2003-2008 Fabrice Bellard >> usage: qemu-system-x86_64 [options] [disk_image]

[Qemu-devel] [PULL 7/7] Enable NVMe start controller for Windows guest.

2015-04-30 Thread Kevin Wolf
From: Daniel Stekloff Windows seems to send two separate calls to NVMe controller configuration. The first sends configuration info and the second the enable bit. I couldn't enable the Windows 8.1 in-box NVMe driver with base Qemu. I made the following change to store the configuration data and t

[Qemu-devel] [PULL 5/7] MAINTAINERS: make block layer core Kevin Wolf's responsibility

2015-04-30 Thread Kevin Wolf
From: Stefan Hajnoczi Kevin is now sole maintainer of the core block layer, including BlockDriverState graphs and monitor commands. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAI

[Qemu-devel] [PULL 2/7] MAINTAINERS: split out image formats

2015-04-30 Thread Kevin Wolf
From: Stefan Hajnoczi Block driver submaintainers has proven to be a good model. Kevin and Stefan are splitting up the unclaimed block drivers so each has a dedicated maintainer. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- MAINTAINERS | 77 +++

[Qemu-devel] [PATCH] cpu: Register QOM links at /machine/cpus/

2015-04-30 Thread Eduardo Habkost
This will provide a predictable path for the CPU objects, and a more powerful alternative for the query-cpus QMP command, as now every QOM property on CPU objects can be easily queried. Signed-off-by: Eduardo Habkost --- Note that this doesn't replace any future topology enumeration mechanisms we

[Qemu-devel] [PULL 4/7] MAINTAINERS: make image fuzzer Stefan Hajnoczi's responsibility

2015-04-30 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- MAINTAINERS | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9e1413e..65a5cc5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -779,7 +779,6 @@ F: block/ F:

[Qemu-devel] [PULL 6/7] MAINTAINERS: Add qemu-block list where missing

2015-04-30 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 25fd2b5..0b67c48 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -735,12 +735,14 @@ F: backends/rng*.c nvme M: Keith Busch +L: qemu-bl...@nongnu.org S: Supported

Re: [Qemu-devel] [PATCH] i440fx-test: guard ARRAY_SIZE definition with #ifndef

2015-04-30 Thread Stefan Weil
Am 30.04.2015 um 21:16 schrieb Emilio G. Cota: ARRAY_SIZE is defined in osdep.h so having an unconditional definition here is fragile. Signed-off-by: Emilio G. Cota --- tests/i440fx-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c index d

Re: [Qemu-devel] [PATCH 1/1] vl.c: Since the help says that 'disk_image' is a raw hard disk image, pass format=raw

2015-04-30 Thread Eric Blake
[adding qemu-block] On 04/30/2015 12:23 PM, Don Slutz wrote: > ~/qemu/out/master/x86_64-softmmu/qemu-system-x86_64 -h | head > QEMU emulator version 2.3.50, Copyright (c) 2003-2008 Fabrice Bellard > usage: qemu-system-x86_64 [options] [disk_image] > > 'disk_image' is a raw hard disk image for IDE

Re: [Qemu-devel] [PATCH] i440fx-test: guard ARRAY_SIZE definition with #ifndef

2015-04-30 Thread Peter Maydell
On 30 April 2015 at 20:28, Stefan Weil wrote: > Am 30.04.2015 um 21:16 schrieb Emilio G. Cota: >> >> ARRAY_SIZE is defined in osdep.h so having an unconditional >> definition here is fragile. FWIW, the original patch of this failed to build on x86 too, so I don't think we currently include osdep.

Re: [Qemu-devel] [PATCH] i440fx-test: guard ARRAY_SIZE definition with #ifndef

2015-04-30 Thread Michael Tokarev
30.04.2015 22:16, Emilio G. Cota wrote: > ARRAY_SIZE is defined in osdep.h so having an unconditional > definition here is fragile. Fragile in what sense? Nothing in that file includes osdep.h. At the maximum, compiler will issue a warning about redefinition (it should really be redefinition, not

Re: [Qemu-devel] [PATCH 1/1] vl.c: Since the help says that 'disk_image' is a raw hard disk image, pass format=raw

2015-04-30 Thread Kevin Wolf
Am 30.04.2015 um 21:15 hat Eric Blake geschrieben: > [adding qemu-block] > > On 04/30/2015 12:23 PM, Don Slutz wrote: > > ~/qemu/out/master/x86_64-softmmu/qemu-system-x86_64 -h | head > > QEMU emulator version 2.3.50, Copyright (c) 2003-2008 Fabrice Bellard > > usage: qemu-system-x86_64 [options]

Re: [Qemu-devel] [PATCH] cpu: Register QOM links at /machine/cpus/

2015-04-30 Thread Andreas Färber
First I did not participate in that discussion, second nack to that self pointer. Please hold off on this until I'm back. Andreas Eduardo Habkost schrieb: >This will provide a predictable path for the CPU objects, and a more >powerful alternative for the query-cpus QMP command, as now every QOM

Re: [Qemu-devel] [PATCH v8 00/16] spapr: add support for pci hotplug

2015-04-30 Thread Michael Roth
Quoting David Gibson (2015-04-29 23:13:04) > On Wed, Apr 22, 2015 at 01:28:04AM -0500, Michael Roth wrote: > > These patches are based on spapr-next, and can also be obtained > > from: > > Thanks Michael. > > I've made a few small conflict fixes and merged this into spapr-next. Great, thanks! >

Re: [Qemu-devel] [RFC 5/5] arm: Simplify cycle counter

2015-04-30 Thread Christopher Covington
Hi Peter, Thanks for taking a look. On Apr 30, 2015 2:28 PM, "Peter Maydell" wrote: > > On 30 April 2015 at 19:14, Christopher Covington > wrote: > > Present a system with an instructions per cycle of exactly one. > > This makes it less likely a user will mistake the cycle counter > > values as

Re: [Qemu-devel] [PATCH v8 00/16] spapr: add support for pci hotplug

2015-04-30 Thread Michael Roth
Quoting Michael Roth (2015-04-30 16:04:49) > Quoting David Gibson (2015-04-29 23:13:04) > > On Wed, Apr 22, 2015 at 01:28:04AM -0500, Michael Roth wrote: > > > These patches are based on spapr-next, and can also be obtained > > > from: > > > > Thanks Michael. > > > > I've made a few small conflic

Re: [Qemu-devel] [PATCH] cpu: Register QOM links at /machine/cpus/

2015-04-30 Thread Paolo Bonzini
On 30/04/2015 22:21, Andreas Färber wrote: >>+cpu->self = cobj; >>+object_property_add_link(cpu_container, path, TYPE_CPU, &cpu->self, NULL, >>+ OBJ_PROP_LINK_UNREF_ON_RELEASE, &error_abort); Doesn't this leak the CPU object? I have a patch to add "." and "..

[Qemu-devel] [PATCH v3 0/4] apic: Implement MSI RH bit handling, lowpri IRQ delivery

2015-04-30 Thread James Sullivan
Changes in v2: * Merged in low priority IRQ delivery implementation to RH bit handling implementation, since both rely on the same helper functions for priority arbitration. * Corrected use of MSI data register => addr register when setting msi_redir_hint in apic_send_msi(). Cha

[Qemu-devel] [PATCH v3 1/4] apic: Implement LAPIC low priority arbitration functions

2015-04-30 Thread James Sullivan
Currently, apic_get_arb_pri() is unimplemented and returns 0. Implemented apic_get_arb_pri() and added helper function apic_compare_prio() to be used for LAPIC arbitration. Signed-off-by: James Sullivan --- Changes in v3: * Fixed apic_get_arb_pri to use AMD's algorithm vs. Intel's (incor

[Qemu-devel] [PATCH v3 3/4] apic: Add helper functions apic_match_dest, apic_match_[physical, logical]_dest

2015-04-30 Thread James Sullivan
Added three helper functions apic_match_dest(), apic_match_physical_dest(), and apic_match_logical_dest() which can be used to determine if a logical or physical APIC ID match a given LAPIC under a given dest_mode. This does not account for shorthand. Signed-off-by: James Sullivan --- hw/intc/ap

<    1   2   3   >