30.04.2015 22:16, Emilio G. Cota wrote: > ARRAY_SIZE is defined in osdep.h so having an unconditional > definition here is fragile.
Fragile in what sense? Nothing in that file includes osdep.h. At the maximum, compiler will issue a warning about redefinition (it should really be redefinition, not the same definition), which might be treated as error, and we'll just fix that warning.. I'd say just be done with this, it doesn't deserve that much attention ;) Somehow initially I thought this patch actually FIXES a warning of this sort. But it looks lile it is only fixes a potential warning. Oh well... :) Thanks, /mjt