On 30 April 2015 at 20:28, Stefan Weil <s...@weilnetz.de> wrote: > Am 30.04.2015 um 21:16 schrieb Emilio G. Cota: >> >> ARRAY_SIZE is defined in osdep.h so having an unconditional >> definition here is fragile.
FWIW, the original patch of this failed to build on x86 too, so I don't think we currently include osdep.h from this file in any circumstances... Where do you get the ARRAY_SIZE definition from that presumably lets you build without this one? > Why not include osdep.h via qemu-common.h and remove all other include > statements which then are no longer needed? I'd prefer that variant. Can we include qemu-common.h in these libqos standalone test executables? I forget... The rtl8139 test seems to though, so I guess it's OK. -- PMM
