Re: [Qemu-devel] [PATCH 0/5] Extend TPM support with a QEMU-external TPM

2015-04-22 Thread Igor Mammedov
On Thu, 16 Apr 2015 10:05:35 -0400 Stefan Berger wrote: > On 04/16/2015 09:35 AM, Igor Mammedov wrote: > > On Wed, 15 Apr 2015 18:38:43 -0400 > > Stefan Berger wrote: > > > >> The following series of patches extends TPM support with an > >> external TPM that offers a Linux CUSE (character device

Re: [Qemu-devel] [PATCH qemu v6 05/15] spapr_pci_vfio: Enable multiple groups per container

2015-04-22 Thread David Gibson
On Sat, Apr 11, 2015 at 01:24:34AM +1000, Alexey Kardashevskiy wrote: > This enables multiple IOMMU groups in one VFIO container which means > that multiple devices from different groups can share the same IOMMU > table (or tables if DDW). > > This removes a group id from vfio_container_ioctl(). T

Re: [Qemu-devel] [PATCH qemu v6 12/15] spapr_vfio_pci: Remove redundant spapr-pci-vfio-host-bridge

2015-04-22 Thread David Gibson
On Sat, Apr 11, 2015 at 01:24:41AM +1000, Alexey Kardashevskiy wrote: > sPAPRTCETable is handling 2 TCE tables already: > > 1) guest view of the TCE table - emulated devices use only this table; > > 2) hardware IOMMU table - VFIO PCI devices use it for actual work but > it does not replace 1) and

Re: [Qemu-devel] [PATCH qemu v6 08/15] spapr_iommu: Introduce "enabled" state for TCE table

2015-04-22 Thread David Gibson
On Sat, Apr 11, 2015 at 01:24:37AM +1000, Alexey Kardashevskiy wrote: > Currently TCE tables are created once at start and their size never > changes. We are going to change that by introducing a Dynamic DMA windows > support where DMA configuration may change during the guest execution. > > This

Re: [Qemu-devel] [PATCH qemu v6 07/15] vfio: spapr: Add SPAPR IOMMU v2 support (DMA memory preregistering)

2015-04-22 Thread David Gibson
On Sat, Apr 11, 2015 at 01:24:36AM +1000, Alexey Kardashevskiy wrote: > This makes use of the new "memory registering" feature. The idea is > to provide the userspace ability to notify the host kernel about pages > which are going to be used for DMA. Having this information, the host > kernel can p

Re: [Qemu-devel] [PATCH qemu v6 13/15] spapr: Add pseries-2.4 machine

2015-04-22 Thread David Gibson
On Sat, Apr 11, 2015 at 01:24:42AM +1000, Alexey Kardashevskiy wrote: > The next patch implements dynamic DMA windows and disables them by default > for older pseries machines. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: David Gibson -- David Gibson| I'll have my

Re: [Qemu-devel] [PATCH qemu v6 10/15] spapr_pci_vfio: Remove unnecessary cast to sPAPRPHBVFIOState

2015-04-22 Thread David Gibson
On Sat, Apr 11, 2015 at 01:24:39AM +1000, Alexey Kardashevskiy wrote: > EEH handlers only need AddressSpace to get to the right VFIO container > to call ioctl() so remove unnecessary cast of sPAPRPHBState to > sPAPRPHBVFIOState. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: David Gibson

Re: [Qemu-devel] [PATCH qemu v6 11/15] spapr_pci: Do complete reset of DMA config when resetting PHB

2015-04-22 Thread David Gibson
On Sat, Apr 11, 2015 at 01:24:40AM +1000, Alexey Kardashevskiy wrote: > On a system reset, DMA configuration has to reset too. At the moment > it clears the table content. This is enough for the single table case > but with DDW, we will also have to disable all DMA windows except > the default one.

Re: [Qemu-devel] [PATCH qemu v6 06/15] spapr_pci: Convert finish_realize() to dma_capabilities_update()+dma_init_window()

2015-04-22 Thread David Gibson
On Sat, Apr 11, 2015 at 01:24:35AM +1000, Alexey Kardashevskiy wrote: > This reworks finish_realize() which used to finalize DMA setup with > an assumption that it will not change later. > > New callbacks supports various window parameters such as page and > windows sizes. The new callback return

Re: [Qemu-devel] [PATCH] hda-codec: use smaller dynamic range for input amplifier

2015-04-22 Thread Wilck, Martin
> > > The "right" solution for this problem would be to implement > > > proper dB scaling in QEMU and the audio backends (such as spice). > > Can we try this please? I would like to, but it's a rather big project and beyond my current QEMU progamming skills. Support seems to be lacking in the gen

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-22 Thread Gerd Hoffmann
Hi, > tseg is just normal ram (yes, located at the end of memory), but (once > tseg is enabled) only cpus in smm mode are allowed to access it. > Likewise busmaster dma access is rejected, so non-smm code can't use the > sata controller to access this indirectly. Update: Seems tseg can be anyw

Re: [Qemu-devel] [PATCH 1/6] s390x/virtio-ccw: enable has_dynamic_sysbus

2015-04-22 Thread Cornelia Huck
On Tue, 21 Apr 2015 21:06:42 +0200 Alexander Graf wrote: > On 04/17/2015 09:52 AM, Cornelia Huck wrote: > > From: Xu Wang > > > > We have to enable this flag to support dynamically adding devices to the > > sysbus. This change is needed for the the upcoming diag288 watchdog. > > s390 doesn't ha

Re: [Qemu-devel] [PATCH 3/6] s390/kvm: diag288 instruction interception and handling

2015-04-22 Thread Cornelia Huck
On Tue, 21 Apr 2015 21:09:05 +0200 Alexander Graf wrote: > On 04/17/2015 09:52 AM, Cornelia Huck wrote: > > From: Xu Wang > > > > Intercept the diag288 requests from kvm guests, and hand the > > requested command to the diag288 watchdog device for further > > handling. > > > > Signed-off-by: Xu

Re: [Qemu-devel] [PATCH 09/10] s390x/mmu: Use ioctl for reading and writing from/to guest memory

2015-04-22 Thread Cornelia Huck
On Tue, 21 Apr 2015 21:48:02 +0200 Christian Borntraeger wrote: > Am 21.04.2015 um 21:36 schrieb Alexander Graf: > > On 04/21/2015 09:34 PM, Christian Borntraeger wrote: > >> Am 21.04.2015 um 21:12 schrieb Alexander Graf: > >>> On 04/20/2015 04:55 PM, Christian Borntraeger wrote: > Am 09.04.

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-22 Thread Laszlo Ersek
On 04/22/15 10:09, Gerd Hoffmann wrote: > Hi, > >> tseg is just normal ram (yes, located at the end of memory), but (once >> tseg is enabled) only cpus in smm mode are allowed to access it. >> Likewise busmaster dma access is rejected, so non-smm code can't use the >> sata controller to access t

Re: [Qemu-devel] [PATCH qemu v6 12/15] spapr_vfio_pci: Remove redundant spapr-pci-vfio-host-bridge

2015-04-22 Thread Alexey Kardashevskiy
On 04/22/2015 04:47 PM, David Gibson wrote: On Sat, Apr 11, 2015 at 01:24:41AM +1000, Alexey Kardashevskiy wrote: sPAPRTCETable is handling 2 TCE tables already: 1) guest view of the TCE table - emulated devices use only this table; 2) hardware IOMMU table - VFIO PCI devices use it for actual

Re: [Qemu-devel] [PATCH qemu v6 08/15] spapr_iommu: Introduce "enabled" state for TCE table

2015-04-22 Thread Alexey Kardashevskiy
On 04/22/2015 04:14 PM, David Gibson wrote: On Sat, Apr 11, 2015 at 01:24:37AM +1000, Alexey Kardashevskiy wrote: Currently TCE tables are created once at start and their size never changes. We are going to change that by introducing a Dynamic DMA windows support where DMA configuration may chan

Re: [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly

2015-04-22 Thread Stefan Hajnoczi
On Mon, Apr 20, 2015 at 03:54:52PM +0200, Paolo Bonzini wrote: > > > On 20/04/2015 15:11, Stefan Hajnoczi wrote: > >> -memory_region_set_coalescing(&s->mem_vram); + > >> memory_region_set_log(&s->mem_vram, true, DIRTY_MEMORY_VGA); > > > > This change isn't 100% clear to me. I guess that coa

Re: [Qemu-devel] [PATCH 1/6] s390x/virtio-ccw: enable has_dynamic_sysbus

2015-04-22 Thread Alexander Graf
On 04/22/2015 10:25 AM, Cornelia Huck wrote: On Tue, 21 Apr 2015 21:06:42 +0200 Alexander Graf wrote: On 04/17/2015 09:52 AM, Cornelia Huck wrote: From: Xu Wang We have to enable this flag to support dynamically adding devices to the sysbus. This change is needed for the the upcoming diag28

Re: [Qemu-devel] [PATCH 3/6] s390/kvm: diag288 instruction interception and handling

2015-04-22 Thread Alexander Graf
On 04/22/2015 10:32 AM, Cornelia Huck wrote: On Tue, 21 Apr 2015 21:09:05 +0200 Alexander Graf wrote: On 04/17/2015 09:52 AM, Cornelia Huck wrote: From: Xu Wang Intercept the diag288 requests from kvm guests, and hand the requested command to the diag288 watchdog device for further handling

Re: [Qemu-devel] [PATCH qemu v6 11/15] spapr_pci: Do complete reset of DMA config when resetting PHB

2015-04-22 Thread Alexey Kardashevskiy
On 04/22/2015 04:39 PM, David Gibson wrote: On Sat, Apr 11, 2015 at 01:24:40AM +1000, Alexey Kardashevskiy wrote: On a system reset, DMA configuration has to reset too. At the moment it clears the table content. This is enough for the single table case but with DDW, we will also have to disable

Re: [Qemu-devel] [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Stefan Hajnoczi
On Tue, Apr 21, 2015 at 05:28:01PM +0200, Paolo Bonzini wrote: > On 21/04/2015 03:25, Wen Congyang wrote: > >> > Please do not introduce "+colo" block drivers. This approach is > >> > invasive and makes block replication specific to only a few block > >> > drivers, e.g. NBD or qcow2. > > NBD is us

Re: [Qemu-devel] [RFC 0/7] Live Migration with Pass-through Devices proposal

2015-04-22 Thread Daniel P. Berrange
On Fri, Apr 17, 2015 at 04:53:02PM +0800, Chen Fan wrote: > backgrond: > Live migration is one of the most important features of virtualization > technology. > With regard to recent virtualization techniques, performance of network I/O > is critical. > Current network I/O virtualization (e.g. Par

Re: [Qemu-devel] [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Wen Congyang
On 04/22/2015 05:18 PM, Stefan Hajnoczi wrote: > On Tue, Apr 21, 2015 at 05:28:01PM +0200, Paolo Bonzini wrote: >> On 21/04/2015 03:25, Wen Congyang wrote: > Please do not introduce "+colo" block drivers. This approach is > invasive and makes block replication specific to only a few block

Re: [Qemu-devel] [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Stefan Hajnoczi
On Tue, Apr 21, 2015 at 09:25:59AM +0800, Wen Congyang wrote: > On 04/20/2015 11:30 PM, Stefan Hajnoczi wrote: > > On Fri, Apr 03, 2015 at 06:01:07PM +0800, Wen Congyang wrote: > > One general question about the design: the Secondary host needs 3x > > storage space since it has the Secondary Disk,

Re: [Qemu-devel] [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Kevin Wolf
Am 21.04.2015 um 17:28 hat Paolo Bonzini geschrieben: > > > On 21/04/2015 03:25, Wen Congyang wrote: > >> > Please do not introduce "+colo" block drivers. This approach is > >> > invasive and makes block replication specific to only a few block > >> > drivers, e.g. NBD or qcow2. > > NBD is used

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-22 Thread Gerd Hoffmann
Hi, > Thanks, that sounds good. So, as far as I understand, no changes to what > we've discussed thus far. > > But, I have another question -- am I allowed to use "top of below-4g > memory" directly, as discussed earlier, or should I use the above PCI > registers? The tseg size will actually co

Re: [Qemu-devel] [PATCH qemu v6 07/15] vfio: spapr: Add SPAPR IOMMU v2 support (DMA memory preregistering)

2015-04-22 Thread Alexey Kardashevskiy
On 04/22/2015 03:53 PM, David Gibson wrote: On Sat, Apr 11, 2015 at 01:24:36AM +1000, Alexey Kardashevskiy wrote: This makes use of the new "memory registering" feature. The idea is to provide the userspace ability to notify the host kernel about pages which are going to be used for DMA. Having

Re: [Qemu-devel] [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Wen Congyang
On 04/22/2015 05:29 PM, Stefan Hajnoczi wrote: > On Tue, Apr 21, 2015 at 09:25:59AM +0800, Wen Congyang wrote: >> On 04/20/2015 11:30 PM, Stefan Hajnoczi wrote: >>> On Fri, Apr 03, 2015 at 06:01:07PM +0800, Wen Congyang wrote: >>> One general question about the design: the Secondary host needs 3x >

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Paolo Bonzini
On 22/04/2015 11:31, Kevin Wolf wrote: >> Actually I liked the "foo+colo" names. >> >> These are just internal details of the implementations and the >> primary/secondary disks actually can be any format. >> >> Stefan, what was your worry with the +colo block drivers? > > I haven't read the patc

Re: [Qemu-devel] [Qemu-block] [PATCH] qmp: fill in the image field in BlockDeviceInfo

2015-04-22 Thread Stefan Hajnoczi
On Fri, Apr 17, 2015 at 02:52:43PM +0300, Alberto Garcia wrote: > The image field in BlockDeviceInfo is supposed to contain an ImageInfo > object. However that is being filled in by bdrv_query_info(), not by > bdrv_block_device_info(), which is where BlockDeviceInfo is actually > created. > > Anyo

Re: [Qemu-devel] using scsi megasas causes Windows 8 bluescreen

2015-04-22 Thread Hannes Reinecke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/22/2015 12:19 PM, Stefan Hajnoczi wrote: > On Tue, Apr 21, 2015 at 10:49:48AM +0300, Alex Fishman wrote: >> I'm trying to install Windows 8 on megasas scsi device with >> master qemu branch. At the end of the installation I >> consistently get a

Re: [Qemu-devel] using scsi megasas causes Windows 8 bluescreen

2015-04-22 Thread Stefan Hajnoczi
On Tue, Apr 21, 2015 at 10:49:48AM +0300, Alex Fishman wrote: > I'm trying to install Windows 8 on megasas scsi device with master qemu > branch. At the end of the installation I consistently get a blue screen and > the image doesn't boot after that. > I tried to bisect to older qemu versions, the

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: do lazy allocation of the L2 cache

2015-04-22 Thread Stefan Hajnoczi
On Tue, Apr 21, 2015 at 06:20:39PM +0300, Alberto Garcia wrote: > Large disk images need large L2 caches in order to maximize their > I/O performance. However setting a correct size for the cache is not > necessarily easy since apart from the image size, it also depends > on other factors like its

Re: [Qemu-devel] [PATCH RFC 0/3] iothread: release iothread around aio_poll

2015-04-22 Thread Stefan Hajnoczi
On Tue, Apr 21, 2015 at 05:54:59PM +0200, Paolo Bonzini wrote: > > > On 21/04/2015 17:40, Stefan Hajnoczi wrote: > >> > > >> > Stefan, can you put this on track for 2.4 or do you need a repost? > > This series causes qemu-iotests -qcow2 091 to fail: > > > > 9f83aea22314d928bb272153ff37d2d7f5adbf

[Qemu-devel] [RFC PATCH 2/2] spapr: populate ibm,loc-code

2015-04-22 Thread Nikunj A Dadhania
Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Populate ibm,loc-code. 1) PCI passthru devices need to identi

[Qemu-devel] [RFC PATCH 1/2] spapr: enumerate and add PCI device tree

2015-04-22 Thread Nikunj A Dadhania
All the PCI enumeration and device node creation was off-loaded to SLOF. With PCI hotplug support, code needed to be added to add device node. This creates multiple copy of the code one in SLOF and other in hotplug code. To unify this, the patch adds the pci device node creation in Qemu. For backwa

[Qemu-devel] [RFC PATCH 0/2] spapr: move pci device creation to Qemu

2015-04-22 Thread Nikunj A Dadhania
The patch series creates PCI DT nodes in QEMU. The new hotplug code needs the device node creation in Qemu. While during boot, nodes were created in SLOF. It makes more sense to consolidate the code to one place for better maintainability. Also, patches for populating ibm,loc-code was getting ver

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > Signed-off-by: Wen Congyang > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Hongyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > docs/block-replication.txt | 153 > + > 1 file

Re: [Qemu-devel] [RFC PATCH v4 00/28] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2015-04-22 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > Hi, > > ping ... I will get to look at this again; but not until after next week. > The main blocked bugs for COLO have been solved, I've got the v3 set running, but the biggest problem I hit are problems with the packet comparison modul

Re: [Qemu-devel] [PATCH 3/6] s390/kvm: diag288 instruction interception and handling

2015-04-22 Thread Cornelia Huck
On Wed, 22 Apr 2015 11:16:00 +0200 Alexander Graf wrote: > On 04/22/2015 10:32 AM, Cornelia Huck wrote: > > On Tue, 21 Apr 2015 21:09:05 +0200 > > Alexander Graf wrote: > > > >> On 04/17/2015 09:52 AM, Cornelia Huck wrote: > >>> From: Xu Wang > >>> > >>> Intercept the diag288 requests from kvm

Re: [Qemu-devel] [PATCH] migration: avoid divide by zero in xbzrle cache miss rate

2015-04-22 Thread Juan Quintela
Michael Chapman wrote: > This bug manifested itself as a VM that could not be resumed by libvirt > following a migration: > > # virsh resume example > error: Failed to resume domain example > error: internal error: cannot parse json {"return": > {"xbzrle-cache": > {..., "cache-miss

Re: [Qemu-devel] [PATCH 1/6] s390x/virtio-ccw: enable has_dynamic_sysbus

2015-04-22 Thread Cornelia Huck
On Wed, 22 Apr 2015 11:14:40 +0200 Alexander Graf wrote: > On 04/22/2015 10:25 AM, Cornelia Huck wrote: > > On Tue, 21 Apr 2015 21:06:42 +0200 > > Alexander Graf wrote: > > > >> On 04/17/2015 09:52 AM, Cornelia Huck wrote: > >>> From: Xu Wang > >>> > >>> We have to enable this flag to support d

Re: [Qemu-devel] [PATCH 01/27] iotests, parallels: quote TEST_IMG in 076 test to be path-safe

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:27:55PM +0300, Denis V. Lunev wrote: > suggested by Jeff Cody > > Signed-off-by: Denis V. Lunev > Reviewed-by: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > tests/qemu-iotests/076 | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Revie

Re: [Qemu-devel] [PATCH 02/27] block/parallels: rename parallels_header to ParallelsHeader

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:27:56PM +0300, Denis V. Lunev wrote: > this follows QEMU coding convention > > Signed-off-by: Denis V. Lunev > Reviewed-by: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH 1/6] s390x/virtio-ccw: enable has_dynamic_sysbus

2015-04-22 Thread Alexander Graf
> Am 22.04.2015 um 13:40 schrieb Cornelia Huck : > > On Wed, 22 Apr 2015 11:14:40 +0200 > Alexander Graf wrote: > >>> On 04/22/2015 10:25 AM, Cornelia Huck wrote: >>> On Tue, 21 Apr 2015 21:06:42 +0200 >>> Alexander Graf wrote: >>> > On 04/17/2015 09:52 AM, Cornelia Huck wrote: > Fro

Re: [Qemu-devel] [PATCH 03/27] block/parallels: switch to bdrv_read

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:27:57PM +0300, Denis V. Lunev wrote: > From: Roman Kagan > > Switch the .bdrv_read method implementation from using bdrv_pread() to > bdrv_read() on the underlying file, since the latter is subject to i/o > throttling while the former is not. > > Besides, since bdrv_re

Re: [Qemu-devel] [RFC 00/10] MultiThread TCG.

2015-04-22 Thread Frederic Konrad
On 10/04/2015 18:03, Frederic Konrad wrote: On 30/03/2015 23:46, Peter Maydell wrote: On 30 March 2015 at 07:52, Mark Burton wrote: So - Fred is unwilling to send the patch set as it stands, because frankly this part is totally broken. There is an independent patch set that needs splitting o

Re: [Qemu-devel] [PATCH 04/27] block/parallels: read up to cluster end in one go

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:27:58PM +0300, Denis V. Lunev wrote: > From: Roman Kagan > > Teach parallels_read() to do reads in coarser granularity than just a > single sector: if requested, read up to the cluster end in one go. > > Signed-off-by: Roman Kagan > Reviewed-by: Denis V. Lunev > Sign

Re: [Qemu-devel] [PATCH 03/27] block/parallels: switch to bdrv_read

2015-04-22 Thread Denis V. Lunev
On 22/04/15 15:23, Stefan Hajnoczi wrote: On Wed, Mar 11, 2015 at 01:27:57PM +0300, Denis V. Lunev wrote: From: Roman Kagan Switch the .bdrv_read method implementation from using bdrv_pread() to bdrv_read() on the underlying file, since the latter is subject to i/o throttling while the former

Re: [Qemu-devel] [PATCH 05/27] block/parallels: add get_block_status

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:27:59PM +0300, Denis V. Lunev wrote: > +static int64_t coroutine_fn parallels_co_get_block_status(BlockDriverState > *bs, > +int64_t sector_num, int nb_sectors, int *pnum) > +{ > +BDRVParallelsState *s = bs->opaque; > +int64_t offset; > + > +qemu_co_m

Re: [Qemu-devel] [PATCH 06/27] block/parallels: provide _co_readv routine for parallels format driver

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:00PM +0300, Denis V. Lunev wrote: > Main approach is taken from qcow2_co_readv. > > The patch drops coroutine lock for the duration of IO operation and > peforms normal scatter-gather IO using standard QEMU backend. > > Signed-off-by: Denis V. Lunev > Reviewed-by: R

Re: [Qemu-devel] [PATCH 07/27] block/parallels: replace magic constants 4, 64 with proper sizeofs

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:01PM +0300, Denis V. Lunev wrote: > simple purification.. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: S

Re: [Qemu-devel] [PATCH 05/27] block/parallels: add get_block_status

2015-04-22 Thread Denis V. Lunev
On 22/04/15 15:39, Stefan Hajnoczi wrote: On Wed, Mar 11, 2015 at 01:27:59PM +0300, Denis V. Lunev wrote: +static int64_t coroutine_fn parallels_co_get_block_status(BlockDriverState *bs, +int64_t sector_num, int nb_sectors, int *pnum) +{ +BDRVParallelsState *s = bs->opaque; +int6

Re: [Qemu-devel] [PATCH 06/27] block/parallels: provide _co_readv routine for parallels format driver

2015-04-22 Thread Denis V. Lunev
On 22/04/15 15:41, Stefan Hajnoczi wrote: On Wed, Mar 11, 2015 at 01:28:00PM +0300, Denis V. Lunev wrote: Main approach is taken from qcow2_co_readv. The patch drops coroutine lock for the duration of IO operation and peforms normal scatter-gather IO using standard QEMU backend. Signed-off-by:

Re: [Qemu-devel] [PATCH 08/27] block/parallels: _co_writev callback for Parallels format

2015-04-22 Thread Denis V. Lunev
On 11/03/15 13:28, Denis V. Lunev wrote: Support write on Parallels images. The code is almost the same as one in the previous patch implemented scatter-gather IO for read. Signed-off-by: Denis V. Lunev Reviewed-by: Roman Kagan CC: Kevin Wolf CC: Stefan Hajnoczi --- block/parallels.c | 77

Re: [Qemu-devel] [PATCH COLO v3 04/14] Add new block driver interfaces to control block replication

2015-04-22 Thread Eric Blake
On 04/03/2015 04:01 AM, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Cc: Luiz Capitulino > Cc: Michael Roth > Reviewed-by: Paolo Bonzini > --- > block.c | 40 > include/b

Re: [Qemu-devel] [PATCH 08/27] block/parallels: _co_writev callback for Parallels format

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:02PM +0300, Denis V. Lunev wrote: > +static coroutine_fn int parallels_co_writev(BlockDriverState *bs, > +int64_t sector_num, int nb_sectors, QEMUIOVector *qiov) > +{ > +BDRVParallelsState *s = bs->opaque; > +uint64_t bytes_done = 0; > +QEMUIOVector

Re: [Qemu-devel] [RFC 0/7] Live Migration with Pass-through Devices proposal

2015-04-22 Thread Daniel P. Berrange
On Wed, Apr 22, 2015 at 10:23:04AM +0100, Daniel P. Berrange wrote: > On Fri, Apr 17, 2015 at 04:53:02PM +0800, Chen Fan wrote: > > backgrond: > > Live migration is one of the most important features of virtualization > > technology. > > With regard to recent virtualization techniques, performance

Re: [Qemu-devel] [PATCH 08/27] block/parallels: _co_writev callback for Parallels format

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:02PM +0300, Denis V. Lunev wrote: > +static int64_t allocate_cluster(BlockDriverState *bs, int64_t sector_num) > +{ > +BDRVParallelsState *s = bs->opaque; > +uint32_t idx, offset, tmp; > +int64_t pos; > +int ret; > + > +idx = sector_num / s->tracks;

Re: [Qemu-devel] [PATCH 09/27] iotests, parallels: test for write into Parallels image

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:03PM +0300, Denis V. Lunev wrote: > Signed-off-by: Denis V. Lunev > Reviewed-by: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > tests/qemu-iotests/076 | 5 + > tests/qemu-iotests/076.out | 10 ++ > 2 files changed, 15 insertions(+) Re

Re: [Qemu-devel] [PATCH] translate-all: use bitmap helpers for PageDesc's bitmap

2015-04-22 Thread Paolo Bonzini
On 21/03/2015 07:25, Emilio G. Cota wrote: > Note that this test > if (b & ((1 << len) - 1)) > can be simplified to > if (b & 1) > , since we know that iff the first bit of a tb is set, > all other bits from that tb are set too. I don't think this optimization is valid, unfortunately

Re: [Qemu-devel] [PATCH 10/27] block/parallels: support parallels image creation

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:04PM +0300, Denis V. Lunev wrote: > Do not even care to create WithoutFreeSpace image, it is obsolete. > Always create WithouFreSpacExt one. > > The code also does not spend a lot of efforts to fill cylinders and > heads fields, they are not used actually in a real li

Re: [Qemu-devel] [PATCH 08/27] block/parallels: _co_writev callback for Parallels format

2015-04-22 Thread Denis V. Lunev
On 22/04/15 16:08, Stefan Hajnoczi wrote: On Wed, Mar 11, 2015 at 01:28:02PM +0300, Denis V. Lunev wrote: +static int64_t allocate_cluster(BlockDriverState *bs, int64_t sector_num) +{ +BDRVParallelsState *s = bs->opaque; +uint32_t idx, offset, tmp; +int64_t pos; +int ret; + +

Re: [Qemu-devel] [PATCH 11/27] iotests, parallels: test for newly created parallels image via qemu-img

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:05PM +0300, Denis V. Lunev wrote: > Signed-off-by: Denis V. Lunev > Reviwed-by: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > tests/qemu-iotests/115 | 68 > ++ > tests/qemu-iotests/115.out | 24

Re: [Qemu-devel] [RFC 00/10] MultiThread TCG.

2015-04-22 Thread Peter Maydell
On 22 April 2015 at 13:26, Frederic Konrad wrote: [re summary of design] > Does that makes sense? Oops, I think that I lost that email in the flow of stuff through the mailing list. I think Alex is going to be doing the bulk of the review on this for Linaro, so I'll let him have a look at it :-)

Re: [Qemu-devel] [PATCH] translate-all: remove redundant page_find from tb_invalidate_phys_page

2015-04-22 Thread Paolo Bonzini
On 08/04/2015 23:37, Emilio G. Cota wrote: > The callers have just looked up the page descriptor, so there's no > point in searching again for it. > > Signed-off-by: Emilio G. Cota > --- > translate-all.c | 11 +++ > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/tra

Re: [Qemu-devel] [PATCH 12/27] parallels: change copyright information in the image header

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:06PM +0300, Denis V. Lunev wrote: > Signed-off-by: Denis V. Lunev > Reviwed-by: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi pgpwOfQ6dM4IC

Re: [Qemu-devel] [PATCH 12/27] parallels: change copyright information in the image header

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:06PM +0300, Denis V. Lunev wrote: > Signed-off-by: Denis V. Lunev > Reviwed-by: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/block/parallels.c b/block/pa

Re: [Qemu-devel] [PATCH 13/27] block/parallels: rename catalog_ names to bat_

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:07PM +0300, Denis V. Lunev wrote: > BAT means 'block allocation table'. Thus this name is clean and shorter > on writing. > > Some obvious formatting fixes in the old code were made to make checkpatch > happy. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Roman K

Re: [Qemu-devel] [PATCH 14/27] block/parallels: create bat2sect helper

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:08PM +0300, Denis V. Lunev wrote: > deduplicate copy/paste arithmetcs > > Signed-off-by: Denis V. Lunev > Reviewed-by: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-

[Qemu-devel] About address mapping between host and guest in QEMU

2015-04-22 Thread Wenjie Liu
Hi all, I have a little problem about the address mapping between host and guest in QEMU. I have got the guest physical address and the host virtual base address of guest's memory space which by check the ramblocks list. So, can I access to the guest's memory content by simply add the guest physi

Re: [Qemu-devel] [PATCH 15/27] block/parallels: keep BAT bitmap data in little endian in memory

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:09PM +0300, Denis V. Lunev wrote: > This will allow to use this data as buffer to BAT update directly > without any intermediate buffers. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c

Re: [Qemu-devel] [PATCH 16/27] block/parallels: read parallels image header and BAT into single buffer

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:10PM +0300, Denis V. Lunev wrote: > This metadata cache would allow to properly batch BAT updates to disk > in next patches. These updates will be properly aligned to avoid > read-modify-write transactions on block level. > > Signed-off-by: Denis V. Lunev > Reviewed-

Re: [Qemu-devel] [PATCH 17/27] block/parallels: move parallels_open/probe to the very end of the file

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:11PM +0300, Denis V. Lunev wrote: > This will help to avoid forward declarations for upcoming parallels_check > > Some very obvious formatting fixes were made to the moved code to make > checkpatch happy. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Roman Kagan

Re: [Qemu-devel] [PATCH 12/12 v9] target-tilegx: Generate tcg instructions to execute to 1st system call

2015-04-22 Thread Chen Gang
On 4/22/15 05:31, Peter Maydell wrote: > On 21 April 2015 at 22:23, Chen Gang wrote: >> On 4/22/15 05:15, Peter Maydell wrote: >>> will work in place of both of the above (and does this CPU >>> really only have two kinds of compare-immediate? Some of the >>> case labels suggest not, so it would be

Re: [Qemu-devel] [PATCH 18/27] block/parallels: implement parallels_check method of block driver

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:12PM +0300, Denis V. Lunev wrote: > The check is very simple at the moment. It calculates necessary stats > and fix only the following errors: > - space leak at the end of the image. This would happens due to > preallocation > - clusters outside the image are zeroed.

Re: [Qemu-devel] [PATCH 19/27] block/parallels: implement incorrect close detection

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:13PM +0300, Denis V. Lunev wrote: > The software driver must set inuse field in Parallels header to > 0x746F6E59 when the image is opened in read-write mode. The presence of > this magic in the header on open forces image consistency check. > > There is an unfortunate

Re: [Qemu-devel] [PATCH] target-arm: Adjust id_aa64pfr0 when has_el3 CPU property disabled

2015-04-22 Thread Greg Bellows
On Tue, Apr 21, 2015 at 9:18 PM, Sergey Fedorov wrote: > Signed-off-by: Sergey Fedorov > --- > target-arm/cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target-arm/cpu.c b/target-arm/cpu.c > index 986f04c..327b1e5 100644 > --- a/target-arm/cpu.c > +++ b/target-

Re: [Qemu-devel] [PATCH 20/27] iotests, parallels: check for incorrectly closed image in tests

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:14PM +0300, Denis V. Lunev wrote: > Signed-off-by: Denis V. Lunev > Reviwed-by: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > tests/qemu-iotests/115 | 9 + > tests/qemu-iotests/115.out | 17 + > 2 files changed, 26 inserti

Re: [Qemu-devel] [PATCH 21/27] block/parallels: no need to flush on each block allocation table update

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:15PM +0300, Denis V. Lunev wrote: > From the point of guest each write to real disk prior to disk barrier > operation could be lost. Therefore there is no problem that "not synced" > new block is lost due to not updated allocation table if QEMU is crashed. > This situa

Re: [Qemu-devel] [PATCH 21/27] block/parallels: no need to flush on each block allocation table update

2015-04-22 Thread Denis V. Lunev
On 22/04/15 17:05, Stefan Hajnoczi wrote: On Wed, Mar 11, 2015 at 01:28:15PM +0300, Denis V. Lunev wrote: From the point of guest each write to real disk prior to disk barrier operation could be lost. Therefore there is no problem that "not synced" new block is lost due to not updated allocatio

Re: [Qemu-devel] [PATCH 22/27] block/parallels: improve image reading performance

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:16PM +0300, Denis V. Lunev wrote: > Try to perform IO for the biggest continuous block possible. > The performance for sequential read is increased from 220 Gb/sec to > 360 Gb/sec for continous image on my SSD HDD. Please, can I have your SSD drive? :) Did you mean M

Re: [Qemu-devel] [PATCH 22/27] block/parallels: improve image reading performance

2015-04-22 Thread Denis V. Lunev
On 22/04/15 17:11, Stefan Hajnoczi wrote: On Wed, Mar 11, 2015 at 01:28:16PM +0300, Denis V. Lunev wrote: Try to perform IO for the biggest continuous block possible. The performance for sequential read is increased from 220 Gb/sec to 360 Gb/sec for continous image on my SSD HDD. Please, can I

Re: [Qemu-devel] [PATCH 23/27] block/parallels: create bat_entry_off helper

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:17PM +0300, Denis V. Lunev wrote: > calculate offset of the BAT entry in the image file. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 15 +-- > 1 file changed, 9 insert

Re: [Qemu-devel] [PATCH 24/27] block/parallels: delay writing to BAT till bdrv_co_flush_to_os

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:18PM +0300, Denis V. Lunev wrote: > The idea is that we do not need to immediately sync BAT to the image as > from the guest point of view there is a possibility that IO is lost > even in the physical controller until flush command was finished. > bdrv_co_flush_to_os i

Re: [Qemu-devel] [PATCH v3 0/27] write/create for Parallels images with reasonable performance

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:27:54PM +0300, Denis V. Lunev wrote: > This patchset provides an ability to create of/write to Parallels > images and some testing of the new code. Readings and writings are > optimized out and I expect the same or slightly better performance > as qcow2. > > This patchse

Re: [Qemu-devel] [PATCH 26/27] block/parallels: optimize linear image expansion

2015-04-22 Thread Stefan Hajnoczi
On Wed, Mar 11, 2015 at 01:28:20PM +0300, Denis V. Lunev wrote: > Plain image expansion spends a lot of time to update image file size. > This seriously affects the performance. The following simple test > qemu_img create -f parallels -o cluster_size=64k ./1.hds 64G > qemu_io -n -c "write -P 0x

Re: [Qemu-devel] [PATCH] x86: Fix Opteron xlevels

2015-04-22 Thread Eduardo Habkost
On Tue, Apr 21, 2015 at 04:15:14PM +0200, Alexander Graf wrote: > On 04/21/2015 04:16 PM, Eduardo Habkost wrote: > >On Tue, Apr 21, 2015 at 04:04:21PM +0200, Alexander Graf wrote: > >>The AMD Opteron family has different xlevel levels depending on the > >>generation. I looked up Gen1, Gen2 and Gen3

Re: [Qemu-devel] [PATCH v3 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-22 Thread Cornelia Huck
On Tue, 21 Apr 2015 18:51:10 +0800 shannon.z...@linaro.org wrote: I'd drop the leading "hw/net/" from the subject. > From: Shannon Zhao > > Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. > The transports just sync the host features from backend. > Meanwhile move virtio_net_set_confi

Re: [Qemu-devel] [PATCH 26/27] block/parallels: optimize linear image expansion

2015-04-22 Thread Denis V. Lunev
On 22/04/15 17:18, Stefan Hajnoczi wrote: On Wed, Mar 11, 2015 at 01:28:20PM +0300, Denis V. Lunev wrote: Plain image expansion spends a lot of time to update image file size. This seriously affects the performance. The following simple test qemu_img create -f parallels -o cluster_size=64k ./

Re: [Qemu-devel] [PATCH 2/5] scripts: qmp-shell: add support for [] expressions

2015-04-22 Thread Eric Blake
On 04/21/2015 08:02 PM, John Snow wrote: > qmp-shell currently allows you to describe values as > JSON expressions: > > key={"key":{"key2":"val"}} > > But it does not currently support arrays, which are needed > for serializing and deserializing transactions: > > key=[{"type":"drive-backup","dat

Re: [Qemu-devel] [PATCH 2/5] scripts: qmp-shell: add support for [] expressions

2015-04-22 Thread John Snow
On 04/22/2015 10:28 AM, Eric Blake wrote: On 04/21/2015 08:02 PM, John Snow wrote: qmp-shell currently allows you to describe values as JSON expressions: key={"key":{"key2":"val"}} But it does not currently support arrays, which are needed for serializing and deserializing transactions: key

Re: [Qemu-devel] [PATCH 3/5] scripts: qmp-shell: allow single-quotes in JSON expressions

2015-04-22 Thread Eric Blake
On 04/21/2015 08:02 PM, John Snow wrote: > As a convenience for the user, replace any single quotes given > with double quotes so that the data will deserialize correctly > via json.loads(). > > Signed-off-by: John Snow > --- > scripts/qmp/qmp-shell | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: do lazy allocation of the L2 cache

2015-04-22 Thread Alberto Garcia
On Wed 22 Apr 2015 12:26:02 PM CEST, Stefan Hajnoczi wrote: >> Large disk images need large L2 caches in order to maximize their I/O >> performance. However setting a correct size for the cache is not >> necessarily easy since apart from the image size, it also depends on >> other factors like its

Re: [Qemu-devel] [PATCH 3/5] scripts: qmp-shell: allow single-quotes in JSON expressions

2015-04-22 Thread John Snow
On 04/22/2015 10:34 AM, Eric Blake wrote: On 04/21/2015 08:02 PM, John Snow wrote: As a convenience for the user, replace any single quotes given with double quotes so that the data will deserialize correctly via json.loads(). Signed-off-by: John Snow --- scripts/qmp/qmp-shell | 2 +- 1 f

Re: [Qemu-devel] [PATCH 4/5] scripts: qmp-shell: add transaction subshell

2015-04-22 Thread Eric Blake
On 04/21/2015 08:02 PM, John Snow wrote: > Add a special processing mode to craft transactions. > > By entering "transaction(" the shell will enter a special > mode where each subsequent command will be saved as a transaction > instead of executed as an individual command. > > The transaction can

Re: [Qemu-devel] [PATCH 5/5] scripts: qmp-shell: Add verbose flag

2015-04-22 Thread Eric Blake
On 04/21/2015 08:02 PM, John Snow wrote: > Add a verbose flag that shows the QMP command that was > constructed, to allow for later copy/pasting, reference, > debugging, etc. Very useful. > > Signed-off-by: John Snow > --- > scripts/qmp/qmp-shell | 21 - > 1 file changed, 1

Re: [Qemu-devel] [PATCH 1/5] scripts: qmp-shell: refactor helpers

2015-04-22 Thread Eric Blake
On 04/21/2015 08:02 PM, John Snow wrote: > Refactor the qmp-shell command line processing function > into two components. This will be used to allow sub-expressions, > which will assist us in adding transactional support to qmp-shell. > > Signed-off-by: John Snow > --- > scripts/qmp/qmp-shell |

Re: [Qemu-devel] [PATCH] x86: Fix Opteron xlevels

2015-04-22 Thread Alexander Graf
On 04/22/2015 04:23 PM, Eduardo Habkost wrote: On Tue, Apr 21, 2015 at 04:15:14PM +0200, Alexander Graf wrote: On 04/21/2015 04:16 PM, Eduardo Habkost wrote: On Tue, Apr 21, 2015 at 04:04:21PM +0200, Alexander Graf wrote: The AMD Opteron family has different xlevel levels depending on the gene

  1   2   3   >