Re: [Qemu-devel] [RFC PATCH COLO v2 12/13] skip nbd_target when starting block replication

2015-03-26 Thread Fam Zheng
On Wed, 03/25 17:36, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > block.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/block.c b/block.c > index bd7fa9c..3af5ad4 100644 > --- a/block.c > +++ b/

Re: [Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS

2015-03-26 Thread Wen Congyang
On 03/26/2015 03:07 PM, Fam Zheng wrote: > On Wed, 03/25 17:36, Wen Congyang wrote: >> When opening BDS, we need to create backup jobs for >> image-fleecing. > > How does this commit message relate to the Makefile change? Hmm, we need to use backup API in block.c, and block.o will be used by qemu

Re: [Qemu-devel] [RFC PATCH COLO v2 12/13] skip nbd_target when starting block replication

2015-03-26 Thread Wen Congyang
On 03/26/2015 03:03 PM, Fam Zheng wrote: > On Wed, 03/25 17:36, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> --- >> block.c | 18 ++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/block.c b/block.c >> ind

Re: [Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS

2015-03-26 Thread Fam Zheng
On Wed, 03/25 17:36, Wen Congyang wrote: > When opening BDS, we need to create backup jobs for > image-fleecing. How does this commit message relate to the Makefile change? > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Cc: Jeff Cody > --- > block/

Re: [Qemu-devel] [RFC PATCH COLO v2 04/13] Add new block driver interfaces to control block replication

2015-03-26 Thread Fam Zheng
On Wed, 03/25 17:36, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Cc: Luiz Capitulino > Cc: Michael Roth > --- > block.c | 39 +++ > include/block/block.h | 4 > incl

Re: [Qemu-devel] [RFC PATCH COLO v2 01/13] docs: block replication's description

2015-03-26 Thread Wen Congyang
On 03/26/2015 02:31 PM, Fam Zheng wrote: > On Wed, 03/25 17:36, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: Paolo Bonzini >> Signed-off-by: Yang Hongyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> --- >> docs/block-replication.txt | 147 >> +

Re: [Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS

2015-03-26 Thread Fam Zheng
On Thu, 03/26 15:14, Wen Congyang wrote: > On 03/26/2015 03:07 PM, Fam Zheng wrote: > > On Wed, 03/25 17:36, Wen Congyang wrote: > >> When opening BDS, we need to create backup jobs for > >> image-fleecing. > > > > How does this commit message relate to the Makefile change? > > Hmm, we need to us

Re: [Qemu-devel] [RFC PATCH COLO v2 04/13] Add new block driver interfaces to control block replication

2015-03-26 Thread Wen Congyang
On 03/26/2015 03:12 PM, Fam Zheng wrote: > On Wed, 03/25 17:36, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> Cc: Luiz Capitulino >> Cc: Michael Roth >> --- >> block.c | 39

Re: [Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS

2015-03-26 Thread Wen Congyang
On 03/26/2015 03:18 PM, Fam Zheng wrote: > On Thu, 03/26 15:14, Wen Congyang wrote: >> On 03/26/2015 03:07 PM, Fam Zheng wrote: >>> On Wed, 03/25 17:36, Wen Congyang wrote: When opening BDS, we need to create backup jobs for image-fleecing. >>> >>> How does this commit message relate to t

Re: [Qemu-devel] [RFC PATCH COLO v2 06/13] NBD client: implement block driver interfaces for block replication

2015-03-26 Thread Fam Zheng
On Wed, 03/25 17:36, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > block/nbd.c | 49 + > 1 file changed, 49 insertions(+) > > diff --git a/block/nbd.c b/block/nbd.c > index 3faf8

Re: [Qemu-devel] [RFC PATCH COLO v2 06/13] NBD client: implement block driver interfaces for block replication

2015-03-26 Thread Wen Congyang
On 03/26/2015 03:21 PM, Fam Zheng wrote: > On Wed, 03/25 17:36, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> --- >> block/nbd.c | 49 + >> 1 file changed, 49 insertions(+) >> >> di

Re: [Qemu-devel] [RFC PATCH COLO v2 09/13] block: Parse "backing_reference" option to reference existing BDS

2015-03-26 Thread Fam Zheng
On Wed, 03/25 17:36, Wen Congyang wrote: > Usage: > -drive file=xxx,id=Y, \ > -drive > file=,id=X,backing_reference.drive_id=Y,backing_reference.hidden-disk.* > > It will create such backing chain: >{virtio-blk dev 'Y'} > {virtio-blk dev '

[Qemu-devel] [PATCH] virtio-scsi-dataplane: fix memory leak for VirtIOSCSIVring

2015-03-26 Thread Ting Wang
VirtIOSCSIVring which allocated in virtio_scsi_vring_init should be free when dataplane has been stopped or failed to start. Signed-off-by: Ting Wang --- hw/scsi/virtio-scsi-dataplane.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scs

Re: [Qemu-devel] [PATCH v8 0/9] rocker: add new rocker ethernet switch device

2015-03-26 Thread Scott Feldman
Ping On Fri, Mar 13, 2015 at 9:09 PM, wrote: > From: Scott Feldman > > v8: > > - From Stefan Hajnoczi's net-pull-request v3, merge in these changes: > - Squash David Ahern's clang struct definition warnings fix > - Squash in Jiri's fix for rocker format string specifiers [Peter] >

Re: [Qemu-devel] [PATCH v5 01/28] qapi: Document type-safety considerations

2015-03-26 Thread Markus Armbruster
Copyright note question, copying Michael. Eric Blake writes: > On 03/25/2015 12:31 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Go into more details about the various types of valid expressions >>> in a qapi schema, including tweaks to document fixes being done >>> later in the cur

Re: [Qemu-devel] [v7][PATCH 03/10] piix: create host bridge to passthrough

2015-03-26 Thread Chen, Tiejun
Michael and Gerd, I don't see any more comments for this revision, so what's next that I should do? Thanks Tiejun On 2015/3/19 9:01, Chen, Tiejun wrote: On 2015/3/18 18:21, Gerd Hoffmann wrote: On Mi, 2015-03-18 at 17:06 +0800, Tiejun Chen wrote: Implement a pci host bridge specific to pas

Re: [Qemu-devel] [PATCH v5 01/28] qapi: Document type-safety considerations

2015-03-26 Thread Markus Armbruster
Eric Blake writes: > On 03/25/2015 12:31 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Go into more details about the various types of valid expressions >>> in a qapi schema, including tweaks to document fixes being done >>> later in the current patch series. Also fix some stale an

Re: [Qemu-devel] [v7][PATCH 03/10] piix: create host bridge to passthrough

2015-03-26 Thread Michael S. Tsirkin
On Thu, Mar 26, 2015 at 03:57:18PM +0800, Chen, Tiejun wrote: > Michael and Gerd, > > I don't see any more comments for this revision, so what's next that I > should do? > > Thanks > Tiejun > > On 2015/3/19 9:01, Chen, Tiejun wrote: It's only been a week, and we are busy finalizing 2.3. So ple

Re: [Qemu-devel] [v7][PATCH 03/10] piix: create host bridge to passthrough

2015-03-26 Thread Chen, Tiejun
On 2015/3/26 16:15, Michael S. Tsirkin wrote: On Thu, Mar 26, 2015 at 03:57:18PM +0800, Chen, Tiejun wrote: Michael and Gerd, I don't see any more comments for this revision, so what's next that I should do? Thanks Tiejun On 2015/3/19 9:01, Chen, Tiejun wrote: It's only been a week, and we

Re: [Qemu-devel] [Qemu-block] [RFC PATCH COLO v2 01/13] docs: block replication's description

2015-03-26 Thread Wen Congyang
On 03/25/2015 11:38 PM, Eric Blake wrote: > On 03/25/2015 03:36 AM, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: Paolo Bonzini >> Signed-off-by: Yang Hongyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> --- >> docs/block-replication.txt | 147 >> +

Re: [Qemu-devel] [PATCH v5 01/28] qapi: Document type-safety considerations

2015-03-26 Thread Markus Armbruster
Eric Blake writes: > On 03/25/2015 02:11 PM, Eric Blake wrote: > >>> The QObject types are QTYPE_NONE, QTYPE_QINT, QTYPE_QSTRING, >>> QTYPE_QDICT, QTYPE_QLIST, QTYPE_QFLOAT, QTYPE_QBOOL, QTYPE_QERROR. >>> >>> The connections JSON string - QTYPE_QSTRING, JSON object - QTYPE_QDICT, >>> JSON array -

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-26 Thread Andrey Korolyov
On Thu, Mar 26, 2015 at 5:47 AM, Bandan Das wrote: > Hi Andrey, > > Andrey Korolyov writes: > >> On Mon, Mar 16, 2015 at 10:17 PM, Andrey Korolyov wrote: >>> For now, it looks like bug have a mixed Murphy-Heisenberg nature, as >>> it appearance is very rare (compared to the number of actual laun

Re: [Qemu-devel] Support for NetLogic XLP Processors

2015-03-26 Thread Leon Alrae
Hi Duarte, On 25/03/2015 23:54, Duarte Silva wrote: > On Wednesday 25 March 2015 17:33:59 Leon Alrae wrote: >> On 25/03/2015 15:38, Duarte Silva wrote: >>> On Wednesday 25 March 2015 14:54:41 Leon Alrae wrote: On 25/03/2015 14:44, Leon Alrae wrote: > Hi Duarte, > > On 25/03/2015 1

Re: [Qemu-devel] Support for NetLogic XLP Processors

2015-03-26 Thread James Hogan
On 26/03/15 09:29, Leon Alrae wrote: > Hi Duarte, > > On 25/03/2015 23:54, Duarte Silva wrote: >> On Wednesday 25 March 2015 17:33:59 Leon Alrae wrote: >>> On 25/03/2015 15:38, Duarte Silva wrote: On Wednesday 25 March 2015 14:54:41 Leon Alrae wrote: > On 25/03/2015 14:44, Leon Alrae wrot

Re: [Qemu-devel] [Qemu-discuss] error - Guest has not initialized the display yet.

2015-03-26 Thread Peter Maydell
On 25 March 2015 at 23:52, Programmingkid wrote: > I'm seeing this error also. It's still not an error. > When I try to boot Mac OS 10.2 in > qemu-system-ppc, I just see a black window. When I switch from the monitor > to the vga window, then I see "Guest has not initialized the display (yet)".

Re: [Qemu-devel] [PATCH v5 02/28] qapi: Fix generation of 'size' builtin type

2015-03-26 Thread Markus Armbruster
Eric Blake writes: > We were missing the 'size' builtin type (which means that QAPI using > [ 'size' ] would fail to compile). I suspect it chokes on 'size' in anonymous unions, too. > Futhermore, there was some > redundancy between builtin_types[] and builti

Re: [Qemu-devel] [PATCH v5 03/28] qapi: Require ASCII in schema

2015-03-26 Thread Markus Armbruster
Eric Blake writes: > On 03/24/2015 02:03 PM, Eric Blake wrote: >> Python 2 and Python 3 have a wild history of whether strings >> default to ascii or unicode, where Python 3 requires checking >> instanceof(foo, basestr) to cover all strings, but where that >> code is not portable to Python 2. It

Re: [Qemu-devel] Support for NetLogic XLP Processors

2015-03-26 Thread Duarte Silva
On Thursday 26 March 2015 09:34:14 James Hogan wrote: > On 26/03/15 09:29, Leon Alrae wrote: > > Hi Duarte, > > > > On 25/03/2015 23:54, Duarte Silva wrote: > >> On Wednesday 25 March 2015 17:33:59 Leon Alrae wrote: > >>> On 25/03/2015 15:38, Duarte Silva wrote: > On Wednesday 25 March 2015 1

Re: [Qemu-devel] [PATCH v5 04/28] qapi: Add some enum tests

2015-03-26 Thread Markus Armbruster
Eric Blake writes: > Demonstrate that the qapi generator doesn't deal well with enums > that aren't up to par. Later patches will update the expected > results as the generator is made stricter. > > Signed-off-by: Eric Blake This is v4 plus the new enum-union-clash test. Reviewed-by: Markus Ar

Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl

2015-03-26 Thread Igor Mammedov
On Wed, 25 Mar 2015 23:47:46 +0800 Lin Ma wrote: > > 在 2015年03月23日 21:30, Igor Mammedov 写道: > > On Mon, 23 Mar 2015 14:13:07 +0100 > > Andreas Färber wrote: > > > >> Hi, > >> > >> For consistency in git-log, please use "qom:" rather than "object:". > >> > >> Am 23.03.2015 um 13:06 schrieb Paolo

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-26 Thread Ian Campbell
On Thu, 2015-03-26 at 08:53 +0800, Chen, Tiejun wrote: > > Hrm, OK. I suppose we can live with autodetect and igd both meaning igd > > and whoever adds a new type will have to remember to add a check for > > qemu-trad then. > > > > When we really have to introduce a new type, this means we probabl

Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl

2015-03-26 Thread Andreas Färber
Am 26.03.2015 um 11:05 schrieb Igor Mammedov: > On Wed, 25 Mar 2015 23:47:46 +0800 > Lin Ma wrote: >> 在 2015年03月23日 21:30, Igor Mammedov 写道: >>> On Mon, 23 Mar 2015 14:13:07 +0100 >>> Andreas Färber wrote: Am 23.03.2015 um 13:06 schrieb Paolo Bonzini: > On 23/03/2015 11:36, Peter Crosthw

Re: [Qemu-devel] [PATCH v5 05/28] qapi: Better error messages for bad enums

2015-03-26 Thread Markus Armbruster
Eric Blake writes: > The previous commit demonstrated that the generator had several > flaws with less-than-perfect enums: > - an enum that listed the same string twice (or two variant > strings that map to the same C enumerator) ended up generating > an invalid C enum > - because the generator a

Re: [Qemu-devel] [v6 08/14] migration: Add the core code of multi-thread compression

2015-03-26 Thread Juan Quintela
"Li, Liang Z" wrote: >> > --- a/arch_init.c >> > +++ b/arch_init.c >> > @@ -355,12 +355,33 @@ static DecompressParam *decomp_param; static >> > QemuThread *decompress_threads; static uint8_t >> *compressed_data_buf; >> > >> > +static int do_compress_ram_page(CompressParam *param); >> > + >> > s

Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl

2015-03-26 Thread Igor Mammedov
On Thu, 26 Mar 2015 11:07:27 +0100 Andreas Färber wrote: > Am 26.03.2015 um 11:05 schrieb Igor Mammedov: > > On Wed, 25 Mar 2015 23:47:46 +0800 > > Lin Ma wrote: > >> 在 2015年03月23日 21:30, Igor Mammedov 写道: > >>> On Mon, 23 Mar 2015 14:13:07 +0100 > >>> Andreas Färber wrote: > Am 23.03.2015

Re: [Qemu-devel] [Qemu-block] [RFC PATCH COLO v2 01/13] docs: block replication's description

2015-03-26 Thread Gonglei
On 2015/3/26 16:58, Wen Congyang wrote: > On 03/25/2015 11:38 PM, Eric Blake wrote: >> > On 03/25/2015 03:36 AM, Wen Congyang wrote: >>> >> Signed-off-by: Wen Congyang >>> >> Signed-off-by: Paolo Bonzini >>> >> Signed-off-by: Yang Hongyang >>> >> Signed-off-by: zhanghailiang >>> >> Signed-off-b

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-03-26 Thread Juan Quintela
Wen Congyang wrote: > On 03/25/2015 05:50 PM, Juan Quintela wrote: >> zhanghailiang wrote: >>> Hi all, >>> >>> We found that, sometimes, the content of VM's memory is >>> inconsistent between Source side and Destination side >>> when we check it just after finishing migration but before VM contin

Re: [Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread

2015-03-26 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:51:53PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Rework the migration thread to setup and start postcopy. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > incl

Re: [Qemu-devel] [PATCH v11 2/4] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-03-26 Thread Alex Bennée
Eric Auger writes: > Device tree nodes for the platform bus and its children dynamic sysbus > devices are added in a machine init done notifier. To load the dtb once, > after those latter nodes are built and before ROM freeze, the actual > arm_load_kernel existing code is moved into a notifier n

[Qemu-devel] [PATCH] vhost: fix typo in vq_index description

2015-03-26 Thread Greg Kurz
Signed-off-by: Greg Kurz --- include/hw/virtio/vhost.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h index 71ef18f..88e1e56 100644 --- a/include/hw/virtio/vhost.h +++ b/include/hw/virtio/vhost.h @@ -36,7 +36,7 @@ struc

[Qemu-devel] [PATCH v3 5/6] virtio-input: emulated devices

2015-03-26 Thread Gerd Hoffmann
This patch adds the virtio-input-hid base class and virtio-{keyboard,mouse,tablet} subclasses building on the base class. They are hooked up to the qemu input core and deliver input events to the guest like all other hid devices (ps/2 kbd, usb tablet, ...). Using them is as simple as adding "-devi

[Qemu-devel] [PATCH v3 6/6] virtio-input: evdev passthrough

2015-03-26 Thread Gerd Hoffmann
This allows to assign host input devices to the guest: qemu -device virto-input-host-pci,evdev=/dev/input/event The guest gets exclusive access to the input device, so be careful with assigning the keyboard if you have only one connected to your machine. Signed-off-by: Gerd Hoffmann --- hw/inp

[Qemu-devel] [PATCH v3 0/6] virtio: add input device

2015-03-26 Thread Gerd Hoffmann
This patch series adds virtio input devices. It's basically sending linux evdev events over virtio. There is support for emulated hid devices (i.e. send usual input to virtio device instead of usb or ps2 device) and for evdev device pass-through. This depends on mst's virtio-1.0 patches. Change

[Qemu-devel] [PATCH v3 2/6] virtio-input: add virtio_input.h

2015-03-26 Thread Gerd Hoffmann
Using scripts/update-linux-headers.sh with linux-input kernel branch. Signed-off-by: Gerd Hoffmann --- include/standard-headers/linux/virtio_ids.h | 1 + include/standard-headers/linux/virtio_input.h | 76 +++ 2 files changed, 77 insertions(+) create mode 100644 inclu

[Qemu-devel] [PATCH v3 4/6] virtio-input: core code & base class

2015-03-26 Thread Gerd Hoffmann
This patch adds virtio-input support to qemu. It brings a abstract base class providing core support, other classes can build on it to actually implement input devices. virtio-input basically sends linux input layer events (evdev) over virtio. Signed-off-by: Gerd Hoffmann --- hw/input/Makefile

[Qemu-devel] [PATCH v3 3/6] virtio-input: add linux/input.h

2015-03-26 Thread Gerd Hoffmann
Linux input layer (evdev) header file. Signed-off-by: Gerd Hoffmann --- include/standard-headers/linux/input.h | 1198 scripts/update-linux-headers.sh|4 +- 2 files changed, 1201 insertions(+), 1 deletion(-) create mode 100644 include/standard-header

[Qemu-devel] [PATCH v3 1/6] pci: add PCI_CLASS_INPUT_*

2015-03-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/pci/pci_ids.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h index d7be386..dfccefc 100644 --- a/include/hw/pci/pci_ids.h +++ b/include/hw/pci/pci_ids.h @@ -46,6 +46,13 @@ #define PCI_CLAS

Re: [Qemu-devel] [PATCH v11 4/4] hw/arm/virt: change indentation in a15memmap

2015-03-26 Thread Alex Bennée
Eric Auger writes: > Re-indent in a15memmap after VIRT_PLATFORM_BUS introduction > > Signed-off-by: Eric Auger Reviewed-by: Alex Bennée > --- > hw/arm/virt.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c >

Re: [Qemu-devel] [PATCH v11 3/4] hw/arm/virt: add dynamic sysbus device support

2015-03-26 Thread Alex Bennée
Eric Auger writes: > Allows sysbus devices to be instantiated from command line by > using -device option. Machvirt creates a platform bus at init. > The dynamic sysbus devices are attached to this platform bus device. > > The platform bus device registers a machine init done notifier > whose ro

Re: [Qemu-devel] [PATCH v5 20/45] Modify savevm handlers for postcopy

2015-03-26 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Mar 25, 2015 at 04:40:11PM +, Dr. David Alan Gilbert wrote: > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > > On Tue, Mar 24, 2015 at 08:04:14PM +, Dr. Dav

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-03-26 Thread Michael S. Tsirkin
On Thu, Mar 26, 2015 at 11:29:43AM +0100, Juan Quintela wrote: > Wen Congyang wrote: > > On 03/25/2015 05:50 PM, Juan Quintela wrote: > >> zhanghailiang wrote: > >>> Hi all, > >>> > >>> We found that, sometimes, the content of VM's memory is > >>> inconsistent between Source side and Destination

Re: [Qemu-devel] [PATCH v5 40/45] Postcopy; Handle userfault requests

2015-03-26 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:52:03PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > userfaultfd is a Linux syscall that gives an fd that receives a stream > > of notifications of accesses to pages registere

Re: [Qemu-devel] [PULL for v2.3 00/01] seccomp branch queue

2015-03-26 Thread Peter Maydell
On 25 March 2015 at 10:26, Eduardo Otubo wrote: > The following changes since commit 054903a832b865eb5432d79b5c9d1e1ff31b58d7: > > Update version for v2.3.0-rc1 release (2015-03-24 16:34:16 +) > > are available in the git repository at: > > git://github.com/otubo/qemu.git tags/pull-seccomp

Re: [Qemu-devel] [PATCH v11 1/4] hw/arm/sysbus-fdt: helpers for platform bus nodes addition

2015-03-26 Thread Alex Bennée
Eric Auger writes: > This new C module will be used by ARM machine files to generate > platform bus node and their dynamic sysbus device tree nodes. > > Dynamic sysbus device node addition is done in a machine init > done notifier. arm_register_platform_bus_fdt_creator does the > registration of

Re: [Qemu-devel] [Qemu-block] [RFC PATCH COLO v2 01/13] docs: block replication's description

2015-03-26 Thread Eric Blake
On 03/26/2015 04:28 AM, Gonglei wrote: Grammar review only (I'll leave the technical review to others) >> +Copyright Fujitsu, Corp. 2015 >> +Copyright (c) 2015 Intel Corporation >> +Copyright (c) 2015 HUAWEI TECHNOLOGIES CO.,LTD. Space after comma in English writin

Re: [Qemu-devel] [Qemu-block] [RFC PATCH COLO v2 01/13] docs: block replication's description

2015-03-26 Thread Gonglei
On 2015/3/26 20:30, Eric Blake wrote: > On 03/26/2015 04:28 AM, Gonglei wrote: > > Grammar review only (I'll leave the technical review to others) > > >>> +Copyright Fujitsu, Corp. 2015 >>> +Copyright (c) 2015 Intel Corporation >>> +Copyright (c) 2015 HUAWEI TECHNOLOGIES CO.,L

Re: [Qemu-devel] [PATCH] configure: Add support for tcmalloc

2015-03-26 Thread Kevin Wolf
Am 26.03.2015 um 04:03 hat Fam Zheng geschrieben: > This adds "--enable-tcmalloc" and "--disable-tcmalloc" to allow linking > to libtcmalloc from gperftools. > > tcmalloc is a malloc implementation that works well with threads and is > fast, so it is good for performance. > > It is disabled by de

[Qemu-devel] [PATCH] misc: fix typos in copyright declaration

2015-03-26 Thread arei.gonglei
From: Gonglei Add a space after comma. Signed-off-by: Gonglei --- bootdevice.c | 2 +- tests/usb-hcd-ohci-test.c | 2 +- tests/usb-hcd-uhci-test.c | 2 +- tests/usb-hcd-xhci-test.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bootdevice.c b/bootdevice.c i

Re: [Qemu-devel] [PATCH] misc: fix typos in copyright declaration

2015-03-26 Thread Eric Blake
On 03/26/2015 06:57 AM, arei.gong...@huawei.com wrote: > From: Gonglei > > Add a space after comma. > > Signed-off-by: Gonglei > --- > bootdevice.c | 2 +- > tests/usb-hcd-ohci-test.c | 2 +- > tests/usb-hcd-uhci-test.c | 2 +- > tests/usb-hcd-xhci-test.c | 2 +- > 4 files changed

Re: [Qemu-devel] [PATCH] configure: Add support for tcmalloc

2015-03-26 Thread Paolo Bonzini
On 26/03/2015 13:53, Kevin Wolf wrote: > Am 26.03.2015 um 04:03 hat Fam Zheng geschrieben: >> This adds "--enable-tcmalloc" and "--disable-tcmalloc" to allow linking >> to libtcmalloc from gperftools. >> >> tcmalloc is a malloc implementation that works well with threads and is >> fast, so it is

Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests

2015-03-26 Thread Markus Armbruster
Eric Blake writes: > Demonstrate that the qapi generator doesn't deal well with unions > that aren't up to par. Later patches will update the expected > reseults as the generator is made stricter. > > Of particular note, we currently allow 'base' without 'discriminator' > as a way to create a sim

Re: [Qemu-devel] Bouncing maintainers

2015-03-26 Thread Kevin Wolf
Am 25.03.2015 um 16:45 hat John Snow geschrieben: > > > On 03/25/2015 10:48 AM, Markus Armbruster wrote: > >I just had another cc: to an address gotten from MAINTAINERS bounce with > >"user unknown". > > > >How do we weed out dead MAINTAINERS entries? > > > > Automated spambot that runs once a r

Re: [Qemu-devel] [PATCH] virtio-scsi-dataplane: fix memory leak for VirtIOSCSIVring

2015-03-26 Thread Paolo Bonzini
On 26/03/2015 08:42, Ting Wang wrote: > VirtIOSCSIVring which allocated in virtio_scsi_vring_init > should be free when dataplane has been stopped or failed to start. > > Signed-off-by: Ting Wang > --- > hw/scsi/virtio-scsi-dataplane.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --

Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests

2015-03-26 Thread Markus Armbruster
One more: [...] > diff --git a/tests/qapi-schema/alternate-conflict-string.json > b/tests/qapi-schema/alternate-conflict-string.json > new file mode 100644 > index 000..5fd1a47 > --- /dev/null > +++ b/tests/qapi-schema/alternate-conflict-string.json > @@ -0,0 +1,8 @@ > +# FIXME: we should rej

Re: [Qemu-devel] [PULL 0/3] pc, virtio bugfixes for 2.3

2015-03-26 Thread Peter Maydell
On 25 March 2015 at 15:30, Michael S. Tsirkin wrote: > The following changes since commit 054903a832b865eb5432d79b5c9d1e1ff31b58d7: > > Update version for v2.3.0-rc1 release (2015-03-24 16:34:16 +) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qe

Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl

2015-03-26 Thread Paolo Bonzini
On 26/03/2015 11:29, Igor Mammedov wrote: > What value of ref, one would use to decide if deletion is possible? > > In generic case object can have ref > 1 but still be eligible for deleting > via object-del. Right, for example devices are unparented with ref > 1. Still, it could be a sane def

Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction

2015-03-26 Thread Juan Quintela
Eduardo Otubo wrote: > Libseccomp version updated to 2.2.0 and arch restriction to x86/x86_64 > is now removed. It's supposed to work on armv7l as well. > > Related bug: https://bugs.launchpad.net/qemu/+bug/1363641 > > Signed-off-by: Eduardo Otubo This prevent compliation on x86_64 on Fedora 21.

Re: [Qemu-devel] [PATCH v5 07/28] qapi: Simplify tests of simple unions

2015-03-26 Thread Markus Armbruster
Eric Blake writes: > None of the existing QMP or QGA interfaces uses a union with a > base type but no discriminator; it is easier to avoid this in > the generator to save room for other future extensions more likely > to be useful (the previous commit added the test > union-base-no-discriminator

Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests

2015-03-26 Thread Eric Blake
On 03/26/2015 07:23 AM, Markus Armbruster wrote: > One more: > > [...] >> diff --git a/tests/qapi-schema/alternate-conflict-string.json >> b/tests/qapi-schema/alternate-conflict-string.json >> new file mode 100644 >> index 000..5fd1a47 >> --- /dev/null >> +++ b/tests/qapi-schema/alternate-con

Re: [Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS

2015-03-26 Thread Paolo Bonzini
On 26/03/2015 08:23, Wen Congyang wrote: >>> >> Hmm, we need to use backup API in block.c, and block.o will >>> >> be used by qemu-img which doesn't use common-obj. >> > >> > I see. How about adding the referenced functions to stubs/? > Good idea. I will try it. Even better would be to move the

Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction

2015-03-26 Thread Juan Quintela
Juan Quintela wrote: > Eduardo Otubo wrote: >> Libseccomp version updated to 2.2.0 and arch restriction to x86/x86_64 >> is now removed. It's supposed to work on armv7l as well. >> >> Related bug: https://bugs.launchpad.net/qemu/+bug/1363641 >> >> Signed-off-by: Eduardo Otubo Just in case anyo

Re: [Qemu-devel] [PATCH 1/8] rc4030: create custom DMA address space

2015-03-26 Thread Paolo Bonzini
On 25/03/2015 20:10, Hervé Poussineau wrote: > Le 25/03/2015 15:45, Paolo Bonzini a écrit : >> >> >> On 05/03/2015 23:13, Hervé Poussineau wrote: >>> Add a new memory region in system address space where DMA address space >>> definition (the 'translation table') belongs, so we can update on the >

Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction

2015-03-26 Thread Peter Maydell
On 26 March 2015 at 14:09, Juan Quintela wrote: > Notice that you can "fix" the problem running with --qemu_sandbox=off, > but breaking the main test suite just before release looks wrong? The main test suite is "make check" :-) -- PMM

Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl

2015-03-26 Thread Igor Mammedov
On Thu, 26 Mar 2015 14:37:13 +0100 Paolo Bonzini wrote: > > > On 26/03/2015 11:29, Igor Mammedov wrote: > > What value of ref, one would use to decide if deletion is possible? > > > > In generic case object can have ref > 1 but still be eligible for deleting > > via object-del. > > Right, for

Re: [Qemu-devel] [PATCH v5 08/28] qapi: Better error messages for bad unions

2015-03-26 Thread Markus Armbruster
Subject suggests you're just polishing error messages here. In fact, you're fixing the generator to detect errors. Suggest something like qapi: Tighten checking of unions Eric Blake writes: > Previous commits demonstrated that the generator had several > flaws with less-than-perfect union

Re: [Qemu-devel] [PATCH v5 09/28] qapi: Prepare for catching more semantic parse errors

2015-03-26 Thread Markus Armbruster
Eric Blake writes: > This patch widens the scope of a try block (with the attending > reindentation required by Python) in preparation for a future > patch adding more instances of QAPIExprError inside the block. > It's easier to separate indentation from semantic changes, so > this patch has no

Re: [Qemu-devel] [PATCH 1/8] rc4030: create custom DMA address space

2015-03-26 Thread Paolo Bonzini
On 05/03/2015 23:13, Hervé Poussineau wrote: > +static const MemoryRegionOps rc4030_dma_tt_ops = { > +.impl.min_access_size = 4, > +.impl.max_access_size = 4, > +.impl.max_access_size = 4, > +}; > + > +static void rc4030_dma_tt_update(rc4030State *s, uint32_t new_tl_base, > +

Re: [Qemu-devel] [RFC] optimization for qcow2 cache get/put

2015-03-26 Thread Stefan Hajnoczi
On Mon, Jan 26, 2015 at 09:20:00PM +0800, Zhang Haoyu wrote: > Hi, all > > Regarding too large qcow2 image, e.g., 2TB, > so long disruption happened when performing snapshot, > which was caused by cache update and IO wait. I have CCed Kevin Wolf, the qcow2 maintainer. > perf top data shown as be

Re: [Qemu-devel] [PULL 2.3 0/5] ppc patch queue 2015-03-25 for 2.3

2015-03-26 Thread Peter Maydell
On 25 March 2015 at 21:54, Alexander Graf wrote: > Hi Peter, > > This is my current patch queue for ppc against 2.3. Please pull. > > Alex > > > The following changes since commit 054903a832b865eb5432d79b5c9d1e1ff31b58d7: > > Update version for v2.3.0-rc1 release (2015-03-24 16:34:16 +) > >

Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction

2015-03-26 Thread Eduardo Otubo
On Thu, Mar 26, 2015 at 02=38=55PM +0100, Juan Quintela wrote: > Eduardo Otubo wrote: > > Libseccomp version updated to 2.2.0 and arch restriction to x86/x86_64 > > is now removed. It's supposed to work on armv7l as well. > > > > Related bug: https://bugs.launchpad.net/qemu/+bug/1363641 > > > > Si

Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction

2015-03-26 Thread Eduardo Otubo
On Thu, Mar 26, 2015 at 03=09=19PM +0100, Juan Quintela wrote: > Juan Quintela wrote: > > Eduardo Otubo wrote: > >> Libseccomp version updated to 2.2.0 and arch restriction to x86/x86_64 > >> is now removed. It's supposed to work on armv7l as well. > >> > >> Related bug: https://bugs.launchpad.ne

Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction

2015-03-26 Thread Peter Maydell
On 26 March 2015 at 14:37, Eduardo Otubo wrote: > I completely understand your concern. Perhaps a ping on libseccomp > Fedora package maintainer would be a better way to tackle this issue > instead of reverting this commit. Libseccomp 2.2.0 is released since Feb > 12th and I actually gave it a lit

[Qemu-devel] [PULL 0/3] Migration pull request

2015-03-26 Thread Juan Quintela
ommit 087c4c9419d3086ac0a920899e4fed8ceaf9bb2b: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-03-26 12:18:44 +) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20150326 for you to fetc

[Qemu-devel] [PULL 2/3] rdma: Fix cleanup in error paths

2015-03-26 Thread Juan Quintela
From: Padmanabh Ratnakar As part of commit e325b49a320b493cc5d69e263751ff716dc458fe, order in which resources are destroyed was changed for fixing a seg fault. Due to this change, CQ will never get destroyed as CQ should be destroyed after QP destruction. Seg fault is caused improper cleanup when

[Qemu-devel] [PULL 3/3] migration: remove last_sent_block from save_page_header

2015-03-26 Thread Juan Quintela
Compression code (still not on tree) want to call this funtion from outside the migration thread, so we can't write to last_sent_block. Instead of reverting full patch: [PULL 07/11] save_block_hdr: we can recalculate Just revert the parts that touch last_sent_block. Signed-off-by: Juan Quintela

[Qemu-devel] [PULL 1/3] Avoid crashing on multiple -incoming

2015-03-26 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Passing multiple -incoming options used to crash qemu (due to an invalid state transition incoming->incoming). Instead we now take the last -incoming option, e.g.: qemu-system-x86_64 -nographic -incoming tcp:: -incoming defer ends up doing the defer. Signed-

Re: [Qemu-devel] [PATCH v5 10/28] qapi: Segregate anonymous unions into alternates in generator

2015-03-26 Thread Markus Armbruster
Eric Blake writes: > Special-casing 'discriminator == {}' for handling anonymous unions > is getting awkward; since this particular type is not always a > dictionary on the wire, it is easier to treat it as a completely > different class of type, "alternate", so that if a type is listed > in the

Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction

2015-03-26 Thread Juan Quintela
Peter Maydell wrote: > On 26 March 2015 at 14:37, Eduardo Otubo > wrote: >> I completely understand your concern. Perhaps a ping on libseccomp >> Fedora package maintainer would be a better way to tackle this issue >> instead of reverting this commit. Libseccomp 2.2.0 is released since Feb >> 12

Re: [Qemu-devel] [PATCH v5 11/28] qapi: Rename anonymous union type in test

2015-03-26 Thread Markus Armbruster
Eric Blake writes: > Reduce churn in the future patch that replaces anonymous unions > with a new metatype 'alternate' by changing 'AnonUnion' to > 'Alternate'. > > Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [GSoC] project proposal

2015-03-26 Thread Paolo Bonzini
On 18/03/2015 15:53, Catalin Vasile wrote: > Hi, > > My name is Catalin Vasile and I want to participate with a project for > qemu at GSoC. > From what I understand from the rules, I can participate with things I > could also use for my college projects. > This is my last bachelor year and I'm d

Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction

2015-03-26 Thread Peter Maydell
On 26 March 2015 at 14:37, Eduardo Otubo wrote: > Libseccomp 2.2.0 is released since Feb > 12th and I actually gave it a little time frame for other distros to > update their packages so we don't run into issues like this. Incidentally, "about two months" is actually a very short time between ups

Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests

2015-03-26 Thread Eric Blake
On 03/26/2015 07:18 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Demonstrate that the qapi generator doesn't deal well with unions >> that aren't up to par. Later patches will update the expected >> reseults as the generator is made stricter. >> >> Of particular note, we currently allow

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-26 Thread Andrey Korolyov
On Thu, Mar 26, 2015 at 12:18 PM, Andrey Korolyov wrote: > On Thu, Mar 26, 2015 at 5:47 AM, Bandan Das wrote: >> Hi Andrey, >> >> Andrey Korolyov writes: >> >>> On Mon, Mar 16, 2015 at 10:17 PM, Andrey Korolyov wrote: For now, it looks like bug have a mixed Murphy-Heisenberg nature, as >>>

Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction

2015-03-26 Thread Eduardo Otubo
On Thu, Mar 26, 2015 at 02=44=14PM +, Peter Maydell wrote: > On 26 March 2015 at 14:37, Eduardo Otubo > wrote: > > I completely understand your concern. Perhaps a ping on libseccomp > > Fedora package maintainer would be a better way to tackle this issue > > instead of reverting this commit.

Re: [Qemu-devel] [PATCH v5 10/28] qapi: Segregate anonymous unions into alternates in generator

2015-03-26 Thread Eric Blake
On 03/26/2015 08:47 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Special-casing 'discriminator == {}' for handling anonymous unions >> is getting awkward; since this particular type is not always a >> dictionary on the wire, it is easier to treat it as a completely >> different class of

Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction

2015-03-26 Thread Juan Quintela
Eduardo Otubo wrote: > On Thu, Mar 26, 2015 at 02=44=14PM +, Peter Maydell wrote: >> On 26 March 2015 at 14:37, Eduardo Otubo >> wrote: >> > I completely understand your concern. Perhaps a ping on libseccomp >> > Fedora package maintainer would be a better way to tackle this issue >> > inste

[Qemu-devel] [PATCH for-2.3 3/4] s390x: do not include ram_addr.h

2015-03-26 Thread Cornelia Huck
From: Paolo Bonzini ram_addr.h is an internal interface and it is not needed anyway by hw/s390x/ipl.c. Cc: Christian Borntraeger Signed-off-by: Paolo Bonzini Message-Id: <1427295389-5054-1-git-send-email-pbonz...@redhat.com> Signed-off-by: Christian Borntraeger Signed-off-by: Cornelia Huck -

[Qemu-devel] [PATCH for-2.3 4/4] s390x/ipl: avoid sign extension

2015-03-26 Thread Cornelia Huck
Make s390_update_iplstate() return uint32_t to avoid sign extensions for cssids > 127. While this doesn't matter in practice yet (as nobody supports MCSS-E and thus won't see the real cssid), play safe. Reported-by: Paolo Bonzini Reviewed-by: Jason J. Herne Signed-off-by: Cornelia Huck --- hw/

[Qemu-devel] [PATCH for-2.3 1/4] virtio-ccw: fix range check for SET_VQ

2015-03-26 Thread Cornelia Huck
VIRTIO_PCI_QUEUE_MAX is already too big; a malicious guest would be able to trigger a write beyond the VirtQueue structure. Cc: qemu-sta...@nongnu.org Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[Qemu-devel] [PATCH for-2.3 0/4] assorted s390x fixes

2015-03-26 Thread Cornelia Huck
Hi, here's what I have pending for 2.3. Paolo noticed two small problems, and I realized we have some bugs wrt accessing virtqueue indices when I reviewed Jason's support for more virtqueues patchset. I'm planning on sending a pull request on monday. Cornelia Huck (3): virtio-ccw: fix range ch

  1   2   3   >