Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-23 Thread Stefan Assmann
On 20.03.2015 21:55, jacob jacob wrote: > On Thu, Mar 19, 2015 at 10:18 AM, Stefan Assmann wrote: >> On 19.03.2015 15:04, jacob jacob wrote: >>> Hi Stefan, >>> have you been able to get PCI passthrough working without any issues >>> after the upgrade? >> >> My XL710 fails to transfer regular TCP t

Re: [Qemu-devel] [PATCH v2 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-23 Thread Gerd Hoffmann
On Fr, 2015-03-20 at 14:01 -0400, Gabriel L. Somlo wrote: > Below is "version 2.5" of the command-line fw_cfg patch only. I'll > send out a v3 of the series once we're mostly happy with this one in > particular. Approach taken looks good to me on a quick scan. cheers, Gerd

Re: [Qemu-devel] [for-2.3 PATCH v2] gitignore: Ignore more .pod files.

2015-03-23 Thread Markus Armbruster
Stefan Weil writes: > Am 20.03.2015 um 17:30 schrieb Eric Blake: >> kvm_stat.{1,pod} started showing up as untracked files in my >> directory, and I nearly accidentally merged them into a commit >> with my usual habit of 'git add .'. Rather than spelling out >> each such file, just ignore the en

Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling

2015-03-23 Thread Paolo Bonzini
On 23/03/2015 06:24, Fam Zheng wrote: > Currently, throttle timers won't make any progress when VCPU is not > running, which would stall the request queue in utils, qtest, vm > suspending, and live migration without special handling. > > For example in bdrv_drain_all, all requests are resumed im

Re: [Qemu-devel] [PATCH v2 0/2] Fix bugs in i6300esb watchdog timer

2015-03-23 Thread Paolo Bonzini
On 23/03/2015 02:51, David Gibson wrote: > This series fixes two bugs in the i6300esb watchdog timer device. The > first only affects big-endian targets (including targets like ppc > which support both endians, but are considered big-endian by default). > The second affects all targets, but only

Re: [Qemu-devel] [PATCH v2 1/2] cpu/apic: drop icc bus/bridge/

2015-03-23 Thread Igor Mammedov
On Mon, 23 Mar 2015 13:54:23 +0800 Chen Fan wrote: > ICC bus was invented only to provide hotplug capability to > CPU and APIC because at the time being hotplug was available only for > BUS attached devices. > > Now this patch is to drop ICC bus impl, and switch to bus-less > CPU+APIC hotplug, h

Re: [Qemu-devel] [PATCH v3 1/5] fw_cfg: add documentation file (docs/specs/fw_cfg.txt)

2015-03-23 Thread Laszlo Ersek
On 03/21/15 21:23, Gabriel L. Somlo wrote: > This document covers the guest-side hardware interface, as > well as the host-side programming API of QEMU's firmware > configuration (fw_cfg) device. > > Signed-off-by: Jordan Justen > Signed-off-by: Gabriel Somlo > --- > docs/specs/fw_cfg.txt | 205

[Qemu-devel] [PATCH 01/15] migration: remove last_sent_block from save_page_header

2015-03-23 Thread Liang Li
From: Juan Quintela Compression code (still not on tree) want to call this funtion from outside the migration thread, so we can't write to last_sent_block. Instead of reverting full patch: [PULL 07/11] save_block_hdr: we can recalculate Just revert the parts that touch last_sent_block. Signed

[Qemu-devel] migration: remove last_sent_block from save_page_header

2015-03-23 Thread Liang Li
From: Juan Quintela Compression code (still not on tree) want to call this funtion from outside the migration thread, so we can't write to last_sent_block. Instead of reverting full patch: [PULL 07/11] save_block_hdr: we can recalculate Just revert the parts that touch last_sent_block. Signed

Re: [Qemu-devel] [PATCH v3 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-23 Thread Laszlo Ersek
comments below On 03/21/15 21:23, Gabriel L. Somlo wrote: > Allow user supplied files to be inserted into the fw_cfg > device before starting the guest. Since fw_cfg_add_file() > already disallows duplicate fw_cfg file names, qemu will > exit with an error message if the user supplies multiple > b

[Qemu-devel] [v6 08/14] migration: Add the core code of multi-thread compression

2015-03-23 Thread Liang Li
Implement the core logic of the multiple thread compression. At this point, multiple thread compression can't co-work with xbzrle yet. Signed-off-by: Liang Li Signed-off-by: Yang Zhang --- arch_init.c | 184 +--- 1 file changed, 177 insert

Re: [Qemu-devel] [PULL 16/19] kvm: fix ioeventfd endianness on bi-endian architectures

2015-03-23 Thread Greg Kurz
On Wed, 18 Mar 2015 12:25:03 +0100 Paolo Bonzini wrote: > From: Greg Kurz > > KVM expects host endian values. Hosts that don't use the default endianness > need to negate the swap performed in adjust_endianness(). > > Suggested-by: Paolo Bonzini > Signed-off-by: Greg Kurz > Message-Id: <20150

[Qemu-devel] [v6 11/14] migration: Add interface to control compression

2015-03-23 Thread Liang Li
The multiple compression threads can be turned on/off through qmp and hmp interface before doing live migration. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Dr.David Alan Gilbert Reviewed-by: Eric Blake --- migration/migration.c | 7 +-- qapi-schema.json | 11

[Qemu-devel] [v6 03/14] migration: Add the framework of multi-thread decompression

2015-03-23 Thread Liang Li
Add the code to create and destroy the multiple threads those will be used to do data decompression. Left some functions empty just to keep clearness, and the code will be added later. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Dr.David Alan Gilbert Reviewed-by: Juan Quintel

Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling

2015-03-23 Thread Alberto Garcia
On Mon, Mar 23, 2015 at 01:24:15PM +0800, Fam Zheng wrote: > Currently, throttle timers won't make any progress when VCPU is not > running, which would stall the request queue in utils, qtest, vm > suspending, and live migration without special handling. > > For example in bdrv_drain_all, all requ

[Qemu-devel] [PATCH v6 0/14] migration: Add a new feature to do live migration

2015-03-23 Thread Liang Li
This feature can help to reduce the data transferred about 60%, and the migration time can also be reduced about 70%. Summary of changed from v5->v6 -Changed the schema of qmp interface -Split the last patche in v5 into 3 patches -Added some comments of the new functions -Chan

[Qemu-devel] [v6 04/14] qemu-file: Add compression functions to QEMUFile

2015-03-23 Thread Liang Li
qemu_put_compression_data() compress the data and put it to QEMUFile. qemu_put_qemu_file() put the data in the buffer of source QEMUFile to destination QEMUFile. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Juan Quintela --- include/migration/qemu-file.h | 3 +++ migration/q

Re: [Qemu-devel] [PATCH v2 2/2] i6300esb: Fix signed integer overflow

2015-03-23 Thread Richard W.M. Jones
On Mon, Mar 23, 2015 at 12:51:48PM +1100, David Gibson wrote: > If the guest programs a sufficiently large timeout value an integer > overflow can occur in i6300esb_restart_timer(). e.g. if the maximum > possible timer preload value of 0xf is programmed then we end up with > the calculation: >

Re: [Qemu-devel] [PATCH v2 1/2] i6300esb: Correct endiannness

2015-03-23 Thread Richard W.M. Jones
On Mon, Mar 23, 2015 at 12:51:47PM +1100, David Gibson wrote: > The IO operations for the i6300esb watchdog timer are marked as > DEVICE_NATIVE_ENDIAN. This is not correct, and - as a PCI device - should > be DEVICE_LITTLE_ENDIAN. > > This allows i6300esb to work on ppc targets (yes, using an Int

Re: [Qemu-devel] [PATCH V4 06/19] virtio-ccw: using VIRTIO_NO_VECTOR instead of 0 for invalid virtqueue

2015-03-23 Thread Cornelia Huck
On Sat, 21 Mar 2015 19:27:49 +0100 "Michael S. Tsirkin" wrote: > On Fri, Mar 20, 2015 at 08:39:24AM +0100, Cornelia Huck wrote: > > On Wed, 18 Mar 2015 14:08:56 +0100 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Mar 18, 2015 at 05:34:56PM +0800, Jason Wang wrote: > > > > There's no need to

[Qemu-devel] [v6 13/14] migration: Add qmp commands to set and query parameters

2015-03-23 Thread Liang Li
Add the qmp commands to tune and query the parameters used in live migration. Signed-off-by: Liang Li Signed-off-by: Yang Zhang --- migration/migration.c | 56 ++ qapi-schema.json | 45 qmp-commands.hx

[Qemu-devel] [v6 10/14] migration: Add the core code for decompression

2015-03-23 Thread Liang Li
Implement the core logic of multiple thread decompression, the decompression can work now. Signed-off-by: Liang Li Signed-off-by: Yang Zhang --- arch_init.c | 50 -- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/arch_init.c b/arch

[Qemu-devel] [v6 09/14] migration: Make compression co-work with xbzrle

2015-03-23 Thread Liang Li
Now, multiple thread compression can co-work with xbzrle. when xbzrle is on, multiple thread compression will only work at the first round of RAM data sync. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Dr.David Alan Gilbert --- arch_init.c | 12 +++- 1 file changed, 1

[Qemu-devel] [v6 14/14] migration: Add hmp interface to set and query parameters

2015-03-23 Thread Liang Li
Add the hmp interface to tune and query the parameters used in live migration. Signed-off-by: Liang Li Signed-off-by: Yang Zhang --- hmp-commands.hx | 17 +++ hmp.c | 65 + hmp.h | 4 monitor.c |

[Qemu-devel] [v6 07/14] migration: Split save_zero_page from ram_save_page

2015-03-23 Thread Liang Li
Split the function save_zero_page from ram_save_page so that we can reuse it later. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Juan Quintela --- arch_init.c | 61 +++-- 1 file changed, 43 insertions(+), 18 deletions(-)

[Qemu-devel] [v6 06/14] arch_init: Add and free data struct for decompression

2015-03-23 Thread Liang Li
Define the data structure and variables used to do multiple thread decompression, and add the code to initialize and free them. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Dr.David Alan Gilbert Reviewed-by: Juan Quintela --- arch_init.c | 13 - 1 file changed, 1

[Qemu-devel] [v6 12/14] migration: Use an array instead of 3 parameters

2015-03-23 Thread Liang Li
Put the three parameters related to multiple thread (de)compression into an int array, and use an enum type to index the parameter. Signed-off-by: Liang Li Signed-off-by: Yang Zhang --- include/migration/migration.h | 4 +--- migration/migration.c | 31 +++

[Qemu-devel] [v6 05/14] arch_init: Alloc and free data struct for compression

2015-03-23 Thread Liang Li
Define the data structure and variables used to do multiple thread compression, and add the code to initialize and free them. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Dr.David Alan Gilbert Reviewed-by: Juan Quintela --- arch_init.c | 35 ++

[Qemu-devel] [v6 02/14] migration: Add the framework of multi-thread compression

2015-03-23 Thread Liang Li
Add the code to create and destroy the multiple threads those will be used to do data compression. Left some functions empty to keep clearness, and the code will be added later. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Dr.David Alan Gilbert Reviewed-by: Juan Quintela ---

[Qemu-devel] [v6 01/14] docs: Add a doc about multiple thread compression

2015-03-23 Thread Liang Li
Give some details about the multiple thread (de)compression and how to use it in live migration. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Dr.David Alan Gilbert Reviewed-by: Juan Quintela --- docs/multi-thread-compression.txt | 149 ++

Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property

2015-03-23 Thread Markus Armbruster
Paolo Bonzini writes: > Add a drive property that can be used with sdhci-pci (instead of the odd > "-drive if=sd,... -device sdhci-pci" that has no equivalent in the rest > of QEMU). Ugh. sdhci-pci is incorrectly qdevified: it uses drive_get_next() in its realize() method. Is it the only devic

[Qemu-devel] [Bug 1186984] Re: large -initrd can wrap around in memory causing memory corruption

2015-03-23 Thread Richard Jones
Although the error message is the same, the bug in comment 5 seems completely different. Please open a new bug about this issue, giving *all* details - including the full qemu command line. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to Q

Re: [Qemu-devel] [PATCH v2 1/2] cpu/apic: drop icc bus/bridge/

2015-03-23 Thread Chen Fan
On 03/23/2015 04:23 PM, Igor Mammedov wrote: On Mon, 23 Mar 2015 13:54:23 +0800 Chen Fan wrote: ICC bus was invented only to provide hotplug capability to CPU and APIC because at the time being hotplug was available only for BUS attached devices. Now this patch is to drop ICC bus impl, and s

Re: [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED

2015-03-23 Thread Markus Armbruster
Alberto Garcia writes: > Since this event can occur in nodes that cannot have a device name > associated, include also a field with the node name. > > Signed-off-by: Alberto Garcia > --- > block/qcow2.c | 8 ++-- > docs/qmp/qmp-events.txt | 16 +--- > qapi/block-core.

[Qemu-devel] 答复: Re: [PATCH] object_del: Prevent removing an in-use memory backend object

2015-03-23 Thread Lin Ma
Igor, It seems my smtp server has some issues, The email including my reply doesn't hit the list. I paste my reply here and send it again: That makes sense, I couldn't agree more. I am going to drop this patch and separate it to 2 patches. One for adding generic can_be_deleted callback, The oth

Re: [Qemu-devel] virtio fixes pull for 4.0?

2015-03-23 Thread Pawel Moll
On Mon, 2015-03-09 at 07:13 +, Rusty Russell wrote: > > virtio_mmio: generation support > > virtio_mmio: fix endian-ness for mmio these two are waiting for ack by > > Pawel > > > > These two fix bugs in virtio 1.0 code for mmio. > > Host code for that was AFAIK not posted, so I can't t

Re: [Qemu-devel] [PATCH v2 1/2] cpu/apic: drop icc bus/bridge/

2015-03-23 Thread Igor Mammedov
On Mon, 23 Mar 2015 17:07:29 +0800 Chen Fan wrote: > > On 03/23/2015 04:23 PM, Igor Mammedov wrote: > > On Mon, 23 Mar 2015 13:54:23 +0800 > > Chen Fan wrote: > > > >> ICC bus was invented only to provide hotplug capability to > >> CPU and APIC because at the time being hotplug was available on

Re: [Qemu-devel] [PATCH v2 1/2] cpu/apic: drop icc bus/bridge/

2015-03-23 Thread Chen Fan
On 03/23/2015 05:43 PM, Igor Mammedov wrote: On Mon, 23 Mar 2015 17:07:29 +0800 Chen Fan wrote: On 03/23/2015 04:23 PM, Igor Mammedov wrote: On Mon, 23 Mar 2015 13:54:23 +0800 Chen Fan wrote: ICC bus was invented only to provide hotplug capability to CPU and APIC because at the time being

Re: [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED

2015-03-23 Thread Alberto Garcia
On Mon, Mar 23, 2015 at 10:20:31AM +0100, Markus Armbruster wrote: > > +- "device":Device name (json-string) > > +- "node-name": Node name, if it's present (json-string) > > By convention, we mark optional members like this: > > - "node-name": Node name (json-string, optional) You're right,

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/2] i6300esb: Fix signed integer overflow

2015-03-23 Thread BALATON Zoltan
On Mon, 23 Mar 2015, David Gibson wrote: If the guest programs a sufficiently large timeout value an integer overflow can occur in i6300esb_restart_timer(). e.g. if the maximum possible timer preload value of 0xf is programmed then we end up with the calculation: timeout = get_ticks_per_sec

[Qemu-devel] [PATCH for-2.3 0/1] block: New command line option --misc format-probing=off

2015-03-23 Thread Markus Armbruster
First of all, my apologies for being so late with this. I realized part way through the current development cycle that I couldn't do both the error work and my half of the block probing work we discussed back in November, so I punted the latter to the next cycle, missing the one little feature I q

[Qemu-devel] [PATCH for-2.3 1/1] block: New command line option --misc format-probing=off

2015-03-23 Thread Markus Armbruster
Probing is convenient, but probing untrusted raw images is insecure (CVE-2008-2004). To avoid it, users should always specify raw format explicitly. This isn't trivial, and even sophisticated users have gotten it wrong (libvirt CVE-2010-2237, CVE-2010-2238, CVE-2010-2239, plus more recent variati

[Qemu-devel] [PATCH 2/2] memory-backend: Add can_be_deleted impl for ram-backend and file-backend

2015-03-23 Thread Lin Ma
The can_be_deleted callback returns false if the backend is in used, Otherwise returns true. Signed-off-by: Lin Ma --- backends/hostmem-file.c | 12 backends/hostmem-ram.c | 12 2 files changed, 24 insertions(+) diff --git a/backends/hostmem-file.c b/backends/hostmem-

[Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl

2015-03-23 Thread Lin Ma
Add can_be_deleted callback, If it is not null and returns false, The qmp_object_del won't delete the given object. Signed-off-by: Lin Ma --- include/qom/object.h | 12 qmp.c| 7 +++ qom/object.c | 12 3 files changed, 31 insertions(+) diff

Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl

2015-03-23 Thread Peter Crosthwaite
On Mon, Mar 23, 2015 at 3:40 PM, Lin Ma wrote: > Add can_be_deleted callback, If it is not null and returns false, > The qmp_object_del won't delete the given object. > > Signed-off-by: Lin Ma > --- > include/qom/object.h | 12 > qmp.c| 7 +++ > qom/object.c

[Qemu-devel] [PATCH for-2.3 v2] cpus: Don't kick un-realized cpus.

2015-03-23 Thread Peter Crosthwaite
following a464982499b2f637f6699e3d03e0a9d2e0b5288b, it's now possible for there to be attempts to take the BQL before CPUs have been realized in cases where a machine model inits peripherals before the first CPU. BQL lock aquisition kicks the first_cpu, leading to a segfault if this happens pre-re

[Qemu-devel] [PATCH for-2.3 v2] cpus: Don't kick un-realized cpus.

2015-03-23 Thread Peter Crosthwaite
following a464982499b2f637f6699e3d03e0a9d2e0b5288b, it's now possible for there to be attempts to take the BQL before CPUs have been realized in cases where a machine model inits peripherals before the first CPU. BQL lock aquisition kicks the first_cpu, leading to a segfault if this happens pre-re

Re: [Qemu-devel] [PATCH target-arm v3 04/15] arm: xlnx-zynqmp: Add GIC

2015-03-23 Thread Peter Crosthwaite
On Wed, Mar 18, 2015 at 10:39 PM, Peter Crosthwaite wrote: > On Wed, Mar 18, 2015 at 7:06 PM, Paolo Bonzini wrote: >> >> >> On 18/03/2015 14:11, Peter Crosthwaite wrote: >>> So I actually bisected this as a recent regression on: >>> >>> commit a464982499b2f637f6699e3d03e0a9d2e0b5288b (refs/bisect

Re: [Qemu-devel] [PATCH target-arm v3 12/15] arm: Add xlnx-ep108 machine

2015-03-23 Thread Peter Crosthwaite
On Wed, Mar 18, 2015 at 10:48 AM, Alistair Francis wrote: > On Mon, Mar 16, 2015 at 10:12 PM, Peter Crosthwaite > wrote: >> Add a machine model for the Xilinx ZynqMP SoC EP108 board. >> >> Signed-off-by: Peter Crosthwaite >> --- >> Chaned since v1: >> Change board name to ep108 >> >> hw/arm/Mak

Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine

2015-03-23 Thread Stefan Berger
On 03/22/2015 09:47 PM, Xu, Quan wrote: -Original Message- From: Stefan Berger [mailto:stef...@linux.vnet.ibm.com] Sent: Friday, March 20, 2015 7:44 PM To: Ian Campbell; Xu, Quan Cc: ke...@koconnor.net; xen-de...@lists.xen.org; qemu-devel@nongnu.org; stefano.stabell...@eu.citrix.com Sub

Re: [Qemu-devel] [RESEND PATCH v4 6/6] acpi: Add hardware implementation for memory hot unplug

2015-03-23 Thread Zhu Guihua
On 03/16/2015 10:59 PM, Igor Mammedov wrote: [...] diff --git a/hw/i386/acpi-dsdt-mem-hotplug.dsl b/hw/i386/acpi-dsdt-mem-hotplug.dsl index 1e9ec39..ef847e2 100644 --- a/hw/i386/acpi-dsdt-mem-hotplug.dsl +++ b/hw/i386/acpi-dsdt-mem-hotplug.dsl @@ -29,6 +29,7 @@ External(MEMORY_S

[Qemu-devel] [PATCH for-2.3 v2] cpus: Don't kick un-realized cpus.

2015-03-23 Thread Peter Crosthwaite
following a464982499b2f637f6699e3d03e0a9d2e0b5288b, it's now possible for there to be attempts to take the BQL before CPUs have been realized in cases where a machine model inits peripherals before the first CPU. BQL lock aquisition kicks the first_cpu, leading to a segfault if this happens pre-re

[Qemu-devel] [PATCH target-arm v4 01/16] cpus: Don't kick un-realized cpus.

2015-03-23 Thread Peter Crosthwaite
following a464982499b2f637f6699e3d03e0a9d2e0b5288b, it's now possible for there to be attempts to take the BQL before CPUs have been realized in cases where a machine model inits peripherals before the first CPU. BQL lock aquisition kicks the first_cpu, leading to a segfault if this happens pre-re

[Qemu-devel] [PATCH target-arm v4 02/16] target-arm: cpu64: Factor out ARM cortex init

2015-03-23 Thread Peter Crosthwaite
In preparation for support for Cortex a53. Use "axx" to describe the shareable features. Some of the CP15 registers (such as ACTLR) are specific to implementation, but we currently just RAZ them so continue with that as the policy for all cortex A processors under a shared definition. The cache si

[Qemu-devel] [PATCH target-arm v4 00/16] Next Generation Xilinx Zynq SoC

2015-03-23 Thread Peter Crosthwaite
Hi Peter and all, Xilinx's next gen SoC has been announced. This series adds a SoC and board. Series start with addition of ARM cortex A53 support (P1 and P2). The Soc skeleton is then added with GIC, EMACs and UARTs are added. The pre-existing models for GEM and UART are not SoC friendly (no vis

[Qemu-devel] [PATCH target-arm v4 08/16] net: cadence_gem: Split state struct and type into header

2015-03-23 Thread Peter Crosthwaite
To allow using the device with modern SoC programming conventions. The state struct needs to be visible to embed the device in SoC containers. Reviewed-by: Alistair Francis Signed-off-by: Peter Crosthwaite --- changed since v1: Fix /* Public */ comment spacing (Alistair review) hw/net/cadence_

[Qemu-devel] [PATCH target-arm v4 05/16] arm: xlnx-zynqmp: Add GIC

2015-03-23 Thread Peter Crosthwaite
And connect IRQ outputs to the CPUs. Reviewed-by: Alistair Francis Signed-off-by: Peter Crosthwaite --- hw/arm/xlnx-zynqmp.c | 19 +++ include/hw/arm/xlnx-zynqmp.h | 2 ++ 2 files changed, 21 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index

[Qemu-devel] [PATCH target-arm v4 04/16] arm: Introduce Xilinx ZynqMP SoC

2015-03-23 Thread Peter Crosthwaite
With quad Cortex-A53 CPUs. Signed-off-by: Peter Crosthwaite --- changed since v2: Added [*] to cpu child property name. changed since v1: Add &error_abort to CPU child adder call. default-configs/aarch64-softmmu.mak | 2 +- hw/arm/Makefile.objs| 1 + hw/arm/xlnx-zynqmp.c

[Qemu-devel] [PATCH target-arm v4 03/16] target-arm: cpu64: Add support for cortex-a53

2015-03-23 Thread Peter Crosthwaite
Similar to a53, but with different L1 I cache policy, phys addr size and different cache geometries. The cache sizes is implementation configurable, but use these values (from Xilinx MPSoC) as a default until cache size configurability is added. Reviewed-by: Alex Bennée Signed-off-by: Peter Crost

[Qemu-devel] [PATCH target-arm v4 07/16] net: cadence_gem: Clean up variable names

2015-03-23 Thread Peter Crosthwaite
In preparation for migrating the state struct and type cast macro to a public header. The acronym "GEM" on it's own is not specific enough to be used in a more global namespace so preface with "cadence". Fix the capitalisation of "gem" in the state type while touching the typename. Also preface the

[Qemu-devel] [PATCH target-arm v4 06/16] arm: xlnx-zynqmp: Connect CPU Timers to GIC

2015-03-23 Thread Peter Crosthwaite
Connect the GPIO outputs from the individual CPUs for the timers to the GIC. Signed-off-by: Peter Crosthwaite --- hw/arm/xlnx-zynqmp.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 9465185..29954f5 100644 --- a/hw/arm/xlnx

[Qemu-devel] [PATCH target-arm v4 11/16] char: cadence_uart: Split state struct and type into header

2015-03-23 Thread Peter Crosthwaite
To allow using the device with modern SoC programming conventions. The state struct needs to be visible to embed the device in SoC containers. Reviewed-by: Alistair Francis Signed-off-by: Peter Crosthwaite --- changed since v1: Fix /* Public */ comment spacing (Alistair review) hw/char/cadence

[Qemu-devel] [PATCH target-arm v4 13/16] arm: Add xlnx-ep108 machine

2015-03-23 Thread Peter Crosthwaite
Add a machine model for the Xilinx ZynqMP SoC EP108 board. Signed-off-by: Peter Crosthwaite --- Chaned since v1: Change board name to ep108 hw/arm/Makefile.objs | 2 +- hw/arm/xlnx-ep108.c | 53 2 files changed, 54 insertions(+), 1 deletion

[Qemu-devel] [PATCH target-arm v4 10/16] char: cadence_uart: Clean up variable names

2015-03-23 Thread Peter Crosthwaite
In preparation for migrating the state struct and type cast macro to a public header. The acronym "UART" on it's own is not specific enough to be used in a more global namespace so preface with "cadence". Fix the capitalisation of "uart" in the state type while touching the typename. Preface macros

[Qemu-devel] [PATCH target-arm v4 15/16] arm: xilinx-ep108: Add bootloading

2015-03-23 Thread Peter Crosthwaite
Using standard ARM bootloader. Signed-off-by: Peter Crosthwaite --- hw/arm/xlnx-ep108.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c index 6e89456..a86f595 100644 --- a/hw/arm/xlnx-ep108.c +++ b/hw/arm/xlnx-ep108.c @@ -28,6 +28,8 @@ typede

[Qemu-devel] [PATCH target-arm v4 14/16] arm: xilinx-ep108: Add external RAM

2015-03-23 Thread Peter Crosthwaite
Zynq MPSoC supports external DDR RAM. Add a RAM at 0 to the model. Signed-off-by: Peter Crosthwaite --- changed since v1: Add ram size clamps and warnings hw/arm/xlnx-ep108.c | 21 + 1 file changed, 21 insertions(+) diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c ind

Re: [Qemu-devel] [RFC 0/6] memory: make dirty_memory[] accesses atomic

2015-03-23 Thread Paolo Bonzini
On 28/11/2014 13:44, Stefan Hajnoczi wrote: > This is an example of what I mean. > > I'm not going to work on making TCG thread-safe in this series, and > there is no dangerous race condition in this code if we leave it as is. > > But I'm not 100% sure of all cases, so I'll audit them again. I

[Qemu-devel] [PATCH target-arm v4 16/16] arm: xlnx-zynqmp: Add PSCI setup

2015-03-23 Thread Peter Crosthwaite
Use SMC PSCI, with the standard policy of secondaries starting in power-off. Reviewed-by: Alistair Francis Signed-off-by: Peter Crosthwaite --- changed since v1: Add &error_abort to property setter calls hw/arm/xlnx-zynqmp.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/arm/xl

Re: [Qemu-devel] GSoC Proposal: ARM Virtualization Extensions

2015-03-23 Thread Merten Sach
On 20/03/15 18:44, Peter Maydell wrote: > * having a project plan that divides the work up into small >but coherent chunks that can be landed upstream incrementally >(to avoid the failure mode of "work all summer but don't >get it finished, and so don't have anything concrete >to s

Re: [Qemu-devel] GSoC Proposal: ARM Virtualization Extensions

2015-03-23 Thread Merten Sach
On 21/03/15 04:16, Sergey Fedorov wrote: > Hi! > > I am currently working on AArch64 EL2 support. There is a plan to submit > the changes to the community. Merten, IIUYC, you are going to support > only AArch32 EL2? > > Best regards, > Sergey Hi Yes, my intention is to focus on AArch32 as I'm m

Re: [Qemu-devel] [PATCH] nvme: Fix unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)

2015-03-23 Thread Stefan Hajnoczi
On Sat, Mar 14, 2015 at 05:00:44PM +0100, Stefan Weil wrote: > The shift operation on nlb gives a 32 bit result if no type cast is > applied. This bug was reported by Coverity. > > Signed-off-by: Stefan Weil > --- > hw/block/nvme.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Than

Re: [Qemu-devel] GSoC Proposal: ARM Virtualization Extensions

2015-03-23 Thread Peter Maydell
On 23 March 2015 at 11:29, Merten Sach wrote: > On 20/03/15 18:44, Peter Maydell wrote: >> * having a project plan that divides the work up into small >>but coherent chunks that can be landed upstream incrementally >>(to avoid the failure mode of "work all summer but don't >>get it fi

Re: [Qemu-devel] live migration fails after host kernel upgrade (3.12 => 3.18)

2015-03-23 Thread Stefan Hajnoczi
On Sun, Mar 15, 2015 at 09:59:25AM +0100, Stefan Priebe wrote: > after upgrading the host kernel from 3.12 to 3.18 live migration fails with > the following qemu output (guest running on a host with 3.12 => host with > 3.18): > > kvm: Features 0x30afffe3 unsupported. Allowed features: 0x79bfbbe7 >

Re: [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED

2015-03-23 Thread Markus Armbruster
Alberto Garcia writes: > On Mon, Mar 23, 2015 at 10:20:31AM +0100, Markus Armbruster wrote: [...] >> Ignorant question: can "device" be ""? If yes, we should document >> what that means, possibly in a separate patch. > > Yes it can be "", the purpose of the patch is precisely to expand the > even

Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine

2015-03-23 Thread Xu, Quan
> -Original Message- > From: Stefan Berger [mailto:stef...@linux.vnet.ibm.com] > Sent: Monday, March 23, 2015 6:57 PM > To: Xu, Quan; Ian Campbell > Cc: ke...@koconnor.net; xen-de...@lists.xen.org; qemu-devel@nongnu.org; > stefano.stabell...@eu.citrix.com > Subject: Re: [Xen-devel] [PATCH

Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property

2015-03-23 Thread Paolo Bonzini
On 23/03/2015 10:10, Markus Armbruster wrote: > Ugh. sdhci-pci is incorrectly qdevified: it uses drive_get_next() in > its realize() method. Is it the only device model with this issue? I think SD devices are the only ones, but all of them have the issue. Ironically, the qdevified ones call d

Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl

2015-03-23 Thread Paolo Bonzini
On 23/03/2015 11:36, Peter Crosthwaite wrote: > I don't think TypeInfo is the right place for this. You can however > define function hooks for Object in ObjectClass. See the unparent > field of ObjectClass for a precedent. In this case, the right place could be UserCreatable. Alternatively...

Re: [Qemu-devel] [PATCH for-2.3 v2] cpus: Don't kick un-realized cpus.

2015-03-23 Thread Paolo Bonzini
On 23/03/2015 11:48, Peter Crosthwaite wrote: > following a464982499b2f637f6699e3d03e0a9d2e0b5288b, it's now possible for > there to be attempts to take the BQL before CPUs have been realized in > cases where a machine model inits peripherals before the first CPU. > > BQL lock aquisition kicks t

Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property

2015-03-23 Thread Peter Maydell
On 23 March 2015 at 12:05, Paolo Bonzini wrote: > > The only alternative for 2.3 is reverting the patch for sdhci-pci. I > certainly don't want "-drive if=sd -device sdhci-pci" to become ABI! What's wrong with that, incidentally? It's what I would have expected for connecting an SD card to sdhci

Re: [Qemu-devel] [PATCH] rcutorture: fix compilation on 32-bit ppc

2015-03-23 Thread Paolo Bonzini
On 21/03/2015 16:44, Peter Maydell wrote: > On 21 March 2015 at 15:34, Paolo Bonzini wrote: >> 32-bit PPC cannot do atomic operations on long long. Inside the loops, >> we are already using local counters that are summed at the end of >> the run---with one exception in rcu_read_stress_test: fix

Re: [Qemu-devel] live migration fails after host kernel upgrade (3.12 => 3.18)

2015-03-23 Thread Stefan Priebe - Profihost AG
Hi, Thanks. I fixed it - there is already a patchseries in 4.0 to fix this. It will be backported in 3.18.10 or 3.18.11. Stefan Am 23.03.2015 um 12:54 schrieb Stefan Hajnoczi: > On Sun, Mar 15, 2015 at 09:59:25AM +0100, Stefan Priebe wrote: >> after upgrading the host kernel from 3.12 to 3.18 l

Re: [Qemu-devel] [PATCH v5 45/45] Inhibit ballooning during postcopy

2015-03-23 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:52:08PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The userfault mechanism used for postcopy generates faults > > for us on pages that are 'not present', inflating a balloon

[Qemu-devel] RFC: memory API changes

2015-03-23 Thread Peter Maydell
(This is part of the work I'm doing for transaction attributes.) Currently we have several APIs used for making physical memory accesses: 1. cpu_physical_memory_rw &c 2. address_space_rw/read/write/map 3. ld/st*_phys These do more-or-less overlapping jobs and it's not obvious which should be u

Re: [Qemu-devel] RFC: memory API changes

2015-03-23 Thread Andreas Färber
Am 23.03.2015 um 13:24 schrieb Peter Maydell: > * address_space_rw &c to be renamed: > address_space_rw -> as_rw_buf > address_space_read -> as_read_buf > address_space_write -> as_write_buf > address_space_map -> as_map_buf &c >This is just so the names line up nicely and we h

Re: [Qemu-devel] RFC: memory API changes

2015-03-23 Thread Peter Maydell
On 23 March 2015 at 12:30, Andreas Färber wrote: > Am 23.03.2015 um 13:24 schrieb Peter Maydell: >> * address_space_rw &c to be renamed: >> address_space_rw -> as_rw_buf >> address_space_read -> as_read_buf >> address_space_write -> as_write_buf >> address_space_map -> as_map_buf

Re: [Qemu-devel] [PATCH v4 4/5] Qemu-Xen-vTPM: Qemu vTPM xenstubdoms backen.

2015-03-23 Thread Xu, Quan
> -Original Message- > From: Stefan Berger [mailto:stef...@linux.vnet.ibm.com] > Sent: Thursday, March 19, 2015 3:17 AM > To: Xu, Quan; stefano.stabell...@eu.citrix.com; qemu-devel@nongnu.org; > arm...@redhat.com; lcapitul...@redhat.com; aligu...@amazon.com; > pbonz...@redhat.com; ebl...@

Re: [Qemu-devel] Output of fprintf messages in qemu source

2015-03-23 Thread Stefan Hajnoczi
On Thu, Mar 19, 2015 at 12:17:29AM +0530, Toms Varghese wrote: > Hi all, > > I can see some fprintf (stderr, ...) statements in qemu source code. I > expect the output to be shown in the terminal window. I use libvirt to > manage my VMs and hence have no idea about the exact qemu command line > b

Re: [Qemu-devel] [RESEND PATCH v4 6/6] acpi: Add hardware implementation for memory hot unplug

2015-03-23 Thread Igor Mammedov
On Mon, 23 Mar 2015 18:59:28 +0800 Zhu Guihua wrote: > > On 03/16/2015 10:59 PM, Igor Mammedov wrote: > [...] > > > > diff --git a/hw/i386/acpi-dsdt-mem-hotplug.dsl > > b/hw/i386/acpi-dsdt-mem-hotplug.dsl > > index 1e9ec39..ef847e2 100644 > > --- a/hw/i386/acpi-dsdt-mem-hotplug.dsl > > +++ b

Re: [Qemu-devel] Question about scsi emulation

2015-03-23 Thread Stefan Hajnoczi
On Wed, Mar 18, 2015 at 02:16:47PM -0700, Yaoli Zheng wrote: > We have problem using qemu emulated scsi driver(the old lsi). Wonder if any > of other device model we can try for emulating scsi, and how we can get and > config it in Xen? Having been told virtio-scsi is alternative one, but have >

Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl

2015-03-23 Thread Andreas Färber
Hi Lin, Am 23.03.2015 um 11:10 schrieb Lin Ma: > Add can_be_deleted callback, If it is not null and returns false, > The qmp_object_del won't delete the given object. > > Signed-off-by: Lin Ma > --- > include/qom/object.h | 12 > qmp.c| 7 +++ > qom/object.c

[Qemu-devel] [PATCH] linux-user: fix broken cpu_copy()

2015-03-23 Thread Leon Alrae
New threads always point at the same env which is incorrect and usually leads to a crash. Signed-off-by: Leon Alrae --- Hi, This patch fixes the bug introduced in: commit 2994fd96d986578a342f2342501b4ad30f6d0a85 Author: Eduardo Habkost cpu: Make cpu_init() return QOM CPUState object Rega

Re: [Qemu-devel] [PATCH v3 4/4] configure: Add workaround for ccache and clang

2015-03-23 Thread Stefan Hajnoczi
On Thu, Mar 19, 2015 at 03:01:37PM -0400, John Snow wrote: > + > +# check if ccache is interfering with > +# semantic analysis of macros > + > +ccache=no > +cat > $TMPC << EOF > +static const int Z = 1; > +#define fn() ({ Z; }) > +#define TAUT(X) ((X) == Z) >

Re: [Qemu-devel] [PATCH] linux-user: fix broken cpu_copy()

2015-03-23 Thread Andreas Färber
Am 23.03.2015 um 13:55 schrieb Leon Alrae: > New threads always point at the same env which is incorrect and usually leads > to a crash. > > Signed-off-by: Leon Alrae > --- > Hi, > > This patch fixes the bug introduced in: > > commit 2994fd96d986578a342f2342501b4ad30f6d0a85 > Author: Eduardo Ha

Re: [Qemu-devel] [PATCH for-2.3 1/1] block: New command line option --misc format-probing=off

2015-03-23 Thread Eric Blake
On 03/23/2015 04:04 AM, Markus Armbruster wrote: > Probing is convenient, but probing untrusted raw images is insecure > (CVE-2008-2004). To avoid it, users should always specify raw format > explicitly. This isn't trivial, and even sophisticated users have > gotten it wrong (libvirt CVE-2010-223

Re: [Qemu-devel] [PATCH v3 2/4] configure: factor out supported flag check

2015-03-23 Thread Stefan Hajnoczi
On Thu, Mar 19, 2015 at 03:01:35PM -0400, John Snow wrote: > +cc_has_warning_flag() { > +if [ "$2" != "--keep-tmpc" ]; then > +write_c_skeleton; > +fi > + > # Use the positive sense of the flag when testing for -Wno-wombat > # support (gcc will happily accept the -Wno- for

Re: [Qemu-devel] [PATCH v3 4/4] configure: Add workaround for ccache and clang

2015-03-23 Thread Peter Maydell
On 19 March 2015 at 19:01, John Snow wrote: > Test if ccache is interfering with our life, and > disable its habit of trying to compile already pre-processed > versions of code if so. > > In particular, clang has different semantic warnings based on > if the warning arose from a macro or not. By t

Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl

2015-03-23 Thread Andreas Färber
Hi, For consistency in git-log, please use "qom:" rather than "object:". Am 23.03.2015 um 13:06 schrieb Paolo Bonzini: > On 23/03/2015 11:36, Peter Crosthwaite wrote: >> I don't think TypeInfo is the right place for this. You can however >> define function hooks for Object in ObjectClass. See the

Re: [Qemu-devel] [PATCH target-arm v4 03/16] target-arm: cpu64: Add support for cortex-a53

2015-03-23 Thread Ryota Ozaki
Hi, On Mon, Mar 23, 2015 at 8:05 PM, Peter Crosthwaite wrote: > Similar to a53, but with different L1 I cache policy, phys addr size and ^^^ I guess a57 :) ozaki-r > different cache geometries. The cache sizes is implementation > configurable, but use these values (from Xili

Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property

2015-03-23 Thread Paolo Bonzini
On 23/03/2015 13:09, Peter Maydell wrote: > > The only alternative for 2.3 is reverting the patch for sdhci-pci. I > > certainly don't want "-drive if=sd -device sdhci-pci" to become ABI! > > What's wrong with that, incidentally? It's what I would have > expected for connecting an SD card to sdh

Re: [Qemu-devel] [PATCH] linux-user: fix broken cpu_copy()

2015-03-23 Thread Andreas Färber
Am 23.03.2015 um 14:02 schrieb Andreas Färber: > Am 23.03.2015 um 13:55 schrieb Leon Alrae: >> New threads always point at the same env which is incorrect and usually leads Please remember to break after 76 chars. (Look at `git log` output.) Andreas >> to a crash. >> >> Signed-off-by: Leon Alrae

  1   2   3   >