Re: [Qemu-devel] [PATCH 1/2] vga: abort instead of shrinking memory

2015-02-17 Thread Gerd Hoffmann
On Mo, 2015-02-16 at 22:23 +0100, Radim Krčmář wrote: > Automatic shrinking of vram_size leads to a segfault, because other > variables depend on being smaller and don't get shrinked. --verbose please. Which other variables? > Implications of shrinking would make the code needlessly complicated;

Re: [Qemu-devel] [PULL v2 00/14] target-mips queue

2015-02-17 Thread Peter Maydell
On 15 February 2015 at 02:44, Leon Alrae wrote: > Hi, > > Here is version 2 of target-mips pullreq - rebased and with signed tag. Just fyi, this hotel's wifi and my work VPN seem to disagree with each other, so probably no pullrequest handling til next week some time. (Unless I manage to figure o

Re: [Qemu-devel] [PATCH 2/2] qxl: surface0 and ram_header should fit into vram

2015-02-17 Thread Gerd Hoffmann
On Mo, 2015-02-16 at 22:23 +0100, Radim Krčmář wrote: > The solution is not perfect, but won't let us do the same error again > and has no overhead. How do you get qemu into a configuration where this isn't true? cheers, Gerd

Re: [Qemu-devel] [PATCH 4/4] block: Remove unused functions

2015-02-17 Thread Thomas Huth
Hi Max, On Mon, 16 Feb 2015 17:26:56 -0500 Max Reitz wrote: > On 2015-02-16 at 16:41, Thomas Huth wrote: > > qemu_try_blockalign0() and nbd_export_close_all() are not > > used anymore and thus can be removed. > > > > Signed-off-by: Thomas Huth > > Cc: Kevin Wolf > > Cc: Stefan Hajnoczi > >

Re: [Qemu-devel] [PATCH 00/13] QemuOpts: Convert various setters to Error

2015-02-17 Thread Markus Armbruster
Forgot to mention: based on my "[PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err()" series, because it needs its "[PATCH v2 01/10] error: New convenience function error_report_err()".

Re: [Qemu-devel] [PATCH 04/13] qemu-img: Suppress unhelpful extra errors in convert, resize

2015-02-17 Thread Markus Armbruster
John Snow writes: > On 02/16/2015 09:44 AM, Markus Armbruster wrote: >> add_old_style_options() for img_convert() and img_resize() use >> qemu_opt_set(), which reports errors with qerror_report_err(). Its >> error messages aren't helpful here, the caller reports one that >> actually makes sense.

Re: [Qemu-devel] [PATCH 06/13] QemuOpts: Drop qemu_opt_set(), rename qemu_opt_set_err(), fix use

2015-02-17 Thread Markus Armbruster
Eric Blake writes: > On 02/16/2015 07:44 AM, Markus Armbruster wrote: >> qemu_opt_set() is a wrapper around qemu_opt_set() that reports the >> error with qerror_report_err(). >> >> Most of its users assume the function can't fail. Make them use >> qemu_opt_set_err() with &error_abort, so that s

Re: [Qemu-devel] [PATCH 2/4] ui/console: Removed unused functions

2015-02-17 Thread Gerd Hoffmann
On Mo, 2015-02-16 at 22:41 +0100, Thomas Huth wrote: > Remove dpy_gfx_update_dirty(), qemu_console_get_head(), > qemu_console_get_ui_info(), qemu_console_get_width(), > qemu_console_get_height(), emu_console_displaystate(), > qemu_different_endianness_pixelformat(), void cpkey(), > qemu_pixman_line

Re: [Qemu-devel] [PATCH v2 1/4] virtio-pci: add flags to enable/disable legacy/modern

2015-02-17 Thread Gerd Hoffmann
Hi, > Should we forbid setting both legacy and modern at the same time? No, this is explicitly allowed in the spec and it is needed for the transition from legacy to modern. cheers, Gerd

Re: [Qemu-devel] [PATCH 09/13] qemu-img: Suppress unhelpful extra errors in convert, amend

2015-02-17 Thread Markus Armbruster
Eric Blake writes: > On 02/16/2015 07:44 AM, Markus Armbruster wrote: >> img_convert() and img_amend() use qemu_opts_do_parse(), which reports >> errors with qerror_report_err(). Its error messages aren't helpful >> here, the caller reports one that actually makes sense. Reproducer: >> >>

Re: [Qemu-devel] [PATCH v2 1/4] virtio-pci: add flags to enable/disable legacy/modern

2015-02-17 Thread Michael S. Tsirkin
On Tue, Feb 17, 2015 at 09:23:35AM +0100, Gerd Hoffmann wrote: > Hi, > > > Should we forbid setting both legacy and modern at the same time? > > No, this is explicitly allowed in the spec and it is needed for the > transition from legacy to modern. > > cheers, > Gerd But !legacy && !modern

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-17 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 16/02/2015 14:37, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > >> Bonzini > >> On 16/02/2015 14:27, Pavel Dovgaluk wrote: > From: Paolo Bonzini [ma

Re: [Qemu-devel] [PATCH 04/10] vnc: switch to QemuOpts, allow multiple servers

2015-02-17 Thread Gerd Hoffmann
On Fr, 2015-02-13 at 19:25 +0100, Markus Armbruster wrote: > Gerd Hoffmann writes: > > > This patch switches vnc over to QemuOpts, and it (more or less > > as side effect) allows multiple vnc server instances. > > > > Signed-off-by: Gerd Hoffmann > > I'm afraid this broke monitor command change

Re: [Qemu-devel] [PATCH 3/4] util: Remove unused functions

2015-02-17 Thread Markus Armbruster
Thomas Huth writes: > Delete the unused functions qemu_opt_get_number_del(), > qemu_signalfd_available(), qemu_send_full() and qemu_recv_full(). > > Signed-off-by: Thomas Huth qemu_opt_get_number_del() was added in commit 782730b along with qemu_opt_get_del(), qemu_opt_get_bool_del() and qemu_o

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-17 Thread Vladimir Sementsov-Ogievskiy
On 16.02.2015 21:18, John Snow wrote: On 02/16/2015 07:06 AM, Vladimir Sementsov-Ogievskiy wrote: On 13.02.2015 23:22, John Snow wrote: On 02/13/2015 03:19 AM, Vladimir Sementsov-Ogievskiy wrote: On 11.02.2015 00:33, John Snow wrote: So in summary: using device names is probably fine fo

Re: [Qemu-devel] [PATCH 04/10] vnc: switch to QemuOpts, allow multiple servers

2015-02-17 Thread Gerd Hoffmann
Hi, > > static void qmp_change_vnc_listen(const char *target, Error **errp) > > { > > -vnc_display_open(NULL, target, errp); > > +QemuOptsList *olist = qemu_find_opts("vnc"); > > +QemuOpts *opts; > > + > > +if (strstr(target, "id=")) { > > +error_setg(errp, "id not supp

[Qemu-devel] [PATCH 0/2] vnc: -readconfig fixups

2015-02-17 Thread Gerd Hoffmann
Hi, Series applies on top of the pending vnc pull request. Fix -writeconfig/-readconfig related fallout from the QemuOpts conversion of the vnc configuration. cheers, Gerd Gerd Hoffmann (2): vnc: set id at parse time not init time vnc: -readconfig fix include/ui/console.h | 1 - qmp.c

[Qemu-devel] [PATCH 1/2] vnc: set id at parse time not init time

2015-02-17 Thread Gerd Hoffmann
This way the generated id will be stored in -writeconfig cfg files. Also we can make vnc_auto_assign_id() local to vnc.c. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 - qmp.c| 1 - ui/vnc.c | 22 -- 3 files changed, 12 insertions(+)

[Qemu-devel] [PATCH 2/2] vnc: -readconfig fix

2015-02-17 Thread Gerd Hoffmann
Now that -vnc goes through QemuOpts we can get vnc configuration via -readconfig too. So setting display_remote in the command line parsing code doesn't cut it any more, we must check QemuOpts instead to see whenever any vnc display is configured. Reported-by: Markus Armbruster Signed-off-by: Ge

Re: [Qemu-devel] [PATCH v2 1/4] virtio-pci: add flags to enable/disable legacy/modern

2015-02-17 Thread Gerd Hoffmann
On Di, 2015-02-17 at 09:42 +0100, Michael S. Tsirkin wrote: > On Tue, Feb 17, 2015 at 09:23:35AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > Should we forbid setting both legacy and modern at the same time? > > > > No, this is explicitly allowed in the spec and it is needed for the > > transi

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: Machine menu patch for Mac OS X

2015-02-17 Thread Kevin Wolf
Am 16.02.2015 um 18:00 hat Programmingkid geschrieben: > > On Feb 16, 2015, at 11:22 AM, Kevin Wolf wrote: > > > Am 16.02.2015 um 17:12 hat Programmingkid geschrieben: > >> > >> On Feb 16, 2015, at 10:42 AM, Kevin Wolf wrote: > >> > >>> Am 16.02.2015 um 16:31 hat Programmingkid geschrieben: > >

Re: [Qemu-devel] [PATCH] virtio-blk: Check return value of blk_aio_ioctl

2015-02-17 Thread Kevin Wolf
Am 17.02.2015 um 04:29 hat Fam Zheng geschrieben: > Since commit 1dc936aa84 (virtio-blk: Use blk_aio_ioctl) we silently lose > the request if blk_aio_ioctl returns NULL (not implemented). > > Fix it by directly returning VIRTIO_BLK_S_UNSUPP as we used to do. > > Signed-off-by: Fam Zheng > --- >

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: Machine menu patch for Mac OS X

2015-02-17 Thread Peter Maydell
On 17 February 2015 at 18:07, Kevin Wolf wrote: > The ID is user-defined, so no, no assumption about it is safe. If you > like, you can name your floppy drive 'ide0-cd1', your virtio harddisk > 'floppy1' and your ATAPI CD-ROM drive 'virtio0'. But if you do that, > I think it's reasonable to argue

[Qemu-devel] [PATCH] console/gtk: add qemu_console_get_label

2015-02-17 Thread Gerd Hoffmann
Add a new function to get a nice label for a given QemuConsole. Drop the labeling code in gtk.c and use the new function instead. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 + ui/console.c | 15 +++ ui/gtk.c | 12 +--- 3 files changed, 17 i

Re: [Qemu-devel] [PATCH] virtio-blk: Check return value of blk_aio_ioctl

2015-02-17 Thread Fam Zheng
On Tue, 02/17 10:34, Kevin Wolf wrote: > Am 17.02.2015 um 04:29 hat Fam Zheng geschrieben: > > Since commit 1dc936aa84 (virtio-blk: Use blk_aio_ioctl) we silently lose > > the request if blk_aio_ioctl returns NULL (not implemented). > > > > Fix it by directly returning VIRTIO_BLK_S_UNSUPP as we us

[Qemu-devel] [PATCH v2] virtio-blk: Check return value of blk_aio_ioctl

2015-02-17 Thread Fam Zheng
Since commit 1dc936aa84 (virtio-blk: Use blk_aio_ioctl) we silently lose the request if blk_aio_ioctl returns NULL (not implemented). Fix it by directly returning VIRTIO_BLK_S_UNSUPP as we used to do. Signed-off-by: Fam Zheng --- v2: Fix the leak of ioctl_req. (Kevin) --- hw/block/virtio-blk.c

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: Machine menu patch for Mac OS X

2015-02-17 Thread Kevin Wolf
Am 17.02.2015 um 10:41 hat Peter Maydell geschrieben: > On 17 February 2015 at 18:07, Kevin Wolf wrote: > > The ID is user-defined, so no, no assumption about it is safe. If you > > like, you can name your floppy drive 'ide0-cd1', your virtio harddisk > > 'floppy1' and your ATAPI CD-ROM drive 'vi

Re: [Qemu-devel] [PATCH 3/4] util: Remove unused functions

2015-02-17 Thread Thomas Huth
Hi, On Tue, 17 Feb 2015 09:55:33 +0100 Markus Armbruster wrote: > Thomas Huth writes: > > > Delete the unused functions qemu_opt_get_number_del(), > > qemu_signalfd_available(), qemu_send_full() and qemu_recv_full(). > > > > Signed-off-by: Thomas Huth > > qemu_opt_get_number_del() was adde

[Qemu-devel] [PATCH 2/4] acpi-build: fix ACPI RAM management

2015-02-17 Thread Michael S. Tsirkin
This fixes multiple issues around ACPI RAM management: RSDP and linker RAM aren't currently marked dirty on update, so they won't be migrated correctly. Let's handle all tables in the same way: set correct size (assert if too big), update, mark RAM dirty. This also drops assert checking that tab

[Qemu-devel] [PATCH 0/4] acpi: fix RSDP and linker memory management

2015-02-17 Thread Michael S. Tsirkin
This cleans up handling for rsdp and linker tables, which many people found confusing, and fixes bugs around linker and rsdp migration. Paolo, could you review/ack exec.c patch please? Michael S. Tsirkin (4): exec: round up size on MR resize acpi-build: fix RSDP/linker RAM migration acpi: h

[Qemu-devel] [PATCH 3/4] acpi: has_immutable_rsdp->!rsdp_in_ram

2015-02-17 Thread Michael S. Tsirkin
As comment in acpi-build.c notes, RSDP is not really immutable. So it's really a question of whether it's in RAM, name the variable accordingly. Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 2 +- hw/i386/acpi-build.c | 2 +- hw/i386/pc_piix.c| 6 +++--- hw/i386/pc_q35.c

[Qemu-devel] [PATCH 1/4] exec: round up size on MR resize

2015-02-17 Thread Michael S. Tsirkin
Block size must fundamentally be a multiple of target page size. Aligning automatically removes need to worry about the alignment from callers. Note: the only caller of qemu_ram_resize (acpi) already happens to have size padded to a power of 2, but we would like to drop the padding in ACPI core, a

[Qemu-devel] [PATCH 4/4] acpi-build: simplify rsdp management for legacy

2015-02-17 Thread Michael S. Tsirkin
For legacy machine types, rsdp is not in RAM, so we need a copy of rsdp for fw cfg. We previously used g_array_free with false parameter, but this seems to confuse people. This also wastes a bit of memory as the buffer is unused for new machine types. Let's just use plain g_memdup, and free origin

[Qemu-devel] [RFC PATCH 2/7] hw/arm/virt-acpi-build: Add GPIO controller in ACPI DSDT table

2015-02-17 Thread Shannon Zhao
Add GPIO controller in ACPI DSDT table. It can be used for device hotplug. Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 21 + hw/arm/virt.c|2 ++ include/hw/arm/virt-acpi-build.h |2 ++ 3 files changed, 25 insertions(+), 0 d

[Qemu-devel] [RFC PATCH 3/7] hw/acpi/virt-hotplug: Add a hotplug device for machine virt

2015-02-17 Thread Shannon Zhao
Add a hotplug device for machine virt. This can be used for virt to support device hotplug. At the moment this hotplug device just include a mmio region which shows the present status of cpus. Signed-off-by: Shannon Zhao --- default-configs/arm-softmmu.mak |2 + hw/acpi/Makefile.objs

[Qemu-devel] [RFC PATCH 1/7] hw/arm/virt: Add a GPIO controller

2015-02-17 Thread Shannon Zhao
Add a GPIO controller in machine virt, in order to support cpu hotplug. Here we use pl061. Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 8a00574..43c0260 10064

[Qemu-devel] [RFC PATCH 6/7] hw/arm/virt: Add cpu hotplug support

2015-02-17 Thread Shannon Zhao
Add a hotplug device in machine virt and add cpu hotplug support using cpu-add. Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 159 +++- include/hw/acpi/virt-hotplug.h |1 + 2 files changed, 159 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [RFC PATCH 4/7] topology: Move topology.h to an arch-independent location

2015-02-17 Thread Shannon Zhao
Move topology.h to an arch-independent location and the apicid_foo can be reused by other architectures. And remove the x86 prefix. Signed-off-by: Shannon Zhao --- include/hw/acpi/topology.h | 134 target-i386/cpu.c |4 +- target-i386/to

[Qemu-devel] [RFC PATCH 5/7] target-arm/cpu: Add apic_id property for ARMCPU

2015-02-17 Thread Shannon Zhao
Add apic_id property for ARMCPU. It can be used for cpu hotplug. Signed-off-by: Shannon Zhao --- target-arm/cpu-qom.h |1 + target-arm/cpu.c | 77 ++ target-arm/cpu.h |2 + 3 files changed, 80 insertions(+), 0 deletions(-) diff -

[Qemu-devel] [RFC PATCH 0/7] hw/arm/virt: Add cpu-add way cpu hotplug support

2015-02-17 Thread Shannon Zhao
Add cpu-add hotplug support in machine virt. As there are some properties which are set out of arm_cpu_initfn, so the way of device_add is not supported now. This will add at next version. Some good suggestion? This patchset is based on below patch: [RFC PATCH v3 00/11] Generate ACPI v5.1 tables a

[Qemu-devel] [RFC PATCH 7/7] hw/arm/virt-acpi-build: Add cpu hotplug support in ACPI

2015-02-17 Thread Shannon Zhao
Add cpu hotplug support in ACPI. Signed-off-by: Shannon Zhao --- hw/acpi/aml-build.c | 135 hw/acpi/virt-hotplug.c | 11 +++ hw/arm/virt-acpi-build.c | 179 +- hw/arm/virt.c|

Re: [Qemu-devel] [PATCH v6 04/24] qcow2: Only return status from qcow2_get_refcount

2015-02-17 Thread Kevin Wolf
Am 10.02.2015 um 21:28 hat Max Reitz geschrieben: > Refcounts can theoretically be of type uint64_t; in order to be able to > represent the full range, qcow2_get_refcount() cannot use a single > variable to represent both all refcount values and also keep some values > reserved for errors. > > One

Re: [Qemu-devel] [PATCH reformat] block: move I/O request processing to block/io.c

2015-02-17 Thread Stefan Hajnoczi
On Thu, Feb 5, 2015 at 12:22 PM, Kevin Wolf wrote: > Am 04.02.2015 um 18:51 hat Eric Blake geschrieben: >> From: Stefan Hajnoczi >> >> The block.c file has grown to over 6000 lines. It is time to split this >> file so there are fewer conflicts and the code is easier to maintain. >> >> Extract I/

Re: [Qemu-devel] [PATCH 1/2] vga: abort instead of shrinking memory

2015-02-17 Thread Radim Krčmář
2015-02-17 09:00+0100, Gerd Hoffmann: > On Mo, 2015-02-16 at 22:23 +0100, Radim Krčmář wrote: > > Automatic shrinking of vram_size leads to a segfault, because other > > variables depend on being smaller and don't get shrinked. > > --verbose please. Which other variables? I'm sorry, at least rom

Re: [Qemu-devel] [PATCH 2/2] qxl: surface0 and ram_header should fit into vram

2015-02-17 Thread Radim Krčmář
2015-02-17 09:02+0100, Gerd Hoffmann: > On Mo, 2015-02-16 at 22:23 +0100, Radim Krčmář wrote: > > The solution is not perfect, but won't let us do the same error again > > and has no overhead. > > How do you get qemu into a configuration where this isn't true? Without [1/2], by setting qxl-vga.vg

Re: [Qemu-devel] [PATCH v10 4/5] stm32f205: Add the stm32f205 SoC

2015-02-17 Thread Alistair Francis
On Tue, Feb 10, 2015 at 4:14 PM, Peter Crosthwaite wrote: > On Thu, Jan 29, 2015 at 4:31 AM, Alistair Francis > wrote: >> This patch adds the stm32f205 SoC. This will be used by the >> Netduino 2 to create a machine. >> >> Signed-off-by: Alistair Francis >> --- >> V6: >> - Correct the number o

Re: [Qemu-devel] [PATCH 1/2] vga: abort instead of shrinking memory

2015-02-17 Thread Gerd Hoffmann
On Di, 2015-02-17 at 11:29 +0100, Radim Krčmář wrote: > 2015-02-17 09:00+0100, Gerd Hoffmann: > > On Mo, 2015-02-16 at 22:23 +0100, Radim Krčmář wrote: > > > Automatic shrinking of vram_size leads to a segfault, because other > > > variables depend on being smaller and don't get shrinked. > > > >

Re: [Qemu-devel] [PATCH 1/2] vga: abort instead of shrinking memory

2015-02-17 Thread Radim Krčmář
2015-02-17 11:37+0100, Gerd Hoffmann: > On Di, 2015-02-17 at 11:29 +0100, Radim Krčmář wrote: > > 2015-02-17 09:00+0100, Gerd Hoffmann: > > > On Mo, 2015-02-16 at 22:23 +0100, Radim Krčmář wrote: > > > > Automatic shrinking of vram_size leads to a segfault, because other > > > > variables depend on

Re: [Qemu-devel] [PATCH 1/2] vga: abort instead of shrinking memory

2015-02-17 Thread Gerd Hoffmann
Hi, > > Which command line triggers it? > > The important subset is: > -vga qxl -global qxl-vga.vgamem_mb=512 Ah, so the problem is only one place enforces a upper limit, so we can get an invalid configuration with large values. Can you try the attached patch? cheers, Gerd >From 7e5e3f9

Re: [Qemu-devel] [PATCH v10 2/7] hw/vfio/platform: vfio-platform skeleton

2015-02-17 Thread Alex Bennée
Eric Auger writes: > Minimal VFIO platform implementation supporting register space > user mapping but not IRQ assignment. > > Signed-off-by: Kim Phillips > Signed-off-by: Eric Auger See comments inline. > +/** > + * vfio_populate_device - initialize MMIO region and IRQ > + * @vbasedev: the

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-17 Thread Paolo Bonzini
On 17/02/2015 09:43, Pavel Dovgaluk wrote: >> > int64_t deadline = qemu_clock_deadline_ns_all(QEMU_CLOCK_VIRTUAL); >> > if (deadline == 0) { >> > qemu_clock_notify(QEMU_CLOCK_VIRTUAL); >> > } >> > >> > instead of qemu_notify_event(), and remove these lines from >> > qemu_

Re: [Qemu-devel] [PATCH v6 00/24] qcow2: Support refcount orders != 4

2015-02-17 Thread Kevin Wolf
Am 10.02.2015 um 21:28 hat Max Reitz geschrieben: > As of version 3, the qcow2 file format supports different widths for > refcount entries, ranging from 1 to 64 bit (only powers of two). > Currently, qemu only supports 16 bit, which is the only width supported > by version 2 (compat=0.10) images.

Re: [Qemu-devel] [PATCH 1/2] vga: abort instead of shrinking memory

2015-02-17 Thread Radim Krčmář
2015-02-17 11:51+0100, Gerd Hoffmann: > Hi, > > > > Which command line triggers it? > > > > The important subset is: > > -vga qxl -global qxl-vga.vgamem_mb=512 > > Ah, so the problem is only one place enforces a upper limit, so we can > get an invalid configuration with large values. (I thi

Re: [Qemu-devel] [PATCH v10 3/7] hw/vfio/platform: add irq assignment

2015-02-17 Thread Alex Bennée
Eric Auger writes: > This patch adds the code requested to assign interrupts to > a guest. The interrupts are mediated through user handled > eventfds only. > > The mechanics to start the IRQ handling is not yet there through. > > Signed-off-by: Eric Auger See comments inline. > > --- > > v8

Re: [Qemu-devel] [PATCH v10 5/7] hw/vfio: calxeda xgmac device

2015-02-17 Thread Alex Bennée
Eric Auger writes: > The platform device class has become abstract. This patch introduces > a calxeda xgmac device that can be be instantiated on command line > using such option. > > -device vfio-calxeda-xgmac,host="fff51000.ethernet" > > Signed-off-by: Eric Auger Reviewed-by: Alex Bennée >

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-17 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 17/02/2015 09:43, Pavel Dovgaluk wrote: > >> > int64_t deadline = qemu_clock_deadline_ns_all(QEMU_CLOCK_VIRTUAL); > >> > if (deadline == 0) { > >> > qemu_clock_notify(QEMU_CLOCK_VIRTUAL); > >> > } > >> > > >> > instead

Re: [Qemu-devel] [PATCH v10 6/7] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation

2015-02-17 Thread Alex Bennée
Eric Auger writes: > vfio-calxeda-xgmac now can be instantiated using the -device option. > The node creation function generates a very basic dt node composed > of the compat, reg and interrupts properties > > Signed-off-by: Eric Auger > > --- > v8 -> v9: > - properly free resources in case of

Re: [Qemu-devel] [PATCH v10 7/7] hw/vfio/platform: add irqfd support

2015-02-17 Thread Alex Bennée
Eric Auger writes: > This patch aims at optimizing IRQ handling using irqfd framework. > > Instead of handling the eventfds on user-side they are handled on > kernel side using > - the KVM irqfd framework, > - the VFIO driver virqfd framework. > > the virtual IRQ completion is trapped at interru

Re: [Qemu-devel] KVM call for agenda for 2015-02-17

2015-02-17 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. As there are no agenda, call got cancelled. Have a good day, Juan. > > > Call details: > > By popular demand, a google calendar public entry with it > > > https://www.google.com/calendar/embed?src=dG9i

Re: [Qemu-devel] [PATCH 04/10] vnc: switch to QemuOpts, allow multiple servers

2015-02-17 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> > static void qmp_change_vnc_listen(const char *target, Error **errp) >> > { >> > -vnc_display_open(NULL, target, errp); >> > +QemuOptsList *olist = qemu_find_opts("vnc"); >> > +QemuOpts *opts; >> > + >> > +if (strstr(target, "id=")) { >> > +

Re: [Qemu-devel] [PATCH v2 0/6] TriCore: Add RRR1 and RRR2 instructions

2015-02-17 Thread Bastian Koppelmann
On 02/11/2015 04:48 PM, Bastian Koppelmann wrote: Hi, the patchset fixes two minor bugs and takes care of all the packed/fixed point mac instructions. So far I only implemented all the multiply-add instructions, since the multiply-sub instructions are similar and I don't want the reviewers to f

Re: [Qemu-devel] [PATCH v3 31/52] acpi: add aml_local() term

2015-02-17 Thread Michael S. Tsirkin
On Mon, Feb 09, 2015 at 10:53:53AM +, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- This causes asserts. > hw/acpi/aml-build.c | 11 +++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-

Re: [Qemu-devel] [PATCH 0/2] vnc: -readconfig fixups

2015-02-17 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > > Series applies on top of the pending vnc pull request. > Fix -writeconfig/-readconfig related fallout from > the QemuOpts conversion of the vnc configuration. Tested-by: Markus Armbruster I don't like that ID "default" is special, but as long as I can't offer

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-17 Thread Paolo Bonzini
On 17/02/2015 12:35, Pavel Dovgaluk wrote: > How can I wake up iothread if there are no pending timers? > deadline will (almost) never become zero in my case, because there is > another kind of event in the log (not the timer one). > Should I fetch the event and call qemu_notify_event() from rep

Re: [Qemu-devel] [PATCH 01/25] s390x/mmu: Move mmu_translate() and friends to separate file

2015-02-17 Thread Alexander Graf
On 02/12/2015 06:09 PM, Jens Freimann wrote: From: Thomas Huth helper.c is quite overcrowded already, so let's move the MMU translation to a separate file instead (like it has been done with the other targets already). Signed-off-by: Thomas Huth Signed-off-by: Jens Freimann Acked-by: Alexa

[Qemu-devel] [PATCH v11 0/5] Netduino 2 Machine Model

2015-02-17 Thread Alistair Francis
This patch series adds the Netduino 2 Machine to QEMU Information on the board is avalible at: http://www.netduino.com/netduino2/specs.htm The git tree can be found at: https://github.com/alistair23/qemu/tree/netduino2.11 Some example code that runs on QEMU is avaliable at: at: https://github.co

[Qemu-devel] [PATCH v11 3/5] stm32f2xx_SYSCFG: Add the stm32f2xx SYSCFG

2015-02-17 Thread Alistair Francis
This patch adds the stm32f2xx System Configuration Controller. This is used to configure what memory is mapped at address 0 (although that is not supported) as well as configure how the EXTI interrupts work (also not supported at the moment). This device is not required for basic examples, but mor

[Qemu-devel] [PATCH v11 1/5] stm32f2xx_timer: Add the stm32f2xx Timer

2015-02-17 Thread Alistair Francis
This patch adds the stm32f2xx timers: TIM2, TIM3, TIM4 and TIM5 to QEMU. Signed-off-by: Alistair Francis Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Crosthwaite --- V11: - Tidy up the register write refresh code V10: - Correct the units based on a patch by Peter C V9: - Convert tick_

[Qemu-devel] [PATCH v11 4/5] stm32f205: Add the stm32f205 SoC

2015-02-17 Thread Alistair Francis
This patch adds the stm32f205 SoC. This will be used by the Netduino 2 to create a machine. Signed-off-by: Alistair Francis --- V11: - Update the headers to only include the required files - Make the CPU Model a property that can be defined V6: - Correct the number of USART/UART devices - Use

[Qemu-devel] [PATCH v11 2/5] stm32f2xx_USART: Add the stm32f2xx USART Controller

2015-02-17 Thread Alistair Francis
This patch adds the stm32f2xx USART controller (UART also uses the same controller). Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- V11: - Update the header macros to only be included once V8: - Clear IRQ on reset - Lower IRQ on data read/status clear - Set IRQ if enabled

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: Machine menu patch for Mac OS X

2015-02-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 16.02.2015 um 18:00 hat Programmingkid geschrieben: >> >> On Feb 16, 2015, at 11:22 AM, Kevin Wolf wrote: >> >> > Am 16.02.2015 um 17:12 hat Programmingkid geschrieben: >> >> >> >> On Feb 16, 2015, at 10:42 AM, Kevin Wolf wrote: >> >> >> >>> Am 16.02.2015 um 16:31 hat

[Qemu-devel] [PATCH v11 5/5] netduino2: Add the Netduino 2 Machine

2015-02-17 Thread Alistair Francis
This patch adds the Netduino 2 Machine. This is a Cortex-M3 based machine. Information can be found at: http://www.netduino.com/netduino2/specs.htm Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- hw/arm/Makefile.objs | 1 + hw/arm/netduino2.c | 57 +++

Re: [Qemu-devel] [PATCH v3 03/17] virtio: use standard virtio_ring.h

2015-02-17 Thread Thomas Huth
On Mon, 16 Feb 2015 22:35:40 +0100 "Michael S. Tsirkin" wrote: > Switch to virtio_ring.h from standard headers. > > Signed-off-by: Michael S. Tsirkin > --- > include/hw/virtio/dataplane/vring.h | 2 +- > include/hw/virtio/virtio_ring.h | 167 > > hw/

Re: [Qemu-devel] [PATCH v3 02/17] include: import virtio headers from linux 4.0

2015-02-17 Thread Thomas Huth
On Mon, 16 Feb 2015 22:35:31 +0100 "Michael S. Tsirkin" wrote: > Add files imported from linux-next (what will become linux 4.0) using > scripts/update-linux-headers.sh > > Signed-off-by: Michael S. Tsirkin > --- > include/standard-headers/linux/if_ether.h | 1 + > include/standard-hea

Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause

2015-02-17 Thread Amit Shah
On (Wed) 11 Feb 2015 [16:46:21], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > This patchset provides a way of setting options on an incoming > migration before the fd/process/socket has been created. > >start qemu with -incoming pause > >migrate_incoming

Re: [Qemu-devel] [PATCH v3 04/17] virtio: use standard-headers

2015-02-17 Thread Thomas Huth
On Mon, 16 Feb 2015 22:35:46 +0100 "Michael S. Tsirkin" wrote: > Drop a bunch of code duplicated from virtio_config.h and virtio_ring.h. > This makes us rename event index accessors which conflict, > as reusing the ones from virtio_ring.h isn't trivial. > > Signed-off-by: Michael S. Tsirkin > -

Re: [Qemu-devel] [PATCH v3 05/17] virtio-balloon: use standard headers

2015-02-17 Thread Thomas Huth
On Mon, 16 Feb 2015 22:35:52 +0100 "Michael S. Tsirkin" wrote: > Drop code duplicated from standard headers. > > Signed-off-by: Michael S. Tsirkin > --- > include/hw/virtio/virtio-balloon.h | 35 ++- > 1 file changed, 2 insertions(+), 33 deletions(-) > > diff -

[Qemu-devel] [PATCH 0/4] ucb: Convert remaining PCI HCDs to realize

2015-02-17 Thread Markus Armbruster
This series requires my "[PATCH 00/10] pci: Partial conversion to realize" and my "[PATCH 0/9] Clean up around error_get_pretty(), qerror_report_err()". Markus Armbruster (4): usb: Propagate errors through usb_register_companion() usb: Improve companion configuration error messages ohci: Com

[Qemu-devel] [PATCH 3/4] ohci: Complete conversion to realize

2015-02-17 Thread Markus Armbruster
Commit 457215ec "ohci: Use QOM realize for OHCI" converted only "sysbus-ohci". Finish the job: convert "pci-ohci". Signed-off-by: Markus Armbruster --- hw/usb/hcd-ohci.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/hw/usb/hcd-ohci.c b/

[Qemu-devel] [PATCH 4/4] uhci: Convert to realize

2015-02-17 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/usb/hcd-uhci.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 2ca8de3..e791377 100644 --- a/hw/usb/hcd-uhci.c +++ b/hw/usb/hcd-uhci.c @@ -66,7 +66,7 @@ struct UHCIInfo {

[Qemu-devel] [PATCH 1/4] usb: Propagate errors through usb_register_companion()

2015-02-17 Thread Markus Armbruster
This loses the messages explaining the error printed with error_printf_unless_qmp(). The next commit will make up for the loss. Signed-off-by: Markus Armbruster --- hw/usb/bus.c | 17 ++--- hw/usb/hcd-ehci.c | 23 +-- hw/usb/hcd-ohci.c | 10 +++--- hw/us

[Qemu-devel] [PATCH 2/4] usb: Improve companion configuration error messages

2015-02-17 Thread Markus Armbruster
The previous commit broke the additional messages explaining the error messages. Improve the error messages, so they don't need explaining so much. Helps QMP users as well, unlike additional explanations. Signed-off-by: Markus Armbruster --- hw/usb/bus.c | 18 -- hw/usb/hc

Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause

2015-02-17 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > On (Wed) 11 Feb 2015 [16:46:21], Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > This patchset provides a way of setting options on an incoming > > migration before the fd/process/socket has been created. > > > >start

Re: [Qemu-devel] [PATCH v6 09/24] qcow2: More helpers for refcount modification

2015-02-17 Thread Kevin Wolf
Am 10.02.2015 um 21:28 hat Max Reitz geschrieben: > Add helper functions for getting and setting refcounts in a refcount > array for any possible refcount order, and choose the correct one during > refcount initialization. > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > Reviewed-by: Ste

Re: [Qemu-devel] [PATCH 1/4] exec: round up size on MR resize

2015-02-17 Thread Igor Mammedov
On Tue, 17 Feb 2015 11:05:36 +0100 "Michael S. Tsirkin" wrote: > Block size must fundamentally be a multiple of target page size. > Aligning automatically removes need to worry about the alignment > from callers. > > Note: the only caller of qemu_ram_resize (acpi) already happens to have > size

Re: [Qemu-devel] [PATCH v3 06/17] virtio-9p: use standard headers

2015-02-17 Thread Thomas Huth
On Mon, 16 Feb 2015 22:35:57 +0100 "Michael S. Tsirkin" wrote: > Drop code duplicated from standard headers. > > Signed-off-by: Michael S. Tsirkin > --- > hw/9pfs/virtio-9p.h | 17 + > 1 file changed, 1 insertion(+), 16 deletions(-) > > diff --git a/hw/9pfs/virtio-9p.h b/hw/9p

[Qemu-devel] [PATCH] qcow2: Remove unused struct QCowCreateState

2015-02-17 Thread Kevin Wolf
The only user went away five years ago with commit a9420734 ('qcow2: Simplify image creation'). It's about time to remove it. Signed-off-by: Kevin Wolf --- block/qcow2.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/block/qcow2.h b/block/qcow2.h index 17c9a3f..a9108f5 100644 --

Re: [Qemu-devel] [PATCH 2/4] acpi-build: fix ACPI RAM management

2015-02-17 Thread Igor Mammedov
On Tue, 17 Feb 2015 11:05:39 +0100 "Michael S. Tsirkin" wrote: > This fixes multiple issues around ACPI RAM management: > > RSDP and linker RAM aren't currently marked dirty > on update, so they won't be migrated correctly. > > Let's handle all tables in the same way: set correct size (assert i

Re: [Qemu-devel] [PATCH v6 09/24] qcow2: More helpers for refcount modification

2015-02-17 Thread Max Reitz
On 2015-02-17 at 08:38, Kevin Wolf wrote: Am 10.02.2015 um 21:28 hat Max Reitz geschrieben: Add helper functions for getting and setting refcounts in a refcount array for any possible refcount order, and choose the correct one during refcount initialization. Signed-off-by: Max Reitz Reviewed-b

Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support

2015-02-17 Thread Scott Feldman
On Tue, Feb 17, 2015 at 1:48 AM, Paolo Bonzini wrote: > > > On 16/02/2015 23:37, Scott Feldman wrote: >>> > I would just merge the other nine patches for 2.3. >> I disagree. qmp/hmp is very important to rocker. It would be nearly >> impossible to debug large/complicated networking setups without

Re: [Qemu-devel] [PATCH 7/7] target-mips: Add IEEE 754-2008 features support

2015-02-17 Thread Maciej W. Rozycki
On Tue, 9 Dec 2014, Maciej W. Rozycki wrote: > Index: qemu-git-trunk/target-mips/op_helper.c > === > --- qemu-git-trunk.orig/target-mips/op_helper.c 2014-12-08 > 23:22:12.0 + > +++ qemu-git-trunk/target-mips/op_help

Re: [Qemu-devel] [PATCH 3/4] acpi: has_immutable_rsdp->!rsdp_in_ram

2015-02-17 Thread Igor Mammedov
On Tue, 17 Feb 2015 11:05:42 +0100 "Michael S. Tsirkin" wrote: > As comment in acpi-build.c notes, RSDP is not really immutable. So it's > really a question of whether it's in RAM, name the variable accordingly. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov > --- > includ

Re: [Qemu-devel] [PATCH v3 31/52] acpi: add aml_local() term

2015-02-17 Thread Igor Mammedov
On Tue, 17 Feb 2015 13:18:19 +0100 "Michael S. Tsirkin" wrote: > On Mon, Feb 09, 2015 at 10:53:53AM +, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > This causes asserts. > > > hw/acpi/aml-build.c | 11 +++ > > include/hw/acpi/aml-build.h | 1 + > > 2 f

Re: [Qemu-devel] [PATCH 1/4] exec: round up size on MR resize

2015-02-17 Thread Paolo Bonzini
On 17/02/2015 14:45, Igor Mammedov wrote: > On Tue, 17 Feb 2015 11:05:36 +0100 > "Michael S. Tsirkin" wrote: > >> Block size must fundamentally be a multiple of target page size. >> Aligning automatically removes need to worry about the alignment >> from callers. >> >> Note: the only caller of

Re: [Qemu-devel] [PATCH v3 10/17] virtio-scsi: use standard-headers

2015-02-17 Thread Paolo Bonzini
On 16/02/2015 22:36, Michael S. Tsirkin wrote: > Drop duplicated code. > > Signed-off-by: Michael S. Tsirkin > --- > include/hw/virtio/virtio-scsi.h | 120 > +++- > hw/scsi/virtio-scsi.c | 1 + > 2 files changed, 10 insertions(+), 111 deletions(

Re: [Qemu-devel] [PATCH] qcow2: Remove unused struct QCowCreateState

2015-02-17 Thread Max Reitz
On 2015-02-17 at 08:49, Kevin Wolf wrote: The only user went away five years ago with commit a9420734 ('qcow2: Simplify image creation'). It's about time to remove it. Signed-off-by: Kevin Wolf --- block/qcow2.h | 11 --- 1 file changed, 11 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH 4/4] acpi-build: simplify rsdp management for legacy

2015-02-17 Thread Igor Mammedov
On Tue, 17 Feb 2015 11:05:45 +0100 "Michael S. Tsirkin" wrote: > For legacy machine types, rsdp is not in RAM, so we need a copy of rsdp > for fw cfg. We previously used g_array_free with false parameter, > but this seems to confuse people. > This also wastes a bit of memory as the buffer is unus

Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes

2015-02-17 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Hi > > (Li special edition) > > Current migration code returns number of bytes transferred and from > there we decide if we.have sent something or not. Problem, we need > two results: number of pages written, and number of bytes written > (depending

[Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-17 Thread Michael Mueller
This patch implements the static part of the s390 cpu class definitions. It defines s390 cpu models by means of virtual cpu ids (enum) which contain information on the cpu generation, the machine class, the GA number and the machine type. The cpu id is used to instantiate a cpu class per cpu model.

[Qemu-devel] [RFC PATCH v2 03/15] cpu-model: Introduce stub routine cpu_desc_avail

2015-02-17 Thread Michael Mueller
This patch introduces the function cpu_desc_avail() which returns by default true if not architecture specific implemented. Its intention is to indicate if the cpu model description is available for display by list_cpus(). This change allows cpu model descriptions to become dynamically created by e

  1   2   3   >