Hi, On Tue, 17 Feb 2015 09:55:33 +0100 Markus Armbruster <arm...@redhat.com> wrote:
> Thomas Huth <th...@linux.vnet.ibm.com> writes: > > > Delete the unused functions qemu_opt_get_number_del(), > > qemu_signalfd_available(), qemu_send_full() and qemu_recv_full(). > > > > Signed-off-by: Thomas Huth <th...@linux.vnet.ibm.com> > > qemu_opt_get_number_del() was added in commit 782730b along with > qemu_opt_get_del(), qemu_opt_get_bool_del() and qemu_opt_get_size_del(). > It hasn't been used so far, but removing it makes the interface > irregular. I'd rather not. Ok, then let's keep them. > qemu_signalfd_available() is unused since commit 6d32717. It's also the > only user of CONFIG_SIGNALFD. If we want to drop it, I recommend > dropping CONFIG_SIGNALFD as well. As far as I can see, CONFIG_SIGNALFD is still used in qemu_signalfd(), so I think we've got to keep that. Thomas
