Gerd Hoffmann <kra...@redhat.com> writes: > Hi, > >> > static void qmp_change_vnc_listen(const char *target, Error **errp) >> > { >> > - vnc_display_open(NULL, target, errp); >> > + QemuOptsList *olist = qemu_find_opts("vnc"); >> > + QemuOpts *opts; >> > + >> > + if (strstr(target, "id=")) { >> > + error_setg(errp, "id not supported"); >> > + return; >> > + } >> >> Aside: this is unclean. Could we somehow test qemu_opts_id() instead? > > For that we would have to parse it first, which has some ugly corner > cases on id clashes ... > > All I wanna do here is keep it alive for the existing use cases, without > support for multiple displays, with minimum effort. > > Should we need support for vnc config change in a multiple vnc server > setup a new qmp monitor command should be designed for that.
Fair enough. Suggests that the QemuOpts API is lacking, though.