Re: [Qemu-devel] [PATCH RFC v6 13/20] virtio: allow to fail setting status

2015-01-08 Thread Michael S. Tsirkin
On Thu, Jan 08, 2015 at 08:20:37AM +0100, Cornelia Huck wrote: > On Wed, 7 Jan 2015 21:08:21 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Jan 07, 2015 at 05:13:32PM +0100, Cornelia Huck wrote: > > > On Tue, 30 Dec 2014 14:25:37 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Thu,

[Qemu-devel] Fwd: [question] About MSI for vioscsi

2015-01-08 Thread Wangting (Kathy)
Hi Vadim, In order to enable MSI for vioscsi in virtio-win-0.1-74, I try to merge the patch about Bug 1077566 into it, but I find that MSI still doesn't work, because the value of IRQ is not negative in the device manager. I try to trace the I/O path with ENABLE_COM_DEBUG, and I find that

Re: [Qemu-devel] Ping [PATCH] Fix irq route entries exceed KVM_MAX_IRQ_ROUTES

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 04:28, kevinnma(马文霜) wrote: > Ping > > Patches here: > http://patchwork.ozlabs.org/patch/424738/ > > Description: > In multi-core guest, set irq affinity will eventually lead to guest crash, > this is a > severe BUG, I do not know why this patch was ignored? Because there is on

Re: [Qemu-devel] [PATCH] Fix irq route entries exceed KVM_MAX_IRQ_ROUTES

2015-01-08 Thread Paolo Bonzini
On 31/12/2014 04:45, kevinnma(马文霜) wrote: > Last month, we experienced several guests crash(6cores-8cores),qemu logs > display the following messages: > > qemu-system-x86_64: /build/qemu-2.1.2/kvm-all.c:976: > kvm_irqchip_commit_routes: Assertion `ret == 0' failed. > > After analysis and verifi

Re: [Qemu-devel] Fwd: [question] About MSI for vioscsi

2015-01-08 Thread Vadim Rozenfeld
On Thu, 2015-01-08 at 16:40 +0800, Wangting (Kathy) wrote: > Hi Vadim, > >In order to enable MSI for vioscsi in virtio-win-0.1-74, I try to merge > > the patch about Bug 1077566 into it, but I find that MSI still doesn't work, > > because the value of IRQ is not negative in the device manage

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-08 Thread Gerd Hoffmann
Hi, > VGA: Using shared surface for depth=32 swap=1 Ok, 32bpp. byteswapping needed. I guess the host is a intel macintosh then? Having a quick look at the cocoa code it seems it doesn't look at the color masks and shifts, only the color depth. So having the UI handle the byteswapping that w

Re: [Qemu-devel] Fwd: [question] About MSI for vioscsi

2015-01-08 Thread Wangting (Kathy)
On 2015-1-8 17:01, Vadim Rozenfeld wrote: > On Thu, 2015-01-08 at 16:40 +0800, Wangting (Kathy) wrote: >> Hi Vadim, >> >>In order to enable MSI for vioscsi in virtio-win-0.1-74, I try to merge >> >> the patch about Bug 1077566 into it, but I find that MSI still doesn't work, >> >> because the

[Qemu-devel] [PATCH 0/4] qemu-timer: introduce usable pointer-free API

2015-01-08 Thread Paolo Bonzini
The current pointer free API for timers is very low level. Introduce a new API that matches timer_new_ns/us/ms and also a new API timer_deinit that can be used instead of timer_free. Finally, mechanically change timer macro names in vmstate, to make it clear that they accept a pointer. This prep

Re: [Qemu-devel] Fwd: [question] About MSI for vioscsi

2015-01-08 Thread Vadim Rozenfeld
On Thu, 2015-01-08 at 17:27 +0800, Wangting (Kathy) wrote: > > On 2015-1-8 17:01, Vadim Rozenfeld wrote: > > On Thu, 2015-01-08 at 16:40 +0800, Wangting (Kathy) wrote: > >> Hi Vadim, > >> > >>In order to enable MSI for vioscsi in virtio-win-0.1-74, I try to merge > >> > >> the patch about Bug

[Qemu-devel] [PATCH 4/4] vmstate: accept QEMUTimer in VMSTATE_TIMER*, add VMSTATE_TIMER_PTR*

2015-01-08 Thread Paolo Bonzini
Old users of VMSTATE_TIMER* are mechanically changed to VMSTATE_TIMER_PTR variants. Signed-off-by: Paolo Bonzini --- hw/acpi/ich9.c | 2 +- hw/acpi/piix4.c | 2 +- hw/arm/stellaris.c | 2 +- hw/block/fdc.c | 2 +- hw/char/cadence_uart.c |

[Qemu-devel] [PATCH 2/4] qemu-timer: add timer_init and timer_init_ns/us/ms

2015-01-08 Thread Paolo Bonzini
These functions for the main loop TimerListGroup will replace timer_new and timer_new_ns/us/ms. Signed-off-by: Paolo Bonzini --- include/qemu/timer.h | 73 1 file changed, 73 insertions(+) diff --git a/include/qemu/timer.h b/include/qemu/time

[Qemu-devel] [PATCH 1/4] qemu-timer: rename timer_init to timer_init_tl

2015-01-08 Thread Paolo Bonzini
timer_init is not called that often. Free the name for an equivalent of timer_new. Signed-off-by: Paolo Bonzini --- include/block/aio.h | 2 +- include/qemu/timer.h | 10 +- qemu-timer.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/block/

[Qemu-devel] [PATCH 3/4] qemu-timer: introduce timer_deinit

2015-01-08 Thread Paolo Bonzini
In some cases, a timer was set to NULL so that we could check if it is initialized. Use the timer_list field instead, and add a timer_deinit function that NULLs it. It then makes sense that timer_del be a no-op (instead of a crasher) on such a de-initialized timer. It avoids the need to poke at

Re: [Qemu-devel] [Qemu-stable] 2.1 unexpected stop after exporting blockdev via nbd server

2015-01-08 Thread Stefan Hajnoczi
On Thu, Jan 8, 2015 at 1:17 AM, Michael Roth wrote: > Quoting Stefan Hajnoczi (2015-01-06 05:49:11) >> On Mon, Jan 05, 2015 at 05:12:10PM +0400, Andrey Korolyov wrote: >> > On Fri, Jan 2, 2015 at 4:04 PM, Stefan Hajnoczi wrote: >> > > On Thu, Dec 18, 2014 at 07:38:59PM +0400, Andrey Korolyov wrot

Re: [Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-08 Thread Peter Maydell
On 7 January 2015 at 15:52, Claudio Fontana wrote: > Interrupt map does not seem to work for me; incidentally this ends up being > the same kind of undocumented blob that Alvise posted in his series. Can > you add a good comment about what the ranges property contains > (the 0x0100, 0x0200

Re: [Qemu-devel] [Makefile] Compiling Qemu to dynamic library

2015-01-08 Thread Peter Maydell
On 8 January 2015 at 04:02, Halsey Pian wrote: > ./stubs/slirp.c:void slirp_pollfds_fill(GArray *pollfds, uint32_t *timeout) > > ./main-loop.c:slirp_pollfds_fill(gpollfds, &timeout); > Do you know when qemustub should be used? libqemustub.a is only used for > qemu-img, qemu-nbd, qemu-io, but

Re: [Qemu-devel] [PATCH RESEND v2 0/3] vl: smp_parse sanity checks

2015-01-08 Thread Paolo Bonzini
On 19/12/2014 03:59, Eduardo Habkost wrote: > From the original series sent by Andrew, only patch 1/3 was kept. Patch 2/3 > from v1 was replaced by a safer fix. Patch 3/3 was removed because it > generates > a warning even on the most common use-case ("-smp " without any extra > options). > > A

[Qemu-devel] [PATCH 3/3] migration_cancel: shutdown migration socket

2015-01-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Force shutdown on migration socket on cancel to cause the cancel to complete even if the socket is blocked on a dead network. Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 12 1 file changed, 12 insertions(+) diff --git a/migrati

[Qemu-devel] [PATCH 2/3] Handle bi-directional communication for fd migration

2015-01-08 Thread Dr. David Alan Gilbert (git)
From: Cristian Klein libvirt prefers opening the TCP connection itself, for two reasons. First, connection failed errors can be detected easier, without having to parse qemu's error output. Second, libvirt might be asked to secure the transfer by tunnelling the communication through an TLS layer.

[Qemu-devel] [PATCH 0/3] Migration cancel with dead network

2015-01-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" If the remote host, or networking dies during a migration, the socket can be waiting for a long timeout, and migration_cancel can't complete the cancel for a long time (and you can't start a new one to somewhere else). (Where 'long' is the TCP timeout, that's ~15 mi

[Qemu-devel] [PATCH 1/3] socket shutdown

2015-01-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add QEMUFile interface to allow a socket to be 'shut down' - i.e. any reads/writes will fail (and any blocking read/write will be woken). Signed-off-by: Dr. David Alan Gilbert --- include/migration/qemu-file.h | 10 ++ include/qemu/sockets.h| 7 +

Re: [Qemu-devel] [PATCH 0/3] Migration cancel with dead network

2015-01-08 Thread Daniel P. Berrange
On Thu, Jan 08, 2015 at 11:11:29AM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > If the remote host, or networking dies during a migration, the socket can be > waiting for a long timeout, and migration_cancel can't complete the cancel > for a long time (and you c

Re: [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-08 Thread Gerd Hoffmann
On Do, 2015-01-08 at 11:50 +0100, Javier Celaya wrote: > Hello > > Recently, SPICE included the lz4 compression algorithm. This patch adds > a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not > exist before the commit that added this compression algorithm, so it should

Re: [Qemu-devel] [PATCH 0/3] Migration cancel with dead network

2015-01-08 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Thu, Jan 08, 2015 at 11:11:29AM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > If the remote host, or networking dies during a migration, the socket can be > > waiting for a long timeout, and migration_c

Re: [Qemu-devel] [PATCH 0/3] Migration cancel with dead network

2015-01-08 Thread Daniel P. Berrange
On Thu, Jan 08, 2015 at 11:29:59AM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Thu, Jan 08, 2015 at 11:11:29AM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > If the remote host, or networking die

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-08 Thread Fabio Fantoni
Il 08/01/2015 11:50, Javier Celaya ha scritto: > Hello > > Recently, SPICE included the lz4 compression algorithm. This patch adds > a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not > exist before the commit that added this compression algorithm, so it should > be >

Re: [Qemu-devel] [PATCH] vmstate: type-check sub-arrays

2015-01-08 Thread Amit Shah
On (Wed) 07 Jan 2015 [15:12:13], Paolo Bonzini wrote: > While we cannot check against the type of the full array, we can check > against the type of the fields. > > Signed-off-by: Paolo Bonzini Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH 0/3] Migration cancel with dead network

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 12:11, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > If the remote host, or networking dies during a migration, the socket can be > waiting for a long timeout, and migration_cancel can't complete the cancel > for a long time (and you can't start a new on

Re: [Qemu-devel] [Qemu-stable] 2.1 unexpected stop after exporting blockdev via nbd server

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 11:31, Stefan Hajnoczi wrote: > Excellent, please add the following commits to stable: > f214928 nbd: Follow the BDS' AIO context > 3338442 block: Add AIO context notifiers > 958c717 nbd: Drop nbd_can_read() > > They prevent crashes when the run-time NBD server is used together > w

Re: [Qemu-devel] [RFC V9 4/4] domain snapshot design: libxl/libxlu

2015-01-08 Thread Ian Campbell
On Mon, 2014-12-22 at 02:36 -0700, Chun Yan Liu wrote: > > > b). For internal snapshot, like qcow2, lvm too. For lvm, it doesn't > > > support > > > snapshot of snapshot, so out of scope. For qcow2, delete any disk > > > snapshot > > > won't affect others. > > > > For either internal or exte

[Qemu-devel] [PATCH 0/6] linux-user: Fix various clang warnings

2015-01-08 Thread Peter Maydell
This patchset fixes warnings produced by clang in the linux-user code. Mostly this is deleting or marking unused functions/data, but it does include a genuine bugfix for Alpha. I think that this means I have patches out on the list now for all the clang warnings we currently generate; maybe some d

[Qemu-devel] [PATCH 5/6] linux-user/main.c: Mark end_exclusive() as possibly unused

2015-01-08 Thread Peter Maydell
The function end_exclusive() isn't used on all targets; mark it as such to avoid a clang warning. Signed-off-by: Peter Maydell --- linux-user/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/main.c b/linux-user/main.c index bbd1cfd..0fda51c 100644 --- a/linux

[Qemu-devel] [PATCH 3/6] linux-user/arm/nwfpe: Delete unused aCC array

2015-01-08 Thread Peter Maydell
The aCC array in fpopcode.c is completely unused in QEMU; delete it (silencing a clang warning). Signed-off-by: Peter Maydell --- linux-user/arm/nwfpe/fpopcode.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/linux-user/arm/nwfpe/fpopcode.c b/linux-user/arm/nwfpe/fpop

[Qemu-devel] [PATCH 6/6] linux-user/signal.c: Remove unnecessary wrapper copy_siginfo_to_user

2015-01-08 Thread Peter Maydell
The function copy_siginfo_to_user() just calls tswap_siginfo(), so call the latter function directly and delete the wrapper function. The wrapper is actually misleading since it implies that the semantics are like the kernel function with the same name which copies the data to a guest user-space ad

[Qemu-devel] [PATCH 4/6] linux-user/main.c: Call cpu_exec_start/end on all target archs

2015-01-08 Thread Peter Maydell
The start_exclusive() infrastructure is used on all target architectures, even if only to do the "stop all CPUs before dumping core" in force_sig(), so be consistent and call cpu_exec_start/end in the main loop of every target. Signed-off-by: Peter Maydell --- linux-user/main.c | 18

[Qemu-devel] [PATCH 1/6] linux-user/signal.c: Remove current_exec_domain_sig()

2015-01-08 Thread Peter Maydell
Remove the function current_exec_domain_sig(), which always returns its argument. This was intended as a stub for supporting the kernel's exec_domain handling, but: * we don't have any of the other code for execution domains * in the kernel this handling is architecture-specific, not generic * w

Re: [Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-08 Thread Claudio Fontana
On 08.01.2015 11:31, Peter Maydell wrote: > On 7 January 2015 at 15:52, Claudio Fontana > wrote: >> Interrupt map does not seem to work for me; incidentally this ends up being >> the same kind of undocumented blob that Alvise posted in his series. Can >> you add a good comment about what the rang

Re: [Qemu-devel] [PATCH v2] vfio-pci: Fix BAR size overflow

2015-01-08 Thread Alexey Kardashevskiy
On 01/08/2015 04:23 AM, Alex Williamson wrote: > We use an unsigned int when working with the PCI BAR size, which can > obviously overflow if the BAR is 4GB or larger. This needs to change > to a fixed length uint64_t. A similar issue is possible, though even > more unlikely, when mapping the reg

[Qemu-devel] [PATCH 2/6] linux-user/alpha: Add define for NR_shmat to enable shmat syscall

2015-01-08 Thread Peter Maydell
For historical reasons, the define for the shmat() syscall on Alpha is NR_osf_shmat; however it has the same semantics as this syscall does on all other architectures, so define TARGET_NR_shmat as well so that QEMU's code for the syscall is enabled. This patch brings our behaviour on the LTP shmat

Re: [Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-08 Thread Claudio Fontana
(added cc: Alvise which I mistakenly assumed was in Cc: already) On 07.01.2015 22:47, Alexander Graf wrote: > > > On 07.01.15 16:52, Claudio Fontana wrote: >> On 06.01.2015 17:03, Alexander Graf wrote: >>> Now that we have a working "generic" PCIe host bridge driver, we can plug >>> it into ARMs

Re: [Qemu-devel] [PATCH v2 0/6] aio: Support epoll by introducing qemu_poll abstraction

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 03:53, Fam Zheng wrote: >>> > > 1) Remove 1ns PR_SET_TIMERSLACK in timerfd+epoll, this doesn't make >>> > > qemu_poll >>> > > faster than the old qemu_poll_ns, but may have other positive effects >>> > > that >>> > > compensate the cost. >> > >> > Sounds like a random hack. What

[Qemu-devel] [PULL v2 1/7] memory: add memory_region_set_size

2015-01-08 Thread Michael S. Tsirkin
Add API to change MR size. Will be used internally for RAM resize. Signed-off-by: Michael S. Tsirkin Reviewed-by: Paolo Bonzini --- include/exec/memory.h | 10 ++ memory.c | 16 2 files changed, 26 insertions(+) diff --git a/include/exec/memory.h b/include

[Qemu-devel] [PULL v2 2/7] exec: cpu_physical_memory_set/clear_dirty_range

2015-01-08 Thread Michael S. Tsirkin
Make cpu_physical_memory_set/clear_dirty_range behave symmetrically. To clear range for a given client type only, add cpu_physical_memory_clear_dirty_range_type. Signed-off-by: Michael S. Tsirkin Reviewed-by: Paolo Bonzini --- include/exec/ram_addr.h | 15 --- exec.c

[Qemu-devel] [PULL v2 0/7] pc: resizeable ROM blocks

2015-01-08 Thread Michael S. Tsirkin
Changes from v1: - squashed two patches, as suggested by Paolo - comment fixup suggested by Paolo - added acks by Paolo The following changes since commit d86fb03469e016af4e54f04efccbc20a8afa3e19: Merge remote-tracking branch 'remotes/spice/tags/pull-spice-20141216-1' into staging

[Qemu-devel] [PULL v2 3/7] exec: split length -> used_length/max_length

2015-01-08 Thread Michael S. Tsirkin
This patch allows us to distinguish between two length values for each block: max_length - length of memory block that was allocated used_length - length of block used by QEMU/guest Currently, we set used_length - max_length, unconditionally. Follow-up patches allow used_length <= max_leng

[Qemu-devel] [PULL v2 4/7] exec: qemu_ram_alloc_resizeable, qemu_ram_resize

2015-01-08 Thread Michael S. Tsirkin
Add API to allocate "resizeable" RAM. This looks just like regular RAM generally, but has a special property that only a portion of it (used_length) is actually used, and migrated. This used_length size can change across reboots. Follow up patches will change used_length for such blocks at migrat

[Qemu-devel] [PULL v2 6/7] memory: API to allocate resizeable RAM MR

2015-01-08 Thread Michael S. Tsirkin
Add API to allocate resizeable RAM MR. This looks just like regular RAM generally, but has a special property that only a portion of it (used_length) is actually used, and migrated. This used_length size can change across reboots. Follow up patches will change used_length for such blocks at migr

[Qemu-devel] [PULL v2 5/7] arch_init: support resizing on incoming migration

2015-01-08 Thread Michael S. Tsirkin
If block used_length does not match, try to resize it. Signed-off-by: Michael S. Tsirkin Reviewed-by: Paolo Bonzini --- arch_init.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/arch_init.c b/arch_init.c index 106f46e..cfedbf0 100644 --- a/arch_init.c +++ b/a

Re: [Qemu-devel] [PATCH RESEND v2 0/3] vl: smp_parse sanity checks

2015-01-08 Thread Eduardo Habkost
On Thu, Jan 08, 2015 at 11:48:30AM +0100, Paolo Bonzini wrote: > > > On 19/12/2014 03:59, Eduardo Habkost wrote: > > From the original series sent by Andrew, only patch 1/3 was kept. Patch 2/3 > > from v1 was replaced by a safer fix. Patch 3/3 was removed because it > > generates > > a warning e

Re: [Qemu-devel] [Qemu-stable] 2.1 unexpected stop after exporting blockdev via nbd server

2015-01-08 Thread Stefan Hajnoczi
On Thu, Jan 8, 2015 at 12:11 PM, Paolo Bonzini wrote: > On 08/01/2015 11:31, Stefan Hajnoczi wrote: >> Excellent, please add the following commits to stable: >> f214928 nbd: Follow the BDS' AIO context >> 3338442 block: Add AIO context notifiers >> 958c717 nbd: Drop nbd_can_read() >> >> They preve

Re: [Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-08 Thread Alexander Graf
On 08.01.15 13:55, Claudio Fontana wrote: > (added cc: Alvise which I mistakenly assumed was in Cc: already) He was in CC :). Now he's there twice. > > On 07.01.2015 22:47, Alexander Graf wrote: >> >> >> On 07.01.15 16:52, Claudio Fontana wrote: >>> On 06.01.2015 17:03, Alexander Graf wrote: >

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-08 Thread Peter Maydell
On 6 January 2015 at 13:29, Marcel Apfelbaum wrote: > Patch e79d5a6 ("machine: remove qemu_machine_opts global list") removed option > descriptions from the -machine QemuOptsList to avoid repeating MachineState's > QOM properties. > > This resulted in a Qemu crash: > $ qemu-system-x86_64 -usb > q

Re: [Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-08 Thread alvise rigo
On Thu, Jan 8, 2015 at 1:55 PM, Claudio Fontana wrote: > (added cc: Alvise which I mistakenly assumed was in Cc: already) > > On 07.01.2015 22:47, Alexander Graf wrote: >> >> >> On 07.01.15 16:52, Claudio Fontana wrote: >>> On 06.01.2015 17:03, Alexander Graf wrote: Now that we have a working

[Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-01-08 Thread Gerhard Wiesinger
Hello, After upgrading my KVM environment from Fedora 20 to Fedora 21 up2date (hosts and guests, Intel CPU) I've the following problem: 1.) On the database VM PostgresSQL e.g. 2 processes hang with 100% cpu 2.) On the monitoring VM Munin/RRDtool also hangs with 100% cpu Killing of processes is

Re: [Qemu-devel] the need for if=none for -drive?

2015-01-08 Thread Stefan Hajnoczi
On Wed, Dec 17, 2014 at 11:52 AM, Markus Armbruster wrote: > Sorry for the slow reply, I missed this one until now. Adding block > maintainers. > > John Snow writes: > >> On 11/02/2014 02:21 AM, Michael Tokarev wrote: >>> All "modern" 2-way drive/device specifications need to explicitly >>> spec

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-08 Thread Javier Celaya
Sure, for the help text of the image-compression option, thanks. El Jueves, 8 de enero de 2015 12:48:57 Fabio Fantoni escribió: > Il 08/01/2015 11:50, Javier Celaya ha scritto: > > Hello > > > > Recently, SPICE included the lz4 compression algorithm. This patch adds > > a command line option to s

[Qemu-devel] [PATCH] NVMe: Set correct VS Value for 1.1 Compliant Controllers

2015-01-08 Thread Anubhav Rakshit
According to NVMe specifications Bits 15:08 represent Minor Version number. Signed-off-by: Anubhav Rakshit --- hw/block/nvme.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index aa1ed98..26e69a7 100644 --- a/hw/block/nvme.c +++ b/hw

[Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-08 Thread Javier Celaya
Hello Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not exist before the commit that added this compression algorithm, so it should be guarded with conditional compilation. How do you think this s

Re: [Qemu-devel] [PATCH] Makefile: Remove config.status and common.env during 'make distclean'

2015-01-08 Thread Thomas Huth
On Mon, 15 Dec 2014 11:19:46 +0100 Thomas Huth wrote: > config.status and tests/qemu-iotests/common.env are generated files > that should be deleted during 'make distclean'. > > Signed-off-by: Thomas Huth > --- > Makefile |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > dif

[Qemu-devel] [Bug 1354167] Re: On VM restart: Could not open 'poppy.qcow2': Could not read snapshots: File too large

2015-01-08 Thread Steve Fox
I'll just add that the work-around worked for me too, but in addition I used the Trusty qemu-img to convert it back from RAW to QCOW2 and it was fine. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/135

[Qemu-devel] [PATCH 1/1] qemu-img: Add --pkgversion common option

2015-01-08 Thread Don Slutz
This will output the QEMU_PKGVERSION which is set by configure's --with-pkgversion= Signed-off-by: Don Slutz --- qemu-img.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/qemu-img.c b/qemu-img.c index 7876258..f73bea6 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3064,6 +3064,17

Re: [Qemu-devel] [PATCH 1/1] qemu-img: Add --pkgversion common option

2015-01-08 Thread Peter Maydell
On 8 January 2015 at 14:30, Don Slutz wrote: > This will output the QEMU_PKGVERSION which is set by configure's > --with-pkgversion= > +/* Report pkgversion */ > +if (!strcmp(cmdname, "--pkgversion")) { > +argc--; argv++; /* Drop special arg. */ > +printf("qemu-img version

[Qemu-devel] [PULL v2 7/7] acpi-build: make ROMs RAM blocks resizeable

2015-01-08 Thread Michael S. Tsirkin
Use resizeable ram API so we can painlessly extend ROMs in the future. Note: migration is not affected, as we are not actually changing the used length for RAM, which is the part that's migrated. Use this in acpi: reserve x16 more RAM space. Signed-off-by: Michael S. Tsirkin Reviewed-by: Paolo

Re: [Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-08 Thread Claudio Fontana
On 08.01.2015 14:26, Alexander Graf wrote: > > > On 08.01.15 13:55, Claudio Fontana wrote: >> (added cc: Alvise which I mistakenly assumed was in Cc: already) > > He was in CC :). Now he's there twice. > >> >> On 07.01.2015 22:47, Alexander Graf wrote: >>> >>> >>> On 07.01.15 16:52, Claudio Fon

Re: [Qemu-devel] [PULL 09/10] monitor: add query-vnc2 command

2015-01-08 Thread Gerd Hoffmann
On Fr, 2014-12-19 at 14:04 +0100, Markus Armbruster wrote: > Gerd Hoffmann writes: > > > Add new query vnc qmp command, for the lack of better ideas just name it > > "query-vnc2". Changes over query-vnc: > > > > * It returns a list of vnc servers, so multiple vnc server instances > >are cov

Re: [Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature

2015-01-08 Thread Keith Busch
On Wed, 7 Jan 2015, Stefan Hajnoczi wrote: On Fri, Dec 05, 2014 at 02:40:24PM +0200, a...@e8storage.com wrote: From: Alex Friedman According to the specification, the low 16 bits should contain the number of I/O submission queues, and the high 16 bits should contain the number of I/O completio

[Qemu-devel] [PATCH] qemu_opt_get_bool_helper: Fix option handling

2015-01-08 Thread Michal Privoznik
Well, after 49d2e648e8087 the options to -machine parameter no longer has .desc nor .desc->type. That's mainly because the options are dynamically added while .desc is allocated statically. Anyway, if user tries to run: qemu-system-x86_64 -machine pc-i440fx-2.2,accel=kvm,usb=off the arguments

Re: [Qemu-devel] [PATCH 00/15] AHCI test helper refactors

2015-01-08 Thread John Snow
On 09/18/2014 07:43 PM, John Snow wrote: The original version of the AHCI test base which is now staged for being merged, processes the ahci_identify test in a monolithic fashion. In authoring new tests, it became necessary and obvious as to how the operation of this device should be factored

[Qemu-devel] goal of tb_lock in cpu-exec?

2015-01-08 Thread Frederic Konrad
Hi everybody and happy new year, I wondered what is the goal of tb_lock in cpu-exec.c. According to the exec-all.h it's to protect tbs and page table but why do we have to cover the whole cpu_exec function? I'm asking this because we planned to reuse tb_lock to protect every access to tb_ctx

Re: [Qemu-devel] Qemu on the Android platform

2015-01-08 Thread Apps Embedded
Hi, Thanks for your answer. Best regards. Apps Embedded Team. 2015-01-01 17:32 GMT+01:00 Andreas Färber : > Hi, > > Am 18.12.2014 um 15:20 schrieb Apps Embedded: > > We would like to know if one is able to compile and run the qemu > > binaries on the Android platform, would it be possible to cr

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 14:27, Peter Maydell wrote: > So does this mean that we still have other broken options? Do we > have a timescale for fixing them? I was hoping to be able to commit > a patchset fixing these regressions this week; if we can't do that > then we should probably revert the original cha

Re: [Qemu-devel] [PATCH RESEND v2 0/3] vl: smp_parse sanity checks

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 14:22, Eduardo Habkost wrote: > Yes, please. > > I believe 2/3 doesn't need to be in the release notes as it is just a > bug fix which shouldn't break existing setups. 3/3 will make QEMU abort > in (rare?) cases where the command-line was already visibly broken, so I > will documen

Re: [Qemu-devel] [PATCH] qemu_opt_get_bool_helper: Fix option handling

2015-01-08 Thread Eric Blake
On 01/08/2015 09:09 AM, Michal Privoznik wrote: > Well, after 49d2e648e8087 the options to -machine parameter no longer > has .desc nor .desc->type. That's mainly because the options are > dynamically added while .desc is allocated statically. Anyway, if user > tries to run: > >qemu-system-x86

Re: [Qemu-devel] [PATCH] qemu_opt_get_bool_helper: Fix option handling

2015-01-08 Thread Marcel Apfelbaum
On 01/08/2015 06:09 PM, Michal Privoznik wrote: Well, after 49d2e648e8087 the options to -machine parameter no longer has .desc nor .desc->type. That's mainly because the options are dynamically added while .desc is allocated statically. Anyway, if user tries to run: qemu-system-x86_64 -mach

Re: [Qemu-devel] [PATCH 1/1] qemu-img: Add --pkgversion common option

2015-01-08 Thread Eric Blake
On 01/08/2015 07:40 AM, Peter Maydell wrote: > On 8 January 2015 at 14:30, Don Slutz wrote: >> This will output the QEMU_PKGVERSION which is set by configure's >> --with-pkgversion= > >> +/* Report pkgversion */ >> +if (!strcmp(cmdname, "--pkgversion")) { >> +argc--; argv++; /* Dr

[Qemu-devel] [PATCH 0/2] target-s390x: fixes for GMP testsuite

2015-01-08 Thread Paolo Bonzini
Reported and tested by Torbjorn. One patch is mine, one is his. Paolo Bonzini (1): target-s390x: support OC and NC in the EX instruction Torbjorn Granlund (1): target-s390x: fix and optimize slb* and slbg* computation of carry/borrow flag target-s390x/cc_helper.c | 18

[Qemu-devel] [PATCH 1/2] target-s390x: support OC and NC in the EX instruction

2015-01-08 Thread Paolo Bonzini
This is needed to run the GMP testsuite. Reported-by: Torbjorn Granlund Tested-by: Torbjorn Granlund Signed-off-by: Paolo Bonzini --- target-s390x/mem_helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-s390x/mem_helper.c b/target-s390x/mem_helper.c index 5a55de8..4de3f

[Qemu-devel] [PATCH 2/2] target-s390x: fix and optimize slb* and slbg* computation of carry/borrow flag

2015-01-08 Thread Paolo Bonzini
From: Torbjorn Granlund This patch fixes the bug with borrow_in being set incorrectly, but it also simplifies the logic to be much more plain, improving speed. It fixes both the 32-bit SLB* and 64-bit SLBG*. The SLBG* change has been well-tested. I haven't tested the SLB* change explicitly, bu

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-08 Thread Programmingkid
On Jan 8, 2015, at 4:02 AM, Gerd Hoffmann wrote: > Hi, > >> VGA: Using shared surface for depth=32 swap=1 > > Ok, 32bpp. byteswapping needed. > > I guess the host is a intel macintosh then? Yes. I unfortunately don't have a fast enough PowerPC Mac to handle QEMU. It would be interesting to

Re: [Qemu-devel] [PATCH] qemu_opt_get_bool_helper: Fix option handling

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 17:09, Michal Privoznik wrote: > diff --git a/util/qemu-option.c b/util/qemu-option.c > index a708241..478420f 100644 > --- a/util/qemu-option.c > +++ b/util/qemu-option.c > @@ -384,7 +384,6 @@ static bool qemu_opt_get_bool_helper(QemuOpts *opts, > const char *name, > } >

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 14:36, Gerhard Wiesinger wrote: > Quitting and reattaching gdb also hangs here, so gettimeofday takes 100% > CPU and never ends! > > Therefore I guess this is a problem either in the Linux kernel or in > QEMU/KVM. What kernel are you running on (and were you running on)? Can you

Re: [Qemu-devel] [PATCH] Makefile: Remove config.status and common.env during 'make distclean'

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 13:22, Thomas Huth wrote: > On Mon, 15 Dec 2014 11:19:46 +0100 > Thomas Huth wrote: > >> config.status and tests/qemu-iotests/common.env are generated files >> that should be deleted during 'make distclean'. >> >> Signed-off-by: Thomas Huth >> --- >> Makefile |4 ++-- >> 1 f

[Qemu-devel] [PATCH 04/88] xhci PCIe endpoint migration compatibility fix

2015-01-08 Thread Michael Roth
From: "Dr. David Alan Gilbert" Add back the PCIe config capabilities on XHCI cards in non-PCIe slots, but only for machine types before 2.1. This fixes a migration incompatibility in the XHCI PCI devices caused by: 058fdcf52cdbf57b67e7 - xhci: add endpoint cap on express bus only Note that i

[Qemu-devel] [PATCH 02/88] qdev: Add cleanup logic in device_set_realized() to avoid resource leak

2015-01-08 Thread Michael Roth
From: Gonglei At present, this function doesn't have partial cleanup implemented, which will cause resource leaks in some scenarios. Example: 1. Assume that "dc->realize(dev, &local_err)" executes successful and local_err == NULL; 2. device hotplug in hotplug_handler_plug() executes but fail

[Qemu-devel] [PATCH 08/88] kvmclock: Add comment explaining why we need cpu_clean_all_dirty()

2015-01-08 Thread Michael Roth
From: Eduardo Habkost Try to explain why commit 317b0a6d8ba44e9bf8f9c3dbd776c4536843d82c needed a cpu_clean_all_dirty() call just after calling cpu_synchronize_all_states(). Signed-off-by: Eduardo Habkost Cc: Andrey Korolyov Cc: Marcin Gibuła Cc: Marcelo Tosatti Cc: Paolo Bonzini Signed-of

[Qemu-devel] Patch Round-up for stable 2.1.3, freeze on 2015-01-14

2015-01-08 Thread Michael Roth
Hi everyone, The following new patches are queued for QEMU stable v2.1.3: https://github.com/mdroth/qemu/commits/stable-2.1-staging The release is planned for 2015-01-21: http://wiki.qemu.org/Planning/2.1 Please respond here or CC qemu-sta...@nongnu.org on any patches you think should be i

[Qemu-devel] [PATCH 03/88] exec: file_ram_alloc(): print error when prealloc fails

2015-01-08 Thread Michael Roth
From: Luiz Capitulino If memory allocation fails when using the -mem-prealloc command-line option, QEMU exits without printing any error information to the user: # qemu [...] -m 1G -mem-prealloc -mem-path /dev/hugepages # echo $? 1 This commit adds an error message, so that we print instead:

[Qemu-devel] [PATCH 01/88] qdev: Use NULL instead of local_err for qbus_child unrealize

2015-01-08 Thread Michael Roth
From: Gonglei Forcefully unrealize all children regardless of errors in earlier iterations (if any). We should keep going with cleanup operation rather than report an error immediately. Therefore store the first child unrealization failure and propagate it at the end. We also forcefully unregiste

[Qemu-devel] [PATCH 15/88] qapi: dealloc visitor, implement visit_start_union

2015-01-08 Thread Michael Roth
If the .data field of a QAPI Union is NULL, we don't need to free any of the union fields. Make use of the new visit_start_union interface to access this information and instruct the generated code to not visit these fields when this occurs. Cc: qemu-sta...@nongnu.org Reported-by: Fam Zheng Sugg

[Qemu-devel] [PATCH 13/88] gdbstub: init mon_chr through qemu_chr_alloc

2015-01-08 Thread Michael Roth
From: Pavel Dovgalyuk This patch initializes monitor for gdbstub with the qemu_chr_alloc function instead of just allocating the memory. Initialization function call is required, because it also creates chr_write_lock mutex, which is used when writing to this character device. Signed-off-by: Pav

[Qemu-devel] [PATCH 10/88] virtio-pci: enable bus master for old guests

2015-01-08 Thread Michael Roth
From: "Michael S. Tsirkin" commit cc943c36faa192cd4b32af8fe5edb31894017d35 pci: Use bus master address space for delivering MSI/MSI-X messages breaks virtio-net for rhel6.[56] x86 guests because they don't enable bus mastering for virtio PCI devices. For the same reason, rhel6.[56] ppc64 gues

[Qemu-devel] [PATCH 24/88] ivshmem: Fix fd leak on error

2015-01-08 Thread Michael Roth
From: Andreas Färber Reported-by: Stefan Hajnoczi Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber Reviewed-by: Michael S. Tsirkin Signed-off-by: Paolo Bonzini (cherry picked from commit 3a31cff11203bf62ebafa6d74b1fcf2aba345eed) Signed-off-by: Michael Roth --- hw/misc/ivshmem.c | 1

[Qemu-devel] [PATCH 11/88] spapr_pci: map the MSI window in each PHB

2015-01-08 Thread Michael Roth
From: Greg Kurz On sPAPR, virtio devices are connected to the PCI bus and use MSI-X. Commit cc943c36faa192cd4b32af8fe5edb31894017d35 has modified MSI-X so that writes are made using the bus master address space and follow the IOMMU path. Unfortunately, the IOMMU address space address space does

[Qemu-devel] [PATCH 18/88] monitor: Reset HMP mon->rs in CHR_EVENT_OPEN

2015-01-08 Thread Michael Roth
From: Stratos Psomadakis Commit cdaa86a54 ("Add G_IO_HUP handler for socket chardev") exposed a bug in the way the HMP monitor handles its command buffer. When a client closes the connection to the monitor, tcp_chr_read() will detect the G_IO_HUP condition and call tcp_chr_disconnect() to close t

[Qemu-devel] [PATCH 05/88] Introduce cpu_clean_all_dirty

2015-01-08 Thread Michael Roth
From: Marcelo Tosatti Introduce cpu_clean_all_dirty, to force subsequent cpu_synchronize_all_states to read in-kernel register state. Cc: qemu-sta...@nongnu.org Signed-off-by: Marcelo Tosatti Signed-off-by: Paolo Bonzini (cherry picked from commit de9d61e83d43be9069e6646fa9d57a3f47779d28) Conf

[Qemu-devel] [PATCH 33/88] virtio/vhost-scsi: fix virtio-scsi/vhost-scsi child refcount in transports

2015-01-08 Thread Michael Roth
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon hot unplug the virtio-scsi/vhost-scsi child is not fi

[Qemu-devel] [PATCH 16/88] tests: add QMP input visitor test for unions with no discriminator

2015-01-08 Thread Michael Roth
This is more of an exercise of the dealloc visitor, where it may erroneously use an uninitialized discriminator field as indication that union fields corresponding to that discriminator field/type are present, which can lead to attempts to free random chunks of heap memory. Cc: qemu-sta...@nongnu.

[Qemu-devel] [PATCH 09/88] pci: Use bus master address space for delivering MSI/MSI-X messages

2015-01-08 Thread Michael Roth
From: Jan Kiszka The spec says (and real HW confirms this) that, if the bus master bit is 0, the device will not generate any PCI accesses. MSI and MSI-X messages fall among these, so we should use the corresponding address space to deliver them. This will prevent delivery if bus master support i

[Qemu-devel] [PATCH 27/88] snapshot: fix referencing wrong variable in while loop in do_delvm

2015-01-08 Thread Michael Roth
From: Zhang Haoyu The while loop variabal is "bs1", but "bs" is always passed to bdrv_snapshot_delete_by_id_or_name. Broken in commit a89d89d, v1.7.0. Signed-off-by: Zhang Haoyu Reviewed-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi (cherry picked from commit af957387547b05ed6dc4d84c10

[Qemu-devel] [PATCH 20/88] vhost-user: fix VIRTIO_NET_F_MRG_RXBUF negotiation

2015-01-08 Thread Michael Roth
From: Damjan Marion Header length check should happen only if backend is kernel. For user backend there is no reason to reset this bit. vhost-user code does not define .has_vnet_hdr_len so VIRTIO_NET_F_MRG_RXBUF cannot be negotiated even if both sides support it. Signed-off-by: Damjan Marion R

  1   2   3   >