Well, after 49d2e648e8087 the options to -machine parameter no longer has .desc nor .desc->type. That's mainly because the options are dynamically added while .desc is allocated statically. Anyway, if user tries to run:
qemu-system-x86_64 -machine pc-i440fx-2.2,accel=kvm,usb=off the arguments evaluation fails with: qemu_opt_get_bool_helper: Assertion `opt->desc && opt->desc->type == QEMU_OPT_BOOL' failed. Fix this by dropping the assert() which is useless after the mentioned commit anyway. Signed-off-by: Michal Privoznik <[email protected]> --- util/qemu-option.c | 1 - 1 file changed, 1 deletion(-) diff --git a/util/qemu-option.c b/util/qemu-option.c index a708241..478420f 100644 --- a/util/qemu-option.c +++ b/util/qemu-option.c @@ -384,7 +384,6 @@ static bool qemu_opt_get_bool_helper(QemuOpts *opts, const char *name, } return ret; } - assert(opt->desc && opt->desc->type == QEMU_OPT_BOOL); ret = opt->value.boolean; if (del) { qemu_opt_del_all(opts, name); -- 2.0.5
