On 09/18/2014 07:43 PM, John Snow wrote:
The original version of the AHCI test base which is now staged for being merged, processes the ahci_identify test in a monolithic fashion. In authoring new tests, it became necessary and obvious as to how the operation of this device should be factored out to ease the writing of new AHCI tests. This patch set issues the necessary refactorings to support future test development for AHCI. This patch set DOES NOT account for any new fixes and requires no fixes from my "AHCI fixes" RFC in order to run successfully on 2014-09-18's origin/master. This patch set does not alter the operation of the existing test, or add new tests. It only offers refactorings for future patch submissions which depend on them, but are still under consideration. John Snow (15): qtest/ahci: Add AHCIState structure qtest/ahci: Add port_select helper qtest/ahci: Add port_clear helper qtest/ahci: Add command header helpers qtest/ahci: Add build cmd table helper qtest/ahci: Add link_cmd_slot helper qtest/ahci: Add port_check_error helper qtest/ahci: Add issue_command helper qtest/ahci: Add port_check_interrupts helper qtest/ahci: Add port_check_nonbusy helper qtest/ahci: Add cmd response sanity check helpers qtest/ahci: Enforce zero-leaks for guest mem usage qtest/ahci: Add a macro bootup routine qtest/ahci: Add human-readable command names qtest/ahci: Don't use a magic constant for buffer size tests/ahci-test.c | 860 ++++++++++++++++++++++++++++++++++++------------------ 1 file changed, 583 insertions(+), 277 deletions(-)
NACKing my own patchset here because I am preparing a V2 and it is not worth anyone's time to review this version at this point in time.
--js
