Tested qemu-utils 2.0.0+dfsg-2ubuntu1.8. Successful.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1368815
Title:
qemu-img convert intermittently corrupts output images
Status in OpenStack Comput
** Tags removed: verification-needed
** Tags added: verification-done-trusty
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1368815
Title:
qemu-img convert intermittently corrupts output images
Sta
The 1st patch fixes batch submission.
The 2nd one fixes -EAGAIN for non-batch case.
The 3rd one is a cleanup.
This patchset is splitted from previous patchset(dataplane: optimization
and multi virtqueue support), as suggested by Stefan.
V7:
- add protection for aborting in laio_attach_a
In the submit path, we can't complete request directly,
otherwise "Co-routine re-entered recursively" may be caused,
so this patch fixes the issue with below ideas:
- for -EAGAIN or partial submission, retry the submision
in following completion cb which is run in BH context
No one uses the 'node' field any more, so remove it
from 'struct qemu_laiocb', and this can save 16byte
for the struct on 64bit arch.
Reviewed-by: Kevin Wolf
Reviewed-by: Paolo Bonzini
Signed-off-by: Ming Lei
---
block/linux-aio.c |1 -
1 file changed, 1 deletion(-)
diff --git a/block/lin
Previously -EAGAIN is simply ignored for !s->io_q.plugged case,
and sometimes it is easy to cause -EIO to VM, such as NVME device.
This patch handles -EAGAIN by io queue for !s->io_q.plugged case,
and it will be retried in following aio completion cb.
Most of times, -EAGAIN only happens if there
On Fri, Nov 28, 2014 at 05:26:29PM +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> Signed-off-by: Gonglei
Peter, could you pick this up for 2.2 please?
Reviewed-by: Michael S. Tsirkin
> ---
> hw/scsi/vhost-scsi.c | 1 +
> hw/virtio/vhost.c| 2 ++
> 2 files changed, 3 insertio
On 28/11/2014 03:38, Gonglei wrote:
>> > Can you find what line of kernel/sched.c it is?
> Yes, of course. See below please:
> "sgs->avg_load = (sgs->group_load * SCHED_LOAD_SCALE) / group->cpu_power; "
> in update_sg_lb_stats(), file sched.c, line 4094
> And I can share the cause of we found. Af
From: Vasileios Kalintiris
Sent: 25 November 2014 11:04
To: qemu-devel@nongnu.org
Cc: Leon Alrae; aurel...@aurel32.net
Subject: [PATCH] target-mips: add CPU definition for MIPS-II
Add mips2-generic among CPU definitions for MIPS.
Signed-off-by: Vasileios
On Mon, Dec 1, 2014 at 9:40 AM, Halsey Pian wrote:
Please keep qemu-devel@nongnu.org CCed so the discussion stays on the
mailing list. I have added it back.
> Hi Stefan, not know if there is similar module, currently I have not seen it.
> If yes, please forgive me. And for the program if it
>
On 28 Nov 2014, at 09:03, Stefan Weil wrote:
> This is my build script:
> http://qemu.weilnetz.de/results/make-installers-all.
we finally have a functional windows version, installed with a setup, as you
recommended.
the build procedure was fully documented at:
http://gnuarmeclipse.livius.ne
On Fri, Nov 28, 2014 at 04:28:57PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 21.11.2014 19:55, Stefan Hajnoczi wrote:
> >Active dirty bitmaps should migrate too. I'm thinking now that the
> >appropriate thing is to add live migration of dirty bitmaps to QEMU
> >(regardless of whether they ar
On Fri, Nov 28, 2014 at 01:19:59PM +0100, Kevin Wolf wrote:
> Am 28.11.2014 um 12:49 hat Stefan Hajnoczi geschrieben:
> > On Wed, Nov 26, 2014 at 03:46:42PM +0100, Kevin Wolf wrote:
> > > +while (data.n > 0) {
> > > +main_loop_wait(false);
> > > +}
> >
> > Why is this false (non-bl
On Fri, Nov 28, 2014 at 02:41:54PM +0100, Markus Armbruster wrote:
> Stefan Hajnoczi writes:
>
> > On Wed, Nov 26, 2014 at 03:01:02PM +0100, Paolo Bonzini wrote:
> >> Use the external qemu-timer API instead.
> >>
> >> Cc: kw...@redhat.com
> >> Cc: stefa...@redhat.com
> >> Signed-off-by: Paolo Bo
On 30 November 2014 at 16:43, Michael S. Tsirkin wrote:
> The result of this is host mapping leak.
> What effect does this have? Can this DOS host?
I don't think we can DOS the host here.
If Xen, we crash (but you can't use virtio-blk with Xen anyway)
Otherwise, if you managed to get address_spa
On Mon, Dec 01, 2014 at 12:07:07PM +, Peter Maydell wrote:
> On 30 November 2014 at 16:43, Michael S. Tsirkin wrote:
> > The result of this is host mapping leak.
> > What effect does this have? Can this DOS host?
>
> I don't think we can DOS the host here.
>
> If Xen, we crash (but you can't
On 01/12/2014 02:28, Ming Lei wrote:
>> > - (unsigned long)(10 * duration) / maxcycles);
>> > + (unsigned long)(10.0 * duration / maxcycles));
> One more single bracket.
I don't understand?
Paolo
Stefan Hajnoczi writes:
> On Fri, Nov 28, 2014 at 02:41:54PM +0100, Markus Armbruster wrote:
>> Stefan Hajnoczi writes:
>>
>> > On Wed, Nov 26, 2014 at 03:01:02PM +0100, Paolo Bonzini wrote:
>> >> Use the external qemu-timer API instead.
>> >>
>> >> Cc: kw...@redhat.com
>> >> Cc: stefa...@redh
Still happening with latest upstream kernel. It seems to involve using
the -initrd option at all, with any cpio file, even a tiny one. More
results posted here:
https://lists.cs.columbia.edu/pipermail/kvmarm/2014-December/012557.html
--
You received this bug notification because you are a memb
On Mon, 24 Nov 2014, Leon Alrae wrote:
> All the patches up to this one have been applied to mips-next branch
> (available at git://github.com/lalrae/qemu.git), thanks. I'll go through
> the remaining soon.
Thanks. I am now back from a week's vacation and will continue posting
outstanding chan
On 1 December 2014 at 09:37, Michael S. Tsirkin wrote:
> On Fri, Nov 28, 2014 at 05:26:29PM +0800, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> Signed-off-by: Gonglei
>
> Peter, could you pick this up for 2.2 please?
>
> Reviewed-by: Michael S. Tsirkin
Applied, thanks.
-- PMM
On 11/27/14 05:48, Stefano Stabellini wrote:
On Wed, 26 Nov 2014, Don Slutz wrote:
On 11/26/14 13:17, Stefano Stabellini wrote:
On Tue, 25 Nov 2014, Andrew Cooper wrote:
On 25/11/14 17:45, Stefano Stabellini wrote:
Increase maxmem before calling xc_domain_populate_physmap_exact to avoid
the r
On Thu, Nov 27, 2014 at 05:42:41PM +0100, Paolo Bonzini wrote:
>
>
> On 27/11/2014 13:29, Stefan Hajnoczi wrote:
> > +void bitmap_set_atomic(unsigned long *map, long start, long nr)
> > +{
> > +unsigned long *p = map + BIT_WORD(start);
> > +const long size = start + nr;
> > +int bits_
On my latest test with xen 4.5 and qemu 2.2 (from git) linux hvm domU
(Fedora 21) has no more crashed without any useful information in log
but was crashed only xorg on start:
[20.653] (EE)
[20.653] (EE) Backtrace:
[20.668] (EE) 0: /usr/libexec/Xorg.bin (OsLookupColor+0x119)
[0x59
On Thu, Nov 27, 2014 at 05:43:56PM +0100, Paolo Bonzini wrote:
>
>
> On 27/11/2014 13:29, Stefan Hajnoczi wrote:
> > +bool bitmap_test_and_clear_atomic(unsigned long *map, long start, long nr)
> > +{
> > +unsigned long *p = map + BIT_WORD(start);
> > +const long size = start + nr;
> > +
On 24/11/2014 17:15, Stefan Hajnoczi wrote:
> The QEMU Advent Calendar is launching on December 1st 2014:
>
> http://www.qemu-advent-calendar.org/
>
> Each day until Christmas (or until we run out) a new QEMU disk image
> will be posted for you to enjoy.
>
> The disk images showcase interesting
On Thu, Nov 27, 2014 at 04:29:06PM +, Dr. David Alan Gilbert wrote:
> * Stefan Hajnoczi (stefa...@redhat.com) wrote:
> > The dirty memory bitmap is managed by ram_addr.h and copied to
> > migration_bitmap[] periodically during live migration.
> >
> > Move the code to sync the bitmap to ram_add
Resolves: https://bugs.launchpad.net/qemu/+bug/1383857
Signed-off-by: Richard W.M. Jones
---
hw/arm/boot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index 0014c34..a859922 100644
--- a/hw/arm/boot.c
+++ b/hw/arm/boot.c
@@ -632,11 +632,11
Hi Stefan,
Thanks for so much info you provided.
Okay, I would keep qemu-devel mailing list in the loop, no problem.
Currently, I have finished the coding of the wrapper, now testing the
bdrv_read/write qcow2 img. I would look into these libraries and incorporate
them based on the concept of
On Mon, Dec 1, 2014 at 1:57 PM, François Revol wrote:
> On 24/11/2014 17:15, Stefan Hajnoczi wrote:
>> The QEMU Advent Calendar is launching on December 1st 2014:
>>
>> http://www.qemu-advent-calendar.org/
>>
>> Each day until Christmas (or until we run out) a new QEMU disk image
>> will be posted
* Stefan Hajnoczi (stefa...@redhat.com) wrote:
> On Thu, Nov 27, 2014 at 04:29:06PM +, Dr. David Alan Gilbert wrote:
> > * Stefan Hajnoczi (stefa...@redhat.com) wrote:
> > > The dirty memory bitmap is managed by ram_addr.h and copied to
> > > migration_bitmap[] periodically during live migratio
Finally found the problem, patch posted:
https://lists.gnu.org/archive/html/qemu-devel/2014-12/msg00034.html
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1383857
Title:
aarch64: virtio disks don't
On 1 December 2014 at 14:13, Richard W.M. Jones wrote:
> Resolves: https://bugs.launchpad.net/qemu/+bug/1383857
> Signed-off-by: Richard W.M. Jones
This is really a kernel bug.
https://www.kernel.org/doc/Documentation/arm64/booting.txt
just says "The device tree blob (dtb) must be placed on an
8
On Mon, 1 Dec 2014, Don Slutz wrote:
> On 11/27/14 05:48, Stefano Stabellini wrote:
> > On Wed, 26 Nov 2014, Don Slutz wrote:
> > > On 11/26/14 13:17, Stefano Stabellini wrote:
> > > > On Tue, 25 Nov 2014, Andrew Cooper wrote:
> > > > > On 25/11/14 17:45, Stefano Stabellini wrote:
> > > > > > Incre
On 11/27/2014 07:48 AM, Max Reitz wrote:
> There are some block drivers which are essential to QEMU and may not be
> removed: These are raw, file and qcow2 (as the default non-raw format).
> Make their BlockDriver objects public so they can be directly referenced
> throughout the block layer withou
On 11/27/2014 07:48 AM, Max Reitz wrote:
> We can always assume raw, file and qcow2 being available; so do not use
> bdrv_find_format() to locate their BlockDriver objects but statically
> reference the respective objects.
>
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Max Reitz
> ---
> block.c
On 11/29/2014 03:39 AM, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> A bonus of this feature is that supporting different
> people (in different countries) using defferent keyboard
s/defferent/different/
> to connect the same guest but not need to configure
> command line or libivrt xml f
On 11/29/2014 03:39 AM, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> Example QMP command of Change VNC keyboard layout:
>
> -> { "execute": "change",
> "arguments": { "device": "vnc", "target": "keymap",
> "arg": "de" } }
> <- { "return": {} }
As I
Some guests seem to set BM for e1000 after
enabling RX.
If packets arrive in the window, device is wedged.
Probably works by luck on real hardware, work around
this by making can_receive depend on BM.
Signed-off-by: Michael S. Tsirkin
---
hw/net/e1000.c | 20 +++-
1 file changed,
Today is the first day of QEMU Advent Calendar 2014, where an
interesting and fun QEMU disk image is published every day.
http://www.qemu-advent-calendar.org/
I won't spam the mailing list every day but I wanted to let you know
that from now until Christmas we will publish a daily image for your
On Mon, Dec 01, 2014 at 06:01:18PM +, Gabriel Somlo wrote:
> Hi Michael,
>
> I had to make some small changes to get this patch to build successfully,
> see inline below:
Ouch, looks like I sent out a stale version:
git commit
build+edit
git format-patch (without git commit)
Happens to me no
Some guests seem to set BM for e1000 after
enabling RX.
If packets arrive in the window, device is wedged.
Probably works by luck on real hardware, work around
this by making can_receive depend on BM.
Tested-by: Gabriel Somlo
Signed-off-by: Michael S. Tsirkin
---
Amos - you were the one reporti
Am 01.12.2014 um 11:30 schrieb Liviu Ionescu:
>
> On 28 Nov 2014, at 09:03, Stefan Weil wrote:
>
>> This is my build script:
>> http://qemu.weilnetz.de/results/make-installers-all.
>
> we finally have a functional windows version, installed with a setup, as you
> recommended.
>
> the build pr
On 11/27/2014 04:41 AM, Max Reitz wrote:
On 2014-11-26 at 18:41, John Snow wrote:
From: Fam Zheng
The new command pair is added to manage user created dirty bitmap. The
dirty bitmap's name is mandatory and must be unique for the same device,
but different devices can have bitmaps with the sa
All - first a huge thanks for those who have contributed, and those who have
expressed an interest in helping out.
One issue I’d like to see more opinions on is the question of a cache per core,
or a shared cache.
I have heard anecdotal evidence that a shared cache gives a major performance
be
From: Fam Zheng
This allows to put the dirty bitmap into a disabled state where no more
writes will be tracked.
It will be used before backup or writing to persistent file.
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 15 +
From: Fam Zheng
This returns the granularity (in bytes) of dirty bitmap,
which matches the QMP interface and the existing query
interface.
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 9 +++--
include/block/block.h | 2 ++
2 files c
From: Fam Zheng
This field will be set for user created dirty bitmap. Also pass in an
error pointer to bdrv_create_dirty_bitmap, so when a name is already
taken on this BDS, it can report an error message. This is not global
check, two BDSes can have dirty bitmap with a common name.
Implemented
Note: This patch is now based on top of stefanha/block-next and is
intended for QEMU 2.3.
This is the in memory part of the incremental backup feature.
With the added commands, we can create a bitmap on a block backend, from which
point of time all the writes are tracked by the bitmap, marking se
From: Fam Zheng
This makes a deep copy of an HBitmap.
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
include/qemu/hbitmap.h | 8
util/hbitmap.c | 16
2 files changed, 24 insertions(+)
diff --git a/include/qemu/hbitmap.h b/incl
From: Fam Zheng
The new command pair is added to manage user created dirty bitmap. The
dirty bitmap's name is mandatory and must be unique for the same device,
but different devices can have bitmaps with the same names.
The granularity is an optional field. If it is not specified, we will
choose
From: Fam Zheng
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 1 +
qapi/block-core.json | 5 -
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 42244f6..677bc6f 100644
--- a/block.c
+++ b/block.c
@@
From: Fam Zheng
This adds three qmp commands to transactions.
Users can stop a dirty bitmap, start backup of it, and start another
dirty bitmap atomically, so that the dirty bitmap is tracked
incrementally and we don't miss any write.
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
Reviewed
From: Fam Zheng
For "dirty-bitmap" sync mode, the block job will iterate through the
given dirty bitmap to decide if a sector needs backup (backup all the
dirty clusters and skip clean ones), just as allocation conditions of
"top" sync mode.
There are two bitmap use modes for sync=dirty-bitmap:
From: Fam Zheng
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 35 +++
include/block/block.h | 4
2 files changed, 35 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index a0d1150..2d08b9
From: Fam Zheng
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
tests/qemu-iotests/056| 33 ++---
tests/qemu-iotests/056.out| 4 ++--
tests/qemu-iotests/iotests.py | 8
3 files changed, 40 insertions(+), 5 deletio
Also I've been able to reproduce this with the latest master in qemu,
and even with the latest daily 3.18-rcX kernel on the host.
** Also affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribe
On 12/01/2014 01:30 PM, John Snow wrote:
> From: Fam Zheng
>
> This field will be set for user created dirty bitmap. Also pass in an
> error pointer to bdrv_create_dirty_bitmap, so when a name is already
> taken on this BDS, it can report an error message. This is not global
> check, two BDSes ca
Mark Burton writes:
> All - first a huge thanks for those who have contributed, and those who have
> expressed an interest in helping out.
> One issue I’d like to see more opinions on is the question of a cache per
> core,
> or a shared cache.
> I have heard anecdotal evidence that a shared cach
On 11/28/2014 05:31 AM, Francesco Romani wrote:
> Managing applications, like oVirt (http://www.ovirt.org), make extensive
> use of thin-provisioned disk images.
> To let the guest run smoothly and be not unnecessarily paused, oVirt sets
> a disk usage threshold (so called 'high water mark') based
On 12/01/2014 01:30 PM, John Snow wrote:
> From: Fam Zheng
>
> The new command pair is added to manage user created dirty bitmap. The
> dirty bitmap's name is mandatory and must be unique for the same device,
> but different devices can have bitmaps with the same names.
>
> The granularity is an
Hi Michael,
I had to make some small changes to get this patch to build successfully,
see inline below:
On Monday, December 01, 2014 11:50am, Michael S. Tsirkin [m...@redhat.com]
wrote:
>
> Some guests seem to set BM for e1000 after
> enabling RX.
> If packets arrive in the window, device is we
On Thu, Nov 27, 2014 at 05:46:28PM +, Stefano Stabellini wrote:
> On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote:
> > On Nov 27, 2014 10:26 AM, Stefano Stabellini
> > wrote:
> > >
> > > On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote:
> > > > On Nov 27, 2014 9:58 AM, Stefano Stabellini
>
On 11/26/2014 01:27 PM, Bryan D. Payne wrote:
> This patch adds a new QMP command that sets up a domain socket. This
> socket can then be used for fast read/write access to the guest's
> physical memory. The key benefit to this system over existing solutions
> is speed. Using this patch, guest memo
On 11/26/2014 01:27 PM, Bryan D. Payne wrote:
> Thanks for the feedback Eric, I've updated the patch.
>
> v2 changes:
> - added QMP command contract to qapi-schema.json
> - corrected some comments
> - rewired QMP command to use schema code
When sending a v2, it's best to send it as a new top-leve
On 12/01/14 10:37, Stefano Stabellini wrote:
On Mon, 1 Dec 2014, Don Slutz wrote:
On 11/27/14 05:48, Stefano Stabellini wrote:
[...]
Works fine in both claim modes and with PoD used (maxmem > memory). Do
not know how to test with tmem. I do not see how it would be worse then
current
code
On behalf of the QEMU Team, I'd like to announce the availability of the
fifth release candidate for the QEMU 2.2 release. This release is meant
for testing purposes and should not be used in a production environment.
http://wiki.qemu.org/download/qemu-2.2.0-rc4.tar.bz2
This is the last planne
On 01.12.14 22:00, Lluís Vilanova wrote:
> Mark Burton writes:
>
>> All - first a huge thanks for those who have contributed, and those who have
>> expressed an interest in helping out.
>
>> One issue I’d like to see more opinions on is the question of a cache per
>> core,
>> or a shared cache
Adding (another) generic model for an old ISA revision is rather
discouraged in QEMU trunk. Can you add a particular real CPU model?
Regards,
Petar
From: Vasileios Kalintiris
Sent: 25 November 2014 11:04
To: address@hidden
Cc: Leon Alrae; address@
Hello.
How do I allocate a specific amount of video memory to a qemu machine?
My OS is GNU/Linux Arch. I'm running qemu using i7 and asus hero7. I want to
run the game
Civilization 5 (windows), but when I run it, it crushes silently. I went to see
how much video memory windows can see. It turns
Hi all,
I know that simpletrace records go to memory buffer before it flushed
to file by a writer thread. My question is how to call this thread
(preferably using python), so I can make the flush process periodical?
Regards,
Ady
On Mon, Dec 1, 2014 at 8:41 PM, Paolo Bonzini wrote:
>
>
> On 01/12/2014 02:28, Ming Lei wrote:
>>> > - (unsigned long)(10 * duration) / maxcycles);
>>> > + (unsigned long)(10.0 * duration / maxcycles));
>> One more single bracket.
>
> I don't un
Alexander Graf writes:
> On 01.12.14 22:00, Lluís Vilanova wrote:
>> Mark Burton writes:
>>
>>> All - first a huge thanks for those who have contributed, and those who have
>>> expressed an interest in helping out.
>>
>>> One issue I’d like to see more opinions on is the question of a cache per
On 2014/12/2 0:40, Eric Blake wrote:
> On 11/29/2014 03:39 AM, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> Example QMP command of Change VNC keyboard layout:
>>
>> -> { "execute": "change",
>> "arguments": { "device": "vnc", "target": "keymap",
>>
On 2014/12/1 17:48, Paolo Bonzini wrote:
>
>
> On 28/11/2014 03:38, Gonglei wrote:
Can you find what line of kernel/sched.c it is?
>> Yes, of course. See below please:
>> "sgs->avg_load = (sgs->group_load * SCHED_LOAD_SCALE) / group->cpu_power; "
>> in update_sg_lb_stats(), file sched.c, li
On 2014/12/2 11:41, Gonglei wrote:
> Hi, Paolo
>
> A bug has been reported:
https://bugzilla.redhat.com/show_bug.cgi?id=1169577
Regards,
-Gonglei
Ok thanks for the advice, I'll adjust for v3. This is (clearly!) my first
contribution to Qemu so I'm still learning how you guys operate.
Cheers,
-bryan
On Mon, Dec 1, 2014 at 2:12 PM, Eric Blake wrote:
> On 11/26/2014 01:27 PM, Bryan D. Payne wrote:
> > Thanks for the feedback Eric, I've upd
On Mon, 12/01 20:36, Bryan D. Payne wrote:
> Ok thanks for the advice, I'll adjust for v3. This is (clearly!) my first
> contribution to Qemu so I'm still learning how you guys operate.
Great. Looking forward to the next version. BTW please try to use inline
replying.
Fam
>
> Cheers,
> -bryan
Here are some improvements on miscellaneous things such as CID generation,
comments, input validation.
Fam Zheng (6):
vmdk: Use g_random_int to generate CID
vmdk: Fix comment to match code of extent lines
vmdk: Clean up descriptor file reading
vmdk: Check descriptor file length when readin
It will be assigned to the return value of vmdk_read_desc.
Suggested-by: Markus Armbruster
Signed-off-by: Fam Zheng
---
block/vmdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index f7c7979..22f85c4 100644
--- a/block/vmdk.c
+++ b/block/vmdk.
Zeroing a buffer that will be filled right after is not necessary, and
allocating a power of two + 1 is naughty.
Suggested-by: Markus Armbruster
Signed-off-by: Fam Zheng
---
block/vmdk.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 2
This replaces two "time(NULL)" invocations with "g_random_int()".
According to VMDK spec, CID "is a random 32‐bit value updated the first
time the content of the virtual disk is modified after the virtual disk
is opened". Using "seconds since epoch" is just a "lame way" to generate
it, and not comp
commit 04d542c8b (vmdk: support vmfs files) added support of VMFS extent
type but the comment above the changed code is left out. Update the
comment so they are consistent.
Signed-off-by: Fam Zheng
---
block/vmdk.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/vm
Since a too small file cannot be a valid VMDK image, and also since the
buffer's first 4 bytes will be unconditionally examined by
vmdk_open_sparse, let's error out the small file case to be clear.
Signed-off-by: Fam Zheng
---
block/vmdk.c | 5 +
1 file changed, 5 insertions(+)
diff --git a
Reported-by: Markus Armbruster
Signed-off-by: Fam Zheng
---
block/vmdk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/vmdk.c b/block/vmdk.c
index 22f85c4..dd97e25 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -642,6 +642,7 @@ static int vmdk_open_vmdk4(BlockDriverState *bs,
Thanks for the quick review!
- Original Message -
> From: "Eric Blake"
> To: "Francesco Romani" , qemu-devel@nongnu.org
> Cc: kw...@redhat.com, mdr...@linux.vnet.ibm.com, stefa...@redhat.com,
> lcapitul...@redhat.com
> Sent: Monday, December 1, 2014 10:07:38 PM
> Subject: Re: [Qemu-devel
86 matches
Mail list logo
