Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

2014-11-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 04.11.2014 um 10:36 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 31.10.2014 um 23:45 hat Eric Blake geschrieben: >> >> On 10/30/2014 06:49 AM, Markus Armbruster wrote: >> >> >> >> > You either have to prevent *any* writing of the first 2048 bytes

Re: [Qemu-devel] [RFC PATCH] virtio-mmio: support for multiple irqs

2014-11-05 Thread Shannon Zhao
On 2014/11/4 17:35, Shannon Zhao wrote: > As the current virtio-mmio only support single irq, > so some advanced features such as vhost-net with irqfd > are not supported. And the net performance is not > the best without vhost-net and irqfd supporting. > Hi Joel, Peter, Mst, Some virtio-net wit

Re: [Qemu-devel] [PATCH 1/5] pci: introduce PC_PCI_CONFIG_ENABLED()

2014-11-05 Thread Hu Tao
On Tue, Nov 04, 2014 at 03:41:11PM +0200, Marcel Apfelbaum wrote: > Hi, > > On Tue, 2014-11-04 at 17:12 +0800, Hu Tao wrote: > > This makes code more readable. > > > > Signed-off-by: Hu Tao > > --- > > hw/mips/gt64xxx_pci.c | 4 ++-- > > hw/pci/pci_host.c | 5 +++-- > > include/hw/pci/pci.h

Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

2014-11-05 Thread Markus Armbruster
Jeff Cody writes: > On Tue, Nov 04, 2014 at 10:39:36AM +0100, Markus Armbruster wrote: >> Kevin Wolf writes: >> >> > Am 30.10.2014 um 13:49 hat Markus Armbruster geschrieben: >> >> Kevin Wolf writes: >> >> >> >> > Am 29.10.2014 um 14:54 hat Markus Armbruster geschrieben: >> >> >> Kevin Wolf

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Fix stale HTAB during live migration (TCG)

2014-11-05 Thread Alexander Graf
On 05.11.14 07:17, Samuel Mendoza-Jonas wrote: > If a TCG guest reboots during a running migration HTAB entries are not > marked dirty, and the destination boots with an invalid HTAB. > > When a reboot occurs reset the state of HTAB migration, and explicitly > inform the destination of invalid e

Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

2014-11-05 Thread Max Reitz
On 2014-11-05 at 09:05, Markus Armbruster wrote: Jeff Cody writes: On Tue, Nov 04, 2014 at 10:39:36AM +0100, Markus Armbruster wrote: Kevin Wolf writes: Am 30.10.2014 um 13:49 hat Markus Armbruster geschrieben: Kevin Wolf writes: Am 29.10.2014 um 14:54 hat Markus Armbruster geschrieben

[Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error.

2014-11-05 Thread SeokYeon Hwang
Negative type of errno like -ERRNO is used a lot by developers. Therefore, error_set_errno() is modified to deal with a negative type of os_error. (Negative type is used at pcie_cap_slot_hotplug_common() in hw/pci/pcie.c) Signed-off-by: SeokYeon Hwang --- util/error.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/4] target-ppc: Extend rtas-blob

2014-11-05 Thread Alexander Graf
On 05.11.14 08:12, Aravinda Prasad wrote: > Extend rtas-blob to accommodate error log. Error log > structure is saved in rtas space upon a machine check > exception. > > Signed-off-by: Aravinda Prasad > --- > hw/ppc/spapr.c |7 +++ > include/hw/ppc/spapr.h |5 + > 2 fil

Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error.

2014-11-05 Thread Max Reitz
On 2014-11-05 at 09:09, SeokYeon Hwang wrote: Negative type of errno like -ERRNO is used a lot by developers. Therefore, error_set_errno() is modified to deal with a negative type of os_error. (Negative type is used at pcie_cap_slot_hotplug_common() in hw/pci/pcie.c) Signed-off-by: SeokYeon Hwa

Re: [Qemu-devel] [PATCH 1/6] configure: add dependency from libxml2

2014-11-05 Thread Denis V. Lunev
On 05/11/14 10:32, Michael Tokarev wrote: 29.10.2014 16:38, Denis V. Lunev wrote: This dependency is required for adequate Parallels images support. Typically the disk consists of several images which are glued by XML disk descriptor. Also XML hides inside several important parameters which are

Re: [Qemu-devel] [RFC PATCH] virtio-mmio: support for multiple irqs

2014-11-05 Thread GAUGUEY Rémy 228890
Hi Shannon, >Type of backend bandwith(GBytes/sec) >virtio-net 0.66 >vhost-net 1.49 >vhost-net with irqfd2.01 > >Test cmd: ./iperf -c 192.168.0.2 -P 1 -i 10 -p 5001 -f G -t 60 Impressive results ! Could you please detail your setup ? which platform are you u

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-05 Thread Alexander Graf
On 05.11.14 08:13, Aravinda Prasad wrote: > This patch adds FWNMI support in qemu for powerKVM > guests by handling the ibm,nmi-register rtas call. > Whenever OS issues ibm,nmi-register RTAS call, the > machine check notification address is saved and the > machine check interrupt vector 0x200 is

Re: [Qemu-devel] The status about vhost-net on kvm-arm?

2014-11-05 Thread Shannon Zhao
Hi Nikolay, >From this mail I know you guys have done some work about ioeventfd support on kvm-arm before. Do you have plan to rework your patch based on the new branch? If not, I think we should send a patch to make eventfd support on kvm-arm and make vhost-net work. Based on the new kvm-arm bran

[Qemu-devel] [PATCH] Provide the missing LIBUSB_LOG_LEVEL_* for older libusb or FreeBSD. Providing just the needed value as a defined.

2014-11-05 Thread Chris Johns
Signed-off-by: Chris Johns --- hw/usb/host-libusb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index d2d161b..032a0e4 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -143,6 +143,12 @@ static void usb_host_attach_kernel(USB

Re: [Qemu-devel] Image probing: how it can be insecure, and what we could do about it

2014-11-05 Thread Max Reitz
On 2014-11-04 at 19:45, Markus Armbruster wrote: I'll try to explain all solutions fairly. Isn't easy when you're as biased towards one of them as I am. Please bear with me. = The trust boundary between image contents and meta-data = A disk image consists of image contents and meta-data. Ex

Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

2014-11-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 04.11.2014 um 16:25 hat Stefan Hajnoczi geschrieben: >> On Tue, Nov 04, 2014 at 11:11:33AM +0100, Kevin Wolf wrote: >> > Am 03.11.2014 um 16:05 hat Stefan Hajnoczi geschrieben: >> > > The argument that there might not be a traditional filename doesn't make >> > > sense to

Re: [Qemu-devel] [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio

2014-11-05 Thread Eric Auger
On 10/27/2014 12:23 PM, Li Liu wrote: > > > On 2014/10/27 17:37, Peter Maydell wrote: >> On 25 October 2014 09:24, john.liuli wrote: >>> To get the interrupt reason to support such VIRTIO_NET_F_STATUS >>> features I add a new register offset VIRTIO_MMIO_ISRMEM which >>> will help to establish a

[Qemu-devel] [PATCH] target-i386: cpu: keeping function parameters alignment on new line

2014-11-05 Thread Chen Fan
Signed-off-by: Chen Fan --- target-i386/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index fa860de..3f13dfe 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -540,8 +540,8 @@ void host_cpuid(uint32_t function, uint32

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/4] target-ppc: Extend rtas-blob

2014-11-05 Thread Aravinda Prasad
On Wednesday 05 November 2014 01:41 PM, Alexander Graf wrote: > > > On 05.11.14 08:12, Aravinda Prasad wrote: >> Extend rtas-blob to accommodate error log. Error log >> structure is saved in rtas space upon a machine check >> exception. >> >> Signed-off-by: Aravinda Prasad >> --- >> hw/ppc/sp

Re: [Qemu-devel] [PATCH] ui/input: strictly check console in finding input handler

2014-11-05 Thread Gerd Hoffmann
On Mi, 2014-11-05 at 00:49 +0800, Amos Kong wrote: > qemu_input_find_handler() prefers a handler associated with con. > But if none exists, it takes any. This patch added a parameter > to strictly check console, in case we want to input event to > special console. > > 'input-send-event' has a para

Re: [Qemu-devel] [PATCH 2/5] pc: define PC_PCI_CONFIG_ADDR and PC_PCI_CONFIG_DATA

2014-11-05 Thread Hu Tao
On Tue, Nov 04, 2014 at 03:44:35PM +0200, Marcel Apfelbaum wrote: > On Tue, 2014-11-04 at 17:12 +0800, Hu Tao wrote: > > PC_PCI_CONFIG_ADDR and PC_PCI_CONFIG_DATA are defined in PCI > > specification, so move them to common place. > > > > Signed-off-by: Hu Tao > > --- > > hw/pci-host/piix.c

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/4] target-ppc: Extend rtas-blob

2014-11-05 Thread Alexander Graf
On 05.11.14 09:46, Aravinda Prasad wrote: > > > On Wednesday 05 November 2014 01:41 PM, Alexander Graf wrote: >> >> >> On 05.11.14 08:12, Aravinda Prasad wrote: >>> Extend rtas-blob to accommodate error log. Error log >>> structure is saved in rtas space upon a machine check >>> exception. >>>

[Qemu-devel] [PATCH v2 2/5] pci: introduce pci_host_config_enabled()

2014-11-05 Thread Hu Tao
This makes code more readable. Signed-off-by: Hu Tao --- hw/mips/gt64xxx_pci.c | 4 ++-- hw/pci/pci_host.c | 5 +++-- include/hw/pci/pci_host.h | 5 + 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index 1f2fe5f..f118

[Qemu-devel] [PATCH v2 1/5] pci: reorganize QEMU_PCI_CAP_*

2014-11-05 Thread Hu Tao
This makes code more readable. Signed-off-by: Hu Tao --- include/hw/pci/pci.h | 39 --- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index c352c7b..b18759a 100644 --- a/include/hw/pci/pci.h +++ b/i

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/4] target-ppc: Extend rtas-blob

2014-11-05 Thread Alexander Graf
On 05.11.14 10:00, Alexander Graf wrote: > > > On 05.11.14 09:46, Aravinda Prasad wrote: >> >> >> On Wednesday 05 November 2014 01:41 PM, Alexander Graf wrote: >>> >>> >>> On 05.11.14 08:12, Aravinda Prasad wrote: Extend rtas-blob to accommodate error log. Error log structure is saved

[Qemu-devel] [PATCH v2 3/5] pci: define PCI_HOST_BRIDGE_CONFIG_ADDR and PCI_HOST_BRIDGE_CONFIG_DATA.

2014-11-05 Thread Hu Tao
PCI_HOST_BRIDGE_CONFIG_ADDR and PCI_HOST_BRIDGE_CONFIG_DATA are defined in PCI specification, so move them to common place. Signed-off-by: Hu Tao --- hw/pci-host/piix.c| 8 hw/pci-host/prep.c| 6 -- hw/pci-host/q35.c | 8 include/hw/pci-host/q35.h

[Qemu-devel] [PATCH v2 0/5] Some PCI related cleanup patches

2014-11-05 Thread Hu Tao
Hi, This is v2 of PCI clenaup series. See each patch for the detail. changes: v2: - remove patch 3 from v1 which is incorrect. - rename defined macros as per Marcel's suggestion - place macros in pci_host.h as per Marcel's suggestion - new patch 'pci: reorganize QEMU_PCI_CAP_*' Hu Tao (5

[Qemu-devel] [PATCH v2 5/5] pci: remove the limit parameter of pci_host_config_write_common

2014-11-05 Thread Hu Tao
Since the limit parameter is always set to the size of pci device's configuration space, and we can determine the size from the type of pci device. Signed-off-by: Hu Tao --- hw/pci/pci_host.c | 13 ++--- hw/pci/pcie_host.c| 9 + hw/ppc/spapr_pci.c| 3 +--

[Qemu-devel] [PATCH v2 4/5] pci: remove the limit parameter of pci_host_config_read_common

2014-11-05 Thread Hu Tao
Since the limit parameter is always set to the size of pci device's configuration space, and we can determine the size from the type of pci device. Signed-off-by: Hu Tao --- hw/pci/pci_host.c | 15 +++ hw/pci/pcie_host.c| 9 + hw/ppc/spapr_pci.c| 3 +

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3 4/5] qemu-char: convert some open functions to use Error API

2014-11-05 Thread Markus Armbruster
Michael Tokarev writes: > 04.11.2014 16:39, Alex Bennée wrote: >> zhanghailiang writes: >> >>> Convert several Character backend open functions to use the Error API. >>> >>> Signed-off-by: zhanghailiang >>> --- >>> qemu-char.c | 76 >>> +---

Re: [Qemu-devel] [RFC PATCH] virtio-mmio: support for multiple irqs

2014-11-05 Thread Shannon Zhao
Hi Rémy, On 2014/11/5 16:26, GAUGUEY Rémy 228890 wrote: > Hi Shannon, > >> Type of backend bandwith(GBytes/sec) >> virtio-net 0.66 >> vhost-net 1.49 >> vhost-net with irqfd2.01 >> >> Test cmd: ./iperf -c 192.168.0.2 -P 1 -i 10 -p 5001 -f G -t 60 > > Impres

Re: [Qemu-devel] [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio

2014-11-05 Thread Christoffer Dall
On Mon, Oct 27, 2014 at 12:58 PM, Peter Maydell wrote: > On 27 October 2014 11:23, Li Liu wrote: >> So you mean virtio-mmio will be replaced by PCI/PCIe on ARM at last? > > That is the plan, yes. I can't make any promises on > timescales at the moment, though... > Linaro has scheduled resources t

Re: [Qemu-devel] [PATCH 0/4] ioeventfd support for virtio-mmio

2014-11-05 Thread Shannon Zhao
On 2014/11/4 20:47, Shannon Zhao wrote: > Add host/guest notifiers support for virtio-mmio, so that qemu can > enable vhost-net for kvm-arm. > > Refer to the patches from Ying-Shiuan Pan > https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg00715.html > > As vhost-net can improve the net p

Re: [Qemu-devel] [PATCH] Provide the missing LIBUSB_LOG_LEVEL_* for older libusb or FreeBSD. Providing just the needed value as a defined.

2014-11-05 Thread Gerd Hoffmann
On Mi, 2014-11-05 at 19:35 +1100, Chris Johns wrote: > +#ifndef LIBUSB_LOG_LEVEL_WARNING /* older libusb didn't define these > */ > +#define LIBUSB_LOG_LEVEL_WARNING 2 > +#endif Added to usb patch queue. thanks, Gerd

[Qemu-devel] [PATCH 2/6] pci: remove pci_config_set_device_id

2014-11-05 Thread Hu Tao
See also commit 'pci: remove pci_config_set_vendor_id'. Signed-off-by: Hu Tao --- hw/pci/pci.c | 2 +- include/hw/pci/pci.h | 6 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 6c544ed..e5d192d 100644 --- a/hw/pci/pci.c +++ b/hw/pci/

[Qemu-devel] [PATCH 3/6] pci: remove pci_config_set_revision

2014-11-05 Thread Hu Tao
See also commit 'pci: remove pci_config_set_vendor_id'. Signed-off-by: Hu Tao --- hw/pci/pci.c | 2 +- include/hw/pci/pci.h | 6 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index e5d192d..fdab941 100644 --- a/hw/pci/pci.c +++ b/hw/pci/

[Qemu-devel] [PATCH 5/6] pci: remove pci_config_set_prog_interface

2014-11-05 Thread Hu Tao
See also commit 'pci: remove pci_config_set_vendor_id'. Signed-off-by: Hu Tao --- hw/block/nvme.c| 2 +- hw/i386/xen/xen_platform.c | 2 +- hw/i386/xen/xen_pvdevice.c | 2 +- hw/ide/ich.c | 2 +- hw/ide/via.c | 2 +- hw/isa/vt82c686.c | 2 +- hw/m

[Qemu-devel] [PATCH 4/6] pci: remove pci_config_set_class

2014-11-05 Thread Hu Tao
See also commit 'pci: remove pci_config_set_vendor_id'. Signed-off-by: Hu Tao --- hw/block/nvme.c| 2 +- hw/pci-host/ppce500.c | 2 +- hw/pci/pci.c | 2 +- hw/pci/pci_bridge.c| 2 +- hw/virtio/virtio-pci.c | 2 +- include/hw/pci/pci.h | 6 -- 6 files changed, 5 inser

[Qemu-devel] [PATCH 1/6] pci: remove pci_config_set_vendor_id

2014-11-05 Thread Hu Tao
Use pci_set_word() instead. The main purpose is for API consistency. Detailed reasons: - pci_config_set_* are not complete. 1) Only part of registers in predefined header portion of PCI Configuration Space are supported. 2) Lack of get_ counterparts. - pci_set_word() and friends are e

[Qemu-devel] [PULL 2/2] s390x: Implement SAM{24,31,64}

2014-11-05 Thread Alexander Graf
The SAM instructions simply change 2 bits in PSW.MASK to advertise the current memory mode. While we can't fully guarantee that 31 bit mode (or even remotely 24 bit mode) actually work correctly, we don't check whether lpswe modifies these bits, so we shouldn't keep the guest from executing SAM ins

[Qemu-devel] [PULL 2.2 0/2] s390 patch queue 2014-11-05 for 2.2

2014-11-05 Thread Alexander Graf
Hi Peter, This is my current patch queue for s390. Please pull. Alex The following changes since commit d5b4dc3b50175f0c34f3cf4b053e123fb37f5aed: Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-peter' into staging (2014-11-04 17:33:34 +) are available in the git re

[Qemu-devel] [PATCH 6/6] pci: remove pci_config_set_interrupt_pin

2014-11-05 Thread Hu Tao
See also commit 'pci: remove pci_config_set_vendor_id'. Signed-off-by: Hu Tao --- hw/audio/intel-hda.c | 2 +- hw/i2c/smbus_ich9.c | 2 +- hw/ide/ich.c | 2 +- hw/isa/i82378.c | 2 +- hw/misc/ivshmem.c| 2 +- hw/misc/vfio.c | 2 +- hw/scsi/vmw_pvscsi.c | 2 +- hw/usb/hcd-

[Qemu-devel] [PULL 1/2] s390x: Fix sclp console input

2014-11-05 Thread Alexander Graf
When injecting an sclp console interrupt into the guest, we increase the PC by 4 for some reason. I have no idea why I put that code there, but it's clearly wrong. Remove the increment. This patch fixes sclp serial input for the ccw machine. Signed-off-by: Alexander Graf Reviewed-by: Bastian Kop

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-05 Thread Claudio Fontana
Hi all, On 30.10.2014 19:02, Mark Rutland wrote: > On Thu, Oct 30, 2014 at 05:52:44PM +, Peter Maydell wrote: >> On 30 October 2014 17:43, Alexander Spyridakis >> wrote: >>> Currently, the virt machine model generates Device Tree information >>> dynamically based on the existing devices in t

[Qemu-devel] [RFC PATCH 0/6] pci cleanup: remove pci_config_set_*

2014-11-05 Thread Hu Tao
Hi, This series removes pci_config_set_*. The main purpose is for API consistency. Detailed reasons: - pci_config_set_* are not complete. 1) Only part of registers in predefined header portion of PCI Configuration Space are supported. 2) Lack of get_ counterparts. - pci_set_word() a

[Qemu-devel] [PATCH] pci: fixed mismatch of error-handling between pci_qdev_init() and qdev

2014-11-05 Thread SeokYeon Hwang
pci_qdev_init() checks whether return value is 0 or not to figure out pci device is initialized successfully. Otherwise, device_realize() in qdev checks that return value is negative value to figure out the device is realized successfully. When pci device returns positive number, pci_qdev_init()

Re: [Qemu-devel] Image probing: how it can be insecure, and what we could do about it

2014-11-05 Thread Gerd Hoffmann
Hi, > My proposal to ditch image contents probing entirely has more serious > compatibility issues. In particular, we'd have to forgo sugared > convenience syntax for a number of less common things. It definitely > needs a grace period where all usage we're going to break warns. On the > up s

Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

2014-11-05 Thread Eric Blake
On 11/05/2014 09:39 AM, Markus Armbruster wrote: >> Hm... In which cases does libvirt probe the image format? And is it even >> consistent with qemu today? > > I had a quick look at the source. Eric, please correct > misunderstandings. > > Enumation type virStorageFileProbeFormat enumerates sup

Re: [Qemu-devel] [RESEND PATCH v4 08/10] pc-dimm: Add pc_dimm_unrealize() for memory hot unplug support.

2014-11-05 Thread Igor Mammedov
On Wed, 5 Nov 2014 13:49:53 +0800 Tang Chen wrote: > From: Hu Tao > > Implement unrealize function for pc-dimm device. It remove subregion from > hotplug region, and delete ram address range from guest ram list. This still doesn't address comments made in V3 looks like there isn't any need for

Re: [Qemu-devel] [PATCH v4 6/6] hw/arm/virt: add dynamic sysbus device support

2014-11-05 Thread Alexander Graf
On 31.10.14 14:53, Eric Auger wrote: > Allows sysbus devices to be instantiated from command line by > using -device option. Machvirt creates a platform bus at init. > The dynamic sysbus devices are attached to a platform bus device. > > The platform bus device registers a machine init done noti

Re: [Qemu-devel] Image probing: how it can be insecure, and what we could do about it

2014-11-05 Thread Eric Blake
On 11/05/2014 09:38 AM, Max Reitz wrote: >> Note that specifying just the top image's format is not enough, you also >> have to specify any backing images' formats. QCOW2 can optionally store >> the backing image format in the image. The other COW formats can't. > > Well, they can, with "json:"

Re: [Qemu-devel] [PATCH v4 5/6] hw/arm/sysbus-fdt: helpers for platform bus nodes addition

2014-11-05 Thread Alexander Graf
On 31.10.14 14:53, Eric Auger wrote: > This new C module will be used by ARM machine files to generate > platform bus node and their dynamic sysbus device tree nodes. > > Dynamic sysbus device node addition is done in a machine init > done notifier. arm_register_platform_bus_fdt_creator does the

Re: [Qemu-devel] [PATCH v4 0/6] machvirt dynamic sysbus device instantiation

2014-11-05 Thread Alexander Graf
On 31.10.14 14:53, Eric Auger wrote: > This patch series enables machvirt to dynamically instantiate sysbus > devices from command line (using -device option). > > All those sysbus devices are plugged onto a platform bus. This latter > device is instantiated in machvirt and takes care of the bin

Re: [Qemu-devel] [RFC PATCH 0/8] Add Generic PCI host device update

2014-11-05 Thread Claudio Fontana
Hi Alvise, On 11.07.2014 09:21, Alvise Rigo wrote: > This patch series is based on the previous work [1] and [2] by Rob > Herring and it tries to enhance this work on these points: do your patches need to be applied on top of Rob's? I ask because I cannot see the patch "hw/arm/virt: Add generic

Re: [Qemu-devel] [PATCH v7 10/16] hw/vfio: calxeda xgmac device

2014-11-05 Thread Alexander Graf
On 31.10.14 15:05, Eric Auger wrote: > The platform device class has become abstract. The device can be be > instantiated on command line using such option. > > -device vfio-calxeda-xgmac,host="fff51000.ethernet" > > Signed-off-by: Eric Auger > > --- > > v5 -> v6 > - back again following Ale

Re: [Qemu-devel] [PATCH] kvmclock: Add comment explaining why we need cpu_clean_all_dirty()

2014-11-05 Thread Paolo Bonzini
On 03/11/2014 18:45, Eduardo Habkost wrote: > Try to explain why commit 317b0a6d8ba44e9bf8f9c3dbd776c4536843d82c > needed a cpu_clean_all_dirty() call just after calling > cpu_synchronize_all_states(). > > Signed-off-by: Eduardo Habkost > Cc: Andrey Korolyov > Cc: Marcin Gibuła > Cc: Marcelo

Re: [Qemu-devel] [PATCH v7 09/16] hw/vfio/platform: add vfio-platform support

2014-11-05 Thread Alexander Graf
On 31.10.14 15:05, Eric Auger wrote: > Minimal VFIO platform implementation supporting > - register space user mapping, > - IRQ assignment based on eventfds handled on qemu side. > > irqfd kernel acceleration comes in a subsequent patch. > > Signed-off-by: Kim Phillips > Signed-off-by: Eric Au

Re: [Qemu-devel] [RESEND PATCH v4 00/10] QEmu memory hot unplug support.

2014-11-05 Thread Igor Mammedov
On Wed, 5 Nov 2014 13:49:45 +0800 Tang Chen wrote: > This patch-set implements memory hot-remove for QEmu. > > Rebased on Igor's asynchronize hotplug framework (qemu v2.1.2, the latest). As I've wrote before, there were hot-unplug patches merged last month, see for reference http://lists.nongn

Re: [Qemu-devel] Image probing: how it can be insecure, and what we could do about it

2014-11-05 Thread Eric Blake
On 11/04/2014 07:45 PM, Markus Armbruster wrote: > I'll try to explain all solutions fairly. Isn't easy when you're as > biased towards one of them as I am. Please bear with me. > Thanks for this write-up. I'll probably reply again, but for now I'm focusing on just one thing I think you missed

Re: [Qemu-devel] [PATCH 7/9] valgrind/i386: avoid false positives on KVM_GET_MSRS ioctl

2014-11-05 Thread Paolo Bonzini
On 30/10/2014 10:36, Christian Borntraeger wrote: > struct kvm_msrs contains a pad field. Lets initialize this pad > field. A designated initializer seems not appropriate here, as > struct kvm_msrs is embedded in the msr_data structure. > > Signed-off-by: Christian Borntraeger What about this:

Re: [Qemu-devel] [PATCH 7/9] valgrind/i386: avoid false positives on KVM_GET_MSRS ioctl

2014-11-05 Thread Paolo Bonzini
On 05/11/2014 11:33, Paolo Bonzini wrote: > On 30/10/2014 10:36, Christian Borntraeger wrote: >> struct kvm_msrs contains a pad field. Lets initialize this pad >> field. A designated initializer seems not appropriate here, as >> struct kvm_msrs is embedded in the msr_data structure. >> >> Signed-

Re: [Qemu-devel] [PATCH v3 2/2] vfio: use kvm_resamplefds_enabled()

2014-11-05 Thread Paolo Bonzini
On 04/11/2014 23:25, Alex Williamson wrote: > Acked-by: Alex Williamson Thanks, I'll get it into the KVM tree (uq/master). Paolo

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-05 Thread Aravinda Prasad
On Wednesday 05 November 2014 02:02 PM, Alexander Graf wrote: > > > On 05.11.14 08:13, Aravinda Prasad wrote: >> This patch adds FWNMI support in qemu for powerKVM >> guests by handling the ibm,nmi-register rtas call. >> Whenever OS issues ibm,nmi-register RTAS call, the >> machine check notifi

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/4] target-ppc: Extend rtas-blob

2014-11-05 Thread Aravinda Prasad
On Wednesday 05 November 2014 02:37 PM, Alexander Graf wrote: > > > On 05.11.14 10:00, Alexander Graf wrote: >> >> >> On 05.11.14 09:46, Aravinda Prasad wrote: >>> >>> >>> On Wednesday 05 November 2014 01:41 PM, Alexander Graf wrote: On 05.11.14 08:12, Aravinda Prasad wrote:

Re: [Qemu-devel] [PATCH 2/6] block/parallels: allow to specify DiskDescriptor.xml instead of image file

2014-11-05 Thread Denis V. Lunev
On 05/11/14 05:12, Jeff Cody wrote: On Wed, Oct 29, 2014 at 04:38:07PM +0300, Denis V. Lunev wrote: Typically Parallels disk bundle consists of several images which are glued by XML disk descriptor. Also XML hides inside several important parameters which are not available in the image header.

Re: [Qemu-devel] [PATCH v3 2/2] main-loop: Use epoll on Linux

2014-11-05 Thread Paolo Bonzini
On 27/10/2014 08:30, Fam Zheng wrote: > > +static int epoll_prepare(int epollfd, > + GPollFD *fds, guint nfds, > + GPollFD **g_poll_fds, > + guint *g_poll_nfds, > + int **g_poll_fd_idx) Please pass t

Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error.

2014-11-05 Thread Paolo Bonzini
On 05/11/2014 09:12, Max Reitz wrote: > On 2014-11-05 at 09:09, SeokYeon Hwang wrote: >> Negative type of errno like -ERRNO is used a lot by developers. >> Therefore, error_set_errno() is modified to deal with a negative type >> of os_error. >> (Negative type is used at pcie_cap_slot_hotplug_common

Re: [Qemu-devel] [PATCH v3] smbios: need to change some of 'ram_addr_t' variable to 'uint64_t'

2014-11-05 Thread Paolo Bonzini
On 05/11/2014 07:19, SeokYeon Hwang wrote: > Some of variables handling 64bit address must be changed from 'ram_addr_t' to > 'uint64_t'. > > Signed-off-by: SeokYeon Hwang Thanks, applied. I modified the commit message as follows: smbios: change 'ram_addr_t' variables to 'uint64_t' ra

Re: [Qemu-devel] [PATCH] pci: fixed mismatch of error-handling between pci_qdev_init() and qdev

2014-11-05 Thread Paolo Bonzini
On 05/11/2014 11:11, SeokYeon Hwang wrote: > pci_qdev_init() checks whether return value is 0 or not to figure out pci > device is initialized successfully. Otherwise, device_realize() in qdev > checks that return value is negative value to figure out the device is > realized successfully. > W

Re: [Qemu-devel] [PATCH v7 12/16] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation

2014-11-05 Thread Alexander Graf
On 31.10.14 15:05, Eric Auger wrote: > vfio-calxeda-xgmac now can be instantiated using the -device option. > The node creation function generates a very basic dt node composed > of the compat, reg and interrupts properties > > Signed-off-by: Eric Auger > > --- > > v6 -> v7: > - compat string

Re: [Qemu-devel] [PATCH 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-05 Thread Stefano Stabellini
On Tue, 4 Nov 2014, Xu, Quan wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Monday, November 03, 2014 7:54 PM > > To: Xu, Quan > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; > > stefano.stabell...@eu.citrix.com > > Sub

Re: [Qemu-devel] [PATCH v2] translate-all: Marked map_exec() with the 'unused' attribute

2014-11-05 Thread Paolo Bonzini
On 03/11/2014 09:11, SeokYeon Hwang wrote: > Marked map_exec() with the 'unused' attribute to avoid '-Wunused-function' on > clang 3.4 or later. > > Signed-off-by: SeokYeon Hwang Cc: qemu-triv...@nongnu.org Reviewed-by: Paolo Bonzini > --- > translate-all.c | 4 ++-- > 1 file changed, 2 inse

Re: [Qemu-devel] Image probing: how it can be insecure, and what we could do about it

2014-11-05 Thread Kevin Wolf
Am 04.11.2014 um 19:45 hat Markus Armbruster geschrieben: > I'll try to explain all solutions fairly. Isn't easy when you're as > biased towards one of them as I am. Please bear with me. > > > = The trust boundary between image contents and meta-data = > > A disk image consists of image conten

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-05 Thread Alexander Graf
On 05.11.14 11:37, Aravinda Prasad wrote: > > > On Wednesday 05 November 2014 02:02 PM, Alexander Graf wrote: >> >> >> On 05.11.14 08:13, Aravinda Prasad wrote: >>> This patch adds FWNMI support in qemu for powerKVM >>> guests by handling the ibm,nmi-register rtas call. >>> Whenever OS issues i

Re: [Qemu-devel] [RFC PATCH 0/8] Add Generic PCI host device update

2014-11-05 Thread alvise rigo
On Wed, Nov 5, 2014 at 11:23 AM, Claudio Fontana wrote: > Hi Alvise, Hi Claudio, > > On 11.07.2014 09:21, Alvise Rigo wrote: >> This patch series is based on the previous work [1] and [2] by Rob >> Herring and it tries to enhance this work on these points: > > do your patches need to be applied

Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error.

2014-11-05 Thread Max Reitz
On 2014-11-05 at 11:57, Paolo Bonzini wrote: On 05/11/2014 09:12, Max Reitz wrote: On 2014-11-05 at 09:09, SeokYeon Hwang wrote: Negative type of errno like -ERRNO is used a lot by developers. Therefore, error_set_errno() is modified to deal with a negative type of os_error. (Negative type is u

Re: [Qemu-devel] Image probing: how it can be insecure, and what we could do about it

2014-11-05 Thread Kevin Wolf
Am 05.11.2014 um 09:38 hat Max Reitz geschrieben: > My conclusion: Don't ditch probing. It increases entropy, why would > you ditch probing? Just combine it with the extension and if both > don't seem to match, that's an error. I actually kind of like this (in addition to preventing bad writes). I

Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error.

2014-11-05 Thread Eric Blake
On 11/05/2014 12:11 PM, Max Reitz wrote: +err->msg = g_strdup_printf("%s: %s", msg1, strerror(abs(os_errno))); >> I don't, we really should fix the callers. > > Of course I understand, but this patch doesn't make matters worse, as > long as there are not systems which have nega

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-05 Thread Aravinda Prasad
On Wednesday 05 November 2014 04:37 PM, Alexander Graf wrote: > > > On 05.11.14 11:37, Aravinda Prasad wrote: >> >> >> On Wednesday 05 November 2014 02:02 PM, Alexander Graf wrote: >>> >>> >>> On 05.11.14 08:13, Aravinda Prasad wrote: This patch adds FWNMI support in qemu for powerKVM

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-05 Thread Alexander Graf
On 05.11.14 12:24, Aravinda Prasad wrote: > > > On Wednesday 05 November 2014 04:37 PM, Alexander Graf wrote: >> >> >> On 05.11.14 11:37, Aravinda Prasad wrote: >>> >>> >>> On Wednesday 05 November 2014 02:02 PM, Alexander Graf wrote: On 05.11.14 08:13, Aravinda Prasad wrote: >>>

Re: [Qemu-devel] [PATCH v7 09/16] hw/vfio/platform: add vfio-platform support

2014-11-05 Thread Eric Auger
On 11/05/2014 11:29 AM, Alexander Graf wrote: > > > On 31.10.14 15:05, Eric Auger wrote: >> Minimal VFIO platform implementation supporting >> - register space user mapping, >> - IRQ assignment based on eventfds handled on qemu side. >> >> irqfd kernel acceleration comes in a subsequent patch. >>

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3 1/5] qemu-char: fix parameter check in some qemu_chr_parse_* functions

2014-11-05 Thread zhanghailiang
On 2014/11/5 15:05, Michael Tokarev wrote: 04.11.2014 16:25, Alex Bennée wrote: zhanghailiang writes: For some qemu_chr_parse_* functions, we just check whether the parameter is NULL or not, but do not check if it is empty. For example: qemu-system-x86_64 -chardev pipe,id=id,path= It will pa

Re: [Qemu-devel] [RFC PATCH 6/8] generic_pci: generate dt node after devices init

2014-11-05 Thread Claudio Fontana
On 11.07.2014 09:21, Alvise Rigo wrote: > Keeping advantage of the finalize_dt QEMUMachine function, the mach-virt > machine now completes the device tree creation after that all the > generic devices have been instantiated. This allows to generate the > interrupt-map node according to the devices

Re: [Qemu-devel] [PATCH v7 12/16] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation

2014-11-05 Thread Eric Auger
On 11/05/2014 11:59 AM, Alexander Graf wrote: > > > On 31.10.14 15:05, Eric Auger wrote: >> vfio-calxeda-xgmac now can be instantiated using the -device option. >> The node creation function generates a very basic dt node composed >> of the compat, reg and interrupts properties >> >> Signed-off-b

Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error.

2014-11-05 Thread Paolo Bonzini
On 05/11/2014 12:11, Max Reitz wrote: > > Of course I understand, but this patch doesn't make matters worse, as > long as there are not systems which have negative values for errno > (which I think we generally assume not to exist throughout qemu). That's > why I'm fine with it. We should fix th

Re: [Qemu-devel] [PATCH] pci: fixed mismatch of error-handling between pci_qdev_init() and qdev

2014-11-05 Thread Michael S. Tsirkin
On Wed, Nov 05, 2014 at 07:11:51PM +0900, SeokYeon Hwang wrote: > pci_qdev_init() checks whether return value is 0 or not to figure out pci > device is initialized successfully. Otherwise, device_realize() in qdev > checks that return value is negative value to figure out the device is > realize

Re: [Qemu-devel] [PULL 2.2 00/33] ppc patch queue 2014-11-04 for 2.2

2014-11-05 Thread Peter Maydell
On 4 November 2014 19:26, Alexander Graf wrote: > Hi Peter, > > This is my current patch queue for ppc. Please pull. > > Alex > > > The following changes since commit d5b4dc3b50175f0c34f3cf4b053e123fb37f5aed: > > Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-peter' > into

Re: [Qemu-devel] [PATCH v7 09/16] hw/vfio/platform: add vfio-platform support

2014-11-05 Thread Alexander Graf
On 05.11.14 13:03, Eric Auger wrote: > On 11/05/2014 11:29 AM, Alexander Graf wrote: >> >> >> On 31.10.14 15:05, Eric Auger wrote: >>> Minimal VFIO platform implementation supporting >>> - register space user mapping, >>> - IRQ assignment based on eventfds handled on qemu side. >>> >>> irqfd kern

Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error.

2014-11-05 Thread SeokYeon Hwang
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Wednesday, November 05, 2014 9:45 PM > To: Max Reitz; SeokYeon Hwang; qemu-devel@nongnu.org > Cc: arm...@redhat.com; paolo.bonz...@gmail.com > Subject: Re: [PATCH] error: fixed e

Re: [Qemu-devel] [PATCH] pci: fixed mismatch of error-handling between pci_qdev_init() and qdev

2014-11-05 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Nov 05, 2014 at 07:11:51PM +0900, SeokYeon Hwang wrote: >> pci_qdev_init() checks whether return value is 0 or not to figure >> out pci device is initialized successfully. Otherwise, >> device_realize() in qdev checks that return value is negative value >> t

Re: [Qemu-devel] [PATCH] pci: fixed mismatch of error-handling between pci_qdev_init() and qdev

2014-11-05 Thread Paolo Bonzini
On 05/11/2014 14:16, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > >> On Wed, Nov 05, 2014 at 07:11:51PM +0900, SeokYeon Hwang wrote: >>> pci_qdev_init() checks whether return value is 0 or not to figure >>> out pci device is initialized successfully. Otherwise, >>> device_realize()

Re: [Qemu-devel] [PULL 00/01] Adding new syscalls to seccomp whitelist

2014-11-05 Thread Peter Maydell
On 22 October 2014 11:02, Peter Maydell wrote: > On 22 October 2014 09:04, Eduardo Otubo > wrote: >> On Fri, Sep 19, 2014 at 08:11:14AM -0700, Peter Maydell wrote: >>> You have compile problems in current master as well. Your macros >>> probably need to guard themselves on whether the syscall th

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3 1/5] qemu-char: fix parameter check in some qemu_chr_parse_* functions

2014-11-05 Thread Alex Bennée
zhanghailiang writes: > On 2014/11/5 15:05, Michael Tokarev wrote: >> 04.11.2014 16:25, Alex Bennée wrote: >>> zhanghailiang writes: >> a good reason for having assert here. >> > > Agreed, assert here is still not unnecessary, > filename will never to be NULL in these two cases. > >>> At a min

Re: [Qemu-devel] [PATCH] pci: fixed mismatch of error-handling between pci_qdev_init() and qdev

2014-11-05 Thread Michael S. Tsirkin
On Wed, Nov 05, 2014 at 02:18:31PM +0100, Paolo Bonzini wrote: > > > On 05/11/2014 14:16, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > >> On Wed, Nov 05, 2014 at 07:11:51PM +0900, SeokYeon Hwang wrote: > >>> pci_qdev_init() checks whether return value is 0 or not to figure >

Re: [Qemu-devel] [PATCH] pci: fixed mismatch of error-handling between pci_qdev_init() and qdev

2014-11-05 Thread SeokYeon Hwang
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Wednesday, November 05, 2014 9:46 PM > To: SeokYeon Hwang > Cc: qemu-devel@nongnu.org; arm...@redhat.com; pbonz...@redhat.com > Subject: Re: [PATCH] pci: fixed mismatch of error-handling between > pci_qdev_init

Re: [Qemu-devel] [PATCH] error: fixed error_set_errno() to deal with a negative type of os_error.

2014-11-05 Thread Markus Armbruster
Paolo Bonzini writes: > On 05/11/2014 12:11, Max Reitz wrote: >> >> Of course I understand, but this patch doesn't make matters worse, as >> long as there are not systems which have negative values for errno >> (which I think we generally assume not to exist throughout qemu). That's >> why I'm f

Re: [Qemu-devel] [PATCH] gdbstub: Add a missing case of signal number translation in gdbstub

2014-11-05 Thread Martin Simmons
> On Tue, 4 Nov 2014 19:09:43 +, Peter Maydell said: > > On 4 November 2014 17:51, Martin Simmons wrote: > > While using qemu with gdb "target remote" to debug an application that uses > > fork and exec, the qemu process receives SIGSTOP every time the forked > > process > > terminates (

Re: [Qemu-devel] [RFC][PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-11-05 Thread Michael S. Tsirkin
On Wed, Nov 05, 2014 at 03:22:59PM +0800, Tiejun Chen wrote: > Currently IGD drivers always need to access PCH by 1f.0, and > PCH vendor/device id is used to identify the card. > > Signed-off-by: Tiejun Chen > --- > hw/i386/pc_piix.c | 28 +++- > 1 file changed, 27 insert

Re: [Qemu-devel] [PATCH RESEND] vhost-user-test: Fix 'make check' broken on glib < 2.26

2014-11-05 Thread Peter Maydell
On 5 November 2014 01:00, wrote: > From: Gonglei > > After commit 89b516d8, some logics is turbid and > breaks 'make check' as below errors: > tests/vhost-user-test.c: In function '_cond_wait_until': > tests/vhost-user-test.c:154: error: 'G_TIME_SPAN_SECOND' undeclared (first > use in this func

Re: [Qemu-devel] [PATCH] gdbstub: Add a missing case of signal number translation in gdbstub

2014-11-05 Thread Peter Maydell
On 5 November 2014 13:50, Martin Simmons wrote: >> On Tue, 4 Nov 2014 19:09:43 +, Peter Maydell said: >> The if() statement should have braces for our coding style, >> and no space before the '(' in function calls; otherwise this >> looks good to me. > > Do you want a new patch with it lik

  1   2   3   >