On 5 November 2014 13:50, Martin Simmons <mar...@lispworks.com> wrote:
>>>>>> On Tue, 4 Nov 2014 19:09:43 +0000, Peter Maydell said:
>> The if() statement should have braces for our coding style,
>> and no space before the '(' in function calls; otherwise this
>> looks good to me.
>
> Do you want a new patch with it like that? I was following the style of the
> rest of that file, in particular the other 'C' case :-(
Yes, if you could respin it that would be nice. Unfortunately there
are still areas of our codebase which don't follow the coding
style; we update bits of code as we change them, so new patches
follow the style guide for the lines they touch. You can use
scripts/checkpatch.pl to check your patch for the most common
issues.
thanks
-- PMM
