Re: [Qemu-devel] [PULL 7/8] s390x/migration: migrate CPU state

2014-10-10 Thread Thomas Huth
On Thu, 9 Oct 2014 17:28:57 +0100 Peter Maydell wrote: > On 9 October 2014 14:36, Cornelia Huck wrote: > > From: Thomas Huth > > > > This patch provides the cpu save information for dumps and later life > > migration and enables migration of the CPU state. The code is based on > > earlier work

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-10-10 Thread Marcin Gibuła
Does anybody know why the APIC state loaded by the first call to kvm_arch_get_registers() is wrong, in the first place? What exactly is different in the APIC state in the second kvm_arch_get_registers() call, and when/why does it change? If cpu_synchronize_state() does the wrong thing if it is ca

Re: [Qemu-devel] qemu is missing monitor

2014-10-10 Thread Gerd Hoffmann
On Do, 2014-10-09 at 17:05 +0100, Peter Maydell wrote: > On 9 October 2014 14:37, Jiri Slaby wrote: > > Hi guys, > > > > qemu in opensuse latest (factory) does not have monitor. Despite > > libvte-devel is installed, it is not detected by qemu. The problem is > > that configure looks for vte-2.90,

Re: [Qemu-devel] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror'

2014-10-10 Thread Peter Maydell
On 10 October 2014 02:54, Chen Gang wrote: > I use the latest upstream gcc (which pulled from master in 2014-10-0?). > In my memory (not quite sure), the older version gcc may not notice > about this warning. Hmm. I'll see if I can test with that gcc. > But for me, the warning (compiler worries

Re: [Qemu-devel] qemu is missing monitor

2014-10-10 Thread Jiri Slaby
On 10/09/2014, 06:05 PM, Peter Maydell wrote: > On 9 October 2014 14:37, Jiri Slaby wrote: >> Hi guys, >> >> qemu in opensuse latest (factory) does not have monitor. Despite >> libvte-devel is installed, it is not detected by qemu. The problem is >> that configure looks for vte-2.90, but we have v

Re: [Qemu-devel] [PATCH v2] linux-user: Let user specify random seed

2014-10-10 Thread Magnus Reftel
On Thu, Oct 9, 2014 at 9:43 PM, Tom Musta wrote: > On 10/9/2014 3:36 AM, Magnus Reftel wrote: >> This patch introduces the -seed command line option and the >> QEMU_RAND_SEED environment variable for setting the random seed, which >> is used for the AT_RANDOM ELF aux entry. >> >> This is an update

Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64

2014-10-10 Thread Claudio Fontana
Reviewed-by: Claudio Fontana On 10.10.2014 06:22, Amanieu d'Antras wrote: > On AArch64 the si_addr field of siginfo_t is truncated to 32 bits > because the fault address passes through an uint32_t variable. This > is fixed by changing the variable to uint64_t. > > Signed-off-by: Amanieu d'Antras

Re: [Qemu-devel] [PATCH] linux-user: Let user specify random seed

2014-10-10 Thread Magnus Reftel
On Thu, Oct 9, 2014 at 11:30 PM, Eric Blake wrote: > On 10/09/2014 01:12 PM, Magnus Reftel wrote: >> +if (parse_uint(arg, &seed, &end, 0) != 0 || *end != 0 || seed > >> UINT_MAX) { > > Slightly shorter as: > > if (parse_uint_full(arg, &seed, 0) < 0 || seed > UINT_MAX) { > > but that's not a f

[Qemu-devel] [Bug 1379688] [NEW] qemu's monitor and parallel create huge window

2014-10-10 Thread Jirislaby
Public bug reported: I have qemu 2.1. When I try to switch to monitor or parallel0, I get window which is 30 *thousand* pixels in height. It is only gray with no content. This did not happen with previous versions of qemu. Kwin crashes because it cannot handle such a huge window. ** Affects: qem

[Qemu-devel] [Bug 1379688] Re: qemu's monitor and parallel create huge window

2014-10-10 Thread Jirislaby
1.6.0 is good at least. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1379688 Title: qemu's monitor and parallel create huge window Status in QEMU: New Bug description: I have qemu 2.1. When

Re: [Qemu-devel] [PULL 23/28] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct

2014-10-10 Thread Cornelia Huck
On Thu, 9 Oct 2014 12:17:30 +0200 Paolo Bonzini wrote: > From: Eduardo Habkost > > Now that we create an accel object before calling machine_init, we can > simply use the accel object to save all KVMState data, instead of > allocationg KVMState manually. > > Reviewed-by: Paolo Bonzini > Sign

Re: [Qemu-devel] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror'

2014-10-10 Thread Chen Gang
On 10/10/14 15:37, Peter Maydell wrote: > On 10 October 2014 02:54, Chen Gang wrote: >> I use the latest upstream gcc (which pulled from master in 2014-10-0?). >> In my memory (not quite sure), the older version gcc may not notice >> about this warning. > > Hmm. I'll see if I can test with that g

Re: [Qemu-devel] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror'

2014-10-10 Thread Chen Gang
On 10/10/14 16:53, Chen Gang wrote: > On 10/10/14 15:37, Peter Maydell wrote: The reason I'm reluctant to make changes to these files is that they're pulled in from a different upstream project (libvixl) so we should only fix critical problems in them, or it makes new versions h

Re: [Qemu-devel] [PATCH] hw/arm/virt: mark timer in fdt as v8-compatible

2014-10-10 Thread Claudio Fontana
On 09.10.2014 19:04, Peter Maydell wrote: > On 9 October 2014 18:00, Peter Maydell wrote: >> On 26 September 2014 14:09, wrote: >>> From: Claudio Fontana >>> >>> check if the first cpu is an armv8 cpu, and if so, put >>> arm,armv8-timer in the compatible string list. >>> >>> Note that due to th

qemu-devel@nongnu.org

2014-10-10 Thread Fabien Chouteau
On 10/09/2014 05:32 PM, Jiri Gaisler wrote: > > I am a bit against the merge of AHB and APB initialization into > the same function. A grlib system can have any number of AHB and APB > buses, so there really should be a separate init routine per bus > as in the original patch. > I understand you

Re: [Qemu-devel] [PULL 23/28] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct

2014-10-10 Thread Cornelia Huck
On Fri, 10 Oct 2014 10:47:09 +0200 Cornelia Huck wrote: > On Thu, 9 Oct 2014 12:17:30 +0200 > Paolo Bonzini wrote: > > > From: Eduardo Habkost > > > > Now that we create an accel object before calling machine_init, we can > > simply use the accel object to save all KVMState data, instead of

Re: [Qemu-devel] [PULL 23/28] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct

2014-10-10 Thread Gonglei
On 2014/10/10 16:47, Cornelia Huck wrote: > On Thu, 9 Oct 2014 12:17:30 +0200 > Paolo Bonzini wrote: > >> From: Eduardo Habkost >> >> Now that we create an accel object before calling machine_init, we can >> simply use the accel object to save all KVMState data, instead of >> allocationg KVMSt

Re: [Qemu-devel] [PATCH 03/20] target-mips: move common funcs to cpu.h

2014-10-10 Thread Leon Alrae
Hi Yongbok, On 14/07/2014 10:55, Yongbok Kim wrote: > +#include "exec/cpu_ldst.h" > + > +#if defined(CONFIG_USER_ONLY) > +#define HELPER_LD(name, insn, type) \ > +static inline type do_##name(CPUMIPSState *env, target_ulong addr, \ > +

Re: [Qemu-devel] [PATCH] rbd: Add support for bdrv_invalidate_cache

2014-10-10 Thread Stefan Hajnoczi
On Thu, Oct 09, 2014 at 11:44:32AM -0700, adamcr...@gmail.com wrote: > From: Adam Crume > > This fixes Ceph issue 2467. A link would be nice: http://tracker.ceph.com/issues/2467 Reviewed-by: Stefan Hajnoczi pgp3sp0dG3nsA.pgp Description: PGP signature

Re: [Qemu-devel] [PATCH 04/20] target-mips: add 8, 16, 32, 64 bits load and store

2014-10-10 Thread Leon Alrae
On 14/07/2014 10:55, Yongbok Kim wrote: > add 8, 16, 32, 64 bits load and store > > Signed-off-by: Yongbok Kim > --- > target-mips/cpu.h |8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/target-mips/cpu.h b/target-mips/cpu.h > index 68ce383..51d1c88 100644 > -

Re: [Qemu-devel] [PATCH 06/20] target-mips: add MSA opcode enum

2014-10-10 Thread Leon Alrae
On 14/07/2014 10:55, Yongbok Kim wrote: > add MSA opcode enum > > Signed-off-by: Yongbok Kim > --- > target-mips/translate.c | 248 > +++ > 1 files changed, 248 insertions(+), 0 deletions(-) > > diff --git a/target-mips/translate.c b/target-mips/tra

Re: [Qemu-devel] [PATCH 08/20] target-mips: add msa_helper.c

2014-10-10 Thread Leon Alrae
On 14/07/2014 10:55, Yongbok Kim wrote: > add msa_helper.c > > Signed-off-by: Yongbok Kim > --- > target-mips/Makefile.objs |2 +- > target-mips/msa_helper.c | 196 > + > 2 files changed, 197 insertions(+), 1 deletions(-) > create mode 100644 t

[Qemu-devel] netperf performance drop from Virtual machine

2014-10-10 Thread Raj Ravi
Hi, I am observing issues with UDP performance issues (with UFO on) from inside KVM based VM. setup details: 1. In the Host (say Host1): ifconfig eth0 0 ifconfig bond0 up ifenslave bond0 eth0 brctl addbr br0 brctl addif br0 bond0 ifconfig br0 Now, br0 bridge is used for network interface in

[Qemu-devel] [Bug 1379688] Re: qemu's monitor and parallel create huge window

2014-10-10 Thread Jirislaby
2.1 is OK with vte 2.90, not with 2.91 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1379688 Title: qemu's monitor and parallel create huge window Status in QEMU: New Bug description: I have

Re: [Qemu-devel] [PULL 23/28] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct

2014-10-10 Thread Paolo Bonzini
Il 10/10/2014 11:11, Cornelia Huck ha scritto: > On Fri, 10 Oct 2014 10:47:09 +0200 > Cornelia Huck wrote: > >> On Thu, 9 Oct 2014 12:17:30 +0200 >> Paolo Bonzini wrote: >> >>> From: Eduardo Habkost >>> >>> Now that we create an accel object before calling machine_init, we can >>> simply use t

Re: [Qemu-devel] [PULL 23/28] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct

2014-10-10 Thread Cornelia Huck
On Fri, 10 Oct 2014 12:09:14 +0200 Paolo Bonzini wrote: > Il 10/10/2014 11:11, Cornelia Huck ha scritto: > > On Fri, 10 Oct 2014 10:47:09 +0200 > > Cornelia Huck wrote: > > > >> On Thu, 9 Oct 2014 12:17:30 +0200 > >> Paolo Bonzini wrote: > >> > >>> From: Eduardo Habkost > >>> > >>> Now that

[Qemu-devel] [PATCH build-fix] kvm fix compilation with GCC 4.3.4

2014-10-10 Thread Paolo Bonzini
As usual, SLES11's GCC complained about double typedefs: /home/cohuck/git/qemu/kvm-all.c:110: error: redefinition of typedef ‘KVMState’ /home/cohuck/git/qemu/include/sysemu/kvm.h:161: error: previous declaration of ‘KVMState’ was here Reported-by: Cornelia Huck Tested-by: Cornelia Huck Signed-

Re: [Qemu-devel] qemu is missing monitor

2014-10-10 Thread Jiri Slaby
On 10/10/2014, 09:38 AM, Gerd Hoffmann wrote: > On Do, 2014-10-09 at 17:05 +0100, Peter Maydell wrote: >> On 9 October 2014 14:37, Jiri Slaby wrote: >>> Hi guys, >>> >>> qemu in opensuse latest (factory) does not have monitor. Despite >>> libvte-devel is installed, it is not detected by qemu. The

Re: [Qemu-devel] [PATCH v5 0/7] ARM: add PSCI 0.2 support in TCG mode

2014-10-10 Thread Ard Biesheuvel
On 9 October 2014 16:30, Peter Maydell wrote: > This series adds PSCI support to ARM and AArch64 system emulation > when running in TCG mode. It's an update of the patchsent Ard > sent out earlier in September which in turn is based on work > by Rob Herring. > > Changes v5->v6: > * minor rebasing

Re: [Qemu-devel] [PATCH v5 0/7] ARM: add PSCI 0.2 support in TCG mode

2014-10-10 Thread Peter Maydell
On 10 October 2014 11:42, Ard Biesheuvel wrote: > Thanks for picking this up while I was away. I have tested your > version of the series, and my test cases still appear to work > correctly. Do you see the odd behaviour after guest reset for 32 bit SMP cores? > However, we still haven't addresse

[Qemu-devel] [PATCH v2] qemu-log: add log category for MMU info

2014-10-10 Thread Antony Pavlov
Running barebox on qemu-system-mips* with '-d unimp' overloads stderr by very very many mips_cpu_handle_mmu_fault() messages: mips_cpu_handle_mmu_fault address=b80003fd ret 0 physical 180003fd prot 3 mips_cpu_handle_mmu_fault address=a0800884 ret 0 physical 00800884 prot 3

Re: [Qemu-devel] [PATCH v5 0/7] ARM: add PSCI 0.2 support in TCG mode

2014-10-10 Thread Ard Biesheuvel
On 10 October 2014 12:56, Peter Maydell wrote: > On 10 October 2014 11:42, Ard Biesheuvel wrote: >> Thanks for picking this up while I was away. I have tested your >> version of the series, and my test cases still appear to work >> correctly. > > Do you see the odd behaviour after guest reset for

Re: [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users

2014-10-10 Thread Amit Shah
On (Thu) 09 Oct 2014 [14:04:53], Peter Maydell wrote: > On 9 October 2014 13:17, Amit Shah wrote: > > On (Thu) 09 Oct 2014 [13:18:16], Markus Armbruster wrote: > >> The code should work, but whether it makes sense is hard to judge for > >> virtio noobs like me without a user of guest_writable. Th

Re: [Qemu-devel] [PATCH build-fix] kvm fix compilation with GCC 4.3.4

2014-10-10 Thread Christian Borntraeger
Am 10.10.2014 12:23, schrieb Paolo Bonzini: > As usual, SLES11's GCC complained about double typedefs: RHEL 6.5 gcc 4.4.7 complains as well. :-) This fix helps there as well. > > /home/cohuck/git/qemu/kvm-all.c:110: error: redefinition of typedef ‘KVMState’ > /home/cohuck/git/qemu/include/sysem

Re: [Qemu-devel] [PATCH v5 0/7] ARM: add PSCI 0.2 support in TCG mode

2014-10-10 Thread Peter Maydell
On 10 October 2014 12:02, Ard Biesheuvel wrote: > On 10 October 2014 12:56, Peter Maydell wrote: >> Do you see the odd behaviour after guest reset for 32 >> bit SMP cores? >> > > I will try to reproduce it. I haven't tried, and I wasn't aware that > SMP on TCG is supposed to be stable now otherwi

Re: [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users

2014-10-10 Thread Peter Maydell
On 10 October 2014 12:19, Amit Shah wrote: > On (Thu) 09 Oct 2014 [14:04:53], Peter Maydell wrote: >> What I would like to see in this patch is a comment giving >> much clearer definition of the semantics of the guest_writable >> call: for instance, is it always called when the guest is >> writabl

Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64

2014-10-10 Thread Peter Maydell
On 10 October 2014 05:22, Amanieu d'Antras wrote: > On AArch64 the si_addr field of siginfo_t is truncated to 32 bits > because the fault address passes through an uint32_t variable. This > is fixed by changing the variable to uint64_t. > > Signed-off-by: Amanieu d'Antras > --- > linux-user/main

Re: [Qemu-devel] [PATCH v1 7/8] throttle: Add throttle group support

2014-10-10 Thread Benoît Canet
On Thu, Oct 09, 2014 at 04:58:22PM +0800, Fam Zheng wrote: > On Wed, 10/08 11:05, Benoît Canet wrote: > > On Wed, Oct 08, 2014 at 02:53:38PM +0800, Fam Zheng wrote: > > > > > > Does this mean that after this series, all the throttle_states must be > > > contained inside its own throttle group? If

[Qemu-devel] [PATCH v2] hw/arm/boot: register cpu reset handlers if using -bios

2014-10-10 Thread Ard Biesheuvel
Move the registering of CPU reset handlers to before the point where we leave the function in the -bios (not -kernel) case, so CPU reset works correctly with -bios as well. Signed-off-by: Ard Biesheuvel --- hw/arm/boot.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --

[Qemu-devel] [patch] qemu educational device

2014-10-10 Thread Jiri Slaby
Hello guys, I am using qemu for teaching the Linux kernel at our university. I wrote a simple PCI device that can answer to writes/reads, generate interrupts and perform DMA. As I am dragging it locally over 2 years, would you be interested in including it upstream? thanks, -- js suse labs tra

[Qemu-devel] [question] Is there a plan to introduce a unified co-scheduling mechanism to CFS ?

2014-10-10 Thread Zhang Haoyu
Hi, Is it worthy to introduce a unified co-scheduling mechanism to CFS ? Because multiple cooperating threads or tasks frequently synchronize with each other, not executing them concurrently would only increase the latency of synchronization. For example, a thread blocking in spinlock to waitin

[Qemu-devel] [PATCH v6 2/2] Tests: QEMUSizedBuffer/QEMUBuffer

2014-10-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Modify some of tests/test-vmstate.c to use the in memory file based on QEMUSizedBuffer to provide basic testing of QEMUSizedBuffer and the associated memory backed QEMUFile type. Only some of the tests are changed so that the fd backed QEMUFile is still tested. Si

[Qemu-devel] [PATCH v6 1/2] QEMUSizedBuffer based QEMUFile

2014-10-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This is based on Stefan and Joel's patch that creates a QEMUFile that goes to a memory buffer; from: http://lists.gnu.org/archive/html/qemu-devel/2013-03/msg05036.html Using the QEMUFile interface, this patch adds support functions for operating on in-memory sized

Re: [Qemu-devel] [PATCH v5 0/7] ARM: add PSCI 0.2 support in TCG mode

2014-10-10 Thread Ard Biesheuvel
On 10 October 2014 13:22, Peter Maydell wrote: > On 10 October 2014 12:02, Ard Biesheuvel wrote: >> On 10 October 2014 12:56, Peter Maydell wrote: >>> Do you see the odd behaviour after guest reset for 32 >>> bit SMP cores? >>> >> >> I will try to reproduce it. I haven't tried, and I wasn't awar

Re: [Qemu-devel] [PATCH 1/2] raw-posix: Fix raw_co_get_block_status() after EOF

2014-10-10 Thread Benoît Canet
The Monday 22 Sep 2014 à 17:23:44 (+0200), Max Reitz wrote : > As its comment states, raw_co_get_block_status() should unconditionally > return 0 and set *pnum to 0 for after EOF. > > An assertion after lseek(..., SEEK_HOLE) tried to catch this case by > asserting that errno != -ENXIO (which would

Re: [Qemu-devel] [PATCH 1/3] qmp: Add command 'blockdev-backup'

2014-10-10 Thread Markus Armbruster
Fam Zheng writes: > Similar to drive-backup, but this command uses a device id as target > instead of creating/opening an image file. > > Also add blocker on target bs, since the target is also a named device > now. > > Add check and report error for bs == target which became possible but is > an

Re: [Qemu-devel] [PATCH 2/3] block: Add blockdev-backup to transaction

2014-10-10 Thread Markus Armbruster
I'm not familiar with transactions, so all I can do is match your code against the DriveBackup action. Passes that sanity check.

Re: [Qemu-devel] [patch] qemu educational device

2014-10-10 Thread Paolo Bonzini
Il 10/10/2014 13:37, Jiri Slaby ha scritto: > Hello guys, > > I am using qemu for teaching the Linux kernel at our university. I wrote > a simple PCI device that can answer to writes/reads, generate interrupts > and perform DMA. As I am dragging it locally over 2 years, would you be > interested i

Re: [Qemu-devel] [PATCH 1/3] block: Ignore allocation size in underlying file

2014-10-10 Thread Benoît Canet
The Saturday 16 Aug 2014 à 20:54:16 (+0200), Max Reitz wrote : > When falling through to the underlying file in > bdrv_co_get_block_status(), do not let the number of sectors for which > information could be obtained be overwritten. > > Signed-off-by: Max Reitz > --- > block.c | 6 -- > 1 fi

[Qemu-devel] [PATCH v6 0/2] In memory QEMUFile

2014-10-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This patch-pair adds the QEMUSizedBuffer based in-memory QEMUFile written by Stefan Berger and Joel Schopp. I've made some fixes and modified the existing test-vmstate to use it for some test cases. While there's nothing other than test cases using it yet, I t

Re: [Qemu-devel] [question] Is there a plan to introduce a unified co-scheduling mechanism to CFS ?

2014-10-10 Thread Zhang Haoyu
>> Hi, >> >> Is it worthy to introduce a unified co-scheduling mechanism to CFS ? >> Because multiple cooperating threads or tasks frequently synchronize with each other, >> not executing them concurrently would only increase the latency of synchronization. >> For example, a thread blocking in s

Re: [Qemu-devel] [PATCH 2/3] qemu-io: Respect early image end for map

2014-10-10 Thread Benoît Canet
> +} else if (!num) { > +error_report("Unexpected end of image"); > +return 0; I think this test can miss some case of Unexpected end of image. For example supose that in map_is_allocated the first bdrv_is_allocated actually succeed then *pnum = num. Then the botto

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test blockdev-backup in 055

2014-10-10 Thread Markus Armbruster
Fam Zheng writes: > This applies cases on drive-backup on blockdev-backup, except cases with > target format and mode. > > Also add a case to check source == target. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/055 | 277 > ++--- > tests/q

Re: [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users

2014-10-10 Thread Amit Shah
On (Fri) 10 Oct 2014 [12:23:21], Peter Maydell wrote: > On 10 October 2014 12:19, Amit Shah wrote: > > On (Thu) 09 Oct 2014 [14:04:53], Peter Maydell wrote: > >> What I would like to see in this patch is a comment giving > >> much clearer definition of the semantics of the guest_writable > >> call

Re: [Qemu-devel] [PATCH v5 01/11] qcow2: Calculate refcount block entry count

2014-10-10 Thread Benoît Canet
On Fri, Aug 29, 2014 at 11:40:53PM +0200, Max Reitz wrote: > The size of a refblock entry is (in theory) variable; calculate > therefore the number of entries per refblock and the according bit shift > (1 << x == entry count) when opening an image. > > Signed-off-by: Max Reitz > --- > block/qcow

Re: [Qemu-devel] [PATCH v12 03/14] qcow2: Optimize bdrv_make_empty()

2014-10-10 Thread Eric Blake
On 08/26/2014 03:36 PM, Max Reitz wrote: > bdrv_make_empty() is currently only called if the current image > represents an external snapshot that has been committed to its base > image; it is therefore unlikely to have internal snapshots. In this > case, bdrv_make_empty() can be greatly sped up by

Re: [Qemu-devel] [PATCH v5 08/11] qcow2: Rebuild refcount structure during check

2014-10-10 Thread Benoît Canet
> +*nb_clusters = cluster + cluster_count - contiguous_free_clusters; > +*refcount_table = g_try_realloc(*refcount_table, > +*nb_clusters * sizeof(uint16_t)); Something tells me that these sizeof(uint16_t) are connected to s->refcount_order

[Qemu-devel] [PATCH 1/1] pci-host: add educational driver

2014-10-10 Thread Jiri Slaby
I am using qemu for teaching the Linux kernel at our university. I wrote a simple PCI device that can answer to writes/reads, generate interrupts and perform DMA. As I am dragging it locally over 2 years, I am sending it to you now. Signed-off-by: Jiri Slaby --- MAINTAINERS | 5 +

Re: [Qemu-devel] [PATCH V2] net: don't use set/get_pointer() in set/get_netdev()

2014-10-10 Thread Markus Armbruster
Jason Wang writes: > Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue > support) tries to use set_pointer() and get_pointer() to set and get > NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This > trick works but result a unclean and fragile implementation (e.g > p

[Qemu-devel] [PULL v2 0/8] s390x patches for 2.2

2014-10-10 Thread Cornelia Huck
for-upstream' into staging (2014-10-09 15:09:05 +0100) are available in the git repository at: git://github.com/cohuck/qemu.git tags/s390x-20141010 for you to fetch changes up to 4b7757bae7c94f980969031119db12d540cf2b61: s390x/virtio-ccw: fix vhost-scsi intialization (20

[Qemu-devel] [PULL v2 2/8] s390x/kvm: introduce proper states for s390 cpus

2014-10-10 Thread Cornelia Huck
From: David Hildenbrand Until now, when a s390 cpu was stopped or halted, the number of running CPUs was tracked in a global variable. This was problematic for migration, so Jason came up with a per-cpu running state. As it turns out, we want to track the full logical state of a target vcpu, so w

[Qemu-devel] [PULL v2 6/8] s390x/kvm: synchronize the cpu state after SIGP (INITIAL) CPU RESET

2014-10-10 Thread Cornelia Huck
From: David Hildenbrand We need to synchronize registers after a reset has been performed. The current code does that in qemu_system_reset(), load_normal_reset() and modified_clear_reset() for all vcpus. After SIGP (INITIAL) CPU RESET, this needs to be done for the targeted vcpu as well, so let's

[Qemu-devel] [PULL v2 5/8] s390x/kvm: reuse kvm_s390_reset_vcpu() to get rid of ifdefs

2014-10-10 Thread Cornelia Huck
From: David Hildenbrand This patch reuses kvm_s390_reset_vcpu() to get rid of some CONFIG_KVM and CONFIG_USER_ONLY ifdefs in cpu.c. In order to get rid of CONFIG_USER_ONLY, kvm_s390_reset_vcpu() has to provide a dummy implementation - the two definitions are moved to the proper section in cpu.h.

[Qemu-devel] [PULL v2 4/8] s390x/kvm: propagate s390 cpu state to kvm

2014-10-10 Thread Cornelia Huck
From: David Hildenbrand Let QEMU propagate the cpu state to kvm. If kvm doesn't yet support it, it is silently ignored as kvm will still handle the cpu state itself in that case. The state is not synced back, thus kvm won't have a chance to actively modify the cpu state. To do so, control has to

[Qemu-devel] [PULL v2 1/8] linux-headers: update to 3.17-rc7

2014-10-10 Thread Cornelia Huck
From: Jens Freimann Sync headers with 3.17-rc7 Acked-by: Paolo Bonzini Signed-off-by: Jens Freimann Signed-off-by: Cornelia Huck --- linux-headers/asm-mips/kvm_para.h |6 +- linux-headers/asm-powerpc/kvm.h |2 ++ linux-headers/asm-x86/kvm.h |3 +++ linux-headers/linux

[Qemu-devel] [PULL v2 3/8] s390x/kvm: proper use of the cpu states OPERATING and STOPPED

2014-10-10 Thread Cornelia Huck
From: David Hildenbrand This patch makes sure that halting a cpu and stopping a cpu are two different things. Stopping a cpu will also set the cpu halted - this is needed for common infrastructure to work (note that the stop and stopped flag cannot be used for our purpose because they are already

[Qemu-devel] [PULL v2 8/8] s390x/virtio-ccw: fix vhost-scsi intialization

2014-10-10 Thread Cornelia Huck
The vhost-scsi-ccw backend is of type VHostSCSICcw, not VirtIOSCSICcw. This fixes a segfault when invoking qemu-system-s390x -device vhost-scsi-ccw,? Reviewed-by: Thomas Huth Tested-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c |2 +- 1 file changed

[Qemu-devel] [PULL v2 7/8] s390x/migration: migrate CPU state

2014-10-10 Thread Cornelia Huck
From: Thomas Huth This patch provides the cpu save information for dumps and later life migration and enables migration of the CPU state. The code is based on earlier work from Christian Borntraeger and Jason Herne. Signed-off-by: Thomas Huth Signed-off-by: David Hildenbrand [provide cpu_post_

Re: [Qemu-devel] [question] Is there a plan to introduce a unified co-scheduling mechanism to CFS ?

2014-10-10 Thread Wanpeng Li
于 10/10/14, 7:37 PM, Zhang Haoyu 写道: Hi, Is it worthy to introduce a unified co-scheduling mechanism to CFS ? Because multiple cooperating threads or tasks frequently synchronize with each other, not executing them concurrently would only increase the latency of synchronization. For example,

Re: [Qemu-devel] [RFC][PATCH v2x prototype 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-10 Thread Stefano Stabellini
On Thu, 9 Oct 2014, Don Slutz wrote: > This adds synchronisation of the 6 vcpu registers (only 32bits of > them) that vmport.c needs between Xen and QEMU. > > This is to avoid a 2nd and 3rd exchange between QEMU and Xen to > fetch and put these 6 vcpu registers used by the code in vmport.c > and v

Re: [Qemu-devel] [PATCH build-fix] kvm fix compilation with GCC 4.3.4

2014-10-10 Thread Peter Maydell
On 10 October 2014 11:23, Paolo Bonzini wrote: > As usual, SLES11's GCC complained about double typedefs: > > /home/cohuck/git/qemu/kvm-all.c:110: error: redefinition of typedef ‘KVMState’ > /home/cohuck/git/qemu/include/sysemu/kvm.h:161: error: previous declaration > of ‘KVMState’ was here > > R

[Qemu-devel] [PATCH] Xen: Use the ioreq-server API when available

2014-10-10 Thread Paul Durrant
The ioreq-server API added to Xen 4.5 offers better security than the existing Xen/QEMU interface because the shared pages that are used to pass emulation request/results back and forth are removed from the guest's memory space before any requests are serviced. This prevents the guest from mapping

Re: [Qemu-devel] [RFC][PATCH v2x prototype 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-10 Thread Don Slutz
On 10/10/14 09:44, Stefano Stabellini wrote: On Thu, 9 Oct 2014, Don Slutz wrote: This adds synchronisation of the 6 vcpu registers (only 32bits of them) that vmport.c needs between Xen and QEMU. This is to avoid a 2nd and 3rd exchange between QEMU and Xen to fetch and put these 6 vcpu register

Re: [Qemu-devel] [PATCH 09/20] target-mips: add MSA branch instructions

2014-10-10 Thread Leon Alrae
On 14/07/2014 10:55, Yongbok Kim wrote: > add MSA branch instructions > > Signed-off-by: Yongbok Kim > --- > target-mips/translate.c | 107 > ++- > 1 files changed, 105 insertions(+), 2 deletions(-) > > diff --git a/target-mips/translate.c b/target-

Re: [Qemu-devel] [PATCH] Xen: Use the ioreq-server API when available

2014-10-10 Thread Stefano Stabellini
On Fri, 10 Oct 2014, Paul Durrant wrote: > The ioreq-server API added to Xen 4.5 offers better security than > the existing Xen/QEMU interface because the shared pages that are > used to pass emulation request/results back and forth are removed > from the guest's memory space before any requests ar

Re: [Qemu-devel] [PATCH v2] qemu-log: add log category for MMU info

2014-10-10 Thread Peter Maydell
On 10 October 2014 11:59, Antony Pavlov wrote: > Running barebox on qemu-system-mips* with '-d unimp' overloads > stderr by very very many mips_cpu_handle_mmu_fault() messages: > > mips_cpu_handle_mmu_fault address=b80003fd ret 0 physical 180003fd > prot 3 > mips_cpu_handle_mmu_fault

Re: [Qemu-devel] [PATCH] Xen: Use the ioreq-server API when available

2014-10-10 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 10 October 2014 15:40 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Michael S. > Tsirkin; Stefano Stabellini; Peter Maydell; Paolo Bonzini; Michael Tokarev; >

Re: [Qemu-devel] [PATCH 1/1] pci-host: add educational driver

2014-10-10 Thread Claudio Fontana
Hello, On 10.10.2014 14:09, Jiri Slaby wrote: > I am using qemu for teaching the Linux kernel at our university. I > wrote a simple PCI device that can answer to writes/reads, generate > interrupts and perform DMA. As I am dragging it locally over 2 years, > I am sending it to you now. > > Signed

Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64

2014-10-10 Thread Claudio Fontana
On 10.10.2014 13:32, Peter Maydell wrote: > On 10 October 2014 05:22, Amanieu d'Antras wrote: >> On AArch64 the si_addr field of siginfo_t is truncated to 32 bits >> because the fault address passes through an uint32_t variable. This >> is fixed by changing the variable to uint64_t. >> >> Signed-o

Re: [Qemu-devel] [PATCH v2] hw/arm/boot: register cpu reset handlers if using -bios

2014-10-10 Thread Peter Maydell
On 10 October 2014 12:35, Ard Biesheuvel wrote: > Move the registering of CPU reset handlers to before the point where > we leave the function in the -bios (not -kernel) case, so CPU reset > works correctly with -bios as well. > > Signed-off-by: Ard Biesheuvel > --- > hw/arm/boot.c | 12 ++--

Re: [Qemu-devel] [PATCH] Xen: Use the ioreq-server API when available

2014-10-10 Thread Paolo Bonzini
Il 10/10/2014 16:52, Paul Durrant ha scritto: >> -Original Message- >> From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] >> Sent: 10 October 2014 15:40 >> To: Paul Durrant >> Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Michael S. >> Tsirkin; Stefano Stabellin

[Qemu-devel] [PATCH v3] hw/arm/boot: register cpu reset handlers if using -bios

2014-10-10 Thread Ard Biesheuvel
Move the registering of CPU reset handlers to before the point where we leave the function in the -bios (not -kernel) case, so CPU reset works correctly with -bios as well. Signed-off-by: Ard Biesheuvel --- Changes since v2: - split into two loops again, as the boot_info field must not be assign

Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64

2014-10-10 Thread Peter Maydell
On 10 October 2014 15:58, Claudio Fontana wrote: > On 10.10.2014 13:32, Peter Maydell wrote: >> Thanks for catching this. Better to fix it by dropping >> the unnecessary local variable completely and just setting >> info._sifields._sigfault._addr = env->exception.vaddress; >> at the only point w

Re: [Qemu-devel] [PATCH v12 03/14] qcow2: Optimize bdrv_make_empty()

2014-10-10 Thread Eric Blake
On 10/10/2014 06:32 AM, Eric Blake wrote: > On 08/26/2014 03:36 PM, Max Reitz wrote: >> bdrv_make_empty() is currently only called if the current image >> represents an external snapshot that has been committed to its base >> image; it is therefore unlikely to have internal snapshots. In this >> ca

[Qemu-devel] [PATCH v6 04/32] target-arm: rename arm_current_pl to arm_current_el

2014-10-10 Thread Greg Bellows
Renamed the arm_current_pl CPU function to more accurately represent that it returns the ARMv8 EL rather than ARMv7 PL. Signed-off-by: Greg Bellows == v5 -> v6 - Renamed DisasContext current_pl field to current_el - Added comment to arm_current_el on handling v7 PL - Fixed comments refe

[Qemu-devel] [PATCH v6 05/32] target-arm: make arm_current_el() return EL3

2014-10-10 Thread Greg Bellows
From: Fabian Aggeler Make arm_current_el() return EL3 for secure PL1 and monitor mode. Increase MMU modes since mmu_index is directly infered from arm_ current_el(). Changes assertion in arm_el_is_aa64() to allow EL3. Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows == v5 ->

[Qemu-devel] [PATCH v6 02/32] target-arm: add arm_is_secure() function

2014-10-10 Thread Greg Bellows
From: Fabian Aggeler arm_is_secure() function allows to determine CPU security state if the CPU implements Security Extensions/EL3. arm_is_secure_below_el3() returns true if CPU is in secure state below EL3. Signed-off-by: Sergey Fedorov Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellow

[Qemu-devel] [PATCH v6 03/32] target-arm: reject switching to monitor mode

2014-10-10 Thread Greg Bellows
From: Sergey Fedorov Reject switching to monitor mode from non-secure state. Signed-off-by: Sergey Fedorov Signed-off-by: Fabian Aggeler Reviewed-by: Edgar E. Iglesias Signed-off-by: Greg Bellows --- target-arm/helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-arm/helper

[Qemu-devel] [PATCH v6 00/32] target-arm: add Security Extensions for CPUs

2014-10-10 Thread Greg Bellows
Version 6 of the ARM processor security extension (TrustZone) support. This patchset includes changes to support the processor security extensions on ARMv7 aarch32 with hooks for later enabling v8 aarch64/32. Summary of generic changes from v5 -> v6: - Removed patch v5 32/33 (add GDB scr register)

[Qemu-devel] [PATCH v6 01/32] target-arm: increase arrays of registers R13 & R14

2014-10-10 Thread Greg Bellows
From: Fabian Aggeler Increasing banked_r13 and banked_r14 to store LR_mon and SP_mon (bank index 7). Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows == v5 -> v6 - Updated vmstate_arm_cpu versioning from 20 to 21 --- target-arm/cpu.h | 4 ++-- target-arm/machine.c | 8 +

[Qemu-devel] [PATCH v6 08/32] target-arm: add async excp target_el function

2014-10-10 Thread Greg Bellows
From: Fabian Aggeler Adds a dedicated function for IRQ and FIQ exceptions to determine target_el and mode (AArch32) according to tables in ARM ARMv8 and ARM ARM v7. Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows == v5 -> v6 - Removed unneeded arm_phys_excp_target_el() func

[Qemu-devel] [PATCH v6 17/32] target-arm: add NSACR register

2014-10-10 Thread Greg Bellows
From: Fabian Aggeler Implements NSACR register with corresponding read/write functions for ARMv7 and ARMv8. Signed-off-by: Sergey Fedorov Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows -- v4 -> v5 - Changed to use renamed arm_current_el() --- target-arm/cpu.h| 6

[Qemu-devel] [PATCH v6 06/32] target-arm: A32: Emulate the SMC instruction

2014-10-10 Thread Greg Bellows
From: Fabian Aggeler Implements SMC instruction in AArch32 using the A32 syndrome. When executing SMC instruction from monitor CPU mode SCR.NS bit is reset. Signed-off-by: Sergey Fedorov Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows == v5 -> v6 - Fixed PC offsetting for

[Qemu-devel] [PATCH v6 07/32] target-arm: extend async excp masking

2014-10-10 Thread Greg Bellows
From: Fabian Aggeler This patch extends arm_excp_unmasked() according to ARM ARMv7 and ARM ARMv8 (all EL running in AArch32) and adds comments. If EL3 is using AArch64 IRQ/FIQ masking is ignored in all exception levels other than EL3 if SCR.{FIQ|IRQ} is set to 1 (routed to EL3). Signed-off-by:

[Qemu-devel] [PATCH v6 16/32] target-arm: respect SCR.FW, SCR.AW and SCTLR.NMFI

2014-10-10 Thread Greg Bellows
From: Fabian Aggeler bits when modifying CPSR. Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows --- v3 -> v4 - Fixed up conditions for ignoring CPSR.A/F updates by isolating to v7 and checking for the existence of EL3 and non-existence of EL2. --- target-arm/helper.c |

[Qemu-devel] [PATCH v6 23/32] target-arm: add TCR_EL3 and make TTBCR banked

2014-10-10 Thread Greg Bellows
From: Fabian Aggeler Adds TCR_EL3 system register and makes existing TTBCR banked. Adjust translation functions to use TCR/TTBCR instance depending on CPU state. Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows == v5 -> v6 - Changed _el field variants to be array based v4 -

[Qemu-devel] [PATCH v6 27/32] target-arm: make DFSR banked

2014-10-10 Thread Greg Bellows
From: Fabian Aggeler When EL3 is running in AArch32 (or ARMv7 with Security Extensions) DFSR has a secure and a non-secure instance. Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows --- v3 -> v4 - Reverted esr/dfsr back to array-based notation as a union with v7 naming. -

[Qemu-devel] [PATCH v6 22/32] target-arm: add TTBR0_EL3 and make TTBR0/1 banked

2014-10-10 Thread Greg Bellows
From: Fabian Aggeler Add TTBR0 and maps secure/non-secure instance of ttbr0 and ttbr1 accordingly (translation table base register). Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows == v5 -> v6 - Changed _el field variants to be array based - Merged TTBR# and TTBR#_EL1 regin

[Qemu-devel] [PATCH v6 10/32] target-arm: add non-secure Translation Block flag

2014-10-10 Thread Greg Bellows
From: Sergey Fedorov This patch is based on idea found in patch at git://github.com/jowinter/qemu-trustzone.git f3d955c6c0ed8c46bc0eb10b634201032a651dd2 by Johannes Winter . The TBFLAG captures the SCR NS secure state at the time when a TB is created so the correct bank is accessed on system reg

[Qemu-devel] [PATCH v6 13/32] target-arm: insert AArch32 cpregs twice into hashtable

2014-10-10 Thread Greg Bellows
From: Fabian Aggeler Prepare for cp register banking by inserting every cp register twice, once for secure world and once for non-secure world. Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows == v5 -> v6 - Fixed NS-bit number in the CPREG hash lookup from 27 to 29. - Switch

  1   2   >