On 10 October 2014 15:58, Claudio Fontana <claudio.font...@huawei.com> wrote: > On 10.10.2014 13:32, Peter Maydell wrote: >> Thanks for catching this. Better to fix it by dropping >> the unnecessary local variable completely and just setting >> info._sifields._sigfault._addr = env->exception.vaddress; >> at the only point where we currently use 'addr', though, >> I think.
> We do use the name code pattern in most of the functions of that file, > meaning > > uint32_t / uint64_t / target_ulong addr; > > and then do_something_with_addr(addr); In other functions the variable is used more than once, mostly. (In cases where it is not I would also be happy with cleanup patches which removed it.) -- PMM
