Re: [Qemu-devel] [PATCH v4 11/23] block: Rename BlockDriverAIOCB* to BlockAIOCB*

2014-10-02 Thread Markus Armbruster
Max Reitz writes: > On 30.09.2014 21:25, Markus Armbruster wrote: >> I'll use BlockDriverAIOCB with block backends shortly, and the name is >> going to fit badly there. It's a block layer thing anyway, not just a >> block driver thing. >> >> Signed-off-by: Markus Armbruster >> --- >> block-mi

Re: [Qemu-devel] [PATCH v4 12/23] block: Rename BlockDriverCompletionFunc to BlockCompletionFunc

2014-10-02 Thread Markus Armbruster
Max Reitz writes: > On 30.09.2014 21:25, Markus Armbruster wrote: >> I'll use it with block backends shortly, and the name is going to fit >> badly there. It's a block layer thing anyway, not just a block driver >> thing. >> >> Signed-off-by: Markus Armbruster >> --- >> block.c

Re: [Qemu-devel] [PATCH v4 15/23] hw: Convert from BlockDriverState to BlockBackend, mostly

2014-10-02 Thread Markus Armbruster
Max Reitz writes: > On 30.09.2014 21:25, Markus Armbruster wrote: >> Device models should access their block backends only through the >> block-backend.h API. Convert them, and drop direct includes of >> inappropriate headers. >> >> Just four uses of BlockDriverState are left: >> >> * The Xen pa

[Qemu-devel] [PATCH] configure: Filter out system includes for pixman

2014-10-02 Thread Jan Kiszka
Other packages may provide includes for pixman as well if the host has a devel package installed. Remove them from QEMU_CFLAGS before adding our version to unsure that the right headers are used. Signed-off-by: Jan Kiszka --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [RFC patch 0/6] vfio based pci pass-through for qemu/KVM on s390

2014-10-02 Thread Frank Blaschka
On Wed, Oct 01, 2014 at 11:26:51AM -0600, Alex Williamson wrote: > On Wed, 2014-10-01 at 11:11 +0200, Frank Blaschka wrote: > > On Fri, Sep 26, 2014 at 01:59:40PM -0600, Alex Williamson wrote: > > > On Fri, 2014-09-26 at 08:45 +0200, Frank Blaschka wrote: > > > > On Wed, Sep 24, 2014 at 10:05:57AM

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-10-02 Thread Jan Kiszka
On 2014-09-02 17:11, Michael Roth wrote: > Quoting Markus Armbruster (2014-07-30 06:19:36) >> Paolo Bonzini writes: >> >>> Il 30/07/2014 10:57, Michael S. Tsirkin ha scritto: On Wed, Jul 30, 2014 at 09:01:59AM +0200, Jan Kiszka wrote: > We used to be able to address both the QEMU and the

Re: [Qemu-devel] [PATCH] configure: Filter out system includes for pixman

2014-10-02 Thread Gerd Hoffmann
On Do, 2014-10-02 at 09:14 +0200, Jan Kiszka wrote: > Other packages may provide includes for pixman as well if the host has a > devel package installed. Remove them from QEMU_CFLAGS before adding our > version to unsure that the right headers are used. Hmm, how does that happen? Shouldn't qemu u

[Qemu-devel] [PULL 00/10] vga: cleanups, prepare for endianness switching

2014-10-02 Thread Gerd Hoffmann
ailable in the git repository at: git://git.kraxel.org/qemu tags/pull-vga-20141002-1 for you to fetch changes up to c3b10605147f9113b8b157d7226d3e215184bc0e: vga: Add endian to vmstate (2014-09-30 13:34:09 +0200) vga: cleanup

[Qemu-devel] [PULL 04/10] vga: Remove rgb_to_pixel indirection

2014-10-02 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt We always use rgb_to_pixel32 nowadays. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Gerd Hoffmann Reviewed-by: David Gibson --- hw/display/cirrus_vga.c | 15 +-- hw/display/vga.c| 31 ++- hw/display/vga_int.

[Qemu-devel] [PULL 03/10] vga: Separate LE and BE conversion functions

2014-10-02 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt Provide different functions for converting from an LE vs a BE framebuffer. We cannot rely on the simple cases always being shared surfaces since cirrus will need to always shadow for cursor emulation, so we need the full set of functions to be able to later handle run

[Qemu-devel] [PULL 10/10] vga: Add endian to vmstate

2014-10-02 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt Include the endian state in the migration stream as an optional subsection which we only include when the endian isn't the default, thus enabling backward compatibility of the common case. Signed-off-by: Benjamin Herrenschmidt Changes by kraxel: * Remove bochs dis

[Qemu-devel] [PULL 09/10] vga: Make fb endian a common state variable

2014-10-02 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt And initialize it based on target endian Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Gerd Hoffmann Reviewed-by: David Gibson --- hw/display/vga.c | 32 +++- hw/display/vga_int.h | 1 + 2 files changed, 20 insertions(+), 1

[Qemu-devel] [PULL 06/10] cirrus: Remove non-32bpp cursor drawing

2014-10-02 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt We only draw cursor on non-shared surfaces (so it seems...) and these are always 32bpp Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Gerd Hoffmann Reviewed-by: David Gibson --- hw/display/cirrus_vga.c | 64 +--- hw/display/cir

[Qemu-devel] [PULL 05/10] vga: Simplify vga_draw_blank() a bit

2014-10-02 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt The test for surface_bits_per_pixel() isn't necessary anymore, the 8bpp case never happens. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Gerd Hoffmann Reviewed-by: David Gibson --- hw/display/vga.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletio

[Qemu-devel] [PULL 01/10] vga: Start cutting out non-32bpp conversion support

2014-10-02 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt Nowadays, we either share a surface with the host, or we create a 32bpp ARGB console surface. So we only need to draw/convert to 32bpp, enabling us to remove all but one instance of vga_template.h inclusion (to be further cleaned up), rgb_to_pixel_* etc... Signed-of

[Qemu-devel] [PULL 07/10] vga: Remove some "should be done in BIOS" comments

2014-10-02 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt Not all platforms have a VGA BIOS, powerpc typically relies on using the DISPI interface to initialize the card. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Gerd Hoffmann Reviewed-by: David Gibson --- hw/display/vga.c | 6 ++ 1 file changed, 2 insert

[Qemu-devel] [PULL 02/10] vga: Remove remainder of old conversion cruft

2014-10-02 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt All the macros used to generate different versions of vga_template.h are now unnecessary, take them all out and remove the _32 suffix from most functions. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Gerd Hoffmann Reviewed-by: David Gibson --- hw/display/

[Qemu-devel] [PULL 08/10] vga: Rename vga_template.h to vga-helpers.h

2014-10-02 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt It's no longer a template, we only instanciate the file once. Keep it a #included file so the functions remain static. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Gerd Hoffmann Reviewed-by: David Gibson --- hw/display/{vga_template.h => vga-helpers.h} |

[Qemu-devel] [PULL 0/1] pixman: fix qemu_default_pixman_format (32bpp non-native endian)

2014-10-02 Thread Gerd Hoffmann
ository at: git://git.kraxel.org/qemu tags/pull-console-20141002-1 for you to fetch changes up to 89ec031b09c81821e349c364575fad652395cf94: pixman: fix qemu_default_pixman_format (32bpp non-native endian) (2014-09-30 13:34:04 +0200) -

[Qemu-devel] [PULL 1/1] pixman: fix qemu_default_pixman_format (32bpp non-native endian)

2014-10-02 Thread Gerd Hoffmann
Bug breaks SDL display of bigendian guests on little endian hosts. Reported-by: BALATON Zoltan Reported-by: Valentin Manea Signed-off-by: Gerd Hoffmann --- ui/qemu-pixman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/qemu-pixman.c b/ui/qemu-pixman.c index 30c7fdd..1f

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 09:27:41AM +0200, Jan Kiszka wrote: > On 2014-09-02 17:11, Michael Roth wrote: > > Quoting Markus Armbruster (2014-07-30 06:19:36) > >> Paolo Bonzini writes: > >> > >>> Il 30/07/2014 10:57, Michael S. Tsirkin ha scritto: > On Wed, Jul 30, 2014 at 09:01:59AM +0200, Jan

[Qemu-devel] [PATCH] configure: Prepend pixman and ftd flags to overrule system-provided ones

2014-10-02 Thread Jan Kiszka
Other packages may provide includes for pixman as well if the host has a devel package installed. So add ours to the front to unsure that the right version is used. Signed-off-by: Jan Kiszka --- Replaces "configure: Filter out system includes for pixman" And, yes, the scenario is too old distro

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-10-02 Thread Jan Kiszka
On 2014-10-02 10:03, Michael S. Tsirkin wrote: > On Thu, Oct 02, 2014 at 09:27:41AM +0200, Jan Kiszka wrote: >> On 2014-09-02 17:11, Michael Roth wrote: >>> Quoting Markus Armbruster (2014-07-30 06:19:36) Paolo Bonzini writes: > Il 30/07/2014 10:57, Michael S. Tsirkin ha scritto: >>>

[Qemu-devel] [PULL 2/2] add input-send-event command

2014-10-02 Thread Gerd Hoffmann
From: Marcelo Tosatti Which allows specification of absolute/relative, up/down and console parameters. Suggested by Gerd Hoffman. Signed-off-by: Marcelo Tosatti Reviewed-by: Eric Blake Signed-off-by: Gerd Hoffmann --- qapi-schema.json | 17 +++ qmp-commands.hx | 63

[Qemu-devel] [PULL 0/2] input patch queue

2014-10-02 Thread Gerd Hoffmann
29' into staging (2014-09-30 11:02:06 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-input-20141002-1 for you to fetch changes up to 50c6617fcbef649674b59f686b12dccfc455ffa3: add input-send-event command (2014-10-02

[Qemu-devel] [PULL 1/2] input: fix send-key monitor command release event ordering

2014-10-02 Thread Gerd Hoffmann
commit 2e377f1730d06deafb3e3ef6cf88792de4a6f4df changed the ordering of the release events as side effect. Some guests are not happy with that and don't recognise ctrl-alt-del any more. This patch restores the old last-pressed first-released behavior. Cc: Amos Kong Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 10:05:38AM +0200, Jan Kiszka wrote: > On 2014-10-02 10:03, Michael S. Tsirkin wrote: > > On Thu, Oct 02, 2014 at 09:27:41AM +0200, Jan Kiszka wrote: > >> On 2014-09-02 17:11, Michael Roth wrote: > >>> Quoting Markus Armbruster (2014-07-30 06:19:36) > Paolo Bonzini writ

Re: [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID

2014-10-02 Thread Gal Hammer
On 01/10/2014 11:58, Markus Armbruster wrote: Did this get stuck? I think so. Did I miss a comment which was not handled in the last version of the patch? Gal. Gal Hammer writes: Hi, A two parts patch to add a QEmu support for Microsoft's Virtual Machine Generation ID device. The

Re: [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 11:32:42AM +0300, Gal Hammer wrote: > On 01/10/2014 11:58, Markus Armbruster wrote: > >Did this get stuck? > > I think so. Did I miss a comment which was not handled in the last version > of the patch? > > Gal. I don't think you did but you have to Cc maintainers if y

Re: [Qemu-devel] pending target-mips patches

2014-10-02 Thread Leon Alrae
Hi Peter, On 01/10/2014 17:32, Peter Maydell wrote: > On 1 October 2014 16:35, Leon Alrae wrote: >> I noticed that it's quite difficult to get target-mips changes >> reviewed/accepted. There is already a queue of relatively big features >> and bug fixes which are stuck for months. Does anyone hav

[Qemu-devel] [RFC PATCH] block/migration: Disable cache invalidate for incoming migration

2014-10-02 Thread Alexey Kardashevskiy
When migrated using libvirt with "--copy-storage-all", at the end of migration there is race between NBD mirroring task trying to do flush and migration completion, both end up invalidating cache. Since qcow2 driver does not handle this situation very well, random crashes happen. This disables the

[Qemu-devel] [PATCH v5 01/23] block: Split bdrv_new_root() off bdrv_new()

2014-10-02 Thread Markus Armbruster
Creating an anonymous BDS can't fail. Make that obvious. Signed-off-by: Markus Armbruster Reviewed-by: Max Reitz Reviewed-by: Benoît Canet Reviewed-by: Kevin Wolf --- block.c | 28 +++- block/iscsi.c | 2 +- block/vvfat.c | 2 +- blockd

[Qemu-devel] [PATCH v5 07/23] block: Eliminate bdrv_iterate(), use bdrv_next()

2014-10-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Benoît Canet Reviewed-by: Max Reitz Reviewed-by: Kevin Wolf --- block-migration.c | 30 +++--- block.c | 9 - blockdev.c| 31 +-- include/block/block.h | 2

[Qemu-devel] [PATCH v5 05/23] block: Code motion to get rid of stubs/blockdev.c

2014-10-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Benoît Canet Reviewed-by: Max Reitz Reviewed-by: Kevin Wolf --- block/block-backend.c | 13 + blockdev.c| 11 --- include/sysemu/blockdev.h | 1 - stubs/Makefile.objs | 1 - stubs/blockdev.c

[Qemu-devel] [PATCH v5 14/23] virtio-blk: Rename VirtIOBlkConf variables to conf

2014-10-02 Thread Markus Armbruster
This is consistent with how VirtIOFOOConf variables are named elsewhere, and makes blk available for BlockBackend variables. Signed-off-by: Markus Armbruster Reviewed-by: Max Reitz --- hw/block/dataplane/virtio-blk.c | 33 ++- hw/block/dataplane/virtio-blk.h | 2 +- hw/

[Qemu-devel] [PATCH v5 13/23] virtio-blk: Drop redundant VirtIOBlock member conf

2014-10-02 Thread Markus Armbruster
Commit 12c5674 turned it into a pointer to member blk.conf. Signed-off-by: Markus Armbruster Reviewed-by: Benoît Canet Reviewed-by: Max Reitz Reviewed-by: Kevin Wolf --- hw/block/virtio-blk.c | 28 ++-- include/hw/virtio/virtio-blk.h | 1 - 2 files changed, 1

[Qemu-devel] [PATCH v5 04/23] block: Connect BlockBackend and DriveInfo

2014-10-02 Thread Markus Armbruster
Make the BlockBackend own the DriveInfo. Change blockdev_init() to return the BlockBackend instead of the DriveInfo. Signed-off-by: Markus Armbruster Reviewed-by: Max Reitz --- block.c | 2 -- block/block-backend.c | 38 ++ blockdev.c

[Qemu-devel] [PATCH v5 02/23] block: New BlockBackend

2014-10-02 Thread Markus Armbruster
A block device consists of a frontend device model and a backend. A block backend has a tree of block drivers doing the actual work. The tree is managed by the block layer. We currently use a single abstraction BlockDriverState both for tree nodes and the backend as a whole. Drawbacks: * Its AP

[Qemu-devel] [PATCH v5 03/23] block: Connect BlockBackend to BlockDriverState

2014-10-02 Thread Markus Armbruster
Convenience function blk_new_with_bs() creates a BlockBackend with its BlockDriverState. Callers have to unref both. The commit after next will relieve them of the need to unref the BlockDriverState. Complication: due to the silly way drive_del works, we need a way to hide a BlockBackend, just l

[Qemu-devel] [PATCH v5 00/23] Split BlockBackend off BDS with an axe

2014-10-02 Thread Markus Armbruster
My last attempt got bogged down because I tried to do a reasonably complete job, and the complexity proved more than I could handle with the limited amount of uninterrupted time available. This time, I'm cutting BlockBackend off with an axe, leaving most of the work for later. Done in this series

[Qemu-devel] [PATCH v5 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-10-02 Thread Markus Armbruster
The patch is big, but all it really does is replacing dinfo->bdrv by blk_bs(blk_by_legacy_dinfo(dinfo)) The replacement is repetitive, but the conversion of device models to BlockBackend is imminent, and will shorten it to just blk_legacy_dinfo(dinfo). Line wrapping muddies the waters

[Qemu-devel] [PATCH v5 09/23] block: Merge BlockBackend and BlockDriverState name spaces

2014-10-02 Thread Markus Armbruster
BlockBackend's name space is separate only to keep the initial patches simple. Time to merge the two. Retain bdrv_find() and bdrv_get_device_name() for now, to keep this series manageable. Signed-off-by: Markus Armbruster Reviewed-by: Max Reitz --- block.c | 48 -

[Qemu-devel] [PATCH v5 18/23] blockdev: Drop superfluous DriveInfo member id

2014-10-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Benoît Canet Reviewed-by: Max Reitz Reviewed-by: Kevin Wolf --- block/block-backend.c | 1 - blockdev.c| 3 +-- include/sysemu/blockdev.h | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/block/block-backend.c

[Qemu-devel] [PATCH v5 06/23] block: Make BlockBackend own its BlockDriverState

2014-10-02 Thread Markus Armbruster
On BlockBackend destruction, unref its BlockDriverState. Replaces the callers' unrefs. This turns the pointer from BlockBackend to BlockDriverState into a strong reference, managed with bdrv_ref() / bdrv_unref(). The back-pointer remains weak. Signed-off-by: Markus Armbruster Reviewed-by: Max

[Qemu-devel] [PATCH v5 21/23] blockdev: Convert qmp_eject(), qmp_change_blockdev() to BlockBackend

2014-10-02 Thread Markus Armbruster
Much more command code needs conversion. I'm converting these now because they're using bdrv_dev_* functions, which I'm about to lift into BlockBackend. Signed-off-by: Markus Armbruster Reviewed-by: Benoît Canet Reviewed-by: Max Reitz Reviewed-by: Kevin Wolf --- blockdev.c | 20 -

[Qemu-devel] [PATCH v5 17/23] pc87312: Drop unused members of PC87312State

2014-10-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Benoît Canet Reviewed-by: Max Reitz Reviewed-by: Kevin Wolf --- include/hw/isa/pc87312.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/hw/isa/pc87312.h b/include/hw/isa/pc87312.h index befc8bd..bf74470 100644 --- a/include/hw/isa/pc

[Qemu-devel] [PATCH v5 08/23] block: Eliminate BlockDriverState member device_name[]

2014-10-02 Thread Markus Armbruster
device_name[] can become non-empty only in bdrv_new_root() and bdrv_move_feature_fields(). The latter is used only to undo damage done by bdrv_swap(). The former is called only by blk_new_with_bs(). Therefore, when a BlockDriverState's device_name[] is non-empty, then it's been created with a Blo

[Qemu-devel] [PATCH v5 20/23] block/qapi: Convert qmp_query_block() to BlockBackend

2014-10-02 Thread Markus Armbruster
Much more command code needs conversion. I start with this one because it's using bdrv_dev_* functions, which I'm about to lift into BlockBackend. While there, give bdrv_query_info() internal linkage. Signed-off-by: Markus Armbruster Reviewed-by: Benoît Canet Reviewed-by: Max Reitz Reviewed-b

[Qemu-devel] [PATCH v5 23/23] block: Make device model's references to BlockBackend strong

2014-10-02 Thread Markus Armbruster
Doesn't make a difference just yet, but it's the right thing to do. Signed-off-by: Markus Armbruster Reviewed-by: Benoît Canet Reviewed-by: Kevin Wolf Reviewed-by: Max Reitz --- block/block-backend.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/block-backend.c b/block/block-bac

[Qemu-devel] [PATCH v5 11/23] block: Rename BlockDriverAIOCB* to BlockAIOCB*

2014-10-02 Thread Markus Armbruster
I'll use BlockDriverAIOCB with block backends shortly, and the name is going to fit badly there. It's a block layer thing anyway, not just a block driver thing. Signed-off-by: Markus Armbruster Reviewed-by: Max Reitz --- block-migration.c | 2 +- block.c | 124 +

[Qemu-devel] [PATCH v5 16/23] ide: Complete conversion from BlockDriverState to BlockBackend

2014-10-02 Thread Markus Armbruster
Add a BlockBackend member to TrimAIOCB, so ide_issue_trim_cb() can use blk_aio_discard() instead of bdrv_aio_discard(). Signed-off-by: Markus Armbruster Reviewed-by: Max Reitz Reviewed-by: Kevin Wolf --- hw/ide/core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH v5 22/23] block: Lift device model API into BlockBackend

2014-10-02 Thread Markus Armbruster
Move device model attachment / detachment and the BlockDevOps device model callbacks and their wrappers from BlockDriverState to BlockBackend. Wrapper calls in block.c change from bdrv_dev_FOO_cb(bs, ...) to if (bs->blk) { bdrv_dev_FOO_cb(bs->blk, ...); } No change, because

[Qemu-devel] [PATCH v5 12/23] block: Rename BlockDriverCompletionFunc to BlockCompletionFunc

2014-10-02 Thread Markus Armbruster
I'll use it with block backends shortly, and the name is going to fit badly there. It's a block layer thing anyway, not just a block driver thing. Signed-off-by: Markus Armbruster Reviewed-by: Max Reitz --- block.c | 30 +++--- block/archipelago.c

[Qemu-devel] [PATCH v5 19/23] blockdev: Fix blockdev-add not to create DriveInfo

2014-10-02 Thread Markus Armbruster
blockdev_init() always creates a DriveInfo, but only drive_new() fills it in. qmp_blockdev_add() leaves it blank. This results in a drive with type = IF_IDE, bus = 0, unit = 0. Screwed up in commit ee13ed1c. Board initialization code looking for IDE drive (0,0) can pick up one of these bogus dr

Re: [Qemu-devel] [RFC PATCH] block/migration: Disable cache invalidate for incoming migration

2014-10-02 Thread Paolo Bonzini
Il 02/10/2014 10:52, Alexey Kardashevskiy ha scritto: > When migrated using libvirt with "--copy-storage-all", at the end of > migration there is race between NBD mirroring task trying to do flush > and migration completion, both end up invalidating cache. Since qcow2 > driver does not handle this

[Qemu-devel] [PATCH 0/2] Here are 2 patches to enable sPAPR NVRAM migration.

2014-10-02 Thread Alexey Kardashevskiy
Please comment. Thanks! Changes: v2: * reworked to always have a copy of NVRAM in RAM and use file only for writes Alexey Kardashevskiy (2): vmstate: Allow dynamic allocation for VBUFFER during migration spapr_nvram: Enable migration hw/nvram/spapr_nvram.c | 81

[Qemu-devel] [PATCH 2/2] spapr_nvram: Enable migration

2014-10-02 Thread Alexey Kardashevskiy
The only case when sPAPR NVRAM migrates now is if is backed by a file and copy-storage migration is performed. In other cases NVRAM does not migrate regardless whether it is backed by a file or not. This enables shadow copy of NVRAM in RAM which is read from a file (if used) and used for reads. Wr

[Qemu-devel] [PATCH 1/2] vmstate: Allow dynamic allocation for VBUFFER during migration

2014-10-02 Thread Alexey Kardashevskiy
This extends use of VMS_ALLOC flag from arrays to VBUFFER as well. This defines VMSTATE_VBUFFER_ALLOC_UINT32 which makes use of VMS_ALLOC and uses uint32_t type for a size. Signed-off-by: Alexey Kardashevskiy --- include/migration/vmstate.h | 11 +++ vmstate.c | 13 +++

[Qemu-devel] [PATCH v2 37/36] qdev: device_del: search for to be unplugged device in 'peripheral' container

2014-10-02 Thread Igor Mammedov
device_add puts every device with 'id' inside of 'peripheral' container using id's value as the last component name. Use it by replacing recursive search on sysbus with path lookup in 'peripheral' container, which could handle both BUS and BUS-less device cases. Signed-off-by: Igor Mammedov ---

Re: [Qemu-devel] [RFC PATCH] block/migration: Disable cache invalidate for incoming migration

2014-10-02 Thread Alexey Kardashevskiy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/02/2014 07:45 PM, Paolo Bonzini wrote: > Il 02/10/2014 10:52, Alexey Kardashevskiy ha scritto: >> When migrated using libvirt with "--copy-storage-all", at the end >> of migration there is race between NBD mirroring task trying to do >> flush and

Re: [Qemu-devel] [PATCH v3 18/21] target-mips: do not allow Status.FR=0 mode in 64-bit FPU

2014-10-02 Thread Yongbok Kim
There is a block of code that modifies CP0_Status_rw_bitmask.CP0St_FR bit to read-writable in the same function. So effectively in case of MIPS64 R6 the bit is now R/W which shouldn't be. You need to modify or merge the code. # if defined(TARGET_MIPS64) /* For MIPS64, init FR bit to 1 if FPU u

Re: [Qemu-devel] [PATCH v3 18/21] target-mips: do not allow Status.FR=0 mode in 64-bit FPU

2014-10-02 Thread Yongbok Kim
Correction: it is not updating the bit but checking the bit. Reviewed-by: Yongbok Kim On 02/10/14 11:21, Yongbok Kim wrote: > There is a block of code that modifies CP0_Status_rw_bitmask.CP0St_FR > bit to read-writable in the same function. > So effectively in case of MIPS64 R6 the bit is now

Re: [Qemu-devel] [PATCH v5 03/23] block: Connect BlockBackend to BlockDriverState

2014-10-02 Thread Kevin Wolf
Am 02.10.2014 um 11:04 hat Markus Armbruster geschrieben: > Convenience function blk_new_with_bs() creates a BlockBackend with its > BlockDriverState. Callers have to unref both. The commit after next > will relieve them of the need to unref the BlockDriverState. > > Complication: due to the sil

Re: [Qemu-devel] [PATCH v5 04/23] block: Connect BlockBackend and DriveInfo

2014-10-02 Thread Kevin Wolf
Am 02.10.2014 um 11:04 hat Markus Armbruster geschrieben: > Make the BlockBackend own the DriveInfo. Change blockdev_init() to > return the BlockBackend instead of the DriveInfo. > > Signed-off-by: Markus Armbruster > Reviewed-by: Max Reitz > @@ -200,11 +202,11 @@ DriveInfo *drive_get_next(Blo

Re: [Qemu-devel] [PATCH 0/2] Here are 2 patches to enable sPAPR NVRAM migration.

2014-10-02 Thread Alexander Graf
On 02.10.14 11:56, Alexey Kardashevskiy wrote: > Please comment. Thanks! > > Changes: > v2: > * reworked to always have a copy of NVRAM in RAM and use file only for writes I like it, please get an ack from Juan on patch 1/2, then I can apply it. Alex

Re: [Qemu-devel] NBD TLS support in QEMU

2014-10-02 Thread Paolo Bonzini
Il 01/10/2014 22:23, Wouter Verhelst ha scritto: > Hi, > > On Fri, Sep 05, 2014 at 03:26:09PM +0200, Wouter Verhelst wrote: >> Tunneling the entire protocol inside an SSL connection doesn't fix that; >> if an attacker is able to hijack your TCP connections and change flags, >> then this attacker i

Re: [Qemu-devel] NBD TLS support in QEMU

2014-10-02 Thread Daniel P. Berrange
On Wed, Oct 01, 2014 at 10:23:26PM +0200, Wouter Verhelst wrote: > Hi, > > On Fri, Sep 05, 2014 at 03:26:09PM +0200, Wouter Verhelst wrote: > > Tunneling the entire protocol inside an SSL connection doesn't fix that; > > if an attacker is able to hijack your TCP connections and change flags, > > t

[Qemu-devel] [Bug 1376675] [NEW] Qemu UI generally broken (both SDL and Gtk)

2014-10-02 Thread ManDay
Public bug reported: With 2.1.2 on FC20 fedora-virt-preview, both the Gtk Interface and the SDL Interface have bugs. The Gtk Interface has only one: Fullscreen is broken, menu remains visible (w GTK3) The SDL interface is completely broken. -no-frame is not respected. Shortcuts don't work (neith

Re: [Qemu-devel] NBD TLS support in QEMU

2014-10-02 Thread Paolo Bonzini
Il 02/10/2014 13:05, Daniel P. Berrange ha scritto: > On Wed, Oct 01, 2014 at 10:23:26PM +0200, Wouter Verhelst wrote: >> Hi, >> >> On Fri, Sep 05, 2014 at 03:26:09PM +0200, Wouter Verhelst wrote: >>> Tunneling the entire protocol inside an SSL connection doesn't fix that; >>> if an attacker is abl

Re: [Qemu-devel] [PATCH v5 03/23] block: Connect BlockBackend to BlockDriverState

2014-10-02 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.10.2014 um 11:04 hat Markus Armbruster geschrieben: >> Convenience function blk_new_with_bs() creates a BlockBackend with its >> BlockDriverState. Callers have to unref both. The commit after next >> will relieve them of the need to unref the BlockDriverState. >> >>

Re: [Qemu-devel] [PATCH v5 04/23] block: Connect BlockBackend and DriveInfo

2014-10-02 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.10.2014 um 11:04 hat Markus Armbruster geschrieben: >> Make the BlockBackend own the DriveInfo. Change blockdev_init() to >> return the BlockBackend instead of the DriveInfo. >> >> Signed-off-by: Markus Armbruster >> Reviewed-by: Max Reitz > >> @@ -200,11 +202,11 @@

Re: [Qemu-devel] [PATCH 1/3] libqos: Remove PCI assumptions in virtio driver

2014-10-02 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 06:24:37PM +0200, Marc Marí wrote: > @@ -60,25 +60,25 @@ static void qvirtio_pci_assign_device(QVirtioDevice *d, > void *data) > *vpcidev = (QVirtioPCIDevice *)d; > } > > -static uint8_t qvirtio_pci_config_readb(QVirtioDevice *d, void *addr) > +static uint8_t qvirti

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Michael S. Tsirkin
On Thu, Sep 18, 2014 at 06:17:48PM +0200, Paolo Bonzini wrote: > In the emergency last-minute patches of QEMU 2.1 we did two things: > > - fixed migration problems from 1.7 or 2.0 to 2.1 due to changes in > ACPI table sizes > > - ensured that future versions will not break migration compatibili

Re: [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID

2014-10-02 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 02:39:50PM +0300, Gal Hammer wrote: > Hi, > > A two parts patch to add a QEmu support for Microsoft's Virtual Machine > Generation ID device. > > The first one add a new ACPI directive which allow to use a 16-bytes > buffer in an ACPI table. This buffer is for storing the

Re: [Qemu-devel] [PATCH 2/3] libqos: Add malloc generic

2014-10-02 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 06:24:38PM +0200, Marc Marí wrote: > This malloc is a basic interface implementation that works for any platform. > It should be replaced in the future for a real malloc implementation for each > of the platforms. > > Signed-off-by: Marc Marí > --- > tests/libqos/malloc-g

Re: [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 03:12:53PM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 17, 2014 at 02:39:50PM +0300, Gal Hammer wrote: > > Hi, > > > > A two parts patch to add a QEmu support for Microsoft's Virtual Machine > > Generation ID device. > > > > The first one add a new ACPI directive which

Re: [Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-10-02 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 02:39:51PM +0300, Gal Hammer wrote: > Add a 16-bytes buffer to allow storing a 128-bit UUID value in an > ACPI table. > > Signed-off-by: Gal Hammer > Reviewed-by: Paolo Bonzini This one looks good. Applied, thanks! > --- > scripts/acpi_extract.py | 23 ++--

Re: [Qemu-devel] [PATCH 2/6] qemu-char: Rework qemu_chr_open_socket() for reconnect

2014-10-02 Thread Paolo Bonzini
Il 01/10/2014 23:09, miny...@acm.org ha scritto: > From: Corey Minyard > > Move all socket configuration to qmp_chardev_open_socket(). > qemu_chr_open_socket_fd() just opens the socket. This is getting ready > for the reconnect code, which will call open_sock_fd() on a reconnect > attempt. > >

Re: [Qemu-devel] [PATCH 4/6] qemu-char: set socket filename to disconnected when not connected

2014-10-02 Thread Paolo Bonzini
Il 01/10/2014 23:09, miny...@acm.org ha scritto: > From: Corey Minyard > > This way we can tell if the socket is connected or not. It also splits > the string conversions out into separate functions to make this more > convenient. > > Signed-off-by: Corey Minyard > Reviewed-by: Paolo Bonzini

Re: [Qemu-devel] [PULL 00/10] vga: cleanups, prepare for endianness switching

2014-10-02 Thread Peter Maydell
;remotes/pmaydell/tags/pull-target-arm-20140929' into staging (2014-09-30 > 11:02:06 +0100) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-vga-20141002-1 > > for you to fetch changes up to c3b10605147f9113b8b157d7226d3e2151

Re: [Qemu-devel] [PATCH 3/3] libqos: Add virtio MMIO support

2014-10-02 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 06:24:39PM +0200, Marc Marí wrote: > +QVirtioMMIODevice *qvirtio_mmio_init_device(uint64_t addr, uint32_t > page_size) > +{ > +QVirtioMMIODevice *dev; > +union { uint32_t magic; char bytes[5]; } magic_value; > +dev = g_malloc0(sizeof(*dev)); > +magic_value.b

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-02 Thread Paolo Bonzini
Il 01/10/2014 23:09, miny...@acm.org ha scritto: > From: Corey Minyard > > Adds a "reconnect" option to socket backends that gives a reconnect > timeout. This only applies to client sockets. If the other end > of a socket closes the connection, qemu will attempt to reconnect > after the given n

Re: [Qemu-devel] [PATCH 0/4] qemu-file: Move QEMUFileOps implementations to separate files

2014-10-02 Thread Eduardo Habkost
On Thu, Oct 02, 2014 at 08:49:12AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > With this, code that uses symbols from qemu-file.c don't need to bring extra > > dependencies because of the actual QEMUFile operation implementations. > > Each case of omitting the "extra dependen

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Paolo Bonzini
Il 02/10/2014 14:11, Michael S. Tsirkin ha scritto: > On Thu, Sep 18, 2014 at 06:17:48PM +0200, Paolo Bonzini wrote: >> In the emergency last-minute patches of QEMU 2.1 we did two things: >> >> - fixed migration problems from 1.7 or 2.0 to 2.1 due to changes in >> ACPI table sizes >> >> - ensured

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-10-02 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 02:39:52PM +0300, Gal Hammer wrote: > Based on Microsoft's sepecifications (paper can be dowloaded from > http://go.microsoft.com/fwlink/?LinkId=260709), add a device > description to the SSDT ACPI table. > > The GUID is set using a new "vmgenid" device. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v5] vmdk: Fix integer overflow in offset calculation

2014-10-02 Thread Stefan Hajnoczi
On Tue, Sep 23, 2014 at 09:56:21AM +0800, Fam Zheng wrote: > This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster > allocation). > > $ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k' > write failed: Invalid argument > > Reported-by: Mark Cave-Ayland > Reviewed-by: M

Re: [Qemu-devel] [PATCH v3 3/6] pc/vl: Add units-per-default-bus property

2014-10-02 Thread Michael S. Tsirkin
On Wed, Oct 01, 2014 at 02:19:26PM -0400, John Snow wrote: > This patch adds the 'units_per_default_bus' property which > allows individual boards to declare their desired > index => (bus,unit) mapping for their default HBA, so that > boards such as Q35 can specify that its default if_ide HBA, > AH

Re: [Qemu-devel] [PATCH v3 5/6] qtest/bios-tables: Correct Q35 command line

2014-10-02 Thread Michael S. Tsirkin
On Wed, Oct 01, 2014 at 02:19:28PM -0400, John Snow wrote: > If the Q35 board types are to begin recognizing > and decoding syntactic sugar for drive/device > declarations, then workarounds found within > the qtests suite need to be adjusted to prevent > any test failures after the fix. > > bios-t

Re: [Qemu-devel] [PATCH v3 6/6] q35/ahci: Pick up -cdrom and -hda options

2014-10-02 Thread Michael S. Tsirkin
On Wed, Oct 01, 2014 at 02:19:29PM -0400, John Snow wrote: > This patch implements the backend for the Q35 board > for us to be able to pick up and use drives defined > by the -cdrom, -hda, or -drive if=ide shorthand options. > > Signed-off-by: John Snow Reviewed-by: Michael S. Tsirkin > ---

Re: [Qemu-devel] [PATCH 0/2] make check-block/qemu-iotests fixes

2014-10-02 Thread Stefan Hajnoczi
On Tue, Sep 30, 2014 at 01:27:08PM +0200, Kevin Wolf wrote: > Kevin Wolf (2): > make check-block: Use default cache modes > qemu-iotests: Fix supported cache modes for 052 > > tests/qemu-iotests-quick.sh | 2 +- > tests/qemu-iotests/052 | 5 +++-- > 2 files changed, 4 insertions(+), 3 de

Re: [Qemu-devel] [PATCH] util: Emancipate id_wellformed() from QemuOpts

2014-10-02 Thread Stefan Hajnoczi
On Tue, Sep 30, 2014 at 01:59:30PM +0200, Markus Armbruster wrote: > +bool id_wellformed(const char *id) > +{ > +int i; > + > +if (!qemu_isalpha(id[0])) { > +return 0; false would be a bit nicer since the other return cases use true/false. pgpWncgsK8jId.pgp Description: PGP signa

Re: [Qemu-devel] IDs in QOM (was: [PATCH] util: Emancipate id_wellformed() from QemuOpts)

2014-10-02 Thread Stefan Hajnoczi
On Wed, Oct 01, 2014 at 02:33:47PM +0200, Markus Armbruster wrote: > Markus Armbruster writes: This discussion seems orthogonal to your patch. But I'm not applying it yet to give more time for discussion/review of the patch. > Is mangling array-ness into the name really a good idea? Isn't this

Re: [Qemu-devel] IDs in QOM

2014-10-02 Thread Andreas Färber
Am 02.10.2014 um 15:21 schrieb Stefan Hajnoczi: > On Wed, Oct 01, 2014 at 02:33:47PM +0200, Markus Armbruster wrote: >> Markus Armbruster writes: > > This discussion seems orthogonal to your patch. But I'm not applying it > yet to give more time for discussion/review of the patch. > >> Is mangl

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 04:14:05PM +0300, Gal Hammer wrote: > On 02/10/2014 15:49, Michael S. Tsirkin wrote: > >On Wed, Sep 17, 2014 at 02:39:52PM +0300, Gal Hammer wrote: > >>Based on Microsoft's sepecifications (paper can be dowloaded from > >>http://go.microsoft.com/fwlink/?LinkId=260709), add a

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Paolo Bonzini
Il 02/10/2014 14:11, Michael S. Tsirkin ha scritto: > Summarizing what you say, there are two issues around ACPI tables: > - linuxboot uses FW CFG to for memory allocations, > seabios ignores that, so they might conflict. > Let's fix either linuxboot or seabios (or both!) > and forget about i

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 03:30:57PM +0200, Paolo Bonzini wrote: > Il 02/10/2014 14:11, Michael S. Tsirkin ha scritto: > > Summarizing what you say, there are two issues around ACPI tables: > > - linuxboot uses FW CFG to for memory allocations, > > seabios ignores that, so they might conflict. > >

Re: [Qemu-devel] [PATCH] util: Emancipate id_wellformed() from QemuOpts

2014-10-02 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Tue, Sep 30, 2014 at 01:59:30PM +0200, Markus Armbruster wrote: >> +bool id_wellformed(const char *id) >> +{ >> +int i; >> + >> +if (!qemu_isalpha(id[0])) { >> +return 0; > > false would be a bit nicer since the other return cases use true/false. Miss

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Paolo Bonzini
Il 02/10/2014 15:41, Michael S. Tsirkin ha scritto: > On Thu, Oct 02, 2014 at 03:30:57PM +0200, Paolo Bonzini wrote: >> These patches do fix John's scenario, but that is not the main issue. >> They are not an _attempt_ to fix it, they just do so more or less by >> chance. Their real purpose is fix

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 03:43:35PM +0200, Paolo Bonzini wrote: > Il 02/10/2014 15:41, Michael S. Tsirkin ha scritto: > > On Thu, Oct 02, 2014 at 03:30:57PM +0200, Paolo Bonzini wrote: > >> These patches do fix John's scenario, but that is not the main issue. > >> They are not an _attempt_ to fix it

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-10-02 Thread Gal Hammer
On 02/10/2014 15:49, Michael S. Tsirkin wrote: On Wed, Sep 17, 2014 at 02:39:52PM +0300, Gal Hammer wrote: Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table. The GUID is set using a n

  1   2   >