Re: [Qemu-devel] [PATCH v2 10/11] vga: Add endian control register

2014-09-30 Thread Gerd Hoffmann
On Di, 2014-09-30 at 10:45 +1000, David Gibson wrote: > On Mon, Sep 29, 2014 at 11:31:11AM +0200, Gerd Hoffmann wrote: > > From: Benjamin Herrenschmidt > > > > Include the endian state in the migration stream as an optional > > subsection which we only include when the endian isn't the default, >

Re: [Qemu-devel] [PATCH v3 12/12] virtio: add a wrapper for virtio-backend initialization

2014-09-30 Thread Cornelia Huck
On Tue, 30 Sep 2014 17:49:44 +0800 wrote: > From: Gonglei > > For better code sharing, add a helper function that handles > reference counting of the virtio backend for virtio proxy devices. > > Cc: Cornelia Huck > Cc: Michael S. Tsirkin > Signed-off-by: Gonglei > --- > hw/s390x/s390-virti

Re: [Qemu-devel] [PATCH v3 23/23] block: Make device model's references to BlockBackend strong

2014-09-30 Thread Kevin Wolf
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: > Doesn't make a difference just yet, but it's the right thing to do. > > Signed-off-by: Markus Armbruster > --- > block/block-backend.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/block/block-backend.c b/

Re: [Qemu-devel] [PATCH 3/3] vga-pci: add qext region to mmio

2014-09-30 Thread Gerd Hoffmann
On Mo, 2014-09-29 at 19:18 +0300, Michael S. Tsirkin wrote: > > +.driver = "VGA",\ > > +.property = "qext",\ > > +.value= "off",\ > > I'd prefer a more friendly name like "qemu-extended-registers". > There's very little documentation for properties besides

Re: [Qemu-devel] [PATCH v2 00/12] virtio: fix virtio child recount in transports

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 10:41:11AM +0200, Paolo Bonzini wrote: > Il 30/09/2014 08:10, arei.gong...@huawei.com ha scritto: > > From: Gonglei > > > > virtio-$device-{pci, s390, ccw} all duplicate the > > qdev properties of their virtio child. This approach does > > not work well with string or poin

Re: [Qemu-devel] [PATCH v3 04/12] virtio/vhost-scsi: fix virtio-scsi/vhost-scsi child refcount in transports

2014-09-30 Thread Cornelia Huck
On Tue, 30 Sep 2014 17:49:36 +0800 wrote: > From: Gonglei > > object_initialize() leaves the object with a refcount of 1. > object_property_add_child() adds its own reference which is dropped > again when the property is deleted. > > The upshot of this is that we always have a refcount >= 1.

Re: [Qemu-devel] [PATCH v3 03/23] block: Connect BlockBackend to BlockDriverState

2014-09-30 Thread Kevin Wolf
Am 30.09.2014 um 12:56 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: > >> The pointer from BlockBackend to BlockDriverState is a strong > >> reference, managed with bdrv_ref() / bdrv_unref(), the back-pointer is > >> a weak

Re: [Qemu-devel] Timer issues with 2.1.1 and migration (was: latest rc: virtio-blk hangs forever after migration)

2014-09-30 Thread Paolo Bonzini
Il 29/09/2014 20:31, Andrey Korolyov ha scritto: >> > >> > Can you get a trace of the guest (echo kvm > >> > /sys/kernel/debug/tracing/set_event; sleep 1s; cp >> > /sys/kernel/debug/tracing/trace /tmp/trace.txt) while it is in the 100% >> > cpu consumption state? >> > >> > Is it otherwise operation

[Qemu-devel] [PATCH 1/2] make check-block: Use default cache modes

2014-09-30 Thread Kevin Wolf
When qemu-iotests only gave a choice between cache=none and cache=writethrough, we picked cache=none because it was the option that would complete the test in finite time. Some tests could only work for one of the two options and would be skipped with cache=none, but that was an acceptable trade-of

[Qemu-devel] [PATCH 0/2] make check-block/qemu-iotests fixes

2014-09-30 Thread Kevin Wolf
Kevin Wolf (2): make check-block: Use default cache modes qemu-iotests: Fix supported cache modes for 052 tests/qemu-iotests-quick.sh | 2 +- tests/qemu-iotests/052 | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) -- 1.8.3.1

[Qemu-devel] [PATCH 2/2] qemu-iotests: Fix supported cache modes for 052

2014-09-30 Thread Kevin Wolf
The requirement for this test case is really "no O_DIRECT", because the temporary snapshot for BDRV_O_SNAPSHOT is created in /tmp, which often is a tmpfs. Commit f210a83c ('qemu-iotests: Add _default_cache_mode and _supported_cache_modes') turned the restriction into writethrough-only, but that's

Re: [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 11:02:34AM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > This patch series based on qom-next tree: > https://github.com/afaerber/qemu-cpu/commits/qom-next > > Add a description field in both ObjectProperty and PropertyInfo struct. > The descriptions can serve

Re: [Qemu-devel] [PATCH] hw/pci/ppc4xx_pci.c: Remove unused pci4xx_cfgaddr_read/write/ops

2014-09-30 Thread Peter Maydell
Ping! thanks -- PMM On 14 September 2014 20:38, Peter Maydell wrote: > The MemoryRegionOps struct pci4xx_cfgaddr_ops and the read and > write functions it references are all unused; remove them. > > Signed-off-by: Peter Maydell > --- > This is rather applying a blunt instrument to the code -- m

[Qemu-devel] [PULL 0/1] audio patch queue

2014-09-30 Thread Gerd Hoffmann
ository at: git://git.kraxel.org/qemu tags/pull-audio-20140930-1 for you to fetch changes up to 133771477c39f3716d9a85609aca0d3e5a77c55c: ac97: register reset via qom (2014-09-29 10:20:05 +0200) ac97: register res

[Qemu-devel] [PULL 1/1] ac97: register reset via qom

2014-09-30 Thread Gerd Hoffmann
So it gets properly unregistered on hot-unplug. Signed-off-by: Gerd Hoffmann --- hw/audio/ac97.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c index 0e22bb9..111ec0e 100644 --- a/hw/audio/ac97.c +++ b/hw/audio/ac97.c @@ -1321,9 +132

Re: [Qemu-devel] [PATCH v2 12/12] virtio: add a wrapper for virtio-backend initialization

2014-09-30 Thread Cornelia Huck
On Tue, 30 Sep 2014 11:17:29 +0200 Paolo Bonzini wrote: > Il 30/09/2014 11:04, Cornelia Huck ha scritto: > > On Tue, 30 Sep 2014 14:10:38 +0800 > > wrote: > > > >> From: Gonglei > >> > >> For better code sharing, add a wrapper help funciton > > > > typo: s/funciton/function/ > > > >> for var

Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 11:02:35AM +0800, arei.gong...@huawei.com wrote: > @@ -552,6 +556,7 @@ static int print_pci_devfn(DeviceState *dev, Property > *prop, char *dest, > PropertyInfo qdev_prop_pci_devfn = { > .name = "int32", Is this name used anywhere? It seems wrong ... > .legacy

[Qemu-devel] Reminder: 2.2 softfreeze tomorrow

2014-09-30 Thread Peter Maydell
Just a reminder that by our schedule for 2.2: http://wiki.qemu.org/Planning/2.2 we enter softfreeze tomorrow (the 1st October), targetting hardfreeze on the 4th November. (Did we forget to announce the schedule earlier? I could have sworn we sent out mail but can't find it in my archives right no

Re: [Qemu-devel] [PATCH v4 5/5] qdev: drop legacy_name from qdev properties

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 11:02:39AM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > The legacy_name is useless now, the better help > information provied by description field of property. provided. Pls run ispell on comments. > > Cc: Paolo Bonzini > Cc: Michael S. Tsirkin > Cc: Mar

Re: [Qemu-devel] [PATCH v3 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-30 Thread Gerd Hoffmann
On Mo, 2014-09-29 at 22:21 -0400, Jan Vesely wrote: > Signed-off-by: Jan Vesely Added them all to the usb queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v4 2/5] qom: add description field in ObjectProperty struct

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 11:02:36AM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > The descriptions can serve as documentation in the code, > and they can be used to provide better help. > > When we call object_property_add_alias() adding alias properties to > the source object on the

Re: [Qemu-devel] [PATCH] smbios: Fix assertion on socket count calculation

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 12:07:17PM +0200, Igor Mammedov wrote: > On Mon, 29 Sep 2014 22:21:45 -0300 > Eduardo Habkost wrote: > > > QEMU currently allows the number of VCPUs to not be a multiple of the > > number of threads per socket, but the smbios socket count calculation > > introduced by comm

Re: [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct

2014-09-30 Thread Paolo Bonzini
Il 30/09/2014 13:35, Michael S. Tsirkin ha scritto: >> > virtio-blk-pci.addr=int32 (Slot and function number, example: 06.0) > Weird. 06.0 is clearly not an int, is it? The QOM property accepts both int32 and str, but always returns an int32 when read. For now we can leave out patch 5 while this

Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari capability of pcie devices

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 06:11:25PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > In QEMU, ARI Forwarding is enabled default at emulation of PCIe > ports. ARI Forwarding enable setting at firmware/OS Control handoff. > If the bit is Set when a non-ARI Device is present, the non-ARI > D

[Qemu-devel] [PATCH] util: Emancipate id_wellformed() from QemuOpts

2014-09-30 Thread Markus Armbruster
IDs have long spread beyond QemuOpts: not everything with an ID necessarily goes through QemuOpts. Commit 9aebf3b is about such a case: block layer names are meant to be well-formed IDs, but some of them don't go through QemuOpts, and thus weren't checked. The commit fixed that the straightforwar

Re: [Qemu-devel] [PATCH v3 03/23] block: Connect BlockBackend to BlockDriverState

2014-09-30 Thread Markus Armbruster
Kevin Wolf writes: > Am 30.09.2014 um 12:56 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: [...] >> > Taking back my R-b: You tricked us, this assertion doesn't hold true. >> > Easy to reproduce by taking a live snapshot. qemu-iotests case 052 >> > catches it. Didn't you run it? >> >>

Re: [Qemu-devel] [PATCH v3 23/23] block: Make device model's references to BlockBackend strong

2014-09-30 Thread Markus Armbruster
Kevin Wolf writes: > Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: >> Doesn't make a difference just yet, but it's the right thing to do. >> >> Signed-off-by: Markus Armbruster >> --- >> block/block-backend.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff -

Re: [Qemu-devel] [PATCH v2 1/2] qdev: add list built for devices

2014-09-30 Thread Igor Mammedov
On Tue, 30 Sep 2014 17:40:34 +0800 Zhu Guihua wrote: rephrase subj to qdev: func_name() helper > For peripheral device del completion, add a function to build a list for > devices. > > Signed-off-by: Zhu Guihua > --- > hw/core/qdev.c | 13 + > include/hw/qdev-core.h | 2

Re: [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct

2014-09-30 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Tue, Sep 30, 2014 at 11:02:34AM +0800, arei.gong...@huawei.com wrote: >> From: Gonglei >> >> This patch series based on qom-next tree: >> https://github.com/afaerber/qemu-cpu/commits/qom-next >> >> Add a description field in both ObjectProperty and PropertyIn

Re: [Qemu-devel] [PULL v2 0/9] tcg-next queue

2014-09-30 Thread Peter Maydell
On 29 September 2014 20:01, Richard Henderson wrote: > A replacement for the one from the 22nd. This one drops the patch > that would have conflicted with Paolo's 12 mmu idx patch set. It > also adjusts the aarch64 patch that Claudio objected to. > > Re-tested on x86_64 and aarch64. Please pull

[Qemu-devel] [PULL 4/5] pc-dimm: Don't check dimm->node when there is non-NUMA config

2014-09-30 Thread Michael S. Tsirkin
From: zhanghailiang It should not break memory hotplug feature if there is non-NUMA option. This patch would also allow to use pc-dimm as replacement for initial memory for non-NUMA configs. Note: After this patch, the memory hotplug can work normally for Linux guest OS when there is non-NUMA o

[Qemu-devel] [PULL 00/39] SCSI changes for 2014-09-23

2014-09-30 Thread Paolo Bonzini
The following changes since commit 380f649e02f9545159dc3158d7c1b2e70c1005e3: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2014-09-23 12:08:55 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you

[Qemu-devel] [PULL 03/39] vhost-scsi: use virtio_ldl_p

2014-09-30 Thread Paolo Bonzini
This helps for cross-endian configurations. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini --- hw/scsi/vhost-scsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index 7146e0e..308b393 100644 --- a/hw/scsi/vhost-scsi

[Qemu-devel] [PULL 10/39] virtio-net: use aliases instead of duplicate qdev properties

2014-09-30 Thread Paolo Bonzini
From: Gonglei virtio-net-pci, virtio-net-s390, and virtio-net-ccw all duplicate the qdev properties of their VirtIONet child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward pr

[Qemu-devel] [PULL 25/39] virtio-scsi: Hook up with dataplane

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng This enables the virtio-scsi-dataplane code by setting the iothread in virtio-scsi device, and makes any function that is called by back from dataplane to cooperate with the caller: they need to be vring/iothread aware when handling the requests and using scsi devices on the bus.

[Qemu-devel] [PULL 01/39] scsi: Optimize scsi_req_alloc

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng Zeroing sense buffer for each scsi request is not efficient, we can just leave it uninitialized because sense_len is set to 0. Move the implicitly zeroed fields to the end of the structure and use a partial memset. The explicitly initialized fields (by scsi_req_alloc or scsi_req

[Qemu-devel] [PULL 02/39] virtio-scsi: Optimize virtio_scsi_init_req

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng The VirtQueueElement is a very big structure (>48k!), since it will be initialzed by virtqueue_pop, we can save the expensive zeroing here. This saves a few microseconds per request in my test: [fio-test] rw bs iodepthjobs bw iops la

[Qemu-devel] [PULL 06/39] virtio-scsi: Split virtio_scsi_handle_ctrl_req from virtio_scsi_handle_ctrl

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng To share with dataplane code. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 60 ++--- include/hw/virtio/virtio-scsi.h | 1 + 2 files changed, 34 insertions(+), 27 deletions(-) diff --git a/hw/s

[Qemu-devel] [PULL 38/39] util: introduce bitmap_try_new

2014-09-30 Thread Paolo Bonzini
From: Peter Lieven regular bitmap_new simply aborts if the memory allocation fails. bitmap_try_new returns NULL on failure and allows for proper error handling. Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini --- include/qemu/bitmap.h | 13 +++-- 1 file changed, 11 insertions

[Qemu-devel] [PULL 04/39] virtio-scsi: clean up virtio_scsi_parse_cdb

2014-09-30 Thread Paolo Bonzini
The command direction according to the guest-passed buffers is already stored in the VirtIOSCSIReq. We can use it instead of computing it again from req->elem. Cc: Laszlo Ersek Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-)

[Qemu-devel] [PULL 12/39] virtio/vhost-scsi: use aliases instead of duplicate qdev properties

2014-09-30 Thread Paolo Bonzini
From: Gonglei {virtio, vhost}-scsi-{pci, s390, ccw} all duplicate the qdev properties of their VirtIOSCSI/VHostSCSI child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward prope

[Qemu-devel] [PULL 05/39] virtio-scsi: Split virtio_scsi_handle_cmd_req from virtio_scsi_handle_cmd

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng This is the "common part" to handle one cmd request. Refactor out for later usage of dataplane iothread code. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 117 +++- include/hw/virtio/virtio-scsi

[Qemu-devel] [PULL 13/39] virtio/vhost-scsi: fix virtio-scsi/vhost-scsi child refcount in transports

2014-09-30 Thread Paolo Bonzini
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon hot unplug the virtio-scsi/vhost-scsi child is not fi

[Qemu-devel] [PULL 11/39] virtio-net: fix virtio-net child refcount in transports

2014-09-30 Thread Paolo Bonzini
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon hot unplug the virtio-net child is not finalized! Dr

[Qemu-devel] [PULL 17/39] virtio-rng: fix virtio-rng child refcount in transports

2014-09-30 Thread Paolo Bonzini
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon hot unplug the virtio-rng child is not finalized! Dr

[Qemu-devel] [PULL 07/39] virtio-scsi: Make virtio_scsi_init_req public

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng To share with datplane code later. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 2 +- include/hw/virtio/virtio-scsi.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi

[Qemu-devel] [PULL 19/39] virtio-9p: use aliases instead of duplicate qdev properties

2014-09-30 Thread Paolo Bonzini
From: Gonglei virtio-9p-pci all duplicate the qdev properties of their V9fsState child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward property accesses to the V9fsState child

[Qemu-devel] [PULL 08/39] virtio-scsi: Make virtio_scsi_free_req public

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng To share with dataplane code later. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 2 +- include/hw/virtio/virtio-scsi.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scs

[Qemu-devel] [PULL 15/39] virtio-serial: fix virtio-serial child refcount in transports

2014-09-30 Thread Paolo Bonzini
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon hot unplug the virtio-serial child is not finalized!

[Qemu-devel] [PULL 20/39] virtio-9p: fix virtio-9p child refcount in transports

2014-09-30 Thread Paolo Bonzini
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon unplug the virtio-9p child is not finalized! Drop our

[Qemu-devel] [PULL 09/39] virtio-scsi: Make virtio_scsi_push_event public

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng Later this will be called by dataplane code. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 4 ++-- include/hw/virtio/virtio-scsi.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/sc

[Qemu-devel] [PULL 23/39] virtio-scsi: Add VirtIOSCSIVring in VirtIOSCSIReq

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng Move VirtIOSCSIReq to header and add one field "vring" as a wrapper structure of Vring, VirtIOSCSIVring. This is necessary for coming dataplane code that runs uses vring on iothread. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- include/hw/virtio/virtio-scsi.h | 1

[Qemu-devel] [PULL 14/39] virtio-serial: use aliases instead of duplicate qdev properties

2014-09-30 Thread Paolo Bonzini
From: Gonglei virtio-serial-{pci, s390, ccw} all duplicate the qdev properties of their VirtIOSerial child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward property accesses to

[Qemu-devel] [PULL 21/39] virtio: add a wrapper for virtio-backend initialization

2014-09-30 Thread Paolo Bonzini
From: Gonglei For better code sharing, add a helper function that handles reference counting of the virtio backend for virtio proxy devices. Cc: Cornelia Huck Cc: Michael S. Tsirkin Signed-off-by: Gonglei Signed-off-by: Paolo Bonzini --- hw/s390x/s390-virtio-bus.c | 42 +

[Qemu-devel] [PULL 16/39] virtio-rng: use aliases instead of duplicate qdev properties

2014-09-30 Thread Paolo Bonzini
From: Gonglei virtio-rng-{pci, s390, ccw} all duplicate the qdev properties of their VirtIORNG child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward property accesses to the V

[Qemu-devel] [PULL 24/39] virtio-scsi-dataplane: Code to run virtio-scsi on iothread

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng This implements the core part of dataplane feature of virtio-scsi. A few fields are added in VirtIOSCSICommon to maintain the dataplane status. These fields are managed by a new source file: virtio-scsi-dataplane.c. Most code in this file will run on an iothread, unless otherwis

[Qemu-devel] [PULL 26/39] virtio-scsi: Add migration state notifier for dataplane code

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng Similar to virtio-blk-dataplane, we stop the iothread while migration starts and restart it when migration finishes. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 35 --- include/hw/virtio/virtio-scs

[Qemu-devel] [PULL 30/39] virtio-scsi: Process ".iothread" property

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng We are ready, now let's effectively enable dataplane. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 09a39cb..fa36e23 100644 --- a/hw/sc

[Qemu-devel] [PULL 18/39] virtio-balloon: fix virtio-balloon child refcount in transports

2014-09-30 Thread Paolo Bonzini
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon hot unplug the virtio-balloon child is not finalized!

[Qemu-devel] [PULL 27/39] virtio-scsi: Two stages processing of cmd request

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng Mechanical change, in preparation for bdrv_io_plug/bdrv_io_unplug. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi-dataplane.c | 4 +++- hw/scsi/virtio-scsi.c | 20 include/hw/virtio/virtio-scsi.h | 3 ++- 3 files

[Qemu-devel] [PULL 35/39] scsi: Introduce scsi_req_cancel_complete

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng Let the aio cb do the clean up and notification job after scsi_req_cancel, in preparation for asynchronous cancellation. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 14 ++ hw/scsi/scsi-disk.c| 8 hw/scsi/scsi-gen

[Qemu-devel] [PULL 31/39] scsi: Drop scsi_req_abort

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng The only user of this function is spapr_vscsi.c. We can convert to scsi_req_cancel plus adding a check in vscsi_request_cancelled. Suggested-by: Paolo Bonzini Signed-off-by: Fam Zheng [Drop prototype. - Paolo] Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 15 -

[Qemu-devel] [PULL 22/39] virtio-scsi: Add 'iothread' property to virtio-scsi

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng Similar to this property in virtio-blk for dataplane, add it as a QOM link in virtio-scsi and an alias in virtio-scsi-pci and virtio-scsi-ccw, in order to assign an iothread to the device. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/s390x/virtio-ccw.c

Re: [Qemu-devel] [PATCH v4 3/3] pcie: remove confused comments

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 06:11:26PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > The below functions is not allocation functions, but > find helper function. The only allocation function is > pcie_add_capability(), but its argument names is not the > same with the comments. So remove

[Qemu-devel] [PULL 37/39] virtio-scsi: Handle TMF request cancellation asynchronously

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng For VIRTIO_SCSI_T_TMF_ABORT_TASK and VIRTIO_SCSI_T_TMF_ABORT_TASK_SET, use scsi_req_cancel_async to start the cancellation. Because each tmf command may cancel multiple requests, we need to use a counter to track the number of remaining requests we still need to wait for. Signed

[Qemu-devel] [PULL 34/39] scsi: Drop SCSIReqOps.cancel_io

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng The only two implementations are identical to each other, with nothing specific to device: they only call bdrv_aio_cancel with the SCSIRequest.aiocb. Let's move it to scsi-bus. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 4 ++-- hw/scsi

[Qemu-devel] [PULL 28/39] virtio-scsi: Batched prepare for cmd reqs

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng Queue the popped requests while calling virtio_scsi_handle_cmd_req_prepare(), then submit them after all prepared. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi-dataplane.c | 9 +++-- hw/scsi/virtio-scsi.c | 9 +++-- include/hw

[Qemu-devel] [PULL 39/39] block/iscsi: handle failure on malloc of the allocationmap

2014-09-30 Thread Paolo Bonzini
From: Peter Lieven Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini --- block/iscsi.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 3c1b416..26bded3 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -317,6 +

[Qemu-devel] [PULL 29/39] virtio-scsi: Call bdrv_io_plug/bdrv_io_unplug in cmd request handling

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 395178e..09a39cb 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -488,6

[Qemu-devel] [PULL 36/39] scsi: Introduce scsi_req_cancel_async

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng Devices will call this function to start an asynchronous cancellation. The bus->info->cancel will be called after the request is canceled. Devices will probably need to track a separate TMF request that triggers this cancellation, and wait until the cancellation is done before co

[Qemu-devel] [PULL 33/39] scsi: Unify request unref in scsi_req_cancel

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng Before, scsi_req_cancel will take ownership of the canceled request and unref it. We did this because we didn't know whether AIO CB will be called or not during the cancelling, so we set the io_canceled flag before calling it, and skip unref in the potentially called callbacks, wh

[Qemu-devel] [PULL 32/39] scsi-generic: Handle canceled request in scsi_command_complete

2014-09-30 Thread Paolo Bonzini
From: Fam Zheng Now that we always called the cb in bdrv_aio_cancel, let's make scsi-generic callbacks check io_canceled flag similarly to scsi-disk. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-generic.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(

Re: [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct

2014-09-30 Thread Gonglei
> Subject: Re: [Qemu-devel] [PATCH v4 0/5] add description field in > ObjectProperty and PropertyInfo struct > > On Tue, Sep 30, 2014 at 11:02:34AM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > This patch series based on qom-next tree: > > https://github.com/afaerber/qemu-cpu/c

Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

2014-09-30 Thread Gonglei
> Subject: Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in > PropertyInfo struct > > On Tue, Sep 30, 2014 at 11:02:35AM +0800, arei.gong...@huawei.com wrote: > > @@ -552,6 +556,7 @@ static int print_pci_devfn(DeviceState *dev, Property > *prop, char *dest, > > PropertyInfo qdev_pro

Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

2014-09-30 Thread Paolo Bonzini
Il 30/09/2014 15:33, Michael S. Tsirkin ha scritto: > > > > > The Propertyinfo.name is used to the qdev property's type, please see PATCH > > 4: > > > > -info->type = g_strdup(prop->info->legacy_name ?: > > prop->info->name); > > +info->type = g_strdup(prop->info->name);

Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 09:14:50PM +0800, Gonglei wrote: > > Subject: Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in > > PropertyInfo struct > > > > On Tue, Sep 30, 2014 at 11:02:35AM +0800, arei.gong...@huawei.com wrote: > > > @@ -552,6 +556,7 @@ static int print_pci_devfn(DeviceS

Re: [Qemu-devel] [PATCH v4 3/3] pcie: remove confused comments

2014-09-30 Thread Gonglei
> Subject: Re: [Qemu-devel] [PATCH v4 3/3] pcie: remove confused comments > > On Tue, Sep 30, 2014 at 06:11:26PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > The below functions is not allocation functions, but > > find helper function. The only allocation function is > > pcie_

Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari capability of pcie devices

2014-09-30 Thread Gonglei
> Subject: Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari capability of > pcie devices > > On Tue, Sep 30, 2014 at 06:11:25PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > In QEMU, ARI Forwarding is enabled default at emulation of PCIe > > ports. ARI Forwarding enable s

Re: [Qemu-devel] [PATCH v4 5/5] qdev: drop legacy_name from qdev properties

2014-09-30 Thread Gonglei
> Subject: Re: [Qemu-devel] [PATCH v4 5/5] qdev: drop legacy_name from qdev > properties > > On Tue, Sep 30, 2014 at 11:02:39AM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > The legacy_name is useless now, the better help > > information provied by description field of property.

Re: [Qemu-devel] [PATCH v4 2/5] qom: add description field in ObjectProperty struct

2014-09-30 Thread Gonglei
> Subject: Re: [Qemu-devel] [PATCH v4 2/5] qom: add description field in > ObjectProperty struct > > On Tue, Sep 30, 2014 at 11:02:36AM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > The descriptions can serve as documentation in the code, > > and they can be used to provide bett

Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 03:36:22PM +0200, Paolo Bonzini wrote: > Il 30/09/2014 15:33, Michael S. Tsirkin ha scritto: > > > > > > > The Propertyinfo.name is used to the qdev property's type, please see > > > PATCH 4: > > > > > > -info->type = g_strdup(prop->info->legacy_name ?: > > >

Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari capability of pcie devices

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 09:38:51PM +0800, Gonglei wrote: > > Subject: Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari capability > > of > > pcie devices > > > > On Tue, Sep 30, 2014 at 06:11:25PM +0800, arei.gong...@huawei.com wrote: > > > From: Gonglei > > > > > > In QEMU, ARI Forwardin

Re: [Qemu-devel] [PATCH v2] libcacard: fix compile error on glib2-2.12.3-4.el5

2014-09-30 Thread Zhi Yong Wu
c++ -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -Wendif-labels -Wmissing-include-dirs -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wold-style-

Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 03:53:53PM +0200, Paolo Bonzini wrote: > Il 30/09/2014 15:55, Michael S. Tsirkin ha scritto: > > > At the QOM level it is an int, even though it secondarily accepts a > > > string in "DD.F" format. > > > > That's the only way to specify a function, isn't it? > > No, as Mar

Re: [Qemu-devel] [PATCH] translate-all.c: memory walker initial address miscalculation

2014-09-30 Thread Mikhail Ilin
ping http://patchwork.ozlabs.org/patch/386918/ On 22.09.2014 13:04, Mikhail Ilin wrote: ping http://patchwork.ozlabs.org/patch/386918/ On 08.09.2014 17:28, m.i...@samsung.com wrote: From: Mikhail Ilyin The initial base address is miscalculated in walk_memory_regions(). It has to be shifted

Re: [Qemu-devel] [PULL 0/5] pci, pc, virtio, misc bugfixes

2014-09-30 Thread Peter Maydell
On 30 September 2014 10:39, Michael S. Tsirkin wrote: > The following changes since commit ed9114356b587b362f5ed10e75366a4f07ed32af: > > raw-posix: Fix build without posix_fallocate() (2014-09-29 16:28:24 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/

Re: [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 11:02:34AM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > This patch series based on qom-next tree: > https://github.com/afaerber/qemu-cpu/commits/qom-next > > Add a description field in both ObjectProperty and PropertyInfo struct. > The descriptions can serve

Re: [Qemu-devel] [PATCH 0/2] make check-block/qemu-iotests fixes

2014-09-30 Thread Markus Armbruster
I'll rebase my block-backend branch onto this for more complete testing. Series Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

2014-09-30 Thread Gonglei
> Subject: Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in > PropertyInfo struct > > On Tue, Sep 30, 2014 at 03:36:22PM +0200, Paolo Bonzini wrote: > > Il 30/09/2014 15:33, Michael S. Tsirkin ha scritto: > > > > > > > > > The Propertyinfo.name is used to the qdev property's type, pl

Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

2014-09-30 Thread Paolo Bonzini
Il 30/09/2014 15:55, Michael S. Tsirkin ha scritto: > > At the QOM level it is an int, even though it secondarily accepts a > > string in "DD.F" format. > > That's the only way to specify a function, isn't it? No, as Markus said "06.0" is 48, "06.1" is 49, etc. Paolo

Re: [Qemu-devel] [PATCH v2] libcacard: fix compile error on glib2-2.12.3-4.el5

2014-09-30 Thread Paolo Bonzini
Il 30/09/2014 15:57, Zhi Yong Wu ha scritto: > libtool --mode=link --tag=CC c++ -m64 -D_GNU_SOURCE > -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes > -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes > -fno-strict-aliasing -fno-common -Wendif-labels > -Wmissing-

Re: [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct

2014-09-30 Thread Gonglei
> Subject: Re: [Qemu-devel] [PATCH v4 0/5] add description field in > ObjectProperty and PropertyInfo struct > > On Tue, Sep 30, 2014 at 11:02:34AM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > This patch series based on qom-next tree: > > https://github.com/afaerber/qemu-cpu/c

Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

2014-09-30 Thread Paolo Bonzini
Il 30/09/2014 16:01, Michael S. Tsirkin ha scritto: > > No, as Markus said "06.0" is 48, "06.1" is 49, etc. > > I see. So in fact the help text I suggested is wrong. > At least for HMP I would say slot.function is the > primary format. > Let's just make it a string, it's a superset of > an integer

Re: [Qemu-devel] [PULL 0/1] audio patch queue

2014-09-30 Thread Peter Maydell
/tags/for-upstream' into > staging (2014-09-26 15:41:50 +0100) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-audio-20140930-1 > > for you to fetch changes up to 133771477c39f3716d9a85609aca0d3e5a77c55

Re: [Qemu-devel] [PATCH v2 03/12] virtio/vhost-scsi: use aliases instead of duplicate qdev properties

2014-09-30 Thread Cornelia Huck
On Tue, 30 Sep 2014 10:43:31 +0200 Cornelia Huck wrote: > On Tue, 30 Sep 2014 14:10:29 +0800 > wrote: > > > From: Gonglei > > > > {virtio, vhost}-scsi-{pci, s390, ccw} all duplicate the > > qdev properties of their VirtIOSCSI/VHostSCSI child. > > This approach does not work well with string o

Re: [Qemu-devel] [PATCH] translate-all.c: memory walker initial address miscalculation

2014-09-30 Thread Michael S. Tsirkin
On Mon, Sep 08, 2014 at 10:51:22AM +0400, m.i...@samsung.com wrote: > From: Mikhail Ilyin > > The initial base address is miscalculated in walk_memory_regions(). > It has to be shifted TARGET_PAGE_BITS more. Holder variables are > extended to target_ulong size otherwise they don't fit for MIPS N3

Re: [Qemu-devel] [PATCH v2] libcacard: fix compile error on glib2-2.12.3-4.el5

2014-09-30 Thread Zhi Yong Wu
On Tue, Sep 30, 2014 at 10:06 PM, Paolo Bonzini wrote: > Il 30/09/2014 15:57, Zhi Yong Wu ha scritto: >> libtool --mode=link --tag=CC c++ -m64 -D_GNU_SOURCE >> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes >> -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes >>

Re: [Qemu-devel] [PATCH v2] libcacard: fix compile error on glib2-2.12.3-4.el5

2014-09-30 Thread Paolo Bonzini
Il 30/09/2014 17:09, Zhi Yong Wu ha scritto: >> > >> > So the problem seems to be with "-Wl,-fstack-protector-all". Where does >> > it come from? QEMU or some pkg-config file? >> > >> > Does it work if you configure with the --disable-stack-protector option? > Yes, it can work now, i'm very supri

[Qemu-devel] [PATCH] gdb: detect target architecture via target.xml

2014-09-30 Thread Jens Freimann
Conny, Alex, Christian, this patch has been sent before as part of a gdb series a few weeks ago. It contains only names for architectures that are also defined in the xml files that are shipped with gdb. Discussion revealed that the 32bit arm case can easily be added as an follow-up patch. The

[Qemu-devel] [PATCH] gdb: provide the name of the architecture in the target.xml

2014-09-30 Thread Jens Freimann
From: David Hildenbrand This patch provides the name of the architecture in the target.xml if available. This allows the remote gdb to detect the target architecture on its own - so there is no need to specify it manually (e.g. if gdb is started without a binary) using "set arch *arch_name*". T

<    1   2   3   4   >