> Subject: Re: [Qemu-devel] [PATCH v4 0/5] add description field in > ObjectProperty and PropertyInfo struct > > On Tue, Sep 30, 2014 at 11:02:34AM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei <arei.gong...@huawei.com> > > > > This patch series based on qom-next tree: > > https://github.com/afaerber/qemu-cpu/commits/qom-next > > > > Add a description field in both ObjectProperty and PropertyInfo struct. > > The descriptions can serve as documentation in the code, > > and they can be used to provide better help. For example: > > > > Before this patch series: > > > > $./qemu-system-x86_64 -device virtio-blk-pci,? > > > > virtio-blk-pci.iothread=link<iothread> > > virtio-blk-pci.x-data-plane=bool > > virtio-blk-pci.scsi=bool > > virtio-blk-pci.config-wce=bool > > virtio-blk-pci.serial=str > > virtio-blk-pci.secs=uint32 > > virtio-blk-pci.heads=uint32 > > virtio-blk-pci.cyls=uint32 > > virtio-blk-pci.discard_granularity=uint32 > > virtio-blk-pci.bootindex=int32 > > virtio-blk-pci.opt_io_size=uint32 > > virtio-blk-pci.min_io_size=uint16 > > virtio-blk-pci.physical_block_size=uint16 > > virtio-blk-pci.logical_block_size=uint16 > > virtio-blk-pci.drive=str > > virtio-blk-pci.virtio-backend=child<virtio-blk-device> > > virtio-blk-pci.command_serr_enable=on/off > > virtio-blk-pci.multifunction=on/off > > virtio-blk-pci.rombar=uint32 > > virtio-blk-pci.romfile=str > > virtio-blk-pci.addr=pci-devfn > > virtio-blk-pci.event_idx=on/off > > virtio-blk-pci.indirect_desc=on/off > > virtio-blk-pci.vectors=uint32 > > virtio-blk-pci.ioeventfd=on/off > > virtio-blk-pci.class=uint32 > > > > After: > > > > $./qemu-system-x86_64 -device virtio-blk-pci,? > > > > virtio-blk-pci.iothread=link<iothread> > > virtio-blk-pci.x-data-plane=bool (on/off) > > virtio-blk-pci.scsi=bool (on/off) > > virtio-blk-pci.config-wce=bool (on/off) > > virtio-blk-pci.serial=str > > virtio-blk-pci.secs=uint32 > > virtio-blk-pci.heads=uint32 > > virtio-blk-pci.cyls=uint32 > > virtio-blk-pci.discard_granularity=uint32 > > virtio-blk-pci.bootindex=int32 > > virtio-blk-pci.opt_io_size=uint32 > > virtio-blk-pci.min_io_size=uint16 > > virtio-blk-pci.physical_block_size=uint16 (A power of two between 512 and > 32768) > > virtio-blk-pci.logical_block_size=uint16 (A power of two between 512 and > 32768) > > virtio-blk-pci.drive=str (ID of a drive to use as a backend) > > virtio-blk-pci.virtio-backend=child<virtio-blk-device> > > virtio-blk-pci.command_serr_enable=bool (on/off) > > virtio-blk-pci.multifunction=bool (on/off) > > virtio-blk-pci.rombar=uint32 > > virtio-blk-pci.romfile=str > > virtio-blk-pci.addr=int32 (Slot and function number, example: 06.0) > > Weird. 06.0 is clearly not an int, is it? > > > virtio-blk-pci.event_idx=bool (on/off) > > virtio-blk-pci.indirect_desc=bool (on/off) > > virtio-blk-pci.vectors=uint32 > > virtio-blk-pci.ioeventfd=bool (on/off) > > virtio-blk-pci.class=uint32 > > BTW, any way we can find out and report default values > as well? E.g. > virtio-blk-pci.indirect_desc=bool (on/off) default:on > I think qom-get is the only way at present. :)
> This idea should not block this patch of course. > Best regards, -Gonglei
