On Tue, Sep 30, 2014 at 11:02:35AM +0800, arei.gong...@huawei.com wrote: > @@ -552,6 +556,7 @@ static int print_pci_devfn(DeviceState *dev, Property > *prop, char *dest, > PropertyInfo qdev_prop_pci_devfn = { > .name = "int32",
Is this name used anywhere? It seems wrong ... > .legacy_name = "pci-devfn", > + .description = "Slot and function number, example: 06.0", In fact, .0 can be omitted. So please make this: Slot and optional function number, examples: 06.0 or 06. > .print = print_pci_devfn, > .get = get_int32, > .set = set_pci_devfn,