Re: [Qemu-devel] [PATCH v3 18/23] blockdev: Fix blockdev-add not to create IDE drive (0, 0)

2014-09-29 Thread Kevin Wolf
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: > blockdev_init() always creates a DriveInfo, but only drive_new() fills > it in. qmp_blockdev_add() leaves it blank. This results in a drive > with type = IF_IDE, bus = 0, unit = 0. Screwed up in commit ee13ed1c. > > Board initializatio

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-29 Thread Gonglei (Arei)
> From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > Sent: Monday, September 29, 2014 7:33 PM > Subject: Re: [PATCH RESEND 0/9] virtio: fix virtio child recount in transports > > On Fri, 26 Sep 2014 16:45:38 +0800 > wrote: > > > Gonglei (9): > > virtio-net: use aliases instead of duplicat

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-29 Thread Michael S. Tsirkin
On Mon, Sep 29, 2014 at 12:09:06PM +, Gonglei (Arei) wrote: > > From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > > Sent: Monday, September 29, 2014 6:53 PM > > Subject: Re: [PATCH RESEND 0/9] virtio: fix virtio child recount in > > transports > > > > On Sat, 27 Sep 2014 10:37:23 +

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-29 Thread Paolo Bonzini
Il 29/09/2014 12:53, Cornelia Huck ha scritto: > void virtio_instance_init_common(Object *proxydev, > DeviceState *vdev, > size_t vdevsize, > const char *vdevname) > { > object_initialize(vdev, vd

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-29 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Monday, September 29, 2014 8:32 PM > Subject: Re: [PATCH RESEND 0/9] virtio: fix virtio child recount in transports > > Il 29/09/2014 12:53, Cornelia Huck ha scritto: > > void virtio_instance_init_common(Object *proxydev, > >

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Alexander Graf
On 29.09.14 14:21, Paolo Bonzini wrote: > Il 29/09/2014 13:53, Alexander Graf ha scritto: >> >> cpu_handle_ioreq() >> { >> ... >> >> if (req->type == IOPORT_REGISTERS_SYNCHRONIZED) { >> cpu->xen_vcpu_dirty = true; >> synchronize_xen_to_env(xenptr, cpu); >> } >> >>

Re: [Qemu-devel] [PULL 00/11] Block patches

2014-09-29 Thread Peter Maydell
On 26 September 2014 19:58, Kevin Wolf wrote: > The following changes since commit 4f2280b2190e39aa6761cc8188626ed9aad350c1: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-signed' into > staging (2014-09-24 13:45:13 +0100) > > are available in the git repository at: > > >

Re: [Qemu-devel] [PATCH v2] target-mips: fix broken MIPS16 and microMIPS

2014-09-29 Thread Maciej W. Rozycki
On Fri, 1 Aug 2014, Yongbok Kim wrote: > Ping! > Patch for v2.1.0 > > -Original Message- > From: Yongbok Kim > Sent: 01 July 2014 17:43 > To: qemu-devel@nongnu.org > Cc: aurel...@aurel32.net; Leon Alrae; Cristian Cuna; Yongbok Kim > Subject: [PATCH v2] target-mips: fix broken MIPS16 and

Re: [Qemu-devel] [PATCH v3 18/23] blockdev: Fix blockdev-add not to create IDE drive (0, 0)

2014-09-29 Thread Markus Armbruster
Kevin Wolf writes: > Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: >> blockdev_init() always creates a DriveInfo, but only drive_new() fills >> it in. qmp_blockdev_add() leaves it blank. This results in a drive >> with type = IF_IDE, bus = 0, unit = 0. Screwed up in commit ee13ed1c

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-29 Thread Cornelia Huck
On Mon, 29 Sep 2014 15:33:32 +0300 "Michael S. Tsirkin" wrote: > On Mon, Sep 29, 2014 at 12:09:06PM +, Gonglei (Arei) wrote: > > > From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > > > Sent: Monday, September 29, 2014 6:53 PM > > > Subject: Re: [PATCH RESEND 0/9] virtio: fix virtio chil

Re: [Qemu-devel] [PATCH v3 18/23] blockdev: Fix blockdev-add not to create IDE drive (0, 0)

2014-09-29 Thread Kevin Wolf
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: > blockdev_init() always creates a DriveInfo, but only drive_new() fills > it in. qmp_blockdev_add() leaves it blank. This results in a drive > with type = IF_IDE, bus = 0, unit = 0. Screwed up in commit ee13ed1c. > > Board initializatio

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Paolo Bonzini
Il 29/09/2014 14:57, Alexander Graf ha scritto: >> > Yeah, that would be possible. You do not even need synchronize_state, >> > it seems to me that it introduces more complication for little gain. > Well, it makes all accels behave the same and keep information always at > a single entity (the env

[Qemu-devel] ui/gtk.c does not check qemu_chr_be_can_write()

2014-09-29 Thread Michael Walle
Hi Anthony, Hi Gerd, the GTK frontend does not respect the the "chr_can_read" hook. The frontend just writes characters to the device using qemu_chr_be_write() without checking if the device can receive any input (qemu_chr_be_can_write()). At least for my device model (hw/char/milkymist-uart

Re: [Qemu-devel] [PATCH v3 20/23] block/qapi: Convert qmp_query_block() to BlockBackend

2014-09-29 Thread Kevin Wolf
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: > Much more command code needs conversion. I start with this one > because it's using bdrv_dev_* functions, which I'm about to lift into > BlockBackend. > > While there, give bdrv_query_info() internal linkage. > > Signed-off-by: Markus A

Re: [Qemu-devel] [PATCH v3 4/7] qom: add description field in ObjectProperty struct

2014-09-29 Thread Paolo Bonzini
Il 27/09/2014 07:13, arei.gong...@huawei.com ha scritto: > +void object_property_set_description(Object *obj, const char *name, > + const char *description, Error **errp) > +{ > +ObjectProperty *op; > + > +op = object_property_find(obj, name, errp); > +

[Qemu-devel] [PATCH] kvm: Fix error code check from kvm_vm_ioctl()

2014-09-29 Thread Christoffer Dall
Currently kvm_physical_sync_dirty_bitmap() calls kvm_vm_ioctl() and checks if it returns -1. However, kvm_vm_ioctl() actually returns -errno, and not -1, so this check will fail and architectures not implementing this functionality in the kernel blindly attempt broken things like unimplemented dir

Re: [Qemu-devel] build regression on osx in block layer

2014-09-29 Thread Peter Maydell
On 29 September 2014 11:10, Igor Mammedov wrote: > Build fails with: > > $ make > LINK qemu-nbd > Undefined symbols for architecture x86_64: > "_posix_fallocate", referenced from: > _raw_create in raw-posix.o > ld: symbol(s) not found for architecture x86_64 > > introduced by > 06247428

Re: [Qemu-devel] [PATCH v3 18/23] blockdev: Fix blockdev-add not to create IDE drive (0, 0)

2014-09-29 Thread Markus Armbruster
Kevin Wolf writes: > Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: >> blockdev_init() always creates a DriveInfo, but only drive_new() fills >> it in. qmp_blockdev_add() leaves it blank. This results in a drive >> with type = IF_IDE, bus = 0, unit = 0. Screwed up in commit ee13ed1c

[Qemu-devel] [Bug 1294227] Re: migration wrong handling of KVM_GET_DIRTY_LOG ioctl

2014-09-29 Thread Christoffer Dall
** Changed in: qemu Status: New => In Progress ** Changed in: qemu Assignee: (unassigned) => Christoffer Dall (cdall) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1294227 Title: migra

[Qemu-devel] [PATCH] block: Drop superfluous conditionals around qemu_opts_del()

2014-09-29 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- blockdev.c | 4 +--- qemu-img.c | 4 +--- qemu-nbd.c | 4 +--- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/blockdev.c b/blockdev.c index ad43648..2f441c5 100644 --- a/blockdev.c +++ b/blockdev.c @@ -224,9 +224,7 @@ void drive_info_del(DriveI

[Qemu-devel] [Bug 1294227] Re: migration wrong handling of KVM_GET_DIRTY_LOG ioctl

2014-09-29 Thread Christoffer Dall
Sent patch for error handling: http://lists.nongnu.org/archive/html/qemu-devel/2014-09/msg05633.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1294227 Title: migration wrong handling of KVM_GET

Re: [Qemu-devel] [PATCH v4 13/19] qapi: More rigourous checking of types

2014-09-29 Thread Eric Blake
On 09/29/2014 02:27 AM, Markus Armbruster wrote: > Markus Armbruster writes: > >> Eric Blake writes: >> >>> Now that we know every expression is valid with regards to >>> its keys, we can add further tests that those keys refer to >>> valid types. With this patch, all references to a type (the

Re: [Qemu-devel] [PATCH v4 14/19] qapi: More rigorous checking for type safety bypass

2014-09-29 Thread Eric Blake
On 09/29/2014 02:38 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Now that we have a way to validate every type, we can also be >> stricter about enforcing that callers that want to bypass >> type safety in generated code. Prior to this patch, it didn't >> matter what value was associat

Re: [Qemu-devel] [PATCH v4 13/19] qapi: More rigourous checking of types

2014-09-29 Thread Eric Blake
On 09/26/2014 03:26 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Now that we know every expression is valid with regards to >> its keys, we can add further tests that those keys refer to >> valid types. With this patch, all references to a type (the >> 'data': of command, type, union,

Re: [Qemu-devel] [PATCH v5 0/2] In memory QEMUFile

2014-09-29 Thread Eric Blake
On 09/29/2014 03:41 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > This patch-pair adds the QEMUSizedBuffer based in-memory QEMUFile > written by Stefan Berger and Joel Schopp. I've made some > fixes and modified the existing test-vmstate to use it for some test c

Re: [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm

2014-09-29 Thread Serge E. Hallyn
Quoting Alex Bligh (a...@alex.org.uk): > > On 29 Sep 2014, at 11:08, Michael S. Tsirkin wrote: > > > On Sun, Sep 28, 2014 at 09:33:08PM +0100, Alex Bligh wrote: > >> Hang on a second! v2 of this patch DID use a new virtual machine, > >> called exactly that. I thought you were objecting to that a

[Qemu-devel] [PATCH] raw-posix: Fix build without posix_fallocate()

2014-09-29 Thread Kevin Wolf
Check for the presence of posix_fallocate() in configure and only compile in support for PREALLOC_MODE_FALLOC when it's there. Signed-off-by: Kevin Wolf --- block/raw-posix.c | 18 ++ configure | 18 ++ 2 files changed, 32 insertions(+), 4 deletions(-) di

Re: [Qemu-devel] [PATCH v3 0/7] add description field in ObjectProperty and PropertyInfo struct

2014-09-29 Thread Andreas Färber
Hi, Am 27.09.2014 um 07:13 schrieb arei.gong...@huawei.com: > Gonglei (7): > qom: add error handler for object_property_print() > qom: add error handler for object alias property I've applied these two to qom-next: https://github.com/afaerber/qemu-cpu/commits/qom-next As I understand there w

Re: [Qemu-devel] [PATCH qom v3 04/14] qmp: qstring: Handle NULL strings

2014-09-29 Thread Andreas Färber
Am 26.09.2014 um 15:27 schrieb Paolo Bonzini: > Il 26/09/2014 07:18, Peter Crosthwaite ha scritto: >> Create a valid qobject even if the input string is null. >> qstring->string will be NULL and length will be 0. >> >> This prepares support for clearing of QOM Link properties >> where NULL canonica

Re: [Qemu-devel] [PATCH v3 18/23] blockdev: Fix blockdev-add not to create IDE drive (0, 0)

2014-09-29 Thread Kevin Wolf
Am 29.09.2014 um 15:05 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: > >> @@ -903,21 +899,19 @@ DriveInfo *drive_new(QemuOpts *all_opts, > >> BlockInterfaceType block_default_type) > >> } > >> > >> /* Set legac

Re: [Qemu-devel] build regression on osx in block layer

2014-09-29 Thread Kevin Wolf
Am 29.09.2014 um 15:58 hat Peter Maydell geschrieben: > On 29 September 2014 11:10, Igor Mammedov wrote: > > Build fails with: > > > > $ make > > LINK qemu-nbd > > Undefined symbols for architecture x86_64: > > "_posix_fallocate", referenced from: > > _raw_create in raw-posix.o > > ld:

[Qemu-devel] [PATCH v2 0/2] libqos: use microseconds instead of iterations for virtio timeout

2014-09-29 Thread Stefan Hajnoczi
v2: * Implement "no interrupt" test properly, added Patch 1 [Peter] Fix the race condition that leads to Travis "make check" failures. Stefan Hajnoczi (2): libqos: improve event_index test with timeout libqos: use microseconds instead of iterations for virtio timeout tests/libqos/virtio.c

[Qemu-devel] [PATCH v2 2/2] libqos: use microseconds instead of iterations for virtio timeout

2014-09-29 Thread Stefan Hajnoczi
Some hosts are slow or overloaded so test execution takes a long time. Test cases use timeouts to protect against an infinite loop stalling the test forever (especially important in automated test setups). Commit 6cd14054b67774cc58a51fca6660cfa1d3c08059 ("libqos virtio: Increase ISR timeout") incr

[Qemu-devel] [PATCH v2 1/2] libqos: improve event_index test with timeout

2014-09-29 Thread Stefan Hajnoczi
The virtio event_index feature lets the device driver tell the device how many requests to process before raising the next interrupt. virtio-blk-test.c tries to verify that the device does not raise an interrupt unnecessarily. Unfortunately the test has a race condition. It spins checking for an

Re: [Qemu-devel] [PATCH] raw-posix: Fix build without posix_fallocate()

2014-09-29 Thread Igor Mammedov
On Mon, 29 Sep 2014 17:12:59 +0200 Kevin Wolf wrote: > Check for the presence of posix_fallocate() in configure and only > compile in support for PREALLOC_MODE_FALLOC when it's there. With this patch QEMU builds fine on OS X Tested-By: Igor Mammedov > > Signed-off-by: Kevin Wolf > --- > blo

Re: [Qemu-devel] [PATCH v3 2/3] timers: Move NANOSECONDS_PER_SECONDS to timer.h for future reuse

2014-09-29 Thread Benoît Canet
On Wed, Sep 24, 2014 at 05:33:45PM +0200, Paolo Bonzini wrote: > Il 24/09/2014 17:21, Benoît Canet ha scritto: > > Reviewed-by: Eric Blake > > Signed-off-by: Benoît Canet > > --- > > include/qemu/throttle.h | 2 -- > > include/qemu/timer.h| 2 ++ > > 2 files changed, 2 insertions(+), 2 delet

Re: [Qemu-devel] [PATCH v3 2/3] pcie: add check for ari capability of pcie devices

2014-09-29 Thread Michael S. Tsirkin
On Mon, Sep 01, 2014 at 09:29:18PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > In QEMU, ARI Forwarding is enabled defualt at emulation of PCIe > ports. ARI Forwarding enable setting at firmware/OS Control handoff. > If the bit is Set when a non-ARI Device is present, the non-ARI > D

Re: [Qemu-devel] [PATCH v3 0/3] add check for PCIe root ports and downstream ports

2014-09-29 Thread Michael S. Tsirkin
On Mon, Sep 01, 2014 at 09:29:16PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Root ports and downstream ports of switches are the hot > pluggable ports in a PCI Express hierarchy. > PCI Express supports chip-to-chip interconnect, a PCIe link can > only connect one pci device/Switch

Re: [Qemu-devel] [PATCH 3/3] vga-pci: add qext region to mmio

2014-09-29 Thread Michael S. Tsirkin
On Tue, Sep 23, 2014 at 02:30:57PM +0200, Gerd Hoffmann wrote: > Add a qemu extented register range to the standard vga mmio bar. > Right nowe there are two registers: One readonly register returning the > size of the region (so we can easily add more registers there if needed) > and one endian co

Re: [Qemu-devel] [PATCH] block: Drop superfluous conditionals around qemu_opts_del()

2014-09-29 Thread Eric Blake
On 09/29/2014 08:07 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > blockdev.c | 4 +--- > qemu-img.c | 4 +--- > qemu-nbd.c | 4 +--- > 3 files changed, 3 insertions(+), 9 deletions(-) Reviewed-by: Eric Blake Made superfluous in commit 4782183. -- Eric Blake eblake

Re: [Qemu-devel] [PULL v3 14/15] virtio-pci: fix migration for pci bus master

2014-09-29 Thread Michael S. Tsirkin
On Mon, Sep 22, 2014 at 07:28:57PM +0200, Greg Kurz wrote: > On Thu, 18 Sep 2014 21:54:58 +0300 > "Michael S. Tsirkin" wrote: > > > Current support for bus master (clearing OK bit) > > together with the need to support guests which do not > > enable PCI bus mastering, leads to extra state in > >

Re: [Qemu-devel] [PATCH v3 6/7] qmp: print descriptions of object properties

2014-09-29 Thread Eric Blake
On 09/26/2014 11:14 PM, arei.gong...@huawei.com wrote: > From: Gonglei > > Add a new "description" field to DevicePropertyInfo. > The descriptions can serve as documentation in the code, > and they can be used to provide better help. For example: > > $./qemu-system-x86_64 -device virtio-blk-pci,

Re: [Qemu-devel] [PATCH] raw-posix: Fix build without posix_fallocate()

2014-09-29 Thread Peter Maydell
On 29 September 2014 16:12, Kevin Wolf wrote: > Check for the presence of posix_fallocate() in configure and only > compile in support for PREALLOC_MODE_FALLOC when it's there. > > Signed-off-by: Kevin Wolf Applied, thanks. -- PMM

Re: [Qemu-devel] [PATCH v2 0/2] Recursive op blockers

2014-09-29 Thread Benoît Canet
On Mon, Sep 22, 2014 at 09:00:50PM +0200, Benoît Canet wrote: > in v2: > Added a base parameters [Kevin] > Remove multiple blockers [Kevin] > > Addressed Kevin's comments except BLOCK_OP_TYPE_MIRROR_REPLACE > relaxing > and "You need to unblock all of the BDSes tha

Re: [Qemu-devel] [PATCH v4 14/19] qapi: More rigorous checking for type safety bypass

2014-09-29 Thread Markus Armbruster
Eric Blake writes: > On 09/29/2014 02:38 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Now that we have a way to validate every type, we can also be >>> stricter about enforcing that callers that want to bypass >>> type safety in generated code. Prior to this patch, it didn't >>> m

[Qemu-devel] [PATCH v2 3/6] pc/vl: Add units-per-default-bus property

2014-09-29 Thread John Snow
This patch adds the 'units_per_default_bus' property which allows individual boards to declare their desired index => (bus,unit) mapping for their default HBA, so that boards such as Q35 can specify that its default if_ide HBA, AHCI, only accepts one unit per bus. This property only overrides the

[Qemu-devel] [PATCH v2 5/6] qtest/bios-tables: Correct Q35 command line

2014-09-29 Thread John Snow
If the Q35 board types are to begin recognizing and decoding syntactic sugar for drive/device declarations, then workarounds found within the qtests suite need to be adjusted to prevent any test failures after the fix. bios-tables-test improperly uses this cli: -drive file=etc,id=hd -device ide-hd

[Qemu-devel] [PATCH v2 1/6] blockdev: Orphaned drive search

2014-09-29 Thread John Snow
When users use command line options like -hda, -cdrom, or even -drive if=ide, it is up to the board initialization routines to pick up these drives and create backing devices for them. Some boards, like Q35, have not been doing this. However, there is no warning explaining why certain drive specif

[Qemu-devel] [PATCH v2 6/6] q35/ahci: Pick up -cdrom and -hda options

2014-09-29 Thread John Snow
This patch implements the backend for the Q35 board for us to be able to pick up and use drives defined by the -cdrom, -hda, or -drive if=ide shorthand options. Signed-off-by: John Snow --- hw/i386/pc_q35.c | 4 hw/ide/ahci.c| 15 +++ hw/ide/ahci.h| 2 ++ 3 files chang

[Qemu-devel] [PATCH v2 0/6] Q35: Implement -cdrom/-hda sugar

2014-09-29 Thread John Snow
The Q35 board initialization does not currently bother to look for any drives added by the various syntactical sugar shorthands to be added to the AHCI HBA. These include -hda through -hdd, -cdrom, and -drive if=ide shorthands. An obstacle to having implemented this sooner is debate over whether o

[Qemu-devel] [PATCH v2 2/6] blockdev: Allow overriding if_max_dev property

2014-09-29 Thread John Snow
The if_max_devs table as in the past been an immutable default that controls the mapping of index => (bus,unit) for all boards and all HBAs for each interface type. Since adding this mapping information to the HBA device itself is currently unwieldly from the perspective of retrieving this informa

[Qemu-devel] [PATCH v2 4/6] ide: Update ide_drive_get to be HBA agnostic

2014-09-29 Thread John Snow
Instead of duplicating the logic for the if_ide (bus,unit) mappings, rely on the blockdev layer for managing those mappings for us, and use the drive_get_by_index call instead. This allows ide_drive_get to work for AHCI HBAs as well, and can be used in the Q35 initialization. Lastly, change the n

Re: [Qemu-devel] [PATCH v2 0/2] libqos: use microseconds instead of iterations for virtio timeout

2014-09-29 Thread Paolo Bonzini
Il 29/09/2014 17:40, Stefan Hajnoczi ha scritto: > v2: > * Implement "no interrupt" test properly, added Patch 1 [Peter] > > Fix the race condition that leads to Travis "make check" failures. > > Stefan Hajnoczi (2): > libqos: improve event_index test with timeout > libqos: use microseconds

Re: [Qemu-devel] [PATCH v2 0/2] libqos: use microseconds instead of iterations for virtio timeout

2014-09-29 Thread Peter Maydell
On 29 September 2014 16:40, Stefan Hajnoczi wrote: > v2: > * Implement "no interrupt" test properly, added Patch 1 [Peter] > > Fix the race condition that leads to Travis "make check" failures. > > Stefan Hajnoczi (2): > libqos: improve event_index test with timeout > libqos: use microseconds

[Qemu-devel] [PATCH v2] qemu-ga: added windows support for 'guest-network-get-interfaces'

2014-09-29 Thread Kenth Andersson
Implementation of guest-network-get-interfaces for windows Signed-off-by: Kenth Andersson --- configure| 2 +- qga/commands-win32.c | 247 ++- 2 files changed, 244 insertions(+), 5 deletions(-) diff --git a/configure b/configure ind

Re: [Qemu-devel] Timer issues with 2.1.1 and migration (was: latest rc: virtio-blk hangs forever after migration)

2014-09-29 Thread Marcelo Tosatti
Andrey, Can you get a trace of the guest (echo kvm > /sys/kernel/debug/tracing/set_event; sleep 1s; cp /sys/kernel/debug/tracing/trace /tmp/trace.txt) while it is in the 100% cpu consumption state? Is it otherwise operational? On Thu, Sep 25, 2014 at 10:40:27PM +0400, Andrey Korolyov wrote: > He

[Qemu-devel] [PULL 07/19] hw/input/tsc210x.c: Delete unused array tsc2101_rates

2014-09-29 Thread Peter Maydell
The array tsc2101_rates[] is unused (and we don't implement the TSC2101 anyway, only the 2102); delete it. Signed-off-by: Peter Maydell Message-id: 1410723223-17711-5-git-send-email-peter.mayd...@linaro.org --- hw/input/tsc210x.c | 30 -- 1 file changed, 30 deletions(

[Qemu-devel] [PULL 17/19] target-arm: A64: Emulate the SMC insn

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-10-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- target-arm/cpu.h | 1 + target-arm/helper-a64.c| 1 + target-arm/helper.c| 3 +++ target-arm/helper.h

[Qemu-devel] [PULL 15/19] target-arm: A64: Emulate the HVC insn

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-8-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- target-arm/cpu.h | 1 + target-arm/helper-a64.c| 1 + target-arm/helper.c| 20 +++- target-a

[Qemu-devel] [PULL 18/19] target-arm: Add IRQ and FIQ routing to EL2 and 3

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Reviewed-by: Greg Bellows Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-11-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- target-arm/cpu.h| 10 ++ target-arm/helper.c | 17 + 2 files changed, 27 ins

[Qemu-devel] [PULL 12/19] target-arm: Break out exception masking to a separate func

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Reviewed-by: Greg Bellows Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-5-git-send-email-edgar.igles...@gmail.com [PMM: updated to account for recent cpu-exec refactoring] Signed-off-by: Peter Maydell --- target-arm/cpu.c | 7 ++- target-arm/cpu.h

[Qemu-devel] [PULL 00/19] target-arm queue

2014-09-29 Thread Peter Maydell
+0100) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20140929 for you to fetch changes up to 136e67e9b50b61fb03fedcea5c4fbe74cf44fdcc: target-arm: Add support for VIRQ and VFIQ (2014-09-29 18:48:51 +0100

[Qemu-devel] [PULL 16/19] target-arm: Add a Hypervisor Trap exception type

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-9-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- target-arm/cpu.h| 1 + target-arm/helper-a64.c | 1 + target-arm/helper.c | 1 + target-arm/internals.h | 1 + 4 files

[Qemu-devel] [PULL 06/19] hw/display/pxa2xx_lcd.c: Remove unused function pxa2xx_dma_rdst_set

2014-09-29 Thread Peter Maydell
The function pxa2xx_dma_rdst_set() is unused; delete it. Signed-off-by: Peter Maydell Message-id: 1410723223-17711-4-git-send-email-peter.mayd...@linaro.org --- hw/display/pxa2xx_lcd.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c in

[Qemu-devel] [PULL 04/19] hw/display/blizzard.c: Delete unused function blizzard_rgb2yuv

2014-09-29 Thread Peter Maydell
The function blizzard_rgb2yuv() is unused; delete it. Signed-off-by: Peter Maydell Message-id: 1410723223-17711-2-git-send-email-peter.mayd...@linaro.org --- hw/display/blizzard.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c index 55c0d

[Qemu-devel] [PULL 19/19] target-arm: Add support for VIRQ and VFIQ

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" This only implements the external delivery method via the GIC. Acked-by: Greg Bellows Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-12-git-send-email-edgar.igles...@gmail.com [PMM: adjusted following cpu-exec refactoring] Signed-off-by: Peter Maydell -

[Qemu-devel] [PULL 13/19] target-arm: Don't take interrupts targeting lower ELs

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Reviewed-by: Alex Bennée Reviewed-by: Greg Bellows Reviewed-by: Peter Maydell Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-6-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- target-arm/cpu.h | 7 +++ 1 file changed, 7 ins

[Qemu-devel] [PULL 03/19] configure: Build GDB XML for 32 bit ARM CPUs into qemu aarch64 binaries

2014-09-29 Thread Peter Maydell
The qemu-aarch64 and qemu-system-aarch64 binaries include support for all the 32 bit ARM CPUs as well as the 64 bit ones. This means we need to build in the GDB XML files for the 32 bit CPUs too. Otherwise gdb will complain: warning: while parsing target description (at line 1): Could not load XML

[Qemu-devel] [PULL 02/19] target-arm: Implement handling of breakpoint firing

2014-09-29 Thread Peter Maydell
Implement handling of breakpoint event firing to correctly inject the debug exception into the guest. Since the breakpoint and watchpoint control register format is very similar we adjust wp_matches() to also handle breakpoints as well rather than using a separate function. Signed-off-by: Peter M

[Qemu-devel] [PULL 14/19] target-arm: A64: Correct updates to FAR and ESR on exceptions

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Not all exception types update both FAR and ESR. Reviewed-by: Alex Bennée Reviewed-by: Greg Bellows Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-7-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- target-arm/helper-a64.c | 7 +

[Qemu-devel] [PULL 05/19] hw/intc/imx_avic.c: Remove unused function imx_avic_set_prio()

2014-09-29 Thread Peter Maydell
The function imx_avic_set_prio() is unused; delete it. Signed-off-by: Peter Maydell Message-id: 1410723223-17711-3-git-send-email-peter.mayd...@linaro.org --- hw/intc/imx_avic.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/intc/imx_avic.c b/hw/intc/imx_avic.c index ec5f9ad..e48

[Qemu-devel] [PULL 08/19] target-arm: Don't handle c15_cpar changes via tb_flush()

2014-09-29 Thread Peter Maydell
At the moment we try to handle c15_cpar with the strategy of: * emit generated code which makes assumptions about its value * when the register value changes call tb_flush() to throw away the now-invalid generated code This works because XScale CPUs are always uniprocessor, but it's confusing

[Qemu-devel] [PULL 01/19] target-arm: Implement setting guest breakpoints

2014-09-29 Thread Peter Maydell
This patch adds support for setting guest breakpoints based on values the guest writes to the DBGBVR and DBGBCR registers. (It doesn't include the code to handle when these breakpoints fire, so has no guest-visible effect.) Signed-off-by: Peter Maydell Message-id: 1410523465-13400-2-git-send-emai

[Qemu-devel] [PULL 10/19] target-arm: Add SCR_EL3

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-3-git-send-email-edgar.igles...@gmail.com [PMM: apply offsetoflow32() to correct regdef] Signed-off-by: Peter Maydell --- target-arm/cpu.h| 19 ++- target-arm/helper.c | 35 ++

[Qemu-devel] [PULL 09/19] target-arm: Add HCR_EL2

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Reviewed-by: Greg Bellows Reviewed-by: Peter Maydell Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-2-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- target-arm/cpu.h| 36 target-arm/hel

[Qemu-devel] [PULL 11/19] target-arm: A64: Refactor aarch64_cpu_do_interrupt

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Introduce new_el and new_mode in preparation for future patches that add support for taking exceptions to and from EL2 and 3. No functional change. Reviewed-by: Peter Maydell Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-4-git-send-email-edgar.igles...@

Re: [Qemu-devel] [PULL 0/9] QMP queue

2014-09-29 Thread Peter Maydell
On 26 September 2014 20:03, Luiz Capitulino wrote: > The following changes since commit 81ab11a7a524d12412a59ef49c6b270671e62ea0: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2014-09-26 15:41:50 +0100) > > are available in the git repository at: > > > g

Re: [Qemu-devel] Timer issues with 2.1.1 and migration (was: latest rc: virtio-blk hangs forever after migration)

2014-09-29 Thread Andrey Korolyov
On Mon, Sep 29, 2014 at 10:25 PM, Marcelo Tosatti wrote: > Andrey, > > Can you get a trace of the guest (echo kvm > > /sys/kernel/debug/tracing/set_event; sleep 1s; cp > /sys/kernel/debug/tracing/trace /tmp/trace.txt) while it is in the 100% > cpu consumption state? > > Is it otherwise operational

[Qemu-devel] [PATCH v3] add input-send-event command

2014-09-29 Thread Marcelo Tosatti
Which allows specification of absolute/relative, up/down and console parameters. Suggested by Gerd Hoffman. Signed-off-by: Marcelo Tosatti --- qapi-schema.json | 17 +++ qmp-commands.hx | 63 + ui/input.c | 31

Re: [Qemu-devel] [PATCH] gdbstub: Allow target CPUs to specify watchpoint STOP_BEFORE_ACCESS flag

2014-09-29 Thread Max Filippov
On Tue, Sep 16, 2014 at 9:16 AM, Max Filippov wrote: > On Mon, Sep 15, 2014 at 9:15 PM, Peter Maydell > wrote: >> On 15 September 2014 20:59, Max Filippov wrote: >>> I've tested xtensa part and have noticed no difference with or without >>> this patch: >>> gdb connected to qemu gdbstub always s

[Qemu-devel] [PULL v2 1/9] tcg-sparc: Support addsub2_i64

2014-09-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 72 +- tcg/sparc/tcg-target.h | 4 +-- 2 files changed, 67 insertions(+), 9 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 40f2ec1..21981d8 100644 --- a

[Qemu-devel] [PULL v2 0/9] tcg-next queue

2014-09-29 Thread Richard Henderson
A replacement for the one from the 22nd. This one drops the patch that would have conflicted with Paolo's 12 mmu idx patch set. It also adjusts the aarch64 patch that Claudio objected to. Re-tested on x86_64 and aarch64. Please pull. r~ The following changes since commit b60a7726cc0f5cbb2ae

[Qemu-devel] [PULL v2 5/9] tcg-sparc: Rename ADDX/SUBX insns

2014-09-29 Thread Richard Henderson
The pre-v9 ADDX/SUBX insns were renamed ADDC/SUBC for v9. Standardizing on the v9 name makes things less confusing. Signed-off-by: Richard Henderson --- disas/sparc.c | 32 +++- tcg/sparc/tcg-target.c | 14 +++--- 2 files changed, 18 insertions(+), 28

[Qemu-devel] [PULL v2 2/9] tcg-sparc: Use ADDXC in addsub2_i64

2014-09-29 Thread Richard Henderson
On T4 and newer Sparc chips we have an add-with-carry insn that takes its input from %xcc instead of %icc. Signed-off-by: Richard Henderson --- disas/sparc.c | 3 +++ include/elf.h | 37 + tcg/sparc/tcg-target.c | 28 +++-

[Qemu-devel] [PULL v2 3/9] tcg-sparc: Fix setcond_i32 uninitialized value

2014-09-29 Thread Richard Henderson
We failed to swap c1 and c2 correctly for NE c2 == 0. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 08ca482..3b232d6 100644 --- a/tcg/sparc/tcg-target.c

[Qemu-devel] [PULL v2 4/9] tcg-sparc: Use ADDXC in setcond_i64

2014-09-29 Thread Richard Henderson
Similar to the ADDC tricks we use in setcond_i32. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 3b232d6..d0bd08c 100644 --- a/tcg/sparc/tcg-target.c +++ b/tc

[Qemu-devel] [PULL v2 6/9] tcg-sparc: Use UMULXHI instruction

2014-09-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- disas/sparc.c | 1 + tcg/sparc/tcg-target.c | 5 + tcg/sparc/tcg-target.h | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/disas/sparc.c b/disas/sparc.c index 22ceac3..8e755d1 100644 --- a/disas/sparc.c +++ b/disas/sparc.c @@

[Qemu-devel] [PULL v2 7/9] tcg-aarch64: Use 32-bit loads for qemu_ld_i32

2014-09-29 Thread Richard Henderson
The "old" qemu_ld opcode did not specify the size of the result, and so we had to assume full register width. With the new opcodes, we can narrow the result. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 27 +++ tcg/tcg-be-ldst.h| 5 +++-- 2 fi

[Qemu-devel] [PULL v2 8/9] qemu/compiler: Define QEMU_ARTIFICIAL

2014-09-29 Thread Richard Henderson
The combination of always_inline + artificial allows tiny inline functions to be written that do not interfere with debugging. In particular, gdb will not step into an artificial function. The always_inline attribute was introduced in gcc 4.2, and the artificial attribute was introduced in gcc 4.3

[Qemu-devel] [PULL v2 9/9] tcg: Always enable TCGv type checking

2014-09-29 Thread Richard Henderson
Instead of using structures, which imply some amount of overhead on certain ABIs, use pointer types. This actually reduces the size of the binaries vs a NON-debug build on ppc64 and x86_64, due to a reduction in the number of sign-extension insns. Signed-off-by: Richard Henderson --- tcg/tcg.h

Re: [Qemu-devel] [PATCH v3] add input-send-event command

2014-09-29 Thread Eric Blake
On 09/29/2014 12:56 PM, Marcelo Tosatti wrote: > > Which allows specification of absolute/relative, > up/down and console parameters. > > Suggested by Gerd Hoffman. > > Signed-off-by: Marcelo Tosatti > > --- > qapi-schema.json | 17 +++ > qmp-commands.hx | 63

Re: [Qemu-devel] [PATCH v3] add input-send-event command

2014-09-29 Thread Marcelo Tosatti
On Mon, Sep 29, 2014 at 01:12:44PM -0600, Eric Blake wrote: > On 09/29/2014 12:56 PM, Marcelo Tosatti wrote: > > > > Which allows specification of absolute/relative, > > up/down and console parameters. > > > > Suggested by Gerd Hoffman. > > > > Signed-off-by: Marcelo Tosatti > > > > --- > > q

[Qemu-devel] [Bug 1354167] Re: On VM restart: Could not open 'poppy.qcow2': Could not read snapshots: File too large

2014-09-29 Thread Nenad Cuturic
Todd, thank you for your post and advise. It helped me to fix the same problem with one of the virtual disks that became corrupted after ubuntu host release upgrade to 14.0.1 LTS I tried first to install qemu 2.1.2 from sources but without any improvement. qemu 1.7.2 could convert to raw img form

Re: [Qemu-devel] [PULL v3 14/15] virtio-pci: fix migration for pci bus master

2014-09-29 Thread Greg Kurz
On Mon, 29 Sep 2014 19:15:05 +0300 "Michael S. Tsirkin" wrote: > On Mon, Sep 22, 2014 at 07:28:57PM +0200, Greg Kurz wrote: > > On Thu, 18 Sep 2014 21:54:58 +0300 > > "Michael S. Tsirkin" wrote: > > > > > Current support for bus master (clearing OK bit) > > > together with the need to support g

Re: [Qemu-devel] [PATCH v1 3/3] monitor: add del completion for peripheral device

2014-09-29 Thread Hani Benhabiles
On Fri, Sep 26, 2014 at 01:29:41PM -0400, Luiz Capitulino wrote: > On Fri, 26 Sep 2014 13:25:45 -0400 > Luiz Capitulino wrote: > > > On Thu, 18 Sep 2014 15:53:21 +0800 > > Zhu Guihua wrote: > > > > > Add peripheral_device_del_completion() to let peripheral device del > > > completion > > > be

Re: [Qemu-devel] [PATCH 0/2] Virtio-9p live migration patchset

2014-09-29 Thread Benoît Canet
The Friday 26 Sep 2014 à 18:19:55 (+0300), Boris Sukholitko wrote : > This patchset is a small rebase of the 9p live migration patches made a year > ago by Benoit Canet. > > See http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg02190.html > for the previous thread. > > I took the liberty to

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: Add support for 9p migration.

2014-09-29 Thread Benoît Canet
The Friday 26 Sep 2014 à 18:19:56 (+0300), Boris Sukholitko wrote : > This patch is a rebase of Aneesh Kumar's and Benoit Canet's previous > work. > > Signed-off-by: Boris Sukholitko If Aneesh and me worked on this you should also keep our signed-off in addition of yours. Best regards Benoît

Re: [Qemu-devel] [PATCH v3 2/3] timers: Move NANOSECONDS_PER_SECONDS to timer.h for future reuse

2014-09-29 Thread Paolo Bonzini
Il 29/09/2014 18:04, Benoît Canet ha scritto: > On Wed, Sep 24, 2014 at 05:33:45PM +0200, Paolo Bonzini wrote: >> Il 24/09/2014 17:21, Benoît Canet ha scritto: >>> Reviewed-by: Eric Blake >>> Signed-off-by: Benoît Canet >>> --- >>> include/qemu/throttle.h | 2 -- >>> include/qemu/timer.h| 2

Re: [Qemu-devel] [PATCH v3 00/17] QOMify accelerator code

2014-09-29 Thread Paolo Bonzini
Il 26/09/2014 22:45, Eduardo Habkost ha scritto: > This is an attempt to convert the accel initialization and registration code > to be QOM-based. Some use cases for this are: > > * Isolating KVM-specific CPU initialization and compatibility code; > * Use compat_props to implement accelrator-spe

Re: [Qemu-devel] [PATCH v3 2/3] timers: Move NANOSECONDS_PER_SECONDS to timer.h for future reuse

2014-09-29 Thread Benoît Canet
On Mon, Sep 29, 2014 at 11:54:47PM +0200, Paolo Bonzini wrote: > Il 29/09/2014 18:04, Benoît Canet ha scritto: > > On Wed, Sep 24, 2014 at 05:33:45PM +0200, Paolo Bonzini wrote: > >> Il 24/09/2014 17:21, Benoît Canet ha scritto: > >>> Reviewed-by: Eric Blake > >>> Signed-off-by: Benoît Canet > >>

<    1   2   3   >