On 09/29/2014 03:41 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > > This patch-pair adds the QEMUSizedBuffer based in-memory QEMUFile > written by Stefan Berger and Joel Schopp. I've made some > fixes and modified the existing test-vmstate to use it for some test cases. > > While there's nothing other than test cases using it yet, I think > it's worth going in by itself, since I'm using it in two separate > patchsets (postcopy and visitor/BER) and Sanidhya uses it in > the periodic vmstate test world. In addition both microcheckpointing and > COLO have similar but independent implementations (although they both > have some extra-gotcha's so it might not be possible to reuse it), and > there was another implementation of the same thing in the Yabusame Postcopy > world. Thus it seems best to put in, if only to stop people writing yet > another implementation. > > Dave > > v5: > Fixes from Eric's comments; including a memory leak in an error path
Looks correct to me, so my R-b is valid. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
