From: ChenLiang
graphic_hw_update and vnc_refresh_server_surface aren't
need to do when no vnc client connected. It can reduce
lock contention, because vnc_refresh will hold global big
lock two millisecond every three seconds.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
---
ui/vnc.c | 10
Alex Bligh writes:
[...]
>>> +/* NB cirrus-vga default value is 8MB anyway, save if we
>>> + * monkey patch it to change the default when the qemu-kvm-migration
>>> + * machine parameter is selected
>>> + */
>>> +
>>
>> This is too hacky for my taste.
>> How about creating a new machine e.g. pc-
The while loop variabal is "bs1", but "bs" is always passed to
bdrv_snapshot_delete_by_id_or_name.
Signed-off-by: Zhang Haoyu
---
savevm.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/savevm.c b/savevm.c
index e19ae0a..2d8eb96 100644
--- a/savevm.c
+++ b/savev
Hi,
> Speaking about properties do I need to add something for display and
> head properties?
No.
cheers,
Gerd
$ ./qemu-img create -f qcow2 overlay \
-b 'json: { "file.driver":"ssh",
"file.host":"localhost",
"file.host_key_check":"no" }'
qemu-img: qobject/qdict.c:193: qdict_get_obj: Assertion `obj != ((void *)0)'
failed.
Aborted
A similar crash also happens if the file.
zhanghailiang writes:
> The second parameter of dump_error is unused, but one purpose of
> using this function is to report the error info.
>
> Use error_set to return the error info to the caller.
>
> Signed-off-by: zhanghailiang
The commit message doesn't explain this patch's benefit clearly.
> Subject: [Qemu-devel] [PATCH] ssh: Don't crash if either host or path is not
> specified.
>
> $ ./qemu-img create -f qcow2 overlay \
> -b 'json: { "file.driver":"ssh",
> "file.host":"localhost",
> "file.host_key_check":"no" }'
> qemu-img: qobject/qdict.c:193:
$ ./qemu-img create -f qcow2 overlay \
-b 'json: { "file.driver":"ssh",
"file.host":"localhost",
"file.host_key_check":"no" }'
qemu-img: qobject/qdict.c:193: qdict_get_obj: Assertion `obj != ((void *)0)'
failed.
Aborted
A similar crash also happens if the file.
On 2014/9/29 15:48, Markus Armbruster wrote:
zhanghailiang writes:
The second parameter of dump_error is unused, but one purpose of
using this function is to report the error info.
Use error_set to return the error info to the caller.
Signed-off-by: zhanghailiang
The commit message doesn'
zhanghailiang writes:
> Functions shouldn't return an error code and an Error object at the same time.
> Turn all these functions that returning Error object to void.
> We also judge if a function success or fail by reference to the local_err.
>
> Signed-off-by: zhanghailiang
>
> ---
> dump.c |
On Mo, 2014-09-29 at 15:00 +0800, arei.gong...@huawei.com wrote:
> graphic_hw_update and vnc_refresh_server_surface aren't
> need to do when no vnc client connected. It can reduce
> lock contention, because vnc_refresh will hold global big
> lock two millisecond every three seconds.
Added to vnc p
On 26.09.14 20:47, Don Slutz wrote:
> This adds synchronisation of the vcpu registers
> between Xen and QEMU.
>
> Signed-off-by: Don Slutz
Could you instead plug into the existing cpu_synchronize_registers()
framework and just implement register synchronization for the Xen side,
just like it's
"Zhang Haoyu" writes:
> The while loop variabal is "bs1", but "bs" is always passed to
> bdrv_snapshot_delete_by_id_or_name.
Please limit commit message line length to around 70 characters.
>
> Signed-off-by: Zhang Haoyu
> ---
> savevm.c | 11 +--
> 1 file changed, 5 insertions(+), 6
On So, 2014-09-28 at 16:54 +0200, Martin Decky wrote:
> http://patchwork.ozlabs.org/patch/390074/
>
> It is a rather simple patch adding support for the Pause key in the GTK
> UI. It should not cause any regressions. Please apply. Thanks.
Patch looks good but doesn't apply any more. Can you ple
On 26.09.14 14:44, Paolo Bonzini wrote:
> Il 26/09/2014 14:26, Alexander Graf ha scritto:
>>
>> Are you sure? Imagine one sysbus device includes another. We only want
>> to look at the region the lowest sysbus device exposes, no?
>
> IIUC this function is used to build the device tree.
Yes, it'
Markus Armbruster writes:
> Eric Blake writes:
>
>> Now that we know every expression is valid with regards to
>> its keys, we can add further tests that those keys refer to
>> valid types. With this patch, all references to a type (the
>> 'data': of command, type, union, and event, and the 're
> -Original Message-
> From: Richard W.M. Jones [mailto:rjo...@redhat.com]
> Sent: Monday, September 29, 2014 4:06 PM
> To: qemu-devel@nongnu.org
> Cc: Gonglei (Arei)
> Subject: [PATCH v2] ssh: Don't crash if either host or path is not specified.
>
> $ ./qemu-img create -f qcow2 overlay \
Il 29/09/2014 10:24, Alexander Graf ha scritto:
>
>
> On 26.09.14 14:44, Paolo Bonzini wrote:
>> Il 26/09/2014 14:26, Alexander Graf ha scritto:
>>>
>>> Are you sure? Imagine one sysbus device includes another. We only want
>>> to look at the region the lowest sysbus device exposes, no?
>>
>> IIU
On 26.09.14 04:53, Alexey Kardashevskiy wrote:
> On 09/26/2014 12:31 PM, David Gibson wrote:
>> On Thu, Sep 25, 2014 at 08:06:40PM +1000, Alexey Kardashevskiy wrote:
>>> On 09/25/2014 07:43 PM, Alexander Graf wrote:
On 25.09.14 09:02, Alexey Kardashevskiy wrote:
> The only case
Eric Blake writes:
> Now that we have a way to validate every type, we can also be
> stricter about enforcing that callers that want to bypass
> type safety in generated code. Prior to this patch, it didn't
> matter what value was associated with the key 'gen', but it
> looked odd that 'gen':'ye
The while loop variabal is "bs1",
but "bs" is always passed to bdrv_snapshot_delete_by_id_or_name.
Broken in commit a89d89d, v1.7.0.
v1 -> v2:
* add broken commit id to commit message
Signed-off-by: Zhang Haoyu
Reviewed-by: Markus Armbruster
---
savevm.c | 11 +--
1 file changed, 5 in
* Eric Blake (ebl...@redhat.com) wrote:
> On 09/17/2014 05:26 AM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > This is based on Stefan and Joel's patch that creates a QEMUFile that goes
> > to a memory buffer; from:
> >
> > http://lists.gnu.org/archive/html/qemu
On Mon, 29 Sep 2014 08:30:15 +0530
Bharata B Rao wrote:
> On Fri, Sep 26, 2014 at 05:29:02PM +0200, Igor Mammedov wrote:
> > On Thu, 4 Sep 2014 11:36:20 +0530
> > Bharata B Rao wrote:
> >
> > > Separate out CPU initialization code into a new routine
> > > ppc_new_cpu() so that it can be used f
On 2014/9/26 19:53, Igor Mammedov wrote:
On Tue, 23 Sep 2014 16:11:25 +0800
zhanghailiang wrote:
When do memory hotplug, if there is numa node, we should add
the memory size to the corresponding node memory size.
For now, it mainly affects the result of hmp command "info numa".
Signed-off-by
On Mon, 29 Sep 2014 10:58:04 +0800
Gu Zheng wrote:
> Hi Igor,
> On 09/26/2014 09:06 PM, Igor Mammedov wrote:
>
> > On Wed, 17 Sep 2014 09:24:00 +0800
> > Gu Zheng wrote:
> >
> >> Add cpu hotplug handler to PC_MACHINE, which will perform the acpi
> >> cpu hotplug callback via hotplug_handler AP
Hi,
> > /me wonders what happened to the input-send-event patch from marcelo,
> > see http://patchwork.ozlabs.org/patch/360649/
> >
> > According to patchwork I've picked it up. But it is neither upstream
> > nor in my local input branch. And I can't remember what happened :(
> > Marcelo, any
Hi,
> It doesn't matter, so users might release the modifier key or not.
> we should make both works
>
> 1)
> sendkey Ctrl-Scroll
> sendkey Ctrl-Scroll
Good to know this works.
> 2)
> sendkey Ctrl-Scroll-Scroll
Why? This tries to squeeze something into the sendkey interface which
it doesn't
Dropping cc: xiaw...@linux.ibm.com, because I got a "user unknown"
bounce.
Copying qemu-stable.
"Zhang Haoyu" writes:
> The while loop variabal is "bs1",
> but "bs" is always passed to bdrv_snapshot_delete_by_id_or_name.
> Broken in commit a89d89d, v1.7.0.
>
> v1 -> v2:
> * add broken commit i
On Mon, 09/29 13:26, Fam Zheng wrote:
> A new implementation for qemu_poll_ns based on epoll is introduced here
> to address the slowness of g_poll and ppoll when the number of fds are
> high.
>
> On my laptop this would reduce the virtio-blk on top of null-aio
> device's response time from 32 us
Hi,
> Series unifies different hotplug mechanisms to a recent
> hotplug-handler API and does shallow conversion of
> devices that still use legacy qdev hotplug to it dropping
> not used after that legacy hotplug path [29/30].
> It also relaces SCSI's own way to do hotplug/unplug with
> hotplug-h
Hi,
Here comes v2 of the vga patches, this time the two patch series
combined into one. Fixed issues found by David Gibson in review,
fixed some codestyle issues. Nothing major. Should be ready for
merge now, /me plans to send a pull req later this week, possibly
excluding patch #11 as I'd li
From: Benjamin Herrenschmidt
Not all platforms have a VGA BIOS, powerpc typically relies on
using the DISPI interface to initialize the card.
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: Gerd Hoffmann
Reviewed-by: David Gibson
---
hw/display/vga.c | 6 ++
1 file changed, 2 insert
From: Benjamin Herrenschmidt
Nowadays, we either share a surface with the host, or we create
a 32bpp ARGB console surface.
So we only need to draw/convert to 32bpp, enabling us to remove
all but one instance of vga_template.h inclusion (to be further
cleaned up), rgb_to_pixel_* etc...
Signed-of
From: Benjamin Herrenschmidt
And initialize it based on target endian
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: Gerd Hoffmann
Reviewed-by: David Gibson
---
hw/display/vga.c | 32 +++-
hw/display/vga_int.h | 1 +
2 files changed, 20 insertions(+), 1
Add a qemu extented register range to the standard vga mmio bar.
Right nowe there are two registers: One readonly register returning the
size of the region (so we can easily add more registers there if needed)
and one endian control register, so guests (especially ppc) can flip
the framebuffer end
From: Benjamin Herrenschmidt
It's no longer a template, we only instanciate the file once.
Keep it a #included file so the functions remain static.
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: Gerd Hoffmann
Reviewed-by: David Gibson
---
hw/display/{vga_template.h => vga-helpers.h} |
From: Benjamin Herrenschmidt
We only draw cursor on non-shared surfaces (so it seems...) and
these are always 32bpp
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: Gerd Hoffmann
Reviewed-by: David Gibson
---
hw/display/cirrus_vga.c | 64 +---
hw/display/cir
From: Benjamin Herrenschmidt
The test for surface_bits_per_pixel() isn't necessary anymore,
the 8bpp case never happens.
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: Gerd Hoffmann
Reviewed-by: David Gibson
---
hw/display/vga.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletio
From: Benjamin Herrenschmidt
We always use rgb_to_pixel32 nowadays.
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: Gerd Hoffmann
Reviewed-by: David Gibson
---
hw/display/cirrus_vga.c | 15 +--
hw/display/vga.c| 31 ++-
hw/display/vga_int.
From: Benjamin Herrenschmidt
All the macros used to generate different versions of vga_template.h
are now unnecessary, take them all out and remove the _32 suffix from
most functions.
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: Gerd Hoffmann
Reviewed-by: David Gibson
---
hw/display/
From: Benjamin Herrenschmidt
Provide different functions for converting from an LE vs a BE
framebuffer. We cannot rely on the simple cases always being
shared surfaces since cirrus will need to always shadow for
cursor emulation, so we need the full set of functions to
be able to later handle run
From: Benjamin Herrenschmidt
Include the endian state in the migration stream as an optional
subsection which we only include when the endian isn't the default,
thus enabling backward compatibility of the common case.
Signed-off-by: Benjamin Herrenschmidt
Changes by kraxel:
* Remove bochs dis
Hi Igor,
On 09/26/2014 09:37 PM, Igor Mammedov wrote:
> On Wed, 17 Sep 2014 09:24:03 +0800
> Gu Zheng wrote:
>
>> Introduce help function acpi_set_local_sts() to simplify acpi_cpu_plug_cb
>> and acpi_cpu_hotplug_init, so that we can keep bit setting in one place.
>>
>> Signed-off-by: Gu Zheng
>
From: "Dr. David Alan Gilbert"
This patch-pair adds the QEMUSizedBuffer based in-memory QEMUFile
written by Stefan Berger and Joel Schopp. I've made some
fixes and modified the existing test-vmstate to use it for some test cases.
While there's nothing other than test cases using it yet, I t
From: "Dr. David Alan Gilbert"
This is based on Stefan and Joel's patch that creates a QEMUFile that goes
to a memory buffer; from:
http://lists.gnu.org/archive/html/qemu-devel/2013-03/msg05036.html
Using the QEMUFile interface, this patch adds support functions for
operating on in-memory sized
From: "Dr. David Alan Gilbert"
Modify some of tests/test-vmstate.c to use the in memory file based
on QEMUSizedBuffer to provide basic testing of QEMUSizedBuffer and
the associated memory backed QEMUFile type.
Only some of the tests are changed so that the fd backed QEMUFile is
still tested.
Si
On Mon, 29 Sep 2014 17:22:08 +0800
Gu Zheng wrote:
> Hi Igor,
> On 09/26/2014 09:37 PM, Igor Mammedov wrote:
>
> > On Wed, 17 Sep 2014 09:24:03 +0800
> > Gu Zheng wrote:
> >
> >> Introduce help function acpi_set_local_sts() to simplify
> >> acpi_cpu_plug_cb and acpi_cpu_hotplug_init, so that w
Am 29.09.2014 um 10:38 hat Zhang Haoyu geschrieben:
> The while loop variabal is "bs1",
> but "bs" is always passed to bdrv_snapshot_delete_by_id_or_name.
> Broken in commit a89d89d, v1.7.0.
>
> v1 -> v2:
> * add broken commit id to commit message
>
> Signed-off-by: Zhang Haoyu
> Reviewed-by: M
On Mon, Sep 29, 2014 at 11:18:33AM +0200, Markus Armbruster wrote:
> > The while loop variabal is "bs1",
> > but "bs" is always passed to bdrv_snapshot_delete_by_id_or_name.
> > Broken in commit a89d89d, v1.7.0.
> >
> > v1 -> v2:
> > * add broken commit id to commit message
>
> Patch version info
On Sun, Sep 28, 2014 at 10:59:05AM +0800, Chen, Tiejun wrote:
> On 2014/9/3 9:40, Kay, Allen M wrote:
> >
> >
> >>-Original Message-
> >>From: Chen, Tiejun
> >>Sent: Monday, September 01, 2014 12:50 AM
> >>To: Michael S. Tsirkin
> >>Cc: xen-de...@lists.xensource.com; Kay, Allen M; qemu-deve
On 09/29/2014 05:47 PM, Igor Mammedov wrote:
> On Mon, 29 Sep 2014 17:22:08 +0800
> Gu Zheng wrote:
>
>> Hi Igor,
>> On 09/26/2014 09:37 PM, Igor Mammedov wrote:
>>
>>> On Wed, 17 Sep 2014 09:24:03 +0800
>>> Gu Zheng wrote:
>>>
Introduce help function acpi_set_local_sts() to simplify
On Sun, Sep 28, 2014 at 09:33:08PM +0100, Alex Bligh wrote:
> Hang on a second! v2 of this patch DID use a new virtual machine,
> called exactly that. I thought you were objecting to that and
> wanting a machine parameter instead! It's far easier with a new
> machine type, and I'd far prefer a new
Build fails with:
$ make
LINK qemu-nbd
Undefined symbols for architecture x86_64:
"_posix_fallocate", referenced from:
_raw_create in raw-posix.o
ld: symbol(s) not found for architecture x86_64
introduced by
06247428be raw-posix: Add falloc and full preallocation
Il 28/09/2014 03:48, Fam Zheng ha scritto:
> +virtio_scsi_complete_req(req);
> +} else {
> +assert(r = -EINPROGRESS);
> +}
> }
= instead of == here.
Apart from this, the patch looks good. Thanks!
Paolo
On Fri, Sep 26, 2014 at 09:28:05AM +, Igor Mammedov wrote:
> Changes since v1:
> * added usb-uas test
> * drop hotplug check in bus_add_child()
> * make SCSI & USB bus as default HotplugHandler
> * fixed dummy HBA hot(un)plug
> * fixed hotunplug on s390x
> * prevent hotplug of non h
On 29 Sep 2014, at 11:08, Michael S. Tsirkin wrote:
> On Sun, Sep 28, 2014 at 09:33:08PM +0100, Alex Bligh wrote:
>> Hang on a second! v2 of this patch DID use a new virtual machine,
>> called exactly that. I thought you were objecting to that and
>> wanting a machine parameter instead! It's far
On Mon, Sep 29, 2014 at 04:38:02PM +0800, Zhang Haoyu wrote:
> The while loop variabal is "bs1",
> but "bs" is always passed to bdrv_snapshot_delete_by_id_or_name.
> Broken in commit a89d89d, v1.7.0.
>
> v1 -> v2:
> * add broken commit id to commit message
>
> Signed-off-by: Zhang Haoyu
> Revie
On Fri, 26 Sep 2014, Don Slutz wrote:
> This adds synchronisation of the vcpu registers
> between Xen and QEMU.
>
> Signed-off-by: Don Slutz
[...]
> diff --git a/xen-hvm.c b/xen-hvm.c
> index 05e522c..e1274bb 100644
> --- a/xen-hvm.c
> +++ b/xen-hvm.c
> @@ -857,14 +857,48 @@ static void cpu_han
On Mon, 29 Sep 2014 17:44:27 +0800
Gu Zheng wrote:
> On 09/29/2014 05:47 PM, Igor Mammedov wrote:
>
> > On Mon, 29 Sep 2014 17:22:08 +0800
> > Gu Zheng wrote:
> >
> >> Hi Igor,
> >> On 09/26/2014 09:37 PM, Igor Mammedov wrote:
> >>
> >>> On Wed, 17 Sep 2014 09:24:03 +0800
> >>> Gu Zheng wrote
On Mon, Sep 29, 2014 at 09:06:22AM +0100, Richard W.M. Jones wrote:
> $ ./qemu-img create -f qcow2 overlay \
> -b 'json: { "file.driver":"ssh",
> "file.host":"localhost",
> "file.host_key_check":"no" }'
> qemu-img: qobject/qdict.c:193: qdict_get_obj: Assertion `o
-tracking branch 'remotes/bonzini/tags/for-upstream' into staging
(2014-09-26 15:41:50 +0100)
are available in the git repository at:
git://anongit.freedesktop.org/spice/qemu tags/pull-spice-20140929-1
for you to fetch changes up to 151623353f4a3da4daec29d658c10ef3b57bd462:
Simply switch function pointers when entering/leaving vga mode.
Allows to remove wrapper functions which do nothing but dispatch
calls depending on the current qxl mode.
Signed-off-by: Gerd Hoffmann
---
hw/display/qxl.c | 49 +
1 file changed, 9 in
Add a function to allow display emulations to switch the hwops
function pointers. This is useful for devices which have two
completely different operation modes. Typical case is the vga
compatibility mode vs. native mode in qxl and the upcoming
virtio-vga device.
Signed-off-by: Gerd Hoffmann
--
On Mon, 29 Sep 2014 13:16:08 +0300
"Michael S. Tsirkin" wrote:
> On Fri, Sep 26, 2014 at 09:28:05AM +, Igor Mammedov wrote:
> > Changes since v1:
> > * added usb-uas test
> > * drop hotplug check in bus_add_child()
> > * make SCSI & USB bus as default HotplugHandler
> > * fixed dummy
On Mon, Sep 29, 2014 at 01:26:29PM +0800, Fam Zheng wrote:
> +int qemu_epoll(GPollFD *fds, guint nfds, int64_t timeout)
> +{
> +/* A copy of last fd array, used to skip epoll_prepare when nothing
> + * changed. */
> +static GPollFD *last_fds;
> +static guint last_nfds;
> +/* An
On Mon, 29 Sep 2014, Stefano Stabellini wrote:
> On Fri, 26 Sep 2014, Don Slutz wrote:
> > This adds synchronisation of the vcpu registers
> > between Xen and QEMU.
> >
> > Signed-off-by: Don Slutz
>
> [...]
>
> > diff --git a/xen-hvm.c b/xen-hvm.c
> > index 05e522c..e1274bb 100644
> > --- a/xe
On Mon, Sep 29, 2014 at 01:26:29PM +0800, Fam Zheng wrote:
> +static bool g_poll_fds_changed(const GPollFD *fds_a, const guint nfds_a,
> + const GPollFD *fds_b, const guint nfds_b)
...
> +static inline int g_io_condition_from_epoll_events(int e)
> +{
Please don't use
On 2014-09-26 17:23, Peter Maydell wrote:
> On 26 September 2014 09:08, Edgar E. Iglesias
> wrote:
>> From: "Edgar E. Iglesias"
>>
>> Hi,
>>
>> This is a second round of AArch64 EL2/3 patches working on the exception
>> model. Among other things adding HVC/SMC, interrupt routing to EL2/3 and
>>
On Mon, Sep 29, 2014 at 12:28:04PM +0200, Igor Mammedov wrote:
> On Mon, 29 Sep 2014 13:16:08 +0300
> "Michael S. Tsirkin" wrote:
>
> > On Fri, Sep 26, 2014 at 09:28:05AM +, Igor Mammedov wrote:
> > > Changes since v1:
> > > * added usb-uas test
> > > * drop hotplug check in bus_add_child
On 29 September 2014 11:31, Jan Kiszka wrote:
> Sorry for hijacking the thread, but it seems related: These bits address
> AArch64, but what is the status of AArch32 /wrt hyp mode emulation?
> After playing with the "fast" model, I would be glad to find such
> support in QEMU rather sooner than la
On 26 September 2014 18:36, Michael Tokarev wrote:
> Here goes another trivial-patches pull request. Cleanups,
> travis.yml changes, coding style changes and a little
> bugfix for stable (avoiding running qom test twice).
>
> Please consider applying/pulling.
>
> Thanks,
>
> /mjt
>
> The followin
On 2014-09-29 12:41, Peter Maydell wrote:
> On 29 September 2014 11:31, Jan Kiszka wrote:
>> Sorry for hijacking the thread, but it seems related: These bits address
>> AArch64, but what is the status of AArch32 /wrt hyp mode emulation?
>> After playing with the "fast" model, I would be glad to fi
Hi, Michael
Would you give me some response?
I have pinged this patch series the third time. :(
Thanks a lot!
Best regards,
-Gonglei
> -Original Message-
> From: Gonglei (Arei)
> Sent: Monday, September 01, 2014 9:29 PM
> To: qemu-devel@nongnu.org
> Cc: m...@redhat.com; Huangweidong (C
Il 29/09/2014 12:11, Paolo Bonzini ha scritto:
> Il 28/09/2014 03:48, Fam Zheng ha scritto:
>> +virtio_scsi_complete_req(req);
>> +} else {
>> +assert(r = -EINPROGRESS);
>> +}
>> }
>
> = instead of == here.
>
> Apart from this, the patch looks good. Thanks!
Hmm, there's
Il 26/09/2014 11:28, Igor Mammedov ha scritto:
> to be used for conversion of SCSI and USB devices,
> and would allow to make every HBA/USB host switch
> to HotplugHandler API without touching each controller
> explicitly.
>
> Signed-off-by: Igor Mammedov
> ---
> hw/core/qdev.c | 19
Il 26/09/2014 11:28, Igor Mammedov ha scritto:
> It will allow explicitly mark device as not hotpluggable and
> avoid its creation with following error at realize time
> and destroying it afterwards anyway. Instead of it will
> error out even before instance of device is created.
>
> Signed-off-by
Il 26/09/2014 11:28, Igor Mammedov ha scritto:
> since bus_add_child() no longer cares if BUS is hotpluggable
> or not, there is no need in setting allow_hotplug field.
>
> Signed-off-by: Igor Mammedov
> ---
> hw/cpu/icc_bus.c | 8
> 1 file changed, 8 deletions(-)
>
> diff --git a/hw/c
Il 26/09/2014 11:28, Igor Mammedov ha scritto:
> check is too restrictive and does not allow
> to add childs to just created bus during hotplug
> when the bus is part of composite device.
>
> Removing check from bus_add_child() doesn't affect
> devices creatable with device_add/del commands since
On Sat, 27 Sep 2014 10:37:23 +
"Gonglei (Arei)" wrote:
> > > One thing I noticed is that the various devices end up with similar
> > > code in the end:
> > >
> > > object_initialize(&dev->vdev, sizeof(dev->vdev), TYPE_WHATEVER);
> > > object_property_add_child(obj, "virtio-backend",
Il 29/09/2014 10:12, Alexander Graf ha scritto:
> Could you instead plug into the existing cpu_synchronize_registers()
> framework and just implement register synchronization for the Xen side,
> just like it's been done for KVM? :)
No, because here it's Xen that sends out the register contents. W
On Fri, Sep 26, 2014 at 09:28:19AM +, Igor Mammedov wrote:
> 'HotplugHandler.unplug' callback is currently used as async
> call to issue unplug request for device that implements it.
> Renaming 'unplug' callback to 'unplug_request' should help to
> avoid confusion about what callback does and w
On 26 September 2014 17:35, Stefan Hajnoczi wrote:
> Some hosts are slow or overloaded so test execution takes a long time.
> Test cases use timeouts to protect against an infinite loop stalling the
> test forever (especially important in automated test setups).
>
> Commit 6cd14054b67774cc58a51fca
On Fri, 26 Sep 2014 16:45:38 +0800
wrote:
> Gonglei (9):
> virtio-net: use aliases instead of duplicate qdev properties
> virtio: fix virtio-net child refcount in transports
> virtio/vhost scsi: use aliases instead of duplicate qdev properties
> virtio/vhost-scsi: fix virtio-scsi/vhost-sc
On 29.09.14 13:10, Paolo Bonzini wrote:
> Il 29/09/2014 10:12, Alexander Graf ha scritto:
>> Could you instead plug into the existing cpu_synchronize_registers()
>> framework and just implement register synchronization for the Xen side,
>> just like it's been done for KVM? :)
>
> No, because her
On 28/09/2014 18:33, Juan Quintela wrote:
Hi
Please, send any topic that you are interested in covering.
Call details:
15:00 CEST
13:00 UTC
09:00 EDT
Every two weeks
By popular demand, a google calendar public entry with it
https://www.google.com/calendar/embed?src=dG9iMXRqcXAz
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
> Add a BlockBackend member to TrimAIOCB, so ide_issue_trim_cb() can use
> blk_aio_discard() instead of bdrv_aio_discard().
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
> Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
> From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com]
> Sent: Monday, September 29, 2014 6:53 PM
> Subject: Re: [PATCH RESEND 0/9] virtio: fix virtio child recount in transports
>
> On Sat, 27 Sep 2014 10:37:23 +
> "Gonglei (Arei)" wrote:
>
> > > > One thing I noticed is that the various d
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
> Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
Update rtc_cmos in pc_cpu_plug directly instead of the notifier.
v4:
-Make link property in PCMachine rather than the global
variables.
-Split out the removal of unused notifier into separate patch.
Signed-off-by: Gu Zheng
---
hw/i386/pc.c | 37
v4:
-convert CPUState *cpu to DeviceState *dev like it's done for other handlers
and do cast to CPU inside.
v2:
-add errp argument to catch error.
-return error instead of aborting if cpu id is invalid.
-make acpi_cpu_plug_cb as a wrapper around AcpiCpuHotplug_add.
Signed-off-by: Gu Zheng
Previously we use cpu_added_notifiers to register cpu hotplug notifier callback
which is not able to pass/handle errors, so we switch it to unified hotplug
handler API which allows to pass errors and would allow to cancel device_add
in case of error.
Thanks very much for Igor's review and suggestio
Il 29/09/2014 13:53, Alexander Graf ha scritto:
>
> cpu_handle_ioreq()
> {
> ...
>
> if (req->type == IOPORT_REGISTERS_SYNCHRONIZED) {
> cpu->xen_vcpu_dirty = true;
> synchronize_xen_to_env(xenptr, cpu);
> }
>
> handle_ioreq();
>
> if (req->type == IOPORT
On Thu, 2014-09-11 at 02:23 +0100, Stefano Stabellini wrote:
Stefano,
In the context of this patch could you also take a look at Owen's xenfb
documentation patches[0], I think you probably know the most about this
particular protocol.
Ian.
[0] <1411376699-8175-1-git-send-email-owen.sm...@citrix
Convert notifier based hotplug handle to hotplug_handler API.
Signed-off-by: Gu Zheng
---
hw/acpi/ich9.c | 13 ++---
include/hw/acpi/ich9.h |1 -
2 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index 7b14bbb..7585364 100644
--
Convert notifier based hotplug handle to hotplug_handler API,
and remove the unused AcpiCpuHotplug_add().
v2:
-remove the unused AcpiCpuHotplug_add().
Signed-off-by: Gu Zheng
---
hw/acpi/cpu_hotplug.c | 14 ++
hw/acpi/piix4.c | 14 ++
include/hw
Introduce help function acpi_set_local_sts() to simplify acpi_cpu_plug_cb
and acpi_cpu_hotplug_init, so that we can keep bit setting in one place.
Signed-off-by: Gu Zheng
---
hw/acpi/cpu_hotplug.c | 23 +++
1 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/hw/
Rename:
AcpiCpuHotplug_init --> acpi_cpu_hotplug_init
AcpiCpuHotplug_ops --> acpi_cpu_hotplug_ops
for better readability, just cleanup.
Signed-off-by: Gu Zheng
---
hw/acpi/cpu_hotplug.c |4 ++--
hw/acpi/ich9.c|4 ++--
hw/acpi/piix4.c |4 ++--
inc
Signed-off-by: Gu Zheng
---
include/sysemu/sysemu.h |3 ---
qom/cpu.c |9 -
2 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index d8539fd..acfe494 100644
--- a/include/sysemu/sysemu.h
+++ b/include/sys
Add cpu hotplug handler to PC_MACHINE, which will perform the acpi
cpu hotplug callback via hotplug_handler API.
v3:
-deal with start up cpus in a more neat way as Igor suggested.
v2:
-just rebase.
Signed-off-by: Gu Zheng
---
hw/i386/pc.c | 26 +-
1 files changed, 25
1 - 100 of 262 matches
Mail list logo
