Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-17 Thread Markus Armbruster
Anthony Liguori writes: > On Tue, Sep 9, 2014 at 8:31 PM, Chun Yan Liu wrote: >> >> > On 9/10/2014 at 02:23 AM, in message > <87tx4girg6@blackfin.pond.sub.org>, >> Markus Armbruster wrote: >>> "Chun Yan Liu" writes: >>> >>> On 9/6/2014 at 05:23 AM, in message >>> > , Stefano >>

Re: [Qemu-devel] vmw_pvscsi: QEMU stuck in SeaBIOS when pvscsi is enabled

2014-09-17 Thread Igor Mammedov
On Wed, 17 Sep 2014 07:12:42 +0800 Asias He wrote: > Hello Paolo, > > > On Tue, Sep 16, 2014 at 10:33 PM, Paolo Bonzini wrote: > > > Il 16/09/2014 16:25, Igor Mammedov ha scritto: > > > Current master cc35a44cf7b522b, > > > > > > QEMU is not able to boot an stuck in SeaBIOS (only SeaBIOS vers

[Qemu-devel] [PATCH] vnc-tls: Clean up dead store in vnc_set_x509_credential()

2014-09-17 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- ui/vnc-tls.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c index 6392326..0f59f9b 100644 --- a/ui/vnc-tls.c +++ b/ui/vnc-tls.c @@ -444,8 +444,6 @@ static int vnc_set_x509_credential(VncDisplay *vd, struct stat sb;

Re: [Qemu-devel] [PATCH 1/1] loader: g_realloc(p, 0) frees and returns NULL, simplify

2014-09-17 Thread Markus Armbruster
Ping? Markus Armbruster writes: > "Michael S. Tsirkin" writes: > >> On Wed, Aug 20, 2014 at 08:38:11PM +0200, Markus Armbruster wrote: >>> Once upon a time, it was decided that qemu_realloc(ptr, 0) should >>> abort. Switching to glib retired that bright idea. A bit of code >>> that was added

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-17 Thread Gal Hammer
Hi Igor, - Original Message - > From: "Igor Mammedov" > To: "Gal Hammer" > Cc: pbonz...@redhat.com, qemu-devel@nongnu.org > Sent: Tuesday, September 16, 2014 5:54:28 PM > Subject: Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation > ID device. > > On Tue, 16 Sep 2014 1

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-17 Thread Peter Maydell
On 17 September 2014 00:04, Markus Armbruster wrote: > Anthony Liguori writes: >> You should fix TigerVNC. It's broken if it isn't sending repeat events. > > It *is* sending repeat events. The commit message says so, and I > tested it to confirm. The question of course is what "repeat events"

Re: [Qemu-devel] vhost-user:is miss command VHOST_NET_SET_BACKEND?

2014-09-17 Thread Linhaifeng
sorry it is not need to add VHOST_NET_SET_BACKEND.I found i can reset in VHOST_GET_VRING_BASE because before the backend cleanup it will send VHOST_GET_VRING_BASE. On 2014/9/17 13:50, Linhaifeng wrote: > Hi, > > The VHOST_NET_SET_BACKEND could tell the user when the backend is created or > des

[Qemu-devel] [PATCH v2] target-i386: update fp status fix

2014-09-17 Thread Pavel Dovgalyuk
This patch introduces cpu_set_fpuc() function, which changes fpuc field of the CPU state and calls update_fp_status() function. These calls update status of softfloat library and prevent bugs caused by non-coherent rounding settings of the FPU and softfloat. v2 changes: * Added missed calls and i

Re: [Qemu-devel] [PATCH v2] target-i386: update fp status fix

2014-09-17 Thread TeLeMan
On Wed, Sep 17, 2014 at 4:05 PM, Pavel Dovgalyuk wrote: > This patch introduces cpu_set_fpuc() function, which changes fpuc field > of the CPU state and calls update_fp_status() function. > These calls update status of softfloat library and prevent bugs caused > by non-coherent rounding settings o

Re: [Qemu-devel] [PATCH 2/2] numa/pc-dimm: Fix stat of memory size in node when hotplug memory

2014-09-17 Thread zhanghailiang
On 2014/9/16 19:20, Igor Mammedov wrote: On Tue, 16 Sep 2014 18:39:16 +0800 zhanghailiang wrote: When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. For now, it mainly affects the result of hmp command "info numa". Signed-off-by

[Qemu-devel] [RFC V7 01/10] migration: make qemu_savevm_state public.

2014-09-17 Thread fred . konrad
From: KONRAD Frederic This makes qemu_savevm_state public for reverse-execution. Signed-off-by: KONRAD Frederic Reviewed-by: Amit Shah Reviewed-by: Juan Quintela --- include/sysemu/sysemu.h | 1 + savevm.c| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/i

[Qemu-devel] [RFC V7 00/10] Reverse execution.

2014-09-17 Thread fred . konrad
From: KONRAD Frederic Hi everybody, This is the seventh version of this RFC (see the changes below). The first patches: migration: make qemu_savevm_state public. icount: introduce icount timer. icount: check for icount clock deadline when cpu loop exits. icount: make icount extra comput

[Qemu-devel] [RFC V7 05/10] trace-events: add reverse-execution events.

2014-09-17 Thread fred . konrad
From: KONRAD Frederic This adds some trace-events for reverse execution. Signed-off-by: KONRAD Frederic --- trace-events | 6 ++ 1 file changed, 6 insertions(+) diff --git a/trace-events b/trace-events index fb58963..573dea9 100644 --- a/trace-events +++ b/trace-events @@ -1318,3 +1318,9

[Qemu-devel] [RFC V7 06/10] introduce reverse execution mechanism.

2014-09-17 Thread fred . konrad
From: KONRAD Frederic This introduces the basic reverse-execution mechanism. Signed-off-by: KONRAD Frederic --- Makefile.target | 1 + cpus.c | 6 + include/reverse-execution.h | 41 ++ reverse-execution.c | 308

[Qemu-devel] [RFC V7 08/10] cpu-exec: trigger a debug request when rexec stops.

2014-09-17 Thread fred . konrad
From: KONRAD Frederic This allows QEMU to trigger a debug exception when rexec_dbg_requested is set. Signed-off-by: KONRAD Frederic --- cpu-exec.c | 13 + 1 file changed, 13 insertions(+) diff --git a/cpu-exec.c b/cpu-exec.c index bd93165..be2070d 100644 --- a/cpu-exec.c +++ b/cpu

[Qemu-devel] [RFC V7 02/10] icount: introduce icount timer.

2014-09-17 Thread fred . konrad
From: KONRAD Frederic This introduces a new timer based only on instruction counter and without any compensation. Signed-off-by: KONRAD Frederic --- cpus.c | 21 + include/qemu/timer.h | 9 - qemu-timer.c | 8 +++- stubs/cpu-get-ico

[Qemu-devel] [RFC V7 10/10] rexec: allow to enable reverse execution.

2014-09-17 Thread fred . konrad
From: KONRAD Frederic This creates QEMU options for reverse execution. Signed-off-by: KONRAD Frederic --- cpus.c | 15 +++ qemu-options.hx | 5 - vl.c| 9 +++-- 3 files changed, 26 insertions(+), 3 deletions(-) diff --git a/cpus.c b/cpus.c index 742f

[Qemu-devel] [RFC V7 07/10] gdbstub: allow reverse execution in gdb stub.

2014-09-17 Thread fred . konrad
From: KONRAD Frederic This allows gdb to reverse step QEMU: reverse-stepi and reverse-cont commands are allowed. When step_backward is called, QEMU restores a snapshot before the actual instruction and stops (with a debug exit) when the previous instruction is reached. Signed-off-by: KONRAD Fre

[Qemu-devel] [RFC V7 03/10] icount: check for icount clock deadline when cpu loop exits.

2014-09-17 Thread fred . konrad
From: KONRAD Frederic Notify events on icount clock when CPU loop exits. Signed-off-by: KONRAD Frederic Reviewed-by: Paolo Bonzini --- cpus.c | 5 + 1 file changed, 5 insertions(+) diff --git a/cpus.c b/cpus.c index 0ae6798..2e9e2ea 100644 --- a/cpus.c +++ b/cpus.c @@ -1030,6 +1030,11 @@

[Qemu-devel] [RFC V7 09/10] rexec: synchronize icount on the next event.

2014-09-17 Thread fred . konrad
From: KONRAD Frederic We don't want to warp on host clock as it is not deterministic for replay. So this patch warp icount on the next QEMU_VIRTUAL_CLOCK event if reverse execution is enabled. The normal behaviour is kept when reverse execution is disabled. Signed-off-by: KONRAD Frederic ---

[Qemu-devel] [RFC V7 04/10] icount: make icount extra computed on icount clock as well.

2014-09-17 Thread fred . konrad
From: KONRAD Frederic This takes icount clock in account for icount extra computation so icount clock's timers will be triggered at the exact time. Signed-off-by: KONRAD Frederic Reviewed-by: Paolo Bonzini --- cpus.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/cpus.c b/cpu

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-17 Thread Hu Tao
On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: > If we do not configure numa option, memory hotplug should work as well. > It should not depend on numa option. > > Steps to reproduce: > (1) Start VM: qemu-kvm -m 1024,slots=4,maxmem=8G > (2) Hotplug memory > It will fail and reports

[Qemu-devel] vhost-user: VHOST_SET_MEM_TABLE, VHOST_SET_VRING_CALL need a reply?

2014-09-17 Thread Michael S. Tsirkin
Reply-To: Thinking about the vhost-user protocol, VHOST_SET_MEM_TABLE is used to update the memory mappings. So shouldn't we want for response? Otherwise e.g. guest can start using the memory that vhost-user can't access. Similarly, with an IOMMU vhost-user might access memory it shouldn't. VH

Re: [Qemu-devel] [PATCH 03/14] target-ppc: use separate indices for various translation modes

2014-09-17 Thread Paolo Bonzini
Il 17/09/2014 08:22, Paolo Bonzini ha scritto: > >> What if instead of having a "mmu_index" for the mmu arrays, we have a pointer >> to the "mmu context". This does imply an extra memory load on the fast path, >> but probably not an extra instruction. >> >> With this, we can suddenly afford to ha

Re: [Qemu-devel] Data classification in Qemu

2014-09-17 Thread Stefan Hajnoczi
On Tue, Sep 16, 2014 at 11:03:04PM +0800, Wu Libin wrote: > Yeah, i know dm-cache, it’s in the layer of block. > > Maybe my description is not clear enough.Just because i see a patch, it will > set flags which can classify IO size in bio->bi_flags, and in the function > sd_prep_fn, it will set t

Re: [Qemu-devel] vhost-user:is miss command VHOST_NET_SET_BACKEND?

2014-09-17 Thread Michael S. Tsirkin
I guess it's a workaround, but I think it's an ugly one. Let's add this command properly. What's the best way to do this? A feature bit? Or just add a new command and assume remote ignores what it can't handle? Nikolay, docs/specs/vhost-user.txt seems silent on this aspect. Can you send a patch d

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed

2014-09-17 Thread Stefan Hajnoczi
On Tue, Sep 16, 2014 at 02:10:39PM +0200, Paolo Bonzini wrote: > Il 16/09/2014 14:02, Alexey Kardashevskiy ha scritto: > > I am having problems when migrate a guest via libvirt like this: > > > > virsh migrate --live --persistent --undefinesource --copy-storage-all > > --verbose --desturi qemu+ssh

Re: [Qemu-devel] [PATCH v2] target-i386: update fp status fix

2014-09-17 Thread Paolo Bonzini
Il 17/09/2014 10:05, Pavel Dovgalyuk ha scritto: > This patch introduces cpu_set_fpuc() function, which changes fpuc field > of the CPU state and calls update_fp_status() function. > These calls update status of softfloat library and prevent bugs caused > by non-coherent rounding settings of the FP

Re: [Qemu-devel] [PATCH V2] image-fuzzer: Trivial readability and formatting improvements

2014-09-17 Thread Stefan Hajnoczi
On Sun, Sep 14, 2014 at 04:07:02PM +0400, Maria Kustova wrote: > Signed-off-by: Maria Kustova > --- > > v1 -> v2: > * Simplified format of test result strings (based on the review of Fam Zheng > and Markus Armbruster). > * Reverted signature of the 'fuzz.selector()' function (based on the review

Re: [Qemu-devel] [PATCH v3] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Chrysostomos Nanakos
On 09/16/2014 10:40 PM, Eric Blake wrote: On 09/16/2014 12:04 PM, Chrysostomos Nanakos wrote: If event_notifier_init fails QEMU exits without printing any error information to the user. This commit adds an error message on failure: # qemu [...] Showing the actual command line you used would

Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on qdev_device_help()

2014-09-17 Thread Gonglei (Arei)
> > >> > > >> Doesn't this leak prop_list when local_err && prop_list? > > >> > > > No, it will not happen this situation. > > > > > >> Returning both a value in need of destruction and an error object is at > > >> least highly unusual, and probably plain wrong. > > >> > > >> Should qmp_device_list

Re: [Qemu-devel] vhost-user: VHOST_SET_MEM_TABLE, VHOST_SET_VRING_CALL need a reply?

2014-09-17 Thread Linhaifeng
I think maybe is not need for the backend to wait for response. There is another way.vhost-user send "VHOST_GET_MEM_TABLE" to qemu then qemu send VHOST_SET_MEM_TABLE to update the regions of vhost-user.same as other command. If qemu could response the request of the vhost-user.the vhost-user cou

Re: [Qemu-devel] [PATCH] Prevent segmentation fault in case of relative resolve of uri

2014-09-17 Thread Stefan Hajnoczi
On Tue, Sep 09, 2014 at 09:45:06AM +0200, mreza...@redhat.com wrote: > From: Miroslav Rezanina > > It was possible to call strcmp with NULL argument, that can cause > segmentation fault. Properly checking parameters to prevent this > situation. > > Signed-off-by: Miroslav Rezanina > --- > util

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-17 Thread Markus Armbruster
Peter Maydell writes: > On 17 September 2014 00:04, Markus Armbruster wrote: >> Anthony Liguori writes: >>> You should fix TigerVNC. It's broken if it isn't sending repeat events. >> >> It *is* sending repeat events. The commit message says so, and I >> tested it to confirm. > > The question

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed

2014-09-17 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 17/09/2014 11:06, Stefan Hajnoczi ha scritto: > I think the fundamental problem here is that the mirror block job > on the source host does not synchronize with live migration. > > Remember the mirror block job iterates on the dirty bitmap > whene

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-17 Thread zhanghailiang
On 2014/9/17 16:32, Hu Tao wrote: On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: If we do not configure numa option, memory hotplug should work as well. It should not depend on numa option. Steps to reproduce: (1) Start VM: qemu-kvm -m 1024,slots=4,maxmem=8G (2) Hotplug memory I

Re: [Qemu-devel] vhost-user: VHOST_SET_MEM_TABLE, VHOST_SET_VRING_CALL need a reply?

2014-09-17 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 05:39:04PM +0800, Linhaifeng wrote: > I think maybe is not need for the backend to wait for response. > > There is another way.vhost-user send "VHOST_GET_MEM_TABLE" to qemu then qemu > send VHOST_SET_MEM_TABLE to update the regions of vhost-user.same as other > command. >

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-17 Thread Igor Mammedov
On Wed, 17 Sep 2014 03:36:58 -0400 (EDT) Gal Hammer wrote: > Hi Igor, > > - Original Message - > > From: "Igor Mammedov" > > To: "Gal Hammer" > > Cc: pbonz...@redhat.com, qemu-devel@nongnu.org > > Sent: Tuesday, September 16, 2014 5:54:28 PM > > Subject: Re: [Qemu-devel] [PATCH 2/2] i3

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-17 Thread Tang Chen
Add Andrey Korolyov On 09/17/2014 04:32 PM, Hu Tao wrote: On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: If we do not configure numa option, memory hotplug should work as well. It should not depend on numa option. Steps to reproduce: (1) Start VM: qemu-kvm -m 1024,slots=4,maxm

Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on qdev_device_help()

2014-09-17 Thread Markus Armbruster
"Gonglei (Arei)" writes: >> > >> >> > >> Doesn't this leak prop_list when local_err && prop_list? >> > >> >> > > No, it will not happen this situation. >> > > >> > >> Returning both a value in need of destruction and an error object is at >> > >> least highly unusual, and probably plain wrong. >>

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-17 Thread Andrey Korolyov
On Wed, Sep 17, 2014 at 2:00 PM, Tang Chen wrote: > Add Andrey Korolyov > > On 09/17/2014 04:32 PM, Hu Tao wrote: >> >> On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: >>> >>> If we do not configure numa option, memory hotplug should work as well. >>> It should not depend on numa o

Re: [Qemu-devel] [PATCH v3 1/2] QEMUSizedBuffer based QEMUFile

2014-09-17 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > This is based on Stefan and Joel's patch that creates a QEMUFile that goes > to a memory buffer; from: Actually, just spotted a bug in this; v4 coming shortly. Dave > > http://lists.gnu.org/archiv

[Qemu-devel] [PATCH] vhost-scsi: use virtio_ldl_p

2014-09-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi/vhost-scsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index 7146e0e..308b393 100644 --- a/hw/scsi/vhost-scsi.c +++ b/hw/scsi/vhost-scsi.c @@ -23,6 +23,7 @@ #include "hw/virtio/vho

Re: [Qemu-devel] [PATCH] vhost-scsi: use virtio_ldl_p

2014-09-17 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 12:41:13PM +0200, Paolo Bonzini wrote: I'm guessing you are fixing cross-endian configs? Commit log should mention this? > Signed-off-by: Paolo Bonzini > --- > hw/scsi/vhost-scsi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/scsi/vho

Re: [Qemu-devel] [PATCH] qemu-char: Do not disconnect when there's data for reading

2014-09-17 Thread Zifei Tong
On Tue, Sep 16, 2014 at 11:30 PM, Kirill Batuzov wrote: > On Tue, 16 Sep 2014, Markus Armbruster wrote: > >> >> Kirill, you added the code being changed. Could you review the patch? >> > > I'll try but this is more about GIOConditions which I do not understand > well. See below. > > Zifei Tong w

Re: [Qemu-devel] [PATCH] vhost-scsi: use virtio_ldl_p

2014-09-17 Thread Paolo Bonzini
Il 17/09/2014 12:47, Michael S. Tsirkin ha scritto: > On Wed, Sep 17, 2014 at 12:41:13PM +0200, Paolo Bonzini wrote: > > I'm guessing you are fixing cross-endian configs? Yes. Found only by inspection, though. > Commit log should mention this? Will do. Paolo

Re: [Qemu-devel] [Important] Query regarding bdrv_co_discard

2014-09-17 Thread Stefan Hajnoczi
On Thu, Sep 11, 2014 at 01:53:49AM -0700, Sanjay Kumar2 wrote: > 1. With my new network based disk protocol, if I use 'raw' format, then it > is working perfectly. But, when I am using 'qcow2' format, then is it causing > issue. After debugging I found that it is returning because > bdrv_get_ge

Re: [Qemu-devel] [PATCH v3 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-17 Thread Benoît Canet
On Tue, Sep 16, 2014 at 08:12:15PM +0200, Markus Armbruster wrote: > -s->enabled = dinfo ? bdrv_is_inserted(dinfo->bdrv) : 0; > +s->enabled = bs && bdrv_is_inserted(bs); This is not so mechanical but seems correct anyway. Reviewed-by: Benoit Canet

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-17 Thread Gerd Hoffmann
Hi, > Which brings us to the other half of this: what does our > UI layer specify should be the behaviour for key repeat? > Gerd, can you clarify what the common input layer's expectation > is here? Should UI front ends call qemu_input_event_send_key() > with 'down/down/down/up' or 'down/up/down

[Qemu-devel] [PATCH v4 2/2] Tests: QEMUSizedBuffer/QEMUBuffer

2014-09-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Modify some of tests/test-vmstate.c to use the in memory file based on QEMUSizedBuffer to provide basic testing of QEMUSizedBuffer and the associated memory backed QEMUFile type. Only some of the tests are changed so that the fd backed QEMUFile is still tested. Si

[Qemu-devel] [PATCH v4 0/2] In memory QEMUFile

2014-09-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, This patch-pair adds the QEMUSizedBuffer based in-memory QEMUFile written by Stefan Berger and Joel Schopp. I've made some fixes and modified the existing test-vmstate to use it for some test cases. While there's nothing other than test cases using it yet,

[Qemu-devel] [PATCH v4 1/2] QEMUSizedBuffer based QEMUFile

2014-09-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This is based on Stefan and Joel's patch that creates a QEMUFile that goes to a memory buffer; from: http://lists.gnu.org/archive/html/qemu-devel/2013-03/msg05036.html Using the QEMUFile interface, this patch adds support functions for operating on in-memory sized

[Qemu-devel] [PATCH] block: Validate node-name

2014-09-17 Thread Kevin Wolf
The device_name of a BlockDriverState is currently checked because it is always used as a QemuOpts ID and qemu_opts_create() checks whether such IDs are wellformed. node-name is supposed to share the same namespace, but it isn't checked currently. This patch adds explicit checks both for device_na

Re: [Qemu-devel] [PATCH v3 12/23] virtio-blk: Drop redundant VirtIOBlock member conf

2014-09-17 Thread Benoît Canet
On Tue, Sep 16, 2014 at 08:12:17PM +0200, Markus Armbruster wrote: > Commit 12c5674 turned it into a pointer to member blk.conf. > > Signed-off-by: Markus Armbruster > --- > hw/block/virtio-blk.c | 28 ++-- > include/hw/virtio/virtio-blk.h | 1 - > 2 files chang

Re: [Qemu-devel] [PATCH v3 13/23] virtio-blk: Rename VirtIOBlkConf variables to conf

2014-09-17 Thread Benoît Canet
> -if (size % dev->blk.conf.logical_block_size) { > +if (size % dev->conf.conf.logical_block_size) { This look strange (conf.conf) Anyway this seems correct. Reviewed-by: Benoit Canet

Re: [Qemu-devel] [PATCH] vnc-tls: Clean up dead store in vnc_set_x509_credential()

2014-09-17 Thread Gerd Hoffmann
On Mi, 2014-09-17 at 09:33 +0200, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > ui/vnc-tls.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c > index 6392326..0f59f9b 100644 > --- a/ui/vnc-tls.c > +++ b/ui/vnc-tls.c > @@ -444,8 +444,6 @@

[Qemu-devel] [PATCH] slirp: udp: fix NULL pointer dereference because of uninitialized socket

2014-09-17 Thread Petr Matousek
When guest sends udp packet with source port and source addr 0, uninitialized socket is picked up when looking for matching and already created udp sockets, and later passed to sosendto() where NULL pointer dereference is hit during so->slirp->vnetwork_mask.s_addr access. Fix this by checking that

Re: [Qemu-devel] [PATCH v3 17/23] blockdev: Drop superfluous DriveInfo member id

2014-09-17 Thread Benoît Canet
On Tue, Sep 16, 2014 at 08:12:22PM +0200, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > block/block-backend.c | 1 - > blockdev.c| 3 +-- > include/sysemu/blockdev.h | 1 - > 3 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/block/block-ba

Re: [Qemu-devel] [PATCH v3 16/23] pc87312: Drop unused members of PC87312State

2014-09-17 Thread Benoît Canet
On Tue, Sep 16, 2014 at 08:12:21PM +0200, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > include/hw/isa/pc87312.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/hw/isa/pc87312.h b/include/hw/isa/pc87312.h > index befc8bd..bf74470 100644 > --- a/include/hw

[Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-09-17 Thread Gal Hammer
Add a 16-bytes buffer to allow storing a 128-bit UUID value in an ACPI table. Signed-off-by: Gal Hammer Reviewed-by: Paolo Bonzini --- scripts/acpi_extract.py | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/scripts/acpi_extract.py b/scripts/acpi_extr

Re: [Qemu-devel] [PATCH] block: Validate node-name

2014-09-17 Thread Benoît Canet
> +int qemu_opts_id_wellformed(const char *id) This return 0 and 1 as a bool. Could we make the function return bool in the same series ? I wonder what are the possible interferences between !strchr("-._", id[i]) and Jeff's node name auto naming series.

[Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-17 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table. The GUID is set using a new "vmgenid" device. Signed-off-by: Gal Hammer Reviewed-By: Igor Mammedov --- default-configs/i386-softmmu

[Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID

2014-09-17 Thread Gal Hammer
Hi, A two parts patch to add a QEmu support for Microsoft's Virtual Machine Generation ID device. The first one add a new ACPI directive which allow to use a 16-bytes buffer in an ACPI table. This buffer is for storing the VM's UUID. The second is the ACPI tables changes and the actual device.

Re: [Qemu-devel] vmw_pvscsi: QEMU stuck in SeaBIOS when pvscsi is enabled

2014-09-17 Thread Asias He
Hello Paolo, On Tue, Sep 16, 2014 at 10:33 PM, Paolo Bonzini wrote: > Il 16/09/2014 16:25, Igor Mammedov ha scritto: > > Current master cc35a44cf7b522b, > > > > QEMU is not able to boot an stuck in SeaBIOS (only SeaBIOS version was > printed) > > when started with "-device pvscsi" CLI option. >

Re: [Qemu-devel] [PATCH v3 18/23] blockdev: Fix blockdev-add not to create IDE drive (0, 0)

2014-09-17 Thread Benoît Canet
> -- > 1.9.3 > Reviewed-by: Benoit Canet

Re: [Qemu-devel] [PATCH v3 19/23] blockdev: Drop DriveInfo member enable_auto_del

2014-09-17 Thread Benoît Canet
> 1.9.3 > Reviewed-by: Benoit Canet

Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-17 Thread Andreas Färber
Am 13.09.2014 um 18:45 schrieb Richard Henderson: > In preparation for removing a bunch of ifdefs from cpu_exec. > > Cc: Andreas Färber > Signed-off-by: Richard Henderson > --- > cpu-exec.c| 9 ++--- > include/qom/cpu.h | 5 + > qom/cpu.c | 6 -- > 3 files changed, 1

Re: [Qemu-devel] [PATCH] block: Validate node-name

2014-09-17 Thread Kevin Wolf
Am 17.09.2014 um 13:49 hat Benoît Canet geschrieben: > > > > +int qemu_opts_id_wellformed(const char *id) > > This return 0 and 1 as a bool. > Could we make the function return bool in the same series ? I considered the change (as you probably saw, the new block.c function returns a bool), but

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-17 Thread Eric Blake
On 09/16/2014 11:54 PM, Markus Armbruster wrote: > Eric Blake writes: > >> On 09/16/2014 12:31 PM, Paolo Bonzini wrote: >> Change legacy_name to point to a detailed human-readable description of the type? E.g. "Ethernet 6-byte MAC Address, format: AA:BB:CC:DD:EE:FF"? >>> >>> If lib

Re: [Qemu-devel] [PATCH v3] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Eric Blake
On 09/17/2014 03:16 AM, Chrysostomos Nanakos wrote: > On 09/16/2014 10:40 PM, Eric Blake wrote: >> On 09/16/2014 12:04 PM, Chrysostomos Nanakos wrote: >>> If event_notifier_init fails QEMU exits without printing >>> any error information to the user. This commit adds an error >>> message on failure

Re: [Qemu-devel] [PATCH] hmp: fix memory leak at hmp_info_block_jobs()

2014-09-17 Thread Stefan Hajnoczi
On Tue, Sep 16, 2014 at 09:36:55PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Signed-off-by: Gonglei > --- > hmp.c | 2 ++ > 1 file changed, 2 insertions(+) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan pgpnBQq4Qev3R.pgp Description:

Re: [Qemu-devel] [PATCH 0/4] qapi/block-core: Add "new" qcow2 options

2014-09-17 Thread Stefan Hajnoczi
On Wed, Aug 20, 2014 at 07:59:32PM +0200, Max Reitz wrote: > This is a follow-up series to my previous series > "[PATCH v2 0/4] qcow2: Allow runtime specification of cache sizes" which > adds missing qcow2 runtime options to the appropriate structure in > qapi/block-core (overlap check mode and met

Re: [Qemu-devel] [PATCH v3] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Chrysostomos Nanakos
On 09/17/2014 04:01 PM, Eric Blake wrote: On 09/17/2014 03:16 AM, Chrysostomos Nanakos wrote: On 09/16/2014 10:40 PM, Eric Blake wrote: On 09/16/2014 12:04 PM, Chrysostomos Nanakos wrote: If event_notifier_init fails QEMU exits without printing any error information to the user. This commit ad

Re: [Qemu-devel] [PATCH V2 0/3] image-fuzzer: Support refcount structures in the qcow2 image generator

2014-09-17 Thread Stefan Hajnoczi
On Tue, Aug 19, 2014 at 04:25:10PM +0400, Maria Kustova wrote: > This patch series was created for the 'block-next' branch and based on the > next > series: > [PATCH V3] layout: Reduce number of generator functions in __init__ > > v0 -> v1 (based on the review of Fam Zheng): > * Fixed t

Re: [Qemu-devel] [PATCH] block: Validate node-name

2014-09-17 Thread Benoît Canet
The Wednesday 17 Sep 2014 à 13:31:06 (+0200), Kevin Wolf wrote : > The device_name of a BlockDriverState is currently checked because it is > always used as a QemuOpts ID and qemu_opts_create() checks whether such > IDs are wellformed. > > node-name is supposed to share the same namespace, but it

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed

2014-09-17 Thread Alexey Kardashevskiy
On 09/17/2014 07:25 PM, Paolo Bonzini wrote: > Il 17/09/2014 11:06, Stefan Hajnoczi ha scritto: >> I think the fundamental problem here is that the mirror block job >> on the source host does not synchronize with live migration. > >> Remember the mirror block job iterates on the dirty bitmap >> w

[Qemu-devel] [PATCH v4] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Chrysostomos Nanakos
On a system with a low limit of open files the initialization of the event notifier could fail and QEMU exits without printing any error information to the user. The problem can be easily reproduced by enforcing a low limit of open files and start QEMU with enough I/O threads to hit this limit. T

[Qemu-devel] [PATCH v4] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Chrysostomos Nanakos
v3->v4 -- * Remove escaped single quotes from error messages. * Rephrase commit log. v2->v3 -- * Remove errno usage and print the detailed message based on errno when event_notifier_init() fails. * Propagate error and return from iothread_complete() if aio_context_new() fails. * Return

Re: [Qemu-devel] Data classification in Qemu

2014-09-17 Thread Wu Libin
Cool, the document should be the design of the patch. The patch is a lustre in intel. Thanks,-:) On 17 Sep, 2014, at 5:01 pm, Stefan Hajnoczi wrote: > On Tue, Sep 16, 2014 at 11:03:04PM +0800, Wu Libin wrote: >> Yeah, i know dm-cache, it’s in the layer of block. >> >> Maybe my description is no

Re: [Qemu-devel] [PATCH v4] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Andreas Färber
Hi, As a general comment, when sending a cover letter for a single patch, please use --numbered, so that the cover letter becomes [PATCH 0/1] and the patch [PATCH 1/1] so they don't end up with identical subjects. Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germa

Re: [Qemu-devel] [PATCH 4/4] blocksize: add blkconf_blocksize call to all block devices

2014-09-17 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 04:15:21PM +0200, Christian Borntraeger wrote: > On 03/09/14 17:46, Stefan Hajnoczi wrote: > > On Tue, Jul 29, 2014 at 02:27:19PM +0200, Ekaterina Tumanova wrote: > > guest after live migration? QEMU doesn't automatically query the > > storage because these parameters must

Re: [Qemu-devel] [PATCH v4] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Eric Blake
On 09/17/2014 07:51 AM, Andreas Färber wrote: > Hi, > > As a general comment, when sending a cover letter for a single patch, > please use --numbered, so that the cover letter becomes [PATCH 0/1] and > the patch [PATCH 1/1] so they don't end up with identical subjects. Or, when sending a single p

Re: [Qemu-devel] [PATCH 4/4] blocksize: add blkconf_blocksize call to all block devices

2014-09-17 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 02:28:26PM +0400, Ekaterina Tumanova wrote: > On 09/03/2014 07:46 PM, Stefan Hajnoczi wrote: > >On Tue, Jul 29, 2014 at 02:27:19PM +0200, Ekaterina Tumanova wrote: > >>This patch add the blkconf_blocksize call to all > >>devices, which use DEFINE_BLOCK_PROPERTIES. > >>If the

Re: [Qemu-devel] [PATCH] slirp: udp: fix NULL pointer dereference because of uninitialized socket

2014-09-17 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 01:41:30PM +0200, Petr Matousek wrote: > When guest sends udp packet with source port and source addr 0, > uninitialized socket is picked up when looking for matching and already > created udp sockets, and later passed to sosendto() where NULL pointer > dereference is hit du

[Qemu-devel] [PATCH v2 2/5] xenfb: Activate mouse event handler

2014-09-17 Thread Owen smith
Without activating the mouse event handler, mouse events are not delivered to the new handler. Input events are only delivered to the first matching handler in the input chain. Activating a handler moves the handler to the start of the chain. Note: qemu_add_kbd_event_handler adds and activates the

[Qemu-devel] [PATCH v2 1/5] xenfb: Unregister keyboard event handler correctly

2014-09-17 Thread Owen smith
The keyboard event handler was not being removed, a NULL-callback entry was being added to intercept events. Use the unregister call to remove the keyboard event handler when appropriate. Signed-off-by: Owen smith --- hw/display/xenfb.c | 12 ++-- 1 file changed, 10 insertions(+), 2 dele

[Qemu-devel] [PATCH v2 4/5] xenfb: Add "feature-no-abs-rescale"

2014-09-17 Thread Owen smith
Some frontends may require absolute axes that are not scaled to DisplaySurface sizes. backend: feature-no-abs-rescale Value: 0/1 (boolean) Default: 0 Indicates whether backend supports unscaled absolute axes. Unscaled axes are in the range [0, 0x7fff]. frontend: request-no-abs-re

[Qemu-devel] [PATCH v2 3/5] xenfb: Add option to use a grant ref for shared page

2014-09-17 Thread Owen smith
Adds "page-gref" to the frontend location to specify the grant reference of the shared page. Adds the DEVOPS_FLAG_NEED_GNTDEV to both vfb and vkbd device flags. "page-ref" is checked first to avoid breaking existing frontends. "page-gref" Value: Grant reference to use to map the shared ri

[Qemu-devel] [PATCH v2 0/5] xenfb: Add support for Windows PV frontend

2014-09-17 Thread Owen smith
This patch series contains improvments for the Xen vkbd backend to support a Windows PV frontend mouse and keyboard. This allows VNC connections to have an absolute pointer without the USB tabled device enabled, and any unneccessary polling associated with the USB devices. Changes over v1: * Spl

[Qemu-devel] [PATCH v2 5/5] xenfb: Add "feature-no-console"

2014-09-17 Thread Owen smith
Added feature to allow vkbd connection without waiting for vfb device. Windows PV frontend requires connection without a vfb device, Ubuntu HVM would not start correctly without the wait for vfb device. backend: feature-no-console Value: 0/1 (boolean) Default Value: 0 A value of "1" i

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed

2014-09-17 Thread Stefan Hajnoczi
On Wed, Sep 17, 2014 at 10:25 AM, Paolo Bonzini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Il 17/09/2014 11:06, Stefan Hajnoczi ha scritto: >> I think the fundamental problem here is that the mirror block job >> on the source host does not synchronize with live migration. >> >> R

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed

2014-09-17 Thread Stefan Hajnoczi
On Wed, Sep 17, 2014 at 2:44 PM, Alexey Kardashevskiy wrote: > On 09/17/2014 07:25 PM, Paolo Bonzini wrote: > btw any better idea of a hack to try? Testers are pushing me - they want to > upgrade the broken setup and I am blocking them :) Thanks! Paolo's qemu_co_mutex_lock(&s->lock) idea in qcow2

Re: [Qemu-devel] [PATCH v4 0/8] AHCI test suite framework

2014-09-17 Thread Stefan Hajnoczi
On Thu, Aug 21, 2014 at 01:44:31PM -0400, John Snow wrote: > This submission does not re-send earlier patches in the series which > have already been merged into QEMU, which were primarily staging > fixes and small tweaks to support this smaller set of patches. > > This patch series introduces a n

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed

2014-09-17 Thread Eric Blake
[adding libvirt list] On 09/17/2014 09:04 AM, Stefan Hajnoczi wrote: > On Wed, Sep 17, 2014 at 10:25 AM, Paolo Bonzini wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Il 17/09/2014 11:06, Stefan Hajnoczi ha scritto: >>> I think the fundamental problem here is that the mirror bloc

Re: [Qemu-devel] [PATCH v2] target-i386: update fp status fix

2014-09-17 Thread Richard Henderson
On 09/17/2014 02:16 AM, Paolo Bonzini wrote: > > Looks good. Richard, are you going to pick it up or shall I? Go ahead. r~

Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-17 Thread Richard Henderson
On 09/17/2014 04:54 AM, Andreas Färber wrote: > I am fine with adding such hooks, but please let's use a better, active > name. CPUClass is the struct name and cpu-exec is a file name; the hook > should say what it's doing, not where the code (used to) live(s). Just > exec_enter/exec_exit possibly?

Re: [Qemu-devel] [PATCH 03/14] target-ppc: use separate indices for various translation modes

2014-09-17 Thread Richard Henderson
On 09/17/2014 01:53 AM, Paolo Bonzini wrote: > +/* All the TLBs together must be smaller than 64k on RISC machines */ > +#if !defined(__i386__) && !defined(__x86_64__) && !defined(__aarch64__) \ > +&& !defined(__sparc__) && !defined(CONFIG_TCG_INTERPRETER) > +#define CPU_TLB_BITS (NB_MMU_MODES

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-09-17 Thread Joakim Tjernlund
Riku Voipio wrote on 2014/09/01 11:51:15: > > On Mon, Sep 01, 2014 at 10:12:18AM +0100, Peter Maydell wrote: > > On 1 September 2014 09:51, Paolo Bonzini wrote: > > > Il 29/08/2014 20:01, Peter Maydell ha scritto: > > >> [cc'ing MJT for more distro opinion since I think fundamentally > > >> the

Re: [Qemu-devel] [PATCH v6 02/10] target-arm: Add SCR_EL3

2014-09-17 Thread Greg Bellows
Reviewed-by: Greg Bellows On 12 September 2014 21:29, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h| 19 ++- > target-arm/helper.c | 35 +-- > 2 files changed, 51 insertio

Re: [Qemu-devel] [PATCH 4/6] hw/arm/boot: register cpu reset handlers if using -bios

2014-09-17 Thread Ard Biesheuvel
On 9 September 2014 11:14, Peter Maydell wrote: > On 5 September 2014 16:15, Ard Biesheuvel wrote: >> When booting with -bios or -pflash rather than -kernel, we need to make sure >> reset handlers are registered. >> >> Signed-off-by: Ard Biesheuvel >> --- >> hw/arm/boot.c | 4 >> 1 file ch

  1   2   >