On 09/17/2014 03:16 AM, Chrysostomos Nanakos wrote: > On 09/16/2014 10:40 PM, Eric Blake wrote: >> On 09/16/2014 12:04 PM, Chrysostomos Nanakos wrote: >>> If event_notifier_init fails QEMU exits without printing >>> any error information to the user. This commit adds an error >>> message on failure: >>> >>> # qemu [...] >> Showing the actual command line you used would be helpful. > > The problem raised after having a system with a low limit of open files > and QEMU with 8 iothread objects. Do you believe that we should add such > a command line in the commit description? The problem can be easily > reproduced with any combination of low limit of open files and iothread > objects or even a low limit of open files without the creation of > iothreads.
It is ALWAYS valuable to make your commit message give a good recipe for how to reproduce the problem your commit is fixing. It's not a prerequisite (a patch can be accepted on inspection alone), but giving full details of how to reproduce it makes life easier when revisiting the patch a year from now or when writing a test case to ensure no regressions. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
