[Qemu-devel] [PATCH] hw/arm/virt: fix pl031 addr typo

2014-07-29 Thread Andrew Jones
pl031's base address should be 0x9001000, 0x9001. While in there also add some spacing and zeros to make it easier to read the map. Signed-off-by: Andrew Jones --- hw/arm/virt.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix pl031 addr typo

2014-07-29 Thread Peter Maydell
On 29 July 2014 16:44, Andrew Jones wrote: > pl031's base address should be 0x9001000, 0x9001. While in there > also add some spacing and zeros to make it easier to read the map. Please don't do both in one patch, it's really hard to tell what you actually changed. thanks -- PMM

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix pl031 addr typo

2014-07-29 Thread Andrew Jones
On Tue, Jul 29, 2014 at 04:58:44PM +0100, Peter Maydell wrote: > On 29 July 2014 16:44, Andrew Jones wrote: > > pl031's base address should be 0x9001000, 0x9001. While in there ^ meant to type 'not' here, but guess that was obvious > > also add some

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix pl031 addr typo

2014-07-29 Thread Peter Maydell
On 29 July 2014 17:06, Andrew Jones wrote: > On Tue, Jul 29, 2014 at 04:58:44PM +0100, Peter Maydell wrote: >> On 29 July 2014 16:44, Andrew Jones wrote: >> > pl031's base address should be 0x9001000, 0x9001. While in there > ^ meant to type 'not'

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: add multiwrite test cases

2014-07-29 Thread Eric Blake
On 07/29/2014 06:41 AM, Stefan Hajnoczi wrote: > This test case covers the basic bdrv_aio_multiwrite() scenarios: > 1. Single request > 2. Sequential requests > 3. Overlapping requests > 4. Disjoint requests > > Signed-off-by: Stefan Hajnoczi > --- > +echo > +echo "== Overlapping requests ==" >

Re: [Qemu-devel] [PATCH RFC v2 03/12] VMState test: query command to extract the qdevified device names

2014-07-29 Thread Eric Blake
On 07/29/2014 06:45 AM, Juan Quintela wrote: > Sanidhya Kashyap wrote: >> I have provided a qmp interface for getting the list of qdevified devices >> that have been registered with SaveVMHandlers. >> >> Signed-off-by: Sanidhya Kashyap >> --- >> qapi-schema.json | 22 ++ >> q

Re: [Qemu-devel] [PATCH RFC v2 07/12] VMState test: qmp interface for querying the vmstate testing process

2014-07-29 Thread Eric Blake
On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote: > This patch provides the information about an already executing testing > process. I have modified the qmp command to query-test-vmstates from > test-vmstates-get-info. > > Signed-off-by: Sanidhya Kashyap > --- > qapi-schema.json | 34

[Qemu-devel] [PATCH v2] hw/arm/virt: fix pl031 addr typo

2014-07-29 Thread Andrew Jones
pl031's base address should be 0x901, not 0x9001, otherwise it sits in ram when configuring a guest with greater than 1G. Signed-off-by: Andrew Jones --- v2: - pl031 needs 64K alignment - don't change the formatting, will send another patch, which may get ignored :-) --- hw/arm/virt

Re: [Qemu-devel] [PATCH v2] hw/arm/virt: fix pl031 addr typo

2014-07-29 Thread Peter Maydell
On 29 July 2014 17:32, Andrew Jones wrote: > pl031's base address should be 0x901, not 0x9001, otherwise > it sits in ram when configuring a guest with greater than 1G. > > Signed-off-by: Andrew Jones > --- > v2: > - pl031 needs 64K alignment > - don't change the formatting, will send a

Re: [Qemu-devel] [PATCH RFC v2 07/12] VMState test: qmp interface for querying the vmstate testing process

2014-07-29 Thread Eric Blake
On 07/29/2014 09:17 AM, Eric Blake wrote: > On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote: >> This patch provides the information about an already executing testing >> process. I have modified the qmp command to query-test-vmstates from >> test-vmstates-get-info. This last sentence does not belon

[Qemu-devel] [PATCH] hw/arm/virt: formatting: memory map

2014-07-29 Thread Andrew Jones
Add some spacing and zeros to make it easier to read and modify the map. This patch has no functional changes. The review looks ugly, but it's actually pretty easy to confirm all the addresses are as they should be - thanks to the new formatting ;-) Applies on top of 'v2.1.0-rc5'. Signed-off-by:

Re: [Qemu-devel] [PATCH RFC v2 09/12] VMState test: update period of vmstate testing process

2014-07-29 Thread Eric Blake
On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote: > No particular change, except variable name. Since I am not modifying other > variables, so I have not made the command generic. This sentence feels like changelog information compared to v1; as such, it belongs... > > Signed-off-by: Sanidhya Kash

Re: [Qemu-devel] [PATCH RFC v2 11/12] VMState test: cancel mechanism for an already running vmstate testing process

2014-07-29 Thread Eric Blake
On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote: > Signed-off-by: Sanidhya Kashyap > --- > qapi-schema.json | 9 + > qmp-commands.hx | 19 +++ > savevm.c | 16 ++-- > 3 files changed, 42 insertions(+), 2 deletions(-) > > diff --git a/qapi-schema.json

Re: [Qemu-devel] [PATCH RFC v2 12/12] VMState test: hmp interface for cancel mechanism

2014-07-29 Thread Eric Blake
On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote: > Signed-off-by: Sanidhya Kashyap > --- > hmp-commands.hx | 14 ++ > hmp.c | 6 ++ > hmp.h | 1 + > 3 files changed, 21 insertions(+) I don't mind if you squash the QMP and HMP counterpart commands into the sam

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-29 Thread Paolo Bonzini
Il 18/07/2014 10:48, Paolo Bonzini ha scritto: > > It is easy to find out if the "fix" is related to 1 or 2/3: just write > > if (cpu->kvm_vcpu_dirty) { > printf ("do_kvm_cpu_synchronize_state_always: look at 2/3\n"); > kvm_arch_get_registers(cpu); > } else { >

[Qemu-devel] [PATCH] vfio: Fix MSI-X vector expansion

2014-07-29 Thread Alex Williamson
When new MSI-X vectors are enabled we need to disable MSI-X and re-enable it with the correct number of vectors. That means we need to reprogram the eventfd triggers for each vector. Prior to f4d45d47 vector->use tracked whether a vector was masked or unmasked and we could always pick the KVM pat

[Qemu-devel] [PATCH] vfio: Don't cache MSIMessage

2014-07-29 Thread Alex Williamson
Commit 40509f7f added a test to avoid updating KVM MSI routes when the MSIMessage is unchanged and f4d45d47 switched to relying on this rather than doing our own comparison. Our cached msg is effectively unused now. Remove it. Signed-off-by: Alex Williamson --- hw/misc/vfio.c |8 ++--

Re: [Qemu-devel] [PATCH RFC v2 03/12] VMState test: query command to extract the qdevified device names

2014-07-29 Thread Sanidhya Kashyap
>> +## >> +# @VMstatesQdevDevices >> +# >> +# list of qdevified devices that are registered with SaveStateEntry >> +# >> +# @device: list of qdevified device names > > > Should we use qdev on the name? Or just list of devices? My > understanding is that all devices are on this list, no? > T

Re: [Qemu-devel] [PATCH RFC v2 05/12] VMstate test: basic VMState testing mechanism

2014-07-29 Thread Sanidhya Kashyap
>> +{ 'command': 'test-vmstates', >> + 'data': {'*iterations': 'int', >> + '*period': 'int', >> + 'noqdev': 'bool', > > Do we really care about "noqdev", or should we just "decree" that it is > "false" always? > Okay. Will remove it. > >> +#define DEBUG_TEST_VMSTA

Re: [Qemu-devel] [PATCH RFC v2 09/12] VMState test: update period of vmstate testing process

2014-07-29 Thread Sanidhya Kashyap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> +# +# Since 2.2 +## +{ 'command' : 'test-vmstates-set-period', + >> 'data': { 'period': 'int' } } > > Is it possible that we might add other tunables in the future? If > so, this command is not very scalable (we would be adding one > command p

Re: [Qemu-devel] [PATCH RFC v2 12/12] VMState test: hmp interface for cancel mechanism

2014-07-29 Thread Sanidhya Kashyap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/29/2014 10:22 PM, Eric Blake wrote: > On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote: >> Signed-off-by: Sanidhya Kashyap --- >> hmp-commands.hx | 14 ++ hmp.c | 6 ++ >> hmp.h | 1 + 3 files changed, 21 ins

[Qemu-devel] [Bug 1349972] [NEW] qcow2-refcount: qemu-io crashes on 'discard' command

2014-07-29 Thread Maria Kustova
Public bug reported: qemu-io is killed by SIGIOT at the 'discard' command on the image having no refcount information. Sequence: 1. Unpack test.img and backing_img.qed in the same directory (see the attached archives for images) 2. Make a copy of test.img to copy.img (qemu-io modifies the image

Re: [Qemu-devel] [PATCH] target-i386/FPU: wrong conversion infinity from float80 to int32/int64

2014-07-29 Thread Richard Henderson
On 07/23/2014 05:04 AM, Dmitry Poletaev wrote: > +if (env->fp_status.float_exception_flags & FPUS_IE) { Mixing bit masks. s/FPUS_IE/float_status_invalid/ r~

Re: [Qemu-devel] [PATCH] hw/arm/boot: Set PC correctly when loading AArch64 ELF files

2014-07-29 Thread Richard Henderson
On 07/25/2014 05:23 AM, Peter Maydell wrote: > +env->regs[15] = info->entry & 0xfffe; You'd do well to use a U suffix here, otherwise c89 makes this -2 while c99 does what you want. Which makes a tiny difference on a 64-bit host. r~

Re: [Qemu-devel] [PATCH] hw/arm/boot: Set PC correctly when loading AArch64 ELF files

2014-07-29 Thread Peter Maydell
On 29 July 2014 20:25, Richard Henderson wrote: > On 07/25/2014 05:23 AM, Peter Maydell wrote: >> +env->regs[15] = info->entry & 0xfffe; > > You'd do well to use a U suffix here, otherwise c89 makes this -2 while c99 > does what you want. Which makes a tiny difference on a 64-

Re: [Qemu-devel] [PATCH RFC v2 09/12] VMState test: update period of vmstate testing process

2014-07-29 Thread Eric Blake
On 07/29/2014 12:04 PM, Sanidhya Kashyap wrote: >>> +void qmp_test_vmstates_set_period(int64_t period, Error **errp) >>> +{ +VMStateLogState *v = vmstate_current_state(); +if >>> (period < TEST_VMSTATE_MIN_INTERVAL_MS || +period > >>> TEST_VMSTATE_MAX_INTERVAL_MS) { +error

[Qemu-devel] Should qemu -kernel option be able to gunzip kernel? (aarch64)

2014-07-29 Thread Richard W.M. Jones
On Fedora/aarch64, the kernel in /boot is a gzip-compressed file: $ file /boot/vmlinuz-* /boot/vmlinuz-0-rescue-520be7dc677d4fab99d3d3ce91f90c84: gzip compressed data, max compression, from Unix /boot/vmlinuz-3.16.0-0.rc6.git3.1.rwmj2.fc22.aarch64:gzip compressed data, max compression, from

Re: [Qemu-devel] [questions] about qemu log

2014-07-29 Thread Eric Blake
On 07/25/2014 08:28 PM, Zhang Haoyu wrote: >> In a shell you would write something like: >> >> 2> stderr.log >> >> You may also want to toggle QEMU's -msg timestamp=on option. >> > I think the "-msg -msg timestamp=on" option will add timestamp to the output > of error_report(fmt, ...), > but wher

Re: [Qemu-devel] [PATCH] hw/arm/boot: Set PC correctly when loading AArch64 ELF files

2014-07-29 Thread Richard Henderson
On 07/29/2014 09:31 AM, Peter Maydell wrote: > Given that env->regs[] is uint32_t, does it actually change the final > result? Ah, no. I mis-remembered regs and xregs being shared. r~

Re: [Qemu-devel] Should qemu -kernel option be able to gunzip kernel? (aarch64)

2014-07-29 Thread Peter Maydell
On 29 July 2014 20:49, Richard W.M. Jones wrote: > On Fedora/aarch64, the kernel in /boot is a gzip-compressed file > Apparently UEFI and u-boot can just handle this by uncompressing the > kernel on the fly. > > However qemu-system-aarch64 -kernel option definitely can*not*, with > the result tha

Re: [Qemu-devel] [PATCH 5/7] libqos: Change free function called in malloc

2014-07-29 Thread John Snow
On 07/24/2014 02:31 PM, Marc Marí wrote: Signed-off-by: Marc Marí --- tests/libqos/malloc.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/malloc.h b/tests/libqos/malloc.h index 46f6000..5565381 100644 --- a/tests/libqos/malloc.h +++ b/tests/libqos/malloc

Re: [Qemu-devel] [PATCH 4/7] libqos: Correct mask to align size to PAGE_SIZE in malloc-pc

2014-07-29 Thread John Snow
On 07/24/2014 02:31 PM, Marc Marí wrote: Signed-off-by: Paolo Bonzini Signed-off-by: Marc Marí --- tests/libqos/malloc-pc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/malloc-pc.c b/tests/libqos/malloc-pc.c index db1496c..2efd095 100644 --- a/tests/li

Re: [Qemu-devel] [PATCH 4/7] libqos: Correct mask to align size to PAGE_SIZE in malloc-pc

2014-07-29 Thread Peter Maydell
On 24 July 2014 19:31, Marc Marí wrote: > Signed-off-by: Paolo Bonzini > Signed-off-by: Marc Marí > --- > tests/libqos/malloc-pc.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/libqos/malloc-pc.c b/tests/libqos/malloc-pc.c > index db1496c..2efd095 100644 > --

[Qemu-devel] [PATCH 0/4] libqos: add a simple first-fit memory allocator

2014-07-29 Thread John Snow
This set collects two patches by Marc Marí already on the mailing list, but goes further by adding a simple memory allocator that allows us to track and debug freed memory, and optionally keep track of any leaks. John Snow (2): libqos: add a simple first-fit memory allocator qtest/ide-test: ad

[Qemu-devel] [PATCH 2/4] libqos: Change free function called in malloc

2014-07-29 Thread John Snow
From: Marc Marí Signed-off-by: Marc Marí Signed-off-by: John Snow --- tests/libqos/malloc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/malloc.h b/tests/libqos/malloc.h index 46f6000..5565381 100644 --- a/tests/libqos/malloc.h +++ b/tests/libqos/malloc.h @@

[Qemu-devel] [PATCH 3/4] libqos: add a simple first-fit memory allocator

2014-07-29 Thread John Snow
Implement a simple first-fit memory allocator that attempts to keep track of leased blocks of memory in order to be able to re-use blocks. Additionally, allow the user to specify when initializing the device that upon cleanup, we would like to assert that there are no blocks in use. This may be us

[Qemu-devel] [PATCH 1/4] libqos: Correct mask to align size to PAGE_SIZE in malloc-pc

2014-07-29 Thread John Snow
From: Marc Marí Signed-off-by: Paolo Bonzini Signed-off-by: Marc Marí Signed-off-by: John Snow --- tests/libqos/malloc-pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/malloc-pc.c b/tests/libqos/malloc-pc.c index db1496c..2efd095 100644 --- a/tests/libqos/

[Qemu-devel] [PATCH 4/4] qtest/ide-test: add pc-alloc-uninit call

2014-07-29 Thread John Snow
Uninitialize the allocator and cleanup residual memory. Signed-off-by: John Snow --- tests/ide-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/ide-test.c b/tests/ide-test.c index 4a0d97f..ad32328 100644 --- a/tests/ide-test.c +++ b/tests/ide-test.c @@ -123,6 +123,8 @@ static v

[Qemu-devel] [PATCH] monitor: Remove hardcoded watchdog event names

2014-07-29 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- monitor.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 5bc70a6..7465775 100644 --- a/monitor.c +++ b/monitor.c @@ -4520,16 +4520,15 @@ void netdev_del_completion(ReadLineState *rs, int nb_args, cons

[Qemu-devel] [PATCH] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-07-29 Thread Richard W.M. Jones
Signed-off-by: Richard W.M. Jones --- hw/arm/boot.c | 9 + hw/core/loader.c| 48 include/hw/loader.h | 1 + 3 files changed, 58 insertions(+) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 3d1f4a2..1086a05 100644 --- a/hw/arm

[Qemu-devel] [Bug 1349941] Re: qemu-ppc segfault on simple hello world

2014-07-29 Thread Serge Hallyn
Hm. No, I could not reproduce it because regardless how I built the binary, I get qemu-ppc-static ./ppc /lib/ld.so.1: No such file or directory Hopefully we can get 2.1 into utopic, however to get the fix into trusty we'll have to narrow it down to a particular cherry-pickable patchset. ** Also

[Qemu-devel] [PATCH 1/2] virtio-rng: Move error-checking forward to prevent memory leak

2014-07-29 Thread John Snow
This patch pushes the error-checking forward and the virtio initialization backward in the device realization function in order to prevent memory leaks for hot plug scenarios. Signed-off-by: John Snow --- hw/virtio/virtio-rng.c | 20 ++-- 1 file changed, 10 insertions(+), 10 dele

[Qemu-devel] [PATCH 0/2] virtio-rng: Fix memory leaks in virtio_rng_device_realize

2014-07-29 Thread John Snow
My previous commit, 713e8a10, did not address the fact that the error checking pathways do not attempt to call virtio_cleanup and thus can leak memory in hotplug scenarios. This patchset shuffles around the error checking so it does not need to perform said cleanup, and changes the error functions

[Qemu-devel] [PATCH 2/2] virtio-rng: replace error_set calls with error_setg

2014-07-29 Thread John Snow
Under recommendation from Luiz Capitulino, we are changing the error_set calls to error_setg while we are fixing up the error handling pathways of virtio-rng. Signed-off-by: John Snow --- hw/virtio/virtio-rng.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/virti

[Qemu-devel] [ANNOUNCE] QEMU 2.1.0-rc5 is now available

2014-07-29 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the sixth release candidate for the QEMU 2.1 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.1.0-rc5.tar.bz2 Note from Peter

[Qemu-devel] [RESEND PATCH V3] qemu-img info: show nocow info

2014-07-29 Thread Chunyan Liu
Add nocow info in 'qemu-img info' output to show whether the file currently has NOCOW flag set or not. Signed-off-by: Chunyan Liu Reviewed-by: Eric Blake --- Resend for QEMU 2.2. Change json version comment. Add Reviewed-by. block/qapi.c | 25 + qapi/block-core.

Re: [Qemu-devel] [RESEND PATCH V3] qemu-img info: show nocow info

2014-07-29 Thread Chun Yan Liu
>>> On 7/29/2014 at 08:45 PM, in message <53d79771.1040...@redhat.com>, Eric >>> Blake wrote: > On 07/29/2014 01:18 AM, Chunyan Liu wrote: > > Add nocow info in 'qemu-img info' output to show whether the file > > currently has NOCOW flag set or not. > > > > Signed-off-by: Chunyan Liu >

[Qemu-devel] [Bug 1349277] [NEW] AArch64 emulation ignores SPSel=0 when taking (or returning from) an exception at EL1 or greater

2014-07-29 Thread T McIntosh
Public bug reported: The AArch64 emulation ignores SPSel=0 when: (1) taking an interrupt from an exception level greater than EL0 (e.g., EL1t), (2) returning from an exception (via ERET) to an exception level greater than EL0 (e.g., EL1t), with SPSR_ELx[SPSel]=0. The attached patch fixes the pr

[Qemu-devel] qemu run crash when divice_add another qxl display card

2014-07-29 Thread zhou link
here hit an assertion: qemu-system-x86_64 -monitor stdio -vga qxl -spice port=,disable-ticketing (/home/brook/local/bin/qemu-system-x86_64:27280): Spice-Warning **: reds.c:3295:spice_server_init: [07-29 23:41:47]ct: Jul 26 2014 00:28:12 QEMU 2.0.0 monitor - type 'help' for more information (q

[Qemu-devel] [Bug 1297218] Re: guest hangs after live migration due to tsc jump

2014-07-29 Thread Paul Boven
** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1297218 Title: guest hangs after live migration due to tsc jump Status in QEMU: Ne

[Qemu-devel] Behavior of floating point conversion in case the float value is NaN

2014-07-29 Thread Gaurav Sharma
In the floating point conversion support , if the float value is NaN, I can see that the largest integer value is returned. 1. Is this as per std ? In the IEEE 754 doc i could not find any statement which says, about this. Thanks, Gaurav

Re: [Qemu-devel] [Bug 1349277] [NEW] AArch64 emulation ignores SPSel=0 when taking (or returning from) an exception at EL1 or greater

2014-07-29 Thread Edgar E. Iglesias
On Mon, Jul 28, 2014 at 07:40:56AM -, T McIntosh wrote: > Public bug reported: > > The AArch64 emulation ignores SPSel=0 when: > > (1) taking an interrupt from an exception level greater than EL0 (e.g., > EL1t), > > (2) returning from an exception (via ERET) to an exception level greater > t

Re: [Qemu-devel] [PATCH RFC v2 12/12] VMState test: hmp interface for cancel mechanism

2014-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote: >> Signed-off-by: Sanidhya Kashyap >> --- >> hmp-commands.hx | 14 ++ >> hmp.c | 6 ++ >> hmp.h | 1 + >> 3 files changed, 21 insertions(+) > > I don't mind if you squash the QMP and HMP c

Re: [Qemu-devel] [PATCH 0/2] virtio-rng: Fix memory leaks in virtio_rng_device_realize

2014-07-29 Thread Markus Armbruster
John Snow writes: > My previous commit, 713e8a10, did not address the fact that > the error checking pathways do not attempt to call > virtio_cleanup and thus can leak memory in hotplug scenarios. > > This patchset shuffles around the error checking so it does not > need to perform said cleanup,

[Qemu-devel] [PATCH v6 0/2] vmdk: Optimize cluster allocation

2014-07-29 Thread Fam Zheng
V6: Address Stefan's comments. See patch 02 for changelog. (Thanks for reviewing) Fam Zheng (2): qemu-iotests: Add data pattern in version3 VMDK sample image in 059 vmdk: Optimize cluster allocation block/vmdk.c | 222 + tests/qemu-

[Qemu-devel] [PATCH v6 1/2] qemu-iotests: Add data pattern in version3 VMDK sample image in 059

2014-07-29 Thread Fam Zheng
It's possible that we diverge from the specification with our implementation. Having a reference image in the test cases may detect such problems when we introduce a bug that can read what it creates, but can't handle a real VMDK. Signed-off-by: Fam Zheng --- tests/qemu-iotests/059

[Qemu-devel] [PATCH v6 2/2] vmdk: Optimize cluster allocation

2014-07-29 Thread Fam Zheng
This drops the unnecessary bdrv_truncate() from, and also improves, cluster allocation code path. Before, when we need a new cluster, get_cluster_offset truncates the image to bdrv_getlength() + cluster_size, and returns the offset of added area, i.e. the image length before truncating. This is n

<    1   2