On 29 July 2014 20:25, Richard Henderson <r...@twiddle.net> wrote: > On 07/25/2014 05:23 AM, Peter Maydell wrote: >> + env->regs[15] = info->entry & 0xfffffffe; > > You'd do well to use a U suffix here, otherwise c89 makes this -2 while c99 > does what you want. Which makes a tiny difference on a 64-bit host.
Given that env->regs[] is uint32_t, does it actually change the final result? I agree that a U suffix would be a good idea, but given that the code has been that way since 2009 it seems unlikely that we've actually got breakage from it... thanks -- PMM
