Eric Blake <ebl...@redhat.com> writes: > On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote: >> Signed-off-by: Sanidhya Kashyap <sanidhya.ii...@gmail.com> >> --- >> hmp-commands.hx | 14 ++++++++++++++ >> hmp.c | 6 ++++++ >> hmp.h | 1 + >> 3 files changed, 21 insertions(+) > > I don't mind if you squash the QMP and HMP counterpart commands into the > same patch as one another (throughout the series). Each pair of patches > are both small enough, and related to the same action, that doing it as > a combined patch may actually get a better review.
It's okay to squash them when they're small and the interfaces they add are uncontroversial. Otherwise, I prefer them separate, so I can concentrate on the QMP interface first, without HMP distractions.
