Re: [Qemu-devel] [PATCH 5/7] hw/core/sysbus: add fdt_add_node method

2014-07-24 Thread Eric Auger
On 07/24/2014 01:02 AM, Alexander Graf wrote: > > On 23.07.14 17:33, Eric Auger wrote: >> On 07/08/2014 03:52 PM, Alexander Graf wrote: >>> On 07.07.14 09:08, Eric Auger wrote: This method is meant to be called on sysbus device dynamic instantiation (-device option). Devices that support

Re: [Qemu-devel] [PATCH 1/7] hw/misc/platform_devices: helpers for dynamic instantiation of platform devices

2014-07-24 Thread Eric Auger
On 07/24/2014 01:07 AM, Alexander Graf wrote: > > On 23.07.14 16:58, Eric Auger wrote: >> On 07/08/2014 03:43 PM, Alexander Graf wrote: >>> On 07.07.14 09:08, Eric Auger wrote: This new module implements routines which help in dynamic instantiation of sysbus devices. Machine files can us

Re: [Qemu-devel] [PATCH 1/2] acpi-dsdt: procedurally generate _PRT

2014-07-24 Thread Igor Mammedov
On Wed, 23 Jul 2014 18:37:45 +0200 Paolo Bonzini wrote: > This replaces the _PRT constant with a method that computes it. > > The problem is that the DSDT+SSDT have grown from 2.0 to 2.1, > enough to cross the 8k barrier (we align the ACPI tables to 4k > before putting them in fw_cfg). This cau

[Qemu-devel] [PULL for-2.1 1/2] fix full frame updates for VNC clients

2014-07-24 Thread Gerd Hoffmann
From: Stephan Kulow If the client asks for !incremental frame updates, it has lost its content so dirty doesn't matter - it has to see the full frame, so setting force_update Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven --- ui/vnc.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PULL for-2.1 0/2] vnc: fix two vnc update issues.

2014-07-24 Thread Gerd Hoffmann
: git://git.kraxel.org/qemu tags/pull-vnc-20140724-1 for you to fetch changes up to 832932a6f17983a3167ae9da6fe54a245a30758e: vnc update fix (2014-07-24 10:14:34 +0200) vnc: fix two vnc update issues

[Qemu-devel] [PULL for-2.1 2/2] vnc update fix

2014-07-24 Thread Gerd Hoffmann
We need to remember has_updates for each vnc client. Otherwise it might happen that vnc_update_client(has_dirty=1) takes the first exit due to output buffers not being flushed yet and subsequent calls with has_dirty=0 take the second exit, wrongly assuming there is nothing to do because the work d

[Qemu-devel] [PATCH 1/6] bootindex: add {del, modify}_boot_device_path function

2014-07-24 Thread arei.gonglei
From: Gonglei When we want to change one device's bootindex, we should do three things. On the on hand, remove the device from global fw_boot_order list, regardless attaching suffix or not delete. On the other hand, delete original object of the assigned bootindex. Finally add the new device's bo

[Qemu-devel] [PATCH 5/6] qemu-monitor: HMP set-bootindex wrapper

2014-07-24 Thread arei.gonglei
From: Gonglei Add HMP set-bootindex wrapper to allow setting devcie's bootindex via monitor. Signed-off-by: Gonglei Signed-off-by: Chenliang --- hmp-commands.hx | 15 +++ hmp.c | 13 + hmp.h | 1 + 3 files changed, 29 insertions(+) diff --git a/hm

[Qemu-devel] [PATCH 2/6] fw_cfg: add fw_cfg_machine_reset function

2014-07-24 Thread arei.gonglei
From: Gonglei We must assure that the changed bootindex can take effect when guest is rebooted. So we introduce fw_cfg_machine_reset(), which change the fw_cfg file's bootindex data using the new global fw_boot_order list. Signed-off-by: Chenliang Signed-off-by: Gonglei --- hw/nvram/fw_cfg.c

[Qemu-devel] [PATCH 4/6] qmp: add set-bootindex command

2014-07-24 Thread arei.gonglei
From: Gonglei Adds "set-bootindex id=xx,bootindex=xx,suffix=xx" QMP command. Example QMP command: -> { "execute": "set-bootindex", "arguments": { "id": "ide0-0-1", "bootindex": 1, "suffix": "/disk@0"}} <- { "return": {} } Signed-off-by: Gonglei Signed-off-by: Chenliang --- qapi-schema.json

[Qemu-devel] [PATCH 0/6] modify boot order of guest, and take effect after rebooting

2014-07-24 Thread arei.gonglei
From: Gonglei Sometimes, we want to modify boot order of a guest, but no need to shutdown it. We can call dynamic changing bootindex of a guest, which can be assured taking effect just after the guest rebooting. For example, in P2V scene, we boot a guest and then attach a new system disk, for co

[Qemu-devel] [PATCH 3/6] bootindex: delete bootindex when device is removed

2014-07-24 Thread arei.gonglei
From: Gonglei Device should be removed from global boot list when it is hot-unplugged. Signed-off-by: Chenliang Signed-off-by: Gonglei --- hw/block/virtio-blk.c| 1 + hw/i386/kvm/pci-assign.c | 1 + hw/misc/vfio.c | 1 + hw/net/e1000.c | 1 + hw/net/eepro100.c|

[Qemu-devel] [PATCH 6/6] spapr: fix possible memory leak

2014-07-24 Thread arei.gonglei
From: Gonglei get_boot_devices_list() will malloc memory, spapr_finalize_fdt doesn't free it. Signed-off-by: Chenliang Signed-off-by: Gonglei --- hw/ppc/spapr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index d01978f..edff5ce 100644 --- a/hw/ppc/spapr

[Qemu-devel] [PATCH 2.1] PPC: KVM: Fix g3beige and mac99 when HV is loaded

2014-07-24 Thread Alexander Graf
On PPC we have 2 different styles of KVM: PR and HV. HV can only virtualize sPAPR guests while PR can virtualize everything that's reasonably close to the host hardware platform. As long as only one kernel module (PR or HV) is loaded, the "default" kvm type is the module that's loaded. So if your

Re: [Qemu-devel] [PATCH 2/2] pc: hack for migration compatibility from QEMU 2.0

2014-07-24 Thread Igor Mammedov
On Wed, 23 Jul 2014 18:37:46 +0200 Paolo Bonzini wrote: > Changing the ACPI table size causes migration to break, and the memory > hotplug work opened our eyes on how horribly we were breaking things in > 2.0 already. > > The ACPI table size is rounded to the next 4k, which one would think > giv

[Qemu-devel] [RFC for-2.1 for for-2.0-stable] pc: acpi: generate AML only for PCI0 devices if PCI bridge hotplug is disabled

2014-07-24 Thread Igor Mammedov
Fixes migration regression from QEMU-1.7 to a newer QEMUs. SSDT table size in QEMU-1.7 doesn't change regardless of a number of PCI bridge devices present at startup. However in QEMU-2.0 since addition of hotplug on PCI bridges, each PCI bridge adds ~1875 bytes to SSDT table, including pc-i440fx-1

[Qemu-devel] [Bug 1347555] Re: qemu build failure, hxtool is a bash script, not a /bin/sh script

2014-07-24 Thread Felix von Leitner
It turns out that expr does not support ^ (at least according to the man page). :-) Still, you could do expr -$flag + 1 to do the same thing. Is the ruckus just about this one place where $(( )) is used or are there other non-Bourne-shell constructs? -- You received this bug notification becaus

Re: [Qemu-devel] [RFC v4 06/13] hw/vfio/pci: split vfio_get_device

2014-07-24 Thread Eric Auger
On 07/09/2014 12:43 AM, Alex Williamson wrote: > On Mon, 2014-07-07 at 13:27 +0100, Eric Auger wrote: >> vfio_get_device now takes a VFIODevice as argument. The function is split >> into 4 functional parts: dev_info query, device check, region populate >> and interrupt populate. the last 3 are spec

Re: [Qemu-devel] [PATCH 1/6] bootindex: add {del, modify}_boot_device_path function

2014-07-24 Thread Gerd Hoffmann
On Do, 2014-07-24 at 16:38 +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > When we want to change one device's bootindex, we should do three > things. On the on hand, remove the device from global fw_boot_order list, > regardless attaching suffix or not delete. On the other hand, delete

Re: [Qemu-devel] [RFC] How to handle feature regressions in new QEMU releases

2014-07-24 Thread Michael Tokarev
24.07.2014 04:37, ronnie sahlberg wrote: > Please find a new version 1.12 on the website. I'm subscribed to the iscsi mailing list, FWIW. Thanks, /mjt

Re: [Qemu-devel] [RFC v4 06/13] hw/vfio/pci: split vfio_get_device

2014-07-24 Thread Eric Auger
On 07/24/2014 11:51 AM, Eric Auger wrote: > On 07/09/2014 12:43 AM, Alex Williamson wrote: >> On Mon, 2014-07-07 at 13:27 +0100, Eric Auger wrote: >>> vfio_get_device now takes a VFIODevice as argument. The function is split >>> into 4 functional parts: dev_info query, device check, region populate

Re: [Qemu-devel] [RFC for-2.1 for for-2.0-stable] pc: acpi: generate AML only for PCI0 devices if PCI bridge hotplug is disabled

2014-07-24 Thread Paolo Bonzini
Il 24/07/2014 11:07, Igor Mammedov ha scritto: > Fixes migration regression from QEMU-1.7 to a newer QEMUs. > SSDT table size in QEMU-1.7 doesn't change regardless of > a number of PCI bridge devices present at startup. > > However in QEMU-2.0 since addition of hotplug on PCI bridges, > each PCI b

Re: [Qemu-devel] [PATCH] target-i386/FPU: wrong conversion infinity from float80 to int32/int64

2014-07-24 Thread Dmitry Poletaev
23.07.2014, 21:13, "Peter Maydell" : >  On 23 July 2014 16:04, Dmitry Poletaev wrote: >>   I'm understood. So, am I right? >  Pretty much, except it's better to use the accessor functions >  get_float_exception_flags() and set_float_exception_flags(). >>   +    if (env->fp_status.float_exception_f

Re: [Qemu-devel] [PATCH 5/7] hw/core/sysbus: add fdt_add_node method

2014-07-24 Thread Alexander Graf
On 24.07.14 09:36, Eric Auger wrote: On 07/24/2014 01:02 AM, Alexander Graf wrote: On 23.07.14 17:33, Eric Auger wrote: On 07/08/2014 03:52 PM, Alexander Graf wrote: On 07.07.14 09:08, Eric Auger wrote: This method is meant to be called on sysbus device dynamic instantiation (-device option)

[Qemu-devel] [PATCH 0/4] xen:passthrough: introduce a separate machine to igd passthrough

2014-07-24 Thread Tiejun Chen
As we discussed currently we have to introduce a separate machine to work out igd passthrough. Tiejun Chen (4): hw:i386:pc_piix: split pc_init1() xen:hw:pci-host:piix: create host bridge to passthrough xen:hw:pci-ho

[Qemu-devel] [PATCH 3/4] xen:hw:pci-host:piix: introduce xen_igd_i440fx_init

2014-07-24 Thread Tiejun Chen
This is almost same as an original i440fx_init but just work with that xen igd host bridge to passthrough. Signed-off-by: Tiejun Chen --- hw/pci-host/piix.c | 79 include/hw/i386/pc.h | 10 +++ 2 files changed, 89 insertions(+) diff --g

[Qemu-devel] [PATCH 1/4] hw:i386:pc_piix: split pc_init1()

2014-07-24 Thread Tiejun Chen
We'd like to split pc_init1 and then we can share something with other stuff. Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c | 93 +-- 1 file changed, 70 insertions(+), 23 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index

[Qemu-devel] [PATCH 4/4] xen:hw:i386:pc_piix: introduce new machine for IGD passthrough

2014-07-24 Thread Tiejun Chen
Now we can introduce a new machine, xenigd, specific to IGD passthrough. This can avoid involving other common codes. Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c | 87 +++ 1 file changed, 87 insertions(+) diff --git a/hw/i386/pc_piix.c b/

[Qemu-devel] [PATCH 2/4] xen:hw:pci-host:piix: create host bridge to passthrough

2014-07-24 Thread Tiejun Chen
Implement that pci host bridge to specific to passthrough. Actually this just inherit the standard one. This is based on http://patchwork.ozlabs.org/patch/363810/. Signed-off-by: Tiejun Chen --- hw/pci-host/piix.c | 43 +++ 1 file changed, 43 insertions(+

Re: [Qemu-devel] [PULL for-2.1 0/2] vnc: fix two vnc update issues.

2014-07-24 Thread Peter Maydell
> Update version for v2.1.0-rc3 release (2014-07-22 18:17:03 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-vnc-20140724-1 > > for you to fetch changes up to 832932a6f17983a3167ae9da6f

Re: [Qemu-devel] [PULL for-2.1 0/1] usb: mtp: tag root property as experimental

2014-07-24 Thread Peter Maydell
On 23 July 2014 08:16, Gerd Hoffmann wrote: > Hi, > > Sorry, bad timing on my side. Patch sent out yesterday, through it > would be a good idea to leave at least one day for review, and now I've > missed -rc3 :( > > This patch renames the root property of the usb-mtp device to make clear > this

Re: [Qemu-devel] [PULL for-2.1 0/2] vnc: fix two vnc update issues.

2014-07-24 Thread Andreas Färber
please pull, >> Gerd >> >> The following changes since commit f368c33d5ab09dd5656924185cd975b11838cd25: >> >> Update version for v2.1.0-rc3 release (2014-07-22 18:17:03 +0100) >> >> are available in the git repository at: >> >> git://git.kraxel.org/qemu tags/pull-vnc-2

Re: [Qemu-devel] [PULL for-2.1 1/2] fix full frame updates for VNC clients

2014-07-24 Thread Andreas Färber
Stephan, Am 24.07.2014 10:28, schrieb Gerd Hoffmann: > From: Stephan Kulow > > If the client asks for !incremental frame updates, it has lost its content > so dirty doesn't matter - it has to see the full frame, so setting > force_update > Can you please sign off your (trivial) patch via repl

[Qemu-devel] [PATCH 0/4] image-fuzzer: Support L1/L2 tables in the qcow2 image generator

2014-07-24 Thread Maria Kustova
This patch series adds support of L1/L2 tables to the qcow2 image generator. Also it contains a fix of the test runner issue, when destructive commands under tests damage test images. This patch series was created for the 'block-next' branch and based on the next series: [PATCH V4 0/5] te

[Qemu-devel] [PATCH 1/4] docs: Expand the list of supported image elements with L1/L2 tables

2014-07-24 Thread Maria Kustova
Signed-off-by: Maria Kustova --- tests/image-fuzzer/docs/image-fuzzer.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/image-fuzzer/docs/image-fuzzer.txt b/tests/image-fuzzer/docs/image-fuzzer.txt index 2c4f346..08960ee 100644 --- a/tests/image-fuzzer/docs/image-fuzz

[Qemu-devel] [PATCH 4/4] layout: Add generators of L1/L2 tables

2014-07-24 Thread Maria Kustova
Valid L2 entries contain offsets to image clusters filled with random data. L2 entries have random positions inside L2 tables. L1 entries contain offsets to generated L2 tables and also have random positions inside the L1 table. Clusters for L1/L2 tables and random data are selected randomly. Sign

[Qemu-devel] [PATCH 2/4] runner: Make a copy of a test image for destructive test commands

2014-07-24 Thread Maria Kustova
Signed-off-by: Maria Kustova --- tests/image-fuzzer/runner/runner.py | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tests/image-fuzzer/runner/runner.py b/tests/image-fuzzer/runner/runner.py index 3e9e65d..6ec40a4 100755 --- a/tests/image-fuzzer/runner/runne

[Qemu-devel] [PATCH 3/4] fuzz: Add fuzzing functions for L1/L2 table entries

2014-07-24 Thread Maria Kustova
Signed-off-by: Maria Kustova --- tests/image-fuzzer/qcow2/fuzz.py | 28 1 file changed, 28 insertions(+) diff --git a/tests/image-fuzzer/qcow2/fuzz.py b/tests/image-fuzzer/qcow2/fuzz.py index ef9198f..178fef8 100644 --- a/tests/image-fuzzer/qcow2/fuzz.py +++ b/tests/

Re: [Qemu-devel] [PATCH 1/6] bootindex: add {del, modify}_boot_device_path function

2014-07-24 Thread Gonglei (Arei)
Hi, Gerd > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, July 24, 2014 6:09 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; afaer...@suse.de; ag...@suse.de; > stefa...@redhat.com; ak...@redhat.com; a...@ozlabs.ru; > alex.william...@redhat.com; a

Re: [Qemu-devel] [PATCH 5/7] hw/core/sysbus: add fdt_add_node method

2014-07-24 Thread Rob Herring
On Thu, Jul 24, 2014 at 6:25 AM, Alexander Graf wrote: > > On 24.07.14 09:36, Eric Auger wrote: >> >> On 07/24/2014 01:02 AM, Alexander Graf wrote: >>> >>> On 23.07.14 17:33, Eric Auger wrote: On 07/08/2014 03:52 PM, Alexander Graf wrote: > > On 07.07.14 09:08, Eric Auger wrote:

Re: [Qemu-devel] [PULL 3/5] serial: change retry logic to avoid concurrency

2014-07-24 Thread Pavel Hrdina
On 14.7.2014 17:49, Paolo Bonzini wrote: > From: Kirill Batuzov > > Whenever serial_xmit fails to transmit a byte it adds a watch that would > call it again when the "line" becomes ready. This results in a retry > chain: > serial_xmit -> add_watch -> serial_xmit > Each chain is able to transmit

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.2] spapr: add host Linux version information to device tree

2014-07-24 Thread Alexander Graf
On 18.07.14 06:31, cyril...@gmail.com wrote: It may prove useful know which Linux distribution version the host machine is running when an issue in the guest arises but a user cannot access the host. Signed-off-by: Cyril Bur --- hw/ppc/spapr.c | 8 +++ target-ppc/kvm.c | 62 +

Re: [Qemu-devel] [PATCH 1/6] bootindex: add {del, modify}_boot_device_path function

2014-07-24 Thread Gerd Hoffmann
Hi, > > Hmm. I think we should simply lookup the device and modify the > > bootindex, leaving the entry as-is otherwise. In case the new bootindex > > is already used by another device just throw an error. > > > If we just throw an error but not change the bootindex is already used, > we cann

Re: [Qemu-devel] [PATCH 2.1] PPC: KVM: Fix g3beige and mac99 when HV is loaded

2014-07-24 Thread Paolo Bonzini
Il 24/07/2014 10:52, Alexander Graf ha scritto: > On PPC we have 2 different styles of KVM: PR and HV. HV can only virtualize > sPAPR guests while PR can virtualize everything that's reasonably close to > the host hardware platform. > > As long as only one kernel module (PR or HV) is loaded, the "

Re: [Qemu-devel] [PATCH 2.1] PPC: KVM: Fix g3beige and mac99 when HV is loaded

2014-07-24 Thread Alexander Graf
On 24.07.14 15:44, Paolo Bonzini wrote: Il 24/07/2014 10:52, Alexander Graf ha scritto: On PPC we have 2 different styles of KVM: PR and HV. HV can only virtualize sPAPR guests while PR can virtualize everything that's reasonably close to the host hardware platform. As long as only one kernel

Re: [Qemu-devel] [PULL for-2.1 1/2] fix full frame updates for VNC clients

2014-07-24 Thread Andreas Färber
Am 24.07.2014 15:45, schrieb Stephan Kulow: > On 24.07.2014 14:30, Andreas Färber wrote: >> Am 24.07.2014 10:28, schrieb Gerd Hoffmann: >>> From: Stephan Kulow >>> >>> If the client asks for !incremental frame updates, it has lost its content >>> so dirty doesn't matter - it has to see the full fr

[Qemu-devel] [PATCH for-2.1] qemu-char: ignore flow control if a PTY's slave is not connected

2014-07-24 Thread Paolo Bonzini
After commit f702e62 (serial: change retry logic to avoid concurrency, 2014-07-11), guest boot hangs if the backend is an unconnected PTY. The reason is that PTYs do not support G_IO_HUP, and serial_xmit is never called. To fix this, simply invoke serial_xmit immediately (via g_idle_source_new) w

Re: [Qemu-devel] [PULL for-2.1 0/2] vnc: fix two vnc update issues.

2014-07-24 Thread Gerd Hoffmann
Hi, > > So are these *really* release critical bugs, if they've been > > only found in code review? We're really close to release now > > and so my preference is not to include changes unless they're > > really necessary... > > These are fixing openQA breakage (os-autoinst), In more detail: S

Re: [Qemu-devel] [PULL for-2.1 1/2] fix full frame updates for VNC clients

2014-07-24 Thread Stephan Kulow
On 24.07.2014 14:30, Andreas Färber wrote: > Stephan, > > Am 24.07.2014 10:28, schrieb Gerd Hoffmann: >> From: Stephan Kulow >> >> If the client asks for !incremental frame updates, it has lost its content >> so dirty doesn't matter - it has to see the full frame, so setting >> force_update >> >

Re: [Qemu-devel] [PULL 3/5] serial: change retry logic to avoid concurrency

2014-07-24 Thread Paolo Bonzini
Il 24/07/2014 14:57, Pavel Hrdina ha scritto: > On 14.7.2014 17:49, Paolo Bonzini wrote: >> From: Kirill Batuzov >> >> Whenever serial_xmit fails to transmit a byte it adds a watch that would >> call it again when the "line" becomes ready. This results in a retry >> chain: >> serial_xmit -> add_

Re: [Qemu-devel] [PATCH 2.1] PPC: KVM: Fix g3beige and mac99 when HV is loaded

2014-07-24 Thread Paolo Bonzini
Il 24/07/2014 15:54, Alexander Graf ha scritto: >>> >> Why should anything except pseries ever use HV KVM? > > Because there are no other Book3S machines :). And for BookE we don't > implement kvm_type != 0 because we only support either PR or HV > depending on the host platform. Yeah, what I mea

Re: [Qemu-devel] [PATCH 2.1] PPC: KVM: Fix g3beige and mac99 when HV is loaded

2014-07-24 Thread Alexander Graf
On 24.07.14 16:11, Paolo Bonzini wrote: Il 24/07/2014 15:54, Alexander Graf ha scritto: Why should anything except pseries ever use HV KVM? Because there are no other Book3S machines :). And for BookE we don't implement kvm_type != 0 because we only support either PR or HV depending on the hos

[Qemu-devel] [Bug 1348106] [NEW] kvm crash on Kali Linux

2014-07-24 Thread adam_von
Public bug reported: platform: DELL Vostro 2421 #uname -a Linux x-linux 3.14-kali1-686-pae #1 SMP Debian 3.14.4-1kali1 (2014-05-14) i686 GNU/Linux #kvm --version QEMU emulator version 1.1.2 (qemu-kvm-1.1.2+dfsg-6+deb7u3, Debian), Copyright (c) 2003-2008 Fabrice Bellard #qemu --version QEMU emu

[Qemu-devel] [PULL 5/5] docs: document missing VSERPORT_CHANGE event

2014-07-24 Thread Luiz Capitulino
From: Eric Blake The VSERPORT_CHANGE event was added in e2ae6159. The patch for this event was prepared at a time when this file was gone, even though it got applied immediately after dfab4892 restored this file. Duplicate the documentation into this file, so that anyone using this file instead

[Qemu-devel] [PULL 2/5] docs: split SPICE_* event docs

2014-07-24 Thread Luiz Capitulino
From: Eric Blake For consistency with the rest of this file, every event should be listed in isolation. Compare how commit 7cfadb6b split SPICE_CONNECTED and SPICE_DISCONNECTED into separate qmp events. * docs/qmp/qmp-events.txt (SPICE_CONNECTED, SPICE_DISCONNECTED): Split. Signed-off-by: Eric

[Qemu-devel] [PULL 4/5] docs: document missing POWERDOWN event

2014-07-24 Thread Luiz Capitulino
From: Eric Blake The POWERDOWN event was first documented in 0aab9ec3. But since dfab4892 later restored this file to the state prior to qmp events, and we never documented it in the past, anyone using this file instead of qapi will miss out on this event. Tweak the existing wording of SHUTDOWN

[Qemu-devel] [PULL 3/5] docs: document missing SPICE_MIGRATE_COMPLETED event

2014-07-24 Thread Luiz Capitulino
From: Eric Blake The SPICE_MIGRATE_COMPLETED event was first documented in 7cfadb6b. But since dfab4892 later restored this file to the state prior to qmp events, and we never documented it in the past, anyone using this file instead of qapi will miss out on this event. * docs/qmp/qmp-events.tx

[Qemu-devel] [PULL for-2.1 0/5] QMP queue

2014-07-24 Thread Luiz Capitulino
Doc fixes, zero regression risk for code. The following changes since commit a537d373b9f330853006ceb18d5891541b9e4030: Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20140723-1' into staging (2014-07-24 12:49:54 +0100) are available in the git repository at: git://repo.or.cz/q

[Qemu-devel] [PULL 1/5] docs: grammar fixes to qmp-events

2014-07-24 Thread Luiz Capitulino
From: Eric Blake When converting to qmp events, commits 7cfadb6b and a6330785 fixed some grammar as part of moving text between files. But since dfab4892 later restored this file to the state prior to qmp events, we have to do it again. * docs/qmp/qmp-events.txt (RESET, SPICE_INITIALIZED): Twea

Re: [Qemu-devel] [PULL for-2.1 0/2] vnc: fix two vnc update issues.

2014-07-24 Thread Peter Maydell
On 24 July 2014 15:10, Gerd Hoffmann wrote: > Hi, > >> > So are these *really* release critical bugs, if they've been >> > only found in code review? We're really close to release now >> > and so my preference is not to include changes unless they're >> > really necessary... >> >> These are fixi

Re: [Qemu-devel] [PATCH 2/2] pc: hack for migration compatibility from QEMU 2.0

2014-07-24 Thread Paolo Bonzini
Il 24/07/2014 10:59, Igor Mammedov ha scritto: > On Wed, 23 Jul 2014 18:37:46 +0200 > Paolo Bonzini wrote: > >> Changing the ACPI table size causes migration to break, and the memory >> hotplug work opened our eyes on how horribly we were breaking things in >> 2.0 already. >> >> The ACPI table si

[Qemu-devel] [PATCH v2 for-2.1 0/2] pc: fix /etc/acpi/tables size in fw_cfg for -M pc-i440fx-2.0

2014-07-24 Thread Paolo Bonzini
Addressing Laszlo and Igor's review points. Testing would be appreciated. :) Paolo Paolo Bonzini (2): acpi-dsdt: procedurally generate _PRT pc: hack for migration compatibility from QEMU 2.0 hw/i386/acpi-build.c| 71 +- hw/i386/acpi-dsdt.dsl | 90 +- hw/i386/acpi-

[Qemu-devel] [PATCH v2 for-2.1 2/2] pc: hack for migration compatibility from QEMU 2.0

2014-07-24 Thread Paolo Bonzini
Changing the ACPI table size causes migration to break, and the memory hotplug work opened our eyes on how horribly we were breaking things in 2.0 already. The ACPI table size is rounded to the next 4k, which one would think gives some headroom. In practice this is not the case, because the user

[Qemu-devel] [PATCH v2 for-2.1 1/2] acpi-dsdt: procedurally generate _PRT

2014-07-24 Thread Paolo Bonzini
This replaces the _PRT constant with a method that computes it. The problem is that the DSDT+SSDT have grown from 2.0 to 2.1, enough to cross the 8k barrier (we align the ACPI tables to 4k before putting them in fw_cfg). This causes problems with migration and the pc-i440fx-2.0 machine type. The

Re: [Qemu-devel] [PATCH 2.1] PPC: KVM: Fix g3beige and mac99 when HV is loaded

2014-07-24 Thread Paolo Bonzini
Il 24/07/2014 16:13, Alexander Graf ha scritto: > > On 24.07.14 16:11, Paolo Bonzini wrote: >> Il 24/07/2014 15:54, Alexander Graf ha scritto: Why should anything except pseries ever use HV KVM? >>> Because there are no other Book3S machines :). And for BookE we don't >>> implement kvm_type !

Re: [Qemu-devel] [PATCH 0/2] pc: fix /etc/acpi/tables size in fw_cfg for -M pc-2.0

2014-07-24 Thread Igor Mammedov
On Wed, 23 Jul 2014 18:37:44 +0200 Paolo Bonzini wrote: > Changing the ACPI table size causes migration to break, and the memory > hotplug work opened our eyes on how horribly we were breaking things in > 2.0 already. > > Unfortunately when reviewing the design I assumed incorrectly that all > t

Re: [Qemu-devel] [PATCH for-2.1] qemu-char: ignore flow control if a PTY's slave is not connected

2014-07-24 Thread Pavel Hrdina
On 24.7.2014 16:09, Paolo Bonzini wrote: > After commit f702e62 (serial: change retry logic to avoid concurrency, > 2014-07-11), guest boot hangs if the backend is an unconnected PTY. > > The reason is that PTYs do not support G_IO_HUP, and serial_xmit is > never called. To fix this, simply invok

[Qemu-devel] [RFC PATCH 0/3] target-arm: Some fixes to page and TLB handling

2014-07-24 Thread Alex Bennée
Hi, While doing some performance analysis on aarch64 system emulation I noticed a fairly high utilisation of cpu_arm_exec and the related find next TB machinery. Peter pointed it this is probably not helped by that fact TARGET_PAGE_BITS was set to 10 (1k pages) which would imply less chaining of T

[Qemu-devel] [PATCH 1/3] target-arm: don't hardcode mask values in arm_cpu_handle_mmu_fault

2014-07-24 Thread Alex Bennée
Otherwise we break quickly when we change TARGET_PAGE_SIZE. Signed-off-by: Alex Bennée diff --git a/target-arm/helper.c b/target-arm/helper.c index a0e57cd..aa5d267 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -4029,8 +4029,8 @@ int arm_cpu_handle_mmu_fault(CPUState *cs, vaddr a

[Qemu-devel] [PATCH 2/3] target-arm: A64: fix TLB flush instructions

2014-07-24 Thread Alex Bennée
According to the ARM ARM we weren't correctly flushing the TLB entries where bits 63:56 didn't match bit 55 of the virtual address. This exposed a problem when we switched QEMU's internal TARGET_PAGE_BITS to 12 for aarch64. Signed-off-by: Alex Bennée diff --git a/target-arm/helper.c b/target-arm

[Qemu-devel] [PATCH 3/3] target-arm: A64: fix use 12 bit page tables for aarch64

2014-07-24 Thread Alex Bennée
The aarch64 architecture only support 4k+ pages so using a smaller value for QEMU's internal page table handling only makes us less efficient. Signed-off-by: Alex Bennée diff --git a/target-arm/cpu.h b/target-arm/cpu.h index c83f249..33359b9 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @

[Qemu-devel] [PATCH for-2.1 v2] qemu-char: ignore flow control if a PTY's slave is not connected

2014-07-24 Thread Paolo Bonzini
After commit f702e62 (serial: change retry logic to avoid concurrency, 2014-07-11), guest boot hangs if the backend is an unconnected PTY. The reason is that PTYs do not support G_IO_HUP, and serial_xmit is never called. To fix this, simply invoke serial_xmit immediately (via g_idle_source_new) w

Re: [Qemu-devel] [PATCH 2/3] target-arm: A64: fix TLB flush instructions

2014-07-24 Thread Peter Maydell
On 24 July 2014 16:52, Alex Bennée wrote: > +/* See: D4.7.2 TLB maintenance requirements and the TLB maintenance > instructions > + * Page D4-1736 (DDI0487A.b) "For TLB maintenance instructions that > + * take an address, the maintenance of VA[63:56] is interpreted as > + * being the same as the

Re: [Qemu-devel] [PATCH 1/3] target-arm: don't hardcode mask values in arm_cpu_handle_mmu_fault

2014-07-24 Thread Peter Maydell
On 24 July 2014 16:52, Alex Bennée wrote: > Otherwise we break quickly when we change TARGET_PAGE_SIZE. > > Signed-off-by: Alex Bennée > > diff --git a/target-arm/helper.c b/target-arm/helper.c > index a0e57cd..aa5d267 100644 > --- a/target-arm/helper.c > +++ b/target-arm/helper.c > @@ -4029,8 +4

[Qemu-devel] [PATCH for-2.1] qemu-options: fix another allows-to for -net l2tpv3

2014-07-24 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- qemu-options.hx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 9e54686..1549625 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1437,7 +1437,7 @@ DEF("net", HAS_ARG, QEMU_OPTION_net, "-n

Re: [Qemu-devel] [PATCH 3/3] target-arm: A64: fix use 12 bit page tables for aarch64

2014-07-24 Thread Peter Maydell
On 24 July 2014 16:52, Alex Bennée wrote: > The aarch64 architecture only support 4k+ pages so using a smaller value > for QEMU's internal page table handling only makes us less efficient. > > Signed-off-by: Alex Bennée > > diff --git a/target-arm/cpu.h b/target-arm/cpu.h > index c83f249..33359b9

Re: [Qemu-devel] [PATCH v2 for-2.1 1/2] acpi-dsdt: procedurally generate _PRT

2014-07-24 Thread Laszlo Ersek
On 07/24/14 16:32, Paolo Bonzini wrote: > This replaces the _PRT constant with a method that computes it. > > The problem is that the DSDT+SSDT have grown from 2.0 to 2.1, > enough to cross the 8k barrier (we align the ACPI tables to 4k > before putting them in fw_cfg). This causes problems with

Re: [Qemu-devel] [RFC PATCH 0/3] target-arm: Some fixes to page and TLB handling

2014-07-24 Thread Peter Maydell
On 24 July 2014 16:52, Alex Bennée wrote: > I don't think this patch set is mergable as-is because we still > include a bunch of 32 bit ARM boards in the aarch64-softmmu build > which could be using an old enough ARM that has support for 1k page > tables (and may even use them?). We can certainly

Re: [Qemu-devel] [PULL for-2.1 0/5] QMP queue

2014-07-24 Thread Peter Maydell
On 24 July 2014 15:17, Luiz Capitulino wrote: > Doc fixes, zero regression risk for code. > > The following changes since commit a537d373b9f330853006ceb18d5891541b9e4030: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20140723-1' into > staging (2014-07-24 12:49:54 +0100) > > ar

Re: [Qemu-devel] KVM Forum 2014 Call for Participation (reminder)

2014-07-24 Thread Paolo Bonzini
The deadline is coming in three days! Paolo Il 16/06/2014 18:08, Paolo Bonzini ha scritto: > = > KVM Forum 2014: Call For Participation > October 14-16, 2014 - Congress Centre Düsseldorf - Düsseldorf, Germany > > (All submissions mu

Re: [Qemu-devel] [PATCH v2 for-2.1 2/2] pc: hack for migration compatibility from QEMU 2.0

2014-07-24 Thread Laszlo Ersek
On 07/24/14 16:32, Paolo Bonzini wrote: > Changing the ACPI table size causes migration to break, and the memory > hotplug work opened our eyes on how horribly we were breaking things in > 2.0 already. > > The ACPI table size is rounded to the next 4k, which one would think > gives some headroom.

Re: [Qemu-devel] [PATCH v2 for-2.1 2/2] pc: hack for migration compatibility from QEMU 2.0

2014-07-24 Thread Paolo Bonzini
Il 24/07/2014 18:29, Laszlo Ersek ha scritto: > I compared this too with its v1 counterpart, and it looks good. I have > one question (just curiosity): the following paragraph was dropped from > the commit message -- why? > > -Non-AML tables can change depending on the configuration (especially >

[Qemu-devel] [PATCH 0/3] libqtest: solve QEMU process cleanup problem

2014-07-24 Thread Stefan Hajnoczi
Test cases are supposed to clean up even if they fail. Historically libqtest has leaked QEMU processes and files. This caused annoyances and buildbot failures so it was gradually fixed. The solution we have for terminating the QEMU process if the test case fails was not very satisfactory. A SIG

[Qemu-devel] [PATCH 1/3] libqemustub: add qemu_system_shutdown_request() and no_shutdown

2014-07-24 Thread Stefan Hajnoczi
These sysemu functions will be needed by qemu-char.c, which is linked into tests/vhost-user-test without system emulation functionality. Signed-off-by: Stefan Hajnoczi --- stubs/Makefile.objs | 1 + stubs/shutdown.c| 7 +++ 2 files changed, 8 insertions(+) create mode 100644 stubs/shutd

[Qemu-devel] [PATCH 2/3] qemu-char: add -chardev exit-on-eof option

2014-07-24 Thread Stefan Hajnoczi
When QEMU is executed as part of a test case or from a script, it is usually desirable to exit if the parent process terminates. This ensures that "leaked" QEMU processes do not continue consuming resources after their parent has died. This patch adds the -chardev exit-on-eof option causing socke

[Qemu-devel] [PATCH 3/3] libqtest: use -chardev exit-on-eof to clean up QEMU

2014-07-24 Thread Stefan Hajnoczi
When the test case aborts it is important to terminate the QEMU process so it does not leak. This was implemented using a SIGABRT handler function in libqtest that sent SIGTERM to QEMU. The SIGABRT approach is messy because it requires a global signal handler but libqtest should support multiple

[Qemu-devel] AHCI bug

2014-07-24 Thread Zhang, Eniac
Hi all, I found a problem while using following combinations: qemu-1.6.1 + large disks (>127GB) + q35(AHCI controller) + int13h disk access. The AHCI controller code in Qemu has a bug that it will use the wrong LBA address when Seabios tries to access LBA>128GB (aka 127.5GB limit http://www.ha

Re: [Qemu-devel] [PATCH 1/3] libqemustub: add qemu_system_shutdown_request() and no_shutdown

2014-07-24 Thread Peter Maydell
On 24 July 2014 17:39, Stefan Hajnoczi wrote: > +++ b/stubs/shutdown.c > @@ -0,0 +1,7 @@ > +#include "sysemu/sysemu.h" > + > +int no_shutdown; > + > +void qemu_system_shutdown_request(void) > +{ > +} Tangential, but every use of "no_shutdown" outside vl.c is in the sequence: no_sh

Re: [Qemu-devel] [RFC PATCH v2 00/49] Series short description

2014-07-24 Thread Paolo Bonzini
Il 17/07/2014 13:01, Pavel Dovgalyuk ha scritto: > This set of patches is related to the reverse execution and deterministic > replay of qemu execution Our implementation of deterministic replay can > be used for deterministic and reverse debugging of guest code through gdb > remote interface.

Re: [Qemu-devel] [PATCH qom-next] machine: Clean up -machine handling

2014-07-24 Thread Marcel Apfelbaum
- Original Message - From: "Andreas Färber" To: qemu-devel@nongnu.org Cc: "marcel a" , "Andreas Färber" , "Paolo Bonzini" , "Anthony Liguori" Sent: Wednesday, July 23, 2014 5:32:11 PM Subject: [PATCH qom-next] machine: Clean up -machine handling Since commit c4090f8, -object options a

[Qemu-devel] [PATCH 1/7] tests: Functions bus_foreach and device_find from libqos virtio API

2014-07-24 Thread Marc Marí
Virtio header has been changed to compile and work with a real device. Functions bus_foreach and device_find have been implemented for PCI. Virtio-blk test case now opens a fake device. Signed-off-by: Marc Marí --- tests/Makefile|3 +- tests/libqos/virtio-pci.c | 75 +++

[Qemu-devel] [PATCH 3/7] libqtest: add QTEST_LOG for debugging qtest testcases

2014-07-24 Thread Marc Marí
Signed-off-by: Paolo Bonzini Signed-off-by: Marc Marí --- tests/libqtest.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 98e8f4b..056275d 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -167,11 +167,12 @@ QTest

[Qemu-devel] [PATCH 4/7] libqos: Correct mask to align size to PAGE_SIZE in malloc-pc

2014-07-24 Thread Marc Marí
Signed-off-by: Paolo Bonzini Signed-off-by: Marc Marí --- tests/libqos/malloc-pc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/malloc-pc.c b/tests/libqos/malloc-pc.c index db1496c..2efd095 100644 --- a/tests/libqos/malloc-pc.c +++ b/tests/libqos/malloc-pc.

[Qemu-devel] [PATCH 0/7] Virtio PCI libqos driver

2014-07-24 Thread Marc Marí
Add functions for virtio PCI libqos driver. Add more debugging tools. Solve bugs found while generating tests. Marc Marí (7): tests: Functions bus_foreach and device_find from libqos virtio API tests: Add virtio device initialization libqtest: add QTEST_LOG for debugging qtest testcases li

[Qemu-devel] [PATCH 5/7] libqos: Change free function called in malloc

2014-07-24 Thread Marc Marí
Signed-off-by: Marc Marí --- tests/libqos/malloc.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/malloc.h b/tests/libqos/malloc.h index 46f6000..5565381 100644 --- a/tests/libqos/malloc.h +++ b/tests/libqos/malloc.h @@ -32,7 +32,7 @@ static inline uint64_t gu

[Qemu-devel] [PATCH 2/7] tests: Add virtio device initialization

2014-07-24 Thread Marc Marí
Add functions to read and write virtio header fields. Add feature checking and status bit setting in virtio-blk-device. Signed-off-by: Marc Marí --- tests/Makefile|2 +- tests/libqos/virtio-pci.c | 32 tests/libqos/virtio-pci.h | 17 ++

[Qemu-devel] [PATCH 6/7] virtio-blk: Correct bug in support for flexible descriptor layout

2014-07-24 Thread Marc Marí
Without this correction, only a three descriptor layout is accepted, and requests with just two descriptors are not completed and no error message is displayed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Marc Marí --- hw/block/virtio-blk.c | 14 +++--- 1 file changed, 7 insertions(

[Qemu-devel] [PATCH 7/7] libqos: Added basic virtqueue support to virtio implementation

2014-07-24 Thread Marc Marí
Add status changing. Add basic virtqueue support for adding and sending virtqueue requests. Add ISR checking. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 86 - tests/libqos/virtio-pci.h |7 ++ tests/libqos/virtio.c | 89 ++

Re: [Qemu-devel] [PATCH 1/4] block/parallels: extend parallels format header with actual data values

2014-07-24 Thread Jeff Cody
On Tue, Jul 22, 2014 at 05:19:34PM +0400, Denis V. Lunev wrote: > Parallels image format has several additional fields inside: > - nb_sectors is actually 64 bit wide. Upper 32bits are not used for > images with signature "WithoutFreeSpace" and must be explicitely s/explicitely/explicitly > ze

Re: [Qemu-devel] [PATCH 2/4] block/parallels: replace tabs with spaces in block/parallels.c

2014-07-24 Thread Jeff Cody
On Tue, Jul 22, 2014 at 05:19:35PM +0400, Denis V. Lunev wrote: > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/block/parallels.c b/block/parallels.c > index c44

  1   2   >