Am 24.07.2014 13:48, schrieb Peter Maydell: > On 24 July 2014 09:28, Gerd Hoffmann <kra...@redhat.com> wrote: >> Hi, >> >> Here are two vnc update bugfixes, found by code review while hunting >> down a issue with vnc updates not being sent to the client. The >> original issue has not been root-caused yet, it is also not clear >> whenever qemu is at fault at all or whenever the vnc updates are >> stuck somewhere else (kernel network stack). The bugs found are >> for real nevertheless, and here are the fixes. >> >> please pull, >> Gerd >> >> The following changes since commit f368c33d5ab09dd5656924185cd975b11838cd25: >> >> Update version for v2.1.0-rc3 release (2014-07-22 18:17:03 +0100) >> >> are available in the git repository at: >> >> git://git.kraxel.org/qemu tags/pull-vnc-20140724-1 >> >> for you to fetch changes up to 832932a6f17983a3167ae9da6fe54a245a30758e: >> >> vnc update fix (2014-07-24 10:14:34 +0200) >> >> ---------------------------------------------------------------- >> vnc: fix two vnc update issues. >> >> ---------------------------------------------------------------- >> Gerd Hoffmann (1): >> vnc update fix >> >> Stephan Kulow (1): >> fix full frame updates for VNC clients >> >> ui/vnc.c | 5 ++++- >> ui/vnc.h | 1 + >> 2 files changed, 5 insertions(+), 1 deletion(-) > > So are these *really* release critical bugs, if they've been > only found in code review? We're really close to release now > and so my preference is not to include changes unless they're > really necessary...
These are fixing openQA breakage (os-autoinst), https://bugzilla.novell.com/show_bug.cgi?id=888142 so +1 to include them if Gerd is confident they don't regress otherwise. Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
