[Qemu-devel] [PULL 4/6] savevm: Remove all the unneeded version_minimum_id_old (rest)

2014-05-14 Thread Juan Quintela
After previous Peter patch, they are redundant. This way we don't assign them except when needed. Once there, there were lots of case where the ".fields" indentation was wrong: .fields = (VMStateField []) { and .fields = (VMStateField []) { Change all the combinations to: .

[Qemu-devel] [PULL 5/6] migration: show average throughput when migration finishes

2014-05-14 Thread Juan Quintela
From: Peter Lieven currently the value of the throughput field contains whatever was the last calculated throughput shortly before the migration finished. This patch updates the post migration contents of the field to the average throughput. Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonz

Re: [Qemu-devel] usb: usb tablet freeze when save/restore guest os

2014-05-14 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, May 14, 2014 6:26 PM > To: Gonglei (Arei); Gerd Hoffmann > Cc: qemu-devel@nongnu.org; Huangweidong (C); Michael S. Tsirkin > Subject: Re: usb: usb tablet freeze when save/restore guest os > > Il

Re: [Qemu-devel] [PATCH] iotests: Use configured python

2014-05-14 Thread Fam Zheng
On Thu, 05/15 01:41, Max Reitz wrote: > On 14.05.2014 14:33, Markus Armbruster wrote: > >Max Reitz writes: > > > >>Currently, QEMU's iotests rely on /usr/bin/env to start the correct > >>Python (that is, at least Python 2.4, but not 3). On systems where > >>Python 3 is the default, the user has no

Re: [Qemu-devel] [PULL 5/6] migration: show average throughput when migration finishes

2014-05-14 Thread Eric Blake
On 05/14/2014 07:40 PM, Juan Quintela wrote: > From: Peter Lieven > > currently the value of the throughput field contains whatever > was the last calculated throughput shortly before the migration > finished. > > This patch updates the post migration contents of the field to > the average throu

[Qemu-devel] [PULL 0/6] migration queue

2014-05-14 Thread Juan Quintela
Hi peter This pull request includes: - split ram_save_block into two functions (David) - simplify code for load_xbzrle (Chen) - fix usb tests (fix on top of previous fixes)) (mst) - calculate at time of printing throughput (peter) - cleanup rest & usb devices version_minimum_id_old (qunitela) Ple

[Qemu-devel] [PULL 2/6] Split ram_save_block

2014-05-14 Thread Juan Quintela
From: "Dr. David Alan Gilbert" ram_save_block is getting a bit too complicated, and does two separate things: 1) Finds a page to send 2) Sends the page (dealing with compression etc) Split into 'ram_save_page' to send the page and deal with compression (2) Rename remaining function to 'ram

[Qemu-devel] [PATCH 0/5] block: Modify block-commit to use node-names

2014-05-14 Thread Jeff Cody
Using node-names instead of filenames for block job operations over QMP is a superior method of identifying the block driver images to operate on, as it removes all pathname ambiguity. This series is the conversion of block-commit to allow use of node-names. Also, it allows the user to specify th

[Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-14 Thread Jeff Cody
Currently, node_name is only filled in when done so explicitly by the user. If no node_name is specified, then the node name field is not populated. If node_names are automatically generated when not specified, that means that all block job operations can be done by reference to the unique node_n

[Qemu-devel] [PATCH 5/5] block: extend block-commit to accept a string for the backing file

2014-05-14 Thread Jeff Cody
On some image chains, QEMU may not always be able to resolve the filenames properly, when updating the backing file of an image after a block commit. For instance, certain relative pathnames may fail, or drives may have been specified originally by file descriptor (e.g. /dev/fd/???), or a relative

[Qemu-devel] [PATCH 2/5] block: add helper function to determine if a BDS is in a chain

2014-05-14 Thread Jeff Cody
This is a small helper function, to determine if 'base' is in the chain of BlockDriverState 'top'. It returns true if it is in the chain, and false otherwise. If either argument is NULL, it will also return false. Signed-off-by: Jeff Cody --- block.c | 9 + include/block/

[Qemu-devel] [PATCH 4/5] block: Accept node-name arguments for block-commit

2014-05-14 Thread Jeff Cody
This modifies the block operation block-commit so that it will accept node-name arguments for either 'top' or 'base' BDS. The filename and node-name are mutually exclusive to each other; i.e.: "top" and "top-node-name" are mutually exclusive (enforced) "base" and "base-node-name" are mutua

[Qemu-devel] [PATCH 3/5] block: make 'top' argument to block-commit optional

2014-05-14 Thread Jeff Cody
Now that active layer block-commit is supported, the 'top' argument no longer needs to be mandatory. Change it optional, with the default being the active layer in the device chain. Signed-off-by: Jeff Cody --- blockdev.c | 3 ++- qapi-schema.json | 7 --- qmp-commands.h

Re: [Qemu-devel] [PATCH v3] vmdk: Optimize cluster allocation

2014-05-14 Thread Fam Zheng
On Wed, 05/14 16:23, Kevin Wolf wrote: > Am 08.05.2014 um 07:57 hat Fam Zheng geschrieben: > > This drops the unnecessary bdrv_truncate() from, and also improves, > > cluster allocation code path. > > [...] > > > > Tested that this passes qemu-iotests for all VMDK subformats. > > > > Signed-off-b

Re: [Qemu-devel] [PATCHv4] block: optimize zero writes with bdrv_write_zeroes

2014-05-14 Thread Peter Lieven
Am 14.05.2014 13:41, schrieb Kevin Wolf: > Am 08.05.2014 um 18:22 hat Peter Lieven geschrieben: >> this patch tries to optimize zero write requests >> by automatically using bdrv_write_zeroes if it is >> supported by the format. >> >> This significantly speeds up file system initialization and >> s

[Qemu-devel] Qemu stucking

2014-05-14 Thread sonia verma
Hi I'm getting below error when trying to boot the KVM with ethernet bridging,kvm support and universel TUN enabled by the following command.. /usr/bin/qemu-system-ppc64 -m 512 -nographic -hda /var/volatile/debian_lenny_ powerpc_standard.qcow2 cannot manage 'OHCI USB controller' PCI device type

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Amit Shah
On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > There is a need to add some more fields to VirtIODevice that should be > migrated (broken status, endianness). The problem is that we do not > want to break compatibility while adding a new feature... This issue has > been addressed in the generic

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > There is a need to add some more fields to VirtIODevice that should be > > migrated (broken status, endianness). The problem is that we do not > > want to break compatibility while add

[Qemu-devel] pidfile option in config file

2014-05-14 Thread William Dauchy
Hello, I'm using the `-pidfile` option in my qemu command line. Since I'm also using the `-readconfig` option I thought it was a good thing to include the pidfile option in my config file. Unfortunately I did not found any possibility to add such option in my config file. Is it something I could e

Re: [Qemu-devel] [PATCH] SMI handler should set the CPL to zero and save and restore it on rsm.

2014-05-14 Thread Paolo Bonzini
Il 15/05/2014 03:32, Kevin O'Connor ha scritto: On Wed, May 14, 2014 at 08:20:59PM -0400, Kevin O'Connor wrote: On Wed, May 14, 2014 at 10:05:47AM +0200, Paolo Bonzini wrote: CPL isn't even altered when CS is reloaded, because you cannot jump out of ring-0 except with an inter-privilege IRET, a

Re: [Qemu-devel] [PATCH v3] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-05-14 Thread Michael S. Tsirkin
On Thu, Feb 27, 2014 at 02:05:05AM +0100, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan > --- This looks sane, a minor comment below (hopefully last). Thanks! > v2: resubmission after pc-2.1 is added with the multiport case > v3: added compatibility check to avoid changing earlier tha

Re: [Qemu-devel] [PATCH v3] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-05-14 Thread Gerd Hoffmann
On Do, 2014-02-27 at 02:05 +0100, BALATON Zoltan wrote: ^^ Looks like your clock is _way_ off. > +if (!pci->compat) { > +pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */ > +} > static Property serial_pci_properties[] = { > DEFINE_PROP_CHR("charde

Re: [Qemu-devel] [PATCH v3] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-05-14 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 08:42:17AM +0200, Gerd Hoffmann wrote: > On Do, 2014-02-27 at 02:05 +0100, BALATON Zoltan wrote: >^^ > Looks like your clock is _way_ off. > > > +if (!pci->compat) { > > +pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */ > > +} >

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Amit Shah
On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: > On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: > > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > > There is a need to add some more fields to VirtIODevice that should be > > > migrated (broken status, endianness). The

Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration

2014-05-14 Thread Gonglei (Arei)
> -Original Message- > From: Michael R. Hines [mailto:mrhi...@linux.vnet.ibm.com] > Sent: Thursday, May 15, 2014 8:44 AM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); quint...@redhat.com; dgilb...@redhat.com; > owass...@redhat.com; mrhi...@us.ibm.com; pbonz...@redhat.c

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Greg Kurz
On Thu, 15 May 2014 11:34:25 +0530 Amit Shah wrote: > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > There is a need to add some more fields to VirtIODevice that should be > > migrated (broken status, endianness). The problem is that we do not > > want to break compatibility while adding a

Re: [Qemu-devel] usb: usb tablet freeze when save/restore guest os

2014-05-14 Thread Gerd Hoffmann
Hi, > Well then, may I post a formal patch for this issue, Gerd? Thanks. I'd like to know what the root cause for the lost interrupt is. Not implementing PIRQ enable could be it, especially as the guest os seems to use it (otherwise your patch would have no effect). The check for the PIRQ ena

Re: [Qemu-devel] [PATCH] iotests: Use configured python

2014-05-14 Thread Markus Armbruster
Max Reitz writes: > On 14.05.2014 14:33, Markus Armbruster wrote: >> Max Reitz writes: >> >>> Currently, QEMU's iotests rely on /usr/bin/env to start the correct >>> Python (that is, at least Python 2.4, but not 3). On systems where >>> Python 3 is the default, the user has no clean way of makin

Re: [Qemu-devel] [PATCH v3] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-05-14 Thread Gerd Hoffmann
> > > static Property serial_pci_properties[] = { > > > DEFINE_PROP_CHR("chardev", PCISerialState, state.chr), > > > +DEFINE_PROP_UINT8("compat", PCISerialState, compat, 0), > > > DEFINE_PROP_END_OF_LIST(), > > > }; > > > > mst, do you take that through the pci tree? > > > > che

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Amit Shah
On (Thu) 15 May 2014 [08:49:48], Greg Kurz wrote: > On Thu, 15 May 2014 11:34:25 +0530 > Amit Shah wrote: > > > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > > There is a need to add some more fields to VirtIODevice that should be > > > migrated (broken status, endianness). The problem is

<    1   2   3   4